[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

--- Comment #194 from Marcel de Rooy  ---
+my $published_on_dt = output_pref({ dt => dt_from_string(
$all->{pubished_on} ), dateonly => 1 });

Will amend the patch now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

--- Comment #193 from Marcel de Rooy  ---
Subject: [PATCH 18/20] Bug 22544: Fix OpacLoginInstructions

What does this patch actually fix ?

-[% IF ( OpacLoginInstructions ) %]
+[% IF OpacLoginInstructions %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426

--- Comment #8 from Jonathan Druart  ---
It could be nice to provide a test first :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427

--- Comment #40 from Jonathan Druart  ---
(In reply to David Cook from comment #39)
> (In reply to David Cook from comment #38)
> > (In reply to Jonathan Druart from comment #34)
> > > And, FWIW, if I move the YAML::XS serializer (see last patch) in the
> > > Data/Session/Serialize directory, all tests pass (longblob).
> > 
> > Wait this works despite
> > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427#c29 ?
> 
> Oh maybe I misunderstand what you're saying... you meant in the vendor perl
> not the Koha perl lib... right?

Yes, I copied it to /path/Data/Session/Serialize/yamlxs.pm where
/path/Data/Session/ is `pmpath Data::Session`.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

--- Comment #192 from Marcel de Rooy  ---
+[% opac_new.timestamp | $KohaDates %]

We removed timestamp from opac_news on bug 21066. Familiar author?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|k...@bywatersolutions.com   |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #191 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #354 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #353)
> (In reply to David Cook from comment #351)
> > I can't guarantee that my last patches actually apply on master
> 
> Indeed lol :P
> 
> > Patch failed at 0001 Bug 15516: Add ability to create hold groups from OPAC

I can look at fixing that in early July I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519

--- Comment #37 from David Cook  ---
(In reply to Jonathan Druart from comment #34)
> But it needs to be top priority for you.

Fair enough. I have very little to give to Koha at the moment...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427

--- Comment #39 from David Cook  ---
(In reply to David Cook from comment #38)
> (In reply to Jonathan Druart from comment #34)
> > And, FWIW, if I move the YAML::XS serializer (see last patch) in the
> > Data/Session/Serialize directory, all tests pass (longblob).
> 
> Wait this works despite
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427#c29 ?

Oh maybe I misunderstand what you're saying... you meant in the vendor perl not
the Koha perl lib... right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427

--- Comment #38 from David Cook  ---
(In reply to Jonathan Druart from comment #34)
> And, FWIW, if I move the YAML::XS serializer (see last patch) in the
> Data/Session/Serialize directory, all tests pass (longblob).

Wait this works despite
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427#c29 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519

--- Comment #36 from David Cook  ---
(In reply to Julian Maurice from comment #33)
> But using Plack::Middleware::Session would prevent using koha with
> mojolicious servers like morbo or hypnotoad, right ?

Probably

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426

--- Comment #7 from David Cook  ---
(In reply to Jonathan Druart from comment #6)
> (In reply to David Cook from comment #3)
> > Btw, we can't use ABS() here because it interprets exponents. For instance,
> > "select abs(978e0143019375)" will actually create an error or "Inf" if it's
> > already stored in a database column.
> 
> How do we process then, David? The patch here has test to prove it is
> working. I can base it on top of yours, but you need to do what's needed to
> remove its FQA status.

Do you mean for Bug 26328? That tester never responded to my questions. I could
re-test it myself, but it could be good to get someone new to test too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575

Benjamin Daeuber  changed:

   What|Removed |Added

 CC||bdaeu...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28575] Add ability to choose if lost fee is refunded based on when lost fee was paid off

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28575

Cheryl  changed:

   What|Removed |Added

 CC||clack...@fargolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry  ---
+1 on this. Currently on needs to follow a needlessly cumbersome chain of links
from the basket to the bib to the invoice. There's no reason not to make that
easier. I'm in favor of either of Katrin's options (a new column or a link off
of the "received" note).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28449] Link from basket summary to invoice for an order line

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28449

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #1 from Andrew Fuerste-Henry  ---
*** Bug 14090 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14090] Add link to basket from invoice and vice versa

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14090

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||and...@bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry  ---


*** This bug has been marked as a duplicate of bug 28449 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not yet listed in the about page.

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.07,20.05.13  |21.05.00,20.11.07
released in||

--- Comment #12 from Victor Grousset/tuxayo  ---
Nice catch, thanks. It's indeed string freeze.
Reverted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523

Owen Leonard  changed:

   What|Removed |Added

 Attachment #122037|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 122395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122395&action=edit
Bug 28523: Escape 'rank' in bor_issues_top.pl

It's a MySQL 8 keyword

Test plan:
Turn off strict_sql_modes (there are other problems in this script)
Hit Home Reports > Patrons with the most checkouts
Submit the form

Without this patch you got:
You have an error in your SQL syntax; check the manual that
corresponds to your MySQL server version for the right syntax to
use near 'RANK, borrowers.borrowernumber AS ID FROM `old_issues`

With this patch applied you see the report result view

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524

Owen Leonard  changed:

   What|Removed |Added

 Attachment #122036|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 122394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122394&action=edit
Bug 28524: Escape 'rank' in cat_issues_top.pl

It's a MySQL 8 keyword

Test plan:
Turn off strict_sql_modes (there are other problems in this script)
Hit Home Reports > Most-circulated items
Submit the form

Without this patch you got:
  You have an error in your SQL syntax; check the manual that
  corresponds to your MySQL server version for the right syntax to use
  near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM,
  ccode as CCODE, loca' at line 1

With this patch applied you see the report result view

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Alex Arnaud  ---
Bug 18017 solved this for 20.11.06 but not backported. Wish this for 20.05 and
19.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628

--- Comment #1 from Alex Arnaud  ---
Created attachment 122393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122393&action=edit
Bug 28628: Make heading search form match related indexed heading

Test plan (UNIMARC exemple):
  - create a biblio with the following data in tag 700:
- $a Vidard
- $b Mathieu
- $d 1971-...
  - save.
  => a new authority is created with the following heading "Vidard
Mathieu 1971-.."
  - create an other biblio with the same value in tag 700.
  => again a new authority is created with the same heading.
  - apply this patch and repeat the test plan
  - The 2nd 700 tag should map to the same authority.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

David Nind  changed:

   What|Removed |Added

 Attachment #122355|0   |1
is obsolete||

--- Comment #23 from David Nind  ---
Created attachment 122392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122392&action=edit
Bug 15156: Get all patrons with owings

This patch adds method to return set of unique patrons with
accountlines matching filtering params.

To test:
prove t/db_dependent/Koha/Patrons.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #7 from Andrew Fuerste-Henry  ---
That did it, thanks! Apologies for not thinking to do that first.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #17 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #11)
> We start here with Checked out until On hold.
> Not sure if we should do exactly the same for the remaining
> not for loan categories.

Note that the last patch now fills that gap.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #16 from Marcel de Rooy  ---
Created attachment 122391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122391&action=edit
Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too

Test plan:
Add some not for loan categories, add some items for them.
Check search results. Verify that results match expectation.

Signed-off-by: Marcel de Rooy 
Tested the combination of pref values for results 2/1 with NFL categories TEST,
MOVING:
Availability: Items available for loan: Centerville (3) [Call number: PERL
A 2, PERL A 3, ...] Items available for reference: Centerville Staff Collection
(1) [Call number: PERL A 10]. Not available: TEST (2) [ PERL A 11, .. ]. MOVING
(1) [ PERL A 13 ]. Withdrawn (2) [ PERL A 5, .. ]. Damaged (3) [ PERL A 7, ..
].

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628

Alex Arnaud  changed:

   What|Removed |Added

Version|19.11   |20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28624] Smart::Comments not used and not installed

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28624

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from David Nind  ---
Patch no longer applies 8-(...

Looks like members/printslip.pl is already fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523

--- Comment #4 from David Nind  ---
Thanks Jonathan!

I can now get this to work with MySQL 8 (ku-my8).

With the patch applied in master with MariaDB (ku), I need to turn off strict
mode to get this to work. Is that what is expected, or is another bug going to
fix this?

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28616] Remove Data::Printer dependency

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00,20.05.01
released in||

--- Comment #6 from Kyle M Hall  ---
Pushed to 21.05.x for 20.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28611] Incorrect Select2 width

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611

Owen Leonard  changed:

   What|Removed |Added

 Attachment #122276|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 122390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122390&action=edit
Bug 28611: Fix width to 50% for additem form elements

This patch suggests to set the width of select and input to 50%

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28611] Incorrect Select2 width

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28386] Replace dev_map.yaml from release_tools with .mailmap

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28386

--- Comment #49 from Victor Grousset/tuxayo  ---
Yes, in bug 28442 it's mentioned that it will have to be backported to all
stables. And this one it a dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28442] Release team 21.11

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28442

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|21.05.00,20.11.07,20.05.13  |21.05.00,20.11.07
released in||

--- Comment #21 from Victor Grousset/tuxayo  ---
You are right! Nice catch, thanks. It's indeed string freeze.
Reverted.

Yesterday I even though about paying attention to that. But happily forgot it
when actually backporting stuff ^^"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614

--- Comment #6 from Jonathan Druart  ---
Update ktd and pull the latest docker images.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #15 from Marcel de Rooy  ---
Created attachment 122389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122389&action=edit
Bug 26302: Add dbrev for two new prefs

Formalizing the local prefs introduced in the former patches:
resultsMaxItems
resultsMaxItemsUnavailable

Test plan:
Check Preferences/OPAC/Appearance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #119111|0   |1
is obsolete||

--- Comment #14 from Marcel de Rooy  ---
Created attachment 122388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122388&action=edit
Bug 26302: Use resultsMaxItemsUnavailable in stylesheet

We start here with Checked out until On hold.
Not sure if we should do exactly the same for the remaining
not for loan categories.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #119109|0   |1
is obsolete||

--- Comment #13 from Marcel de Rooy  ---
Created attachment 122387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122387&action=edit
Bug 26302: Add syspref resultsMaxItemsUnavailable

This is the number of call numbers displayed for unavailable
categories in the results XSLT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #119108|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 122386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122386&action=edit
Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers

We define a local preference resultsMaxItems and add it to the xml
passed to the results XSLT (in C4::XSLT).
Instead of showing one item, we add this number of items for the
available for loan and reference segments.

Test plan:
Play with the value of local pref resultsMaxItems.
Check if it matches with displayed callnumbers.
Try home and holdingbranch for results location.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614

--- Comment #5 from Lucas Gass  ---
I am seeing this error in the intranet-error.log:


[Thu Jun 24 13:42:19.781481 2021] [cgi:error] [pid 35597] [client
172.19.0.1:64816] AH01215: new(): failed: couldn't load
CGI::Session::Serialize::yamlxs: Can't locate CGI/Session/Serialize/yamlxs.pm
in @INC (you may need to install the CGI::Session::Serialize::yamlxs module)
(@INC contains: /kohadevbox/koha /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/var/lib/koha/kohadev/plugins) at (eval 1661) line 2.:
/kohadevbox/koha/tools/stage-marc-import.pl

[Thu Jun 24 13:42:19.823176 2021] [cgi:error] [pid 35597] [client
172.19.0.1:64816] End of script output before headers: stage-marc-import.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #43 from Martin Renvoize  ---
(In reply to Marcel de Rooy from comment #25)
> Note for QA:
> 
> Should we try to update existing notices here too ?

No we have logs for notices changes, we could theoretically try.. but I don't
see that as a blocker for this either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628

Alex Arnaud  changed:

   What|Removed |Added

Version|master  |19.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614

--- Comment #4 from Lucas Gass  ---
I am also able to recreate this in master, same 500 error as Andrew. These
pages seem to be the ones effected:


"/cgi-bin/koha/offline_circ/process_koc.pl" 
"/cgi-bin/koha/tools/background-job-progress.pl" 
"/cgi-bin/koha/tools/export.pl"
"/cgi-bin/koha/tools/manage-marc-import.pl" 
"/cgi-bin/koha/tools/stage-marc-import.pl" 
"/cgi-bin/koha/tools/upload-cover-image.pl"
"/cgi-bin/koha/svc/cataloguing/metasearch" 


These files are all listed in apache-shared-intranet-plack.conf with the
comment:

# FIXME: These scripts should be fixed so they
# don't break under plack/starman


Perhaps related?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28628] New: Elasticsearch - Heading search form does'nt match related indexed heading

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628

Bug ID: 28628
   Summary: Elasticsearch - Heading search form does'nt match
related indexed heading
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com

When an authority is created using LinkBibHeadingsToAuthorities
the heading created "700 $aVidard $bMathieu $f1971-..." (unimarc)
is saved as "Vidard Mathieu 1971-..", indexed as "Vidard Mathieu 1971-.."
and searched as "Vidard Mathieu 1971" => no match.

So the link bib does'nt work.

Test plan (UNIMARC exemple):
  - create a biblio with the following data in tag 700:
- $a Vidard
- $b Mathieu
- $d 1971-...
  - save.
  => a new authority is created with the following heading "Vidard Mathieu
1971-.."
  - create an other biblio with the same value in tag 700.
  => again a new authority is created with the same heading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614

--- Comment #3 from Jonathan Druart  ---
Anything relevant in the Koha log files?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction'

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
Version|20.11   |unspecified
 CC||jonathan.druart+koha@gmail.
   ||com
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

--- Comment #2 from Jonathan Druart  ---
Hi Julien, I am not familiar with the script so hard to fully test it, but this
patch should remove the error you got. Can you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already in a transaction'

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399

--- Comment #1 from Jonathan Druart  ---
Created attachment 122385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122385&action=edit
Bug 28399: Remove txn error from batchRebuildItemsTables.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615

--- Comment #19 from Jonathan Druart  ---
The following line:
  t::lib::Mocks::mock_logger({ warn => 1 });

needs to be:
  my $m = t::lib::Mocks::mock_logger({ warn => 1 });

Or the module won't be mocked correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196

David Nind  changed:

   What|Removed |Added

 Attachment #122352|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 122384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122384&action=edit
Bug 28196: make sure URL hash is appended last

TO test:
1 Do a search within the staff client
2 Click on any results and go to the detail page
3 Click the edit button on any item in that record, it should take you to a URL
like this:
'/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=55&itemnumber=117#edititem&searchid=scs_1619109565224'
4 Apply patch
5 Do steps 1 & 2 again
Click the edit button on any item in that record, it should take you to a URL
like this:
'/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=55&itemnum   
ber=117&searchid=scs_1619109565224#edititem'
6. If they URL hash is last the anchor should work and you'll be placed on the
h2 element with and ID of edititem

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614

--- Comment #2 from Andrew Fuerste-Henry  ---
Huh. I'm on Koha Testing Docker, running master, on Chrome.

When I click the Stage MARC Records for Import link in Tools it tries to load
this url: http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl. After
a couple seconds I get an error page that says:

An error has occurred!
Error 500
This message may have been caused by any of the following reasons:
You made use of an external link to an item that is no longer available
You followed an outdated link e.g. from a search engine or a bookmark
You tried to access a page that needs authentication
An internal link in the client is broken and the page does not exist

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #42 from Marcel de Rooy  ---
Created attachment 122383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122383&action=edit
Bug 20472: [DO NOT PUSH] DBIx schema changes

Refreshed 24-06-21

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #122379|0   |1
is obsolete||

--- Comment #41 from Marcel de Rooy  ---
Created attachment 122382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122382&action=edit
Bug 20472: (QA follow-up) Add few TT filters

Signed-off-by: Marcel de Rooy 
No more warns from qa tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615

--- Comment #18 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #17)
> Since bug 28606 t/Auth_with_shibboleth.t is failing
> 
> 12:06:13 koha_1   | Log::Log4perl configuration looks suspicious: No
> loggers defined at /usr/share/perl5/Log/Log4perl/Config.pm line 325.

Tests in t/ should not depend on a setup (i.e. should be mocked).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615

--- Comment #17 from Jonathan Druart  ---
Since bug 28606 t/Auth_with_shibboleth.t is failing

12:06:13 koha_1   | Log::Log4perl configuration looks suspicious: No
loggers defined at /usr/share/perl5/Log/Log4perl/Config.pm line 325.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #16 from Jonathan Druart  ---
t/Auth_with_shibboleth.t is failing

12:06:13 koha_1   | Log::Log4perl configuration looks suspicious: No
loggers defined at /usr/share/perl5/Log/Log4perl/Config.pm line 325.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28585] Cannot search on date fields

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585

--- Comment #6 from Jonathan Druart  ---
Tomas, looks like this could be a fix. Do you see something else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28585] Cannot search on date fields

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585

--- Comment #5 from Jonathan Druart  ---
Created attachment 122381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122381&action=edit
Bug 28585: Fix search on date field

We should not rfc3339 format the date if it's not a datetime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28585] Cannot search on date fields

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585

Jonathan Druart  changed:

   What|Removed |Added

Summary|Bug in GET /patrons by  |Cannot search on date
   |date_of_birth   |fields
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
   Severity|normal  |major
Version|21.05   |unspecified
 CC||jonathan.druart+koha@gmail.
   ||com
 Status|NEW |ASSIGNED

--- Comment #4 from Jonathan Druart  ---
DBIC is receiving
dateofbirth   {
like   "%1980-04-24T00:00:00%"  
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627

--- Comment #1 from Alex Buckley  ---
Created attachment 122380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122380&action=edit
Bug 28627: Fallback to displaying ecost_tax_included, ecost_tax_excluded in
orderreceive.pl

Test plan:
1. Create a basket and adding items to it. Set the 'Vendor price' to
'20', do not add an 'Actual cost'
2. Close the basket
3. Select 'Receive shipment'
4. Set a value for vendor invoice
5. Receive the order you created
6. Observe 'Actual cost' is = 0.00
7. Apply patch
8. Refresh the order receival page, and confirm the 'Actual cost' =
20.00

Sponsored-By: South Taranaki District Council, NZ

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28614] 500 error on Stage MARC records for import, Staged MARC record management, Upload local cover image

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28614

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
It works for me, which error do you get?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28623] Fails to connect to server do not get response

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28623

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||jonathan.druart+koha@gmail.
   ||com
 Status|NEW |RESOLVED

--- Comment #2 from Jonathan Druart  ---
This is a support question, please ask the mailing list.

https://koha-community.org/support/koha-mailing-lists/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28627] New: Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627

Bug ID: 28627
   Summary: Revert the order receive page to display 'Actual cost'
as ecost_tax_included/ecost_tax_excluded if unitprice
not set
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Currently, the order receive page (orderreceive.tt) displays
unitprice_tax_included/unitprice_tax_excluded in the 'Actual cost' field.
However, if the user has not set a unitprice previously in the acquisitions
workflow then the 'Actual cost' is displayed with a value of 0.000

In Koha 20.05.x the 'Actual cost' was displayed as
ecost_tax_included/ecost_tax_excluded if unitprice was not defined.

Like in Bug 25750 , Koha should fallback to using ecost_tax_included and
ecost_tax_excluded if unitprice is not defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #40 from Martin Renvoize  ---
This works really nicely and the code is nice and clean.. Signing off.

However.. QA script highlights some missing filters.. a quick follow-up should
resolve those ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122372|0   |1
is obsolete||

--- Comment #39 from Martin Renvoize  ---
Created attachment 122379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122379&action=edit
Bug 20472: [DO NOT PUSH] DBIx schema changes

Refreshed 24-06-21

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122371|0   |1
is obsolete||

--- Comment #38 from Martin Renvoize  ---
Created attachment 122378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122378&action=edit
Bug 20472: Update translated AR notices

Originally, we had:
de-DE/mandatory/sample_notices.sql
fr-CA/obligatoire/sample_notices.sql
fr-FR/1-Obligatoire/sample_notices.sql
it-IT/necessari/notices.sql
nb-NO/1-Obligatorisk/sample_notices.sql
pl-PL/mandatory/sample_notices.sql
ru-RU/mandatory/sample_notices.sql
uk-UA/mandatory/sample_notices.sql

Obviously, the landscape changed in the meantime.
We still have: fr-CA, fr-FR, nb-NO.

Test plan:
Reinstall notices for one of the languages above.

Signed-off-by: Marcel de Rooy 
Have run all sql files thru mysql on the command line.
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122370|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 122377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122377&action=edit
Bug 20472: Add format to sample notices

NOTE: We are only changing English here. A follow-up will care for
the translated languages. (English is in yml format, the remainder
not yet.)

We need to change the following notices:
AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED.
In AR_COMPLETED the last sentence about picking up has been modified
too.

Test plan:
Reinstall Koha. Choose English. Check notice text.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122369|0   |1
is obsolete||

--- Comment #36 from Martin Renvoize  ---
Created attachment 122376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122376&action=edit
Bug 20472: Edit URL field on staff form

This patch makes the following changes:

Add menu option Edit URLs.
Edit modal form to edit URLs.
Save URLs via ajax call to svc/article_request (Add action update_urls).
Add URL column to pending and processing table.
Allow Edit URLs for pending table too (just as Complete).
Do not allow 'Complete request' if a scan request has no URL(s).

Test plan:
[1] Add a few scan and photocopy requests.
[2] Fill url-A and url-B in two separate scan requests.
[3] Verify that these two urls are really saved (refresh form).
[4] Check that you cannot complete a scan request without URL and that you
cannot add a URL to a photocopy request.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122368|0   |1
is obsolete||

--- Comment #35 from Martin Renvoize  ---
Created attachment 122375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122375&action=edit
Bug 20472: Add format field to the interface

We need to add the format to the forms entering new requests:
  opac/opac-request-article
  circ/request-article
If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed
format will be preselected on the request form. If there is only one option,
we should not disable the select however. (Possibly hide it.)

If we have no mandatory fields, we should not allow the submit of a complete
empty form (check on OPAC).

And we need to show the format of pending requests on forms:
  opac/opac-user
  circ/request-article (biblio detail tab)
  circ/article-requests (staff form to handle requests)
  members/moremember (Article requests tab at the bottom)
  circ/circulation (Checkout/Article requests tab)
Note: The last two forms use the same include file.

Test plan:
[1] Add an article request via opac or staff. Choose Scan.
[2] Verify that you see the Scan format on opac-user and the
above-mentioned staff forms.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122367|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 122374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122374&action=edit
Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats

This preference controls which formats are actually offered to patrons of
the library via the Article Request feature.
By default, it only contains PHOTOCOPY. This is default behavior.

The request format SCAN will be made possible by this report and can be
added by changing the preference.

Test plan:
Run the dbrev. Check the new pref on Administration.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122366|0   |1
is obsolete||

--- Comment #33 from Martin Renvoize  ---
Created attachment 122373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122373&action=edit
Bug 20472: Add new fields article_requests.format and urls

The field 'format' will allow to make a distinction between requests for
photocopies and digital scans.
The field 'urls' will be used to save the URLs that allow the client to
download the scanned materials.

Test plan:
Run new install or upgrade existing install with atomic update.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606

--- Comment #15 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601

--- Comment #4 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28600] Variable "$patron" is not available

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600

--- Comment #5 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28600] Variable "$patron" is not available

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571

--- Comment #4 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search?

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622

Jonathan Druart  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
   ||, katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20310] Article requests: Can we redirect article records without items to host record?

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310

--- Comment #50 from Marcel de Rooy  ---
HELP Who wants to assist in getting this fURTHER ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #32 from Marcel de Rooy  ---
Created attachment 122372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122372&action=edit
Bug 20472: [DO NOT PUSH] DBIx schema changes

Refreshed 24-06-21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #31 from Marcel de Rooy  ---
Created attachment 122371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122371&action=edit
Bug 20472: Update translated AR notices

Originally, we had:
de-DE/mandatory/sample_notices.sql
fr-CA/obligatoire/sample_notices.sql
fr-FR/1-Obligatoire/sample_notices.sql
it-IT/necessari/notices.sql
nb-NO/1-Obligatorisk/sample_notices.sql
pl-PL/mandatory/sample_notices.sql
ru-RU/mandatory/sample_notices.sql
uk-UA/mandatory/sample_notices.sql

Obviously, the landscape changed in the meantime.
We still have: fr-CA, fr-FR, nb-NO.

Test plan:
Reinstall notices for one of the languages above.

Signed-off-by: Marcel de Rooy 
Have run all sql files thru mysql on the command line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #30 from Marcel de Rooy  ---
Created attachment 122370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122370&action=edit
Bug 20472: Add format to sample notices

NOTE: We are only changing English here. A follow-up will care for
the translated languages. (English is in yml format, the remainder
not yet.)

We need to change the following notices:
AR_SLIP, AR_CANCELED, AR_PROCESSING, AR_PENDING and AR_COMPLETED.
In AR_COMPLETED the last sentence about picking up has been modified
too.

Test plan:
Reinstall Koha. Choose English. Check notice text.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #29 from Marcel de Rooy  ---
Created attachment 122369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122369&action=edit
Bug 20472: Edit URL field on staff form

This patch makes the following changes:

Add menu option Edit URLs.
Edit modal form to edit URLs.
Save URLs via ajax call to svc/article_request (Add action update_urls).
Add URL column to pending and processing table.
Allow Edit URLs for pending table too (just as Complete).
Do not allow 'Complete request' if a scan request has no URL(s).

Test plan:
[1] Add a few scan and photocopy requests.
[2] Fill url-A and url-B in two separate scan requests.
[3] Verify that these two urls are really saved (refresh form).
[4] Check that you cannot complete a scan request without URL and that you
cannot add a URL to a photocopy request.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #28 from Marcel de Rooy  ---
Created attachment 122368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122368&action=edit
Bug 20472: Add format field to the interface

We need to add the format to the forms entering new requests:
  opac/opac-request-article
  circ/request-article
If the pref contains multiple formats like SCAN|PHOTOCOPY, the first listed
format will be preselected on the request form. If there is only one option,
we should not disable the select however. (Possibly hide it.)

If we have no mandatory fields, we should not allow the submit of a complete
empty form (check on OPAC).

And we need to show the format of pending requests on forms:
  opac/opac-user
  circ/request-article (biblio detail tab)
  circ/article-requests (staff form to handle requests)
  members/moremember (Article requests tab at the bottom)
  circ/circulation (Checkout/Article requests tab)
Note: The last two forms use the same include file.

Test plan:
[1] Add an article request via opac or staff. Choose Scan.
[2] Verify that you see the Scan format on opac-user and the
above-mentioned staff forms.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #27 from Marcel de Rooy  ---
Created attachment 122367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122367&action=edit
Bug 20472: Db rev for new preference ArticleRequestsSupportedFormats

This preference controls which formats are actually offered to patrons of
the library via the Article Request feature.
By default, it only contains PHOTOCOPY. This is default behavior.

The request format SCAN will be made possible by this report and can be
added by changing the preference.

Test plan:
Run the dbrev. Check the new pref on Administration.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #26 from Marcel de Rooy  ---
Created attachment 122366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122366&action=edit
Bug 20472: Add new fields article_requests.format and urls

The field 'format' will allow to make a distinction between requests for
photocopies and digital scans.
The field 'urls' will be used to save the URLs that allow the client to
download the scanned materials.

Test plan:
Run new install or upgrade existing install with atomic update.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #25 from Marcel de Rooy  ---
Note for QA:

Should we try to update existing notices here too ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

--- Comment #24 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #9)
> The plan changed ;) This patch set has run in production on 16.11 and 18.05.
> And I rebased for 19.11 and master now.

So I had this stuff on 16.11, 18.05, 19.11, 20.06 and 21.06 now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Marcel de Rooy  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #111479|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #111478|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #111477|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >