[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #24 from David Nind --- A couple of things I noted: 1. Should the call number be repeated if it is the same? That is, should only distinct call numbers be displayed for items available by library branch or not available categories? 2. Should using 0 for resultsMaxItems suppress the display of call numbers? That is the behavour when resultsMaxItemsUnavailable is 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added Text to go in the|Allows customizing the |This enhancement allows release notes|number of call numbers |customizing the number of |listed on the OPAC search |call numbers displayed for |results by changing the |OPAC search results for |prefs: |items available and not |resultsMaxItems |available by changing two |resultsMaxItemsUnavailable |new system preferences: |The latter now applies to |- |the categories Checked out, |resultsMaxItems: maximum |Damaged, ..., On hold. |number of available items ||displayed in search results ||(default = 2) ||- ||resultsMaxItemsUnavailable ||- maximum number of ||unavailable items displayed ||in search results (such as ||when checked out and ||damaged) (default = 1) || ||This is useful when records ||have a large number of ||items, for example larger ||libraries with many ||branches, union catalogues, ||and university libraries ||with course text books. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #23 from David Nind --- Testing notes (using koha-testing-docker): Revised test plan: 1. Setup records and items to test: . Have records with multiple items and call numbers (one with 20 items and one with 50) that will appear in the OPAC results using the same keyword (use 'Add multiple copies of this item' option at the bottom of the add item form to bulk add multiple items). . Make sure (using batch item editing) that there are a mix of libraries, not for loan categories, call numbers, and damaged status' . As a bonus, add some additional not for loan categories (Administration > Basic parameters > Authorized values), such as 'Not for Loan' and 'Staff Collection' . Check out some items to patrons 2. Confirm the current behavour when searching in the OPAC (see the example at the end): . The first call number per branch is displayed under availablility in the results (for items available for loan and items available for reference) . Where there are multiple call numbers for an item, "..." is used to indicate more call numbers . For items not available, such as damaged: no call numbers are displayed. 3. Apply the patch 4. Update the database (updatedatabase when using koha-testing-docker) 5. Run flush_memcached and restart_all (when using koha-testing-docker) 6. Without changing the default values for the new system preferences, check that the current behavour still works (as per step 2). Note: the default setting is to display 2 call numbers for items available (only 1 was displayed before) and 1 call number for items not available (no call numbers were displayed before). 7. Experiment with different values for the new system preferences (for example 10 for resultsMaxItems and 0 for resultsMaxItemsUnavailable): . resultsMaxItems - Maximum number of available items displayed in search results . resultsMaxItemsUnavailable - Maximum number of unavailable items displayed in search results 8. Confirm that the correct number of call numbers are displayed. 9. Sign off! Example --- Before patch applied: ~ Availability: Items available for loan: Centerville (16) Call number: PERL A1, .., Fairview (1) Call number: PERL A1, Franklin (7) Call number: PERL B2, .., Midway (9) Call number: 560.897 ZAK, .., Springfield (6) Call number: 965.009 PLO, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call number: PERL B2, Midway Not For Loan (2) Call number: 560.897 ZAK, .., Centerville Not For Loan (1) Call number: PERL B2, Springfield Not For Loan (3) Call number: 965.009 PLO, ... Not available: Damaged (7). Patch applied: ~~ Availability: Items available for loan: Centerville (16) Call number: PERL A1, PERL A1, .., Fairview (1) Call number: PERL A1, PERL A1, Franklin (7) Call number: PERL A1, PERL A1, .., Midway (9) Call number: PERL A1, PERL A1, .., Springfield (6) Call number: PERL A1, PERL A1, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, PERL B2, Franklin Not For Loan (1) Call number: PERL A1, PERL B2, Midway Not For Loan (2) Call number: PERL A1, PERL B2, Centerville Not For Loan (1) Call number: PERL A1, PERL B2, Springfield Not For Loan (3) Call number: PERL A1, PERL B2, ... Not available: Damaged (7) [ PERL A1, .. ]. Note differences: - Default number of call numbers peated for items available for loan (before patch was applied they didn't), - Not available items didn't originally dispaly Call numbers for Damaged Different values Results with: - resultsMaxItems: 10 - resultsMaxItemsUnavailable: 0 Availability: Items available for loan: Centerville (16) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, .., Fairview (1) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Franklin (7) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Midway (9) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Springfield (6) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK. Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Franklin Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Midway Not For Loan (2) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added Attachment #122391|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 122466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122466=edit Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too Test plan: Add some not for loan categories, add some items for them. Check search results. Verify that results match expectation. Signed-off-by: Marcel de Rooy Tested the combination of pref values for results 2/1 with NFL categories TEST, MOVING: Availability: Items available for loan: Centerville (3) [Call number: PERL A 2, PERL A 3, ...] Items available for reference: Centerville Staff Collection (1) [Call number: PERL A 10]. Not available: TEST (2) [ PERL A 11, .. ]. MOVING (1) [ PERL A 13 ]. Withdrawn (2) [ PERL A 5, .. ]. Damaged (3) [ PERL A 7, .. ]. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added Attachment #122389|0 |1 is obsolete|| --- Comment #21 from David Nind --- Created attachment 122465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122465=edit Bug 26302: Add dbrev for two new prefs Formalizing the local prefs introduced in the former patches: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added Attachment #122388|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 122464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122464=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added Attachment #122387|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 122463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122463=edit Bug 26302: Add syspref resultsMaxItemsUnavailable This is the number of call numbers displayed for unavailable categories in the results XSLT. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added Attachment #122386|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 122462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122462=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 --- Comment #12 from Katrin Fischer --- (In reply to Jonathan Druart from comment #11) > I am suggesting: > > * Codebase will use "additional_contents", Koha::AdditionalContents > > * UI will split: > Tools > News (same as now) > Tools > HTML customization > > Would that work for everybody? +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #217 from Katrin Fischer --- Thx, Marcel. Quite happy to see this one move forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
