[Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|RESOLVED

--- Comment #6 from Fridolin Somers  ---
Minor change, I prefer not to push to oldstable to avoid translation work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28428] Capitalization: Password Updated

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28428

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|RESOLVED

--- Comment #6 from Fridolin Somers  ---
Minor change, I prefer not to push to oldstable to avoid translation work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28280] Item types configuration page doesn't use Price filter for default replacement cost and processing fee

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28427] Terminology: Shelf should be list

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28427

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28423] JavaScript error on MARC modifications page

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28423

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850) at /usr/share/koha/Koha/ArticleRequest.pm line 123.

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545

--- Comment #7 from Fridolin Somers  ---
Note that behavior in staff interface in catalogue/MARCdetail.pl is different :
$item->{ $subf[$i][0] } .= GetAuthorisedValueDesc( $field->tag(), $subf[$i][0],
$subf[$i][1], '', $tagslib) || $subf[$i][1];

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||28545


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545
[Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28545] Noisy uninitialized warn at opac-MARCdetail.pl line 313

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Blocks||25790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
[Bug 25790] [OMNIBUS] warnings removal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28479] TestBuilder.pm uses incorrect method for checking if objects to be created exists

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28479

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28388] Search result set is lost when viewing the MARC plain view (opac-showmarc.pl)

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28388

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18112] Add street type to main address in OPAC

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||28511


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511
[Bug 28511] Road types in OPAC should prefer OPAC description if one exists
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC description if one exists

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||18112
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin Somers  ---
Depends on Bug 18112 not in 20.11.x


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112
[Bug 18112] Add street type to main address in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |vic...@tuxayo.net
   |y.org   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422

--- Comment #9 from Fridolin Somers  ---
(In reply to Katrin Fischer from comment #4)
> I get a strong feeling that we should centralize the code for this check...
> but as a bug fix this works really well.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #8 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

--- Comment #55 from Victor Grousset/tuxayo  ---
(In reply to Jonathan Druart from comment #54)
> Unless you are, Victor!

Nope, I'm learning everything there!
Really, for main 4 things of the test plan I had to ask or dig a tutorial for
each one ^^"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #14 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates Zebra errors

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286

--- Comment #13 from Fridolin Somers  ---
Knowing that,
we may add in koha-indexdefs-to-zebra.xsl the phrase form if missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28344] One should be able to issue refunds against payments that have already been cashed up.

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28344

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28313] Add street type to alternate address in OPAC

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28313

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #10 from Fridolin Somers  ---
Not pushed to 20.11.x since Bug 18112 is not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28191] Update wording on batch patron deletion to reflect changes from bug 26517

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28191

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #9 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28513] Analytic search links formed incorrectly

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28513] Analytic search links formed incorrectly

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27929] Regex option in item batch modification is hidden for itemcallnumber if 952$o linked to cn_browser plugin

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27929

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||

--- Comment #10 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28542] Move new authority from Z39.50/SRU to a button

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28542

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.02   |21.11.00,21.05.02,20.11.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #6 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28600] Variable "$patron" is not available

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|RESOLVED

--- Comment #7 from Fridolin Somers  ---
Depends on Bug 18989 not is 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28586] Cannot resolve a claim

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.01   |21.11.00,21.05.01,20.11.08
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to stable|Pushed to oldstable

--- Comment #15 from Fridolin Somers  ---
Pushed to 20.11.x for 20.11.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28616] Remove Data::Printer dependency

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28616

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin Somers  ---
For 20.11 waiting for Bug 28220

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||28698


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698
[Bug 28698] News for all displays in all locations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28698] News for all displays in all locations

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||22544


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544
[Bug 22544] Move C4:NewsChannels to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28698] News for all displays in all locations

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs Signoff   |RESOLVED

--- Comment #3 from Fridolin Somers  ---
(In reply to Jonathan Druart from comment #2)
> Fridolin, bug 22544 removed C4::NewsChannels, and I think it fixes it.
I confirm.

> 
> Note that I am about to provide a patch on bug 24387 to clean that area a
> bit.
Ahhh super.

So I close.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This removes unnecessary
  release notes||warning messages in
   ||plack-opac-error.log when
   ||patrons have no first name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

David Nind  changed:

   What|Removed |Added

 Attachment #122745|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 122758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122758=edit
Bug 28699: Allow for blank firstname in checkauth

When mapping the fields from the session we should map blank fieds
to blank strings

To test:
1 - Remove first name from a patron
2 - tail -f /var/log/koha/kohadev/plack-opac-error.log
3 - Login as that patron on the opac
4 - Note warns in the log like:
[2021/07/09 13:22:54] [WARN] Use of uninitialized value in sprintf at
/kohadevbox/koha/C4/Auth.pm line 888.
5 - Apply patch
6 - restart_all
7 - Log out and in to opac with user
8 - Note warns above are gone

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567

--- Comment #8 from David Nind  ---
With the updated patch, if I create a new library with 'Yes' the 'Ph:', 'Fax:'
etc still show when no details are entered. You have to edit again to remove.

'No' works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27891] New DIN-oriented order print format (PDF-export) - layout2pagesdinde

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27891

--- Comment #1 from M. Oehme  ---
Created attachment 122757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122757=edit
Bug 27891: New DIN-oriented order print format (PDF-export) - layout2pagesdinde
Add a new order print format (pdf-export) named layout2pagesdinde

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28696] Point of sale: attempting to pay with the "Enter" key cause an overcharge in the database

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28696

--- Comment #2 from Marie-Luce Laflamme  ---
correction
the payment screen shows only $1 to pay
the receipt shows up $3
db tell 3 time $1 payment

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28662] Not possible to log out of patron account in OPAC with JavaScript disabled

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662

Lucas Gass  changed:

   What|Removed |Added

 Attachment #122619|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 122756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122756=edit
Bug 28662: Not possible to log out of patron account in OPAC with JavaScript
disabled

This patch adds a "Log out" link to the OPAC header which is hidden by
CSS when JavaScript is enabled.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Log in to the OPAC with JavaScript disabled in your browser.
 - In the header next to the logged-in user's name there should be a
   "Log out." link.
 - Confirm that it logs the user out.
 - Enable JavaScript and repeat the process to confirm that the new
   logout link doesn't appear.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28662] Not possible to log out of patron account in OPAC with JavaScript disabled

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28631] Holds History title link returns "not found" error

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28631] Holds History title link returns "not found" error

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #122510|0   |1
is obsolete||

--- Comment #2 from sandbo...@biblibre.com  ---
Created attachment 122755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122755=edit
Bug 28631: Holds History title link returns "not found" error

This patch corrects a broken path in the OPAC holds history page.

This patch also corrects the breadcrumb markup which didn't conform to
the new Bootstrap 4 pattern.

To test, apply the patch and log into the OPAC as a patron who has past
or current holds.

- View the "your holds history" page.
- Click a title link in the table of holds. It should take you to the
  correct bibliographic detail page.
- Check the breadcrumbs of the page. They should look consistent with
  breadcrumb navigation on other pages in the OPAC.

Signed-off-by: Kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #14 from Kelly McElligott  ---
Hi, Do you have a good way of testing this without having to set up email
generation on a test server?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #8 from Victor Grousset/tuxayo  ---
No error found after some fiddling on 20.05.x which needed a conflict to solve.

code looks good.
QA script passes on the 20.11 version and the 20.05 one.

Above attached is the 20.11 version (not the one with the 20.05 conflict
solving which would have hindered the applicability on 20.11)

So, stamped!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27451] Split opac_news.lang into two distinct fields for location and language

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451
Bug 27451 depends on bug 22544, which changed state.

Bug 22544 Summary: Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387
Bug 24387 depends on bug 22544, which changed state.

Bug 22544 Summary: Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15449] Move stuff to the Koha namespace

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
Bug 15449 depends on bug 22544, which changed state.

Bug 22544 Summary: Move C4:NewsChannels to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

--- Comment #219 from Kyle M Hall  ---
Enhancement not backported to 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28597] OPAC suggestions do not display news for logged in branch

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|21.11.00|21.11.00,21.05.02
released in||

--- Comment #7 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28455] If TrackLastPatronActivity is enabled we should update 'lastseen' field on checkouts

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28455

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #15 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28611] Incorrect Select2 width

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|21.11.00|21.11.00,21.05.02
released in||

--- Comment #8 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28299] OpacHiddenItems not working in OPAC lists

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 CC||k...@bywatersolutions.com

--- Comment #28 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28462] TT tag on several lines break the translator tool

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|21.11.00|21.11.00,21.05.02
released in||

--- Comment #21 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28524] Most-circulated items (cat_issues_top.pl) is failing with MySQL 8

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28524

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|21.11.00|21.11.00,21.05.02
released in||

--- Comment #5 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #122697|0   |1
is obsolete||

--- Comment #7 from Victor Grousset/tuxayo  ---
Created attachment 122754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122754=edit
Bug 28675: (bug 27942 follow-up) Fix QOTD - add new quote

Bug 27942 has been written for master on top of bug 27251, and the code
differ a lot from what we have in <= 20.11.

This patch is quite ugly but it works, and is certainly the less painful
solution to fix stable branches.
Feel free to provide an alternative patch.

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28523] Patrons with the most checkouts (bor_issues_top.pl) is failing with MySQL 8

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

koha-US bug tracker  changed:

   What|Removed |Added

  Text to go in the||Sponsored by koha-US
  release notes||
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24019] Patron batch modification based on borrowernumber

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #121151|0   |1
is obsolete||

--- Comment #2 from sandbo...@biblibre.com  ---
Created attachment 122753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122753=edit
Bug 24019: Patron batch modification based on borrowernumber

This patch adds batch patron modifications based on borrowernumber. The
user can choose to upload a file of borrowernumbers or submit a list of
borrowernumbers in a textarea, just like they can with card numbers.

To test, apply the patch and prepare files containing borrowernumbers
and card numbers. Patron lists should be enabled, and you should have at
least one patron list with patrons on it.

- Go to Tools -> Batch patron modification.
- You should see three tabs: "By card number," "By borrowernumber," and
  "By patron list."
- Test each option for batch patron modifications:
  - By card number file
  - By card number list
  - By borrowernumber file
  - By borrowernumber list
  - By patron list
- In each case the correct batch should be submitted, and modifications
  should finish correctly..
- There should be an "order of operations" for card numbers and
  borrowernumbers:
  - If a file is uploaded AND a list of numbers is entered, the list of
numbers should be used.
- Batches should only get submitted from the active tab.
  - If you upload a file or enter card numbers in one tab and then
switch to another tab and submit numbers from there, the original
tab's batches should be ignored.

Signed-off-by: kelly mcelligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Kelly McElligott  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #116085|0   |1
is obsolete||

--- Comment #19 from sandbo...@biblibre.com  ---
Created attachment 122752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122752=edit
Bug 13188: Add PatronSelfModificationMandatoryField system preference

TEST PLAN:
1. Apply patch, updatedatabase, restart_all
2. In the  PatronSelfRegistrationBorrowerMandatoryField add the field password.
3. Go to the self registration page on make sure password is required.
4. Now go to the OPAC modification page, make some changes and attempt to
submit. It should work.
5. Go to PatronSelfModificationMandatoryField and select some fields.
6. The columns you selected should now be required.
7. On the PatronSelfModificationMandatoryField page, make sure the select all
and clear all buttons work.

Signed-off-by: Kelly McElligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28618] Move t/lib modules to lib/Koha/Test

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618
Bug 28618 depends on bug 28615, which changed state.

Bug 28615 Summary: Add a simple way to mock Koha::Logger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28615] Add a simple way to mock Koha::Logger

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28615

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

--- Comment #34 from Kyle M Hall  ---
Enhancement not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28571] C4::Auth::_session_log is not used and must be removed

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28571

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28606] Replace $ENV{DEBUG} and $DEBUG with Koha::Logger->debug

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28606

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Kyle M Hall  ---
Enhancement not pushed to 21.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28601] Wrong breadcrumb for 'Home' on circulation-home

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28601

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595
Bug 28595 depends on bug 28588, which changed state.

Bug 28588 Summary: Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588

   What|Removed |Added

 Status|Pushed to master|CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593
Bug 28593 depends on bug 28588, which changed state.

Bug 28588 Summary: Add Koha::Checkouts::ReturnClaim->resolve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588

   What|Removed |Added

 Status|Pushed to master|CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|CLOSED
 Resolution|--- |FIXED

--- Comment #11 from Kyle M Hall  ---
Enhancement not pushed to 21.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.02
released in||
 CC||k...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
> We now have this already:
> KohaPlugins.get_plugins_opac_head
> And: [% KohaPlugins.get_plugins_opac_js %]
> And: [% KohaPlugins.get_plugins_intranet_head %]
> 
> So it is a discussion item whether we really should have this too.
> We miss an intranet counterpart here, that the plugins offer.
> And maybe the location of adding the pref content in doc-head-close is
> questionable? Should we add it at the end, if we would decide so?
> 
> Could you raise this on koha-devel ?

I think you are misunderstanding the purpose of this patch. Clearly, we should
not have to build a plugin just to import a google font into Koha for some CSS
style. That appears to be the purpose of this ehancement; to allow importing js
and css into the correct part of Koha's html, the head block.

Does that make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

--- Comment #28 from Jonathan Druart  ---
Can someone stress the feature with this patch? IIRC weird bugs usually happens
"on the edge" of the pagination.

Like search with your favourite weird terms and click the last records from the
page, then next, previous.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

--- Comment #27 from Jonathan Druart  ---
Created attachment 122751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122751=edit
Bug 20529: Remove other occurrences of decodeURIComponent from browser.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529

--- Comment #26 from Jonathan Druart  ---
(In reply to Fridolin Somers from comment #24)
> I totally reproduce bug and patch fixes it.
> 
> We already see :
>   decodeURIComponent(current_search.limit)
> It is logical to use :
>   decodeURIComponent(current_search.query)

Hum? What do you mean?

If it makes sense to remove this decode call then we should remove other
occurrences from this file.

I don't see the point of decodeURIComponent to generate an URI, unless we are
doing weird stuffs somewhere else (or it's Friday afternoon and I am tired).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to adv search

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622

--- Comment #13 from David Nind  ---
Testing notes (koha-testing-docker):
- Before and after apply the patch the behavour is:
  . Set library in staff interface
  . Go to the advanced search interface
  . For 'Location and availability', 'All libraries' is the default choice
  . If the library is changed (drop down list > Set library) the default for
'Location and availability' should remain as 'All libraries'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to adv search

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622

David Nind  changed:

   What|Removed |Added

 Attachment #122598|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 122750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122750=edit
Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv
search

From
  commit df97814f3034a3d5015546c4eca21f08ae951e37
  Bug 15758: Koha::Libraries - Remove GetBranches

+selected_branchcode => ( C4::Context->IsSuperLibrarian ?
C4::Context->userenv : '' ),

And

-[% PROCESS options_for_libraries libraries => Branches.all() %]
+[%# FIXME Should not we filter the libraries displayed? %]
+[% PROCESS options_for_libraries libraries => Branches.all( selected
=> selected_branchcode, unfiltered => 1 ) %]

The change in the pl is wrong as it should pass C4::Context->userenv->{branch},
but prior to this commit it seems that we didn't select the logged in
library anyway.

Looks like we should remove this code but preserve the current behavior and
select "All libraries".

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28622] Selected branchcode incorrectly passed to adv search

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Nick Clemens  changed:

   What|Removed |Added

 Attachment #122547|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 122749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122749=edit
Bug 28472: handle items with NULL shelving location

The UpdateItemLocationOnCheckin System Preference can be set to update the
location of ALL items during check in, regardless of their shelving location.
However, this does not currently work 100% as it is excluding items with no
shelving location (i.e. value of NULL in the corresponding database field).

This patch, based on the comment made by Nick Clemens, fixes that.

Test plan (based on the original Bug Description by Andrew Fuerste-Henry):

1) Have a shelving location CART
2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes)
3) Check in an item that has a shelving location, confirm it changes to CART
4) Check in an item with a NULL shelving location, confirm it doesn't go to
CART
5) Apply this patch
6) Repeat step 4): this time the item should move to the CART shelving location

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #122748|Dump data for opac_news to  |Dump of dumb data for
description|replay the db rev easily|opac_news to replay the db
   ||rev easily

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

--- Comment #20 from Jonathan Druart  ---
Created attachment 122748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122748=edit
Dump data for opac_news to replay the db rev easily

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #11 from Nick Clemens  ---
Oops, this breaks item editing, the form now has values like:


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

--- Comment #19 from Jonathan Druart  ---
And I finally forgot to write those tests for search_for_display!
Will do next week if I don't forget. It does not prevent testing ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196

Nick Clemens  changed:

   What|Removed |Added

 Attachment #122384|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 122747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122747=edit
Bug 28196: make sure URL hash is appended last

TO test:
1 Do a search within the staff client
2 Click on any results and go to the detail page
3 Click the edit button on any item in that record, it should take you to a URL
like this:
'/cgi-bin/koha/cataloguing/additem.pl?op=edititem=55=117#edititem=scs_1619109565224'
4 Apply patch
5 Do steps 1 & 2 again
Click the edit button on any item in that record, it should take you to a URL
like this:
'/cgi-bin/koha/cataloguing/additem.pl?op=edititem=55   
ber=117=scs_1619109565224#edititem'
6. If they URL hash is last the anchor should work and you'll be placed on the
h2 element with and ID of edititem

Signed-off-by: David Nind 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always go to the right place

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

--- Comment #18 from Jonathan Druart  ---
Created attachment 122746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122746=edit
Bug 24387: Fix location options when editing HTML custom

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

--- Comment #1 from Nick Clemens  ---
Created attachment 122745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122745=edit
Bug 28699: Allow for blank firstname in checkauth

When mapping the fields from the session we should map blank fieds
to blank strings

To test:
1 - Remove first name from a patron
2 - tail -f /var/log/koha/kohadev/plack-opac-error.log
3 - Login as that patron on the opac
4 - Note warns in the log like:
[2021/07/09 13:22:54] [WARN] Use of uninitialized value in sprintf at
/kohadevbox/koha/C4/Auth.pm line 888.
5 - Apply patch
6 - restart_all
7 - Log out and in to opac with user
8 - Note warns above are gone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24387] Rename News tool

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

--- Comment #17 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #16)
> I still prefer 'Blocks' or 'Content blocks' but am happy to be overruled
> there.

Well, Katrin disagreed on that one, and that's why I've asked here before
starting two days ago! :D
Now it will be quite a nightmare to replace all the occurrences (script and
template names, DB table, variables, modules...)

> However, this isn't working fully for me.. in the HTML Customisations screen
> if I attempt to edit an existing block the Display locations dropdown only
> shows the News options and not the Nav blocks etc.

Indeed, patch on its way!

> As later change, I'd love to see a more visual display on the blocks page
> highlighting where the blocks of content will actually appear rather than
> just a table.. but that's certainly a later enhancement.

Can you detail?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] New: Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Bug ID: 28699
   Summary: Noisy warns in checkauth when patron has no firstname
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Firstname field is not required, however, we try to log it in checkauth:
 888 Koha::Logger->get->debug(sprintf "AUTH_SESSION: (%s)\t%s %s -
%s", map { $session->param($_) || "" } qw(cardnumber firstname surname
branch));

This causes a warn in the logs:
[2021/07/09 13:22:54] [WARN] Use of uninitialized value in sprintf at
/kohadevbox/koha/C4/Auth.pm line 888.

To recreate:
1 - Remove first name from a patron
2 - tail -f /var/log/koha/kohadev/plack-opac-error.log
3 - Login as that patron on the opac

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561

Nick Clemens  changed:

   What|Removed |Added

 Attachment #122215|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 122744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122744=edit
Bug 28561: Remove DBIC warning in opac-shelves

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561

Nick Clemens  changed:

   What|Removed |Added

 Attachment #121913|0   |1
is obsolete||

--- Comment #11 from Nick Clemens  ---
Created attachment 122743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122743=edit
Bug 28561: Fix noisy warning about $direction too

Use of uninitialized value $direction in string ne at
/usr/share/koha/opac/opac-shelves.pl line 265.

Bonus:
Use of uninitialized value $sortfield in string eq at
/usr/share/koha/opac/opac-shelves.pl line 264.

Test plan:
While testing patch 1, check the logs for these warnings with and
without this patch.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >