[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #90 from Victor Grousset/tuxayo ---
Testing note: always restart services after changing the version syspref.
A bit confused about the test plan:
> - Apply "Bug 25078: [DO NOT PUSH] DB revs for testing" (restart_all)
> - Read the different DBrevs created as examples
> - Make sure the different use cases are covered
> - execute the updatedatabase script (CLI)
Actually all patches should be applied from the start, right?
Moving on with this assumption.
==
> - execute the updatedatabase script (CLI)
output:
> Wide character in say at
> /kohadevbox/koha/installer/data/mysql/db_revs/21060.pl line 11.
> Upgrade to 21.06.00.000 done [01:12:42]: Increase DBRev for 21.06
> - Run, rabbit run.
> - Dig that hole, forget the
> sun,
> - And when at last the work
> is done
> - Don't sit down it's time
> to dig another one.
> Upgrade to 21.06.00.001 done [01:12:42]: Bug 28489 - Modify
> sessions.a_session from longtext to longblob
> Upgrade to 21.06.00.002 done [01:12:42]: Bug 28490 - Bring back accidentally
> deleted relationship columns
> Upgrade to 21.06.00.003 done [01:12:43]: Bug 24434 - Add 'WrongTransfer' to
> branchtransfers.cancellation_reason enum
> Upgrade to 21.06.00.004 done [01:12:43]: Bug 15788 - Split edit_borrowers
> permission
> Upgrade to 21.06.00.005 done [01:12:43]: Bug 26205 - Add new system
> preference NewsLog to log news changes
> Upgrade to 21.06.00.081 done [01:12:43]: Bug 42322 - Single line
> description, no report
> Upgrade to 21.06.00.082 done [01:12:43]: Bug 42422 - Testing number of
> patrons
> - Number of patrons: 53
> Upgrade to 21.06.00.083 done [01:12:43]: Bug 42323 - Multi lines report
> - Multi
> - lines
> - report
> Upgrade to 21.06.00.090 failed [01:12:43]: Bug 42420 - Testing failure
> ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table
> 'koha_kohadev.Foo' doesn't exist [for Statement "ALTER TABLE Foo"] at
> /kohadevbox/koha/C4/Installer.pm line 734
>
> DEV atomic update: bug_25078.perl
> Upgrade to XXX [01:12:43]: Bug 25078 - Description
> - Boom, boom
> - Chick-a-boom
The Chick-a-boom atomic update is executed after the failure of the previous
update.
Is that an issue?
«Wide character in say» Shouldn't it be fixed by «Fix encoding issue with
db_revs output»
===
> - Update the DB from the UI
↓↓↓
> User koha_kohadev doesn't have enough privilege on database koha_kohadev.
What?! This is obviously unrelated but worth mentioning in case others using
koha-testing-docker or not also have that.
Anyway, moving on.
Ok lol, we can actually move on. ¯\_ (ツ)_/¯
=
> DEV atomic update: bug_25078.perl
> Upgrade to XXX [23:11:53]: Bug 25078 - Description
> - Boom, boom
> - Chick-a-boom
>
> Upgrade to 21.06.00.000 done [23:11:53]: Increase DBRev for 21.06
> - Run, rabbit run.
> - Dig that hole, forget the sun,
> - And when at last the work is done
> - Don't sit down it's time to dig another one.
> Upgrade to 21.06.00.001 done [23:11:53]: Bug 28489 - Modify
> sessions.a_session from longtext to longblob
> Upgrade to 21.06.00.002 done [23:11:53]: Bug 28490 - Bring back
> accidentally deleted relationship columns
> Upgrade to 21.06.00.003 done [23:11:53]: Bug 24434 - Add 'WrongTransfer'
> to branchtransfers.cancellation_reason enum
> Upgrade to 21.06.00.004 done [23:11:53]: Bug 15788 - Split edit_borrowers
> permission
> Upgrade to 21.06.00.005 done [23:11:53]: Bug 26205 - Add new system
> preference NewsLog to log news changes
> Upgrade to 21.06.00.081 done [23:11:53]: Bug 42322 - Single line
> description, no report
> Upgrade to 21.06.00.082 done [23:11:53]: Bug 42422 - Testing number of
> patrons
> - Number of patrons: 53
> Upgrade to 21.06.00.083 done [23:11:53]: Bug 42323 - Multi lines report
> - Multi
> - lines
> - report
>
> Update error :
>
> Upgrade to 21.06.00.090 failed [23:11:53]: Bug 42420 - Testing failure
> ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table
> 'koha_kohadev.Foo' doesn't exist [for Statement "ALTER TABLE Foo"] at
> /kohadevbox/koha/C4/Installer.pm line 734
This time the Chick-a-boom update is first! Does it matter?
And no «Wide character in say» warning.
==
Oh a "try again" button, let's press it.
Same error, as expected.
The Chick-a-boom
[Koha-bugs] [Bug 28688] Auto Renew Patron Membership if Patron has Been Active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- I like the sound of this. (It makes me wonder if all my library cards have expired since I haven't been to a public library since 2019 thanks to the pandemic*.) *I wonder if we'll look back one day on these Bugzilla comments and say "oh right... we did have a pandemic back then..." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9815] <> can't contain "The Library"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9815 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16786] No longer to add multiple emails addresses in an email field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15349] Problem with email pattern check on forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- This one is really interesting. At a glance at the documentation and source code, Email::Valid might be able to support that... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 David Cook changed: What|Removed |Added Summary|Fetching biblio objects for |Fetching biblio objects for |custom covers is|custom covers is |innefficient|inefficient -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17485] Add Marc modification templates to z39.50 import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17485 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is innefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I like the motivation for the change, but I'm not sure about the style. What if we moved most of the logic out of "custom_cover_image_url" and into a separate class method. Then "custom_cover_image_url" could call that class method, and that class method could be used in the search results. I think that would make the code easier to read and maintain in the longer term. But that's just my two cents. I know that it would be more work so might not be feasible. I've used the same style of checking if $self is a ref for times when I couldn't refactor more fully. Always nice to see an efficiency improvement :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28680] Staff without edit_borrower permission still see patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28680 --- Comment #3 from David Cook --- For what it's worth, off the top of my head, it would be a massive long expensive development with little chance of success to hide the borrower information as desired. I could be wrong, but that's my first instinct. I can also think of a few holes (like reports) that would probably be impossible to plug without completely rewriting entire modules in Koha, which would then break many workflows and expectations. But that's just my two cents. Someone else might have a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28666] Locale::XGettext::TT2 shows as missing in about.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28666 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #3 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #2) > diff --git a/cpanfile b/cpanfile > index 6e13f049320..70dd516d449 100644 > --- a/cpanfile > +++ b/cpanfile > @@ -144,7 +144,7 @@ recommends 'Gravatar::URL', '1.03'; > recommends 'HTTPD::Bench::ApacheBench', '0.73'; > recommends 'LWP::Protocol::https', '5.836'; > recommends 'Lingua::Ispell', '0.07'; > -recommends 'Locale::XGettext::TT2', '0.7'; > +recommends 'Locale::XGettext', '0.7'; > recommends 'Module::Bundled::Files', '0.03'; > recommends 'Module::Load::Conditional', '0.38'; > recommends 'Module::Pluggable', '3.9'; > > > It makes it looks ok but feels wrong. If TT2 is part of the library distribution, it is ok imho. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #42 from Kyle M Hall --- Created attachment 122834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122834=edit Bug 20817: _trim should always return a value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is innefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is innefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
Nick Clemens changed:
What|Removed |Added
Attachment #122832|0 |1
is obsolete||
--- Comment #2 from Nick Clemens ---
Created attachment 122833
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122833=edit
Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing
parameters
Currently the search result template receive a Koha::Biblio object and call the
method.
The searchResults routine already has the isbn, issn, and normalized_isbn
calculated.
Rather than fetching the object and passing to the template we can pass the
parameters,
generate the url, and pass only the URL to the template
To test:
1 - Set the system preferences:
CustomCoverImages : Display
OPACCustomCoverImages: Display
CustomCoverImagesURL:
https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZ.jpg
2 - Search on staff and opac for a term that returns titles with covers, e.g.
'shuffle'
3 - Confirm the covers show
4 - Apply patch
5 - Restart all
6 - Confirm covers still show
7 - prove -v t/db_dependent/Koha/Biblios.t
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Nick Clemens changed: What|Removed |Added Blocks||28709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 [Bug 28709] Fetching biblio objects for custom covers is innefficient -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is innefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Depends on||22445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 [Bug 22445] Ability to define a URL for custom cover images -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is innefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709
--- Comment #1 from Nick Clemens ---
Created attachment 122832
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122832=edit
Bug 28709: Refactor Koha::Biblio->custom_cover_image_url to allow passing
parameters
Currently the search result template receive a Koha::Biblio object and call the
method.
The searchResults routine already has the isbn, issn, and normalized_isbn
calculated.
Rather than fetching the object and passing to the template we can pass the
parameters,
generate the url, and pass only the URL to the template
To test:
1 - Set the system preferences:
CustomCoverImages : Display
OPACCustomCoverImages: Display
CustomCoverImagesURL:
https://images-na.ssl-images-amazon.com/images/P/{normalized_isbn}.01.LZZZ.jpg
2 - Search on staff and opac for a term that returns titles with covers, e.g.
'shuffle'
3 - Confirm the covers show
4 - Apply patch
5 - Restart all
6 - Confirm covers still show
7 - prove -v t/db_dependent/Koha/Biblios.t
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is innefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17485] Add Marc modification templates to z39.50 import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17485 --- Comment #2 from Barbara Johnson --- I'd love to see some more action on this bug because I think this would be great functionality. We get brief bib records when we order from our vendor. When cataloging in the advanced editor we overlay the brief bib with a full MARC record via Z39.50. Sometimes the incoming record has tags that we do not want in our bibs (local 9XX tags, 852, local 59x notes, etc.) We'd like a way to prevent those tags from being imported instead of having to delete them from every incoming record. We'd also like a way to add or modify fields in the incoming record such as changing an incoming 092 to an 099. These are some examples of what we would like to have automatically removed from the incoming records: Delete all 9xx tags Delete all 852 tags Delete all 59x tags Delete all 69x tags Delete subfield ‡0 from all 1xx, 6xx, 7xx and 8xx tags - Example: 600 1 0 ‡aObama, Michelle,‡d1964-‡0823994 Delete 6xx subject headings that contain a subfield ‡2fast‡0(OCoLC) - Example: 650 _ 7 ‡aAfrican American women lawyers.‡2fast‡0(OCoLC)fst00799505. Change the incoming 092 tag to an 099 tag Delete all 035 tags that do not contain (OCoLC) at the beginning Remove the  diacritic symbol from the beginning of a 264_4 tag Delete subfield ‡b of the 003 tag Add audience code to the leader -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] New: Fetching biblio objects for custom covers is innefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Bug ID: 28709 Summary: Fetching biblio objects for custom covers is innefficient Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 22445 added the ability to define custom cover image urls using info from the bibliographic record The method custom_cover_image_url is part of Koha::Biblio To use the method the search results now fetch the Biblio object in individual calls in the results loop. If the method is refactored to allow passing parameters we can use the values already calculated in the subroutine to generate the URL and pass only the URL to the templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #318 from Kyle M Hall --- Created attachment 122831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122831=edit Bug 24857: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #317 from Kyle M Hall --- Created attachment 122830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122830=edit Bug 24857: (QA follow-up) Fix unit tests and code for changes in Koha::Item::delete -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #316 from Kyle M Hall --- Created attachment 122829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122829=edit Bug 24857: (QA follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #315 from Kyle M Hall --- Created attachment 122828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122828=edit Bug 24857: (QA follow-up) Add volume to table settings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #314 from Kyle M Hall --- Created attachment 122827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122827=edit Bug 24857: Change button text from "Create new" to "New volume" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #313 from Kyle M Hall --- Created attachment 122826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122826=edit Bug 24857: Fix sorting of new syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #312 from Kyle M Hall --- Created attachment 122825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122825=edit Bug 24857: Remove doubled 'use Koha::Biblio::Volumes' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #311 from Kyle M Hall --- Created attachment 122824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122824=edit Bug 24857: Fix simple-quote string -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #310 from Kyle M Hall --- Created attachment 122823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122823=edit Bug 24857: Add missing filter and move js to footer on additem.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #309 from Kyle M Hall --- Created attachment 122822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122822=edit Bug 24857: Fix POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #308 from Kyle M Hall --- Created attachment 122821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122821=edit Bug 24857: Fix license statements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #307 from Kyle M Hall --- Created attachment 122820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122820=edit Bug 24857: Add user permission for volumes management Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #306 from Kyle M Hall --- Created attachment 122819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122819=edit Bug 24857: Copy the volume to the item's enumchron Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #305 from Kyle M Hall --- Created attachment 122818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122818=edit Bug 24857: Delete a volume when the last item on that volume is deleted Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #304 from Kyle M Hall --- Created attachment 122817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122817=edit Bug 24857: Add ability to manage item's volumes from detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #303 from Kyle M Hall --- Created attachment 122816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122816=edit Bug 24857: Add ability to attach newly cataloged items to a volume Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #302 from Kyle M Hall --- Created attachment 122815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122815=edit Bug 24857: Add volume management to detail.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #301 from Kyle M Hall --- Created attachment 122814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122814=edit Bug 24857: Implement volume related controllers Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #300 from Kyle M Hall --- Created attachment 122813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122813=edit Bug 24857: Koha::Biblio::Volume methods This patch introduces the following methods: - add_item - del_item - items - to_api_mapping - store (overloaded) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #299 from Kyle M Hall --- Created attachment 122812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122812=edit Bug 24857: API spec Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #298 from Kyle M Hall --- Created attachment 122811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122811=edit Bug 24857: Add Object Methods Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #297 from Kyle M Hall --- Created attachment 122810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122810=edit Bug 24857: Add Koha Object(s) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #296 from Kyle M Hall --- Created attachment 122809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122809=edit Bug 24857: Add new Schema files Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Kyle M Hall changed: What|Removed |Added Attachment #120495|0 |1 is obsolete|| Attachment #120496|0 |1 is obsolete|| Attachment #120497|0 |1 is obsolete|| Attachment #120498|0 |1 is obsolete|| Attachment #120499|0 |1 is obsolete|| Attachment #120500|0 |1 is obsolete|| Attachment #120501|0 |1 is obsolete|| Attachment #120502|0 |1 is obsolete|| Attachment #120503|0 |1 is obsolete|| Attachment #120504|0 |1 is obsolete|| Attachment #120505|0 |1 is obsolete|| Attachment #120506|0 |1 is obsolete|| Attachment #120507|0 |1 is obsolete|| Attachment #120508|0 |1 is obsolete|| Attachment #120509|0 |1 is obsolete|| Attachment #120510|0 |1 is obsolete|| Attachment #120511|0 |1 is obsolete|| Attachment #120512|0 |1 is obsolete|| Attachment #120513|0 |1 is obsolete|| Attachment #120514|0 |1 is obsolete|| Attachment #120515|0 |1 is obsolete|| Attachment #120516|0 |1 is obsolete|| Attachment #120517|0 |1 is obsolete|| Attachment #120518|0 |1 is obsolete|| --- Comment #295 from Kyle M Hall --- Created attachment 122808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122808=edit Bug 24857: Update Database We have a partner that needs Volume Level Holds. This is a feature that some ILSs have that allows the creation of volumes at the bibliographic level, with items being optionally assigned to a given volume. This facilitates the ability to place holds at a volume level, rather than on a specific item or any available item on a record. Test Plan: 1) Apply the patches for this bug 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new syspref EnableVolumes 5) Browse to detail.pl for a record with items 6) Note the new volumes tab 7) Test creating, editing and deleting volumes 8) On the Holdings tab, select one or more items using the checkboxes 8) Note new selection options for setting a volume for items, and for clearing a volume for items. 9) Test adding and clearing the volume set for items Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28708] fr-CA localization file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 122807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122807=edit Bug 28708 : fr-CA localization file This patch adds a custom.sql file in localization/fr-CA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28708] fr-CA localization file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28708] fr-CA localization file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28708] New: fr-CA localization file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 Bug ID: 28708 Summary: fr-CA localization file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr I saw some other languages had localization files for specific system preferences. I had my own file before, but now I can share most of it (some things are specific to our organization). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27101] Remove fr-CA installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101 Caroline Cyr La Rose changed: What|Removed |Added CC||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27101] Remove fr-CA installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101 --- Comment #2 from Caroline Cyr La Rose --- Do i simply remove the directories? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 --- Comment #1 from Caroline Cyr La Rose --- Ok, I'm even more lost than I thought! I found the name and title of the letter in translate.koha-community.org. But I can't find the content (e.g. I'm looking for "Operator ID" which is in the RECEIPT). How do I submit a change to get the content of the letter in translate.k-c.org? Or rather, how do we need to change the letter in order for the content to show up in translate.k-c.org? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 --- Comment #8 from Marcel de Rooy --- (In reply to Lucas Gass from comment #7) > Marcel, we can do that for CSS, yes. I thought maybe it would be beneficial > to be able to add other things that belong in the HTML head, > link/meta/style/script etc. > > But perhaps the use case is so small that is not worth adding a whole new > system preference to Koha. I will go ahead and mark this one as invalid as > there are workarounds to my problem. Fair enough. But no one told you so yet. Stand with the first QA wave, cope with the second :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28083] Add system preference that allows users to insert HTML in the on all staff pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28083 Lucas Gass changed: What|Removed |Added Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #5 from Lucas Gass --- Like we discussed in Bug 28080, these patches are probably unnecessary as there are plenty of workarounds to get things into the HTML head. Marking this one as invalid as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28080] Add system preference that allows users to insert HTML in the on all OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28080 Lucas Gass changed: What|Removed |Added Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #7 from Lucas Gass --- > Surely, this explanation is helpful :) > In this case I would ask: Couldnt you do the same with OPACUserCSS and > @import url() or @font-face and src: url()? Marcel, we can do that for CSS, yes. I thought maybe it would be beneficial to be able to add other things that belong in the HTML head, link/meta/style/script etc. But perhaps the use case is so small that is not worth adding a whole new system preference to Koha. I will go ahead and mark this one as invalid as there are workarounds to my problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28707] New: Translate RECEIPT notice (fr-CA)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Bug ID: 28707 Summary: Translate RECEIPT notice (fr-CA) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The RECEIPT notice was not yet translated in fr-CA. I hope I'm doing this correctly. I admit I'm a bit lost since the change of the translation process for SQL data. Let me know if I need to change something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15349] Problem with email pattern check on forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #3 from Katrin Fischer --- *** Bug 28706 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28706] Email address fields should allow for display name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28706 --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15349 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15349] Problem with email pattern check on forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 Katrin Fischer changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 24233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24233] Library branches editor doesn't allow email addresses with a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24233 --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15349 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9815] <> can't contain "The Library"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9815 --- Comment #4 from Katrin Fischer --- Found it - it was 15349. Redirecting the duplicates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9815] <> can't contain "The Library"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9815 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16786 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16786] No longer to add multiple emails addresses in an email field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9815 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9815] <> can't contain "The Library"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9815 --- Comment #3 from Katrin Fischer --- Hm, realizing this bug is about the notices, but still interesting in context of bugs 24233 and 28706 and I just KNOW there was another bug where I discussed this change with Owen on :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9815] <> can't contain "The Library"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9815 Katrin Fischer changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 24233 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24233] Library branches editor doesn't allow email addresses with a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24233 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 9815 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9815] <> can't contain "The Library"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9815 Katrin Fischer changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #1 from Katrin Fischer --- *** Bug 28706 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28706] Email address fields should allow for display name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28706 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- Hm, we have been using "branch name " in the past by adding it to the database directly, but I am a little worried that will implode in newer versions with the changes for adding STMP configs. Also - this is a duplicate ;) *** This bug has been marked as a duplicate of bug 9815 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28680] Staff without edit_borrower permission still see patron information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28680 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #2 from George Williams (NEKLS) --- I agree with Donna that, since the edit_borrowers permission says "Add, modify and view patron information" it should actually work that way. If, as David suggests, the wording in the description were changed, then I would want a separate permission that controls "view patron information" because we have staff at 50+ libraries that are currently restricted from viewing borrower address information that we need to continue to restrict from viewing address information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28688] Auto Renew Patron Membership if Patron has Been Active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #1 from George Williams (NEKLS) --- I agree. I think this is a great idea so long as there is some kind of system preference to turn it on or off. Even better, though, would be to make it part of the circulation rules so that it could be turned on or off based on the borrower's home library or part of the patron category configuration so it could be turned on or off based on a borrower's category. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316
--- Comment #58 from Peter Vashchuk ---
(In reply to Victor Grousset/tuxayo from comment #51)
> With QueryAutoTruncate=only if *
> For a search of the following and a record named the following:
> The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ /
> => Error: Unable to perform your search
>
> With QueryAutoTruncate=auto
> For a search of the following and a record named the following:
> The reserved characters are: + - = && || > < ! ( ) { } [ ] ^ " ~ * ? : \ /
> => Error: Unable to perform your search
Hey Victor, thanks for the response,
I think search query like that should never work as it will always cause ES
syntax error, ElasticSearch is a mini-language after all and has it's own
syntax and it will die on something like that.
Though we do need to notify the user, in cases like that, that the search query
is incorrect and that they need to correct it and search with it again. I will
make a ticket for it a bit later if.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28706] Email address fields should allow for display name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28706 --- Comment #1 from Nick Clemens --- Format: <> libr...@place.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28706] New: Email address fields should allow for display name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28706 Bug ID: 28706 Summary: Email address fields should allow for display name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When a library enters their branch address they are constrained to the format: u...@domain.com Some libraries would like to add a display name to aid users on the other end in recognizing their emails: Your Public Library <> Our email validation routine should be expanded to allow this format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632
--- Comment #7 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #6)
> Why a warn? And why don't you just delete $result->{update_on} then compare
> with is_deeply?
What we want to test here is that the passed parameters are present on the
response (and on the DB). Those parameters can change because we are basically
using a Koha::Patron as a basis (there's a bug adding a new column to
'borrowers', for example) so it felt like we needed to loop through the passed
parameters and see they all match with the response.
Maybe we could assign the miss-matched attributes to a string, and make the
test compare to empty? What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28705] Article requests: Renew should look at current requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 --- Comment #2 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #1) > Hi Marcel, can you explain how you expect it to work? > > Articles aren't checked out/don't need to be returned usually I think. Or > maybe I missed an alternative workflow? Here it's usually used with copies > that are kept by the patron. I need the physical material to make a photcopy or digital scan of it. When the book is renewed without checking, the request is delayed once more. Yeah, this is about more than articles actually. An article could be some pages of a regular book too in our context. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28705] Article requests: Renew should look at current requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 --- Comment #1 from Katrin Fischer --- Hi Marcel, can you explain how you expect it to work? Articles aren't checked out/don't need to be returned usually I think. Or maybe I missed an alternative workflow? Here it's usually used with copies that are kept by the patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28667] Check damaged item can be reserved in OPAC detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28667 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I get an error: Could not compile /kohadevbox/koha/opac/opac-detail.pl: Global symbol "$i" requires explicit package name (did you forget to declare "my $i"?) at /kohadevbox/koha/opac/opac-detail.pl line 725. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28705] Article requests: Renew should look at current requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Marcel de Rooy changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28705] New: Article requests: Renew should look at current requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Bug ID: 28705 Summary: Article requests: Renew should look at current requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The Article Requests feature has not been fully integrated with Koha's core circulation functions. Currently, the renew process does not look at current article requests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26088] Add optional fee for (scanned) article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26088 --- Comment #5 from Marcel de Rooy --- Bug 27946 is even kind of duplicate; could this one be closed ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26088 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26088] Add optional fee for (scanned) article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26088 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27946 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20684] Don't allow article requests on lost and missing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20684 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20570] Add script to complete scanned article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20570 --- Comment #5 from Marcel de Rooy --- Bug 20472 has been pushed! So we c/should revive this one here now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #57 from Peter Vashchuk --- Created attachment 122806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122806=edit Bug 28316: escape ES ranges if QueryAutoTruncate is enabled if QueryAutoTruncate enabled we will have any special operators ruined for example: "test [6 TO 7]" will be converted to "test* [6* TO* 7]" so no reason to keep ranges when QueryAutoTruncate set to "enabled" 1) enable QueryAutoTruncate at your sysprefs. 2) perform a search using range, for example: "[1999 TO 2020]", it shouldn't work the way it's supposed to. 3) apply the patch. 4) perform the same search with range, ensure that it works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #56 from Peter Vashchuk --- Created attachment 122805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122805=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the behavior with QueryRegexEscapeOptions set to values other than "Escape" still will works as expected. It does so by storing the contents of regexes before escaping special characters and then restores the contents of regexes back to how it was before, ensuring that searching with regex is possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #55 from Peter Vashchuk --- Created attachment 122804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122804=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at the end of the query makes ES search fail, and when you try to search for a book that has exclamation sign in the tittle (something like "Words! words") won't show results correctly as it tries to negate everything that is after exclamation sign, making it impossible to search for books that have in in the title This patch escapes exclamation signs if it's at the end of the query or has a space after it, resolving both of the issues listed above. To reproduce: 1) with ES enabled, search for the book with title that contains exclamation sight at the end, like "book!", this search should result in error. 2) do another search, but this time find/prepare beforehand book with a title that has exclamation sign with a space after it, e.g "exclamation! sign", it shouldn't find it as ES treats everything after that exclamation sign as negation. 2) apply the patch. 3) perform searches from the steep one and two again. Search from step one should no longer fail, while search from the step two should find that book. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #54 from Peter Vashchuk --- Created attachment 122803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122803=edit Bug 28316: escape brackets in the search query This patch screens square and curly brackets which have no special language meaning. To reproduce: 1) using ES, search for the book with title that contains square and/or curly brackets, like "book [second edition]", which will result in error. 2) apply the patch. 3) search for that book again, ensure that it works now. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #53 from Peter Vashchuk --- Created attachment 122802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122802=edit Bug 28316: screen unquoted semicolons and all followup colons Currently searches like: "book:", ":book" and "host-item:test:n" cause internal server errors. This patch adds additional regexes that remove the colons at the start and end of the query, and another regex that screens all follow-up colons that go after the first colon to avoid errors when searching for "host-item:test:n". To reproduce: 1) using ES, search for the book with title that contains semicolon at the start or at the end of the line, separated with spaces, this should cause internal server error. 2) try doing the same with something like "host-item:test:n", it should result in error as well. 3) apply the patch. 4) repeat steps 1-2, ensure that it works now. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What|Removed |Added Attachment #122201|0 |1 is obsolete|| Attachment #122202|0 |1 is obsolete|| Attachment #122203|0 |1 is obsolete|| Attachment #122204|0 |1 is obsolete|| Attachment #122205|0 |1 is obsolete|| Attachment #122206|0 |1 is obsolete|| --- Comment #52 from Peter Vashchuk --- Created attachment 122801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122801=edit Bug 28316: add tests Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28704] Library MARCOrgCode field needs maxlength attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 --- Comment #1 from Owen Leonard --- Created attachment 122800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122800=edit Bug 28704: Library MARCOrgCode field needs maxlength attribute This patch adds a maxlength attribute to the "MARC organization code" field in the form for adding and editing libraries. The maxlength, 16, matches the limit of the table column. To reproduce the problem, go to Administration -> Libraries. - Add or edit a library - Fill the "MARC organization code" field with a string longer than 16 characters, e.g. Decriminalization - When you save the record you will see an error. Apply the patch and add or edit a library. - Confirm that you cannot enter more than 16 characters in the "MARC organization code" field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28704] Library MARCOrgCode field needs maxlength attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Owen Leonard changed: What|Removed |Added Attachment #122772|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 122799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122799=edit Bug 28567: Fix 0 vs "" vs undef on the admin library form There are two things here: * Branches.pickup_location has a default = 1 in DB, we should not set to undef if 0 or it will be set to 1 when stored. * The other fields are all text (varchar, mediumtext or longtext) and can be NULL. They are correct set to NULL when a new library is created but set to an empty string when the library is modified. That's not consistent Test plan: 0. Don't apply the patch 1. Create a new library, set pickup location to "No" 2. Save => Pickup location is set to YES => In DB notice that the different values you didn't fill in are set to NULL 3. Edit the library 4. Save => In DB notice that the different values you didn't fill in are now set to an empty string 5. Apply the patch, restart_all 6. Run the updatedatabase script => In DB all the empty string values are set to NULL 7. Repeat 1 to 4 and confirm that everything is now working as expected Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28704] New: Library MARCOrgCode field needs maxlength attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28704 Bug ID: 28704 Summary: Library MARCOrgCode field needs maxlength attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: System Administration Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When adding or editing a library, the "MARC organization code" field should be limited to the maximum length defined in the table, which is 16. Otherwise the process will fail with an unhelpful message, "An error occurred when adding this library. The branchcode might already exist." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14237] Allow bibs to be added to course without items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 --- Comment #54 from Katrin Fischer --- Thx everyone, this one makes me especially happy :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24387] Rename News tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28703] New: Display problem in 505$a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 Bug ID: 28703 Summary: Display problem in 505$a field Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: h...@interleaf.ie QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 122798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122798=edit Appearance of arrows in 505 field Content in the 505$ a field (Formatted contents note) is displaying arrows at the beginning and end of the content. This was not appearing on the 19.11 release of Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28700] "Unblessed" method in Object.pm has blessed values for keys in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28700
Peter Vashchuk changed:
What|Removed |Added
Attachment #122776|0 |1
is obsolete||
--- Comment #3 from Peter Vashchuk ---
Created attachment 122797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122797=edit
Bug 28700: unblessed in Object.pm has blessed values in some cases
This "unblessed" sub acts as such: creates a hash from fields prepared
in memory by DBIX::Class. In case when we get data from DB our fields
are filled with scalars and all unblessed hash returned as keys with
scalar values. This is the expected behavior and feature for which
this method was created.
But in some cases, when we modify the DBIX::Class field in Perl code
(and then it get stored into DB), we pass some special objects to
DBIX::Class, not scalars. For example DateTime object. It is stored
in proper form into DB (converted by DBIX::Class to proper text form
with required date format), but still kept in memory for this field
_as object_! And this is the source of the bug: because now when we use
the "unblessed" method, the value for DATE or TIMESTAMP field is
returned for us by DBIX::Class in the same form as we provided it
some lines above in Perl code: i.e. as "DateTime Object".
For example: when the "dateaccessioned" column in the "items" table
is NULL, "dateaccessioned" gets prefilled by this Perl code
(file: KohaCommunity/Koha/Item.pm around line 198):
unless ( $self->dateaccessioned ) {
$self->dateaccessioned($today);
}
my $result = $self->SUPER::store;
if ( $log_action && C4::Context->preference("CataloguingLog") ) {
$action eq 'create'
? logaction( "CATALOGUING", "ADD", $self->itemnumber, "item" )
: logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item
" . Dumper( $self->unblessed ) );
}
it gets assigned with DateTime object, stored in Perl process in
DBIX::Class as Object, and converted to scalar only when stored to DB,
but, in the same code piece above, when we have
Dumper( $self->unblessed ), it is passed as blessed value for key
"dateaccessioned", so as we see, when we dumping this record just a few
lines below into object_log, the "dateaccessioned" value appears as a
blessed object rather than the standard date/time text scalar we expect
it to be.
This patch adds the ability for the "unblessed" subroutine in the
Object.pm to make scalar results for ref type DateTime.
I have chosen "->stringify" for DateTime because that anyway will
happen if we try to use the DateTime object in any strings,
concatenations, or prints. For now, it returns the iso8601 text date
which has all the needed data saved. It might be different from which
value stored in the end into DB because the DB field might be simpler
(just date), but anyway we _expect_ that unblessed method should give
just scalars as keys/values, or refs to deeper structures like
arrays/hashes but scalars as well, not objects inside
(nothing blessed inside).
I also added a warning for us to have it logged if we have any other
blessed values returned as a key by the unblessed method.
To reproduce:
1) at the items table pick any item you see fit, find the
"dateaccessioned" column of it, and set it NULL.
2) go to your koha and edit that item (doesn't matter what you change
as long as you make some change), save it afterward.
3) check the action_logs table and find there a newly created MODIFY
item row, "info" column of that contains dumped data, find
"dateaccessioned" among that data and notice that it is an object,
optional: check and note about the size of it.
4) apply the patch.
5) repeat steps 1-3, ensure that "dateaccessioned" contains usual
date/time data (iso8601 formatted in our case).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
