[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 David Cook changed: What|Removed |Added Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2799] branch transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2799 David Cook changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24562 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24562 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 David Cook changed: What|Removed |Added See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=2799|?id=27299 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2799] branch transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2799 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24562 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27928, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=2799 --- Comment #28 from David Cook --- Ohh... if we do a "git blame" we can see that Nick made a change which dates to March 2021 (bug 27928). Before that change, there was no maximum specified, so in theory FindDuplicate could have fetched *a lot* of records. That said, that seems unlikely, since we're doing "ti,ext" and "au,ext" searches. Although... that reminds me of a different issue. Bug 27299. There was/is an issue with ICU the phrase register which would've been used by a CCL search using a "ext" qualifier since it does a 'complete-field' search. I haven't noticed this problem with any of my CHR libraries but the 1 library that has reported the problem to me was a ICU library. So the resolution of bug 27928 and bug 27299 may have resolved this issue from Koha 21.05 onwards. I think that's a reasonably sound hypothesis. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27928] FindDuplicate is hardcoded to use Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24562 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #27 from David Cook --- (In reply to David Cook from comment #26) > It looks like we only ever use the 1st result from FindDuplicate, but we > return a copy of an array that (in theory) can contain up to 50 results. > > -- > > my ( $error, $searchresults, undef ) = > $searcher->simple_search_compat($query,0,50); > I've just created 50+ duplicate records that have an apostrophe in the title, and I've confirmed that FindDuplicate returns a maximum of 50 records (ie 100 array entries - 2 for each record). Looking at FindDuplicate, there's no reason why addbiblio.pl should consume 100% CPU when using that function. That suggests to me if there is an issue.. it's probably with Koha::SearchEngine::Search::Zebra::Search's simple_search_compat(), new_record_from_zebra(), or TransformMarcToKoha(). TransformMarcToKoha() does have a loop which gets run for every potential result, but it's not too consuming at a glance, and it should max out at 50 iterations. new_record_from_zebra() just creates a MARC::Record object. The one thing is that it could return a null result which isn't checked in FindDuplicate... but TransformMarcToKoha should carp() and return an empty hashref if it gets an undefined record. simple_search_compat() actually just uses C4::Search::SimpleSearch(). While there is some looping, it's all quite contained. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27928] FindDuplicate is hardcoded to use Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #10 from David Cook --- I think this may have inadvertently fixed Bug 24562. In theory, the max results could be 1 instead of 50, since all the code that uses FindDuplicate only ever takes the 1st result, but I suppose you never know... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562
--- Comment #26 from David Cook ---
Wow, FindDuplicate is so inefficient.
It looks like we only ever use the 1st result from FindDuplicate, but we return
a copy of an array that (in theory) can contain up to 50 results.
(Also there is a little syntax problem in Search.t although it doesn't affect
the test outcome.)
--
my ( $error, $searchresults, undef ) =
$searcher->simple_search_compat($query,0,50);
--
grep -R "FindDuplicate(" *
acqui/addorderiso2709.pl:$duplifound = 1 if
FindDuplicate($marcrecord);
acqui/neworderempty.pl:($biblionumber,$duplicatetitle) =
FindDuplicate($marcrecord);
C4/Search.pm:($biblionumber,$biblionumber,$title) = FindDuplicate($record);
cataloguing/addbiblio.pl:( $duplicatebiblionumber, $duplicatetitle ) =
FindDuplicate($record);
opac/opac-suggestions.pl:if ( my ($duplicatebiblionumber, $duplicatetitle)
= FindDuplicate($biblio) ) {
suggestion/suggestion.pl:elsif ( !$suggestion_only->{suggestionid} && ( my
($duplicatebiblionumber, $duplicatetitle) = FindDuplicate($biblio) ) &&
!$save_confirmed ) {
t/db_dependent/Search.t:($biblionumber,undef,$title) =
FindDuplicate($record);
t/db_dependent/Search.t:($biblionumber,undef,$title) =
FindDuplicate($record);
t/db_dependent/Search.t:warning_is {
C4::Search::FindDuplicate($record_1);}
t/db_dependent/Search.t:warning_is {
C4::Search::FindDuplicate($record_2);}
t/db_dependent/Search.t:warning_is {
C4::Search::FindDuplicate($record_3);}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562
--- Comment #25 from David Cook ---
(In reply to Jawad Makki from comment #21)
>
> the suggested modification (to add $result->{title} =~ s /\'//g;) in
> C4/Search.pm has solved the problem.
> the sub FindDuplicate is not overloading the CPU anymore when it is called
> from addbiblio.pl
>
This is really interesting. I've created 2 duplicate records in Koha with an
apostrophe in the title and I'm not having any issues.
What exact title are you using?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Bug 27318 depends on bug 25405, which changed state. Bug 25405 Summary: Make separation of Shibboleth and Local login clearer in modal login on OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What|Removed |Added Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 --- Comment #28 from Lucas Gass --- > Admittedly, my interest in this is personal rather than business. I suppose > having multiple auth options doesn't really make sense for a library OPAC. > Maybe we should mark this one as invalid... I agree here and I am setting this to invalid, thanks David. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no notice is defined for the user's preferred language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712 Katrin Fischer changed: What|Removed |Added Version|unspecified |21.05 --- Comment #3 from Katrin Fischer --- Should have added we are seeing this in latest 20.11. I believe it's also in 21.05. Bug 26734 doesn't qualify for backporting (changes to notices), so we might want an easy temp fix here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 --- Comment #25 from Katrin Fischer --- (In reply to Katrin Fischer from comment #24) > https://translate.koha-community.org/de/21.05/translate/ > #search=Preserve%20existing%20values&sfields=source,target Turned out to be a mistake on creating the po files - Koha codebase is ok and po files are now too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28721] New: Holds Ratio fails when all copies are unavailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28721 Bug ID: 28721 Summary: Holds Ratio fails when all copies are unavailable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: - find a bib with just 1 item on it - confirm the item is not notforloan, damaged, lost, or withdrawn - place 3 holds on the title - go to the holds ratio in circulation, confirm your title shows when the ratio is set to 3 - go back to your item, set it to lost - reload the holds ratio, see your title is no longer listed In the scenario above, we end up dividing by zero because there are no available items. This messes up our ratio and makes this title not show as needing more copies, even though our ratio is definitely less than 3 copies per hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28677] Add the word "calendar" to the description for ExpireReservesOnHolidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28677 --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 122956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122956&action=edit Bug 28677: Update wording on ExpireReservesOnHolidays To test: 1: look at ExpireReservesOnHolidays syspref description 2: apply patch, restart 3: look at wording again, see that it now clarifies that it only pertains to systems using ExpireReservesMaxPickUpDelay and includes the word "calendar" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28677] Add the word "calendar" to the description for ExpireReservesOnHolidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28677 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 --- Comment #15 from Lucas Gass --- Created attachment 122955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122955&action=edit Bug 28717: (follow-up) add title to logged information -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Lucas Gass changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #65 from Jonathan Druart --- Patches have been rebased (easy conflicts with bug 17600). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122696|0 |1 is obsolete|| --- Comment #64 from Jonathan Druart --- Created attachment 122954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122954&action=edit Bug 27526: Fix Add multiple copies This has been moved to Koha::Item->store by bug 27545. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122695|0 |1 is obsolete|| --- Comment #63 from Jonathan Druart --- Created attachment 122953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122953&action=edit Bug 27526: Fix Add & duplicate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122694|0 |1 is obsolete|| --- Comment #62 from Jonathan Druart --- Created attachment 122952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122952&action=edit Bug 27526: Fix PrefillItem We are basically adding: $current_item = $item->unblessed; Other changes are for readability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122682|0 |1 is obsolete|| --- Comment #61 from Jonathan Druart --- Created attachment 122951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122951&action=edit Bug 27526: Fix mandatory and important checks The input names have been changed from "field_value" to $kohafield. Modifying this could have an impact in other area, where CheckMandatorySubfields and CheckImportantSubfields are called. Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones. Note that the other ones are actually broken (!) Also note that there is a typo in the error message alertString2 += "\n- " + "%s " + MSG_MANDATORY_FIELDS_EMPTY.format(total_errors); There is an extra %s Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122681|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart --- Created attachment 122950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122950&action=edit Bug 27526: Fix repeatable more subfields We retrieved always the first value. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122658|0 |1 is obsolete|| --- Comment #59 from Jonathan Druart --- Created attachment 122949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122949&action=edit Bug 27526: Improve grep for date fields 'replacementpricedate' should not catch 'price' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122657|0 |1 is obsolete|| --- Comment #58 from Jonathan Druart --- Created attachment 122948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122948&action=edit Bug 27526: Adjust code to use Koha::Items Not that we removed all the transformations of the item and are using Koha::Item from DB to TT (and the other way around), some code needs adjustments. - Retrieve host items can be simplified (see Koha::Biblio->host_items) - Some TT variables have been renamed for better understanding - Koha::Item->columns_to_str return a hashref with the representation string of the columns. A date will return the value how it must be displayed, using output_pref. A subfield linked with a AV will be replaced with the AV's description. - LastCreatedItem cookie serializes and stores Koha::Item->unblessed, no longer the MARC::Record Change in behaviour: If a subfield is linked with a AV cat and the value is not a valid AV, before this patch the column was displayed with an empty value. Now the column is hidden, it's considered empty. In the sample data it happens with itemlost (0) and withdrawn (0). Test plan: 1. Test the Prefill a. Turn PrefillItem on b. Fill in SubfieldsToUseWhenPrefill with some subfield codes c. Catalogue an item, save => The values from subfields listed in SubfieldsToUseWhenPrefill must be kept 2. more subfields a. Add subfields that are not linked with a koha field (k is available) b. Create an item and fill in all the values c. Confirm that non linked subfields are stored and displayed correctly d. Try with a "more subfield" that is linked with an authorised value category 3. Test barcode values 4. Test the different "Add" buttons at the bottom of the form Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122656|0 |1 is obsolete|| --- Comment #57 from Jonathan Druart --- Created attachment 122947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122947&action=edit Bug 27526: Remove AddItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122655|0 |1 is obsolete|| --- Comment #56 from Jonathan Druart --- Created attachment 122946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122946&action=edit Bug 27526: Remove ModItemFromMarc from additem Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #107 from Jonathan Druart --- Follow-ups have been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28541 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28338 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #106 from Jonathan Druart --- Created attachment 122945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122945&action=edit Bug 17600: Fix batchMod.pl Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_tools_batchMod_2epl::haspermission called at /kohadevbox/koha/tools/batchMod.pl line 89 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 --- Comment #14 from Owen Leonard --- This works well, so I've signed off. I'd love to see a follow-up which adds title to the logged information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Owen Leonard changed: What|Removed |Added Attachment #122943|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 122944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122944&action=edit Bug 28717: Add logging logic to koha-news.pl To test: 1. have some news items 2. make sure NewsLog is turned on 3. Add, modify, and delete some news 4. Check the action logs, nothing is logged 5. Apply patch 6. do step 3 again 7. now changes should be logged 8. make sure you try deleting multiple news items at once and confirm that all deletions are logged Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #153 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #152)
> (In reply to Jonathan Druart from comment #150)
> > 4.
> > in move_to_biblio you are calling, on a DBIC rs, ->update, then update_all:
> > 1237 $hold_fill_target->update({ biblionumber => $to_biblionumber
> > });
> >
> > 1254 $linktrackers->update_all({ biblionumber => $to_biblionumber });
> >
> > It's not consistent, is there a good reason for that?
> >
> > Please provide a fast reply, I can write the follow-up patches if needed.
>
> I think this is simply because we didn't have a Koha:: based resultset yet
> and he didn't want to add further complexity to the patch by adding that new
> class as well. Having said that, it's fairly trivial to add such a class so
> long as it's a basic one, so perhaps we should for consistency.
Both are "raw" DBIC resultsets :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #5 from Jonathan Druart --- There is also bootstrap-datepicker - https://github.com/uxsolutions/bootstrap-datepicker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > * time format (now it's 12h when the syspref is 24h) Well, maybe not, but it's confusing! https://snipboard.io/IzOBMF.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #3 from Jonathan Druart --- Yes, go for it! Can we have a working version of the patch? I would like, as a first step, a POC witch takes care of two occurrences, a simple one and a complex one. We need to think about the edge cases: * time format (now it's 12h when the syspref is 24h) * manual editing * format validation * range validation (from/to) * "from today only" (no date from the paste) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 Jonathan Druart changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #152 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #150)
> 1. Why Koha::Item->item_orders is not named Koha::Item->orders?
> It returns a Koha::Acquisition::Orders.
This should certainly be named 'orders', annoyed I overlooked that during QA :(
>
> 2.
> in move_to_biblio
> 1215 return unless $self->biblionumber != $to_biblio->biblionumber;
> I am a fan of unless, not when there is a negation in the test :)
> return if $self->biblionumber == $to_biblio->biblionumber;
> Read much better IMO.
Agreed.
>
> 3. There is Koha::Item->move_to_biblio($biblio) and
> Koha::Biblio->adopt_items_from_biblio($biblio)
> Don't you think Koha::Biblio->adopt_items_from_biblio could be
> Koha::Items->move_to_biblio actually?
> It would be more consistent and flexible.
Hmmm, I think so long as the method name is clear I was happy for it to live in
either class. I do see what you mean though and for consistency, I certainly
like that.
>
> 4.
> in move_to_biblio you are calling, on a DBIC rs, ->update, then update_all:
> 1237 $hold_fill_target->update({ biblionumber => $to_biblionumber
> });
>
> 1254 $linktrackers->update_all({ biblionumber => $to_biblionumber });
>
> It's not consistent, is there a good reason for that?
>
> Please provide a fast reply, I can write the follow-up patches if needed.
I think this is simply because we didn't have a Koha:: based resultset yet and
he didn't want to add further complexity to the patch by adding that new class
as well. Having said that, it's fairly trivial to add such a class so long as
it's a basic one, so perhaps we should for consistency.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Jonathan Druart --- Sorry, it was caused by my rebase. I didn't get the conflict when I applied it this morning, it auto-solved using a previous resolution (that was wrong apparently!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What|Removed |Added Attachment #122941|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 122943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122943&action=edit Bug 28717: Add logging logic to koha-news.pl To test: 1. have some news items 2. make sure NewsLog is turned on 3. Add, modify, and delete some news 4. Check the action logs, nothing is logged 5. Apply patch 6. do step 3 again 7. now changes should be logged 8. make sure you try deleting multiple news items at once and confirm that all deletions are logged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|stalkern...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard --- When I try to delete multiple news entries at one time I get an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column '29' in 'where clause' [for Statement "DELETE FROM `opac_news` WHERE ( ( `29` = ? AND `idnew` = ? ) )" with ParamValues: 0="27", 1="44"] at /kohadevbox/koha/Koha/Objects.pm line 208 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 The deletions fail but are logged as if they were successful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #3 from Jonathan Druart --- Tomas, can you take a look at this bug please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart changed: What|Removed |Added Summary|Koha/Acquisition/Orders.t |Koha/Acquisition/Orders.t |is failing (randomly?) |is failing randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #6 from Jonathan Druart --- Created attachment 122942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122942&action=edit Bug 28509: Prevent Koha/Acquisition/Orders.t to fail randomly The random errors were: 03:25:39 koha_1 | # Structures begin differing at: 03:25:39 koha_1 | # $got->[0] = '10' 03:25:39 koha_1 | # $expected->[0] = '9' and 16:36:15 koha_1 | # Structures begin differing at: 16:36:15 koha_1 | # $got->[0] = '100' 16:36:15 koha_1 | # $expected->[0] = '99' You see it coming? We sorted the ordernumbers alphabetically. Test plan: 0. Don't apply this patch 1. % git checkout v21.05.01 # The error is not appearing in master right now 2. Add 2 warn statements before the 'The 2 orders are returned' tests to display $order_1->ordernumber and $order_2->ordernumber 3. MariaDB CLI > ALTER TABLE aqorders AUTO_INCREMENT=3; 4. prove t/db_dependent/Koha/Acquisition/Orders.t => Fail with # Structures begin differing at: # $got->[0] = '10' # $expected->[0] = '9' 5. Apply this patch, repeat 3. and 4. => The test passes now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Koha_21.05_D9/26 D5 16:51:24 koha_1 | # Failed test 'The 2 orders are returned' 16:51:24 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 152. 16:51:24 koha_1 | # Structures begin differing at: 16:51:24 koha_1 | # $got->[0] = '10' 16:51:24 koha_1 | # $expected->[0] = '9' 16:51:24 koha_1 | # Looks like you failed 1 test of 4. 16:51:24 koha_1 | 16:51:24 koha_1 | # Failed test 'filter_by_id_including_transfers() tests' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > (In reply to Jonathan Druart from comment #1) > > Master_D9_MDB_Latest/612 > > This was on Docker_2. 16:36:15 koha_1 | # Failed test 'The 2 orders are returned' 16:36:15 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 152. 16:36:15 koha_1 | # Structures begin differing at: 16:36:15 koha_1 | # $got->[0] = '100' 16:36:15 koha_1 | # $expected->[0] = '99' 16:36:15 koha_1 | # Looks like you failed 1 test of 4. 16:36:15 koha_1 | 16:36:15 koha_1 | # Failed test 'filter_by_id_including_transfers() tests' 16:36:15 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 160. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > Master_D9_MDB_Latest/612 This was on Docker_2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28509] Koha/Acquisition/Orders.t is failing (randomly?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28509 --- Comment #2 from Jonathan Druart --- Koha_21.05_D9/26 D5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28674] old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28674 Jonathan Druart changed: What|Removed |Added Component|Project website |Database CC||jonathan.druart+koha@gmail. ||com QA Contact||testo...@bugs.koha-communit ||y.org Keywords||Academy Product|Project Infrastructure |Koha Assignee|wizzy...@gmail.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What|Removed |Added Attachment #122927|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 122941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122941&action=edit Bug 28717: Add logging logic to koha-news.pl To test: 1. have some news items 2. make sure NewsLog is turned on 3. Add, modify, and delete some news 4. Check the action logs, nothing is logged 5. Apply patch 6. do step 3 again 7. now changes should be logged 8. make sure you try deleting multiple news items at once and confirm that all deletions are logged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #194 from Jonathan Druart --- (In reply to Martin Renvoize from comment #193) > (In reply to Jonathan Druart from comment #192) > > Martin, shouldn't we apply the following change to make the db rev > > idempotent? > > > > -$dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != > > 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND ( debit_id IS NULL OR > > credit_id IS NULL)" ); > > +$dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != > > 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND type != 'APPLY' AND ( > > debit_id IS NULL OR credit_id IS NULL)" ); > > Hmm, it wouldn't do any harm, though I believe we shouldn't have any cases > where APPLY exists where debit_id or credit_id is null. Correct, forget that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #193 from Martin Renvoize --- (In reply to Jonathan Druart from comment #192) > Martin, shouldn't we apply the following change to make the db rev > idempotent? > > -$dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != > 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND ( debit_id IS NULL OR > credit_id IS NULL)" ); > +$dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != > 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND type != 'APPLY' AND ( > debit_id IS NULL OR credit_id IS NULL)" ); Hmm, it wouldn't do any harm, though I believe we shouldn't have any cases where APPLY exists where debit_id or credit_id is null. Thanks for the whitespace fix, I'll have to double check my git config.. seems I lost something on the last reset of that environment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28717] NewsLog doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Owen Leonard --- Does not apply cleanly on top of Bug 28718 or master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28718] Can't delete multiple news items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718 Owen Leonard changed: What|Removed |Added Attachment #122898|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 122940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122940&action=edit Bug 28718: handle multiple deletions from news To test: 1. have multiple news 2. check several of them and and click 'Delete selected' 3. see ugly error 4. apply patch 5. try again 6. no error Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28718] Can't delete multiple news items at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28718 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 --- Comment #24 from Katrin Fischer --- https://translate.koha-community.org/de/21.05/translate/#search=Preserve%20existing%20values&sfields=source,target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 --- Comment #23 from Katrin Fischer --- (In reply to Kyle M Hall from comment #22) > Enhancement not backported to 21.05 There is something odd going on here. Strings from this have showed up in 21.05 translations I did today? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 Jonathan Druart changed: What|Removed |Added Attachment #122936|0 |1 is obsolete|| --- Comment #151 from Jonathan Druart --- Created attachment 122939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122939&action=edit Bug 22690: Remove MoveItemFromBiblio import Added in the meanwhile by bug 17600. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #150 from Jonathan Druart ---
1. Why Koha::Item->item_orders is not named Koha::Item->orders?
It returns a Koha::Acquisition::Orders.
2.
in move_to_biblio
1215 return unless $self->biblionumber != $to_biblio->biblionumber;
I am a fan of unless, not when there is a negation in the test :)
return if $self->biblionumber == $to_biblio->biblionumber;
Read much better IMO.
3. There is Koha::Item->move_to_biblio($biblio) and
Koha::Biblio->adopt_items_from_biblio($biblio)
Don't you think Koha::Biblio->adopt_items_from_biblio could be
Koha::Items->move_to_biblio actually?
It would be more consistent and flexible.
4.
in move_to_biblio you are calling, on a DBIC rs, ->update, then update_all:
1237 $hold_fill_target->update({ biblionumber => $to_biblionumber });
1254 $linktrackers->update_all({ biblionumber => $to_biblionumber });
It's not consistent, is there a good reason for that?
Please provide a fast reply, I can write the follow-up patches if needed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #149 from Jonathan Druart --- Created attachment 122938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122938&action=edit Bug 22690: Add missing txn_begin in subtest -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds history for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Jonathan Druart changed: What|Removed |Added Blocks||28631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 [Bug 28631] Holds History title link returns "not found" error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28631] Holds History title link returns "not found" error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28631 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Depends on||20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #192 from Jonathan Druart --- Martin, shouldn't we apply the following change to make the db rev idempotent? -$dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND ( debit_id IS NULL OR credit_id IS NULL)" ); +$dbh->do( "UPDATE account_offsets SET type = 'CREATE' WHERE type != 'OVERDUE_INCREASE' AND type != 'OVERDUE_DECREASE' AND type != 'APPLY' AND ( debit_id IS NULL OR credit_id IS NULL)" ); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Jonathan Druart changed: What|Removed |Added Attachment #122918|0 |1 is obsolete|| --- Comment #191 from Jonathan Druart --- Created attachment 122937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122937&action=edit Bug 22435: (follow-up) Set CREATE offset for credits to positive The history view of an accountline shows increases and decreases in the amount outstanding from the perspective of the credit/debit line you are inspecting. Apply creates a negative offset amount which acts to 'reduce' both the outstanding 'debt' for the debit line and the outstanding 'credit' for the credit line. Starting with a negative offset for the credit thus makes this nonsenical. Void creates positive offset amounts which act to 'restore' both the outstanding 'debt' for the debit line and the outstanding 'credit' for the credit line. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi JD Amended patch: Remove trailing spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 --- Comment #148 from Jonathan Druart --- Created attachment 122936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122936&action=edit Bug 22690: Remove MoveItemFromBiblio import Added in the meanwhile by bug 17600. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Jonathan Druart changed: What|Removed |Added Summary|When refunding lost fees we |Add tests for Voided |should not include voided |Payment and Voided |payments|Writeoff. Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #8 from Jonathan Druart --- Thanks, Galen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Summary|Is misc/kohalib.pl still|misc/kohalib.pl no longer |useful? |useful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #7 from Jonathan Druart --- Created attachment 122935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122935&action=edit Bug 28617: Remove kohalib.pl and rely on PERL5LIB The purpose of this script was to load the relevant Koha lib for the different scripts (installation, cronjob, CLI, etc.) However it is not used consistently and we prefer to rely on PERL5LIB. From bug 28617 comment 6 from Galen: """ Time marches on, and one of the motivations for having kohalib.pl - making it possible to install Koha without setting a single environment variable - has been obviated by the vast improvements in the ease of installing Koha. Consequently, I think kohalib.pl can go away. """ Test plan: confirm that the changes make sense and that kohalib.pl can be removed safely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28705] Article requests: Renew should look at current requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- Silly question, do we highlight there's an article request pending at check-in already.. if not I could see that being nicely folded in here too.. I would be helpful to have such cases flagged at return so the item can be put to one side to process the article request. Generally, though, this seems like a nice feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #24 from David Cook --- One of my libraries (before they joined us) did a lot of customizations to FindDuplicate to get around this problem. Their customizations were all about making the query more specific. In theory, the max number of results to be returned is 50. That's quite a few, especially since we're running an inefficient TransformMarcToKoha over every one of those results. I'll have to look into this more. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
