[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #27 from David Cook --- (In reply to David Cook from comment #26) > (In reply to David Cook from comment #21) > > There's another potential SCO regression I'll be looking into later today as > > well... need to confirm that it's a problem in master first though. > > The other regression I was looking for wasn't there, so must be a local > problem I'm having. > > Thanks, Jonathan for this one. Actually, it's not so much a regression as a security bug. Hurray. I love these. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #26 from David Cook --- (In reply to David Cook from comment #21) > There's another potential SCO regression I'll be looking into later today as > well... need to confirm that it's a problem in master first though. The other regression I was looking for wasn't there, so must be a local problem I'm having. Thanks, Jonathan for this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added Attachment #122773|0 |1 is obsolete|| --- Comment #25 from David Cook --- Created attachment 123023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123023=edit Bug 28660: (bug 21325 follow-up) Fix auto self check Signed-off-by: Marcel de Rooy Works as expected. The need for an additional check of pref WebBasedSelfCheck is merely theoretical. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #24 from David Cook --- testing 1 commit(s) (applied to 3748efc 'ab Bug 28731: (bug 17600 follow-up) I') Processing files before patches |>| 1 / 1 (100.00%) Processing files after patches |>| 1 / 1 (100.00%) OK C4/Auth.pm Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #23 from David Cook --- Test plan: 0. Don't apply patch yet 1. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 2. Note that you are prompted with a regular Koha login screen 3. Apply patch 4. koha-plack --restart kohadev 5. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 6. Note that you are prompted with a Koha Self checkout system login screen 7. Log into the self checkout and note it works 8. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 9. Log into Koha and note it works -- Well that's good enough for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28660] Self checkout is not automatically logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28660 --- Comment #22 from David Cook --- Ok finally getting to this. It would've been good to have a test plan but I'll whip one up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #55 from Aleisha Amohia --- (In reply to Marcel de Rooy from comment #49) > There is a problem with these mails. I do not have an attachment, but this > is in the body: > I think that is the way MIME::Lite works but correct me if I'm wrong! I think the attachment gets embedded in the email. So hard to test by looking at the message queue or notices tab, would be good to test with the actual email sent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #54 from Aleisha Amohia --- Created attachment 123022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123022=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #121038|0 |1 is obsolete|| --- Comment #53 from Aleisha Amohia --- Created attachment 123021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123021=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Attachment #121037|0 |1 is obsolete|| --- Comment #52 from Aleisha Amohia --- Created attachment 123020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123020=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28647] administration_tasks.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28647 --- Comment #7 from Victor Grousset/tuxayo --- Running prove t/db_dependent/selenium/administration_tasks.t in a loop without the patches. And hope that on your machine there isn't a too low probability of failure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #13 from Aleisha Amohia --- Created attachment 123019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123019=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #12 from Aleisha Amohia --- Created attachment 123018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123018=edit Bug 27266: (QA follow-up) Rename to get_marc_authors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What|Removed |Added Attachment #118312|0 |1 is obsolete|| --- Comment #11 from Aleisha Amohia --- Created attachment 123017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123017=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 --- Comment #11 from Aleisha Amohia --- I have added a patch to fix this at Bug 28734 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #1 from Aleisha Amohia --- Created attachment 123016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123016=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Aleisha Amohia changed: What|Removed |Added Blocks||28734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch Depends on||27268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] New: Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Bug ID: 28734 Summary: Koha::Biblio->get_marc_notes should use XSLTParse4Display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Bug 27268 moved C4::Biblio::GetMarcNotes to Koha::Biblio->get_marc_notes, but neglected to include the call to XSLTParse4Display. This means that authorised values aren't being replaced with their descriptions. To reproduce: 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. <-- BUG -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28733] New: Desks link is in "Patrons and circ" section on admin homepage but in "Basic Parameters" on the sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28733 Bug ID: 28733 Summary: Desks link is in "Patrons and circ" section on admin homepage but in "Basic Parameters" on the sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If UseCirculationDesks is enabled, the link to Desks shows up in the "Patrons and circ" section on admin homepage but in the "Basic Parameters" on the sidebar. We should move it on the sidebar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #39 from Agustín Moyano --- (In reply to Marcel de Rooy from comment #31) > Note comment24 (maybe Tomas could have a look too?) > Note comment29 > > And a few other points needing attention still: > > TODO Behavior of "Set request as pending" > => The New(number) is not updated, nor the Pending(number) > => Same for Process btw now. > > TODO The staff home page does no longer show New requests. It shows pending > requests. Hi Marcel, sorry about that.. Set request as pending worked well before rebase. Now its fixed. Cheers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not correctly set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28732] New: Order and claim emails don't work well with repeatable information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28732 Bug ID: 28732 Summary: Order and claim emails don't work well with repeatable information Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org There is an issue with how the repeatable part of the notice is figured out. This sets some strict limits to how you can write the notice template. It appears that the repeat will happen from first to the last placeholder from an acq table used in the notice. The tags don't appear to be used at all. Test plan: - Create a basket with more than one order line - Set up a notice called ACQORDER for sending order emails (templats below) - Make sure the vendor has an email set and all checkboxes in the contact are checked - Make sure your system can send emails - Click button "send order e-mail" on the basket summary page ACQORDER TEMPLATE 1: [%- USE Price -%] Dear... Title: <>Author: <>Edition: <>Year: <>ISBN: <>Units: <>Price: [% <> | $Price %] EUR Thank you! RESULT: Dear and Thank you only appear once. OK. Dear... Title: ... Author: ... Edition: 1. Auflage, Originalausgabe Year: ISBN: 9783839225837 Units: 1 Price: 13.99 EUR Title: ... Author: Edition: Year: 2020 ISBN: Units: 1 Price: 13.00 EUR Thank you! ACQORDER TEMPLATE 2: Only addition/change is the second line. [%- USE Price -%] Order: <> Dear... Title: <>Author: <>Edition: <>Year: <>ISBN: <>Units: <>Price: [% <> | $Price %] EUR Thank you! RESULT: Order:... and Dear... lines are repeated. For information from the basket this doesn't make sense. If you add a field from the branches table, this doesn't appear to cause any additional repeats. Order: 28.4.2021 Dear... Title: ... Author: ... Edition: 1. Auflage, Originalausgabe Year: ISBN: 9783839225837 Units: 1 Price: 13.99 EUR Order: 28.4.2021 Dear... Title: ... Author: Edition: Year: 2020 ISBN: Units: 1 Price: 13.00 EUR Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28725] ACQORDER email no longer prints more than one order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28725 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- I can happily close this as the problem was in front of the computer: Order lines that are cancelled or already received won#t be printed. Testing this on a basket with several unreceived orders works well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28725] ACQORDER email no longer prints more than one order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28725 --- Comment #1 from Katrin Fischer --- I am still investigating. The below templates works for acq claims, but not for orders: <> <> <> <> <> <> Ordernumber <> (<>) (<> ordered) (each $<> €). As the code for the orders is based on the code for the claims... where is the difference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path header not correctly set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Katrin Fischer changed: What|Removed |Added Summary|Return-path Header not |Return-path header not |correctly set in emails |correctly set in emails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master --- Comment #3 from Jonathan Druart --- Patch pushed to master for 21.11.00 Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Jonathan Druart changed: What|Removed |Added Attachment #123014|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 123015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123015=edit Bug 28731: (bug 17600 follow-up) Import necessary subroutines in reports svc endpoint TO test: 1 - Write a report 2 - Click the svc link in the saved reports list 3 - ISE 4 - Make report public 5 - Click the svc link in saved reports list 6 - ISE 7 - Apply patch 8 - Comfirm opac/public link works 9 - Make report not public 10 - Confirm the internal svc link works Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15349] Problem with email pattern check on forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 --- Comment #6 from Katrin Fischer --- (In reply to Nick Clemens from comment #5) > Could we either: > 1 - add an 'Email display name' field for branches > 2 - add a syspref that adds the branch name to the from field when sending > emails? Hm why not change the validation and allow adding them directly? We have disabled the validation on the branch email field and added things like "Library xy " and it does actually work well in production for a long time. At least in 18.11, but also in my tests with 20.11. At least in our setup where we are also using Reply-to and return-path. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 --- Comment #1 from Nick Clemens --- Created attachment 123014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123014=edit Bug 28371: (bug 17600 follow-up) Import necessary subroutines in reports svc endpoint TO test: 1 - Write a report 2 - Click the svc link in the saved reports list 3 - ISE 4 - Make report public 5 - Click the svc link in saved reports list 6 - ISE 7 - Apply patch 8 - Comfirm opac/public link works 9 - Make report not public 10 - Confirm the internal svc link works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Nick Clemens changed: What|Removed |Added Blocks||28731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Depends on||17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28731] New: Subroutines not explicitly imported in reports svc (opac and staff)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731 Bug ID: 28731 Summary: Subroutines not explicitly imported in reports svc (opac and staff) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15349] Problem with email pattern check on forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 --- Comment #5 from Nick Clemens --- Could we either: 1 - add an 'Email display name' field for branches 2 - add a syspref that adds the branch name to the from field when sending emails? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #8 from Owen Leonard --- The only thing I've found so far that Flatpickr lacks compared to jQueryUI is an option to show a "Today" button in the calendar widget. There is an addon which can provide this (https://github.com/jcsmorais/shortcut-buttons-flatpickr) but I'm not sure it's worth adding another dependency. FWIW you can type the word "today" in a Flatpickr date field and it will correctly interpret it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard changed: What|Removed |Added Attachment #121257|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 123013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123013=edit Bug 28367: PROOF OF CONCEPT Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). NEW: I've modified the default configuration of Flatpickr instances so that a "Clear date" link is automatically appended. This eliminates the need to add a button to the markup and event handling for each case. NEW: Date/time formatting should be corrected in this revised patch. The patch modifies three pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - NEW: You can also test the datepicker shown when you renew an on-hold item. This demonstrates a configuration which requires that the selection be after today. - Administration -> Patron categories -> New category, to demonstrate a calendar-only date picker enforcing a date after today. - NEW: Reports -> Patrons. The "Date of birth" fields are linked so that the second cannot be before the first. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28730] Add option to format AH field (due date) in SIP checkout response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28730] Add option to format AH field (due date) in SIP checkout response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 --- Comment #1 from Nick Clemens --- Created attachment 123012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123012=edit Bug 28730: Add option to format AH field (due date) in SIP checkout response This patch adds a new option to sip accounts: format_due_date If set to 1 the AH field in checkouts will follow the dateFormat system preference and format as due dates (ignoring time portion if 23:59:59 or 11:59:59) To test: 1 - checkout an item via SIP: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 30001 --patron enda -m checkout 2 - Note the AH field is like "MMDDHHMMSS" 3 - Apply patch 4 - repeat SIP checkout - nothing has changed 5 - edit SIPConfig.xml and add format_due_date="1" to 'term1' account: 6 - restart all 7 - repeat the SIP checkout 8 - AH field now matches dateFormat system preference 9 - Change your dateFormat preference 10 - repeat the SIP checkout 11 - AH matches new format Note: If you cannot renew and don't get an AH just check the item back in: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -t CR --item 30001 --patron enda -m checkin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28730] Add option to format AH field (due date) in SIP checkout response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path Header not correctly set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Katrin Fischer changed: What|Removed |Added Version|20.05 |20.11 CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28730] New: Add option to format AH field (due date) in SIP checkout response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28730 Bug ID: 28730 Summary: Add option to format AH field (due date) in SIP checkout response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org According to SIP2 spec on due date/AH: This date field is not necessarily formatted with the ANSI standard X3.30 for date and X3.43 for time. Since it is a variable-length field the ACS can send this date field in any format it wishes. Some machines pass this directly to the checkout receipt, we should be able to format as a due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] Return-path Header not correctly set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 --- Comment #1 from Katrin Fischer --- Tests were done using the cart email (directly sent) and the checkout notice (goes through message_queue). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28729] New: Return-path Header not correctly set in emails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28729 Bug ID: 28729 Summary: Return-path Header not correctly set in emails Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com We have been testing the email setup in Koha comparing our 18.11 installations with a 20.11 one. In those tests we see an issue with the Return-Path header. The Return-Path header should be using (if set) the * ReturnpathDefault system preference * Return-Path from library configuration But in 20.11 we see that it's set using * KohaAdminEmailAddress * branch email This is quite an issue. Wer are using specific and different email addresses for each of those settings: * KohaAdminEmailAddress / branch email * ReturnPathDefault / return-path for library * ReplytoDefault / reply to for library Something between versions has changed to cause the change in the Return-Path header. Maybe another side effect of the SMTP library change? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #67 from Victor Grousset/tuxayo --- I missed the two previous messages. At the first glance it seems the «No reserves HOLD letter transported by print» isn't related to the other stuff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #66 from Victor Grousset/tuxayo --- Hi, just letting know that I'm investigating the «No reserves HOLD letter transported by print» warning/error. Just the message, not the failure of the test.(maybe linked, I didn't looked at all) So this is weird, it finds a template for - reserves - reserves but not for reserves When the letter table contains only - reserves - reserves So it shouldn't for sms but should for print The same query (from Notice/Templates.pm PoV) on the previous test The warning/error comes from "Itemnumber should not be removed when the waiting status is revert" "Itemnumber should be set on hold confirmation" More precisely the ModReserveAffect() call before the assertion of the above tests. After `cpanm DBIx::QueryLog` adding `DBIx::QueryLog` before the call to the ORM. I can see that the params are correct. The query is: SELECT COUNT( * ) FROM `letter` `me` WHERE ( ( ( `branchcode` = 'Rvfd7OyOU8' OR `branchcode` = '' ) AND `code` = 'HOLD' AND `lang` = 'default' AND `message_transport_type` = 'print' AND `module` = 'reserves' ) ); Which yields 1 when ran in mariadb client. (right after interupting the tests with die: after ModReserveAffect() ) But when using dbh() with the same query right before and after the DBIx one is done (there are two ->count calls). Is yields 0. That's what I've found so far. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #29 from Nick Clemens --- I am seeing the same callnumbers for every branch, to recreate: 1 - sudo koha-mysql kohadev 2 - UPDATE items SET itemcallnumber=barcode; 3 - Add 5 items for a single branch (IPT) with IPT1-5 as barcodes and "IPT" as item callnumber 4 - Display in opac: Availability: Items available for loan: Midway (1) Call number: 313351, 313375, 313399, Centerville (3) Call number: 313351, 313375, 313399, Fairview (1) Call number: 313351, 313375, 313399, Institut Protestant de Théologie (5) Call number: 313351, 313375, 313399, ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28719] Cannot edit serials when deleted the selected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28719
--- Comment #3 from Alexis Ripetti ---
I forgot to add a test plan, so :
1- Search for a serial
2- Pick one
3- Go to 'Serial collection' on the left
4- An issue should be selected if you're expected a new issue
5- delete it using 'Delete selected issues'
6- Confirm deletion
7- If you're supposed to receive more issues the next one should now be there
8- Now edit the serial ('Edit serials')
9- See that the link leads to nothing
10- Apply patch and redo steps 1 to 8
11- See that the link now leads to something
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #2 from Andrew Fuerste-Henry --- Turns out that link was doing something -- clicking it changed the ratio value for your search to the ratio for the title in question. I really don't see the utility in that, so I removed it and replaced it with a link to the title's holds page. Please let me know if the old behavior needs to be retained, but I suspect it does not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 123011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123011=edit Bug 28728: Link to holds page from holds raio To test: 1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) 2 - Go to the holds ratio page in circulation 3 - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on 4 - apply patch, restart_all, reload page 5 - link now goes to the holds page for that title -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28728] New: Holds ratio page links to itself pointlessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Bug ID: 28728 Summary: Holds ratio page links to itself pointlessly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To recreate: - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) - Go to the holds ratio page in circulation - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on This link as it exists now seems completely pointless. I propose we make it point to the holds tab for the bib in question instead (/cgi-bin/koha/reserve/request.pl?biblionumber=). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #5 from Nick Clemens --- Created attachment 123010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123010=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferredname' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name now displays on patron details 6 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 7 - Sign in as patron to opac 8 - Confirm preferred name shows 9 - Edit account on opac and confirm field is present -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #4 from Nick Clemens --- Created attachment 123009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123009=edit Bug 28633: DO NOT PUSH Schema Changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #3 from Nick Clemens --- Created attachment 123008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123008=edit Bug 28633: DB Update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #72 from Jonathan Druart --- Created attachment 123007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123007=edit Bug 27526: Fix encoding issue on subfield If you have a "é" subfield it should work! Note that VARCHAR(1) for binary means 1-byte (from MySQL doc): "For example, if the default character set is utf8mb4, CHAR(5) BINARY is treated as CHAR(5) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin. This differs from BINARY(5), which stores 5-byte binary strings that have the binary character set and collation." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Attachment #122974|0 |1 is obsolete|| --- Comment #71 from Jonathan Druart --- Created attachment 123006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123006=edit Bug 27526: Remove uneeded call to TransformMarcToKoha And also clean some imports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #65 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #63) > - t/db_dependent/Reserves.t failure There are 2 things: 1. 1107 item_id => $item->biblionumber, Key must be biblio_id 2. The $title_level_target_query query in _Findgroupreserve is now returning the "reserved" hold. On master it's not matching any rows and the third query ($query) is hit and returned the different holds. I think it's coming from: -JOIN hold_fill_targets USING (reserve_id) vs +JOIN hold_fill_targets ON ( +holds.biblio_id=hold_fill_targets.biblionumber +AND holds.patron_id=hold_fill_targets.borrowernumber) > - t/db_dependent/Circulation.t failure # got: 'on_reserve' # expected: 'too_soon' Related to hold's status as well so may be fixed if the previous test is corrected. > - Add some warning in about.pl about wrong letters (maybe?) After we moved the marcxml out of biblioitems we added a warning on the report list view. Maybe we should do the same for the notice templates? commit f22d2e7200ee8b35aff66b26acc3e2daa49f9f0d Bug 17898: Automagically convert SQL reports Questions: * Shouldn't *_date DB fields be *_on? * item_level => item_level_request I think we agreed on "item_level_request", why did you change it? * Shouldn't holds.id be holds.hold_id? I cannot remember when/where but I think we agreed we shouldn't use "id" (to prevent wrong id to be returned on JOIN). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15248] Make it possible to configure duplicate check on bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 --- Comment #1 from David Cook --- I like this idea! I was just about to open a ticket because I wanted to add a few indexes (like identifier-standard for 024$a and 022$a and Control-number for 001)to FindDuplicate (which have already been implemented locally). Using record matching rules might really be the best way to do this, since different libraries might have different needs/wants for how to find duplicates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 --- Comment #4 from David Cook --- Perhaps this could even be marked as a duplicate of bug 15248? Making it configurable could be the best solution for everyone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15248 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15248] Make it possible to configure duplicate check on bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27278 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 --- Comment #3 from David Cook --- I was thinking a lot about FindDuplicate today and the merits of "exact" vs inexact searches... If you don't use an "exact" search, "The vixens" would also match "Wild vixens: how foxes raise cubs in nature". I think the sorting is based on biblionumber so you'll just get the earliest catalogued "vixens", since we only take the top result from the search results for FindDuplicate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
