[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #9 from David Nind --- Testing notes (koha-testing-docker) - Before applying patches: . can edit and save a record using the default editor (for example, edit title for a book - where BKS framework used) . can't edit using advanced editor: sits on screen with icon going around "Loading..." . result from accessing URL in step 3 is error in step 4 of test plan - After applying patches: . advanced editor loads! . any edits using the normal or advanced editor complain about missing 003 field (didn't before the patch, even though was mandatory before and doesn't display by default) . page with framework data loads for URL in step 3 . can edit and save records using the advanced editor (and normal editor) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind changed: What|Removed |Added Attachment #123144|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 123156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123156&action=edit Bug 28750: fix svc/bib_framework Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind changed: What|Removed |Added Attachment #123124|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 123155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123155&action=edit Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind changed: What|Removed |Added Attachment #123118|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 123154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123154&action=edit Bug 28750: (bug 17600 follow-up) Use full path for subroutines Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 David Nind changed: What|Removed |Added Attachment #123070|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 123153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123153&action=edit Bug 28744: Better handling of undefined to_api_mapping We always had some mapping because of the DB vs. API object definition discrepancies. But bug 25260 revamps the reserves table, and it is a perfect match. It highlights this edge case: if no mapping defined, then and undef from_api_mapping is generated (as opposed to an empty hashref) and this leads to errors in the query translation from the API. This patch makes a small change so this method always returns an empty hashref. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Test fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 David Nind changed: What|Removed |Added Attachment #123069|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 123152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123152&action=edit Bug 28744: Regression tests This patch adds tests for the following cases: - to_api_mapping not defined - to_api_mapping returning an empty hashref To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: Tests fail :-( Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 Kyle M Hall changed: What|Removed |Added Attachment #123150|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 123151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123151&action=edit Bug 28306: Fix POD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 --- Comment #12 from Kyle M Hall --- Created attachment 123150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123150&action=edit Bug 28306: Fix POD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 --- Comment #11 from Kyle M Hall --- Created attachment 123149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123149&action=edit Bug 28306: Switch back to using 'mock' instead of 'redefine' Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306
Kyle M Hall changed:
What|Removed |Added
Attachment #123145|0 |1
is obsolete||
--- Comment #10 from Kyle M Hall ---
Created attachment 123148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123148&action=edit
Bug 28306: Allow to query database with minimal memory footprint
The goal is to be able to build a database handler (dbh) and to execute
queries without loading unnecessary stuff. This will be useful to reduce
memory usage of daemons that need to check the database
periodically
The patch provides a new method Koha::Database::dbh which returns a
database handler without loading the DBIx::Class schema. This method is
also used by DBIx::Class, so whether you use DBI or DBIx::Class, the
same method is used to initialize the connection.
The patch also moves some code in order to avoid loading C4::Context:
- C4::Context::timezone moves to Koha::Config
- C4::Context::db_scheme2dbi moves to Koha::Database
To measure memory usage I used the following commands:
* before the patch:
perl -MKoha::Database \
-E 'Koha::Database->schema->storage->dbh->do("select 1");' \
-E '$|=1; say $$; sleep 2' \
| while read pid; do ps -p $pid -o rss=; done
* after the patch:
perl -MKoha::Database \
-E 'Koha::Database->dbh->do("select 1");' \
-E '$|=1; say $$; sleep 2' \
| while read pid; do ps -p $pid -o rss=; done
It will give you the RSS (Resident Set Size) of the perl process in kB
What I get:
* before the patch: between 96.9MB and 97.2MB
* after the patch: between 17.8MB and 18.2MB
Note that if a timezone is configured (either from $KOHA_CONF or
TZ environment variable), Koha will load DateTime::Timezone to check if
it's valid, and it increases RSS to 36MB
Another interesting metric is the number of modules loaded:
* before the patch:
perl -MKoha::Database \
-E 'Koha::Database->schema->storage->dbh;' \
-E 'say scalar keys %INC'
Result: 567
* after the patch:
perl -MKoha::Database \
-E 'Koha::Database->dbh;' \
-E 'say scalar keys %INC'
Result: 51
Test plan:
1. Apply the patch & restart starman
2. Make sure Koha is still ok (ie. can access the database, does not
have encoding issues, ...)
3. Run the tests in t/Context.t, t/Koha/Config.t,
t/db_dependent/Koha/Database.t, t/timezones.t
Signed-off-by: Martin Renvoize
Signed-off-by: Nick Clemens
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #8) > 0.11 > > t/timezones.t .. Can't locate object method "redefine" via package > "Test::MockModule" at /kohadevbox/koha/t/lib/Mocks.pm line 56, line 1. > > koha-testing-docker has Test::MockModule v0.11, but the method "redefine" > was not added until v0.13 I ran into that recently. It is a pity, but we should use ->mock until all our supported distros ship the newer Test::MockModule. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Kyle M Hall --- 0.11 t/timezones.t .. Can't locate object method "redefine" via package "Test::MockModule" at /kohadevbox/koha/t/lib/Mocks.pm line 56, line 1. koha-testing-docker has Test::MockModule v0.11, but the method "redefine" was not added until v0.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28238] Add itemcallnumber to ils-di GetAvailability output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #6 from Nick Clemens --- If we are going to add it, I think we should return it even if item is unavailable - perhaps the patron wants to make a request for it, or to check the surrounding shelves if their item is not available. Consistency is nice when we can attain it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 --- Comment #1 from Nick Clemens --- Created attachment 123147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123147&action=edit Bug 28754: Only adjust holds on specific biblio and don't go past end of array Our query for lowest priority holds only needs to adjust holds on the biblio we are looking at so I add biblionumber Additionally we can simply find the end of the array and use that rather than 8 so I set new_rank to scalar @priority Lastly, we don't need to fetch the lowest priority holds if we are ignoring lowest priority so I move it into the conditional To test: 1 - Add holds with lowest priorty to 2 records in the catalog 2 - Add a hold on a third record 3 - Note errors in log like: [2021/07/23 17:47:17] [WARN] splice() offset past end of array at /kohadevbox/koha/C4/Reserves.pm line 1649 4 - Apply patch and restart all the things 5 - Add a new hold on third record - no warns 6 - Make one of the holds on third record have lowestPriority (click rightmost arrow with line at bottom) 7 - Note no warns 8 - Adjust other holds on record and note no warns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28754] C4::Reserves::FixPriority creates many warns when holds have lowestPriority set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28754] New: C4::Reserves::FixPriority creates many warns when holds have lowestPriority set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28754 Bug ID: 28754 Summary: C4::Reserves::FixPriority creates many warns when holds have lowestPriority set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To recreate: 1 - Add holds with lowest priorty to 2 records in the catalog 2 - Add a hold on a third record 3 - Note errors in log like: [2021/07/23 17:47:17] [WARN] splice() offset past end of array at /kohadevbox/koha/C4/Reserves.pm line 1649 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 Nick Clemens changed: What|Removed |Added Attachment #121468|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 123146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123146&action=edit Bug 28469: Move "Skip to main content" to top of OPAC page This patch moves the "Skip to main content" button out of the nav element and to the top of the element, so that it's the first (potentially) viewable element on the page. This means you can inject content above the navbar, which has a relative position, and it won't disrupt the display of the "Skip to main content" button. To test: 1) Apply patch 2) Same test plan as Bug 22807: Go to any page in the OPAC and hit the tab key. The "Skip to main content" link should appear. Tabbing away from it should cause the link to hide. Hitting the ENTER key when the link is highlighted should cause the page to scroll to the main content. Signed-off-by: Lucas Gass Signed-off-by: Wainui Witika-Park Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 --- Comment #7 from Nick Clemens --- Adding my SO - there are POD complaints from QA tools - this has potential to break things so another pair of eyes for QA would be nice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28306] Allow to query database with minimal memory footprint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306
Nick Clemens changed:
What|Removed |Added
Attachment #120794|0 |1
is obsolete||
--- Comment #6 from Nick Clemens ---
Created attachment 123145
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123145&action=edit
Bug 28306: Allow to query database with minimal memory footprint
The goal is to be able to build a database handler (dbh) and to execute
queries without loading unnecessary stuff. This will be useful to reduce
memory usage of daemons that need to check the database
periodically
The patch provides a new method Koha::Database::dbh which returns a
database handler without loading the DBIx::Class schema. This method is
also used by DBIx::Class, so whether you use DBI or DBIx::Class, the
same method is used to initialize the connection.
The patch also moves some code in order to avoid loading C4::Context:
- C4::Context::timezone moves to Koha::Config
- C4::Context::db_scheme2dbi moves to Koha::Database
To measure memory usage I used the following commands:
* before the patch:
perl -MKoha::Database \
-E 'Koha::Database->schema->storage->dbh->do("select 1");' \
-E '$|=1; say $$; sleep 2' \
| while read pid; do ps -p $pid -o rss=; done
* after the patch:
perl -MKoha::Database \
-E 'Koha::Database->dbh->do("select 1");' \
-E '$|=1; say $$; sleep 2' \
| while read pid; do ps -p $pid -o rss=; done
It will give you the RSS (Resident Set Size) of the perl process in kB
What I get:
* before the patch: between 96.9MB and 97.2MB
* after the patch: between 17.8MB and 18.2MB
Note that if a timezone is configured (either from $KOHA_CONF or
TZ environment variable), Koha will load DateTime::Timezone to check if
it's valid, and it increases RSS to 36MB
Another interesting metric is the number of modules loaded:
* before the patch:
perl -MKoha::Database \
-E 'Koha::Database->schema->storage->dbh;' \
-E 'say scalar keys %INC'
Result: 567
* after the patch:
perl -MKoha::Database \
-E 'Koha::Database->dbh;' \
-E 'say scalar keys %INC'
Result: 51
Test plan:
1. Apply the patch & restart starman
2. Make sure Koha is still ok (ie. can access the database, does not
have encoding issues, ...)
3. Run the tests in t/Context.t, t/Koha/Config.t,
t/db_dependent/Koha/Database.t, t/timezones.t
Signed-off-by: Martin Renvoize
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 --- Comment #5 from Nick Clemens --- Created attachment 123144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123144&action=edit Bug 28750: fix svc/bib_framework -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28753] New: But the following aren't displaying: OPAC (opacheader_en), OPAC (OpacMainUserBlock_en), OPAC (OpacNavRight_en), OPAC (en)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28753 Bug ID: 28753 Summary: But the following aren't displaying: OPAC (opacheader_en), OPAC (OpacMainUserBlock_en), OPAC (OpacNavRight_en), OPAC (en) Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: dannybustamante...@gmail.com QA Contact: testo...@bugs.koha-community.org But the following aren't displaying: OPAC (opacheader_en), OPAC (OpacMainUserBlock_en), OPAC (OpacNavRight_en), OPAC (en) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28752] New: Add 'sort fields' to Housebound module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28752 Bug ID: 28752 Summary: Add 'sort fields' to Housebound module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: rkui...@roundrocktexas.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com For the Housebound Module, it would be very helpful to have up to 4 'Sort fields' where libraries can save data specific to their program for each patron's housebound details. Currently you can enter delivery day, frequency, preferred materials, subjects, authors, referrals and notes. We would like 4 additional fields that we can set up with data specific to our program. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #27 from Nick Clemens --- Created attachment 123143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123143&action=edit Bug 15067: (QA follow-up) Ensure update is idempotent These tables really shoul;d have some unique keys, we need a test so we can add those This ended up being a bigger work than expected, RM feel free to reject or move to another bug and let the risk of duplicated languages This is an old one, let's get it in :-) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #26 from Nick Clemens --- Created attachment 123142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123142&action=edit Bug 15067: Added translations of languages to those 5 languages Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq are added with their translations to the Advanced Search languages. Test Plan: 1. From homepage, go to Advanced search 2. Click on More options next to the Search button 3. Scroll down to the Limits section 4. Click on Language: No limit 5. Find Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq at the bottom of the dropdown. 6. They should all be there. 7. Estonian and Latvian are repeated, this need to be fixed. 8. They need to be put in alphabetical order. Signed-off-by: Hayley Mapley The five languages are present, sorted alphabetically, and are not repeated. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #25 from Nick Clemens --- Created attachment 123141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123141&action=edit Bug 15067: Add additional languages to advanced search language search run update database script, look for new laguages under 'Language:' in Advanced search. Languages that should be added are: 1. Estonian 2. Latvian 3. Lithuanian 4. Inuktitut 5. Inupiaq Signed-off-by: Nick Clemens Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Nick Clemens changed: What|Removed |Added Attachment #121260|0 |1 is obsolete|| Attachment #121261|0 |1 is obsolete|| Attachment #121262|0 |1 is obsolete|| --- Comment #24 from Nick Clemens --- Created attachment 123140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123140&action=edit Bug 15067: Follow up to fix sorting It looks like C4::Languages:getLanguages relies on implicit database order for languages. They appear to be sorted by subtag so this patch adds that sorting to the database query to ensure the dropdown is sorted. Signed-off-by: Aleisha Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28751] New: opacheader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28751 Bug ID: 28751 Summary: opacheader Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: dannybustamante...@gmail.com QA Contact: testo...@bugs.koha-community.org Opac no visualiza las noticias opacheader -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28675] QOTD broken in 20.11 and below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28675 --- Comment #11 from Katrin Fischer --- @Frido can still still be pushed for 20.11.08? I just tested and this bug affects 20.11.07. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28491] Field 003 in authority records not updated after import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #17 from Kyle M Hall --- Created attachment 123139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123139&action=edit Bug 22801: (follow-up) Use date-of-publication directly Signed-off-by: Nick Clemens Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801
Kyle M Hall changed:
What|Removed |Added
Attachment #122069|0 |1
is obsolete||
Attachment #122070|0 |1
is obsolete||
--- Comment #16 from Kyle M Hall ---
Created attachment 123138
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123138&action=edit
Bug 22801: Advance search yr must use date-of-publication and not copydate
In advanced search with Elasticsearch the limit on years range is actually
using copydate :
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm in _fix_limit_special_cases() :
if ( $l =~ /^yr,st-numeric,ge=/ ) {
my ( $start, $end ) =
( $l =~ /^yr,st-numeric,ge=(.*) and yr,st-numeric,le=(.*)$/ );
next unless defined($start) && defined($end);
push @new_lim, "copydate:[$start TO $end]";
}
With Zebra it uses date-of-publication and also in
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm :
our %index_field_convert = (
(...)
'yr' => 'date-of-publication',
This patch uses %index_field_convert to perform 'yr' limit.
Test plan:
1) Apply patch
2) Use Elasticsearch searchengine
3) Go to advanced search with 'More options'
4) Perform a search with a year limit (value or range)
5) Check results are correct
Signed-off-by: David Nind
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #123133|0 |1 is obsolete|| --- Comment #36 from David Gustafsson --- Created attachment 123137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123137&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 Kyle M Hall changed: What|Removed |Added QA Contact||k...@bywatersolutions.com CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Kyle M Hall changed: What|Removed |Added Attachment #121634|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 123136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123136&action=edit Bug 28408: Add 'Last updated' column to suggestions table We have specific meanings for the different dates in suggestions Managed - means the status was changed or the suggestion edited, but doesn't change if item type updated Modification - implies an edit of the subscript, not updated if status changed alone Updated - this is the date field in the DB, which is actually a timestamp The cronjob purge_suggestions.pl uses teh 'date' field For a user, a suggestion can look old in the interface, but be considered recent by the script To clear the confusion we should show the timestamp as well To test: 1 - Add a suggestion 2 - In the DB, pretend you set it in the past: UPDATE suggestions SET manageddate='2021-01-01', suggesteddate='2021-01-01', date='2021-01-01 12:12:12'; 3 - Click 'Go' In Organize by: Status 4 - Note the suggestion looks old now 5 - Check the box, and click 'Update item types with:' -> Submit 6 - Prganize by status again 7 - No change? 8 - Check the DB: SELECT date FROM suggestions; 9 - The field is updated 10 - Apply patch 11 - Organize by status again 12 - See the 'Last updated' ate set to today Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28408] Last modification date for suggestions is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28394] Improve style of patron category entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Nick Clemens changed: What|Removed |Added Attachment #121202|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 123135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123135&action=edit Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Administration -> Patron categories -> New category and confirm that the style updates look good. Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28394] Improve style of patron category entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 Kyle M Hall changed: What|Removed |Added Attachment #121613|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 123134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123134&action=edit Bug 28336: Add missing input for item_action To test: 1 - Stage a marc file of authorities 2 - Manage the staged file 3 - Attempt to change the matching rule 4 - 500 Error, in intranet-error.log: [Wed May 12 16:53:03.046652 2021] [cgi:error] [pid 52072] [client 172.19.0.1:50580] AH01215: C4::ImportBatch::SetImportBatchItemAction(): DBI Exception: DBD::mysql::st execute failed: Column 'item_action' cannot be null [for Statement "UPDATE import_batches SET item_action = ? WHERE import_batch_id = ?" with ParamValues: 0=undef, 1="1"] at /kohadevbox/koha/tools/manage-marc-import.pl line 160: /kohadevbox/koha/tools/manage-marc-import.pl, referer: http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1 5 - Apply patch 6 - Reload page and change matching rule 7 - Success! Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28336] Cannot change matching rules for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28336 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #123125|0 |1 is obsolete|| --- Comment #35 from David Gustafsson --- Created attachment 123133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123133&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #120709|0 |1 is obsolete|| --- Comment #34 from David Gustafsson --- Created attachment 123132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123132&action=edit Bug 18138: (QA follow-up) Fix QA script issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #118443|0 |1 is obsolete|| --- Comment #33 from David Gustafsson --- Created attachment 123131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123131&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #118442|0 |1 is obsolete|| --- Comment #32 from David Gustafsson --- Created attachment 123130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123130&action=edit Bug 18138: Fix tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #118441|0 |1 is obsolete|| --- Comment #31 from David Gustafsson --- Created attachment 123129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123129&action=edit Bug 18138: Add system preference to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #118440|0 |1 is obsolete|| --- Comment #30 from David Gustafsson --- Created attachment 123128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123128&action=edit Bug 18138: Rename system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #118439|0 |1 is obsolete|| --- Comment #29 from David Gustafsson --- Created attachment 123127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123127&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28347] Add DataTables, additional information to patron attribute types management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28347 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28347] Add DataTables, additional information to patron attribute types management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28347 Nick Clemens changed: What|Removed |Added Attachment #121020|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 123126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123126&action=edit Bug 28347: Add DataTables, additional information to patron attribute types management This patch enhances the display of patron attribute information on the attribute management page. To test, apply the patch and go to Administration -> Patron attribute types. - If necessary, add multiple patron attributes so that there is data to display. Include: - Some which are mandatory - Some which are linked to an authorized value category - Some which share a class. - The tables showing your attributes should each have DataTables sorting and controls (except for column configuration, which isn't added by this patch). - Confirm that DataTable controls work correctly for each table. - The table should include columns showing authorized value category and whether the attribute is mandatory. - If you are logged in as a user with permission to manage authorized values, the data in the authorized value category column should be linked to that category on the authorized values page. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28347] Add DataTables, additional information to patron attribute types management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28347 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson changed: What|Removed |Added Attachment #118824|0 |1 is obsolete|| --- Comment #28 from David Gustafsson --- Created attachment 123125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123125&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24342] Self check needs on screen keyboard for login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24342 --- Comment #4 from Christopher Brannon --- (In reply to Owen Leonard from comment #1) > Isn't this a hardware/OS issue? No, this isn't. Windows does not reliably bring up an on-screen keyboard, or the desired type, at the right times. It took a lot of work to get Windows to bring up an onscreen keyboard for a keyboardless catalog station, and that is without an on screen switch. The interface needs to come up only when a patron calls it, otherwise stay out of the way. Since I opened this ticket, I've redesigned an interface that is based in a bootstrap modal and looks and feels better that my original source I pointed to. I can share that if someone wants to consider incorporating it into the program or a plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Nick Clemens changed: What|Removed |Added Attachment #123121|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 123124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123124&action=edit Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850 --- Comment #15 from Nick Clemens --- Created attachment 123123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123123&action=edit Bug 27850: Search link for 260 a and c in MARC21 XSLT OPAC display In MARC21 XSLT OPAC display, 260$b is a search link on 'Provider'. $a and $c also have a search field, we can create search links. Test plan: 1) Create 2 records with same 260 : two $a, one $b, two $c 2) Use XSLT display in OPAC 2) Look at first record details page in OPAC 3) Click on a $a link => you see both records 4) Click on a $c link => you see both records https://bugs.koha-community.org/show_bug.cgi?id=27850 Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850 Nick Clemens changed: What|Removed |Added Attachment #120998|0 |1 is obsolete|| Attachment #120999|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 123122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123122&action=edit Bug 27850: Search link for 260 a and c in MARC21 XSLT intranet display In MARC21 XSLT intranet display, 260$b is a search link on 'Provider'. $a and $c also have a search field, we can create search links. Test plan: 1) Create 2 records with same 260 : two $a, one $b, two $c 2) Use XSLT display in staff inteface 2) Look at first record details page in staff interface 3) Click on a $a link => you see both records 4) Click on a $c link => you see both records Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 --- Comment #3 from Nick Clemens --- Created attachment 123121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123121&action=edit Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 --- Comment #11 from Kyle M Hall --- Created attachment 123120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123120&action=edit Bug 27885: (follow-up) Use biblionumbers instead of biblionumber in form action for club search This simply matches the code on the patrons search tab Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Kyle M Hall changed: What|Removed |Added Attachment #120831|0 |1 is obsolete|| Attachment #121425|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 123119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123119&action=edit Bug 27885: Populate biblionumbers parameter using biblionumbers array Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop This patch uses @biblionumbers to avoid sending a blank variable in the URL To test: 1 - On the staff client click 'place hold' for an individual record 2 - Use the form to find a patron 3 - Note the url is: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= 4 - Apply patch 5 - Repeat 6 - The url is now like: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 (but with whatever biblionumber you chose) 7 - Perform a search and select multiple biblios and confirm you can place holds as before Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27885] Populate biblionumbers parameter when placing hold on single title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #75 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #74) > This should be need sign-off? I am building a lot of things on top of this and fixing bugs when I find them. A strong QA review would be good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #74 from Joonas Kylmälä --- This should be need sign-off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- I think there are all the svc scripts that need to be double checked. I can do it on Monday if nobody beats me to it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 --- Comment #1 from Nick Clemens --- Created attachment 123118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123118&action=edit Bug 28750: (bug 17600 follow-up) Use full path for subroutines Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28679] Unable to click "Log in to your account" when GoogleOpenIDConnect is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28679 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Attachment #122780|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28750] New: Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Bug ID: 28750 Summary: Undefined subroutines in svc/cataloguing/framework (caused by bug 17600) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28585] Cannot search on date fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Kyle M Hall changed: What|Removed |Added QA Contact||k...@bywatersolutions.com Assignee|k...@bywatersolutions.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28585] Cannot search on date fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #18 from Kyle M Hall --- Created attachment 123117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123117&action=edit Bug 28585: (follow-up) Tests for q= supporting date/date-time parameters Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28585] Cannot search on date fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 --- Comment #17 from Kyle M Hall --- Created attachment 123116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123116&action=edit Bug 28585: Use the datetime_parser for handling API dates This patchset takes the GET /patrons route as a sample usage for filtering on date and date-time (including timestamp) fields. It then makes Koha::Object->attributes_from_api use the DB storage datetime parser for format the parameters correctly. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: It doesn't find the patron when filtering by date 3. Apply this patch 4. Repeat 2 => SUCCESS: It works now! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28585] Cannot search on date fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Kyle M Hall changed: What|Removed |Added Attachment #122457|0 |1 is obsolete|| Attachment #122458|0 |1 is obsolete|| Attachment #122459|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 123115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123115&action=edit Bug 28585: Regression tests This patch adds tests for filtering GET calls with date/date-time parameters. Tests fail because the feature is not working Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28585] Cannot search on date fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28749] All backups on 21.05 behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Jason Boyer changed: What|Removed |Added CC||jbo...@equinoxoli.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28749] New: All backups on 21.05 behave as if --without-db-name is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28749 Bug ID: 28749 Summary: All backups on 21.05 behave as if --without-db-name is passed Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: jbo...@equinoxoli.org QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Created attachment 123114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123114&action=edit Restore the database name to Koha dumps The line to use the --databases flag with mysqldump by default was accidentally removed from koha-dump when the --schema-only option was added. This makes all backups act as if koha-dump is called with the --without-db-name flag, causing koha-restore to fail to restore the database because it's neither CREATEd or USEd. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28585] Cannot search on date fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28585 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|tomasco...@gmail.com|k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall changed: What|Removed |Added Attachment #121918|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 123113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123113&action=edit Bug 28534: Atomic update to fix existing installs Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall changed: What|Removed |Added Attachment #121917|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 123112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123112&action=edit Bug 28534: Fix engine for pending_offline_circulations table Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28748] When hold is overridden cannot select a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28748 Nick Clemens changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28748] New: When hold is overridden cannot select a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28748 Bug ID: 28748 Summary: When hold is overridden cannot select a pickup location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Bug 28338 added a check of hold pickup locations for each hold item on a record When selecting an item that normally is not for hold there is no pickup dropdown, the hold is placed with no location To recreate: 1 - Enable AllowHoldPolicyOverride 2 - Set 'Default checkout, hold and return policy' - Hold policy 'From home library' Hold pickup library match 'Item's home library' 3 - Find a record with items from multiple libraries 4 - Attempt to place a hold on an item that normally wouldn't be allowed 5 - Notice these items have no holds dropdown 6 - Place the hold 7 - Note the pickup location is blank -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #5 from Nick Clemens --- Created attachment 123111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123111&action=edit Too long library name makes the icon drop down Display issue when library name is long -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens --- Slight display problem with long library names -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #73 from Jonathan Druart --- Created attachment 123110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123110&action=edit Bug 27526: Fix cn_source display For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are calling from Koha::Item->columns_to_str) does not deal with class sources. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27747] Add CodeMirror custom syntax highlighting for column placeholders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27747 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27747] Add CodeMirror custom syntax highlighting for column placeholders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27747 --- Comment #4 from Nick Clemens --- Created attachment 123109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123109&action=edit Bug 27747: (QA follow-up) Make code consistent and add explicit brackets The while statements were including the next statement, I add brackets to make it more obvious Also the highlighting was applying to [[borrowernumber|Borrow number] I removed the break to match code above and only highlight when syntax complete and correct Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27747] Add CodeMirror custom syntax highlighting for column placeholders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27747 Nick Clemens changed: What|Removed |Added Attachment #120849|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 123108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123108&action=edit Bug 27747: Add CodeMirror custom syntax highlighting for column placeholders This patch adds some additional configuration to CodeMirror so that column placeholders have a distinct color in the CodeMirror SQL editor. To test, apply the patch and create or edit an SQL report which contains one or more column placeholders, e.g. [[itemnumber|Item number]], [[borrowernumber|Borrower number]], etc. Confirm that when editing the SQL, these placeholders should appear as red text. Save your report and view it. The syntax highlighting should be updated in this view too. Signed-off-by: Lucas Gass Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27747] Add CodeMirror custom syntax highlighting for column placeholders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27747 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28745] Batch item modifications no longer displayed modified items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28745 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28745] Batch item modifications no longer displayed modified items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28745 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC||n...@bywatersolutions.com --- Comment #21 from Nick Clemens --- Small QA failures: OK Koha/Schema/Result/Itemtype.pm FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint The new column (type) for table configurations is using BOOLEAN as type, must be TINYINT(1) instead, see the SQL12 coding guideline FAIL t/db_dependent/Koha/Configurations.t FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
