[Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 --- Comment #2 from Hayley Pelham --- Created attachment 123238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123238&action=edit Bug 20463: Adding index for Leader 19 Multipart resource record level Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass changed: What|Removed |Added Attachment #123236|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 123237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123237&action=edit Bug 28762: handle notforloan better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #3 from Lucas Gass --- Created attachment 123236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123236&action=edit Bug 28762: handle notforloan better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #2 from Lucas Gass --- Created attachment 123235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123235&action=edit Bug 28761: better handle notforloan and restricted status in item.status.inc To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on opac-course-details.pl 3. give your item a notforloan status 4. reload opac-course-details.pl, confirm its still "available" 5. give your item a restricted user status 6. reload opac-course-details.pl, confirm its still "available" 7. give your item a lost, damaged, or withdrawn status 8. reload opac-course-details.pl, these statuses *are* reflected 9. apply patch 10. check notforloan and restricted, they should be reflect the correct status now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass changed: What|Removed |Added Attachment #123233|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 123234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123234&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28770] Add request date to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28770 --- Comment #1 from Katrin Fischer --- Hi Michael, can you explain the difference between requested and ordered in your workflow? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #1 from Lucas Gass --- Created attachment 123233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123233&action=edit Bug 28762: Handle different item statuses in course details To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl https://bugs.koha-community.org/show_bug.cgi?id=28761 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Attachment #123232|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #1 from Lucas Gass --- Created attachment 123232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123232&action=edit Bug 28762: Handle different item statuses in course details To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18631] Cleanup_database.pl should take an option for modules in action_logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631 --- Comment #4 from Nick Clemens --- Created attachment 123231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123231&action=edit Bug 18631: Add option to specify logs to preserve or delete in cleanup_database.pl This adds two new parameters: --log_module --preserve_log These can be repeated to include or exclude specific modules from the cleanup To test: 0 - Apply patch 1 - Enable cataloging log and borrowers log 2 - Make some changes to borrowers and records 3 - run cleanup databse with --logs 0 --preserve_log=MEMBERS --preserve_log=CATALOGUING 4 - nothing is removed 5 - run cleanup databse with --logs 0 --log_module=MEMBERS 6 - the borrower logs are removed, the record changes remain 7 - run cleanup database with --logs 0 8 - record changes are removed (all other logs too) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 --- Comment #4 from Lucas Gass --- Created attachment 123230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123230&action=edit Bug 28768: remove unnessesary template variable To test: 1. Add some news that should display on opac-readingrecord.pl. For example: opacheader, OpacCustomSearch, opaccredits 2. Go to opac-readingrecord.pl, the news doesn't display 3. Apply patch, restart_all 4. Go to opac-readingrecord.pl, the news displays 5. Turn on 'opacreadinghistory' and test to make sure it still works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768
--- Comment #3 from Lucas Gass ---
It is this line in opac-readingrecord.pl:
$template->param(%{$borr});
which is setting the language to 'default'. I'm pretty sure its unnecessary to
pass this to the template and we can remove the line.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added URL||https://gitlab.com/joubu/Ko ||ha/-/commits/bug_28445 --- Comment #11 from Jonathan Druart --- Remote branch, with all the dependencies applied, available for testing: https://gitlab.com/joubu/Koha/-/commits/bug_28445 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #10 from Jonathan Druart --- Created attachment 123229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123229&action=edit Bug 28445: Fix encoding issue with the background job's report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #9 from Jonathan Druart --- Created attachment 123228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123228&action=edit Bug 28445: UI change for repeatable and regex This patch applies the changes describe in the main commit message about the "limitation" and "the behaviour in master was buggy". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #8 from Jonathan Druart --- Created attachment 123227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123227&action=edit Bug 28445: Use the task queue for the batch delete and update items tool Here we go! Disclaimer: this patch is huge and does many things, but splitting it in several chunks would be time consuming and painful to rebase. However it adds many tests and isolate/refactor code to make it way more reusable. This patchset will make the "batch item modification" and "batch item deletion" features use the task queue (reminder: Since bug 28158, and so 21.05.00, we do no longer use the old "background job" functionality and the user does not get any info about the progress of the job). More than that, more of the code to build an item form and a list of items is now isolated in module (.pm) and include files (.inc) We are reusing the changes made by bug 27526 that simplifies the way we edit/create items (no more unecessary serialization Koha > MARC > MARCXML > XML > HTML) New module: * Koha::BackgroundJob::BatchDeleteItem Subclass for process item deletion in batch * Koha::BackgroundJob::BatchUpdateItem Subclass for process item modification in batch * Koha::Item::Attributes We needed an object to represent item's attributes that are not mapped with a koha field (aka "more subfields xml") This module will help us to create the marcxml from a hashref and the reverse. * Koha::UI::Form::Builder::Item The code that was used to build the add/edit item form is centralised in this module. In conjunction with the subfields_for_item BLOCK (from html_helpers.inc) it will be really easy to reuse this code in other places where the item form is used (acquisition and serials modules) * Koha::UI::Table::Builder::Items Same as previously for the table. We are now using this table from 3 different places (batch item mod, batch item del, backgroung job detail view) and the code is only in one place. To use with items_table_batchmod BLOCK (still from html_helpers.inc) This patch is fixing some bugs about repeatable subfields and regex. A UI change will reflect the limitation: if you want to apply a regex on a subfield you cannot add several subfields for the same subfield code. Test plan: Prepare the ground: - Make sure you are always using a bibliographic/item record using the framework you are modifying! - Add some subfields for items that are not mapped with a koha field (note that you can use 'é' for more fun, don't try more funny characters) - Make some subfields (mapped and not mapped with a kohafield) repeatable - Add default values to some of your subfields There are 4 main screens to test: 1. Add/edit item form The behaviour should be the same before and after this patch. See test plan from bug 27526. Those 2 prefs must be tested: * SubfieldsToAllowForRestrictedEditing * SubfieldsToUseWhenPrefill 2. Batch modification a. Fill some values, play with repeatable and regex. Note that the behaviour in master was buggy, only the first value was modified by the regex: * With subfield = "a | b" 1 value added with "new" => "new | b" * With subfield = "a | b" 2 new fields "new1","new2" => "new2 | b" Important note: For repeatable subfields, a regex will apply on the subfields in the "concatenated form". To apply the regex on all the different subfields of a given subfield code you must use the "g" modifier. This could be improved later, but keep in mind that it's not a regression or behaviour change. b. Play with the "Populate fields with default values from default framework" checkbox c. Use this tool to modify items and play with the different sysprefs that interfer with it: * NewItemsDefaultLocation * SubfieldsToAllowForRestrictedBatchmod * MaxItemsToDisplayForBatchMod * MaxItemsToProcessForBatchMod 3. Batch deletion a. Batch delete some items b. Check items out and try to delete them c. Use the "Delete records if no items remain" checkbox to delete bibliographic records without remaining items. d. Play with the following sysprefs and confirm that it works as expected: * MaxItemsToDisplayForBatchDel e. Stress the tool: Go to the confirmation screen with items that can be deleted, don't request the job to be processed right away, but check the item out before. 4. Background job detail view You must have seen it already if you are curious and tested the above. When a new modification or deletion batch is requested, the confirmation screen will tell you that the job has enqueued. A link to the progress of the job can be followed. On this screen you will be able to see the result of the job once it's fully processed. QA notes: * There are some FIXME's that are not blocker in my opinion. Feel free to discuss them if you have suggestions. * Do we still need MaxItemsToProcessForBatchMod? * Prior to
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #7 from Jonathan Druart --- Created attachment 123226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123226&action=edit Bug 28445: Add the capability to provide more info to the background job detail view We already had the need for that, when bibliographic records are modified in batch we wanted to add a "Add to list" feature, and so pass a list of lists/virtual shelves to the template. Here we will want to pass the infos of the items that have been modified to display a table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #6 from Jonathan Druart --- Created attachment 123225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123225&action=edit Bug 28445: Start form with empty library for batch mod -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #5 from Jonathan Druart --- Created attachment 123224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123224&action=edit Bug 28445: Adjust code to handle regexs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #4 from Jonathan Druart --- Created attachment 123223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123223&action=edit Bug 28445: Use Koha::UI::Form::Builder::Item from batchmod as well Now that it's reusable, let use it somewhere else! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 --- Comment #3 from Jonathan Druart --- Created attachment 123222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123222&action=edit Bug 28445: Move controller code to Koha::UI::Form::Builder::Item To ease reusability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added Attachment #121372|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 123221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123221&action=edit Bug 28445: Isolate add item form to an include file To ease reusability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added CC||dc...@prosentient.com.au, ||katrin.fisc...@bsz-bw.de, ||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28771] Received orders in Acq can be cancelled from an open basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 Donna changed: What|Removed |Added Version|unspecified |20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28771] Received orders in Acq can be cancelled from an open basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 Donna changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||sbr...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28771] New: Received orders in Acq can be cancelled from an open basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 Bug ID: 28771 Summary: Received orders in Acq can be cancelled from an open basket Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org Once an item has been received, and the basket is open for whatever reason, the received item order line can be cancelled. You should not be able to cancel an ordered item that has been received, you should have to unreceive the item before you can cancel it. To recreate: 1. Set up a basket with multiple items in it 2. Close the basket and receive an order 3. Re-open the basket and click cancel order on the received item 4. See that the received item has now been cancelled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 e.betemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 e.betemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #5 from Tomás Cohen Arazi --- Maybe 'article_request_daily_limit'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #4 from Agustín Moyano --- Created attachment 123220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123220&action=edit Bug 27945: Add limit article request feature This patch makes it possible to limit article requests per patron per day. To test: 1. Apply patches 2. updatedatabase 3. Enable ArticleRequests preference 4. Edit a patron category and set an article request limit to 1 CHECK => if you set the limit to anything else but a positive number or empty string, a warning appears 5. In staff search biblios and request an article for a patron of the modified category 6. Repeat step 5 SUCCESS => if limit is reached, when you select the user to request an article a warning appears saying that the limit was reached 7. Repeat steps 5 and 6 but this time in opac SUCCESS => Patron is not allowed to request another article if limit is reached 8. prove t/db_dependent/ArticleRequests.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #3 from Agustín Moyano --- Created attachment 123219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123219&action=edit Bug 27945: [DO NOT PUSH] Update DBIx schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #2 from Agustín Moyano --- Created attachment 123218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123218&action=edit Bug 27945: Add article_request_limit in categories table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #1 from Agustín Moyano --- Created attachment 123217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123217&action=edit Bug 27945: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 Agustín Moyano changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 --- Comment #4 from Lucas Gass --- Martin, Any chance for a rebase of this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 --- Comment #2 from Andrew Isherwood --- I should have said "call to KohaNews.get in any templates/includes that make the call" since this doesn't just affect masthead.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Andrew Isherwood changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com --- Comment #1 from Andrew Isherwood --- I've been investigating this one today not knowing it had already been reported! It seems to be due to the template for this page not receiving the language (e.g. en-GB) and instead receiving "default".The effect of this is that the call to KohaNews.get in masthead.inc fails. I've not been able to determine why this page in particular is suffering from this issue, I'm hoping someone with more experience of this area can fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Blocks||28445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added Depends on||27526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Blocks|26080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 [Bug 26080] Use the task queue for the batch delete records tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What|Removed |Added Depends on|27526 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #10 from Jonathan Druart --- Created attachment 123216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123216&action=edit Bug 26080: Use the task queue for batch delete authorities Same as the first patch, for authorities Test plan: Delete authority records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 --- Comment #9 from Jonathan Druart --- Created attachment 123215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123215&action=edit Bug 26080: Some refactoring A new include file is created per background job to avoid background_jobs.tt to grow too much -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What|Removed |Added Attachment #122347|0 |1 is obsolete|| Attachment #122348|0 |1 is obsolete|| Attachment #122349|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 123214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123214&action=edit Bug 26080: Use the task queue for batch delete biblios This patch takes advantage of the task queue to delegate the batch delete biblios tool. Test plan: Delete bibliographic records using the batch record deletion tool Confirm that the job is now delegated to the task queue and that everything else is working as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Blocks||26080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 [Bug 26080] Use the task queue for the batch delete records tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26080] Use the task queue for the batch delete records tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 Jonathan Druart changed: What|Removed |Added Depends on||27526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28770] New: Add request date to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28770 Bug ID: 28770 Summary: Add request date to order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: sudrl...@vt.edu QA Contact: testo...@bugs.koha-community.org Created attachment 123213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123213&action=edit Accounting details to add an order When adding orders to Koha, it would be nice to be able to track certain dates for our orders, such as the date when the item is requested. We would like to track the time from when the item was requested, ordered, and then received. A requesteddate field could be added to the aqorders table and a text field in the accounting details when adding the order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Blocks||28769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 [Bug 28769] tabloop not used in cataloguing plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Jonathan Druart changed: What|Removed |Added Depends on||27526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 --- Comment #1 from Jonathan Druart --- Created attachment 123212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123212&action=edit Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Jonathan Druart changed: What|Removed |Added Blocks||28445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added Depends on||28769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 [Bug 28769] tabloop not used in cataloguing plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] New: tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Bug ID: 28769 Summary: tabloop not used in cataloguing plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 Jonathan Druart changed: What|Removed |Added Blocks||28445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added Depends on||28765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 [Bug 28765] sub find_value not used in tools/batchMod.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28768] New: OPAC reading history page (opac-readingrecord.pl) wont display news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28768 Bug ID: 28768 Summary: OPAC reading history page (opac-readingrecord.pl) wont display news items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Add some news that should display on opac-readingrecord.pl. For example: opacheader, OpacCustomSearch, opaccredits 2. Go to opac-readingrecord.pl, the news doesn't display Checking the errors logs I see: [WARN] File not found : default/js/locale_data.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28705] Renewal should look at current article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Marcel de Rooy changed: What|Removed |Added Blocks||28767 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28767 [Bug 28767] AddReturn should also look at current article requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28767] AddReturn should also look at current article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28767 Marcel de Rooy changed: What|Removed |Added Depends on||28705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 [Bug 28705] Renewal should look at current article requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28767] New: AddReturn should also look at current article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28767 Bug ID: 28767 Summary: AddReturn should also look at current article requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The article requests feature has unfortunately not been integrated into Koha's Circulation module. This is just a small step in bridging the gap. Apart from looking at reserves/holds, AddReturn should also look at older open article requests (prioritizing them over newer holds). This should be preference controlled in order to keep existing behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||28766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28766 [Bug 28766] Fix remaining instance of missing sub checkHoldPolicy in C4/HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28766] New: Fix remaining instance of missing sub checkHoldPolicy in C4/HoldsQueue.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28766 Bug ID: 28766 Summary: Fix remaining instance of missing sub checkHoldPolicy in C4/HoldsQueue.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 27068 In master, line 628 of C4/HoldsQueue.pm needs to get updated to use the new checkHoldPolicy sub. We got other instances of this in bug 27068. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 [Bug 27068] HoldsQueue doesn't know how to use holds groups -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Jonathan Druart changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_11_candidate, ||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 --- Comment #1 from Jonathan Druart --- Created attachment 123211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123211&action=edit Bug 28765: Remove sub find_value from batchMod.pl It has never been used and should be removed Test plan: Search for "find_value" in the file and confirm that there is no more occurrence -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28765] New: sub find_value not used in tools/batchMod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 Bug ID: 28765 Summary: sub find_value not used in tools/batchMod.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org This subroutine is not used and can be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #123 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #121) > Created attachment 123210 [details] [review] > Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES > > Signed-off-by: Marcel de Rooy Patch pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #122 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #117) > (In reply to Jonathan Druart from comment #116) > > Created attachment 123196 [details] [review] [review] > > Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES > > Can I get a review on that patch please, before I push it and continue to > mess up with things. > > I think this fixes a problem we had prior to this patch (to confirm!). Both > Locale::Messages and POSIX are exporting LC_MESSAGES. As we explicitly > imported LC_MESSAGES from Locale::Messages I guess it's what we wanted to > do, but POSIX exported it as well and it's the one we got (it's after > Locale::Messages in the use sequence). Looks good to me now. Have the impression that both constants return the same for me.. But when you look at Locale::Messages, this is the way it should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17600] Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Marcel de Rooy changed: What|Removed |Added Attachment #123196|0 |1 is obsolete|| --- Comment #121 from Marcel de Rooy --- Created attachment 123210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123210&action=edit Bug 17600: (follow-up) Fix wrong import in Koha::I18N - LC_MESSAGES Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Owen Leonard changed: What|Removed |Added Attachment #122992|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 123209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123209&action=edit Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28727] "Edit item" button on moredetail should be enabled with edit_items permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28727 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Klas Blomberg changed: What|Removed |Added CC||klas.blomb...@skovde.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Klas Blomberg changed: What|Removed |Added CC||klas.blomb...@skovde.se --- Comment #10 from Klas Blomberg --- +1 for creating a separate field. This is how it worked in my previous ILS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display (bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display (bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display (bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display (bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 Jonathan Druart changed: What|Removed |Added Summary|Undefined subroutine|Undefined subroutine |XSLTParse4Display when |XSLTParse4Display (bug |viewing lists (bug 17600) |17600) CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display when viewing lists (bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 --- Comment #3 from Jonathan Druart --- Created attachment 123208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123208&action=edit Bug 28763: (bug 17600 follow-up) Import XSLTParse4display in opac-tags.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Owen Leonard changed: What|Removed |Added Attachment #123205|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 123207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123207&action=edit Bug 28764: Parse direction parameter in public list view This patch adds a check for a 'direction' paramter in list sorting. It maintains the existing syntax for sorting 'sortfield=field:direction' but adds support for the form used in paginations and more commonly thtoughout Koha' sortfield=field&direction=direction' To test: 1 - Create a public list 2 - Add enough items to generate two pages (40 worked for me) 3 - View the list and enforce sorting by date added descending: sortfield=dateadded:desc 4 - Note the titles shown 5 - Click to second page using the pagination bar 6 - Note the same titles are shown, in a reversed order 7 - Apply patch 8 - repeat 305 9 - Second page is sorted correctly! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display when viewing lists (bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 Owen Leonard changed: What|Removed |Added Attachment #123204|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 123206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123206&action=edit Bug 28763: (bug 17600 follow-up) Import XSLTParse4display in lists Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display when viewing lists (bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 --- Comment #1 from Nick Clemens --- Created attachment 123205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123205&action=edit Bug 28764: Parse direction parameter in public list view This patch adds a check for a 'direction' paramter in list sorting. It maintains the existing syntax for sorting 'sortfield=field:direction' but adds support for the form used in paginations and more commonly thtoughout Koha' sortfield=field&direction=direction' To test: 1 - Create a public list 2 - Add enough items to generate two pages (40 worked for me) 3 - View the list and enforce sorting by date added descending: sortfield=dateadded:desc 4 - Note the titles shown 5 - Click to second page using the pagination bar 6 - Note the same titles are shown, in a reversed order 7 - Apply patch 8 - repeat 305 9 - Second page is sorted correctly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- The print slip page gives me an error: Can't call method "unblessed" on an undefined value at /kohadevbox/koha/C4/Members.pm line 692 QA tool reports the following failures: FAIL C4/Members.pm FAIL pod coverage POD is missing for FineSlip POD is missing for checkcardnumber FAIL t/db_dependent/Members/FineSlip.t FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28764] New: Sorting not correct in pagination on OPAC lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28764 Bug ID: 28764 Summary: Sorting not correct in pagination on OPAC lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When viewing a list on the OPAC you can force a sorting direction by appending to the sortfield with a colon: sortfield=dateadded:desc When clicking on the next page, however, the direction is formed as: direction=desc&sortfield=dateadded The script doesn't read the 'direction' parameter, so sorting fails To recreate: 1 - Create a public list 2 - Add enough items to generate two pages (40 worked for me) 3 - View the list and enforce sorting by date added descending: sortfield=dateadded:desc 4 - Note the titles shown 5 - Click to second page using the pagination bar 6 - Note the same titles are shown, in a reversed order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27944] Add new stages to the article request process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #43) > (In reply to Jonathan Druart from comment #42) > > Tomas asked me to look at the following QA errors: > > > > Prototype mismatch: sub Koha::ArticleRequest::Status::Completed: none vs () > > at /usr/share/perl/5.28/constant.pm line 171. > > > > Prototype mismatch: sub Koha::ArticleRequest::Status::Processing: none vs () > > at /usr/share/perl/5.28/constant.pm line 171. > > > > Prototype mismatch: sub Koha::ArticleRequest::Status::Pending: none vs () at > > /usr/share/perl/5.28/constant.pm line 171. > > > > Prototype mismatch: sub Koha::ArticleRequest::Status::Canceled: none vs () > > at /usr/share/perl/5.28/constant.pm line 171. > > > > I'd say we can ignore them. > > Yeah thats what I concluded too. > The more intriguing problem is the one about Koha::Template::Plugin::Biblio. > Last mentioned in comment40, but discussed before that too. > You did already have a look, and I actually asked Tomas to have a look. but > he did not yet.. I've been looking at this yesterday morning, with no luck. Will give it another run today! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
