[Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Lucas Gass changed: What|Removed |Added Attachment #119846|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 123354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123354=edit Bug 27847: Don't obscure page when checkin modal is non-blocking This patch changes the series of events striggered when a non-blocking modal dialog is displayed during checkin. If the "TransfersBlockCirc" preference is set to "Don't block," the user can continue to check in even though a transfer dialog has appeared. This patch hides the modal's "backdrop" element so that the modal doesn't look like one which blocks further action. There is no Bootstrap backdrop option which both hides the backdrop and makes it non-blocking, so we have to use the default non-blocking option and "manually" hide the backdrop. The "show.bs.modal" event must be added in order to make the necessary change before the modal is displayed. This prevents the darkened backdrop from appearing and then being hidden. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Set the "TransfersBlockCirc" preference to "Don't block." - Check in an item which belongs to another library. - A modal dialog should be displayed: "Please return this item to XXX" - The page "behind" the modal should not be darkened, and the cursor focus should remain in the check-in field. - Checking in an item which as a hold should still trigger the "blocking" behavior: The modal must be dismissed by clicking one of its buttons (not the backdrop) and the page behind the modal should be darkend. - Test with "TransfersBlockCirc" set to "Block." Checking in an item belonging to another library should trigger the "blocking" modal behavior. - Test that other checkins still work correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27847] Don't obscure page when checkin modal is non-blocking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27847 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28092] Holds to pull needs to include reserve notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28092 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27023] Add class names in the suggestions column in suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27023 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26630] Allow custom text for each library on the purchase suggestion page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28034] Add DataTables to lists of clubs in "Clubs" tabs on patron account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28034 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator - Patron Search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- Hey Micheal, Can you provide a test plan for testing this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 David Nind changed: What|Removed |Added Attachment #123211|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 123353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123353=edit Bug 28765: Remove sub find_value from batchMod.pl It has never been used and should be removed Test plan: Search for "find_value" in the file and confirm that there is no more occurrence Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28765] sub find_value not used in tools/batchMod.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28765 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #11 from David Nind --- Everything seemed to work okay for me. Also like that the calendar icon is now back inside the input box. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Nind changed: What|Removed |Added Attachment #123324|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 123352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123352=edit Bug 28376: Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). NEW: I've modified the default configuration of Flatpickr instances so that a "Clear date" link is automatically appended. This eliminates the need to add a button to the markup and event handling for each case. NEW: Date/time formatting should be corrected in this revised patch. The patch modifies three pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - NEW: You can also test the datepicker shown when you renew an on-hold item. This demonstrates a configuration which requires that the selection be after today. - Administration -> Patron categories -> New category, to demonstrate a calendar-only date picker enforcing a date after today. - NEW: Reports -> Patrons. The "Date of birth" fields are linked so that the second cannot be before the first. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28376] Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28778] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28778 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|Demon Alvien|SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28689] Extra %s in alert message when saving an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Katrin Fischer changed: What|Removed |Added Summary|Extra %s in alert message |Extra %s in alert message |when saving an items|when saving an item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #6 from Lucas Gass --- (In reply to Nick Clemens from comment #4) > This patch also affects the details page on the opac, and the cart > > Before this patch a restricted item shows as: > Available (Restricted Access) > > After it is: > Restricted Access Thanks Nick, I erroneously set the itemavailable flag to 0 for restricted items. They should be considered available. Reset the status of this one to NSO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass changed: What|Removed |Added Attachment #123246|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 123351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123351=edit Bug 28761: better handle notforloan and restricted status in item.status.inc To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on opac-course-details.pl 3. give your item a notforloan status 4. reload opac-course-details.pl, confirm its still "available" 5. give your item a restricted user status 6. reload opac-course-details.pl, confirm its still "available" 7. give your item a lost, damaged, or withdrawn status 8. reload opac-course-details.pl, these statuses *are* reflected 9. apply patch 10. check notforloan and restricted, they should be reflect the correct status now 11. restricted status should NOT cause the item to become unavailable 11. The item-status.inc also effects opac-detail and opac-cart 12. look at those and make sure everything looks correct and statuses are properly reflected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28761] Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12561] Remove non-XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Katrin Fischer changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 David Nind changed: What|Removed |Added Attachment #123338|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 123350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123350=edit Bug 26979: Show correctly-pluralized labels on checkouts page tabs This patch modifies the tabs shown on the checkout and patron detail page so that counts of checkouts, etc. have the correct pluralization. This avoids the use of labels like "Checkout(s)" To test, apply the patch and check out to a patron. - The tabs showing checkouts, holds, claims, etc. should show the correct plural or singular on each label, e.g.: 14 Checkouts 20 Holds 0 Article requests 1 Club - Test that each plural/singular changes appropriately when you add checkouts, holds, clubs, etc. To test translation, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the templates e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from circulation.tt and moremember.tt translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:770 msgid "Relatives' checkout" msgid_plural "Relatives' checkouts" msgstr[0] "" msgstr[1] "" - Edit the "msgstr[0]" and "msgstr[1]" strings however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the staff client, switch to the language you're testing. Confirm that your translated strings appear correctly in singular and plural cases. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26979] Show correctly-pluralized labels on checkouts page tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should use XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 David Nind changed: What|Removed |Added Attachment #123016|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 123349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123349=edit Bug 28734: Parse display in $biblio->get_marc_notes 1. Go to Koha Administration, MARC bibliographic frameworks 2. Edit a framework, find tag 590, edit the $z subfield to use an authorised value. 3. Do a catalogue search and edit a record using this framework. Edit 590$z and select an authorised value. Save the record. 4. Add the record to your cart. 5. View your cart. Click More Details. 6. Scroll down to the Notes section. Notice the authorised value code is displayed instead of the description. 7. Apply the patch, restart services. 8. Refresh your cart. Click More Details again if you need to. 9. Scroll down to the Notes section. The description of the authorised value should now be displayed. Sponsored-by: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
