[Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981

--- Comment #46 from David Cook  ---
Thanks for working on this, Nick. This is a feature I've long wanted in Koha.

I've just taken a quick peek at the code, so just going to ask for some
clarification.

At a glance, it looks like a 001 will be assigned for original cataloguing or
copy cataloguing using the Cataloguing UI (even if it already has a 001), is
that right? That sounds good to me.

I wonder about Staged MARC Imports though. At a glance, I think those will
retain their original 001 and won't get updated. I think that might be
problematic. 

Same goes for the APIs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

--- Comment #5 from David Cook  ---
Since you're using an atypical stack and folk here can't reproduce it, it
sounds like this might be more of a support request than a bug report. 

I don't use Elasticsearch with Koha, so I'm probably not much help there.
However, are you able to reproduce the same problem when using Zebra instead of
Elasticsearch for your SearchEngine?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26544] Housebound module should show delivery preferences when scheduling

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26544

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

--- Comment #1 from Lucas Gass  ---
Created attachment 123445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123445=edit
Bug 28810: replace housebould detail inputs with textarea

To test:
1. apply patch
2. enable housebound module
3. go to a patron and look at the housebound tab
4. Edit the detials.
5. The preferred materials, subjects, authors, referral, and note inputs should
be replace with much larger textareas.
6. You should now be able to added line breaks, so fill out each of the fields
adding some line breaks. I added something like:
Fiction authors: Frank Herbert
Non-fiction authors: Malcolm Gladwell

7. Save changes
8. Now when you look at the housebound details those line breaks should be
preserved and much easier to read.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28810] New: Housebound details should be textarea not text inputs

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

Bug ID: 28810
   Summary: Housebound details should be textarea not text inputs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

In the housebound module when filling out the housebound details there are some
fields that could potentially contain a lot of information. There fields are 
Preferred materials, Subjects, Authors, Referrals, and notes. 

Librarians may wish to enter many subjects/authors/notes/etc and perhaps add
line breaks to separate subjects/authors/notes/etc. 

We should replace the input's with textarea and when viewing those housebound
details we should preserve those lines breaks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725

--- Comment #6 from David Nind  ---
Hi Owen.

I've finally had another go at this one.

For some reason the forward button no longer works (after using the back
button).

I tested this in Firefox and Google Chrome (latest versions on Ubuntu 18.04).

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

--- Comment #4 from T. Keagan  ---
(In reply to Jonathan Druart from comment #2)
> I don't recreate what you describe (tested on master and 20.11.x), the title
> is always displayed.

Thank you Jonathan.  Perhaps this is particular to our tech stack. We're using
Oracle Linux and Percona SQL Server.  Maybe something is up with Perl.  We've
duplicated this issue on multiple machines.  Since I'm working in a new
instance with only four MARC records in it, it seems like the only variable is
toggling OpacSuppression.  I see nothing useful in the logs, although I get the
warnings below regardless of whether OpacSuppression is toggled:

[2021/08/03 09:26:45] [WARN] Use of uninitialized value $f in pattern match
(m//) at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
line 725.
[2021/08/03 09:26:45] [WARN] Use of uninitialized value $f in exists at
/usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 729.

Perhaps I will just need to set this aside until I have time to go through the
code.  I am mystified.  Thanks for your time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

--- Comment #3 from T. Keagan  ---
(In reply to David Cook from comment #1)
> Did you put "No" as a value in the 942$n?

Hi David.  The display value is "No".  The authorized value is "0", populated
by the Fast Add Framework, which has the YES_NO authorized values linked to it
by default.  

The suppression that is happening is not "normal", meaning that the label,
"Suppressed in OPAC", isn't being applied to the record when viewed in the
intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303

--- Comment #6 from David Nind  ---
Thanks Michael for the test plan!

I have now tested and signed off.

Testing notes (using koha-testing-docker):
- Step 7: 
  . I didn't see an error (maybe because I changed the user/group for the new
directory to match the koha instance)
  . The plugin looked okay (I used ByWaterSolutions'
dev-koha-plugin-kitchen-sink) but there were errors when i tried to do anything
with it - it looks like it was uploaded to koha-tmpl/opac-tmpl
- After applying the patch and restarting the plugin showed as having errors.
After reinstalling the plugin everything was back to working as expected and i
could install other plugins. Manually deleted the plugin files added to
koha-tmpl/opac-tmpl/Koha/

David

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303

David Nind  changed:

   What|Removed |Added

 Attachment #120722|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Comment on attachment 120722
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120722
Proposed fix

Not sure what happened here - obsoleting patch so there is only one (the signed
off one).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303

--- Comment #4 from David Nind  ---
Created attachment 123444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123444=edit
Bug 28303 - Fix plugins system with multiple pluginsdir settings

C4/Templates::badtemplatecheck mucks with the config('pluginsdir') array ref.
This makes sure it operates on a copy of the array.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28303] Having multiple pluginsdir causes plugin_upload to try to write to the opac-tmpl folder

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28303

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28809] Patron age calculated incorrectly after changing dateformat syspref

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28809

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
dateformat_pref is a global variable and does not seem to clear until a
restart_all

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28809] New: Patron age calculated incorrectly after changing dateformat syspref

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28809

Bug ID: 28809
   Summary: Patron age calculated incorrectly after changing
dateformat syspref
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:
- change the dateformat syspref (I was on MM/DD/ and changed to -MM-DD)
- click to edit a patron record
- select yesterday for patron's date of birth
- note the text that appears under DOB to tell you the patron's age is
something entirely wrong

This is only an issue with the age as it appears on the edit page. Koha
calculates the age correctly on save and correctly enforces category age
limits.

Dateformat is getting cached somewhere. I was able to correct it by restarting
memcached and plack, but that shouldn't be needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28808] Item search should allow wildcard in subfield when setting up custom search option

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28808

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
Currently the code is something like:
ExtractValue(metadata,'//record/datafield[@tag="XXX"]/subfield[@code="Y"]')
LIKE 'TERM'

If we defaulted to a contains search we could implement as:
SELECT ExtractValue(metadata,'//datafield[@tag="XXX"]/subfield[@code="Y" AND
contains(.,"TERM")]')

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28808] New: Item search should allow wildcard in subfield when setting up custom search option

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28808

Bug ID: 28808
   Summary: Item search should allow wildcard in subfield when
setting up custom search option
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When querying a MARC record via SQL directly, one can wildcard the subfield to
search an entire MARC tag -- like
"ExtractValue(metadata,'//datafield[@tag="650"]/*')" to look at the whole 650
without specifying a subfield.

It would be nice to be able to select "*" for one's subfield when setting up a
custom item search field. As is, you have to either leave it blank (which will
break all searches) or pick a specific value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28807] New: Item search should search repeated subfields sequentially

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28807

Bug ID: 28807
   Summary: Item search should search repeated subfields
sequentially
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Say we have a bib with two 650$a tags, "cheese" and "corn." If we set the 650$a
up as a searchable field in item search, our search terms will be compared to
the string "cheese corn." That means we end up having to wildcard our search
terms in both directions to account for the possibility that they might have a
term on either side in the record ("%cheese%" and "%corn%").

This would work better if we compared our search term to each value
individually, rather than to the concatenated string of all values.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28800] Libabry list at /cgi-bin/koha/admin/branches.pl appears empty

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800

Manos PETRIDIS  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #217 from Martin Renvoize  ---
Yup, I neglected to add the fix for that test to my final commit the first time
around!

All fixed now.. and rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123442|0   |1
is obsolete||

--- Comment #216 from Martin Renvoize  ---
Created attachment 123443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123443=edit
Bug 22435: (follow-up) Set CREATE offset for credits to positive

The history view of an accountline shows increases and decreases in the
amount outstanding from the perspective of the credit/debit line you are
inspecting.

Apply creates a negative offset amount which acts to 'reduce' both the
outstanding 'debt' for the debit line and the outstanding 'credit' for
the credit line.  Starting with a negative offset for the credit thus
makes this nonsenical.

Void creates positive offset amounts which act to 'restore' both the
outstanding 'debt' for the debit line and the outstanding 'credit' for
the credit line.

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122937|0   |1
is obsolete||

--- Comment #215 from Martin Renvoize  ---
Created attachment 123442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123442=edit
Bug 22435: (follow-up) Set CREATE offset for credits to positive

The history view of an accountline shows increases and decreases in the
amount outstanding from the perspective of the credit/debit line you are
inspecting.

Apply creates a negative offset amount which acts to 'reduce' both the
outstanding 'debt' for the debit line and the outstanding 'credit' for
the credit line.  Starting with a negative offset for the credit thus
makes this nonsenical.

Void creates positive offset amounts which act to 'restore' both the
outstanding 'debt' for the debit line and the outstanding 'credit' for
the credit line.

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122917|0   |1
is obsolete||

--- Comment #214 from Martin Renvoize  ---
Created attachment 123441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123441=edit
Bug 22435: (QA follow-up) More test updates

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122916|0   |1
is obsolete||

--- Comment #213 from Martin Renvoize  ---
Created attachment 123440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123440=edit
Bug 22435: (QA follow-up) Fix returned offsets in moredetail

This patch updates the offsets query for lost item returns displayed in
the catalogue/moredetail controller.

Test plan (Same as bug 19919)
Test plan:
1) Pay off a LOST item
2) Check for the associated display of 'Paidfor?:' on the itemdetails page
3) Writeoff a LOST item
4) Check that a 'Paidfor?:' is not displayed on the itemdetails page.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122915|0   |1
is obsolete||

--- Comment #212 from Martin Renvoize  ---
Created attachment 123439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123439=edit
Bug 22435: Update DBIC Schema's

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122914|0   |1
is obsolete||

--- Comment #211 from Martin Renvoize  ---
Created attachment 123438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123438=edit
Bug 22435: (QA follow-up) Fix test for offset total

This patch updates the test for the offset total method to adhere to the
new restricted set of offset types available.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122913|0   |1
is obsolete||

--- Comment #210 from Martin Renvoize  ---
Created attachment 123437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123437=edit
Bug 22435: (QA follow-up) Add missing test for manager relation

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122912|0   |1
is obsolete||

--- Comment #209 from Martin Renvoize  ---
Created attachment 123436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123436=edit
Bug 22435: (follow-up) Drop account_offset_types table

This patch drops the now defunkt account_offset_types table and ensure
the type field in account_offsets is instead an enum type column.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122911|0   |1
is obsolete||

--- Comment #208 from Martin Renvoize  ---
Created attachment 123435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123435=edit
Bug 22435: (follow-up) Update POS for reduced offset types

This patch updates the Koha::Charges::Sales class to use the 'CREATE'
and 'APPLY' offset types.

Test plan
1/ Run t/db_dependent/Koha/Charges/Sales.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122910|0   |1
is obsolete||

--- Comment #207 from Martin Renvoize  ---
Created attachment 123434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123434=edit
Bug 22435: (QA follow-up) Fix test file and adjust test

Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122909|0   |1
is obsolete||

--- Comment #206 from Martin Renvoize  ---
Created attachment 123433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123433=edit
Bug 22435: Improve database update

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122908|0   |1
is obsolete||

--- Comment #205 from Martin Renvoize  ---
Created attachment 123432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123432=edit
Bug 22435: Update accountline-details page to show all history

The accountline-details page took a simplistic approach to displaying
the history of an accountline. This patch drops the now defunct
offset_type_description template block from it's respective include
files, and then updates the accountline-details template and controller
to show the full history of what's happend to the accountline passed.
This includes the creation, any increments/decrements (for fines), and
finally any offsets against the total (payments, cancellations, voids).

Test plan
1/ Create some credits and debits and apply them to each other in
various combinations.
2/ View the 'Details' page for some of the debit/credits
3/ Compare before patch and after for the Details page.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122907|0   |1
is obsolete||

--- Comment #204 from Martin Renvoize  ---
Created attachment 123431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123431=edit
Bug 22435: Update for bug 27049

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122906|0   |1
is obsolete||

--- Comment #203 from Martin Renvoize  ---
Created attachment 123430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123430=edit
Bug 22435: Fix _set_found_trigger

The _set_found_trigger utilised the 'Writeoff' offset type to
distinguish between the application of a writeoff and any other form of
offset application.

This patch updates the trigger to use the full link through from offset
to account credit line to get the credit type being offset.

Test plan
1/ Run t/db_dependent/Koha/Items.t and prove it fails before the patch,
but passes after applying this patch.
2/ Run t/db_dependent/Koha/Account/Offsets.t and prove it passes both
before and after applying this patch.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122905|0   |1
is obsolete||

--- Comment #202 from Martin Renvoize  ---
Created attachment 123429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123429=edit
Bug 22435: Fix CREATE offset amounts

Updateing the tests highlighted a mistake in the original code.. the
offsets for the cancel and reduce creation lines were incorrectly
signed.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122904|0   |1
is obsolete||

--- Comment #201 from Martin Renvoize  ---
Created attachment 123428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123428=edit
Bug 22435: Update unit tests

This patch updates the unit tests to reflect the changes we have made to
offset types.  We do two things:

1) Clean up calls to 'apply' to drop passing offset_type
2) Update test code to look for APPLY and CREATE instead of specific
   offset types.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122903|0   |1
is obsolete||

--- Comment #200 from Martin Renvoize  ---
Created attachment 123427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123427=edit
Bug 22435: ->apply() should always use 'APPLY' for offset_type

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122902|0   |1
is obsolete||

--- Comment #199 from Martin Renvoize  ---
Created attachment 123426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123426=edit
Bug 22435: Add 'APPLY' to account_offset_types

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122901|0   |1
is obsolete||

--- Comment #198 from Martin Renvoize  ---
Created attachment 123425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123425=edit
Bug 22435: Use 'CREATE' offset type in Koha::Account::Line

This patch updates the Koha::Account::Line methods that result in new account
lines to use the 'CREATE' offset type for the creation record.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122900|0   |1
is obsolete||

--- Comment #197 from Martin Renvoize  ---
Created attachment 123424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123424=edit
Bug 22435: Use 'CREATE' offset type in Koha::Account

This patch updates the Koha::Account methods for adding debits and
credits to use the 'CREATE' offset type for the creation record.

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122899|0   |1
is obsolete||

--- Comment #196 from Martin Renvoize  ---
Created attachment 123423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123423=edit
Bug 22435: Update CREATE offset types

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Nick Clemens 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28806] New: Labels exported as PDF create zero sized PDF files.

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806

Bug ID: 28806
   Summary: Labels exported as PDF create zero sized PDF files.
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: egpetri...@yahoo.com
QA Contact: testo...@bugs.koha-community.org

In my first tries to create biblio labels, I see that export to PDF creates
zero sized PDF files, in both individual/single and batch modes.  

Coult it be due to non-latin characters (Greek) appearing in the label
contents? Export to CSV does produce files with the expected number of rows,
albeit with non-usable characters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28799] Action logs should capture lost items found

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799

he...@bywatersolutions.com changed:

   What|Removed |Added

Version|master  |20.05

--- Comment #2 from he...@bywatersolutions.com ---
(In reply to Jonathan Druart from comment #1)
> In master there is no action log when the item is checked in.
> 
> On which version did you test?

20.05. I've updated ticket to reflect that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390

Martin Renvoize  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #121187|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 123422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123422=edit
Bug 28390: Move timestamp into grouping row

This patch moves the timestamp that was getting repeated for each
transaction breakdown row into the group header row.

Test plan
1/ Add a series of transactions to to a register (via Point of Sale
or/and Borrower Accounts)
2/ View the transactions (and past transactions tables) on the Register
details page
3/ Apply the patch and compare the display

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805

Katrin Fischer  changed:

   What|Removed |Added

Summary|Batch checkout shoudl have  |Batch checkout should have
   |on-site checkout option |on-site checkout option

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28805] New: Batch checkout shoudl have on-site checkout option

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805

Bug ID: 28805
   Summary: Batch checkout shoudl have on-site checkout option
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The batch checkout is very useful, but currently doesn't support all advanced
options of the normal search page.

It's missing the "on-site checkout" functionality.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #64 from Nick Clemens  ---
Error in :
installer/data/mysql/atomicupdate/bug_27378_add_CookieConsentPopup_syspref.perl
(shoudl quote with q{} so the | doesn't break it)

In testing I was never able to get the cookies to set - can you provide some
values in the test plan that work on koha testing docker - I got complaints of
bad domain for cookies

Question: Should you be able to keep using the site before clicking 'Accept' on
the necessary cookies?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28736] Better error message when ES fails to understand the syntax of the search query

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736

e.betemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142

Nick Clemens  changed:

   What|Removed |Added

 Attachment #122885|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 123421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123421=edit
Bug 28142: Accessibility: OPAC cart/basket checkboxes are not labelled

This patch adds labels to the checkboxes on the "Your cart" page to
improve accessibility for users of screen readers. The labels are
hidden from display because the item titles provide enough visual
context.

Test Plan:

1. Go to the OPAC
2. Search for some items and add them to your cart
3. Inspect the page html and confirm the checkboxes are not labelled
4. Select the "More Details" page and confirm these labels are missing too
5. Apply the patch
6. Inspect the checkboxes on the "Brief display" and "more details" views
7. Confirm that the checkboxes have meaningful labels and that the visual
display of the pages has not changed.

Signed-off-by: Owen Leonard 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28804] New: 500 Error when running report with bad syntax

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804

Bug ID: 28804
   Summary: 500 Error when running report with bad syntax
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jstalli...@tsas.org
QA Contact: testo...@bugs.koha-community.org

In previous versions, running an SQL report with an error (typo, bad syntax)
would yield an error page with the problem syntax highlighted. 21.05 returns
only a 500 error. Excerpt from plack-intranet-error.log here:
https://pastebin.com/0UCYkU46

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057

--- Comment #19 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #18)
> (In reply to Nick Clemens from comment #17)
> > I don't go further to keep this small for backporting, but I agree, we
> > should rewrite much of this
> 
> I am willing to do it, can I count on you for test or QA? :)

Yes, but another bug report please :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #136 from Jonathan Druart  ---
(In reply to Nick Clemens from comment #135)
> Created attachment 123420 [details] [review]
> Bug 17600: Add missing imports in authorities/
> 
> Signed-off-by: Nick Clemens 

Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316

--- Comment #60 from Peter Vashchuk  ---
Victor, please check this ticket:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28736

it will make sense why search queries like this one "+ - = && || > < ! ( ) { }
[ ] ^ " ~ * ? : \ /" fail :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Nick Clemens  changed:

   What|Removed |Added

 Attachment #123419|0   |1
is obsolete||

--- Comment #135 from Nick Clemens  ---
Created attachment 123420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123420=edit
Bug 17600: Add missing imports in authorities/

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #123418|0   |1
is obsolete||

--- Comment #134 from Jonathan Druart  ---
Created attachment 123419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123419=edit
Bug 17600: Add missing imports in authorities/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057

--- Comment #18 from Jonathan Druart  ---
(In reply to Nick Clemens from comment #17)
> I don't go further to keep this small for backporting, but I agree, we
> should rewrite much of this

I am willing to do it, can I count on you for test or QA? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #133 from Jonathan Druart  ---
Created attachment 123418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123418=edit
Bug 17600: Add missing imports in authorities/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #169 from Martin Renvoize  ---
Comment on attachment 123087
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123087
Bug 11175: Limit the amount of component parts returned

Review of attachment 123087:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11175=123087)
-

::: Koha/Util/Search.pm
@@ +34,5 @@
> +=cut
> +
> +sub get_component_part_query {
> +my ($biblionumber) = @_;
> +

I think perhaps we should be taking UseControlNumber into account here...

See opac-details.pl and details.pl controllers for a near the same case.

  my $cleaned_title = $biblio->title;
  $cleaned_title =~ tr|/||;
  my $query =
( C4::Context->preference('UseControlNumber') and $record->field('001') )
? 'rcn:'. $record->field('001')->data . ' AND (bib-level:a OR bib-level:b)'
: "Host-item:($cleaned_title)";

We should really utilise something similar here I feel.. and even better..
start using this in those two locations too.. or rather.. move that handling
into XSLT.pm as you have done for the overall show parts code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #132 from Jonathan Druart  ---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

--- Comment #131 from Jonathan Druart  ---
Created attachment 123417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123417=edit
Bug 17600: Fix GetTagsLabels imports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057

--- Comment #17 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #16)
> Why aren't we going further here?
> 
> IMO we should completely remove the code related to biblioitemnumber.
> 
> This comment:
> 405 ## Here we go backwards again to create hash of biblioitemnumber to
> itemnumbers
> 406 ## this is important when we have analytic items which may be on
> another record
> 
> It implies that we must use biblioitemnumber to be correct, but we actually
> should use biblionumber.
> 
> Is this correct?

The comment is meant to describe what we are doing so that we can fix it in the
future

I don't go further to keep this small for backporting, but I agree, we should
rewrite much of this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

--- Comment #83 from Jonathan Druart  ---
txn_begin was missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #123372|0   |1
is obsolete||

--- Comment #82 from Jonathan Druart  ---
Created attachment 123415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123415=edit
Bug 27526: Add tests for columns_to_str and host_items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #168 from Martin Renvoize  ---
OK, having dug a bit further I'm a little less sure about this patch set.. I
love it in theory.. but I feel we're perhaps duplicating code a bit..

The code that governs the 'show analytics' link display already does a similar
search but does it within the two -details' controller files.. I feel we should
move to using the Util function and XSLT method from here for both cases.. and
likely take some notice of UseControlNumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083

jjenni...@ait.ie changed:

   What|Removed |Added

 CC||jjenni...@ait.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28728] Holds ratio page links to itself pointlessly

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728

--- Comment #9 from Andrew Fuerste-Henry  ---
(In reply to Jonathan Druart from comment #8)
> Pushed to master for 21.11, thanks to everybody involved!

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #167 from Martin Renvoize  ---
QA Question

Should 'Analytics: Show analytics' still display even when the syspref is
enabled to display them inline?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083

Maura Stephens  changed:

   What|Removed |Added

 CC||maura.steph...@gmit.ie

--- Comment #6 from Maura Stephens  ---
For us, the order date needs to be set and not amendable. Many institutions
will have vendor agreements in place with follow up timeframes and reports need
to display the initial date the order was sent to the vendor. 
We had a report in place in 19.11 that could bypass the reopening of a basket
for amending a price or switching a fund, but this is no longer the case in
20.11 and this causes major issues now with vendor follow up.
Can we please get this bug resolved as a matter of priority.
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27987] Canceling an order / deleting item will result in warning even though there was no problem

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27987

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Kyle M Hall  ---
Bug was resolved when DelOrder was replaced with
Koha::Acquisition::Order::cancel

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28802] Untranslatable strings in browser.js

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

Owen Leonard  changed:

   What|Removed |Added

 Attachment #123408|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 123411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123411=edit
Bug 28802: Untranslatable strings in browser.js

File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation
process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js
We must move it to prog/js.

Test plan :
1) Perform a search on staff interface
2) Click on a result
3) Check you see records browser

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28802] Untranslatable strings in browser.js

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #166 from Martin Renvoize  ---
Created attachment 123410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123410=edit
Bug 11175: (QA follow-up) We lost Encode somewhere

This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it
somewhere along the way and broke the feature as it uses 'decode'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize  changed:

   What|Removed |Added

 CC|koha-b...@lists.koha-commun |
   |ity.org,|
   |testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] New: process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Bug ID: 28803
   Summary: process_message_queue.pl dies if any messsages in the
message queue contain an invalid to_address
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: ha...@orex.es, koha-bugs@lists.koha-community.org,
testo...@bugs.koha-community.org

We try hard to catch bad email addresses on entry, but we don't always succeed
for cases like patron imports.

However, with the introduction of exceptions in Koha::Email->create on invalid
addresses we now die upon meeting such a case in the database. We should
instead wrap this in a try/catch block and report the failure in the database
and then move on to the next message in the queue instead of exploding.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057

--- Comment #16 from Jonathan Druart  ---
Why aren't we going further here?

IMO we should completely remove the code related to biblioitemnumber.

This comment:
405 ## Here we go backwards again to create hash of biblioitemnumber to
itemnumbers
406 ## this is important when we have analytic items which may be on
another record

It implies that we must use biblioitemnumber to be correct, but we actually
should use biblionumber.

Is this correct?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28799] Action logs should capture lost items found

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
In master there is no action log when the item is checked in.

On which version did you test?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28801] OpacSuppression prevents retrieval of non-suppressed titles that contain punctuation

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28801

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #2 from Jonathan Druart  ---
I don't recreate what you describe (tested on master and 20.11.x), the title is
always displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28802] Untranslatable strings in browser.js

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

--- Comment #2 from Fridolin Somers  ---
Created attachment 123408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123408=edit
Bug 28802: Untranslatable strings in browser.js

File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation
process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js
We must move it to prog/js.

Test plan :
1) Perform a search on staff interface
2) Click on a result
3) Check you see records browser

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28802] Untranslatable strings in browser.js

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC)

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||28784

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28796] wrong number of parameters in new_from_xml call

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796

Jonathan Druart  changed:

   What|Removed |Added

Version|20.11   |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28796] wrong number of parameters in new_from_xml call

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28796

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
Yes, that's wrong, it must be
  $rowref->{'encoding'} , $marc_type

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28802] Untranslatable strings in browser.js

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25321] Move translatable strings out of strings.inc into the corresponding JavaScript

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||28802


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802
[Bug 28802] Untranslatable strings in browser.js
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28802] Untranslatable strings in browser.js

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||25321
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
Caused by:
  commit 5fa99d7d59ffe65a3533c79a637b50f04e904736
  Bug 25321: Move translatable strings out of strings.inc into the
corresponding JavaScript


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321
[Bug 25321] Move translatable strings out of strings.inc into the corresponding
JavaScript
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #165 from Martin Renvoize  ---
Created attachment 123406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123406=edit
Bug 11175: (QA follow-up) Move preference to 'Display'

The 'ShowComponentRecords' preference was displaying under the 'Export'
section in the cataloging system preferences tab. As a display related
feature, I felt it was more appropriate to put it into the 'Display'
section.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28220] Exception not caught when importing patrons

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220

--- Comment #40 from Jonathan Druart  ---
(In reply to Fridolin Somers from comment #39)
> Does not apply on 20.11.x.
> Fails because t/db_dependent/Koha/Patron/Attribute.t does not exists.
> This file as been added by Bug 27858. Is it a dependance ?

Yes, you certainly need bug 27858 and bug 27833 as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20447] Add support for MARC holdings records

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||8214


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214
[Bug 8214] Create a bound with function
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8214] Create a bound with function

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||20447


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
[Bug 20447] Add support for MARC holdings records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8214] Create a bound with function

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #9 from Martin Renvoize  ---
(In reply to Katrin Fischer from comment #8)
> There is a difference:
> 
> "Bound withs" are on item level. The library might have something twice, but
> once it's bound with something else and once it's on its own. That can
> happen especially in libraries with old and rare books.
> 
> bug 11175 is talking about showing relationships between bibliographic
> records, so it's on a different level. For example in Germany for a multi
> volume work you'd usually have a 'set record' that represents the whole work
> and then a record for each volume. They are tied together using 7xx and 8xx.
> The goal of bug 11175 would then be to show the volume records on the set
> record.

Oh, I wasn't thinking of this at the item level.. so does this really need the
Holdings level MARC support before it can be implemented then?  i.e. should it
depend on bug 20447

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28802] New: Untranslatable strings in browser.js

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28802

Bug ID: 28802
   Summary: Untranslatable strings in browser.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

File koha-tmpl/intranet-tmpl/js/browser.js is not parsed by translation
process, which uses koha-tmpl/intranet-tmpl/prog/js/**/*.js
We must move it to prog/js.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds

2021-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #98 from Fridolin Somers  ---
Created attachment 123405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123405=edit
Bug 15261: Always check preference PreventCheckoutOnSameReservePeriod first

Proposed patch (may not apply on current master)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/