[Koha-bugs] [Bug 27367] Housebound and CheckPrevCheckout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27367 Donna changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Donna --- Since the functionality to set this by patron category is available, I will close this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27287] Make note fields from orders searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 Hayley Pelham changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27287] Make note fields from orders searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 Hayley Pelham changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |hayleypel...@catalyst.net.n |ity.org |z CC||hayleypel...@catalyst.net.n ||z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28554] In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What|Removed |Added Attachment #123451|0 |1 is obsolete|| --- Comment #12 from David Nind --- Created attachment 123466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123466&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28554] In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What|Removed |Added Attachment #121936|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 123465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123465&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28554] In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What|Removed |Added Attachment #121935|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 123464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123464&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28554] In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #22 from Aleisha Amohia --- These icons were designed by a Catalyst Academy student (Victoria, who opened the bug report), and she designed them as part of her contribution to the Academy. They are free to use for Koha's image sets. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #5 from Michael Hafen --- (In reply to David Cook from comment #2) > The title of this report doesn't make sense. Bibliographic records don't > belong to library branches. > > Also, blocking based on homebranch of items that belong to the record > doesn't make sense. You'd block modifications of bib records as soon as an > item is added for another branch. Branch A might add the bib record, but > then if Branch B adds an item, Branch A won't be able to edit the bib record > that they added. I could see that being frustrating. > > But I can also see it being frustrating to have a different branch change a > bib record that you're using. Hmm... This is a pit-fall with IndependantBranches. As you observe it is frustrating to not be able to change a record, but also frustrating to have someone else change a record you are using. I have a little fork (patch submitted on another enhancement) that hides items from other libraries, so we don't even know when someone else is using a record. Our solution was this; since we can't see when a record is shared we will block changes to those records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 --- Comment #4 from Michael Hafen --- Created attachment 123463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123463&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28743] With IndependentBranches block changes to biblio records shared with other libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28743 Michael Hafen changed: What|Removed |Added Attachment #123068|0 |1 is obsolete|| --- Comment #3 from Michael Hafen --- Comment on attachment 123068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123068 Proposed fix Found a bug in the patch. Will replace the patch shortly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28799] Action logs should capture lost items found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799 Nick Clemens changed: What|Removed |Added Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27360] Libraries should be able to pick what information displays on the 'Libraries' pages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin Somers --- +1 Some customers ask to hide some libraries that are not a "real" place. A "public" or "show in OPAC" flag would be great. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 --- Comment #7 from Owen Leonard --- (In reply to Owen Leonard from comment #5) > I don't have a patch, so please attempt! Never mind I did a patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Owen Leonard changed: What|Removed |Added Attachment #123368|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Owen Leonard changed: What|Removed |Added Attachment #123368|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 123462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123462&action=edit Bug 26626: (follow-up) Update icon selection This patch changes the "Ignore" button to use an X icon and the "Cancel" button to use a "Trash" icon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Andrew Fuerste-Henry changed: What|Removed |Added Severity|normal |enhancement --- Comment #5 from Andrew Fuerste-Henry --- Following through (In reply to Andrew Fuerste-Henry from comment #4) > Hi folks! I'm reopening this one. It was not actually a duplicate of bug > 23767. > 23767 was about the total at the bottom of the table on Acq Home. This is > about the amount shown in each parent fund's line directly. Which means really this is an enhancement rather than a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Owen Leonard changed: What|Removed |Added Attachment #123446|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 123461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123461&action=edit Bug 28804: (bug 25026 follow-up) Handle SQL errors in reports Since bug 25026 DBMS errors are raised, but the report module is not dealing correctly with the errors. If an error occurred in execute_query, next queries will fail as well, we should skip them. Test plan: 1. Create report from SQL queries, containing errors (invalid syntax, etc.) 'SELECT id FROM borrowers' can do it 2. Execute the query => Without this patch you get a 500 => With this patch applied you see that the error raised at DBMS level is propagated to the UI 3. Confirm that there is no regression on valid queries Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28804] 500 Error when running report with bad syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28804 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 --- Comment #6 from Katrin Fischer --- Created attachment 123460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123460&action=edit Bug 20463: (follow-up) Remove option from search templates Using this search option in the GUI would require the user to enter the codes from MARC, LDR 19, see: https://www.loc.gov/marc/bibliographic/bdleader.html So I think it's better to leave this out for the moment. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 --- Comment #5 from Katrin Fischer --- Created attachment 123459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123459&action=edit Bug 20463: (follow-up) Configure short name mrl for Multipart-resource-level index This adds mrl as appreviation of Multipart-resource-level to the Zebra configuration and Search.pm so it can be used when searching. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Katrin Fischer changed: What|Removed |Added Attachment #123355|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 123458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123458&action=edit Bug 20463: Adding index for Leader 19 Multipart resource record level Sponsored-by: Bibliotheksservice-Zentrum Baden-Wuerttemberg Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28812] Authority tag editor only copies $a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Didier Gautheron changed: What|Removed |Added Summary|Authority tag editor only |Authority tag editor only |copy $a |copies $a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields and subfields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Didier Gautheron changed: What|Removed |Added Blocks||28812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 [Bug 28812] Authority tag editor only copy $a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28812] New: Authority tag editor only copy $a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812
Bug ID: 28812
Summary: Authority tag editor only copy $a
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs@lists.koha-community.org
Reporter: didier.gauthe...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
Depends on: 7882
Steps to reproduce:
1- Create a notice with a 700$a and 700$d
2- Click on Tag Editor
3- Only 700$a is copied
Expect result:
same as 19.11 all other subfields should be copied.
There's now one more level in HTML tree and
koha-tmpl/intranet-tmpl/prog/js/cataloging.js:openAuth() selects the wrong
node.
To check: still working in
authorities/authorities.pl
diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
index f126c86de2..35cbe499ae 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
@@ -43,8 +43,8 @@ function openAuth(tagsubfieldid,authtype,source) {
var elementsubfcode=getSubfieldCode(element.name);
var mainmainstring=element.value;
var mainstring = new Array();
-var inputs = element.parentNode.parentNode.getElementsByTagName("input");
+var inputs =
element.parentNode.parentNode.parentNode.getElementsByTagName("input");
for (var myindex =0; myindexhttps://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882
[Bug 7882] Add ability to move and reorder fields and subfields in MARC editor
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What|Removed |Added Attachment #123164|0 |1 is obsolete|| Attachment #123165|0 |1 is obsolete|| Attachment #123166|0 |1 is obsolete|| --- Comment #21 from Owen Leonard --- Created attachment 123457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123457&action=edit Bug 27522: Adding new itemtype info image to carredart This patch adds an "info" icon to the carredart icon set. It was created from scratch for Koha based on an earlier patch by Victoria Faafia. Test Plan: 1. Go to Administration > Item Types > Modify Item Type 2. Under carredart you should see an "info" item type icon. Assign it to an item type. 3. Go to Administration -> System preferences and make sure that OpacAdvSearchOptions and AdvancedSearchTypes have item type searches enabled. 4. In the OPAC and staff interface, view the advanced search page and confirm that the new icon appears. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28752] Add 'sort fields' to Housebound module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28752 --- Comment #2 from Rhonda Kuiper --- Interesting idea. This will work for some of the information we want to associate with our housebound patrons but there are other bits of information that we aren't saving anywhere else like the quadrant of the city the person lives in. For these extra things we would like a few fields that we can define as we need. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Andrew Nugged changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #36 from Andrew Nugged --- Petro, regarding this from JD: > 2. You need a new method in Koha::CirculationRules to retrieve the effective > value of the new rule (have a look at 'sub get_effective_*') Let's create +1 more patch and move get_effective_expire_reserves_charge as for example get_effective_daysmode created and move "default detection" logic there, so it will be the proper place for re-usable code. (JD: thanks for the explanation!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28549] Add a system preference to duplicate --frombranch flag in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28549 Andrew Fuerste-Henry changed: What|Removed |Added CC||k...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #35 from Peter Vashchuk --- Created attachment 123456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123456&action=edit Bug 25711: fix existing tests and add new one Add a new test with circulation rule for library_C_code that has set expire_reserves_charge which is 0. In this case 0 should be used as the charge. Also use build_object instead of build to build the koha object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Peter Vashchuk changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28773] Aquisitions from external source not working for non english language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28773 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #21 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28391] Elasticsearch - Add 264b to publisher index mapping (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28391 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #30 from Jonathan Druart --- (In reply to Jonathan Druart from comment #28) > About the warns in the db rev, don't we actually want to explode instead? DB rev adjusted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28391] Elasticsearch - Add 264b to publisher index mapping (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28391 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle and 245p part subfields in the default title index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27848] Elasticsearch - include 245b subtitle and 245p part subfields in the default title index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27848 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #218 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #29 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28752] Add 'sort fields' to Housebound module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28752 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- I like this idea generally, but I'd prefer a method to define fields as desired, rather than a set number of fields -- something more like a patron attribute rather than something like sort1/sort2. In fact, could we make this an option on patron attributes? A checkbox in attribute setup for something like "Show in housebound." If that's checked, this attribute shows in the housebound module rather than in the usual place? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27367] Housebound and CheckPrevCheckout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27367 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18425] Housebound module needs to accomodate branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18425 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +!, makes sense! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #123445|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 123455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123455&action=edit Bug 28810: replace housebould detail inputs with textarea To test: 1. apply patch 2. enable housebound module 3. go to a patron and look at the housebound tab 4. Edit the detials. 5. The preferred materials, subjects, authors, referral, and note inputs should be replace with much larger textareas. 6. You should now be able to added line breaks, so fill out each of the fields adding some line breaks. I added something like: Fiction authors: Frank Herbert Non-fiction authors: Malcolm Gladwell 7. Save changes 8. Now when you look at the housebound details those line breaks should be preserved and much easier to read. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Attachment #12|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Attachment #123332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #34 from Andrew Nugged --- We tested once more with Petro: Nick's update works, so it's ok, I was confused that we might overlap 0 in "$rule ? $rule->rule_value : C4::Context->preference..." but we before "?" checking for RULE as _object_, not rule value (my confusion :) ), so even if rule_value is 0, object anyway will be truth, so zero returned, and logic works. And in the "Default" case in rule, we store "undef", which leads to full rule absence in DB, so again: checking for the rule as object fails and we falling back to Default. All ok with logic, yeah. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15067] Add additional languages to advanced search language search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #28 from Jonathan Druart --- About the warns in the db rev, don't we actually want to explode instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
--- Comment #33 from Andrew Nugged ---
> 4. (not blocker)
> Not a bit deal but in tests you can use $builder->build_object instead of
> ->build, to return a Koha::Object-based object.
and, as I figured out too, seems tests needed to protect numerical zero in rule
value not to be overlapped with default:
10) But in case if matching rule has zero ("0") as a value - that
allows to have no-fee smart-rule results, as a feature.
... and this is not covered by tests now. So, Petro, you can update tests also
taking into account this JD's p4 advice.
As well as I see roll-back for this
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123328&action=diff#a/Koha/Hold.pm_sec1
needed to restore this "no-fee (0) for particular items when the default is not
zero" feature.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 --- Comment #20 from Jonathan Druart --- Created attachment 123454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123454&action=edit Bug 28630: Improve date comparisons in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
--- Comment #32 from Peter Vashchuk ---
(In reply to Jonathan Druart from comment #29)
> 3.
> -} else if ( i == 5 || i == 6 || i == 26 || i == 27
> || i == 28 ) {
> +} else if ( i == 5 || i == 6 || i == 17 || i == 27
> || i == 28 || i == 29 ) {
>
> I think there is something wrong here. Why did you remove 26?...
A new 17th column was added, so the number of columns increased, and relative
numbers for the next ones shifted, in short, 26th column wasn't removed, it
just became 27th, so 26 27 28 are 27 28 29 accordingly.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Passed QA |In Discussion --- Comment #20 from Jonathan Druart --- Can we squash and clarify in the commit message what's happening here? It seems that the icons were part of Koha (bug 5640) but have been removed (inadvertently) and so we are adding them back? But with a modified version because we didn't know what was the license? Aleisha, do you remember the origin of this bug report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #31 from Andrew Nugged --- > 1. Tiny wording change suggestion, do you agree with the last patch? yes, "Default" is good -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 --- Comment #5 from Jonathan Druart --- My fix was 143 next unless $kohafield and $av; But yours is better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 Jonathan Druart changed: What|Removed |Added Blocks||28352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Jonathan Druart changed: What|Removed |Added Depends on||27852 CC||jonathan.druart+koha@gmail. ||com --- Comment #4 from Jonathan Druart --- Highlighed by bug 27852. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27852 [Bug 27852] Link YES_NO authorized value category to 942$n in Default framework -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
--- Comment #30 from Andrew Nugged ---
I think we lost part of the logic after changes (as I remember it was tricky):
The goal was: when we calling "get_effective_rule" for "expire_reserves_charge"
we expect to have any number _including_ zero as value for real charge value,
and in case we have '' (blank) in the rule, we get
"ExpireReservesMaxPickUpDelayCharge" instead, as default.
Look for commit description test/check scenario:
...
10) But in case if matching rule has zero ("0") as a value - that
allows to have no-fee smart-rule results, as a feature.
but now: there is the replacement in patch 123328:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123328&action=diff#a/Koha/Hold.pm_sec1
This:
my $rule_value = $rule && $rule->rule_value // '';
$charge = $rule_value ne ''
? $rule_value
: C4::Context->preference("ExpireReservesMaxPickUpDelayCharge");
is replaced by:
$charge = $rule
? $rule->rule_value
: C4::Context->preference("ExpireReservesMaxPickUpDelayCharge");
and the new version goes only for "Perl truth" so it doesn't differentiate
between 0 and '' (under as well) and all goes then to "Default", but we should
have 0 instead of Default if we have zero in $rule->rule_value.
Petro, let's check why tests are passing :)...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 --- Comment #9 from Jonathan Druart --- (not related to this patch but we have .hold_location_select and .pickup_location_dropdown) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #29 from Jonathan Druart ---
1. Tiny wording change suggestion, do you agree with the last patch?
2. You need a new method in Koha::CirculationRules to retrieve the effective
value of the new rule (have a look at 'sub get_effective_*')
3.
-} else if ( i == 5 || i == 6 || i == 26 || i == 27 ||
i == 28 ) {
+} else if ( i == 5 || i == 6 || i == 17 || i == 27 ||
i == 28 || i == 29 ) {
I think there is something wrong here. Why did you remove 26? Do you understand
what this part of the code does? It's displaying "Unlimited" for integer
without value. But you want "use global/Default" to be displayed if the rule is
empty.
I am not sure we need this line to change.
4. (not blocker)
Not a bit deal but in tests you can use $builder->build_object instead of
->build, to return a Koha::Object-based object.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28811] New: Cant receive orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28811 Bug ID: 28811 Summary: Cant receive orders Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mbar...@birzeit.edu QA Contact: testo...@bugs.koha-community.org Created attachment 123453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123453&action=edit no listing order to receive Dears, Im on debian 9 koha 21.05 I have a problem with receiving orders, I have closed basket, with a lot of orders inside, check picture attached , if I try to receive any order, nothing appear on the receiving page , check next photo. logs from server ==> /var/log/koha/koha/plack.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /intranet/acqui/parcel.pl?invoiceid=22 HTTP/1.1" 200 41592 "https://koha-intra.birzeit.edu/cgi-bin/koha/acqui/parcels.pl?booksellerid=309"; "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36" ==> /var/log/koha/koha/intranet-access.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /cgi-bin/koha/acqui/parcel.pl?invoiceid=22 HTTP/1.1" 200 7952 ==> /var/log/koha/koha/plack.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /api/v1/app.pl/api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&_match=contains&_order_by=%2Bbasket.name HTTP/1.1" 404 - "https://koha-intra.birzeit.edu/cgi-bin/koha/acqui/parcel.pl?invoiceid=22"; "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36" ==> /var/log/koha/koha/intranet-access.log <== IP - - [04/Aug/2021:09:26:51 +0300] "GET /api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&_match=contains&_order_by=%2Bbasket.name HTTP/1.1" 404 1046 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #28 from Jonathan Druart --- Created attachment 123452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123452&action=edit Bug 25711: Wording 'use global' > 'Default' We use 'Default' for useDaysMode already -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Jonathan Druart changed: What|Removed |Added Depends on||25711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Jonathan Druart changed: What|Removed |Added Blocks||15523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Jonathan Druart changed: What|Removed |Added Summary|Add ability to define |Move |expiredpickup charge for|ExpireReservesMaxPickUpDela |patron category and item|yCharge to the circulation |type|rules CC||jonathan.druart+koha@gmail. ||com Version|20.05 |unspecified Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #9 from Jonathan Druart --- Why this limitation? I would exclude a list of special characters but not to anything that is not a-Z0-9, "❤" is a valid branchcode and is known (by me, at least) to work perfectly. It will certainly be considered as a regression by users not using Latin alphabet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28526] Impossible to search only zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28526 --- Comment #6 from Fridolin Somers --- Can this be backported to 21.05.x please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28554] In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #9 from Fridolin Somers --- Created attachment 123451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123451&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28554] In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What|Removed |Added Attachment #122546|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 123450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123450&action=edit Bug 28630: (follow-up) Update wording of syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What|Removed |Added Attachment #122545|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 123449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123449&action=edit Bug 28630: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Martin Renvoize changed: What|Removed |Added Attachment #122544|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 123448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123448&action=edit Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 --- Comment #10 from Fridolin Somers --- OK so we wait on Bug 28390 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Fridolin Somers changed: What|Removed |Added Attachment #119447|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Fridolin Somers changed: What|Removed |Added Attachment #119809|0 |1 is obsolete|| --- Comment #9 from Fridolin Somers --- Comment on attachment 119809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119809 Bug 28127: Add transaction timestamp to register details tables Patch with "add" was pushed to master so I obsolete patch with "Add". It will be missing "Signed-off-by: Katrin Fischer" but we know it ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||jonathan.druart+koha@gmail. ||com --- Comment #16 from Jonathan Druart --- There is a conflict on the last patch, Martin can you have a look please? Should be easy for a native English speaker :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Jonathan Druart changed: What|Removed |Added Attachment #119447|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28127] POS register details tables should have a transaction date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28127 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- Personally.. I think if this is backported then bug 28390 should be too in quick succession as it fixes a bug with this implimentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #7 from Fridolin Somers --- Done, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28569] In opac-suggestions.pl user library is not preselected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28569 Fridolin Somers changed: What|Removed |Added Summary|In opac-suggestions.pl |In opac-suggestions.pl user |preselect user library |library is not preselected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 --- Comment #3 from Fridolin Somers --- I was just about to open the same issue ;) Thanks a lot Nick :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Fridolin Somers changed: What|Removed |Added Attachment #121424|0 |1 is obsolete|| --- Comment #2 from Fridolin Somers --- Created attachment 123447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123447&action=edit Bug 28352: Only check authorised values mapped to DB fields The errors reported seem to be caused by authorised values mapped to MARC fields but not mapped to a koha field. We should additionally make sure to check the Default framework Also, adding comment to indicate we only check records with items, because we do TO test: 1 - In a framework that is not the default map a MARC field to an authorised value, but not a koha field 2 - In SQL, force the kohafield to NULL for the mapping you just make UPDATE marc_subfield_structure SET kohafield = NULL WHERE frameworkcode='BKS' and authorised_value='HINGS_AS' 3 - perl misc/maintenance/search_for_data_inconsistencies.pl 4 - get the following errors: Use of uninitialized value $tmp_kohafield in pattern match (m//) at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 151. Use of uninitialized value $tmp_kohafield in substitution (s///) at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 154. Can't call method "get_column" on an undefined value at /kohadevbox/koha/misc/maintenance/search_for_data_inconsistencies.pl line 157. 5 - Apply patch 6 - Repeat 7 - No more errors Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28352] Errors in search_for_data_inconsistencies.pl relating to authorised values and frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28352 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
