[Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow'

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27507

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21469

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow'

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow'

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

--- Comment #1 from Martin Renvoize  ---
With the introduction of the ability to search using 003 as part of the query
for analytics, we should account for this in the cataloguing workflow.

We should check for the presence of 'MarcOrgCode' being defined (at library or
system level) and if it is being used we should copy the value of the 003 of
the parent record into the constructed 773.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21469] Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow'

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21469

Martin Renvoize  changed:

   What|Removed |Added

Summary|Add |Account for 'MarcOrgCode'
   |useControlNumberIdentifier  |preference in 'Enhanced
   |preference to allow |Analytics Workflow'
   |(003)001 constructions in   |
   |$w links.   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507

--- Comment #5 from Martin Renvoize  ---
I've been doing some more work on bug 11175 and I think there might be a DRY
solution to this we could use.. rather than using functions in the XSLT Utils I
think we could/should be using the constructed query string from
Koha::Util::Search, passing it as a variable as 11175 does for the inline view
expansion over 300 records.

I'll submit that patch later today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28656] Cancellations should be allowed on paid/partially paid debts

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656

--- Comment #24 from Marcel de Rooy  ---
Ping Martin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #46 from Marcel de Rooy  ---
> Signed-off-by: Owen Leonard 
> 
> Signed-off-by: David Nind 

Great. Thx Owen and David !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28819] Add link to Item Search from mainpage.pl

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819

Donna  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
   ||,
   ||ke...@bywatersolutions.com,
   ||lu...@bywatersolutions.com,
   ||sbr...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28819] New: Add link to Item Search from mainpage.pl

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28819

Bug ID: 28819
   Summary: Add link to Item Search from mainpage.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The only way to access item search is through the drop down Search link in the
top bar.  It would be helpful to have a "button" to the item search on the main
page, like there is for Advanced Search.  The item search is heavily used, and
having a more prominent way to access it would be helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #89 from Agnes Rivers-Moore  ---
Ah - there might be a problem with Koha counting SIP logins as 'failed'
attempts. I could not see it before, but thanks to this enhancement I do see
that the total of login attempts goes up by one when I log in to Overdrive
Libby, and it is not reset to zero again - even though the login is successful.
 We had found more patrons complained of being locked out of the OPAC when they
had not had 8 failed login attempts. If SIP login adds one every time, and does
not clear back to zero, people using SIP products can come back to the Koha
OPAC and find themselves locked out. I am on Koha 20.11
It may be this needs to be a separate new bug - anyone interested to describe
what's not working as expected with SIP logins? (and possibly other kinds of
external login too...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #88 from Agnes Rivers-Moore  ---
Created attachment 123540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123540&action=edit
Picture of log showing successful SIP logins incrementing 'attempts'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to its completion

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au
Summary|Delivery notes feature was  |Delivery notes feature was
   |pushed prior to it's|pushed prior to its
   |completion  |completion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #9 from David Nind  ---
Testing notes (koha-testing-docker):
- prove t/db_dependent/Letters.t (before apply patches)
- apply patches
- updatedatabase + dbic
- flush_memcached
- restart_all
- prove t/db_dependent/Letters.t (tests should pass)

Hope that is sufficient for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813

David Nind  changed:

   What|Removed |Added

 Attachment #123474|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 123539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123539&action=edit
Bug 28813: Rename delivery_note to failure_code

We now use the codes from the half implimented error_code in place of
the plain text that was being added to the delivery_note field. As part
of that we rename the field to failure_code to clarify it's intended
content.

Test plan
1/ Confirm t/db_dependent/Letters.t passes

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813

David Nind  changed:

   What|Removed |Added

 Attachment #123473|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 123538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123538&action=edit
Bug 28813: Update unit tests

This patch updates the unit tests to check for failure_code instead of
delivery_note and catches a missing case.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813

David Nind  changed:

   What|Removed |Added

 Attachment #123472|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 123537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123537&action=edit
Bug 28813: DBIC Schema Update

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813

David Nind  changed:

   What|Removed |Added

 Attachment #123471|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 123536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123536&action=edit
Bug 28813: Update database field name

Update the database field name from 'delivery_note' to 'failure_code' to
more accurately denote it's use.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28813] Delivery notes feature was pushed prior to it's completion

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #7 from David Nind  ---
Hi Agustín.

There are errors when running the database update:

root@kohadevbox:koha(bz27945)$ updatedatabase
DEV atomic update: bug_27945.perl
Atomic update generated errors: {UNKNOWN}: DBI Exception: DBD::mysql::db do
failed: Unknown column 'article_request_fee' in 'categories' [for Statement "
ALTER TABLE `categories` ADD COLUMN `article_request_limit` tinyint(4)
DEFAULT NULL COMMENT 'Limit article scan requests per day' AFTER
`article_request_fee`
  "]  at /usr/share/perl5/DBIx/Class/Schema.pm line 1118.
DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x55c0aed443e8),
"DBI Exception: DBD::mysql::db do failed: Unknown column 'arti"...) called at
/usr/share/perl5/DBIx/Class/Storage.pm line 113
   
DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x55c0b29ba4b0),
"DBI Exception: DBD::mysql::db do failed: Unknown column 'arti"...) called at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501
DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed: Unknown
column 'article_request_fee"..., DBI::db=HASH(0x55c0b4469f90), undef) called at
(eval 1487) line 7
eval '$DBversion = \'XXX\'; # will be replaced by the RM
if( CheckVersion( $DBversion ) ) {
# you can use $dbh here like:
# $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" );

# or perform some test and warn
if( !column_exists( \'categories\', \'article_request_limit\' ) ) {
  $dbh->do(q{
ALTER TABLE `categories` ADD COLUMN `article_request_limit` tinyint(4)
DEFAULT NULL COMMENT \'Limit article scan requests per day\' AFTER
`article_request_fee`
  });
}

# Always end with this (adjust the bug info)
NewVersion( $DBversion, 27945, "Add article_request_limit to categories
table");
}
' called at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 24596


DEV atomic update: bug_27946.perl
Upgrade to XXX done [20:29:34]: Bug 27946 - Add article_request_fee to
categories table, add debit_line_id column to article_requests table and add
ARTICLE_REQUEST as a debit type

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

David Nind  changed:

   What|Removed |Added

 Attachment #123525|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 123535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123535&action=edit
Bug 28816: Improve the display of multiple holds during hold process

This patch updates the appearance of the "confirm holds" page, shown
during the process of placing a hold for someone in the staff interface.

Most of the changes affect the appearance of the page when placing
multiple holds on titles which have one or more holds on them already.

The changes are intended to make the page clearer and easier to scan,
especially when placing multiple holds at once.

Also changed: The page heading when placing multiple holds now changes
based on whether you've selected a patron or not. It says "Search
patrons or clubs" when it's waiting for a patron/club selection. It says
"Place holds" after the patron/club has been selected. This is instead
of "Confirm holds" on both pages.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> System preferences and set HoldsSplitQueue to
  "nothing."
- Perform a search in the staff client catalog and place multiple holds
  titles from that result set on hold for a patron.
- Perform the same search and select one or more of the titles you
  selected before in addition to one or more titles with no holds.
- After clicking the "Place hold" button you should see a page with the
  heading "Search patrons or clubs" showing information about existing
  holds. This section of the page should be clear and readable, with
  clear distinction between each section of information about each hold.
- Test this page again under each different option for the
  "HoldsSplitQueue" system preference by changing the preference and
  reloading the page.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

David Nind  changed:

   What|Removed |Added

 Attachment #123529|0   |1
is obsolete||

--- Comment #45 from David Nind  ---
Created attachment 123534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123534&action=edit
Bug 26302: Refactor Availability block in OPAC results xslt

Decided finally to do a larger refactor here. Hopefully we improved
consistency and removed some redundancy. And the two new prefs provide
additional functionality.

Most significant changes:
[1] Clearer distinction of the Availability line in three parts:
Available, Reference and Unavailable.
For Unavailable we loop thru branches now too.
[2] Calling template to list item data (including location or ccode).
Made the separate Location line obsolete.
[3] The tests around OPACItemLibrary are removed since we now look at
resultbranch from XSLT.pm.
[4] Removed code replication for various 'other' statuses like Checked out.
[5] Obsoleted three xslt key indexes, singleBranchMode.
[6] Apply the two prefs to control number of listed items.

Test plan:
You may play with: OPACResultsLibrary (home/holding), OPACItemLocation
(library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers),
Reference_NFL_Statuses (list of notforloan codes in reference part).

[1] Create a biblio with various items on a few branches. Fill call number,
location and ccode too. Set home branch and holdingbranch differently.
[2] Toggle the preferences, and verify display within OAPC search results.

Example with prefs (home, callnumber, 2, 2):
Availability: Items available for loan: Centerville (2)Call number: perl A 4,
PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call
number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL
A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff
Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call
number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1.

Same data with prefs (holding, callnumber, 2, 2):
Availability: Items available for loan: Centerville (1)Call number: PERL D 1.
Liberty (1)Call number: perl A 4. Items available for reference: Centerville:
Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out
(1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A
2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call
number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff
Collection (1)Call number: PERL E 1.

Same data with prefs (holding, library, n/a, n/a):
Availability: Items available for loan: Centerville (1). Liberty (1). Items
available for reference: Centerville: Not For Loan (1). Not available:
Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville:
Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff
Collection (1).

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

David Nind  changed:

   What|Removed |Added

 Attachment #123528|0   |1
is obsolete||

--- Comment #44 from David Nind  ---
Created attachment 123533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123533&action=edit
Bug 26302: Changes for substatus, resultbranch in XSLT.t

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

David Nind  changed:

   What|Removed |Added

 Attachment #123527|0   |1
is obsolete||

--- Comment #43 from David Nind  ---
Created attachment 123532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123532&action=edit
Bug 26302: Add resultbranch and other status in C4/XSLT

Groundwork for changes in the OPAC results xslt.

NOTE: Adds both new prefs too.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

David Nind  changed:

   What|Removed |Added

 Attachment #123526|0   |1
is obsolete||

--- Comment #42 from David Nind  ---
Created attachment 123531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123531&action=edit
Bug 26302: Add dbrev for two new prefs

Adding two prefs:
resultsMaxItems
resultsMaxItemsUnavailable

Test plan:
Check Preferences/OPAC/Appearance.

Signed-off-by: David Nind 

Signed-off-by: Owen Leonard 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28799] Action logs should capture lost items found

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799

Owen Leonard  changed:

   What|Removed |Added

 Attachment #123480|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 123530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123530&action=edit
Bug 28799: Log when item was lost and now found

In the subroutine ModDateLastSeen we unset an item's lost status when
checked in.

This routine passes a noi log parameter to the store request, this is
to avoid spamming the cataloguing log on every checkin.

When marking an item unlost we should record this change.

To test:
1 - Enable cataloguing log
2 - Mark an item lost
3 - View the log and confirm this chagne was recorded
4 - Check the item in
5 - The message indicates item is now found, but logs have no new entry
6 - Apply patch, restart all
7 - Mark the item lost and verify it is logged
8 - Check the item in, reported found and log entry recorded

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28799] Action logs should capture lost items found

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28799

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #41 from Owen Leonard  ---
Created attachment 123529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123529&action=edit
Bug 26302: Refactor Availability block in OPAC results xslt

Decided finally to do a larger refactor here. Hopefully we improved
consistency and removed some redundancy. And the two new prefs provide
additional functionality.

Most significant changes:
[1] Clearer distinction of the Availability line in three parts:
Available, Reference and Unavailable.
For Unavailable we loop thru branches now too.
[2] Calling template to list item data (including location or ccode).
Made the separate Location line obsolete.
[3] The tests around OPACItemLibrary are removed since we now look at
resultbranch from XSLT.pm.
[4] Removed code replication for various 'other' statuses like Checked out.
[5] Obsoleted three xslt key indexes, singleBranchMode.
[6] Apply the two prefs to control number of listed items.

Test plan:
You may play with: OPACResultsLibrary (home/holding), OPACItemLocation
(library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers),
Reference_NFL_Statuses (list of notforloan codes in reference part).

[1] Create a biblio with various items on a few branches. Fill call number,
location and ccode too. Set home branch and holdingbranch differently.
[2] Toggle the preferences, and verify display within OAPC search results.

Example with prefs (home, callnumber, 2, 2):
Availability: Items available for loan: Centerville (2)Call number: perl A 4,
PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call
number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL
A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff
Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call
number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1.

Same data with prefs (holding, callnumber, 2, 2):
Availability: Items available for loan: Centerville (1)Call number: PERL D 1.
Liberty (1)Call number: perl A 4. Items available for reference: Centerville:
Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out
(1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A
2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call
number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff
Collection (1)Call number: PERL E 1.

Same data with prefs (holding, library, n/a, n/a):
Availability: Items available for loan: Centerville (1). Liberty (1). Items
available for reference: Centerville: Not For Loan (1). Not available:
Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville:
Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff
Collection (1).

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #40 from Owen Leonard  ---
Created attachment 123528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123528&action=edit
Bug 26302: Changes for substatus, resultbranch in XSLT.t

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #39 from Owen Leonard  ---
Created attachment 123527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123527&action=edit
Bug 26302: Add resultbranch and other status in C4/XSLT

Groundwork for changes in the OPAC results xslt.

NOTE: Adds both new prefs too.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Owen Leonard  changed:

   What|Removed |Added

 Attachment #123499|0   |1
is obsolete||
 Attachment #123500|0   |1
is obsolete||
 Attachment #123501|0   |1
is obsolete||
 Attachment #123502|0   |1
is obsolete||

--- Comment #38 from Owen Leonard  ---
Created attachment 123526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123526&action=edit
Bug 26302: Add dbrev for two new prefs

Adding two prefs:
resultsMaxItems
resultsMaxItemsUnavailable

Test plan:
Check Preferences/OPAC/Appearance.

Signed-off-by: David Nind 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

--- Comment #1 from Owen Leonard  ---
Created attachment 123525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123525&action=edit
Bug 28816: Improve the display of multiple holds during hold process

This patch updates the appearance of the "confirm holds" page, shown
during the process of placing a hold for someone in the staff interface.

Most of the changes affect the appearance of the page when placing
multiple holds on titles which have one or more holds on them already.

The changes are intended to make the page clearer and easier to scan,
especially when placing multiple holds at once.

Also changed: The page heading when placing multiple holds now changes
based on whether you've selected a patron or not. It says "Search
patrons or clubs" when it's waiting for a patron/club selection. It says
"Place holds" after the patron/club has been selected. This is instead
of "Confirm holds" on both pages.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> System preferences and set HoldsSplitQueue to
  "nothing."
- Perform a search in the staff client catalog and place multiple holds
  titles from that result set on hold for a patron.
- Perform the same search and select one or more of the titles you
  selected before in addition to one or more titles with no holds.
- After clicking the "Place hold" button you should see a page with the
  heading "Search patrons or clubs" showing information about existing
  holds. This section of the page should be clear and readable, with
  clear distinction between each section of information about each hold.
- Test this page again under each different option for the
  "HoldsSplitQueue" system preference by changing the preference and
  reloading the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28818] New: Patron Messaging Preferences including ILL Messaging

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28818

Bug ID: 28818
   Summary: Patron Messaging Preferences including ILL Messaging
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

As this table (Patron Messaging Preferences) on the Patron Detail page, is
getting long on the Patron's account, is there a way a library could not see
the 3 ILL Messaging preferences if they are not using the ILL module (so the
Sys Pref for ILL is set to disable)? This would be similar to not displaying
the Phone Column in Messaging Settings if the library does not use a Phone
Service to call patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17335] waitingreserves.pl cancel button needs simplification

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17335

--- Comment #2 from Christopher Brannon  ---
(In reply to Owen Leonard from comment #1)
> The check-in page shows a dialog telling the user that a transfer is
> required when checking in an item from another library. I think adding the
> same thing to this page would eliminate the need for a "Cancel and return
> to..." button label.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19685] Canceling a hold from the Hold Found popup does not alert librarian about next hold

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685

--- Comment #3 from Christopher Brannon  ---
Hmmm...I thought maybe this had been addressed, maybe in another bug somewhere.
 Currently, in 20.05.13, if I check in an item that is a waiting hold, I can
cancel the hold, and then it immediately triggers the next hold (asks for
confirmation).  Is this not a new feature?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #187 from Martin Renvoize  ---
t/Koha/Util/Search.t needs updating for that final patch.. one to attack
tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123523|0   |1
is obsolete||

--- Comment #186 from Martin Renvoize  ---
Created attachment 123524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123524&action=edit
Bug 11175: (QA follow-up) Take account of bug 15851

We can simplify the code introduced by bug 15851 by moving the
'show_analytics_link' variable assignment into C4::XSLT and thus making
the code more DRY.

Taking the code in bug 15851 as inspiration this patch also adds proper
handling for UseControlNumber vs EasyAnalytics style 773 linking and
ensures we only return analytic component parts and no other records
containing 773's.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #185 from Martin Renvoize  ---
Created attachment 123523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123523&action=edit
Bug 11175: (QA follow-up) Take account of bug 15851

We can simplify the code introduced by bug 15851 by moving the
'show_analytics_link' variable assignment into C4::XSLT and thus making
the code more DRY.

Taking the code in bug 15851 as inspiration this patch also adds proper
handling for UseControlNumber vs EasyAnalytics style 773 linking and
ensures we only return analytic component parts and no other records
containing 773's.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123410|0   |1
is obsolete||

--- Comment #184 from Martin Renvoize  ---
Created attachment 123522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123522&action=edit
Bug 11175: (QA follow-up) We lost Encode somewhere

This adds back `use Encode qw( decode )` into C4::XSLT.pm. We lost it
somewhere along the way and broke the feature as it uses 'decode'.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123406|0   |1
is obsolete||

--- Comment #183 from Martin Renvoize  ---
Created attachment 123521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123521&action=edit
Bug 11175: (QA follow-up) Move preference to 'Display'

The 'ShowComponentRecords' preference was displaying under the 'Export'
section in the cataloging system preferences tab. As a display related
feature, I felt it was more appropriate to put it into the 'Display'
section.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123093|0   |1
is obsolete||

--- Comment #182 from Martin Renvoize  ---
Created attachment 123520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123520&action=edit
Bug 11175: (QA follow-up) Replace en dash with hyphen in perldoc

This fixes the QA tool failure.

Signed-off-by: Joonas Kylmälä 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123092|0   |1
is obsolete||

--- Comment #181 from Martin Renvoize  ---
Created attachment 123519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123519&action=edit
Bug 11175: (follow-up) Rename routine get_marc_components

For consistency with other marc data accessor methods rename the new
'components' method to 'get_marc_components'.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123091|0   |1
is obsolete||

--- Comment #180 from Martin Renvoize  ---
Created attachment 123518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123518&action=edit
Bug 11175: (follow-up) make atomic update idempotent

Atomic update tries to insert line into system preferences even if it's
already there. This patch fixes that by adding 'IGNORE' to the query,
making it idempotent.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123090|0   |1
is obsolete||

--- Comment #179 from Martin Renvoize  ---
Created attachment 123517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123517&action=edit
Bug 11175: (follow-up) Add tests

Signed-off-by: Nick Clemens 
Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123089|0   |1
is obsolete||

--- Comment #178 from Martin Renvoize  ---
Created attachment 123516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123516&action=edit
Bug 11175: Remove outdated info about Elasticsearch not being suppported

Support for Elasticsearch was added in commit "Bug 11175: Add
Elasticsearch support".

Signed-off-by: Joonas Kylmälä 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123088|0   |1
is obsolete||

--- Comment #177 from Martin Renvoize  ---
Created attachment 123515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123515&action=edit
Bug 11175: Search using double quotes to support Elasticsearch

With Elasticsearch if you would use the search string here without the
change to double quotes, i.e.

(rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234'

then the search would somehow manage to return a record with 001 =
1234 and 003 = FI-XXX. Using double quotes prevents that. Also using
parenthesis around the latter part of the OR seems to work:

(rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234')

Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123087|0   |1
is obsolete||

--- Comment #176 from Martin Renvoize  ---
Created attachment 123514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123514&action=edit
Bug 11175: Limit the amount of component parts returned

There was already before this a limit of 100 results when using
Elasticsearch but then the list of component parts was truncated
silently. This change now limits the amount to hard coded limit of 300
which is still fast to render. Also when the 300 component part record
limit is reached there is a link in the list now to list all the
records via the cataloging search.

To test:
   1) Create 300+ component part records and see if the link to list
  all the component part records shows up
   2) Make sure prove t/Koha/Util/Search.t passes

Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123086|0   |1
is obsolete||

--- Comment #175 from Martin Renvoize  ---
Created attachment 123513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123513&action=edit
Bug 11175: Keep component part record list items inside the box

Without this the number denoting the component part item in the list
will overflow and is partly hidden.

To test:
 1) Create 100 component parts
 2) Notice without this patch the number next to the component part is
not fully shown

Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123085|0   |1
is obsolete||

--- Comment #174 from Martin Renvoize  ---
Created attachment 123512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123512&action=edit
Bug 11175: Add Elasticsearch support

Signed-off-by: Nick Clemens 
Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17335] waitingreserves.pl cancel button needs simplification

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17335

--- Comment #1 from Owen Leonard  ---
The check-in page shows a dialog telling the user that a transfer is required
when checking in an item from another library. I think adding the same thing to
this page would eliminate the need for a "Cancel and return to..." button
label.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123084|0   |1
is obsolete||

--- Comment #173 from Martin Renvoize  ---
Created attachment 123511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123511&action=edit
Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref
description

The syspref is not only affecting staff interface so moving it to
Cataloguing section. Added also notes about UNIMARC and Elasticsearch
not being supported.

Signed-off-by: Nick Clemens 
Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123083|0   |1
is obsolete||

--- Comment #172 from Martin Renvoize  ---
Created attachment 123510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123510&action=edit
Bug 11175: (follow-up) Return empty array if no components

Signed-off-by: Nick Clemens 
Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123082|0   |1
is obsolete||

--- Comment #171 from Martin Renvoize  ---
Created attachment 123509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123509&action=edit
Bug 11175: (follow-up) Don't return explicitly undef

This would create in list context an list of one element that is
undef, which we don't want, we want empty list if there are no
components.

Signed-off-by: Nick Clemens 
Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123081|0   |1
is obsolete||

--- Comment #170 from Martin Renvoize  ---
Created attachment 123508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123508&action=edit
Bug 11175: Show record component parts in the detail view

Shows the component records of a host, on the hosts detail view in
staff client or OPAC, with clickable links to the component records.

The host does not require linking entries to the components, but
components do require a link to the host record via 773$w.

Adds a new search index, Control-number-identifier (aka cni), which
indexes the 003 controlfield.

Adds 'Yet Another System Preference', ShowComponentRecords, which can
be used to turn this feature on or off in staff client and/or OPAC,
and defaults to off.

When looking up the component part records, the code searches for
records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001'
or, if the 003 is not defined in the Host, 773$w=Host001.

Does not use easyanalytics or useControlNumber.

Only for MARC21 biblios - UNIMARC has not been updated.

staff-global.css and opac.css have not been recreated, so you need
to use sass to recreate those from staff-global.scss and opac.scss

Test plan:

0) Apply patch
1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML
   (This file is an attachment on the bug)
2) rebuild the zebra biblio index
3) Search for "easy piano" in staff client, and go to
   the biblio detail page. You should not see anything different
   in the record detail page.
4) Do the same on OPAC.
5) Change the ShowComponentRecords syspref appropriately and check
   the record detail page in staff client and OPAC.
   You should see a list of component part records.

Rebased-by: Joonas Kylmälä 
Signed-off-by: Nick Clemens 
Signed-off-by: Pasi Kallinen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25925] In the alert box for unfilled important field in cataloging, the cancel button is not translatable

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25925

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Caroline Cyr La Rose  ---
I confirm this is a browser pop-up, since it looks different in Firefox and
Chromium... 
Sorry about that!
Caroline

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28817] New: It should be possible to configure the reply_address for various notices

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28817

Bug ID: 28817
   Summary: It should be possible to configure the reply_address
for various notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently except for messages originating from the patron we do not set a
reply_address when enqueuing letters,

git grep reply_address

If no reply address is specified when we are sending the messages we use the
patron's library's address:
1325 sub _send_message_by_email {
...
1363 if ($patron) {
1364 $library   = $patron->library;
1365 $branch_email  = $library->from_email_address;
1366 $branch_replyto= $library->branchreplyto;
1367 $branch_returnpath = $library->branchreturnpath;
1368 }
...
1393 reply_to => $message->{'reply_address'} || $branch_replyto,


This means that when an overdue is sent by the issuing library, replies go to
the patron's branch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19685] Canceling a hold from the Hold Found popup does not alert librarian about next hold

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685

Owen Leonard  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Owen Leonard  ---
*** Bug 24557 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24557] Cancel Hold on check in

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24557

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 19685 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23479] Hold cancellation confirmation too generic

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23479

--- Comment #1 from Owen Leonard  ---
*** Bug 23815 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23815] Cancel hold confirmation should display specific information

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23815

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 23479 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26532] Error when cancelling a hold from check-in page

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26532

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---
This appears to have been either a temporary glitch or has been fixed. I can't
reproduce the problem now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28779] Calling request.pl with non-existent biblionumber gives internal server error

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28779

Owen Leonard  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #12 from Owen Leonard  ---
*** Bug 24500 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24500] Cancelling a hold at the same time produces internal server error

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24500

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 28779 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of article requests per day per patron category

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Agustín Moyano  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

Agustín Moyano  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

--- Comment #37 from Agustín Moyano  ---
Created attachment 123507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123507&action=edit
Bug 27946: (follow-up) Use bug 28656

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

--- Comment #36 from Agustín Moyano  ---
Created attachment 123506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123506&action=edit
Bug 27946: [DO NOT PUSH] Update DBIx schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

--- Comment #35 from Agustín Moyano  ---
Created attachment 123505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123505&action=edit
Bug 27946: Add article request fee feature

This patch adds the ability to charge a fee for article scan requests.

To test:
1. apply patches
2. updatedatabase
3. restart_all
4. enable ArticleRequest in preferences
5. grab a patron category and set a fee for article requests
6. grab a patron of that category (patron a) and another fron different
category (patron b)
7. place an article request for both patrons
SUCCESS => only for patron a, a warning is displayed saying a fee will be
charged
8. check the account for both patrons
SUCCESS => only for patron a there is a debit of type ARTICLE_REQUEST
9. cancel the article request for patron a
SUCCESS => the debit for patron a gets canceled
10. repeat step 7 only for patron a
11. change article request fee for the patron a's category
12. repeat step 10
13. check account for patron a
SUCCESS => there are 2 debits with different amount of typ ARTICLE_REQUEST
14. cancel only one article request
SUCCESS => only the corresponding debit gets canceled
15. prove t/db_dependent/ArticleRequests.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

--- Comment #34 from Agustín Moyano  ---
Created attachment 123504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123504&action=edit
Bug 27946: Add article_request_fee to categories table and ARTICLE_REQUEST
account debit type

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #122529|0   |1
is obsolete||
 Attachment #122530|0   |1
is obsolete||
 Attachment #122531|0   |1
is obsolete||
 Attachment #122532|0   |1
is obsolete||
 Attachment #122552|0   |1
is obsolete||

--- Comment #33 from Agustín Moyano  ---
Created attachment 123503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123503&action=edit
Bug 27946: Add tests

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

Agustín Moyano  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] New: Improve the display of multiple holds during hold process

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

Bug ID: 28816
   Summary: Improve the display of multiple holds during hold
process
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I think the display of holds during the multi-hold process is confusing and
hard to read. I'd like to suggest a revised version.

Here's what it looks like now with HoldsSplitQueue set to "nothing":
https://snipboard.io/eEXLaR.jpg

Here is the what I'm working on:
https://snipboard.io/YtbNMs.jpg

Here's the current version with HoldsSplitQueue set to "pickup library and item
type":
https://snipboard.io/vpQjDF.jpg

Here is the new version:
https://snipboard.io/BvRCwJ.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729

Chris Slone  changed:

   What|Removed |Added

 CC||cslone@camdencountylibrary.
   ||org

--- Comment #11 from Chris Slone  ---
We've just run into some issues with the expiration date not reverting when an
awaiting copy was checked out to a different patron... Definitely would be
better if the expiration date was cleared/reset than for it to hang on to the
expiration date set when the first item was confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28815] New: Item Circulation Alert settings for checkouts also cover renewals

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28815

Bug ID: 28815
   Summary: Item Circulation Alert settings for checkouts also
cover renewals
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In item circulation alerts (cgi-bin/koha/admin/item_circulation_alerts.pl),
disabling checkout alerts also disables renewal alerts.

Best case scenario, we'd create a mechanism to differentiate the two notice
types.

At the least, we should add some text here making it clear that renewals are
also covered by checkouts.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28814] Messaging preference for renewals

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28814

--- Comment #1 from Andrew Fuerste-Henry  ---
Sorry, I need to walk back a bit of my snark here -- I forgot that we have
updated that messaging preference so that it says "Checkout and renewal" in the
preference. So at least we're telling people there what it means. But I'd still
prefer a separate preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28814] New: Messaging preference for renewals

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28814

Bug ID: 28814
   Summary: Messaging preference for renewals
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

In bug 18532 we add a messaging preference for the auto_renew notice. It would
be good to do the same for the regular renewal notice. Right now, patrons get a
renewal notice if the RenewalSendNotice syspref is on and the patron is signed
up for CHECKOUT notices, with RENEWAL just following the CHECKOUT preference. 

That assumption -- that if one wants a CHECKOUT notice one must also want a
RENEWAL notice -- is both spurious and largely undocumented.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #38 from Jonathan Druart  ---
+return $expire_reserves_charge_rule ?
$expire_reserves_charge_rule->rule_value :
C4::Context->preference("ExpireReservesMaxPickUpDelayCharge");

Is this correct if the rule is "0"?

Note that it won't pass QA because of missing tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #37 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #28)
> (In reply to David Nind from comment #24)
> > 1. Should the call number be repeated if it is the same? That is, should
> > only distinct call numbers be displayed for items available by library
> > branch or not available categories?
> 
> This is far from trivially adding a distinct keyword. We are relying here on
> the output of the xslt key function. Making this change would require a bit
> more than we are doing here now to control the number displayed.

Looking back, I must have misinterpreted this comment. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #36 from Marcel de Rooy  ---
David, would you mind to test this change again?
Hopefully, Nick could pick it up after that :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #35 from Marcel de Rooy  ---
 .../en/xslt/MARC21slim2OPACResults.xsl| 383 +++---
 1 file changed, 144 insertions(+), 239 deletions(-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #34 from Marcel de Rooy  ---
Created attachment 123502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123502&action=edit
Bug 26302: Refactor Availability block in OPAC results xslt

Decided finally to do a larger refactor here. Hopefully we improved
consistency and removed some redundancy. And the two new prefs provide
additional functionality.

Most significant changes:
[1] Clearer distinction of the Availability line in three parts:
Available, Reference and Unavailable.
For Unavailable we loop thru branches now too.
[2] Calling template to list item data (including location or ccode).
Made the separate Location line obsolete.
[3] The tests around OPACItemLibrary are removed since we now look at
resultbranch from XSLT.pm.
[4] Removed code replication for various 'other' statuses like Checked out.
[5] Obsoleted three xslt key indexes, singleBranchMode.
[6] Apply the two prefs to control number of listed items.

Test plan:
You may play with: OPACResultsLibrary (home/holding), OPACItemLocation
(library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers),
Reference_NFL_Statuses (list of notforloan codes in reference part).

[1] Create a biblio with various items on a few branches. Fill call number,
location and ccode too. Set home branch and holdingbranch differently.
[2] Toggle the preferences, and verify display within OAPC search results.

Example with prefs (home, callnumber, 2, 2):
Availability: Items available for loan: Centerville (2)Call number: perl A 4,
PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call
number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL
A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff
Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call
number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1.

Same data with prefs (holding, callnumber, 2, 2):
Availability: Items available for loan: Centerville (1)Call number: PERL D 1.
Liberty (1)Call number: perl A 4. Items available for reference: Centerville:
Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out
(1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A
2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call
number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff
Collection (1)Call number: PERL E 1.

Same data with prefs (holding, library, n/a, n/a):
Availability: Items available for loan: Centerville (1). Liberty (1). Items
available for reference: Centerville: Not For Loan (1). Not available:
Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville:
Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff
Collection (1).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #33 from Marcel de Rooy  ---
Created attachment 123501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123501&action=edit
Bug 26302: Changes for substatus, resultbranch in XSLT.t

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

--- Comment #32 from Marcel de Rooy  ---
Created attachment 123500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123500&action=edit
Bug 26302: Add resultbranch and other status in C4/XSLT

Groundwork for changes in the OPAC results xslt.

NOTE: Adds both new prefs too.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #122462|0   |1
is obsolete||
 Attachment #122463|0   |1
is obsolete||
 Attachment #122464|0   |1
is obsolete||
 Attachment #122465|0   |1
is obsolete||
 Attachment #122466|0   |1
is obsolete||
 Attachment #122487|0   |1
is obsolete||

--- Comment #31 from Marcel de Rooy  ---
Created attachment 123499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123499&action=edit
Bug 26302: Add dbrev for two new prefs

Adding two prefs:
resultsMaxItems
resultsMaxItemsUnavailable

Test plan:
Check Preferences/OPAC/Appearance.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #37 from Peter Vashchuk  ---
Created attachment 123498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123498&action=edit
Bug 25711: move get_effective_expire_charge to Koha::CirculationRules

Move get_effective_expire_reserves_charge as a new method
in Koha::CirculationRules to retrieve the effective value of the rule.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

Peter Vashchuk  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #193 from Martin Renvoize  ---
Fixes made in followup, test suit re-run against everything and all passing.

I think it was a good move adding the Koha:: classes, it makes the code cleaner
and shows the path for future work.

Setting back to PQA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #192 from Martin Renvoize  ---
Created attachment 123497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123497&action=edit
Bug 22690: (QA follow-up) Fix indexing for Items sets

This patch adds tests and handling for calling move_to_biblio on a
Koha::Items set that contains items from more than one source biblio.

Test plan
1/ Inspect the changes to t/db_dependent/Koha/SearchEngine/Indexer.t
2/ Run t/db_dependent/Koha/SearchEngine/Indexer.t and confirm it passes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123062|0   |1
is obsolete||

--- Comment #191 from Martin Renvoize  ---
Created attachment 123496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123496&action=edit
Bug 22690: (QA follow-up) Correct variable name

The $from_biblio variable name doesn't exists after a refactoring that
happened. Here we need to re-index both the $self biblio and $to_biblio
biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123044|0   |1
is obsolete||

--- Comment #190 from Martin Renvoize  ---
Created attachment 123495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123495&action=edit
Bug 22690: (QA follow-up) Add TrackedLink classes and use them

This patch adds Koha::TrackedLink(s) classes based on Koha::Object(s)
and then adds the relationship accessor to Koha::Item and uses it within
the move_to_biblio method.

Tests for new relationship also added to t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123042|0   |1
is obsolete||

--- Comment #189 from Martin Renvoize  ---
Created attachment 123494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123494&action=edit
Bug 22690: (QA follow-up) Use relationship accessor

With the addition of foreign key relationships to the linktracker table
we now get a DBIC relationship accessor we can use. This clarifies the
code slightly by using the _result->relationship form to get the DBIC
resultset.  We should still introduce a Koha::Object based class for
this table at some point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123041|0   |1
is obsolete||

--- Comment #188 from Martin Renvoize  ---
Created attachment 123493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123493&action=edit
Bug 22690: DBIC Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123040|0   |1
is obsolete||

--- Comment #187 from Martin Renvoize  ---
Created attachment 123492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123492&action=edit
Bug 22690: (QA follow-up) Add relationships to linktracker

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

2021-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #123039|0   |1
is obsolete||

--- Comment #186 from Martin Renvoize  ---
Created attachment 123491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123491&action=edit
Bug 22690: (QA follow-up) Clarify uses of DBIC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >