[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #7 from David Cook --- I spent a lot of time thinking this morning, and I'm not sure I see a purpose for filtering outbound data besides for the public API. And on the flipside the API has its own input validation so it wouldn't need an inbound data filter whereas the HTML UI does. I just wonder if we're trying to make this all too generic/comprehensive. The original premise was just filtering input from HTML forms. Maybe it makes more sense to do a RFC? I think this might be the 3rd or 4th report now for allow lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999
--- Comment #6 from Marcel de Rooy ---
The code for AllowList is generic now. But we need the ColumnSet to apply it to
Koha objects in various ways.
This is the idea:
Say $city is a Koha object.
$city->filter('opac_ui') returns city data through the opac_ui filter which is
just a set of columns for some purpose.
$city->filter('staff') could return some other subset or even nothing when the
set does not exist.
The sub filter calls Koha::Object::ColumnSet with the requested column set
name. The module calls the corresponding DBIx schema where we add a sub called
column_set_info containing the lists we need like a list for opac_ui.
ColumnSet runs a Koha::AllowList based on that list over the object data.
Hang on a little bit. Submitting some concept code shortly.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Marcel de Rooy changed: What|Removed |Added Summary|Add module for Allowlist / |Add Koha::AllowList, |ColumnFilter|DenyList and ||Koha::Object::ColumnSet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #5 from Marcel de Rooy --- Created attachment 124824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124824&action=edit Bug 28999: Add Koha::DenyList as counterpart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #4 from Marcel de Rooy --- Created attachment 124823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124823&action=edit Bug 28999: Remove (un)load, add reset; apply returns result now Remove load but add $defaults in new. Replace unload by reset, restoring defaults. Replace warn en verbose by a dump variable in apply. Do not return $blocked anymore but return the filtered input in apply. New check method returns true when no entries were blocked. New keys method to list current allow list entries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #3 from Marcel de Rooy --- Created attachment 124822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124822&action=edit Bug 28999: Additional check method, some parameter changes License for module. Remove interface parameter in new. Add dry_run parameter to apply. Add arrayref as input for apply. Add check as shortcut for apply with dry_run. Add tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #2 from Marcel de Rooy --- Created attachment 124821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124821&action=edit Bug 28999: Rename to AllowList -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #1 from Marcel de Rooy --- Created attachment 124820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124820&action=edit Bug 28999: Introduce Allowlist Based on work of David Cook and Jonathan Druart. Removed the patron example here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29000] Create a display of patrons with permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries REST endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 --- Comment #13 from Marcel de Rooy --- (In reply to David Cook from comment #12) > I think that we've overloaded the allow list concept. I originally came up > with the allow list concept to function as a user input validation > allow/valid list rather than an attribute-based access control list. I am submitting shortly a generic AllowList and a Koha::Object::ColumnSet proposal on bug 28999. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #19 from David Cook --- For a while, I've been fantasizing about an RBAC or ABAC permission system, but I think modernizing Koha's AuthZ might be an insurmountable task. I like the idea of groups too. Administrators, Cataloguers, and Circulation as three out-of-the-box groups with default permissions set. Rather than setting permissions for individual users, the average library might just assign users to groups and manage permissions at the group level. I think someone needs to do something (although it's not going to be me). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries REST endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 --- Comment #12 from David Cook --- (In reply to Martin Renvoize from comment #10) > I think we need more work here to provide > for 'read' and 'write' allowlists.. we also need a way to alter the > allowlist from the Koha object when required as with the load time at > to_api here we currently have no way to pass overrides to the allowlist. I think that we've overloaded the allow list concept. I originally came up with the allow list concept to function as a user input validation allow/valid list rather than an attribute-based access control list. I like attribute-based access control, but it might make more sense to start there and then do the input validation rather than going the other way around. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28999] Add module for Allowlist / ColumnFilter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27432] Add report run to action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #24 from David Cook --- I would love to see this get through. What do we need to do to push this along? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29000] Create a display of patrons with permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 --- Comment #3 from David Cook --- I have it in the Tools module with the label "User Audit", but I suppose it should be in the "Patrons" module? Maybe next to "Patron lists" we could have a "Permission audit" or "Permission review" button? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29000] Create a display of patrons with permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- I actually wrote a simple PHP script to do this about 10 years ago, as a library needed to be able to easily audit user permissions, and I've been meaning to convert it into Perl... but it looks like you've saved me the hassle! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28990] Allow changes for a configurable subset of systempreferences by superlibrarian only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 --- Comment #9 from David Cook --- My above idea would actually flow into another idea I've had for "hardening" Koha instances. Many of Koha's defaults are quite open and flexible, which makes it easy for anyone to use Koha. But I suspect many vendors would like to apply certain rules that make the Koha instance more secure. Originally, I was thinking about installation "profiles", which could be invoked by koha-create, but maybe a post-installation script would be easier/more flexible. While I haven't used it myself, I've been thinking about the "jboss-cli" tool that comes with the Java server JBOSS AS/Wildfly. I encountered it most recently with Keycloak: https://www.keycloak.org/docs/latest/server_installation/#_start_cli It lets you set configuration with a script. I like the idea of a "secure_koha.cli" or "vendor_profile.cli" script that you could run. A sysadmin could lock down certain system preferences, set certain values for authentication servers, email addresses, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28990] Allow changes for a configurable subset of systempreferences by superlibrarian only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #8 from David Cook --- (In reply to Fridolin Somers from comment #7) > To add water in the mill : > > I'd say if a preference is really system-related we should move it to > koha-conf.xml. > For example 'casServerUrl', it sounds system-related like LDAP > authentication that is in koha-conf.xml. > Idem for OPACBaseURL. That's interesting. On one hand, Donna makes the point that a library might not always have a sysadmin available to make those changes via the CLI, so having them editable by web UI is ideal. (From a deployment point of view, it might be nicer at times to just make a data change via normal user activity in the UI rather than needing to do a full deployment.) On the other hand, as a vendor, there are times where I want to prevent all library staff users (including superlibrarians) from making certain changes, as they can break the system, make the system insecure, etc. -- What if we could add functionality for a sysadmin to lock system preferences with all sysprefs defaulted to unlocked? We could add a "locked" or "readonly" column to the systempreferences table. We could then have a little CLI script for locking/unlocking system preferences, setting system preference values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28989] Allow viewing systempreferences only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28989 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #53 from Jonathan Druart --- Hi Katrin, thanks! You found a bug in a very specific combination. AdLibris is loaded first but there is no image there (is the service broken currently?). The code copied from staff is broken. As we have much more cover services OPAC side the bugs are easier to catch. I think this last patch is improving the situation but I cannot guarantee it will always work. To be honest I've always tested with local cover images (as it's why this enhancement has been sponsored), and it was always working when a cover image is attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #52 from Jonathan Druart --- Created attachment 124819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124819&action=edit Bug 28180: Fix bug with AdLibris If Adlibris is first and there is no image -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #51 from Katrin Fischer --- Hm, I later realized that this was not meant to change results, but only the detail page. Previous comments apply to the results list. On the detail page for me none of the 3 mentioned cover services covers show :( Example: search for "perl" > Programming Perl - 2 covers and the adlibris link on results - no cover at all on detail page Switch back to master, git stash, restart_all: - Adlibris still broken on results - covers show on results and detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28988] Reindent calendar template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 David Nind changed: What|Removed |Added Attachment #124721|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 124818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124818&action=edit Bug 29899: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=28988 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28988] Reindent calendar template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 David Nind changed: What|Removed |Added Attachment #124720|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 124817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124817&action=edit Bug 28988: Reindent calendar template This patch performs general template cleanup to the calendar template: Make indentation consistent and trim trailing whitespace. To test, apply the patch and go to Tools -> Calendar. The page should look correct and work correctly. If you view the diff while ignoring whitespace the only changes should be where line breaks were introduced. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28988] Reindent calendar template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29001] New: Subfields attributes are not preserved when order is changed in framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001 Bug ID: 29001 Summary: Subfields attributes are not preserved when order is changed in framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: mathsaby...@gmail.com QA Contact: testo...@bugs.koha-community.org Bug 8976 adds the ability to change the default order of the subfields in MARC framework. But it does not preserve the Repeatable or Mandatory attribute. To test : in a MARC framework, define a subfield as Mandatory. Move the subfield to an other position within the field. The Mandatory flag for that subfield is not preserved. Instead, the subfield occupying the same position is flaged as Mandatory. M. Saby -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 --- Comment #50 from Katrin Fischer --- Patches still apply, but something has been broken since my last test run. What I did so far: - Made sure master was current - restart_all, ran database updates - Applied patches, no conflicts - restart_all again - yarn build --view opac 1) Turned on Adlibris covers. Instead of the covers, only a link shows in the result list and detail pages. 2) Additionally activated Google covers. The covers show, but not within the lightbox display. 3) Added Amazon covers Now I see up to 2 covers, but next to each other, still no lightbox. Did a patch get lost here? :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 Joonas Kylmälä changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 Joonas Kylmälä changed: What|Removed |Added Severity|enhancement |trivial QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 --- Comment #4 from Joonas Kylmälä --- Created attachment 124816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124816&action=edit Bug 28653: (QA follow-up) Remove debug message used during development Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653
Joonas Kylmälä changed:
What|Removed |Added
Attachment #123706|0 |1
is obsolete||
--- Comment #3 from Joonas Kylmälä ---
Created attachment 124815
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124815&action=edit
Bug 28653: Add new method RefreshIssuesTable
On patrons check out or details page, after renewing
loans they don't sort correctly when clicking on "Date due"
tab. Page has to be reloaded so that sorting works.
This patch adds new method RefreshIssuesTable to
checkouts.js. When loans are renewed or checked in, issues
table is reloaded to and due dates are sorted correctly.
To test:
1. Add 3 loans for patron.
2. Change due dates so you they are e.g. 07/01, 07/02, 07/04
3. Make sure you have renewal period set e.g. 5 days and
check your RenewalPeriodBase syspref (I use current date there)
4. Renew loan with date due on 07/01, it should now be 07/07
5. Sort loans by date due
=> Note that order from top to bottom is 07/04->07/02->07/07
or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would
assume.
6. Apply patch and repeat.
=> Note that issues table is reloaded ("Loading..." pop-up is displayed)
and that due dates are in correct order.
Sponsored-by: Koha-Suomi Oy
Signed-off-by: kelly
Signed-off-by: Joonas Kylmälä
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work after renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28831] OPAC XSLT Results: Allow unavailable item grouping on status only for large consortia
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831 --- Comment #14 from Marcel de Rooy --- (In reply to David Nind from comment #13) > Signed-off-by: David Nind Thanks David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #24 from Marcel de Rooy --- (In reply to Joonas Kylmälä from comment #18) > This patch does not alter the message we are giving out, we already say > before this patch explicitly in the OPAC GUI whether a list is Public or > not. So I wouldn't take that into consideration whether to accept this patch > or not. If we want to use another naming it can be done even after this > patch, this patch doesn't make it any harder as far as I can tell. So, we implicitly already have three categories. And some requests show that people are still shaking the tree. Might extending categories solve that? Not sure. But we choose to put that aside here and make it a boolean. I have no strong arguments against it but just have the intuitive feeling that this may not be the right direction :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 --- Comment #8 from Joonas Kylmälä --- Passing QA. Note: Administration->Cities and towns search was already broken before this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356
Joonas Kylmälä changed:
What|Removed |Added
Attachment #122346|0 |1
is obsolete||
--- Comment #7 from Joonas Kylmälä ---
Created attachment 124814
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124814&action=edit
Bug 28356: Consolidate catalogue search box code
To test:
1 - Apply patch
2 - Confirm searchign the catalog works from:
Administration->Budgets
Cataloging
Circulation->Check in
Administration->Cities and towns
Acquisitions->{Vendor}->Contracts
Administration->Currencies
Administration->Circulation desks (requires UseCirculationDesks
preference)
Home
Tools->Notices and slips
Patrons
Adminstration
Serials
Acquisitions->Suggestions
Administration->Z39.50/SRU servers
Signed-off-by: hakam
Signed-off-by: Joonas Kylmälä
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Specified due date incorrectly retained when using fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Specified due date incorrectly retained when using fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Joonas Kylmälä changed: What|Removed |Added Attachment #124653|0 |1 is obsolete|| --- Comment #8 from Joonas Kylmälä --- Created attachment 124813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124813&action=edit Bug 21093: In additem.pl set the right stickyduedate for fast add To test: -1 Set the specify due date option to a date, don't check the checkbox -2 Enter an unknown barcode -3 Click on fast add -4 Add a record -5 Add an item (don't change the barcode!) -6 The item is checked out to the patron -7 Verify: The checkbox is "Remember for session" is checked now -8 APPLY patch -9 Do steps 1-6 again, this time "Remember for session" should be unchecked -10 Do steps 1-6 again but this time do check the "Remember for session" checkbox. -11 It should be properly checked Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Specified due date incorrectly retained when using fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992 Joonas Kylmälä changed: What|Removed |Added Attachment #124726|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä --- Created attachment 124812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124812&action=edit Bug 28992: Resolve warning on BIG_LOOP Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ addbiblio.tt line 896. Came across it when testing 28608. Could have been a QA follow-up. Test plan: If you run QA tools on this patch, you should see the warning only when processing files before patches. Signed-off-by: Marcel de Rooy Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #21 from Joonas Kylmälä ---
Sorry for not doing very good job the first time reviewing, I found now
additional issue:
The buildQuery function in C4/Search.pm is modified by "Bug 28847: Move
SearchLimitLibrary code to QueryBuilder Modules", it however leaves dead code
in the else section "if ($this_limit =~ /^branch:(.+)/) {". That should be
completely removed, and also we can see from that that the new regex condition
added doesn't match as carefully the limit parameter.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #23 from Joonas Kylmälä --- Created attachment 124811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124811&action=edit Bug 28959: (follow-up) Adjust more places in which 'category' was used Some links still had category. I propose we use explicit public=1 and public=0 when links to public/private are side by side. Otherwise whe just use /cgi-bin/koha/opac-shelves.pl?op=list using default value 0. Signed-off-by: David Nind JK: Adjust commit title Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #22 from Joonas Kylmälä --- Created attachment 124810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124810&action=edit Bug 28959: (follow-up) Adjust all places in which 'category' was used Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #21 from Joonas Kylmälä --- Created attachment 124809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124809&action=edit Bug 28959: Add virtualshelves.public as a boolean This patchset moves the 'category' attribute for virtual shelves, that takes values of 1 and 2 (private and public respectively) into a boolean for public. The DBRev is trivial, and the changes to the code are as well. To test: 1. have some known public and private lists 2. Apply this patches 3. Run: $ updatedatabase => SUCCESS: Public lists have public=1, private have public=0 4. Run: $ kshell k$ prove t/db_dependent/Utils/Datatables_Virtualshelves.t \ t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 5. Try the feature in staff and OPAC => SUCCESS: All good 6. Sign off :-D Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #20 from Joonas Kylmälä --- Created attachment 124808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124808&action=edit Bug 28959: DBIC update Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Joonas Kylmälä changed: What|Removed |Added Attachment #124799|0 |1 is obsolete|| Attachment #124800|0 |1 is obsolete|| Attachment #124801|0 |1 is obsolete|| Attachment #124802|0 |1 is obsolete|| Attachment #124803|0 |1 is obsolete|| --- Comment #19 from Joonas Kylmälä --- Created attachment 124807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124807&action=edit Bug 28959: Move category => public Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi --- Comment #18 from Joonas Kylmälä --- (In reply to Marcel de Rooy from comment #12) > (In reply to Tomás Cohen Arazi from comment #0) > > Somehow it got more complicated than required. > > This report oversimplifies things? > Private lists include shared lists too. > Saying public Y/N implicitly may include the wrong message. This patch does not alter the message we are giving out, we already say before this patch explicitly in the OPAC GUI whether a list is Public or not. So I wouldn't take that into consideration whether to accept this patch or not. If we want to use another naming it can be done even after this patch, this patch doesn't make it any harder as far as I can tell. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wording in authentication forms is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #9 from David Nind --- (In reply to Fridolin Somers from comment #8) > Is it at least OK to change submit button "Login" to "Log in" ? It is for the submit button (log in where it as an action (verb), for example: Log in with your user id; login when you are referring to the details they use (noun or adjective), for example: Your login details are and , Enter your credentials in the login page. https://wiki.koha-community.org/wiki/Terminology#L -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
