[Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29025] Saved auth login and password are pre-filled in patron creation form

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #11 from David Cook  ---
This should be wrapped in a system preference, so that you can enable the
cronjob for a server, but only implement it for selective Koha instances on
that server.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #34 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #33)
> After reading the comments again, it seems that:
> - Keep wantarray, fix places: ashimema, tcohen
> - Get rid of wantarray: Joubu
> 
> what do you think, Marcel?

I am close to revisiting this bug. On my list ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Attachment #124208|0   |1
is obsolete||

--- Comment #7 from Henry Bolshaw  ---
Comment on attachment 124208
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124208
Bug 28188: Accessibility: OPAC contrast ratio for text is insufficient

I'm breaking this down into smaller patches on other bugs so I've marked this
obsolete. Thank you for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Depends on||29038


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038
[Bug 29038] Accessibility: OPACUserSummary heading doesn't have sufficient
contrast
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29038] Accessibility: OPACUserSummary heading doesn't have sufficient contrast

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Henry Bolshaw  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||28188
   Assignee|oleon...@myacpl.org |bolsh...@parliament.uk
   Keywords||accessibility
 CC||bolsh...@parliament.uk


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29038] New: Accessibility: OPACUserSummary heading doesn't have sufficient contrast

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29038

Bug ID: 29038
   Summary: Accessibility: OPACUserSummary heading doesn't have
sufficient contrast
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The "heading" of the OPACUserSummary table has bad contrast (grey script on
grey background). This makes the text difficult to read and fails to meet
accessibility criteria.

The Summary table is only visible if you are logged in, have some checkouts and
OPACUserSummary is active.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1..."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Depends on||29037


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037
[Bug 29037] Accessibility: OPAC breadcrumb links don't have sufficient contrast
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29037] Accessibility: OPAC breadcrumb links don't have sufficient contrast

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Henry Bolshaw  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |bolsh...@parliament.uk
 CC||bolsh...@parliament.uk
   Keywords||accessibility
 Status|NEW |ASSIGNED
 Blocks||28188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29037] New: Accessibility: OPAC breadcrumb links don't have sufficient contrast

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037

Bug ID: 29037
   Summary: Accessibility: OPAC breadcrumb links don't have
sufficient contrast
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The OPAC breadcrumb links are on a grey background and don't have sufficient
contrast. This makes the text difficult to read and fails to meet accessibility
criteria.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Depends on||29036


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036
[Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

Henry Bolshaw  changed:

   What|Removed |Added

 Blocks||28188
 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |bolsh...@parliament.uk
   Keywords||accessibility

--- Comment #1 from Henry Bolshaw  ---
The Koha green we are using for the buttons isn't accessible with white text so
we could change it to a green that is. Alternatively we could change the text
to black (which keeps the Koha green) or choose a completely different button
colour.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29036] New: Accessibility: OPAC buttons don't have sufficient contrast

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036

Bug ID: 29036
   Summary: Accessibility: OPAC buttons don't have sufficient
contrast
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The contrast ratio for the OPAC buttons fails to meet accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Henry Bolshaw  changed:

   What|Removed |Added

 Blocks||28188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Depends on||29035


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035
[Bug 29035] Accessibility: OPAC masthead_search label doesn't have sufficient
contrast ratio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29035] Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Henry Bolshaw  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|oleon...@myacpl.org |bolsh...@parliament.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29035] New: Accessibility: OPAC masthead_search label doesn't have sufficient contrast ratio

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29035

Bug ID: 29035
   Summary: Accessibility: OPAC masthead_search label doesn't have
sufficient contrast ratio
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The contrast ratio for the OPAC mast_head search label fails to meet
accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have sufficient contrast ratio

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Henry Bolshaw  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |bolsh...@parliament.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188

Henry Bolshaw  changed:

   What|Removed |Added

 Depends on||29034


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034
[Bug 29034] Accessibility: OPAC nav-links don't have sufficient contrast ratio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29034] Accessibility: OPAC nav-links don't have sufficient contrast ratio

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Henry Bolshaw  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Keywords||accessibility
 Blocks||28188


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188
[Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient
[OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29034] New: Accessibility: OPAC nav-links don't have sufficient contrast ratio

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29034

Bug ID: 29034
   Summary: Accessibility: OPAC nav-links don't have sufficient
contrast ratio
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: bolsh...@parliament.uk
QA Contact: testo...@bugs.koha-community.org

The contrast ratio for the OPAC navigation links (Cart, Lists, Login, Search
history, Delete your search history)fails to meet accessibility guidelines.

WCAG 2.1 1.4.3 Contrast (Minimum) Level AA:

"The visual presentation of text and images of text has a contrast ratio of at
least 4.5:1, except for the following: 

- Large Text: Large-scale text and images of large-scale text have a contrast
ratio of at least 3:1;

- Incidental: Text or images of text that are part of an inactive user
interface component, that are pure decoration, that are not visible to anyone,
or that are part of a picture that contains significant other visual content,
have no contrast requirement.

- Logotypes: Text that is part of a logo or brand name has no contrast
requirement."

(https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum)

There are several free websites for checking the contrast ratio, e.g.
https://webaim.org/resources/contrastchecker/ 

You can also use the built-in accessibility functions in Firefox and Chrome, as
well as specialist accessibility browser extensions like WAVE
(https://wave.webaim.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #163 from David Cook  ---
(In reply to David Cook from comment #161)
> I don't think this patch takes into account
> C4::Reserves::CancelExpiredReserves which gets called by the cronjob
> /usr/share/koha/bin/cronjobs/holds/cancel_expired_holds.pl

Actually, that's irrelevant. I was mixing up "ReservesMaxPickUpDelay" and
"ExpireReservesMaxPickUpDelay". The description of
"ExpireReservesMaxPickUpDelay" is actually a bit misleading and isn't relevant
after all (since a user could nominate their own expiry regardless of
ReservesMaxPickUpDelay).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #162 from David Cook  ---
Actually, I don't think we really need the changes to opac-reserve.pl and
opac-reserve.tt. Those changes just add complexity. While they give patrons a
little bit more information about when the hold expires, I don't know that we
need to give that information at that point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

--- Comment #57 from Phil Ringnalda  ---
Fails for me in koha-testing-docker startup, with

koha_1   | C4::Installer::load_sql returned the following errors while
attempting to load
/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql:
koha_1   | DBD::mysql::st execute failed: Data too long for column 'type'
at row 588 at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1.
koha_1   | Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql ([SQL ERROR]:
INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`,
`type` ) VALUES

Looks like at 22 characters, modification-templates doesn't quite fit in a 20
character column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29033] New: Add C4::Context->multivalue_preference

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033

Bug ID: 29033
   Summary: Add C4::Context->multivalue_preference
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I've seen many places in which a syspref is read, and then split used to
convert the contents into a list.

It seems it would be simple to add a method to do that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #9 from Owen Leonard  ---
Created attachment 124910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124910&action=edit
Bug 29015: (follow-up) Default to logged in branch unless viewing queue

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #8 from Owen Leonard  ---
Created attachment 124909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124909&action=edit
Bug 29015: (follow-up) Show sidebar filter form with results

This patch adds the new filter form in the sidebar when showing results.
To do so the form markup is moved into a BLOCK so that it can be reused.

This patch also adds pre-selection of submitted options on the filter
form so that it reflects the user's choices.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation -> Holds queue.
- Submit the form with one or more filters selected.
- On the results page the queue should be correctly filtered and the
  sidebar should show your search fields preselected.
- Test with the CircSidebar preference enabled and disabled. The
  circulation menu should appear correctly, with the filter form only
  displaying in the sidebar after submitting the form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #7 from Owen Leonard  ---
Created attachment 124908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124908&action=edit
Bug 29015: Unit tests

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard  changed:

   What|Removed |Added

 Attachment #124871|0   |1
is obsolete||
 Attachment #124881|0   |1
is obsolete||
 Attachment #124883|0   |1
is obsolete||
 Attachment #124903|0   |1
is obsolete||

--- Comment #6 from Owen Leonard  ---
Created attachment 124907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124907&action=edit
Bug 29015: Add options for itemtpye, collection, and shelving location to
view_holdsqueue.pl

This patch makes the code for itemtypeslimit work, and adds options for
shelving location and collection code

This also remove the 'post' method from the form to allow easy bookmarking

To test:
1 - Add holds to your system
2 - Run the holds queue builder
3 - Browse to Circulation->Holds queue
4 - Note the library dropdown
5 - Apply patch
6 - Reload and note new options
7 - Test that both limits and 'All' options work as expected
8 - Note that description at top includes options when selected
"### items found for All libraries and item type:(Books)"

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #124904|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 124906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124906&action=edit
Bug 29032: Pre-load ILL backends to speed up response

Bug 22440 will rewrite the route and make it even more efficient by
prefetching the related data instead of performing several queries in
loops.

In the meantime, we can make this controller perform better with a
simple intervention: load backends once, and use the
$request->_backend() setter to pre-set it before using the objects.

To test:
1. Perform any usual ILL requests listing, try having several
=> FAIL: Notice it takes a weird amount of time to load
2. Apply this patch
3. Restart all
4. Repeat 1
=> SUCCESS: It feels fast enough!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29030] Problems introduced by bug 25728

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #3 from Owen Leonard  ---
(In reply to Owen Leonard from comment #1)
> At the very least the authorized value and description fields should be
> mandatory in the modal form.

My patch makes this change along with some other interface improvements. It
would be nice if errors triggered by duplicate authorized values were better
handled... Right now it triggers a 500 error which shows up in the browser
console.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29030] Problems introduced by bug 25728

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #2 from Owen Leonard  ---
Created attachment 124905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124905&action=edit
Bug 29030: Make authorized value and description fields required

This patch modifies the markup of the "Create a new authorized value"
modal so that a minimum set of fields is required: Authorized value and
description.

The patch also modifies the JavaScript which handles the submission so
that the jQuery Validation plugin can handle the field checks.

The spelling "authorised" is changed to "authorized" following coding
guidelines.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Locate a record in the catalog which has items and open an item for
  editing.
- In the add item form, test the process of adding an authorized
  value on the fly with the following fields: Withdrawn, Lost,
  Damaged, Use restrictions, Not for loan, Collection code, Shelving
  location, and Shelving control number.
  - In each case you should be able to type a new value in the
dropdown's search box and be shown the option "Select to create."
  - Selecting should trigger a modal window, "Create a new authorized
value."
  - Test that both "Authorized value" and "Description" fields are
required, and the form can't be submitted without them.
  - Test that an error message shows up when you submit an authorized
value which already exists, e.g. authval "1" for "DAMAGED."
  - After triggering this error, click the "Cancel" button and try
creating another new authorized value. When the modal reopens the
form should be reset: No previously-entered data, no error messages.
  - Submitting a valid form with a new authorized value should work
correctly. The modal window should close automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29030] Problems introduced by bug 25728

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #124899|0   |1
is obsolete||

--- Comment #3 from Andrew Fuerste-Henry  ---
Created attachment 124904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124904&action=edit
Bug 29032: Pre-load ILL backends to speed up response

Bug 22440 will rewrite the route and make it even more efficient by
prefetching the related data instead of performing several queries in
loops.

In the meantime, we can make this controller perform better with a
simple intervention: load backends once, and use the
$request->_backend() setter to pre-set it before using the objects.

To test:
1. Perform any usual ILL requests listing, try having several
=> FAIL: Notice it takes a weird amount of time to load
2. Apply this patch
3. Restart all
4. Repeat 1
=> SUCCESS: It feels fast enough!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #5 from Nick Clemens  ---
Created attachment 124903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124903&action=edit
Bug 29015: (follow-up) Default to logged in branch unless viewing queue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22440


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
[Bug 22440] ILL API response objects inconsistent with other endpoints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||29032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032
[Bug 29032] ILL route unusable (slow)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #33 from Tomás Cohen Arazi  ---
After reading the comments again, it seems that:
- Keep wantarray, fix places: ashimema, tcohen
- Get rid of wantarray: Joubu

what do you think, Marcel?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #32 from Tomás Cohen Arazi  ---
@ashimema, @Joubu what you think needs to be done to unlock this?
I could chase the places in which scalar is used in a chained fashion on
templates and make them use the Scalar TT plugin as suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #38 from Kyle M Hall  ---
Created attachment 124902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124902&action=edit
Bug 28803: (follow-up) Error details improvement

This patch updates the exceptions thrown by Koha::Email to include the
parameter that failed email validation and then updates the failure code
to include this parameter and finally display this field in the template.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #37 from Kyle M Hall  ---
Created attachment 124901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124901&action=edit
Bug 28803: Add invalid email handling in _send_message_by_email

This patch adds a try/catch block around the call to Koha::Email->create
to catch and handle invalid emails being passed in the parameters.

The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #124886|0   |1
is obsolete||
 Attachment #124887|0   |1
is obsolete||
 Attachment #124888|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall  ---
Created attachment 124900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124900&action=edit
Bug 28803: Add unit tests

This patch updates Letters.t to confirm that invalid email addresses in
the message_queue should not throw an exception when sending mail but
instead set the status to failed and pass error details to the end user.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 124899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124899&action=edit
Bug 29032: Pre-load ILL backends to speed up response

Bug 22440 will rewrite the route and make it even more efficient by
prefetching the related data instead of performing several queries in
loops.

In the meantime, we can make this controller perform better with a
simple intervention: load backends once, and use the
$request->_backend() setter to pre-set it before using the objects.

To test:
1. Perform any usual ILL requests listing, try having several
=> FAIL: Notice it takes a weird amount of time to load
2. Apply this patch
3. Restart all
4. Repeat 1
=> SUCCESS: It feels fast enough!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||RM_priority

--- Comment #1 from Tomás Cohen Arazi  ---
Marking it RM_priority so it can be backported ASAP to stable branches once we
are sure it works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||andrew.isherwood@ptfs-europ
   ||e.com,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29032] New: ILL route unusable (slow)

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29032

Bug ID: 29032
   Summary: ILL route unusable (slow)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com

With only 20 ill requests, for the same backend, the page takes lots of seconds
to load.

Steps to reproduce:
1. Add 23 requests with your favourite ILL backend
2. Hit the ILL requests page
=> FAIL: Notice it takes ages to load

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

--- Comment #4 from Marcel de Rooy  ---
Created attachment 124898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124898&action=edit
Bug 29029: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #124885|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 124897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124897&action=edit
Bug 29029: Introduce Koha::Object::ColumnSet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223

Martin Renvoize  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
   ||,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

--- Comment #10 from Martin Renvoize  ---
Updated to use the Signed off alternative posted to bug 15156.

What is 'MAD' for the --confirm option.. that confused me whilst testing.

Otherwise, this generally works as expected.. I'd love to see the filter
options introduced in bug 15156 utilised in this script allowing for debarment
threshold amounts for example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

--- Comment #9 from Martin Renvoize  ---
Created attachment 124896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124896&action=edit
Bug 15157: Update for reworked bug 15156

This patch updates the script to use filter_by_amount_owed.

We could add a series of options to the script to allow more fine
grained control.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #109220|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 124895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124895&action=edit
Bug 15157: Update script

This patch updates debarrBorrowersWithFines.pl script to match
changes made in bug 15156.

To test:
1. Have patron(s) with unpaid fines
2. Run e.g debarrBorrowersWithFines.pl --confirm -m "This is a description of
you bad deeds"
(test other options too)
3. Confirm patron(s) with fines has been debarred with the explanation

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #44646|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 124894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124894&action=edit
Bug 15157 - Cronjob to automatically debar Borrowers/Patrons with
pending/unpaid fines/accountlines

If your library wants to debar all Borrower who haven't paid their fines by the
end of the year, this script will do that trick :)

You can give the message from a file if the cronjob runner doesn't deal with
quotes,
or as a command-line parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29030] Problems introduced by bug 25728

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Owen Leonard  changed:

   What|Removed |Added

Summary|Problems introduced by bugg |Problems introduced by bug
   |25728   |25728

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29030] Problems introduced by bugg 25728

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

--- Comment #1 from Owen Leonard  ---
At the very least the authorized value and description fields should be
mandatory in the modal form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27859] Marc export for search result

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #6 from David Gustafsson  ---
Rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27859] Marc export for search result

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859

David Gustafsson  changed:

   What|Removed |Added

 Attachment #117721|0   |1
is obsolete||
 Attachment #124892|0   |1
is obsolete||

--- Comment #5 from David Gustafsson  ---
Created attachment 124893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124893&action=edit
Bug 27859: marc search result export

Enable export of staff interface search results in different marc formats.
The export will be mailed to the configured mail address of the current user.
This feature is Elasticsearch only.

To test:
1) Apply patch
2) Run installer/data/mysql/updatedatabase.pl
3) Make sure the syspref EnableSearchResultMARCExport is enabled
4) Make sure the current user has the tools -> export_catalog permission
5) Make sure the current user has an email under your control set
6) Perform a search
7) Export the serach result by choosing a format under the
   "Export results" drop down
8) Verify that link(s) with exported data has been mailed to the
   provided emial
9) Revoke the permission in 3) and make sure exporting is no longer
   possible
10) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27859] Marc export for search result

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859

--- Comment #4 from David Gustafsson  ---
Created attachment 124892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124892&action=edit
Use patron object instead of userenv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Agustín Moyano  changed:

   What|Removed |Added

 CC||agustinmoy...@theke.io
   Assignee|n...@bywatersolutions.com   |agustinmoy...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27884] Add html mail support for email report

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27884] Add html mail support for email report

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884

--- Comment #9 from David Gustafsson  ---
Created attachment 124891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124891&action=edit
Bug 27884: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27884] Add html mail support for email report

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884

David Gustafsson  changed:

   What|Removed |Added

 Attachment #118929|0   |1
is obsolete||

--- Comment #8 from David Gustafsson  ---
Created attachment 124890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124890&action=edit
Bug 27884: Add html support for report mails

To test:
1) Create a new notice, for example with Koha module "Patrons",
   name/code TEST and message body "testing".
2) Create a new sql report, the query could be someting like:
   SELECT "" as `borrowernumber`, "t...@example.com", as `email`,
"f...@example.com" as `from`;
   where "" is a valid borrowernumber.
3) Run patron_emailer.pl --report= --notice=TEST --module=members -commit
   where  is the report id.
4) Check the message_queue table that the content_type column has been
   set to text/html; charset="UTF-8".
5) Ideally process the message queue and veriy that the sent email is displayed
   as rendered html.
6) Run tests in t/db_dependent/Reports/Guided.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29031] New: Authorities see also links - plack error

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29031

Bug ID: 29031
   Summary: Authorities see also links - plack error
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: vitorfernande...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The authorities see also links in Koha 21.05.01 OPAC gives a plack error:
Can't call method "authtypetext" on an undefined value at
opac-authorities-home.pl line 155

Test plan:

- Create for example an UNIMARC authority with the following fields:
- 250$a - test1
- 550$a - test2
- Open the created authority in OPAC
- Click on the link test2 (see also section)
- Error 500

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29025] Saved auth login and password are pre-filled in patron creation form

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Owen Leonard  changed:

   What|Removed |Added

 Attachment #124873|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 124889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124889&action=edit
Bug 29025: Don't prefill userid and password in user creation form

Recent Firefox versions try to prefill userid and password with
logged in user credentials.

To test
1 - Log in staff as user foo password bar
2 - Save user and password in Firefox
3 - Log out
4 - Log in again, log in pop-up must be pre-filled
5 - Open Create a new patron form
6 - At least password field is pre-filled with logged in user's credentials
7 - Apply patch
8 - Redo 4 and 5
9 - Userid and password fields aren't prefilled

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29025] Saved auth login and password are pre-filled in patron creation form

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29025

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29030] New: Problems introduced by bugg 25728

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29030

Bug ID: 29030
   Summary: Problems introduced by bugg 25728
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: klas.blomb...@skovde.se
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

There are two problems with the feature of creating new authorized values
introduced by bugg 25728

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

The MINOR problem is that you can save a new authorized value without actually
entering a new authorized value, you just need a description

The MAJOR problem is that this feature isn't optional!
Introducing a new authorized value is a complex process where you have to take
library limitaions into consideration, authorized values are used in sysprefs
and conjobs, often you have to rewrite some reports when you introduce a new
authorized value &c, &c.
In short: We certainly don't want anyone to create new authorized values on the
fly! Not even I should have that possibility.

We have had this unwelcome feature for some weeks, and there are already dozens
of new athorized values created by mistake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #35 from Martin Renvoize  ---
Rebased for bug 28870..

I really wish the dependencies hadn't been jumbled up so much.. this was a
trivial and critical fix for older Koha's and now it's got a chain of bugs to
apply.

Oh well.. this is how things go sometimes I suppose.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #124880|0   |1
is obsolete||

--- Comment #34 from Martin Renvoize  ---
Created attachment 124888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124888&action=edit
Bug 28803: (follow-up) Error details improvement

This patch updates the exceptions thrown by Koha::Email to include the
parameter that failed email validation and then updates the failure code
to include this parameter and finally display this field in the template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #124879|0   |1
is obsolete||

--- Comment #33 from Martin Renvoize  ---
Created attachment 124887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124887&action=edit
Bug 28803: Add invalid email handling in _send_message_by_email

This patch adds a try/catch block around the call to Koha::Email->create
to catch and handle invalid emails being passed in the parameters.

The message is marked as 'failed' with an error_code of 'INVALID_EMAIL'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #124878|0   |1
is obsolete||

--- Comment #32 from Martin Renvoize  ---
Created attachment 124886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124886&action=edit
Bug 28803: Add unit tests

This patch updates Letters.t to confirm that invalid email addresses in
the message_queue should not throw an exception when sending mail but
instead set the status to failed and pass error details to the end user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

--- Comment #17 from Katrin Fischer  ---
Just looking into this a little bit: I think sending the "all branches all
items" notice from the patron's homebranch would make a lot of sense as this is
how the DUEDGST and PREDUEDGST also operate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

--- Comment #2 from Marcel de Rooy  ---
Removed the test temporarily, and the City example. Patch coming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Marcel de Rooy  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

--- Comment #1 from Marcel de Rooy  ---
Created attachment 124885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124885&action=edit
Bug 29029: Introduce Koha::Object::ColumnSet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28999] Add Koha::AllowList and DenyList

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #11 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #9)
> Please add feedback on especially the last patch.

Here is my current stand: These two objects are so generic and close to hash
slice and invert that I removed them from ColumnSet. They are real nice
objects, but we can live without them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28999] Add Koha::AllowList and DenyList

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Add Koha::AllowList,|Add Koha::AllowList and
   |DenyList and|DenyList
   |Koha::Object::ColumnSet |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #124828|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999

--- Comment #10 from Marcel de Rooy  ---
Moving the ColumnSet to its own report. Bug 29029

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard  ---
I think the original patches work well, and I hope my follow-up makes it even
better. I do have one request because I think as it is this patch changes a
behavior that libraries depend on:

The form when it is initially displayed should pre-select the logged-in user's
home library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29026] Behavior change when an empty barcode field is submitted in circulation

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #124877|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 124884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124884&action=edit
Bug 29026: Restore behavior when an empty barcode field is submitted in
circulation

When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty
barcode field is submitted in circulation :

Before Bug 17845, behavior was to display empty circulation page (no patron
selected).
Now behavior is displaying the circulation page of current patron.

I think previous behavior was used when scanner is used to clear form and wait
for another patron card to be scanned.

Test plan :
1) Set system preference CircAutoPrintQuickSlip to 'clear the screen'
2) Go to a patron circulation page
3) Post form without a barcode
=> Check you go to circulation page with no patron selected
4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip
window'
5) Go to a patron circulation page
6) Post form without a barcode
=> Check you go to print quick slip window with correct datas

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29026] Behavior change when an empty barcode field is submitted in circulation

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29026

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29015] Add option to limit Holds Queue report by shelving location / collection

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015

--- Comment #3 from Owen Leonard  ---
Created attachment 124883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124883&action=edit
Bug 29015: (follow-up) Show sidebar filter form with results

This patch adds the new filter form in the sidebar when showing results.
To do so the form markup is moved into a BLOCK so that it can be reused.

This patch also adds pre-selection of submitted options on the filter
form so that it reflects the user's choices.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation -> Holds queue.
- Submit the form with one or more filters selected.
- On the results page the queue should be correctly filtered and the
  sidebar should show your search fields preselected.
- Test with the CircSidebar preference enabled and disabled. The
  circulation menu should appear correctly, with the filter form only
  displaying in the sidebar after submitting the form.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29029] New: Koha::Object - add filter method based on column sets

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029

Bug ID: 29029
   Summary: Koha::Object - add filter method based on column sets
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

See bug 28999. Separating ColumnSet from AllowList.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Kyle M Hall  ---
(In reply to Martin Renvoize from comment #30)
> Fresh patches attached... should work now Kyle, sorry about that... sha1
> issues are the bane.

I looks like your patches conflict when applied on top of 28870?

Even applied directly to master, I'm getting unit test failures:
t/db_dependent/Letters.t .. 51/83
#   Failed test 'Failure code set correctly for invalid email parameter'
#   at t/db_dependent/Letters.t line 959.
#  got: 'INVALID_EMAIL:HASH(0x55de0d87b468)->parameter'
# expected: 'INVALID_EMAIL'
# Looks like you failed 1 test of 7.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28914] Wrong wording in authentication forms

2021-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914

Owen Leonard  changed:

   What|Removed |Added

 Attachment #124872|0   |1
is obsolete||

--- Comment #14 from Owen Leonard  ---
Created attachment 124882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124882&action=edit
Bug 28914: Fix wording in authentication forms

In most authentication forms we see :
Fields "Login:" and "Password:" with a submit button "Log in".

In some places submit button contains "Login", which is confusing for
translation.
It is not correct according to terminology
https://wiki.koha-community.org/wiki/Terminology#L
Also in opac-user.pl ":" is missing, it generates new translation entries.

Test plan:
1) Log out if you are logged in
2) Go to staff interface
3) Check you see button "Log in"
4) Go to OPAC page /cgi-bin/koha/opac-user.pl
5) Check you see fields "Login:" and "Password:"

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >