[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 David Nind changed: What|Removed |Added Attachment #124921|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 125031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125031&action=edit Bug 29033: Add C4::Context->multivalue_preference I've seen several places in which a syspref is retrieved and then splitted using split and the fact they are pipe-separated strings. It seems it would be simple (and handy) to add a method to do that. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Context.t => SUCCESS: Tests pass, a pipe-separated syspref is correctly retrieved as an arrayref. 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Thanks Owen - some nice tidy-ups! Testing notes: - Reviewed diff in browser -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 --- Comment #3 from David Nind --- Created attachment 125030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125030&action=edit Bug 28438: (follow-up) Capitalization: Various corrections One mdditional correction. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 David Nind changed: What|Removed |Added Attachment #125015|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 125029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125029&action=edit Bug 28438: Capitalization: Various corrections This patch makes capitalization corrections to many templates in the OPAC and staff interface. A exhaustive test plan would be huge, so I recommend examining the patch to confirm that it contains correct case changes. If you want to make it easier to examine changes you can try: https://github.com/so-fancy/diff-so-fancy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29053] ILSDI Internal Server errors seem not to log anywhere?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29053 --- Comment #1 from Liz Rea --- The test case was a place hold via ilsdi, with a dateformat that was not in ISO format, which was a bug with the requesting software. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29053] ILSDI Internal Server errors seem not to log anywhere?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29053 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29053] New: ILSDI Internal Server errors seem not to log anywhere?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29053 Bug ID: 29053 Summary: ILSDI Internal Server errors seem not to log anywhere? Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wizzy...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Had a situation where ILSDI was throwing an internal server error, but none of the logs (plack-intranet-error, plack-error, intranet-error, plack-opac-error, opac-error, or really anywhere in /var/log/koha/instance/) seemed to be logging the errors. I'd be happy to be wrong about this one lol. Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Owen Leonard changed: What|Removed |Added Attachment #124942|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 --- Comment #9 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #6) > Fixes the problem, also as well for link_bibs_to_authorities.pl where the > same issue occurred. This patch doesn't update the match_count value to > cache in the update_cache() function even though it should, but the function > was already buggy before this (it didn't update correctly the fuzzy value), > and I think what we should do there is call the get_link() with a parameter > to tell ignore cache so it will correctly then populate the cache values – > but it's out of scope for this bug. > > Passing QA. Forgot to attach the other patch, re-attached now with my sign-off again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 --- Comment #8 from Joonas Kylmälä --- Created attachment 125028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125028&action=edit Bug 28676: Cache and retrieve match_count when searching a cached heading We use match_count to determine if a new authority record should be created, however, we were not adding this count to the cache, so if a record returned too many matches on first lookup, we would create a new record on the second lookup To test: 1 - Set Linker Module to 'Default' 2 - Enable AutoCreateAuthorities and BiblioAddsAuthorities and CatalogModuleRelink and LinkerRelink 3 - Add two copies of a single authority via Z39 4 - Add two headings for that authority to a bib record (e.g. a 610 and 710) 5 - Save the record and note a new authority is generated 6 - Repeat and see another is generated 7 - Apply patch 8 - Restart all the things 9 - Save the record again, no new authority created Signed-off-by: Phil Ringnalda Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 Joonas Kylmälä changed: What|Removed |Added Attachment #125026|0 |1 is obsolete|| --- Comment #7 from Joonas Kylmälä --- Created attachment 125027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125027&action=edit Bug 28676: Unit test Signed-off-by: Phil Ringnalda Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | --- Comment #6 from Joonas Kylmälä --- Fixes the problem, also as well for link_bibs_to_authorities.pl where the same issue occurred. This patch doesn't update the match_count value to cache in the update_cache() function even though it should, but the function was already buggy before this (it didn't update correctly the fuzzy value), and I think what we should do there is call the get_link() with a parameter to tell ignore cache so it will correctly then populate the cache values – but it's out of scope for this bug. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 Joonas Kylmälä changed: What|Removed |Added Attachment #124430|0 |1 is obsolete|| Attachment #124431|0 |1 is obsolete|| --- Comment #5 from Joonas Kylmälä --- Created attachment 125026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125026&action=edit Bug 28676: Cache and retrieve match_count when searching a cached heading We use match_count to determine if a new authority record should be created, however, we were not adding this count to the cache, so if a record returned too many matches on first lookup, we would create a new record on the second lookup To test: 1 - Set Linker Module to 'Default' 2 - Enable AutoCreateAuthorities and BiblioAddsAuthorities and CatalogModuleRelink and LinkerRelink 3 - Add two copies of a single authority via Z39 4 - Add two headings for that authority to a bib record (e.g. a 610 and 710) 5 - Save the record and note a new authority is generated 6 - Repeat and see another is generated 7 - Apply patch 8 - Restart all the things 9 - Save the record again, no new authority created Signed-off-by: Phil Ringnalda Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28972] Add missing foreign key constraints to holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28972] Add missing foreign key constraints to holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Joonas Kylmälä changed: What|Removed |Added Attachment #124662|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä --- Created attachment 125025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125025&action=edit Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28972] Add missing foreign key constraints to holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Joonas Kylmälä changed: What|Removed |Added Attachment #124328|0 |1 is obsolete|| --- Comment #9 from Joonas Kylmälä --- Created attachment 125024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125024&action=edit Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. Signed-off-by: Sally Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18747] Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wrong wording in authentication forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wrong wording in authentication forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Joonas Kylmälä changed: What|Removed |Added Attachment #124882|0 |1 is obsolete|| --- Comment #15 from Joonas Kylmälä --- Created attachment 125023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125023&action=edit Bug 28914: Fix wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. It is not correct according to terminology https://wiki.koha-community.org/wiki/Terminology#L Also in opac-user.pl ":" is missing, it generates new translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see button "Log in" 4) Go to OPAC page /cgi-bin/koha/opac-user.pl 5) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wrong wording in authentication forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Failed QA CC||joonas.kylm...@iki.fi --- Comment #3 from Joonas Kylmälä --- The get_from_cache() function cannot be called without any value because it calls croak() if done so. This change will at least break the Koha installer, http://localhost:8081/cgi-bin/koha/installer/install.pl. Please also fix the typo in the commit title and check with perltidy your code follows the coding style: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #28 from Joonas Kylmälä --- Created attachment 125022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125022&action=edit Bug 28847: Remove dead code and make regex consistent This updates the regex code to match throughout the routine and removes code that would no longer be reached. Note that the code to update library name in the query descruiption was broken before this patch, so removal does not change behaviour Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #27 from Joonas Kylmälä --- Created attachment 125021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125021&action=edit Bug 28847: (follow-up) Handle branch_group_limit To test: 1 - Create a library group as an OPAC search group 2 - Enable OpacAddMastheadLibraryPulldown 3 - Browse to: http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=t&branch_group_limit=multibranchlimit-1&weight_search=1 4 - Confirm search works and returns correct results 5 - Confirm dropdown is correctly populated Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #26 from Joonas Kylmälä --- Created attachment 125020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125020&action=edit Bug 28847: Only apply JS to branch/multibranch selection if there are search groups Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #25 from Joonas Kylmälä --- Created attachment 125019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125019&action=edit Bug 28847: Cleanup of branch limitsand fix OPAC_SEARCH_LIMIT The opac had 'branch_group_limit' parameters which can be simplified to more closely match intranet code. Adjust C4::Auth for chaneg above to ensure dropdowns correctly populate Expand JS to prevent selection of single and multibranch limits To test: 1 - Enable OpacAddMastheadLibraryPulldown system preference 2 - Ensure branches and groups show as before patch 3 - Ensure single and multibranch limits from masthead apply as expected 4 - Test advanced search page, ensure you cannot select both single and multibranch limit 5 - Follow test plan on 28845 - ensure multibranch limit still correctly pre-selected Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #24 from Joonas Kylmälä --- Created attachment 125018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125018&action=edit Bug 28847: Unit tests Note: tests are very similar between ES and Zebra, however, ES requires the uppercase OR and doesn't use '=' in the same way. I feel having test coverage in each module is fair and more future proof in case of changes to search engine Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä changed: What|Removed |Added Attachment #124574|0 |1 is obsolete|| Attachment #124575|0 |1 is obsolete|| Attachment #124576|0 |1 is obsolete|| Attachment #124577|0 |1 is obsolete|| Attachment #124797|0 |1 is obsolete|| Attachment #124831|0 |1 is obsolete|| --- Comment #23 from Joonas Kylmälä --- Created attachment 125017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125017&action=edit Bug 28847: Move SearchLimitLibrary code to QueryBuilder Modules This patch removes the code from the search scripts into QueryBuilder modules. To test: 1 - Have a library group defined as a search group for both staff and opac 2 - Search on staff client and opac with that group limit and a single branch limit 3 - Note your results/counts 4 - Note the visuals of the search description 5 - Apply patch 6 - Repeat searches 7 - All should work as before Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
