[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #64 from Emmi Takkinen --- Gosh, I didn't realise I had made that change in follow up and hadn't tested it properly. My bad, sorry. Thanks Martin for fixing this :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29055] New: Focus on keyword field when subscription biblio search window opens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29055 Bug ID: 29055 Summary: Focus on keyword field when subscription biblio search window opens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org To reproduce: 1. Go to Serials and Add a new subscription 2. Search for a record 3. There is only one search field (keyword), and you have to click into it to use it. It should be focussed as the window opens so the cursor starts in there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Hayley Pelham changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |hayleypel...@catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29054] New: Stop warns from advance_notices.pl if not running in verbose mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Bug ID: 29054 Summary: Stop warns from advance_notices.pl if not running in verbose mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: hayleypel...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz When the advance_notices.pl cronjob is run and the EnhancedMessagingPreferences syspref is set to don't allow, we get the following warning: The "EnhancedMessagingPreferences" syspref is off. Therefore, it is unlikely that this script will actually produce any messages to be sent. To change this, edit the "EnhancedMessagingPreferences" syspref. The advance_notices.pl script help says: -v Verbose. Without this flag set, only fatal errors are reported. However, the above warning is shown regardless of whether the script is run with the verbose flag. We need to add a verbosity check to this warn -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] OPAC registration form design is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 --- Comment #8 from Hayley Pelham --- Hi Joonas, The alignment is much closer to the other form elements now, which is great. However, if all required fields are completed except the GDPR checkbox, we don't get the 'This field is required' text and highlighting like we do for other elements. Should this be present? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #4 from David Cook --- "SubfieldsToAllowForRestrictedBatchmod", "SubfieldsToAllowForRestrictedEditing", and "SubfieldsToUseWhenPrefill" are separated by spaces. "AdvancedSearchLanguages" is separated by pipe or comma, which would make this method particularly problematic... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I don't know about this one... There are also multi value preferences that don't use pipes. Many preferences like "NotesToHide" and "ILS-DI:AuthorizedIPs" use commas instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] OPAC registration form design is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11388] Error exporting records to non-Unicode/MARC-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11388] Error exporting records to non-Unicode/MARC-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28604] Bad encoding when using marc-in-json
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28604 --- Comment #19 from wainuiwitikap...@catalyst.net.nz --- On 19.11.x Test Result (2 failures / ±0) t_db_dependent_api_v1_biblios_t.get() tests (703) t_db_dependent_api_v1_biblios_t.get_public() tests (703) I am getting these failtures Can someone please write a patch for that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29011] Error 500 on item checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29011 --- Comment #2 from Katrin Fischer --- Another thing to check: Make sure that all your items have itemtype, holding branch and home branch set. These are the subfields a, b, and y in the item form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29013] Add ability to uncancel an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29013 --- Comment #1 from Katrin Fischer --- Hi Karen, could you maybe add a step by step where you end up in this kind of situation? I haven't seen that error/message yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from David Nind --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28377: Use the API to suspend/resume holds Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/js/holds.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/holds.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 28377: Use the API to suspend/resume holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind changed: What|Removed |Added Attachment #124115|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 125037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125037=edit Bug 28906: (26223 follow-up) Remove use of as_list This bug makes Koha::Items->filter_by_visible_in_opac honour list context, so this explicit call is not needed. To test: 1. Pick a biblio in the OPAC 2. Go to the ISBD view => SUCCESS: It renders correctly 3. Apply this patch and restart Plack 4. Refresh the ISBD view page => SUCCESS: It doesn't break! 5. Check opac-reserve.pl doesn't break either 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind changed: What|Removed |Added Attachment #124113|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 125036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125036=edit Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context This patch makes the method honour list context. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => FAIL: Tests fail! It returns [Koha::Items]. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind changed: What|Removed |Added Attachment #124112|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 125035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125035=edit Bug 28906: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11388] Error exporting records to non-Unicode/MARC-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388 Joonas Kylmälä changed: What|Removed |Added Assignee|joonas.kylm...@iki.fi |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11388] Error exporting records to non-Unicode/MARC-8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388 --- Comment #3 from Joonas Kylmälä --- Bug still valid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi --- Comment #13 from Joonas Kylmälä --- So can we just obsolete those two patches? Let me know when this is ready for QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26626] When checking in a hold that is not found the X option is 'ignore' and when hold is found it is 'cancel'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||joonas.kylm...@iki.fi --- Comment #11 from Joonas Kylmälä --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi --- Comment #16 from Joonas Kylmälä --- (In reply to Hannah Co from comment #12) > Hi Andreas, I can certainly start a new bug report - I can report a bug for > my situation, but would it be better to create a bug that covers the whole > issue of "UpdateItemLocationOnCheckin not updating items where location is > null"? The _ALL_: CART issue discussed above is another highly specific > case, and I don't quite understand why the fix for that doesn't help in my > situation. I feel like there's a larger issue of location = NULL needing to > be handled in all situations. Opening a new bug report for your issue seems like the best idea, the problem here (by reading the code) is just specific to the _ALL_ configuration value and not to the other ones. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 --- Comment #15 from Joonas Kylmälä --- Created attachment 125034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125034=edit Bug 28472: (follow-up) add unit test for the case where location = NULL This patch adds an extra unit test, to cover the case where the UpdateItemLocationOnCheckin System Preference is set to "_ALL_: CART" and the item being returned has no shelving location set. Test plan: 1) Apply the patch provided earlier 2) prove -v t/db_dependent/Circulation/issue.t ...and sign off if all tests pass. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Joonas Kylmälä changed: What|Removed |Added Attachment #125011|0 |1 is obsolete|| Attachment #125012|0 |1 is obsolete|| --- Comment #14 from Joonas Kylmälä --- Created attachment 125033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125033=edit Bug 28472: handle items with NULL shelving location The UpdateItemLocationOnCheckin System Preference can be set to update the location of ALL items during check in, regardless of their shelving location. However, this does not currently work 100% as it is excluding items with no shelving location (i.e. value of NULL in the corresponding database field). This patch, based on the comment made by Nick Clemens, fixes that. Test plan (based on the original Bug Description by Andrew Fuerste-Henry): 1) Have a shelving location CART 2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes) 3) Check in an item that has a shelving location, confirm it changes to CART 4) Check in an item with a NULL shelving location, confirm it doesn't go to CART 5) Apply this patch 6) Repeat step 4): this time the item should move to the CART shelving location Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28903] Tab key and drop-down menu in item module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28903 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Signed Off |Failed QA --- Comment #13 from Joonas Kylmälä --- Proposed fix would select the option if you just hover your mouse cursor over the option and then click outside the box after that --> will cause most definitely unintended changes and was not the previous behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi --- Comment #8 from Joonas Kylmälä --- hmm, this disables the hide_patron_infos_if_needed variable which is probably not wanted, though the feature is quite broken anyways but this makes it more broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] OPAC registration form design is not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added Summary|Correct markup of GDPR |OPAC registration form |consent in OPAC patron |design is not consistent |entry | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added Attachment #124852|0 |1 is obsolete|| --- Comment #7 from Joonas Kylmälä --- Created attachment 125032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125032=edit Bug 28934: Make the OPAC registration form design consistent The gender/sex and GDPR inputs were slightly misaligned (by 1.5em). Now they are aligned with the other inputs which have a width of 10em (9em width + margin 1em). The label assignments and required attributes for input elements are made also consistent. To test: 1) Enable GDPR_Policy syspref 2) Apply patch, run "yarn build --view opac", restart plack 3) Go to /cgi-bin/koha/opac-memberentry.pl 3) Check that the GDPR input box shows the required text now in red color 3) Check that the alignment of sex/gender and GDPR input matches with the other inputs perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added Assignee|oleon...@myacpl.org |joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Signed Off |Failed QA --- Comment #6 from Joonas Kylmälä --- (In reply to Hayley Pelham from comment #5) > Created attachment 124852 [details] [review] > Bug 28934: Correct markup of GDPR consent in OPAC patron entry > > This patch makes changes to the markup around the GDPR consent checkbox > in the OPAC self-registration / update page to make it more consistent > with other form fields on the page. > > The patch also adds some missing attributes which are required to enable > JavaScript validation of the checkbox. > > To test, apply the patch and rebuild the OPAC CSS > (https://wiki.koha-community.org/wiki/ > Working_with_SCSS_in_the_OPAC_and_staff_client). > > - Go to Administration -> System preferences and Enable the system > preference PatronSelfRegistration. > - Set the system preference GDPR_Policy to "Enforce". > - Go to the OPAC and click the "Register here" link. > - Under the "GDPR consent" heading near the bottom of the page, > confirm that the "I agree" checkbox lines up with other form fields on > the page, and that the "Required" label lines up below it. > - Submit the form without checking the GDPR consent checkbox. > - The form should not be submitted, and a "This field is > required" message should appear next to the checkbox label. > > Signed-off-by: Hayley Pelham The alignment is still slightly off with this patch, noticable if you put the cursor to the input box above and then use down arrow to scroll to the checkbox. Also, I would prefer we would use consistent way to show the fields, i.e. always label and then the input form, this would make the alignment perfect as well. The gender field has also the same problem. I could send a patch to fix both of them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
