[Koha-bugs] [Bug 28321] Use template block for display of items in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28321] Use template block for display of items in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28321 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Patch no longer applies 8-(.. Applying: Bug 28321: Use template block for display of items in search results Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt Falling back to patching base and 3-way merge... Removing koha-tmpl/intranet-tmpl/prog/img/item-bullet.gif Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 28321: Use template block for display of items in search results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29101] unable to enter 020 and 024 tag fields other than blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29101 Courtenay Johnson changed: What|Removed |Added Resolution|INVALID |WONTFIX --- Comment #2 from Courtenay Johnson --- Problem resolved. Update to 21.05 reported problem as error 500. Found by examining log and the file it pointed to the problems that the tag specified in the framework should be 020, and not 20. Ditto for tag 24 in the framework should be 024. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29077] Warns when searching blank index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #2 from Fridolin Somers ---
@indexes = grep(/.+/, @indexes)
This is correct, but in actual code we see much more occurrences of :
grep { $_ ne q{} } @array
In my opinion it is better.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 --- Comment #6 from Fridolin Somers --- Nice change, I test it. > For a search with many results, you are redirected to the patron search > results and there is a 'Checkout' button under the cardnumber I see this also when searching via 'Seach patrons' form. And looks like permission check is needed there right ? In my opinion this button should be with 'Edit' in actions column. When searching for patron one can assume cardnumber is unknown so button being next to it is not really useful. Note than cardnumber column may be hidden. Patron may be identified by name so when clicking on it we may go to circulation page. Best regards, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 --- Comment #20 from Victor Grousset/tuxayo --- Also, there are been some changes in Koha that require consideration: issues.branchcode was moved from the bulk of the SQL query to just after in an «if($owning_library)» https://git.koha-community.org/Koha-community/Koha/src/commit/9d6d641d1f8b77271800f43bc027b651f9aea52b/misc/cronjobs/overdue_notices.pl#L492 This patch historically removed issues.branchcode from the bulk of the SQL query to have instead «AND issues.branchcode = ?" unless $all_in_one;» So maybe these two aren't compatible as it is. Still worth testing the current patch to maybe expose that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Victor Grousset/tuxayo --- Hi :) I'm not working on this anymore but since I did a rebase in the past, here is another one. The test plan of Olivier has been integrated with the requested changes(comment 13) It has not been tested, I'm just solving conflicts :P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29091] Correct display of lists and tags on search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #4 from Fridolin Somers --- I've also tested display in lists. "Tags:" diplay is corrected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29091] Correct display of lists and tags on search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091 Fridolin Somers changed: What|Removed |Added Attachment #125188|0 |1 is obsolete|| --- Comment #3 from Fridolin Somers --- Created attachment 125299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125299=edit Bug 29091: Correct display of lists and tags on search results This patch makes a minor change to CSS to fix the display of tags and lists on the OPAC search results page so that the list doesn't have extra padding. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - To test you should be able to perform a catalog search in the OPAC which will return results which have one or more tags and which are on one or more lists. - In the OPAC search results, confirm that there isn't extra padding between the "Tags:" and "Lists:" labels and their values. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29091] Correct display of lists and tags on search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29091 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 --- Comment #3 from Fridolin Somers --- Oh see that this will be obsolete if Bug 15812 is pushed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29104 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15812 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin Somers --- Hi, Looks great. Just a few thoughts : > 3. Do a patron search that will return multiple patrons, you should see the > date expiry column You should tell to use the "Check out" form. To not mistake with "Search patrons" form. Column name is 'Date expiry'. We see in patrons module the name 'Expires on'. I propose we use the same name. There is an issue, column sorting is not on date (if you don't use the ISO format). This is because formatting is done in perl code : https://git.koha-community.org/Koha-community/Koha/src/commit/870e3e8e161f6da998c1deae216d7fdf0d0490e7/C4/Utils/DataTables/Members.pm#L222 See the FIXME. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #80925|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #58398|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17649] Create only one message per borrower and overdue level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 125298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125298=edit Bug 17649: Only one message per borrower and overdue level The added option (-a|--all_in_one) allows to create only one message per borrower and delay level including overdues from whatever branches. A branchcode value (branches.branchcode) has to be given to choose which sender address will be set. == test plan == 0/ Have (or create) at least two branches B1 and B2. Have (or create) a default notice for all branches in Notices and Slips Module 1/ Make sure you're logged in with an account belonging to B1, or switch to branch B1 2/ checkout item I1 (belonging to B1) to patron P (specifying as due date the day before (1 day overdue)) 3/ switch to branch B2 4/ checkout item I2 (belonging to B2) to patron P (specifying as due date the day before (1 day overdue)) 5/ make sure you have defined "Overdue notice/status triggers" for that patron category, ie with Delay=1 so that "Overdue Notice" is selected and "Email" is checked. 6/ from cli run 'perl ./misc/cronjobs/overdue_notices.pl' (optionally specifying also '-library B1 -library B2' ) 7/ Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items 8/ either see the 'content' field in these entries, or run 'perl ./cronjobs/process_message_queue.pl' to receive the actual emails (provided the email is properly setup). Apply patch redo step 6 running the script with the new option -a (all_in_one). this option expect as mandatory parameter the branchcode of the library that you want to make sender of the message. say that 'B2CODE' is the branchcode of B2 branch, it will run like this : perl ./misc/cronjobs/overdue_notices.pl -a B2CODE You will see that only one message had been created. Its content shows both B1 and B2 overdue items and the sender address matches B2 address as well. Rebased-on: 2021-09-24 Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28996] SendQueuedMessages exit on a bad email 'To' and following messages are never processed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin Somers --- +1 giga -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26305] Warn IE users of staff interface that it is no longer supported and to use a supported browser instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24977] Enable translations for authorised values (POC)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #12 from Kyle M Hall --- Created attachment 125297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125297=edit Bug 28974: Hard code page = 1 instead of using javascript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #11 from Kyle M Hall --- Created attachment 125296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125296=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall changed: What|Removed |Added Attachment #125291|0 |1 is obsolete|| Attachment #125292|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 125295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125295=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 --- Comment #4 from Owen Leonard --- Created attachment 125294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125294=edit Bug 29036: (follow-up) Improve the use of variables to keep colors consistent This patch modifies the OPAC SCSS so that a "base theme color" variable is defined which can be used to color button backgrounds and similar elements. The patch also moves some other colors into variables and removes some unused CSS. The Koha logo which is displayed in the upper left corner of the OPAC has been modified to use the same color. To test, apply the patch and repeat the previous test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Attachment #125080|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 125293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125293=edit Bug 29036: Accessibility OPAC buttons don't have sufficient contrast This patch changed the base colour of OPAC buttons to increase the contrast ratio, improving accessibility and making the button text easier to read. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio on the OPAC 2. Confirm that the OPAC buttons don't have sufficient colour contrast 3. Apply the patch and rebuild css: yarn build --view opac 4. Use the accessibility tool to confirm the button contrast ratio now meets minimum accessibility requirements 5. Check that the OPAC still looks ok after the changes Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Owen Leonard changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #9 from Kyle M Hall --- Created attachment 125292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125292=edit Bug 28974: Start at first page when change number of results per page Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Kyle M Hall changed: What|Removed |Added Attachment #124874|0 |1 is obsolete|| Attachment #124875|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 125291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125291=edit Bug 28974: Add pagination to holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. Paginating the results of the holds queue will allow this page more flexible and load more quickly. Test Plan 1) Generate a lot of holds in the holds queue 2) Apply this patch 3) Try out the new pagination bar 4) Ensure the limit and page features function correctly Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #6 from Tomás Cohen Arazi ---
(In reply to David Nind from comment #5)
> I singed this off, but then thought I should check that the article requests
> system is still working.
>
> When adding a request or going to "Your account" (all the other user account
> ages seem fine) I get:
>
> Template process failed: undef error - DBIC result _type isn't of the _type
> Item at
> /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line
> 751.
> at /kohadevbox/koha/C4/Templates.pm line 121
>
> in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 121
>
> 118:
> 119: my $data;
> 120: binmode( STDOUT, ":encoding(UTF-8)" );
> 121: $template->process( $self->filename, $vars, \$data )
> 122: || die "Template process failed: ", $template->error();
> 123: return $data;
> 124: }
>
> Show function arguments
> in (eval) at /kohadevbox/koha/opac/opac-user.pl line 421
>
> 418: );
> 419: }
> 420:
> 421: output_html_with_http_headers $query, $cookie, $template->output,
> undef, { force_no_caching => 1 };
Are you sure you restarted all the things? I have just applied the whole tree
and reset_all, and things keep working as they used to.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 David Nind changed: What|Removed |Added Attachment #125192|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 125290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125290=edit Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093
David Nind changed:
What|Removed |Added
Attachment #125191|0 |1
is obsolete||
--- Comment #5 from David Nind ---
Created attachment 125289
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125289=edit
Bug 29093: {DO NOT PUSH] DBIx schema changes
Note: Pending table changes in PQA.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 David Nind changed: What|Removed |Added Attachment #125190|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 125288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125288=edit Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29093] Article requests: Checkbox for table of contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29093 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 --- Comment #5 from Esther Melander --- On version 21.05.14. The combination of the certain numbers appears to result in being 1 penny off. 0.6 x 3 = 1.79 0.7 x 3 = 2.09 Other combinations appear to be correct. In this case, only one item is added to the sale box. Screenshot attached to ticket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Esther Melander changed: What|Removed |Added CC||esth...@sodaspringsid.com --- Comment #4 from Esther Melander --- Created attachment 125287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125287=edit Calculation error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25003] Clearly identify when JavaScript errors are caused by OPACUserJS/IntranetUserJS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25003 T. Keagan changed: What|Removed |Added CC||tasha.kea...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 David Nind changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--- Comment #5 from David Nind ---
I singed this off, but then thought I should check that the article requests
system is still working.
When adding a request or going to "Your account" (all the other user account
ages seem fine) I get:
Template process failed: undef error - DBIC result _type isn't of the _type
Item at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 751.
at /kohadevbox/koha/C4/Templates.pm line 121
in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 121
118:
119: my $data;
120: binmode( STDOUT, ":encoding(UTF-8)" );
121: $template->process( $self->filename, $vars, \$data )
122: || die "Template process failed: ", $template->error();
123: return $data;
124: }
Show function arguments
in (eval) at /kohadevbox/koha/opac/opac-user.pl line 421
418: );
419: }
420:
421: output_html_with_http_headers $query, $cookie, $template->output,
undef, { force_no_caching => 1 };
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28826] Facet sort order differs between search engines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Works well, nice improvement. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28826] Facet sort order differs between search engines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826 Martin Renvoize changed: What|Removed |Added Attachment #123599|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 125286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125286=edit Bug 28826: Add FacetOrder system preference This bug adds a system preference to control ordering of facets and adds the control to both Zebra and Elasticsearch To test: 1 - Have a koha that can use both Zebra and ES 2 - Set 'displayFacetCount' to true 3 - Search in ES and Zebra 4 - Note facets in Zebra sorted alphabetically, ES by usage 5 - Apply patch, updatedatabase 6 - Search in ES and Zebra, facets are alphabetically sorted in both 7 - Find new syspref FacetOrder and set to 'by usage' 8 - Search in both engines, facets sorted by usage Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 David Nind changed: What|Removed |Added Attachment #125257|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 125285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125285=edit Bug 29110: Refactor Koha::ArticleRequest This patchset is simple to test. It adds lots of tests for the existing routines, and then tweaks them. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/ArticleRequests.t \ t/db_dependent/Koha/ArticleRequest* => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 David Nind changed: What|Removed |Added Attachment #125256|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 125284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125284=edit Bug 29110: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Nice work, QA scripts happy, cleaner code and tests still pass. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Martin Renvoize changed: What|Removed |Added Attachment #124842|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 125283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125283=edit Bug 28510: Remove unused variable Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Martin Renvoize changed: What|Removed |Added Attachment #122195|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 125282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125282=edit Bug 28510: Remove unnecessary conditional It makes sense to use items by branch to get the list of branches, as it already tells use which branches have available items. We could use branches to pull from instead, but all we would accomplish is added extra ununsed loop iterations. We already know that any additional branches in the branches to pull loop have no items to fill holds. If they did, they would be in the items_by_branch hash. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Martin Renvoize changed: What|Removed |Added Attachment #122194|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 125281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125281=edit Bug 28510: Remove marking of closed branches as 'disable_transfer' We no longer need to act as if closed branches were marked as disable_transfer. This allows us to clean up a nice bit of code. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Martin Renvoize changed: What|Removed |Added Attachment #122193|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 125280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125280=edit Bug 28510: Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled Right now we skip closed branch's items as we iterate over all items looking for ones to fill a hold. If HoldsQueueSkipClosed is enabled, no items held be a closed library can be targeted, so it would be more efficient if we never selected the items from those branches to begin with. This is how the holds queue works if we are not using the transport cost matrix, so we should make it work the same way if we *are* using the matrix. Test Plan: 1) Apply this patch 2) prove prove t/db_dependent/HoldsQueue.t 3) All tests should continue to pass Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- A marked improvement. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29037] Accessibility: OPAC links don't have sufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29037 Martin Renvoize changed: What|Removed |Added Attachment #125153|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 125279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125279=edit Bug 29037: Accessibility: OPAC links don't have sufficient contrast This patch changes the colour of links on the OPAC to improve the contrast ratio and make the link text easier to read. This accessibility issue was identified using the WebAIM WAVE accessibility browser extension and Google Chrome's Lighthouse tool. To test: 1. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to test the contrast ratio. 2. Confirm that some links (e.g. breadcrumb links and title links in search results) have insufficient contrast. 3. Apply the patch and rebuild the OPAC CSS: yarn build --view opac 4. Use the accessibility tool to confirm the contrast ratio meets minimum requirements 5. Check that the OPAC still looks ok after the changes. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29019] Unable to delete HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019 Caroline Cyr La Rose changed: What|Removed |Added Attachment #125223|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 125278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125278=edit Bug 29019: Unable to delete HTML customization This patch makes some corrections to additional contents to allow content to be deleted. The wrong parameter was being passed to the script. The script was also not handling multiple deletions correctly. The patch also adds a "category" parameter to the delete operation so that the page is redirected correctly. The patch also changes some strings which referred to "news" referencing operations which might be performed on news or on HTML customizations, e.g.: "Are you sure you want to delete the selected content?" instead of "Are you sure you want to delete the selected news?" To test, apply the patch and go to Tools -> News. - Create multiple news items if necessary. - Test the "Delete" button corresponding to a single news item: - Clicking the button should ask you to confirm. - Check that the wording of the message is correct. - After confirming the news item should be deleted. - Ideally, test on news items which are on the second page of the DataTable of news items. - Test the process of deleting multiple news items at once: - Check the checkbox next to multiple items. - Click the "Delete selected" button at the bottom of the page. - Check that the wording of the confirmation message is correct. - After you confirm, the items should be deleted. - Repeat these tests under Tools -> HTML customizations to confirm that redirects work correctly. After deleting an HTML customization you should be redirected back to the list of HTML customizations. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29019] Unable to delete HTML customization
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29019 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history link has insufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Brill. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29065] Accessibility: OPAC clear search history link has insufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29065 Martin Renvoize changed: What|Removed |Added Attachment #125089|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 125277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125277=edit Bug 29065: Accessibility OPAC clear search history link has insufficient contrast This patch changes the colour of the clear search history link on the OPAC to increase the contrast ratio, improve accessibility and makes the text easier to read. To test: 1. Go to the OPAC homepage 2. Use an accessibility tool (e.g Chrome's Lighthouse tool) to check the contrast ratio 3. Confirm that the clear search history link has insufficient contrast 4. Apply the patch and rebuild css: yarn build --view opac 5. Confirm that the contrast ratio now meets minimum accessibility requirements 6. Check the OPAC still looks ok after the changes Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Owen Leonard changed: What|Removed |Added Attachment #123961|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 125276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125276=edit Bug 28879: Fix display of request metadata This commit adjusts the CSS surrounding the display of request metadata, it improves the display for metadata with long key names. Test plan: - Do not apply patch - Create a FreeForm ILL request with a custom metadata field with a long name - View the created request - Observe that the long metadata name breaks the display of the metadata - Apply the patch - View the created request => TEST: Observe that the display is no longer broken Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28879] Display of metadata with long label names looks terrible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28879 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- All works as expected.. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29078] Division by zero in touch_all scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29078 Martin Renvoize changed: What|Removed |Added Attachment #125133|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 125275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125275=edit Bug 29078: Resolve division by zero in touch_all scripts Illegal division by zero at misc/maintenance/touch_all_biblios.pl line 102. Trivial fix. Funny that the percentage is not even shown without verbose flag ;) Test plan: Run misc/maintenance/touch_all_biblios.pl -where 'biblionumber<0' You should now see: Good: 0, Bad: 0 (of 0) in 0 seconds Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #27 from Martin Renvoize --- Nice one.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #26 from Martin Renvoize --- Created attachment 125274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125274=edit Bug 13188: (QA follow-up) Modernise atomicupdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Martin Renvoize changed: What|Removed |Added Attachment #123335|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 125273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125273=edit Bug 13188: (follow-up) Get value from PatronSelfRegistrationBorrowerMandatoryField when updating database Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Martin Renvoize changed: What|Removed |Added Attachment #122752|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 125272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125272=edit Bug 13188: Add PatronSelfModificationMandatoryField system preference TEST PLAN: 1. Apply patch, updatedatabase, restart_all 2. In the PatronSelfRegistrationBorrowerMandatoryField add the field password. 3. Go to the self registration page on make sure password is required. 4. Now go to the OPAC modification page, make some changes and attempt to submit. It should work. 5. Go to PatronSelfModificationMandatoryField and select some fields. 6. The columns you selected should now be required. 7. On the PatronSelfModificationMandatoryField page, make sure the select all and clear all buttons work. Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #14 from Nick Clemens --- Created attachment 125271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125271=edit Bug 29083: Fix OPAC listing of article requests This patch makes the OPAC template reuse a precalculated value for the active article requests for the patron (and its count). The original code relied on the methods returning a list, which is not the case for _new_from_dbic until bug 28883 is pushed. This patch fixes that. Note: there was an odd behavior when ArticleRequests was enabled but no active article requests were present: the tab wasn't rendered but the 'empty table' with the 'You have no article requests currently.' message was displayed below the Checkouts tab. I'm not sure that was caused by this patches, or other. Fixed on this patch. To test: 1. In the OPAC, go to 'your summary' => FAIL: Things don't show for article requests 2. Add some article requests and repeat 1 => FAIL: Something's wrong there 3. Apply this patch and repeat 1 => Yes! Things show correctly! 4. Cancel all your article requests => SUCCESS: Things render as they should 5. Re-enter the 'your summary' page (to force re-rendering) => SUCCESS: Things render correctly for empty article requests 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #13 from Nick Clemens --- Created attachment 125270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125270=edit Bug 29083: (QA follow-up) Remove unused param Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #12 from Nick Clemens --- Created attachment 125269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125269=edit Bug 29083: Update article requests-related Koha::Patron methods to use relationships This patch makes Koha::Patron->article_requests use the underlying DBIC relationship and _new_from_dbic instead of a plain search. It also refactors 'article_requests_current' and 'article_requests_finished' to use ->article_requests, as well as the new methods introduced by bug 29082 for filtering. No behavior change should take place. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/ArticleRequests.t => SUCCESS: Tests pass! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Nick Clemens changed: What|Removed |Added Attachment #125240|0 |1 is obsolete|| Attachment #125241|0 |1 is obsolete|| Attachment #125242|0 |1 is obsolete|| Attachment #125243|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 125268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125268=edit Bug 29083: Unit tests This patch adds missing tests for Koha::Patron->article_requests and moves (and extends) tests for 'article_requests_current' and 'article_requests_finished' that were originally in ArticleRequests.t into Koha/Patron.t as we now do. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/ArticleRequests.t \ t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #18 from Martin Renvoize --- Nice work, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Martin Renvoize changed: What|Removed |Added Attachment #124865|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 125267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125267=edit Bug 28534: (follow-up) Don't adjust original DB update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Martin Renvoize changed: What|Removed |Added Attachment #123113|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 125266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125266=edit Bug 28534: Atomic update to fix existing installs Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28534] pending_offline_circulations table uses MyISAM engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28534 Martin Renvoize changed: What|Removed |Added Attachment #123112|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 125265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125265=edit Bug 28534: Fix engine for pending_offline_circulations table Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29073] Hold expiration added to new holds when DefaultHoldExpirationdate turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Doh! Well spotted, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29073] Hold expiration added to new holds when DefaultHoldExpirationdate turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Martin Renvoize changed: What|Removed |Added Attachment #125113|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 125264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125264=edit Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Excellent work.. scald the devs for getting them wrong in the first place (that probably includes me :( ) Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29082] Add filtering methods to Koha::ArticleRequests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082 Nick Clemens changed: What|Removed |Added Attachment #125239|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 125263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125263=edit Bug 29082: Add filtering methods to Koha::ArticleRequests This patch adds handy methods for filtering Koha::ArticleRequests resultsets. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29082] Add filtering methods to Koha::ArticleRequests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 Martin Renvoize changed: What|Removed |Added Attachment #125030|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 125262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125262=edit Bug 28438: (follow-up) Capitalization: Various corrections One mdditional correction. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28438] Capitalization: Various corrections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28438 Martin Renvoize changed: What|Removed |Added Attachment #125029|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 125261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125261=edit Bug 28438: Capitalization: Various corrections This patch makes capitalization corrections to many templates in the OPAC and staff interface. A exhaustive test plan would be huge, so I recommend examining the patch to confirm that it contains correct case changes. If you want to make it easier to examine changes you can try: https://github.com/so-fancy/diff-so-fancy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #11 from Martin Renvoize --- All works as expected, no regressions found, QA scripts happy and tests all passing. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize changed: What|Removed |Added Attachment #125037|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 125260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125260=edit Bug 28906: (26223 follow-up) Remove use of as_list This bug makes Koha::Items->filter_by_visible_in_opac honour list context, so this explicit call is not needed. To test: 1. Pick a biblio in the OPAC 2. Go to the ISBD view => SUCCESS: It renders correctly 3. Apply this patch and restart Plack 4. Refresh the ISBD view page => SUCCESS: It doesn't break! 5. Check opac-reserve.pl doesn't break either 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize changed: What|Removed |Added Attachment #125036|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 125259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125259=edit Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context This patch makes the method honour list context. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => FAIL: Tests fail! It returns [Koha::Items]. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Martin Renvoize changed: What|Removed |Added Attachment #125035|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 125258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125258=edit Bug 28906: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 125257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125257=edit Bug 29110: Refactor Koha::ArticleRequest This patchset is simple to test. It adds lots of tests for the existing routines, and then tweaks them. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/ArticleRequests.t \ t/db_dependent/Koha/ArticleRequest* => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 125256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125256=edit Bug 29110: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29056] Remove demo functionality remnants
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29056] Remove demo functionality remnants
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29056 Martin Renvoize changed: What|Removed |Added Attachment #125051|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 125255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125255=edit Bug 29056: Remove the demo functionality leftovers Remove forgotten code of the old legacy demo functionality that was removed from elsewhere except systempreferences, this code not only serves no purpose but also is causing some troubles for our customers. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #5 from Martin Renvoize --- So this patch does one direction (i.e. results), but doesn't cater for searches using q_param yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29108] Add q parameters to items routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29105 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] items responses do not respect effective_itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29108] Add q parameters to items routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Fair.. signed off then. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29108] Add q parameters to items routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108 Martin Renvoize changed: What|Removed |Added Attachment #125237|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 125254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125254=edit Bug 29108: Add q parameters to items routes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 Tomás Cohen Arazi changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27949] Batch printing of article request slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 [Bug 29110] Refactor Koha::ArticleRequest->store -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27949 Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949 [Bug 27949] Batch printing of article request slips -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] New: Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 Bug ID: 29110 Summary: Refactor Koha::ArticleRequest->store Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org We should revisit the file altogether, and add more checks to ->store. This way the code will be easier to follow are more similar to what we do everywhere else. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
