[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

David Nind  changed:

   What|Removed |Added

 Attachment #125688|0   |1
is obsolete||

--- Comment #16 from David Nind  ---
Created attachment 125718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125718=edit
Bug 29135: Fix handling of deleted items in OAI-PMH provider

Test plan:
1. Make sure this scenario now works properly:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135#c0
2. Run prove -v t/db_dependent/OAI/

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29135] OAI should not include biblionumbers from deleteditems when determining deletedbiblios

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29135

--- Comment #15 from David Nind  ---
8-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (koha-testing-docker):

1. Check that LoadSearchHistoryToTheFirstLoggedUser is not working as expected
when set to 'Don't add':
   a. Set LoadSearchHistoryToTheFirstLoggedUser to 'Add'
   b. In the OPAC make sure you are logged out
   c. Perform some searches
   d. Check search history is recorded by selecting "Search history" in the
top-right navigation menu
   e. Log in as a user
   f. Check search history recorded (From the top-right navigation menu select
Welcome, [username] > Search history)
   g. Search history should be populated with searches from when not logged in
   h. Select all then select 'Remove selected searches'
   i. Change LoadSearchHistoryToTheFirstLoggedUser to 'Don't add'
   j. Repeat from b-g
   k. Search history will still be shown, even though it should be empty
2. Check database to see what value is recorded:
   a. koha-mysql kohadev
   b. SQL query: select * from systempreferences where
variable='LoadSearchHistoryToTheFirstLoggedUser';
   c. When LoadSearchHistoryToTheFirstLoggedUser is set to 'Don't add' value =
"no" 
3. Apply the patch.
4. Update the database (updatedatabase) and restart services (restart_all)
5. Check value in database again from step 2 - value should now be 0
6. Repeat the steps from 1 - this time it should work as expected, that is:
   . When LoadSearchHistoryToTheFirstLoggedUser is set to 'Don't add'
   . Search history should be empty when you log in
7. Sign-off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

David Nind  changed:

   What|Removed |Added

 Attachment #125462|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 125717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125717=edit
Bug 29138: Use zero instead of no in LoadSearchHistoryToTheFirstLoggedUser

To test:
- apply patch
- set LoadSearchHistoryToTheFirstLoggedUser to 'Don't add'
- confirm via sql that value=0
- confirm on OPAC that search history is not loaded to account on login

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29138] LoadSearchHistoryToTheFirstLoggedUser should save 0 instead of "no"

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29138

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

--- Comment #14 from David Cook  ---
I'm not sure what I think about "Legal name" in this context. 

I suppose if there are any cases where they have something other than their
legal name in first name when also using a preferred name it just becomes a
data problem which can be fixed...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #7 from David Nind  ---
Testing notes (koha-testing-docker):

- Test plan was to apply patch and run tests
- Hopefully that is sufficient

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

David Nind  changed:

   What|Removed |Added

 Attachment #125412|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 125716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125716=edit
Bug 27173: Add tests

Test plan:
Run t/db_dependent/Koha/Plugins/authority_hooks.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

David Nind  changed:

   What|Removed |Added

 Attachment #125411|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 125715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125715=edit
Bug 27173: Add plugin hooks for authority record changes

2021-09-28 Updated version

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26234] Default DataTables must know our own classes

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26234

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28349

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26234

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349

--- Comment #2 from Fridolin Somers  ---
I see it is Bug 26234 that removed :
  { "sType": "title-string", "aTargets" : [ "title-string" ] }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27994] Replace obsolete title-string sorting: Reports templates

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27994

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28349

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27994

--- Comment #1 from Fridolin Somers  ---
Looks like it is fixed by Bug 27994

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28019] Script "process_message_queue.pl" no more accepting comma separated addresses

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28019

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #4 from Tomás Cohen Arazi  ---
I found a case of passing --to with multiple addresses to runreports.pl that
stopped working, and might be related.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28019] Script "process_message_queue.pl" no more accepting comma separated addresses

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28019

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29167] New: Patron Search - Data Export

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29167

Bug ID: 29167
   Summary: Patron Search - Data Export
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: Windows
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tgoat...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 125714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125714=edit
Default number does not export all data

A partner library noticed that when exporting data from a patron search
(Address) that the export only exports what is showing in the search results.
Previously when they exported it would export all data without having to select
the "All" from the quantity dropdown.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29166] New: Browse system logs: add itemnumber to search limit

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29166

Bug ID: 29166
   Summary: Browse system logs: add itemnumber to search limit
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wdescha...@prospertx.gov
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

In the Browse System Logs, "Object" limits search to borrowernumber."  It would
be great to also have the option to limit the search to itemnumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29162] Change template structure on OPAC library page so that a single library can easily be hidden

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162

--- Comment #1 from Owen Leonard  ---
Created attachment 125713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125713=edit
Bug 29162: Change template structure on OPAC library page so that a single
library can easily be hidden

This patch adds markup to the OPAC library page so that CSS or JS can
more easily target elements of the page:

- Each library is wrapped in a div, e.g. 
- Classes are added to the paragraphs containing phone, fax, URL, and
  library description.
- An ID has been added to the menu of libraries in the sidebar so that
  they can be targetted individually.

To test, apply the patch and go to Administration -> System prefernces.

- Add some testing CSS to the OPACUserCSS system preference, if
  necessary replacing "CPL" with a branchcode in your system:

  div#section_CPL,
  li#menu_CPL {
 font-size: 80%;
  }

- In the OPAC, view the "Libraries" page.
- In the view of all libraries you should see your CSS reflected in the
  section for that library.
- In the individual library view you should see the menu item for that
  library affected by your custom CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29162] Change template structure on OPAC library page so that a single library can easily be hidden

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29162] Change template structure on OPAC library page so that a single library can easily be hidden

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29062] Patron check-in slip repeats data

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

--- Comment #5 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #3)
> This might be hard to find another occurrence.
> But look at this code in SendCirculationAlert
> This should no longer work.

Fixed

> 
> How do you know if there no other occurrences like that one?

according to tools/letters.pl only 
CHECKIN and CHECKINSLIP have the old_issues table, infact, in printslip we
don't even pass the old_issues table, but we send it using the 'loops'
parameter

I added a patch that fixes that call, I could find no others, and we don't
indicate support elsewhere

The sample notices make no use of the old_issues table, so another option would
be to remove it from the options all together

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29062] Patron check-in slip repeats data

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

--- Comment #4 from Nick Clemens  ---
Created attachment 125712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125712=edit
Bug 29062: (follow-up) Adjust SendCirculationAlert

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29062] Patron check-in slip repeats data

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

Owen Leonard  changed:

   What|Removed |Added

 Attachment #123535|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 125711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125711=edit
Bug 28816: Improve the display of multiple holds during hold process

This patch updates the appearance of the "confirm holds" page, shown
during the process of placing a hold for someone in the staff interface.

Most of the changes affect the appearance of the page when placing
multiple holds on titles which have one or more holds on them already.

The changes are intended to make the page clearer and easier to scan,
especially when placing multiple holds at once.

Also changed: The page heading when placing multiple holds now changes
based on whether you've selected a patron or not. It says "Search
patrons or clubs" when it's waiting for a patron/club selection. It says
"Place holds" after the patron/club has been selected. This is instead
of "Confirm holds" on both pages.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> System preferences and set HoldsSplitQueue to
  "nothing."
- Perform a search in the staff client catalog and place multiple holds
  titles from that result set on hold for a patron.
- Perform the same search and select one or more of the titles you
  selected before in addition to one or more titles with no holds.
- After clicking the "Place hold" button you should see a page with the
  heading "Search patrons or clubs" showing information about existing
  holds. This section of the page should be clear and readable, with
  clear distinction between each section of information about each hold.
- Test this page again under each different option for the
  "HoldsSplitQueue" system preference by changing the preference and
  reloading the page.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

--- Comment #6 from Owen Leonard  ---
Created attachment 125710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125710=edit
Bug 28982: (follow-up) Ensure that date format is correctly checked

This patch modifies the global calendar include so that it doesn't use
the potentially-undefined template variable "dateformat."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734

--- Comment #22 from Joonas Kylmälä  ---
(In reply to Jonathan Druart from comment #17)
> 1.
> -use Koha::AuthorisedValueCategories;
> -use Koha::AuthorisedValues;
> +use Koha::AuthorisedValueCategory;
> +use Koha::AuthorisedValue;
> 
> Joonas, Aleisha was correct. We load the plurals modules, which will load
> the singulars.

Oh, I didn't know this was the preferred way, we could add it maybe to the
coding guidelines? To me it seemed more logical to always import directly the
modules we are using and not trust that the other module will do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Nick Clemens  ---
If i add a new item, defining several languages on the initial save then the
code is set as NULL for all entries

Adding a second does the same and they are all grouped as a single entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24698] UNIMARC authorities leader plugin

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24698

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Joonas Kylmälä  ---
(In reply to George Veranis from comment #16)
> No it is not allowed base ifla instructions you are right. I forgot to
> delete it.

Could you please send a follow-up for that and sign-off the ones I did? (even
though they are pretty trivial – but many in count).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28963] Use Flatpickr on calendar page

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

--- Comment #3 from Owen Leonard  ---
Created attachment 125709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125709=edit
Bug 28963: Use Flatpickr on calendar page

This patch replaces the use of jQueryUI's datepicker widget on the
Calendar page.

In order to ease customization of the static calendar which shows the
current calendar, I've converted the calendar.css file to SCSS. This
allows us to define new SCSS variables to pass to the Flatpickr SCSS.

Also changed: Removed some unecessary comments in the template.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Tools -> Calendar.
- Confirm that entering holidays works correctly for all types: Single,
  weekly, yearly, ranges, repeated ranges.
- Confirm that holidays are deleted as expected.
- Confirm that the colors of each type of holiday is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28963] Use Flatpickr on calendar page

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29165] New: Allow patron modification request notifications to be branch specific

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29165

Bug ID: 29165
   Summary: Allow patron modification request notifications to be
branch specific
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When a patron makes request via the OPAC to change some of their patron details
librarians get a notification on the staff main page about the request.

Some multi-branch systems find this confusing because they see all the requests
across all the branches. It would be nice if this were filtered to only the
current logged in branch. 

But maybe some libraries like the current behavior, so maybe this could be a
system pref?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

--- Comment #4 from Owen Leonard  ---
Created attachment 125708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125708=edit
Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled

This patch adds a missing check for the BakerTaylorEnabled system
preference in staff interface search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

--- Comment #3 from Caroline Cyr La Rose  ---
I think superlibrarians should be able to see all background jobs.

As for other users, could it be a permission? The other links in the
Administration page or Tools page are all linked to permissions.

We could maybe emulate the items_batchmod and items_batchmod_restricted
permissions?

background_jobs : access to all background jobs

background_jobs_restricted : access to background jobs limited to jobs started
by user

? 

I'm not sure what appears in that page and what are the implications of having
access to it (I don't even remember in what context I had to have access to it
when I wrote this bug lol!). Can we stop background jobs from there? If that is
the case, should we also have a permission to stop jobs? Or is that ability
implied when having access to the page?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #106 from Tomás Cohen Arazi  ---
Created attachment 125707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125707=edit
Bug 27945: Fix error handling and translatability

This patch adds better error handling and reporting when placing an
article request fails. It also makes the error messages translatable.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #105 from Tomás Cohen Arazi  ---
Created attachment 125706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125706=edit
Bug 27945: Implement limits using circulation rules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #104 from Tomás Cohen Arazi  ---
Created attachment 125705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125705=edit
Bug 27945: Add max_daily_article_requests circulation rule

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #103 from Tomás Cohen Arazi  ---
Created attachment 125704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125704=edit
Bug 27945: Clarify 'same day' behavior

This patch introduces tests for the 'same day' check of the ability to
place article requests for a patron.

The limit goes against current requests, and those that have been
completed on the same day. The tests cover this specific situation.

The current behavior is that it takes into account a 24 hr timespan, but
consensus on the QA step was that we should do it as 'same day' and use
a separate feature request to change this, if required.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #102 from Tomás Cohen Arazi  ---
Created attachment 125703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125703=edit
Bug 27945: Add limit article request feature

This patch makes it possible to limit article requests per patron per day.

To test:
1. Apply patches
2. updatedatabase
3. Enable ArticleRequests preference
4. Edit a patron category and set an article request limit to 1
CHECK => if you set the limit to anything else but a positive number or empty
string, a warning appears
5. In staff search biblios and request an article for a patron of the modified
category
6. Repeat step 5
SUCCESS => if limit is reached, when you select the user to request an article
a warning appears saying that the limit was reached
7. Repeat steps 5 and 6 but this time in opac
SUCCESS => Patron is not allowed to request another article if limit is reached
8. prove t/db_dependent/ArticleRequests.t

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Marcel de Rooy 

Edit: This patchset originally changed the 'categories' table structure
and relied on that for limit calculation. I removed all that code and
squashed into this one, as we moved everything to the circulation_rules
table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #101 from Tomás Cohen Arazi  ---
Created attachment 125702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125702=edit
Bug 27945: Add tests

Signed-off-by: David Nind 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125150|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125149|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125148|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125147|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125146|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125145|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125144|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125143|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125142|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125140|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125571|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125178|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125690|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125638|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125179|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #125569|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

--- Comment #15 from Nick Clemens  ---
Created attachment 125701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125701=edit
Bug 27138: Import needed subroutines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

--- Comment #14 from Nick Clemens  ---
Created attachment 125700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125700=edit
Bug 27138: Add preference EmbedHostItemsInSearchEngine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

--- Comment #13 from Nick Clemens  ---
Created attachment 125699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125699=edit
Bug 27138: (follow-up) Embed host items when performing index from command line

The previous patch made sure host items were embedded when indexes were
performed inside of Koha (catalg edits, checkins, etc.) but did not affect a
command line reindex

To test:
0 - Follow previous test plan to setup records and set search engine to
elasticsearch
1 - perl misc/search_tools/rebuild_elasticsearch.pl -d
2 - Search for the barcode and confirm both records are returned
3 - Confirm the host items are included in the results

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Michael Sutherland 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Nick Clemens  changed:

   What|Removed |Added

 Attachment #117346|0   |1
is obsolete||
 Attachment #117347|0   |1
is obsolete||
 Attachment #122035|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 125698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125698=edit
Bug 27138: Index host items in child records when sending to search engine

On the Koha side we seperate the items from the MARC record but we do put them
in
the search engines

For easy analytics we embed host items when displaying results after fetching
from the search engine

We can simpify things and improve results by including the host items when
indexing

To test:
 1 - Enable EasyAnalyticalRecords
 2 - Find a record in the staff client
 3 - From details page select Edit->Link to host record
 4 - Attach a barcode from a different record
 5 - Search for that barcode in the staff client
 6 - Only host record is returned
 7 - Perform a search that returns the child record and others
 8 - Note the host item is listed on the child record in the results page
 9 - Repeat on OPAC
10 - Note on opac that host item is missing on results
11 - Apply patch
12 - Search for barcode
13 - Child and host record returned on both staff and OPAC
14 - Child record correctly includes host item on staff and OPAC
15 - Connect to the Z3950 responder or zebra directly
 yaz-client localhost:2100
 yaz-client unix:/var/run/koha/kohadev/bibliosocket
16 - Search for the child record
 base biblios
 find record_keyword
 show 1+10
17 - Note the record includes the host item
18 - Repeat tests for Elasticsearch

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Michael Sutherland 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29164] New: MARC21: Result page display empty Square brackets when 711 $e is filed

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29164

Bug ID: 29164
   Summary: MARC21: Result page display empty Square brackets when
711 $e is filed
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: PC
OS: Linux
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marion.dur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 125697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125697=edit
An instance of the bug

In the results page of search the catalog (both in the opac and the staff
interface), I notice a stage behavior for field 711.
When $e is filed koha display square bracket even when there is nothing inside
($j and $4 are empty)

Example:
711 $aMostly Mozart Festival $eOrchestra
result:
Orchestra Mostly Mozart Festival [].

behavior check on master 21.05

Test plan:
1- Be sure to use koha with MARC21
2- Find or create a record with a 711 $e field but no 711 $j and no 711 $4
3- Search the catalog for your record (be sure to have more than one result)
4- On the results page see that empty square bracket are displayed after 711
field

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #125695|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  ---
Created attachment 125696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125696=edit
Bug 29113: Hide code for additional contents and generate it

additional_contents.code is used to group DB rows together. Each row
represent one content in a given language, and the code is used to know
they are translation of the lang='default' one.

It's not really useful for the end user and we could hide it and
generate it.

Test plan:
Create/Edit/Delete additional contents (news and HTML customizations)
and confirm that they are correctly grouped together.
You need several languages installed to test this patch correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #2 from Jonathan Druart  ---
I haven't done it in the first iteration because it's a bit tricky.

A user who enqueued a job should be able to access to page, and view their
jobs.

Should we have the view available for any staff users? Only those with admin
access?

Otherwise we need to list the permissions of the different pages that allow
background jobs. But I don't like this solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12561] Remove non-XSLT views

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate,|
   |RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28421] Add tests for Voided Payment and Voided Writeoff.

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28421

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28261] Add visual feedback on overridden pickup locations on patron's page

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate,|
   |RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24975] Refactor database translations

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate,|
   |RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_11_candidate
 CC||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

--- Comment #6 from Jonathan Druart  ---
Created attachment 125695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125695=edit
Bug 29113: Hide code for additional contents and generate it

additional_contents.code is used to group DB rows together. Each row
represent one content in a given language, and the code is used to know
they are translation of the lang='default' one.

It's not really useful for the end user and we could hide it and
generate it.

Test plan:
Create/Edit/Delete additional contents (news and HTML customizations)
and confirm that they are correctly grouped together.
You need several languages installed to test this patch correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29113] Required new "code" field for additional contents appears unnecessary

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on opac-detail.tt

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #125693|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  ---
Created attachment 125694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125694=edit
Bug 29128: Remove the other whitespace in browse shelf link

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on opac-detail.tt

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #12 from Jonathan Druart  ---
Adjusted patch's author, as agreed with Jeremy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29128] Trailing whitespace in Browse shelf link on opac-detail.tt

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #125484|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  ---
Created attachment 125693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125693=edit
Bug 29128: Remove the other whitespace in browse shelf link

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #5 from Jonathan Druart  ---
Question (not related only to this patch, but other flatpickr ones as well):
Why don't you set the flatpickrto class when needed?

For instance:

+var billingdatefrom = $("#billingdatefrom").flatpickr({
+onClose: function( selectedDates, dateText, instance) {
+validate_date( selectedDates, instance );
+billingdateto.set('minDate', selectedDates[0]);
+}
+});
+var billingdateto = $("#billingdateto").flatpickr({
+onClose: function( selectedDates, dateText, instance) {
+validate_date( selectedDates, instance );
+},
+});

You need billingdatefrom, but you could use .flatpickrto for #billintdateto.

Also I think we could improve it a bit more, .flatpickrfrom could have a data
containing the name of its "to".

We could only have:

  

  

And a couple of line in calendar.inc to link them.

I won't ofc block this patch series for that, but it would be great to have a
follow-up bug on top to clean it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29163] New: Lost items should optionally be excluded from automatic renewals

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29163

Bug ID: 29163
   Summary: Lost items should optionally be excluded from
automatic renewals
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If an item cannot be renewed for some time (there is a hold) and it remains
checkout out until it is lost, when the blocking status is removed (hold is
filled or cancelled) the item could be renewed again

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29162] New: Change template structure on OPAC library page so that a single library can easily be hidden

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29162

Bug ID: 29162
   Summary: Change template structure on OPAC library page so that
a single library can easily be hidden
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

At the moment the structur of the OPAC libraries page doesn't allow to change
the information of one library easily or to hide one library using an id or
similar as there is no "wrapping" HTML element for each entry.

It would be nice if a div or span could be added around each library element +
hr.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28720] Update the process of adding a checkout note in the OPAC

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28720

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #9 from Jonathan Druart  ---
Shouldn't the input in the modal have the focus?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #13 from Jonathan Druart  ---
Regression found: if you are using the patron search in the header, the search
is not triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||29154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154
[Bug 29154] Add hold cancellation reason to Holds Awaiting Pickup page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29154] Add hold cancellation reason to Holds Awaiting Pickup page

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on||25534


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534
[Bug 25534] Add ability to specifying and store a reason when cancelling a hold
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29154] Add hold cancellation reason to Holds Awaiting Pickup page

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #1 from Andrew Fuerste-Henry  ---
Agreed, that's an unfortunate oversight.
Right now, cancelling a hold from the bib record pops up a modal that asks for
a reason. On the other hand, if you're cancelling from the patron record you're
given a dropdown with which to pick a reason before clicking cancel. Which
option do you think would be more helpful here?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26949] Upgrade TinyMCE in the staff interface from 5.0.16 to 5.9.2

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26949

--- Comment #10 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #9)
> No problems spotted, can you please add my sign-offs as well? :)

Remote branch updated to add Katrin's signoff. Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28692] Reduce DB action_log table size

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692

Peter Vashchuk  changed:

   What|Removed |Added

 Attachment #122782|0   |1
is obsolete||

--- Comment #9 from Peter Vashchuk  ---
Created attachment 125692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125692=edit
Bug 28692: log without indentation to decrease DB action_log table size

Indentation symbols like spaces and newlines take up a large amount of
extra space. Example: fully indented action_log item MODIFY record
weighs from 1.6 to 370 KB while the version of it without any
indentation takes 1.1 to 46 KB accordingly.

This changes logaction subroutine to perform a special transformation,
if$info came as known object, that adds Indent(0) parameter of
Data::Dumper to output without indentation.

To reproduce for item:
1) edit any item you see fit, save it.
2) check the action_logs table and find there a newly created MODIFY
item row, "info" column of that contains dumped data, see that it has
indentation, optional: check and note about the size of it.
3) apply the patch.
4) edit that item again and save it afterwards.
5) "info" column of the newly created row should contain non-indented
text now. If you did check the size of the previous dump, compare it
with this new one, check the difference it makes.

To reproduce for hold:
1) in syspref set HoldsLog to Log.
1) go to the biblio page and suspend and resume any hold you see fit.
2) check the action_logs table and find there a newly created SUSPEND
item row, "info" column of that contains dumped data, see that it has
indentation, optional: check and note about the size of it.
3) apply the patch.
4) edit that item again and save it afterwards.
5) "info" column of the newly created row should contain non-indented
text now. If you did check the size of the previous dump, compare it
with this new one, check the difference it makes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28692] Reduce DB action_log table size

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692

Peter Vashchuk  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #19 from Jonathan Druart  ---
Same as bug 29084 comment 8. I don't think we need
$patron->article_requests_finished, callers can
$patron->article_requests->filter_by_finished (or ->finished as the filter_by
methods are not correctly named in this module).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29082] Add filtering methods to Koha::ArticleRequests

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29082

--- Comment #12 from Jonathan Druart  ---
Created attachment 125691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125691=edit
Bug 29082: Simplify tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #100 from Jonathan Druart  ---
Why is it a category's attribute and not a circ rule?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >