[Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 David Cook changed: What|Removed |Added Blocks||27961 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27961 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961 [Bug 27961] External track clicks links should get uri filtered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27961] External track clicks links should get uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961 David Cook changed: What|Removed |Added Depends on||24699 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24699 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 [Bug 24699] Split items.uri on OPAC detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27961 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27961] External track clicks links should get uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27961 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24699 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114
--- Comment #6 from Fridolin Somers ---
PS :
In the future, we may make this trim inside
Koha::Items->find({barcode => $barcode})
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 --- Comment #5 from Fridolin Somers --- (In reply to Fridolin Somers from comment #2) > A agree 100%, but I think we should trim also trailing whitespaces, like in > check-out : > https://git.koha-community.org/Koha-community/Koha/src/commit/ > 870e3e8e161f6da998c1deae216d7fdf0d0490e7/circ/circulation.pl#L159 Super, it is in patch : +$barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace We should add "trailing" to bug description, release notes and commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27884] Add html mail support for email report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Nind changed: What|Removed |Added Attachment #124891|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 125756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125756=edit Bug 27884: Add tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27884] Add html mail support for email report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Nind changed: What|Removed |Added Attachment #124890|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 125755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125755=edit Bug 27884: Add html support for report mails To test: 1) Create a new notice, for example with Koha module "Patrons", name/code TEST and message body "testing". 2) Create a new sql report, the query could be someting like: SELECT "" as `borrowernumber`, "t...@example.com", as `email`, "f...@example.com" as `from`; where "" is a valid borrowernumber. 3) Run patron_emailer.pl --report= --notice=TEST --module=members -commit where is the report id. 4) Check the message_queue table that the content_type column has been set to text/html; charset="UTF-8". 5) Ideally process the message queue and veriy that the sent email is displayed as rendered html. 6) Run tests in t/db_dependent/Reports/Guided.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27884] Add html mail support for email report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27884 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172
David Nind changed:
What|Removed |Added
Attachment #125731|0 |1
is obsolete||
--- Comment #2 from David Nind ---
Created attachment 125754
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125754=edit
Bug 29172: Make CustomCoverImagesURL compatible with control fields
Bug 22445 added CustomCoverImagesURL that deals with MARC fields, but
control fields were not supported.
Test plan:
Turn CustomCoverImages on
Fill CustomCoverImagesURL with
https://covers.openlibrary.org/b/isbn/{006}-M.jpg
Add an isbn in 006 (0596001738 will work)
Go to the detail page of the bibliographic record and confirm that you
see a cover image.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes an issue where release notes||barcodes with white spaces ||at the beginning could not ||be added to a list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Attachment #125752|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 125753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125753=edit Bug 29114: Trim whitespace before the barcode The solution was to add regexp that trims all whitespaces. How to test: 1. Go to the koha/virtualshelves/shelves.pl; 2. Add new list or edit existing one; 3. Start adding new items; 4. In the "Barcode" field add barcode(s) with whitespaces before them; 5. Observe that it wasn't added as the barcode isn't recognized because of whitespaces; 6. Apply the patch; 7. Repeat step 4; 8. Observe that the item was successfully added; Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] finishreceive: Replace , by ;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- I laughed when I read the original name, but now I'm curious how you even noticed this one. Perl critic? I didn't even know until today that you could use a comma to put multiple calls into one single statement... at least not in this way I guess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #2 from Katrin Fischer --- Hm, I suggest AllowOpacHolds - but yes, took me ages to remember that one... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 Andrii Veremeienko changed: What|Removed |Added Attachment #125369|0 |1 is obsolete|| --- Comment #3 from Andrii Veremeienko --- Created attachment 125752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125752=edit Bug 29114: Trim whitespace before the barcode The solution was to add regexp that trims all whitespaces. How to test: 1. Go to the koha/virtualshelves/shelves.pl; 2. Add new list or edit existing one; 3. Start adding new items; 4. In the "Barcode" field add barcode(s) with whitespaces before them; 5. Observe that it wasn't added as the barcode isn't recognized because of whitespaces; 6. Apply the patch; 7. Repeat step 4; 8. Observe that the item was successfully added; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 David Nind changed: What|Removed |Added Attachment #125746|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 125751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125751=edit Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29181] New: Allow patron card creator to use a report to get list of borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29181 Bug ID: 29181 Summary: Allow patron card creator to use a report to get list of borrowers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: ch...@bigballofwax.co.nz QA Contact: testo...@bugs.koha-community.org Allow the list of borrowers to be created dynamically from a report. So that there is not the need to run the report, and then try to cut and paste a big list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29178] Any users can delete a background job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29178 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- You mean adding : if ( $job->borrowernumber eq $loggedinuser ) But we could argue that any staff user with 'manage_background_jobs' permission should be able to cancel a job, no ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 --- Comment #5 from Fridolin Somers --- I reproduce this bug on our demo actually 20.11.09 : https://intranet-demo.biblibre.com/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 --- Comment #26 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #24) > I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected > but I failed to understand what's going on. > This was very weird right! Glad it wasn't just an odd bug happening for me. > > (In reply to Joonas Kylmälä from comment #22) > > (In reply to Jonathan Druart from comment #17) Thanks both! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] finishreceive: Replace , by ;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #3 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #2) > Taking the liberty to pass this thru QA myself :) How dare you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #1 from Owen Leonard --- (In reply to Nick Clemens from comment #0) > Possibly, 'AllowHoldsOnOpac'? +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29179] Useless include in moveitem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29179 Owen Leonard changed: What|Removed |Added Attachment #125747|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 125750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125750=edit Bug 29179: Remove useless includes in moveitem.pl This patch moves a trivially unneeded set of includes from this file. To test: 1. Apply the patch 2. Try attaching an item to another biblio => SUCCESS: Things work as expected! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29179] Useless include in moveitem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29179 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29062] Patron check-in slip repeats data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 Nick Clemens changed: What|Removed |Added Attachment #125712|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 125749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125749=edit Bug 29062: (follow-up) Adjust SendCirculationAlert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29062] Patron check-in slip repeats data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2334] noOPACHolds syspref unused, superceded by RequestOnOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2334 Martin Renvoize changed: What|Removed |Added Target Milestone|Oldversions |--- Nick Clemens changed: What|Removed |Added Blocks||29180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 [Bug 29180] System preference RequestOnOpac should be renamed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Nick Clemens changed: What|Removed |Added Depends on||2334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2334 [Bug 2334] noOPACHolds syspref unused, superceded by RequestOnOpac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29180] New: System preference RequestOnOpac should be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Bug ID: 29180 Summary: System preference RequestOnOpac should be renamed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com It is a confusing name because we have 'Article Request' as a feature, and this does not follow Koha terminology Possibly, 'AllowHoldsOnOpac'? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Tomás Cohen Arazi changed: What|Removed |Added Attachment #123212|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 125748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125748=edit Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769 Tomás Cohen Arazi changed: What|Removed |Added Keywords||release-notes-needed CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- This is a trivial change, *but* it needs to be advertised because it might break custom cataloguing plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29179] Useless include in moveitem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29179 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 125747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125747=edit Bug 29179: Remove useless includes in moveitem.pl This patch moves a trivially unneeded set of includes from this file. To test: 1. Apply the patch 2. Try attaching an item to another biblio => SUCCESS: Things work as expected! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29179] Useless include in moveitem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29179 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 --- Comment #3 from Owen Leonard --- Created attachment 125746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125746=edit Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29179] Useless include in moveitem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29179 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29179] New: Useless include in moveitem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29179 Bug ID: 29179 Summary: Useless include in moveitem.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org This includes are not used anymore: use C4::Context; use C4::ClassSource; use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder/; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Owen Leonard changed: What|Removed |Added Blocks||29112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 [Bug 29112] Module navigation sidebars in staff now show bullet points -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29112] Module navigation sidebars in staff now show bullet points
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29112 Owen Leonard changed: What|Removed |Added Depends on||27873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29176] Additional LOC Classifications Should Display on a Newline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29176 --- Comment #3 from Eliana --- (In reply to Owen Leonard from comment #2) > Created attachment 125745 [details] > Screenshot showing a customized display with Bug 27613 > > This is what it would look like if you added custom CSS separating the tags. > Otherwise the pipe character would appear where the ♦ is. Thank you so much, that's exactly what I was looking for! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29176] Additional LOC Classifications Should Display on a Newline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29176 --- Comment #2 from Owen Leonard --- Created attachment 125745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125745=edit Screenshot showing a customized display with Bug 27613 This is what it would look like if you added custom CSS separating the tags. Otherwise the pipe character would appear where the ♦ is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass changed: What|Removed |Added Attachment #123198|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass changed: What|Removed |Added Attachment #125708|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 125744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125744=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #5 from Lucas Gass --- Created attachment 125743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125743=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Make BakerTaylorEnabled preference separate for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard changed: What|Removed |Added CC||eli...@flo.org --- Comment #8 from Owen Leonard --- *** Bug 29176 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29176] Additional LOC Classifications Should Display on a Newline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29176 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- I'm going to mark this a duplicate of Bug 27613 because the patch for that bug makes improvements which I think are the correct solution for this bug report. *** This bug has been marked as a duplicate of bug 27613 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613
--- Comment #7 from Owen Leonard ---
Created attachment 125742
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125742=edit
Bug 27613: (follow-up) Modify additional repeating entries for consistency
This patch makes further changes to the detail and results XSLT in the
OPAC so that previously pipe-separated fields are styled with CSS. The
following tags are modified on the detail page:
020 ISBN
022 ISSN
050 LOC classification
060 NLM classification
082 DDC classification
084 Other classification
130/240/730 Uniform titles
246 Other title
336 Content type
337 Media type
338 Carrier type
385 Audience
508 Production credits
583 Action note
586 Awards
655 Genre/Form
700/710/711 Contained works
700/710/711 Related works
770 Supplement
772 Supplement to
856 Online resources
These are modified on the results page:
028 Publisher number
246 Other title
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
In order to better see the effect of the CSS change you can add
something ike this to your OPACUserCSS system preference:
.resource_list li::after {
content: "♦";
}
View catalog search results and detail pages for records which contain
repeated entries from the tag list above. The entries should be
separated by "|" without customization, or the symbol from your
OPACUserCSS if you specified one.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What|Removed |Added Blocks||29178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29178 [Bug 29178] Any users can delete a background job -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29178] Any users can delete a background job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29178 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_11_candidate Depends on||22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29178] New: Any users can delete a background job
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29178
Bug ID: 29178
Summary: Any users can delete a background job
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
64 if ( my $job = Koha::BackgroundJobs->find($id) ) { # FIXME Make sure
logged in user can cancel this job
65 $job->cancel;
66 }
This FIXME must be fixed ASAP.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020
--- Comment #5 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #4)
> > Can we stop background jobs from there?
>
> Yes, you can cancel a job, but only those you started (or you have the
> manage_background_jobs permission).
This is the theory, the code is wrong!
64 if ( my $job = Koha::BackgroundJobs->find($id) ) { # FIXME Make sure
logged in user can cancel this job
65 $job->cancel;
66 }
will fix separately.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020 --- Comment #4 from Jonathan Druart --- Tools that allow you to batch delete/edit/create will use the "background jobs" (also "task queue" sometimes) feature in a near (hopefully) future. The goal is to process the job when the server can do it (and to not block the user, the job is enqueued and they don't need to care about it). So any users with access to those tools (listed is short now, but will be extended later, even to plugins certainly) should have access to the list of jobs THEY enqueued (at the minimum). I don't think it should be a permission, neither it should be linked to the permissions of the tools using the task queue (it's a list that we will need to keep up-to-date, and it will be tricky when it will be extended to plugins). > Can we stop background jobs from there? Yes, you can cancel a job, but only those you started (or you have the manage_background_jobs permission). I am in favor of displaying a link to that page for any users with access to the staff interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 --- Comment #108 from Tomás Cohen Arazi --- Created attachment 125741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125741=edit Bug 27945: Terminology: max daily => open requests limit Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #67 from Tomás Cohen Arazi --- Created attachment 125740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125740=edit Bug 27947: (QA follow-up) Fix shipped notice Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #66 from Tomás Cohen Arazi --- Created attachment 125739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125739=edit Bug 27947: (QA follow-up) Make parameters a hashref This patch makes the Koha::ArticleRequest->cancel parameters into a hashref. (Missing) tests are added for those parameters being set as well. Calls to ->cancel are updated. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t \ t/db_dependent/api/v1/article_requests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #383 from David Gustafsson --- > > 6. How does it interface with the marc modification templates when batch > > editing bibliographic records? > > Investigating.. I have a feeling his patchset predates it and I missed this > case ! :( Sorry, never got around to have a look at this yesterday, but now did. From what I can gather from the code I'm pretty sure that if no rules have been defined for the batchmod context, the incoming record simply overwrites the existing record. If there are rules, these are applied on the record after the record has been modified using the specified template. So if the modification template modifies some protected field for example, these changes will not be applied. This is expected behavior as far as I can tell? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29177] Remove TODO in acqui/finishreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- So trivial that I am signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29177] Remove TODO in acqui/finishreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | --- Comment #2 from Marcel de Rooy --- Martin, did you have this in mind ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29177] Remove TODO in acqui/finishreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 --- Comment #1 from Marcel de Rooy --- Created attachment 125738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125738=edit Bug 29177: Remove TODO in acqui/finishreceive Replacing a multiple object->column(value) by ->update. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29177] Remove TODO in acqui/finishreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29177] New: Remove TODO in acqui/finishreceive.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29177 Bug ID: 29177 Summary: Remove TODO in acqui/finishreceive.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Trivial edit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8417] date acquired is shipping date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Jonathan Druart changed: What|Removed |Added Blocks||29175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 [Bug 29175] finishreceive: Replace , by ; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] finishreceive: Replace , by ;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Jonathan Druart changed: What|Removed |Added Depends on||8417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 [Bug 8417] date acquired is shipping date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29176] New: Additional LOC Classifications Should Display on a Newline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29176 Bug ID: 29176 Summary: Additional LOC Classifications Should Display on a Newline Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: eli...@flo.org QA Contact: testo...@bugs.koha-community.org Created attachment 125737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125737=edit LOC Classification in OPAC When a title has multiple LOC classifications they appear smooshed together with no spaces in both the staff client and OPAC. If there are multiple classifications then additional ones should appear on a newline for legibility's sake. Another option would be to use the pipe character to separate additional classifications, similar to how subject headings appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] finishreceive: Replace , by ;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Marcel de Rooy changed: What|Removed |Added Summary|My shortest patch? |finishreceive: Replace , by ||; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] My shortest patch?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] My shortest patch?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] My shortest patch?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Taking the liberty to pass this thru QA myself :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] My shortest patch?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] My shortest patch?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 --- Comment #1 from Marcel de Rooy --- Created attachment 125736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125736=edit Bug 29175: finishreceive: Replace , by ; This certainly is one of my shortest fixes ever ;) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] My shortest patch?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29175] New: My shortest patch?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29175 Bug ID: 29175 Summary: My shortest patch? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Hang on -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29174] Availability colors are not consistent in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29174 --- Comment #1 from Marcel de Rooy --- Please help to make Koha an even greener place ! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29174] New: Availability colors are not consistent in the codebase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29174 Bug ID: 29174 Summary: Availability colors are not consistent in the codebase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org OPAC Results has three blocks: Available for loan, Available for reference (a subset of some not for loan categories, see pref Reference_NFL_Statuses and Not available (some not for loans, checked out, damaged, etc) The not available group is RED, the two available groups are GREEN. At least talking about opac-search. (And opac-shelves too.) But now we still need to address a few other spots where we use these colors: opac-detail shows the reference items RED! opac-basket does the same. Would you know more code locations? It seems that staff already uses another algorithm to choose for RED. On catalogue detail red is used only for damaged, lost, etc? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142
--- Comment #31 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #27)
> (In reply to Jonathan Druart from comment #25)
> > (In reply to Marcel de Rooy from comment #23)
> > > +my @hold_not_allowed_itypes = Koha::CirculationRules->search(
> > > +{
> > > +rule_name=> 'holdallowed',
> > > +branchcode => undef,
> > > +categorycode => undef,
> > > +rule_value => 'not_allowed',
> > > +}
> > > +)->get_column('itemtype');
> > >
> > > I have my doubts here btw.
> > > This is too simple. You are looking at circ rules with exception for
> > > various
> > > combinations of category, itemtype etc.
> > > You cant just do a get_column here. This depends on context.
> > > Please clarify and add tests.
> >
> > Which context? The logged in branch?
> > Here we are not in C4::Reserves, we don't want to offer all the complexity
> > of CanItemBeReserved. As said previously I am not adding new code of
> > functionality (apart for the additional damaged check).
>
> Ok. If this is a reflection of what we did already, I cant justify to fail
> it :) Koha never fails!
> Back to SO
lol I am feeling your sarcasms, Marcel :)
I will be happy to improve anything you think that may be useful. But keep in
mind that the point here is only to centralize things.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29131] Row striping breaks color coding on item circulation alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 --- Comment #1 from Owen Leonard --- Created attachment 125735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125735=edit Bug 29131: Row striping breaks color coding on item circulation alerts The CSS we use for table row "striping," which uses 'tbody tr:nth-child(odd),' is often difficult to work with because it takes a lot of increased specificity to override the default. Bootstrap compounds this by adding its own similar CSS. In order to overcome this I've added '!important' to the CSS embedded in the item circulation alerts page. I normally would avoid '!important' but since this CSS is only relevant to this page I think it's appropriate. This patch also adds [% FILTER collapse %] around the
[Koha-bugs] [Bug 29131] Row striping breaks color coding on item circulation alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29131 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #30 from Jonathan Druart --- Created attachment 125734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125734=edit Bug 3142: Add note about imprecision of filter_by_for_hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #29 from Jonathan Druart --- Created attachment 125733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125733=edit Bug 3142: Add test for the circ rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Marcel de Rooy changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #28 from Marcel de Rooy --- Will QA this one soon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #27 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #25)
> (In reply to Marcel de Rooy from comment #23)
> > +my @hold_not_allowed_itypes = Koha::CirculationRules->search(
> > +{
> > +rule_name=> 'holdallowed',
> > +branchcode => undef,
> > +categorycode => undef,
> > +rule_value => 'not_allowed',
> > +}
> > +)->get_column('itemtype');
> >
> > I have my doubts here btw.
> > This is too simple. You are looking at circ rules with exception for various
> > combinations of category, itemtype etc.
> > You cant just do a get_column here. This depends on context.
> > Please clarify and add tests.
>
> Which context? The logged in branch?
> Here we are not in C4::Reserves, we don't want to offer all the complexity
> of CanItemBeReserved. As said previously I am not adding new code of
> functionality (apart for the additional damaged check).
Ok. If this is a reflection of what we did already, I cant justify to fail it
:) Koha never fails!
Back to SO
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #26 from Jonathan Druart --- Created attachment 125732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125732=edit Bug 3142: Add tests And fix a bug! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29173] New: Button "replace authority record via Z39/50/SRU" doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Bug ID: 29173 Summary: Button "replace authority record via Z39/50/SRU" doesn't work Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: marion.dur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To replace an authority record via Z39.50/SRU there are two buttons on differents pages but their behaviour is not the same. One pre-fill the search form but the other don't. If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Replace record via Z39.50/SRU" Then: "Z39.50 authority search points" pop up but all field are empty. But If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Edit record" 3- Click on the button "Replace record via Z39.50/SRU search" Then: "Z39.50 authority search points" pop up with usefull values already filled (for example the Author) There is the same two button for bibliographic record and both of them pre-fill the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142
--- Comment #25 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #23)
> +my @hold_not_allowed_itypes = Koha::CirculationRules->search(
> +{
> +rule_name=> 'holdallowed',
> +branchcode => undef,
> +categorycode => undef,
> +rule_value => 'not_allowed',
> +}
> +)->get_column('itemtype');
>
> I have my doubts here btw.
> This is too simple. You are looking at circ rules with exception for various
> combinations of category, itemtype etc.
> You cant just do a get_column here. This depends on context.
> Please clarify and add tests.
Which context? The logged in branch?
Here we are not in C4::Reserves, we don't want to offer all the complexity of
CanItemBeReserved. As said previously I am not adding new code of functionality
(apart for the additional damaged check).
Tests are definitely missing, agreed.
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #24 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > (In reply to Martin Renvoize from comment #21) > > This works well and certainly clarifies the code.. it does need tests still > > though ;) > > If it does, we cant get it further from here? What do you suggest? I didn't get what suggested David in comment 9. The unique ambition of these patches is to reuse an existing method and avoid duplication of code. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172
--- Comment #1 from Jonathan Druart ---
Created attachment 125731
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125731=edit
Bug 29172: Make CustomCoverImagesURL compatible with control fields
Bug 22445 added CustomCoverImagesURL that deals with MARC fields, but
control fields were not supported.
Test plan:
Turn CustomCoverImages on
Fill CustomCoverImagesURL with
https://covers.openlibrary.org/b/isbn/{006}-M.jpg
Add an isbn in 006 (0596001738 will work)
Go to the detail page of the bibliographic record and confirm that you
see a cover image.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #23 from Marcel de Rooy ---
+my @hold_not_allowed_itypes = Koha::CirculationRules->search(
+{
+rule_name=> 'holdallowed',
+branchcode => undef,
+categorycode => undef,
+rule_value => 'not_allowed',
+}
+)->get_column('itemtype');
I have my doubts here btw.
This is too simple. You are looking at circ rules with exception for various
combinations of category, itemtype etc.
You cant just do a get_column here. This depends on context.
Please clarify and add tests.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #22 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #21) > This works well and certainly clarifies the code.. it does need tests still > though ;) If it does, we cant get it further from here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
