[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 QA Contact|tomasco...@gmail.com|m.de.r...@rijksmuseum.nl

--- Comment #16 from Marcel de Rooy  ---
+require C4::Items;

Why? There is a use in the module already.

Formally, we should add 'use Koha::Items' though..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

--- Comment #21 from Martin Renvoize  ---
This works well and certainly clarifies the code.. it does need tests still
though ;)

Whilst I see David's point about on shelf holds, I think we can defer that
piece to a next step in a follow-up bug.

Signing off.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122317|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 125730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125730=edit
Bug 3142: Use filter_by_for_holds where holdability is calculated

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122316|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 125729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125729=edit
Bug 3142: Add itype

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122315|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 125728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125728=edit
Bug 3142: Exclude damaged items

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #122314|0   |1
is obsolete||

--- Comment #17 from Martin Renvoize  ---
Created attachment 125727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125727=edit
Bug 3142: Add itemlost, withdrawn and notforloan

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29062] Patron check-in slip repeats data

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

--- Comment #7 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #6)
> +$issues_id = $item->{itemnumber};
> 
> I am having serious doubts about that change ;)

Especially the way it reads btw. Maybe find a good rename..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29062] Patron check-in slip repeats data

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29062

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Marcel de Rooy  ---
+$issues_id = $item->{itemnumber};

I am having serious doubts about that change ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168

--- Comment #4 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #3)
> Not a lot of cost for the detail view (and we try to do it for holds on this
> view).

True. I had the results view in mind.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the|When a librarian is |When a librarian is
  release notes|cataloguing a bibliographic |cataloguing a bibliographic
   |record and needs a new  |record and needs a new
   |authorised value, they will |authorised value, they will
   |now be able to create it|now be able to create it
   |directly from the edit  |directly from the edit
   |form.
  |form.
   |It also works on the|It also works on the
   |item and authority editing  |item and authority editing
   |forms.
 |forms.
   |They will need the  |They will need the
   |necessary permission:   |necessary permission:
   |manage_authorised_values.   |manage_auth_values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168

--- Comment #3 from Jonathan Druart  ---
Not a lot of cost for the detail view (and we try to do it for holds on this
view).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #4 from David Nind  ---
Patch no longer applies 8-(..

Applying: Bug 29057: Use font awesome icons on request.pl
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #65 from Jonathan Druart  ---
I think there is something wrong with the notice.

From the DBrev:

 28 $dbh->do(q{
 29 UPDATE letter SET content=REPLACE(content,
'<>', '<>')
 30 WHERE module = 'circulation' AND code = 'AR_CANCELED'
 31 });

when the installer file is still using notes

 233 - "Your request for an article from <>
(<>) has been canceled for the following reason:"
 234 - ""
 235 - "<>"

By the way, shouldn't we copy the notes to the cancellation_reason when the
article request has been canceled?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28826] Facet sort order differs between search engines

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

Fridolin Somers  changed:

   What|Removed |Added

 CC||jhann...@nmc.edu

--- Comment #9 from Fridolin Somers  ---
*** Bug 23036 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23036] Optionally order facets by result hits

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23036

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||fridolin.som...@biblibre.co
   ||m
 Status|NEW |RESOLVED

--- Comment #1 from Fridolin Somers  ---


*** This bug has been marked as a duplicate of bug 28826 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28826] Facet sort order differs between search engines

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28826

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
*** Bug 25838 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25838] Sort facets values by number of occurrences (Zebra)

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838

Fridolin Somers  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|In Discussion   |RESOLVED

--- Comment #13 from Fridolin Somers  ---


*** This bug has been marked as a duplicate of bug 28826 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168

--- Comment #2 from Marcel de Rooy  ---
Note that we may not even be able to say if a request is possible. We are doing
sort of intelligent guess now. You have biblio and item level requests. You
depend on multiple circ rules. Etc. It will be too costly to calculate
beforehand?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #1 from Marcel de Rooy  ---
Are we doing the same for holds now? I think we didnt, we only calculated if we
allow when the user clicked further?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29172] Can't use controlfiels with CustomCoverImagesURL

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||29172


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172
[Bug 29172] Can't use controlfiels with CustomCoverImagesURL
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29172] New: Can't use controlfiels with CustomCoverImagesURL

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29172

Bug ID: 29172
   Summary: Can't use controlfiels with CustomCoverImagesURL
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 22445

I've been trying to use the controlnumber from 001 in CustomCoverImagesURL, but
didn't manage to make it work:

{001}
{001$@} - internal server error
{001$}

Mabe it's possible and I don't have the right syntax?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445
[Bug 22445] Ability to define a URL for custom cover images
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445

--- Comment #124 from Katrin Fischer  ---
I did't manage to use 001 - is there a special syntax to use for control
fields?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

--- Comment #107 from Jonathan Druart  ---
Created attachment 125726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125726=edit
Bug 27945: Don't save rule if not defined

The DB rev added a row with NULL (unlimited), and the UI a row with ''
(unlimited as well) when saved without value.

Better is to not have a row (still unlimited)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29171] New: Offline circulation file date due

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29171

Bug ID: 29171
   Summary: Offline circulation file date due
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: igor.a.syc...@mail.ru
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Now the string has the form:
2015-05-27 14:59:13 issue   2382100033  13821000268800

How can I specify the date(date due) in the line when the instance should be
returned?

Converting data from a third-party ILS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29170] New: MARC21 Field 100$t is not display in the results page and record detail page

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29170

Bug ID: 29170
   Summary: MARC21 Field 100$t is not display in the results page
and record detail page
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marion.dur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

In koha MARC21, the field 100$t is not displayed in the results page (neither
in the detailed record page). 

In the code that display 700$t for the results page I found this:
(file: ./koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl)


...

The comment clearly states that the next portion of code should display title
for 700 and 100 fields (field 100$c which is displayed earlier, or field 100$t)
but the code actually only display title for 700 field. (Field 700$t is
correctly displayed.)

Should we add the code to display field 100$t or should we change the comment
so it's more accurate with what the code do ?

To test:
1- Be sure to use koha MARC21
2- Find or create a record that have a field 100$t
3- Search the catalog for this record (be sure to hav at least two results)
4- See that field 100$t is not displayed
5- Click on your record to go to the detail page
6- See that field 100$t is not displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29169
[Bug 29169] Wrong "daily limit" warning when article request is not available
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29169] Wrong "daily limit" warning when article request is not available

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29169

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||27945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29169] New: Wrong "daily limit" warning when article request is not available

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29169

Bug ID: 29169
   Summary: Wrong "daily limit" warning when article request is
not available
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org

If you have reached the daily limit (bug 27945) and article request are not
possible, the error will be "daily limit reached" when it should be "No article
requests can be made for this record"

Step to recreate:
- Turn the syspref "ArticleRequests" on
- Circ rule "Article requests" => No
- "Default article requests limits" for your patron's category => 0

/cgi-bin/koha/opac-request-article.pl?biblionumber=1

=> "You reached your article requests daily limit."

The ELSIF ELSE in opac-request-article.tt need to be improved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27945] Limit the number of active article requests per patron category

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29168


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168
[Bug 29168] Disable "Request article" links when limit is reached
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29168] Disable "Request article" links when limit is reached

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||27945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945
[Bug 27945] Limit the number of active article requests per patron category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29168] New: Disable "Request article" links when limit is reached

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168

Bug ID: 29168
   Summary: Disable "Request article" links when limit is reached
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Since bug 27945 we can limit article request per patron's category. However the
"request article" links (detail and search views) are still active.
We could disable them and add a tooltip.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #125724|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart  ---
Created attachment 125725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125725=edit
Bug 28734: Parse display in $biblio->get_marc_notes

1. Go to Koha Administration, MARC bibliographic frameworks
2. Edit a framework, find tag 590, edit the $z subfield to use an
authorised value.
3. Do a catalogue search and edit a record using this framework. Edit
590$z and select an authorised value. Save the record.
4. Add the record to your cart.
5. View your cart. Click More Details.
6. Scroll down to the Notes section. Notice the authorised value code is
displayed instead of the description.
7. Apply the patch, restart services.
8. Refresh your cart. Click More Details again if you need to.
9. Scroll down to the Notes section. The description of the authorised
value should now be displayed.

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

Signed-off-by: David Nind 

Signed-off-by: Joonas Kylmälä 

Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests

Confirm the following tests pass:
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/XSLT.t

Signed-off-by: David Nind 

Signed-off-by: Joonas Kylmälä 

Bug 28734: (QA follow-up) Fix test imports and readability

Signed-off-by: Joonas Kylmälä 

Bug 28734: (QA follow-up) Update documentation about function usage

We are now using the function from Koha::Biblio.

Signed-off-by: Joonas Kylmälä 

Bug 28734: Remove unadvertised changes

1. Using $frameworkcode instead of the default '' is an unadvertised change.
It would make sense to use $frameworkcode, but actually we must remove this
parameter and always use the default, as we decided to make the default
authoritative.
I would prefer to not introduce this change, just in case..

2. Restore good import (use plurals)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734

--- Comment #24 from Jonathan Druart  ---
I had to reintroduce the C4::Koha prefix for xml_escape. That's not expected
but I failed to understand what's going on.


(In reply to Joonas Kylmälä from comment #22)
> (In reply to Jonathan Druart from comment #17)
> > 1.
> > -use Koha::AuthorisedValueCategories;
> > -use Koha::AuthorisedValues;
> > +use Koha::AuthorisedValueCategory;
> > +use Koha::AuthorisedValue;
> > 
> > Joonas, Aleisha was correct. We load the plurals modules, which will load
> > the singulars.
> 
> Oh, I didn't know this was the preferred way, we could add it maybe to the
> coding guidelines? To me it seemed more logical to always import directly
> the modules we are using and not trust that the other module will do it.

For Koha::Object-based objects, all plurals needs their respective singular.
It avoid to have the 2 use statements.

We could indeed add that to the guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #18 from David Nind  ---
Patch no longer applies 8-(..

Applying: Bug 24370: Don't reset library when editing a suggestion
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 24370: Don't reset library when editing a suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15430] MARC21: Abbreviated names missing ending . in XSLT views

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15430

marion.dur...@biblibre.com changed:

   What|Removed |Added

 CC||marion.dur...@biblibre.com

--- Comment #2 from marion.dur...@biblibre.com ---
I think it is the same bug as Bug 28976 (or at least close to it).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29104] Add dateexpiry column to circulation patron search results

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29104

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #63 from David Nind  ---
Patch no longer applies 8-(..

Applying: Bug 3150: Move emails for sending cart and list contents to notices
Using index info to reconstruct a base tree...
M   basket/sendbasket.pl
M   opac/opac-sendbasket.pl
M   opac/opac-sendshelf.pl
M   virtualshelves/sendshelf.pl
Falling back to patching base and 3-way merge...
Auto-merging virtualshelves/sendshelf.pl
CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl
Auto-merging opac/opac-sendshelf.pl
CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl
Auto-merging opac/opac-sendbasket.pl
CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl
Auto-merging basket/sendbasket.pl
CONFLICT (content): Merge conflict in basket/sendbasket.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 3150: Move emails for sending cart and list contents
to notices
hint: Use 'git am --show-current-patch' to see the failed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #125660|0   |1
is obsolete||
 Attachment #125661|0   |1
is obsolete||
 Attachment #125662|0   |1
is obsolete||
 Attachment #125663|0   |1
is obsolete||
 Attachment #125687|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  ---
Created attachment 125724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125724=edit
Bug 28734: Parse display in $biblio->get_marc_notes

1. Go to Koha Administration, MARC bibliographic frameworks
2. Edit a framework, find tag 590, edit the $z subfield to use an
authorised value.
3. Do a catalogue search and edit a record using this framework. Edit
590$z and select an authorised value. Save the record.
4. Add the record to your cart.
5. View your cart. Click More Details.
6. Scroll down to the Notes section. Notice the authorised value code is
displayed instead of the description.
7. Apply the patch, restart services.
8. Refresh your cart. Click More Details again if you need to.
9. Scroll down to the Notes section. The description of the authorised
value should now be displayed.

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

Signed-off-by: David Nind 

Signed-off-by: Joonas Kylmälä 

Bug 28734: (follow-up) Use transformMARCXML4XSLT and tests

Confirm the following tests pass:
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/XSLT.t

Signed-off-by: David Nind 

Signed-off-by: Joonas Kylmälä 

Bug 28734: (QA follow-up) Fix test imports and readability

Signed-off-by: Joonas Kylmälä 

Bug 28734: (QA follow-up) Update documentation about function usage

We are now using the function from Koha::Biblio.

Signed-off-by: Joonas Kylmälä 

Bug 28734: Remove unadvertised changes

1. Using $frameworkcode instead of the default '' is an unadvertised change.
It would make sense to use $frameworkcode, but actually we must remove this
parameter and always use the default, as we decided to make the default
authoritative.
I would prefer to not introduce this change, just in case..

2. Remove uneeded C4::Koha:: prefix

3. Restore good import (use plurals)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

David Nind  changed:

   What|Removed |Added

 Attachment #125469|0   |1
is obsolete||

--- Comment #34 from David Nind  ---
Created attachment 125723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125723=edit
Bug 27266: (follow-up) Remove get_marc_authors from opac-detail

There's no way to use 'no' XSLT now, so don't need to use this to show
authors on the detail page.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

David Nind  changed:

   What|Removed |Added

 Attachment #125468|0   |1
is obsolete||

--- Comment #33 from David Nind  ---
Created attachment 125722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125722=edit
Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

David Nind  changed:

   What|Removed |Added

 Attachment #125467|0   |1
is obsolete||

--- Comment #32 from David Nind  ---
Created attachment 125721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125721=edit
Bug 27266: (follow-up) Remove instances of GetMarcAuthors

Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

David Nind  changed:

   What|Removed |Added

 Attachment #125466|0   |1
is obsolete||

--- Comment #31 from David Nind  ---
Created attachment 125720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125720=edit
Bug 27266: (QA follow-up) Rename to get_marc_authors

Signed-off-by: Martin Renvoize 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

David Nind  changed:

   What|Removed |Added

 Attachment #125465|0   |1
is obsolete||

--- Comment #30 from David Nind  ---
Created attachment 125719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125719=edit
Bug 27266: Move GetMarcAuthors to Koha namespace

This patch moves C4::Biblio::GetMarcAuthors to
Koha::Biblio->get_authors_from_MARC. This is so the method can be
used in templates and notices.

To test:
1. Find a record that has an author in the added entry field (700-720).
2. Add the record to the cart and a list.
3. View your cart and click 'more details'. Confirm authors show as
normal.
4. Click 'send' and confirm the email sent shows the authors as normal.
5. Go to the list you added the record to and click 'send list'. Confirm
the email sent shows the authors as normal.
xslt)
6. Log in to the OPAC. Find the record and add it to the cart and a list
7. View the cart and click 'more details'. Confirm authors show as
normal.
8. Click 'send' and confirm the email sent shows the authors as normal.
9. Go to the list you added the record to and click 'send list'.
Confirm the email sent shows the authors as normal.
10. Confirm tests pass:
- t/Biblio.t
- t/db_dependent/Koha/Biblio.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=26234   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26234] Default DataTables must know our own classes

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26234

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=28349   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349

--- Comment #4 from Jonathan Druart  ---
(In reply to Fridolin Somers from comment #2)
> I see it is Bug 26234 that removed :
>   { "sType": "title-string", "aTargets" : [ "title-string" ] }

Not related and not a bug, title-string has been moved to columns_settings.inc
(not removed).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #3 from Jonathan Druart  ---
Hi David, that seems to work correctly for me on master, with en-GB and
dateformat=dd/mm/

On which version of Koha do you see that problem? Can you recreate on a
sandbox?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes

2021-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173

--- Comment #8 from Marcel de Rooy  ---
(In reply to David Nind from comment #7)
> Testing notes (koha-testing-docker):
> 
> - Test plan was to apply patch and run tests
> - Hopefully that is sufficient

Thanks David. The test script proves that a plugin on top of this action works.
Which is sufficient.

We have been running a plugin based on this action for a year now in
production. It copies the CREATE UPDATE DELETE actions to an external system
where we try to reconcile authorities from several subsystems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


<    1   2