[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642 Mengu Yazicioglu changed: What|Removed |Added CC||me...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Caroline Cyr La Rose changed: What|Removed |Added CC||mathsaby...@gmail.com --- Comment #78 from Caroline Cyr La Rose --- *** Bug 28791 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28791] make a distinction between public lists in OPAC and staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28791 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |RESOLVED CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |DUPLICATE --- Comment #1 from Caroline Cyr La Rose --- *** This bug has been marked as a duplicate of bug 26346 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- Depends on Bug 28189 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28992] Resolve warning from undefined BIG_LOOP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28992 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28985] Negative rental amounts can be saved but not enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,21.11.11 released in|| --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28985] Negative rental amounts can be saved but not enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.05 released in|| Status|Pushed to master|Pushed to stable CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin Somers --- I see it is in 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Specified due date incorrectly retained when using fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28464] Cancelling a waiting hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| --- Comment #13 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28228] Warns from plugins when metadata value not defined for key
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28228 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28914] Wrong wording in authentication forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #19 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating items where location is null
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to stable|Pushed to oldstable --- Comment #20 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28986] Parent itemtype not selected when editing circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28986 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29171] Offline circulation file date due
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29171 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Igor, for questions about Koha, please use the mailing lists, IRC or one of the other communication channels first - bugzilla is meant to be used to log bugs and enhancement requests. In this case the offline circulation format is limited and doesn't allow for specifying a due date. It's meant to be calculated by Koha at the time of uploading the files. You might be able to achieve your goal by setting the issue date so that the calculation works in your favor. Also see: https://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28845] OpacAddMastheadLibraryPulldown does not respect multibranchlimit in OPAC_SEARCH_LIMIT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28845 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||fridolin.som...@biblibre.co ||m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28676] AutoCreateAuthorities can repeatedly generate authority records when using Default linker and heading is cached
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28676 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28960] EDI transfer_items uses a relationship where it's looking for a field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28960 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29189] New: Expired serial subscriptions still automatically generate issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29189 Bug ID: 29189 Summary: Expired serial subscriptions still automatically generate issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I know this is like a Pandora's box, But I just can't get my head around why expired subscriptions would still generate issues even after the expiry date. To replicate : Create a subscription that would end in the past 1. Search for a record in the staff interface 2. Click on the title to go to the record details page 3. Click on New > New subscription 4. Click Next 5. Fill in the second part of the new subscription form - First issue publication date : enter a date in the past, e.g. 2020-01-01 - Frequency : choose a frequency, e.g. 1/3month - Subscription length : enter a number of issues for the subscription, e.g. 4 - Subscription start date : enter a date on or before your first issue publication date, e.g. 2020-01-01 - Numbering pattern : choose a numbering pattern, e.g. Number - Begins with : enter a number, e.g. 42 6. Click on Test prediction pattern 7. Click Save subscription Receive one issue for this subscription 8. Click Receive 9. Change the status to Arrived 10. Change the Expected on date to something close(r) to the Published on date, e.g. 2020-01-01 11. Click Save Make one issue late 12. Click Generate next Receive the rest of the issues normally 13. Repeat steps 8-11 for all remaining issues -- Once you have received all issues in the subscription, it should say "Subscription expired" in the Serial collection page. -- Note that the next issue was automatically generated even though it's not supposed to be in the subscription Like Katrin said in the chat, I don't think receiving should be completely forbidden in expired subscriptions as there can be late issues that you might receive in the future. And the act of "receiving" is actually editing the issues, so if I need to mark one as "Missing" in the future, I need to be able to do that even when the subscription is expired. But, I don't think additional issues should be generated after the prescribed number of issues/weeks/months in the subscription or after the subscription end date. My problem is rally with the automatic creation of issues. Although I must say, I don't work in a library, so maybe what I'm saying doesn't make sense in a day-to-day serial workflow. But I did receive a question from a client asking why issues were still being generated even after the subscription is expired and I can't find a logical explanation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28946] 500 error when choosing patron for purchase suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Fridolin Somers --- Depends on Bug 23271 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28722] tools/batchMod.pl needs to import C4::Auth::haspermission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28722 Fridolin Somers changed: What|Removed |Added Version(s)||21.11.00,21.05.05 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin Somers --- I see it is in master and 21.05.x Not pushed to 20.11.x since it does not contain Bug 17600 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27895] Internal server error when trying to change pickup location for a hold with no valid locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27895 Katrin Fischer changed: What|Removed |Added Summary|Internal server error when |Internal server error when |trying to change picup |trying to change pickup |location for a hold with no |location for a hold with no |valid locations |valid locations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27173] Add plugin hooks for authority record changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27173 Katrin Fischer changed: What|Removed |Added Keywords||Manual --- Comment #9 from Katrin Fischer --- Please remember to update https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 --- Comment #1 from Owen Leonard --- Created attachment 125849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125849=edit Bug 28453: Update pagination subroutine to generate Bootstrap markup This patch modifies Output.pm to change the HTML it generates when creating pagination bars. The changes allow the pagination menu to be styled like Bootstrap pagination, making them consistent with the pagination on catalog search results. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Test pages where the pagination_bar subroutine is called: - Administration -> Record matching rules. - Authorities -> Authority search results. - Cataloging -> Cataloging search results. - Cataloging -> MARC Editor -> Edit tag which is configured to use the unimarc_field_210c value builder. - Reports -> Saved SQL reports -> Results. - Tools -> Comments. - Lists -> List contents. The pagination bar markup was removed from the templates for these pages because it wasn't being used: - Administration -> Patron attribute types. - Tools -> Tags. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27515] Elasticsearch: search for singular/plural form / stemming
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27515 Margaret Hade changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 125848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125848=edit [21.05.x] Bug 29139: Only pass the offsets for lines the credit was applied to On writing the regression tests, I noticed the CREATE offset was added to the template. The idea behind passing the offsets is that we can print information about the lines that got the credit applied. Having the CREATE offset is meaningless, and (worse) would require users to add logic to skip it. And all the payment information is already passed in the 'credit' variable anyway. This patch filters the credit_offsets by type, leaving the APPLY ones only. To test: 1. Apply up to the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: 3 offsets, including the CREATE one, boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Only the two APPLY offsets are returned! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 125847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125847=edit [21.05.x] Bug 29139: Add regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 125846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125846=edit [21.05.x] Bug 29139: Add exceptions to relation accessors We already had exceptions on the many-to-many links, but we didn't have them for the middle table. The underlying dbic relations make it clear which id's are being used for linking. A 'credit' has 'credit_offsets', a 'debit' has 'debit_offsets'. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 125845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125845=edit [21.05.x] Bug 29139: Fix incorrect relation call The bug here was worse than originally thought. We were calling the wrong relation too.. we should probably add some exceptions to catch this, it confuses me every single time! Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139
--- Comment #26 from Tomás Cohen Arazi ---
Created attachment 125844
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125844=edit
[21.05.x] Bug 29139: $line->debit_offsets doesn't honor list context
Being based on _new_from_dbic (discussion on bug 28883), makes the
assignment incorrect:
my @account_offsets = $payment->debit_offsets;
This patch explicitly makes the resultset be assigned as a list by
calling *as_list*.
To test:
1. Have UseEmailReceipts disabled
2. Have a patron with a debt of 6
3. Make a payment of 2
=> SUCCESS: All good
4. Enable UseEmailReceipts
5. Repeat 3
=> FAIL: You get something like:
ERROR PROCESSING TEMPLATE: undef error - The method
Koha::Account::Offsets->debit is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Objects.pm line 595
Koha::Objects::AUTOLOAD('Koha::Account::Offsets=HASH(0x561cbe2ac930)') called
at input text line 6
eval {...} at input text line 6
eval {...} at input text line 23
6. Apply this patch
7. Repeat 3
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #16 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #15) > I don't think we need this for now. The only valuable addition is the schema > changes, adding relationships with better names, but it falls short as it is > not renaming the methods to access those. > > My original idea was to rename the methods to allow embedding things in an > API route for article requests e.g. > > GET /article_requests > x-koha-embed: patron, library > > so we can use it to render datatables. That said, I'm closing this bug, and opening a new one, once I can start coding such API route. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 --- Comment #15 from Tomás Cohen Arazi --- I don't think we need this for now. The only valuable addition is the schema changes, adding relationships with better names, but it falls short as it is not renaming the methods to access those. My original idea was to rename the methods to allow embedding things in an API route for article requests e.g. GET /article_requests x-koha-embed: patron, library so we can use it to render datatables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #9) > +# this is to avoid calling ->discard_changes to retrieve > +# the default value from the DB > +$self->status( Koha::ArticleRequest::Status::Requested ) > +unless $self->status; > > Hmm. But if you didnt provide a status, we should be able to rely on the > default value from the DB engine, isnt it? True -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #8) > Koha/Schema/Result/ArticleRequest.pm | 38 +- That's weird. Probably didn't notice on git add. > Strictly forbidden. Even for Tomas. Specially for any QA team member! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29110] Refactor Koha::ArticleRequest->store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29110 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #7) > +$deleted_patron->delete; # Haha It makes sense :-D I want a patron I'm sure doesn't exist on the DB :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29108] Add q parameters to items routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29108 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #13 from Tomás Cohen Arazi --- Went the Context.Scalar way on this one as well. Back to PQA. Please note that the unit tests need the latest follow-up I submitted on bug 27526. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 125843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125843=edit Bug 29084: Remove article_requests_finished and article_requests_current This patch removes those methods that are not really needed. Templates are adjusted to use the expected combination of ->article_requests->filter_by_current. To test: 1. Apply this patch 2. Visit a biblio with article requests => SUCCESS: All works 3. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass, less tests. 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125245|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 125842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125842=edit Bug 29084: Update article requests-related Koha::Biblio methods to use relationships This patch makes Koha::Patron->article_requests use the underlying DBIC relationship and _new_from_dbic instead of a plain search. It also refactors 'article_requests_current' and 'article_requests_finished' to use ->article_requests, as well as the new methods introduced by bug 29082 for filtering. No behavior change should take place. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t \ t/db_dependent/ArticleRequests.t => SUCCESS: Tests pass! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29084] Update article requests-related Koha::Biblio methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29084 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125244|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 125841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125841=edit Bug 29084: Unit tests This patch adds missing tests for Koha::Biblio->article_requests and reorganizes (and extends) the tests for 'article_requests_current' and 'article_requests_finished' that were originally in ArticleRequests.t into Koha/Biblio.t as we do now. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/ArticleRequests.t \ t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125838|0 |1 is obsolete|| --- Comment #32 from Tomás Cohen Arazi --- Created attachment 125840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125840=edit Bug 29083: Remove article_requests_finished and article_requests_current This patch removes those methods that are not really needed. Templates are adjusted to use the expected combination of ->article_requests->filter_by_current. To test: 1. Apply this patch 2. Visit a patron with article requests => SUCCESS: All works 3. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass, less tests. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #122 from Tomás Cohen Arazi --- Created attachment 125839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125839=edit Bug 27526: (QA follow-up) Wrap tests in transaction Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 125838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125838=edit Bug 29083: Remove article_requests_finished and article_requests_current This patch removes those methods that are not really needed. Templates are adjusted to use the expected combination of ->article_requests->filter_by_current. To test: 1. Apply this patch 2. Visit a patron with article requests => SUCCESS: All works 3. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass, less tests. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 125837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125837=edit Bug 29083: Fix OPAC listing of article requests This patch makes the OPAC template reuse a precalculated value for the active article requests for the patron (and its count). The original code relied on the methods returning a list, which is not the case for _new_from_dbic until bug 28883 is pushed. This patch fixes that. Note: there was an odd behavior when ArticleRequests was enabled but no active article requests were present: the tab wasn't rendered but the 'empty table' with the 'You have no article requests currently.' message was displayed below the Checkouts tab. I'm not sure that was caused by this patches, or other. Fixed on this patch. To test: 1. In the OPAC, go to 'your summary' => FAIL: Things don't show for article requests 2. Add some article requests and repeat 1 => FAIL: Something's wrong there 3. Apply this patch and repeat 1 => Yes! Things show correctly! 4. Cancel all your article requests => SUCCESS: Things render as they should 5. Re-enter the 'your summary' page (to force re-rendering) => SUCCESS: Things render correctly for empty article requests 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 125836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125836=edit Bug 29083: (QA follow-up) Remove unused param Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 125835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125835=edit Bug 29083: Update article requests-related Koha::Patron methods to use relationships This patch makes Koha::Patron->article_requests use the underlying DBIC relationship and _new_from_dbic instead of a plain search. It also refactors 'article_requests_current' and 'article_requests_finished' to use ->article_requests, as well as the new methods introduced by bug 29082 for filtering. No behavior change should take place. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/ArticleRequests.t => SUCCESS: Tests pass! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 125834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125834=edit Bug 29083: Unit tests This patch adds missing tests for Koha::Patron->article_requests and moves (and extends) tests for 'article_requests_current' and 'article_requests_finished' that were originally in ArticleRequests.t into Koha/Patron.t as we now do. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/ArticleRequests.t \ t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125833|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125643|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125642|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125641|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125640|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #26 from Tomás Cohen Arazi --- Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Passed QA --- Comment #25 from Tomás Cohen Arazi --- Done. Went the Context.Scalar way for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29083] Update article requests-related Koha::Patron methods to use relationships
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29083 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 125833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125833=edit Bug 29083: Remove article_requests_finished and article_requests_current This patch removes those methods that are not really needed. Templates are adjusted to use the expected combination of ->article_requests->filter_by_current. To test: 1. Apply this patch 2. Visit a patron with article requests => SUCCESS: All works 3. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass, less tests. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29188] New: Expired serial subscriptions can still receive issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29188 Bug ID: 29188 Summary: Expired serial subscriptions can still receive issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org In the manual, it says "If your serial subscription has expired you won’t be able to receive issues." But that is not actually true. Expired subscriptions can still generate new issues and you can still receive them. To stop a subscription from generating new issues, you have to close it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #8 from Caroline Cyr La Rose --- If I may, here's what I have with the current master... My subscription A expired on September 1st 2021, we are Oct. 6, so it is currently expired. I have received all issues that were in the subscription (and more). In subscription-detail.pl : "Subscription will expire 09/01/2021. Renew this subscription." In a blue message box. Renew this subscription is a link. In serials-collection.pl : "Subscription expired" in bold, red and with an exclamation mark icon next to it My subscription B expired on the same day. BUT I haven't received any issues (I only just created the subscription and didn't do anything else). Nothing in subscription-detail.pl, nothing in serials-collection.pl. Once I have received one issue with today's date, the messages appear in both subscription-detail.pl and serials-collection.pl If I change the received issue and put a date in the past in "Expected on", the messages disappear. I can't get just one message like Katrin. But, what I understand is that it has nothing to do with the end of the subscription and more to do with the issues in the subscription? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29187] New: Some libraries don't use print notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29187 Bug ID: 29187 Summary: Some libraries don't use print notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Sometimes print are generated as a fallback when a patron doesn't have an address for a message transport These messages sit in the DB as 'pending' if gather print is not run We should have a way to either: 1 - Clean these up (via cleanup database etc) without needing to change status (i.e. run gather print) 2 - Prevent generation of these messages if they will not be used -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28996] SendQueuedMessages exit on a bad email 'To' and following messages are never processed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996 --- Comment #5 from Jonathan Druart --- Looks like a duplicate of bug 28803. Please reopen if I am wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Jonathan Druart changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om --- Comment #53 from Jonathan Druart --- *** Bug 28996 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28996] SendQueuedMessages exit on a bad email 'To' and following messages are never processed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 28803 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28996 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28996] SendQueuedMessages exit on a bad email 'To' and following messages are never processed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28996 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28803 CC||n...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 --- Comment #1 from Owen Leonard --- Created attachment 125832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125832=edit Bug 29186: Move reports result limit menu into toolbar This patch creates a new Bootstrap button menu for selecting the number of search results to be shown. This replaces the HTML . To test, apply the patch and go to Reports -> Saved reports. - Test the appearance and functionality of the "Rows per page" button in various situations: - A report that returns more than 10 results - A report that returns fewer than 10 results - A report that returns no results - Test that the batch operations button menu appears correctly when there are biblionumbers, itemnumbers, or cardnumbers in the results. - When there are no results, or fewer than 10 results with no batch operations possible the toolbar shouldn't appear at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29186] New: Move reports result limit menu into toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 Bug ID: 29186 Summary: Move reports result limit menu into toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Created attachment 125831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125831=edit Screenshot of the proposed change I propose to convert the HTML for choosing the number of report results shown into a Bootstrap dropdown menu. See attached screenshot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22435] Clarify account_offset types by converting them to clear codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Bug 22435 depends on bug 27636, which changed state. Bug 27636 Summary: Replace Koha::Account::pay with a simpler method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29139] Paying gives ISE if UseEmailReceipts is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29139 Bug 29139 depends on bug 27636, which changed state. Bug 27636 Summary: Replace Koha::Account::pay with a simpler method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27636] Replace Koha::Account::pay with a simpler method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27636 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #30 from Jonathan Druart --- Patch is too big See https://gitlab.com/joubu/Koha/-/commits/bug_18984 For "Bug 18984: Remove *-NORMARC.po files" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #29 from Jonathan Druart --- (In reply to Jonathan Druart from comment #28) > (In reply to Marcel de Rooy from comment #25) > > How about removing: > > Hum good question. That needs to be done with Bernardo at release time I'd > say, otherwise he is going to re-introduce them. > > I don't know, to be honest. It would make sense to remove them now, but make sure we are not going to reintroduce them later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #28 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #25) > How about removing: Hum good question. That needs to be done with Bernardo at release time I'd say, otherwise he is going to re-introduce them. I don't know, to be honest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #27 from Jonathan Druart --- Created attachment 125830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125830=edit Bug 18984: DB changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #26 from Marcel de Rooy --- hmm bit too much text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #25 from Marcel de Rooy --- How about removing: misc/translator/po/am-Ethi-marc-NORMARC.po misc/translator/po/ar-Arab-marc-NORMARC.po misc/translator/po/as-IN-marc-NORMARC.po misc/translator/po/az-AZ-marc-NORMARC.po misc/translator/po/be-BY-marc-NORMARC.po misc/translator/po/bg-Cyrl-marc-NORMARC.po misc/translator/po/bn-IN-marc-NORMARC.po misc/translator/po/ca-ES-marc-NORMARC.po misc/translator/po/cs-CZ-marc-NORMARC.po misc/translator/po/cy-GB-marc-NORMARC.po misc/translator/po/da-DK-marc-NORMARC.po misc/translator/po/de-CH-marc-NORMARC.po misc/translator/po/de-DE-marc-NORMARC.po misc/translator/po/dz-marc-NORMARC.po misc/translator/po/el-GR-marc-NORMARC.po misc/translator/po/en-GB-marc-NORMARC.po misc/translator/po/en-NZ-marc-NORMARC.po misc/translator/po/eo-marc-NORMARC.po misc/translator/po/es-ES-marc-NORMARC.po misc/translator/po/eu-marc-NORMARC.po misc/translator/po/fa-Arab-marc-NORMARC.po misc/translator/po/fi-FI-marc-NORMARC.po misc/translator/po/fo-FO-marc-NORMARC.po misc/translator/po/fr-CA-marc-NORMARC.po misc/translator/po/fr-FR-marc-NORMARC.po misc/translator/po/ga-marc-NORMARC.po misc/translator/po/gd-marc-NORMARC.po misc/translator/po/gl-marc-NORMARC.po misc/translator/po/he-Hebr-marc-NORMARC.po misc/translator/po/hi-marc-NORMARC.po misc/translator/po/hr-HR-marc-NORMARC.po misc/translator/po/hu-HU-marc-NORMARC.po misc/translator/po/hy-Armn-marc-NORMARC.po misc/translator/po/hyw-Armn-marc-NORMARC.po misc/translator/po/ia-marc-NORMARC.po misc/translator/po/id-ID-marc-NORMARC.po misc/translator/po/iq-CA-marc-NORMARC.po misc/translator/po/is-IS-marc-NORMARC.po misc/translator/po/it-IT-marc-NORMARC.po misc/translator/po/iu-CA-marc-NORMARC.po misc/translator/po/ja-Jpan-JP-marc-NORMARC.po misc/translator/po/ka-marc-NORMARC.po misc/translator/po/km-KH-marc-NORMARC.po misc/translator/po/kn-Knda-marc-NORMARC.po misc/translator/po/ko-Kore-KP-marc-NORMARC.po misc/translator/po/ku-Arab-marc-NORMARC.po misc/translator/po/lo-Laoo-marc-NORMARC.po misc/translator/po/lv-marc-NORMARC.po misc/translator/po/mi-NZ-marc-NORMARC.po misc/translator/po/ml-marc-NORMARC.po misc/translator/po/mon-marc-NORMARC.po misc/translator/po/mr-marc-NORMARC.po misc/translator/po/ms-MY-marc-NORMARC.po misc/translator/po/my-marc-NORMARC.po misc/translator/po/nb-NO-marc-NORMARC.po misc/translator/po/ne-NE-marc-NORMARC.po misc/translator/po/nl-BE-marc-NORMARC.po misc/translator/po/nl-NL-marc-NORMARC.po misc/translator/po/nn-NO-marc-NORMARC.po misc/translator/po/oc-marc-NORMARC.po misc/translator/po/pbr-marc-NORMARC.po misc/translator/po/pl-PL-marc-NORMARC.po misc/translator/po/prs-marc-NORMARC.po misc/translator/po/pt-BR-marc-NORMARC.po misc/translator/po/pt-PT-marc-NORMARC.po misc/translator/po/ro-RO-marc-NORMARC.po misc/translator/po/ru-RU-marc-NORMARC.po misc/translator/po/rw-RW-marc-NORMARC.po misc/translator/po/sd-PK-marc-NORMARC.po misc/translator/po/sk-SK-marc-NORMARC.po misc/translator/po/sl-SI-marc-NORMARC.po misc/translator/po/sq-AL-marc-NORMARC.po misc/translator/po/sr-Cyrl-marc-NORMARC.po misc/translator/po/sv-SE-marc-NORMARC.po misc/translator/po/sw-KE-marc-NORMARC.po misc/translator/po/ta-LK-marc-NORMARC.po misc/translator/po/ta-marc-NORMARC.po misc/translator/po/te-marc-NORMARC.po misc/translator/po/tet-marc-NORMARC.po misc/translator/po/th-TH-marc-NORMARC.po misc/translator/po/tl-PH-marc-NORMARC.po misc/translator/po/tr-TR-marc-NORMARC.po misc/translator/po/tvl-marc-NORMARC.po misc/translator/po/uk-UA-marc-NORMARC.po misc/translator/po/ur-Arab-marc-NORMARC.po misc/translator/po/vi-VN-marc-NORMARC.po misc/translator/po/zh-Hans-CN-marc-NORMARC.po misc/translator/po/zh-Hant-TW-marc-NORMARC.po root@master:/usr/share/koha# git grep -l normarc > zz root@master:/usr/share/koha# cat zz installer/data/mysql/updatedatabase.pl misc/release_notes/release_notes_3_12_0.txt misc/translator/po/am-Ethi-marc-NORMARC.po misc/translator/po/ar-Arab-marc-NORMARC.po misc/translator/po/as-IN-marc-NORMARC.po misc/translator/po/az-AZ-marc-NORMARC.po misc/translator/po/be-BY-marc-NORMARC.po misc/translator/po/bg-Cyrl-marc-NORMARC.po misc/translator/po/bn-IN-marc-NORMARC.po misc/translator/po/ca-ES-marc-NORMARC.po misc/translator/po/cs-CZ-marc-NORMARC.po misc/translator/po/cy-GB-marc-NORMARC.po misc/translator/po/da-DK-marc-NORMARC.po misc/translator/po/de-CH-marc-NORMARC.po misc/translator/po/de-DE-marc-NORMARC.po misc/translator/po/dz-marc-NORMARC.po misc/translator/po/el-GR-marc-NORMARC.po misc/translator/po/en-GB-marc-NORMARC.po misc/translator/po/en-NZ-marc-NORMARC.po misc/translator/po/eo-marc-NORMARC.po misc/translator/po/es-ES-marc-NORMARC.po misc/translator/po/eu-marc-NORMARC.po misc/translator/po/fa-Arab-marc-NORMARC.po misc/translator/po/fi-FI-marc-NORMARC.po misc/translator/po/fo-FO-marc-NORMARC.po misc/translator/po/fr-CA-marc-NORMARC.po misc/translator/po/fr-FR-marc-NORMARC.po misc/translator/po/ga-marc-NORMARC.po misc/translator/po/gd-marc-NORMARC.po
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #24 from Jonathan Druart --- Koha/Schema/Result/SearchMarcMap.pm changes removed from last patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #23 from Jonathan Druart --- Created attachment 125829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125829=edit Bug 18984: Remove ES mapping for NORMARC perl misc/search_tools/export_elasticsearch_mappings.pl > admin/searchengine/elasticsearch/mappings.yaml grep -v 'mandatory: ~' admin/searchengine/elasticsearch/mappings.yaml|grep -v 'opac: 1'|grep -v 'staff_client: 1' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Jonathan Druart changed: What|Removed |Added Attachment #125826|0 |1 is obsolete|| Attachment #125827|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart --- Created attachment 125828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125828=edit Bug 18984: Remove NORMARC support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #21 from Marcel de Rooy --- Dont forget to add a dbrev for search_marc_map -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Marcel de Rooy --- The signoff stands, but it needs attention still. Switch back to SO afterwards. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984
--- Comment #19 from Marcel de Rooy ---
diff --git a/Koha/Schema/Result/SearchMarcMap.pm
b/Koha/Schema/Result/SearchMarcMap.pm
index 03bc94304c..6b700c65ff 100644
--- a/Koha/Schema/Result/SearchMarcMap.pm
+++ b/Koha/Schema/Result/SearchMarcMap.pm
@@ -40,7 +40,7 @@ what storage index this map is for
=head2 marc_type
data_type: 'enum'
- extra: {list => ["marc21","unimarc","normarc"]}
+ extra: {list => ["marc21","unimarc"]}
is_nullable: 0
what MARC type this map is for
@@ -67,7 +67,7 @@ __PACKAGE__->add_columns(
"marc_type",
{
data_type => "enum",
-extra => { list => ["marc21", "unimarc", "normarc"] },
+extra => { list => ["marc21", "unimarc"] },
is_nullable => 0,
},
"marc_field",
You dont want this in your regular patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20119] Ability to print claims for late orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #20 from Alex Arnaud --- Patches rebased on master. I attached a new one that add an option for updating claims count and claim date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #18 from Marcel de Rooy --- DBIx::Class::Relationship::ManyToMany::many_to_many(): *** The many-to-many relationship 'search_fields' is trying to create a utility method called add_to_search_fields. This will completely overwrite one such already existing method on class Koha::Schema::Result::SearchMarcMap. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Marcel de Rooy changed: What|Removed |Added Attachment #125820|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 125827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125827=edit Bug 18984: Remove ES mapping for NORMARC perl misc/search_tools/export_elasticsearch_mappings.pl > admin/searchengine/elasticsearch/mappings.yaml grep -v 'mandatory: ~' admin/searchengine/elasticsearch/mappings.yaml|grep -v 'opac: 1'|grep -v 'staff_client: 1' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Marcel de Rooy changed: What|Removed |Added Attachment #125819|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 125826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125826=edit Bug 18984: Remove NORMARC support Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20119] Ability to print claims for late orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 --- Comment #19 from Alex Arnaud --- Created attachment 125825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125825=edit Bug 20119: Add option to update claims count and claim date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20119] Ability to print claims for late orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What|Removed |Added Attachment #72945|0 |1 is obsolete|| --- Comment #18 from Alex Arnaud --- Created attachment 125824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125824=edit Bug 20119 - Add unit tests [2018-03-15] Rebased-by: Alex Arnaud Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20119] Ability to print claims for late orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119 Alex Arnaud changed: What|Removed |Added Attachment #72944|0 |1 is obsolete|| --- Comment #17 from Alex Arnaud --- Created attachment 125823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125823=edit Bug 20119 - Ability to print claims for late orders Test plan: - create a notice: module: claimacquisition, code: ACQCLAIM: transport: print - create at least a bookseller, basket and orders, - close the basket and change the closedate to make orders late, - go to cgi-bin/koha/acqui/lateorders.pl, - select one or more order(s) to claim and click on "Print claim", - check the pdf downloaded [2018-03-15] Rebased-by: Alex Arnaud Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24326] Remove advance_notices_digest.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24326] Remove advance_notices_digest.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24326] Remove advance_notices_digest.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com --- Comment #3 from Jonathan Druart --- I do agree those tests should not have been pushed. 3 years later we are still missing the "clean ups could be handled separately" part. However the tests are there and can be useful, Jenkins could back us is something is going wrong. But for devs it's really bad. We could use the RUN_TESTS_AND_EXIT flag set by Jenkins: The tests would warn and exit early (exit 0) if the env var is not set. Something better to suggest? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28867] Use Bootstrap button menu and modal for adding patrons to lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28867 --- Comment #2 from Owen Leonard --- Created attachment 125822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125822=edit Bug 28867: Use Bootstrap button menu and modal for adding patrons to lists This patch reworks the controls for adding patrons to a list from the patron search results page. The is converted to a Bootstrap dropdown menu, and the list creation form is moved into a Bootstrap modal. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff interface, perform a patron search that will return multiple results. - In the toolbar at the top of the search results you should see two disabled Bootstrap-styled buttons: "Add to patron list" and "Merge selected patrons." - The "Select all" and "Clear all" links should work to enable and disable the toolbar buttons. - "Clear all" and then check the checkbox next to one of the results. The "Add to patron list" button should be enabled. - Check a second checkbox. The "Merge selected patrons" button should be enabled. - Test the "Add to patron list" button. It should trigger a dropdown menu listing existing patrons lists and a "New list" link. - Test adding to an exising patron list. It should trigger a message at the top of the page which shows a link to that list. - Test adding to a new list. It should trigger a Bootstrap modal where you can enter the name of the new list. - Submitting the list title form should close the modal and trigger the display of the message showing how many patrons were added to your new list. The link to the new list should be correct. - Test the "Merge selected patrons" button. It should send the selected patrons to the patron merge screen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28867] Use Bootstrap button menu and modal for adding patrons to lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28867 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #15 from Marcel de Rooy --- Lots of qa warns here for DBIx::Class::Relationship::ManyToMany::many_to_many(): -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 --- Comment #14 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #13) > FAIL t/db_dependent/selenium/purchase_workflow.t >OK critic >FAIL file permissions > File must have the exec flag >OK forbidden patterns >OK git manipulation >OK pod >SKIP spelling >OK valid > > > Processing additional checks > > * Commit title does not start with 'Bug X: ' - 75d22621e8 wrong bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18984] Remove support for NORMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #13 from Marcel de Rooy --- FAIL t/db_dependent/selenium/purchase_workflow.t OK critic FAIL file permissions File must have the exec flag OK forbidden patterns OK git manipulation OK pod SKIP spelling OK valid Processing additional checks * Commit title does not start with 'Bug X: ' - 75d22621e8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27725] Use JavaScript to set history state during patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27725 --- Comment #14 from Owen Leonard --- Created attachment 125821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125821=edit Bug 27725: (follow-up) Remove code for clearing search results This patch removes code which cleared search results if there was no first-letter search. It was unnecessary for the letter search functionality and made all other searches fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
