[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #117 from Fridolin Somers --- Yep, I was waiting for Bug 29284. Will be in 20.11.12 release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 marion.dur...@biblibre.com changed: What|Removed |Added Attachment #126909|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #137 from Jonathan Druart --- (In reply to Andrew Nugged from comment #136) > (In reply to Jonathan Druart from comment #125) > > Created attachment 126034 [details] [review] [review] > > Bug 27526: Correct NULL vs empty string when editing > > looks like we lost this one from master. > > Jonathan: for a reason? Oops, sorry, I forgot it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 --- Comment #11 from marion.dur...@biblibre.com --- (In reply to David Nind from comment #10) > I amended the commit message for the follow up so that it has the correct > bug number. Thank you David for the correction. I obsoleted the patch with the wrong bug number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #442 from Jonathan Druart --- Created attachment 126950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126950&action=edit Bug 14957: Fix perlcritic error on admin/marc-overlay-rules.pl Subroutine "new" called using indirect syntax at line 30, column 13. See page 349 of PBP. (Severity: 4) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #443 from Jonathan Druart --- Created attachment 126951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126951&action=edit Bug 14957: DBIC changes - Remove MarcOverlayRulesModule.pm Where is that coming from?? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #138 from Jonathan Druart --- I was actually waiting for confirmation, I haven't flagged it as pushed. It's now pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate | --- Comment #444 from Jonathan Druart --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What|Removed |Added Attachment #126448|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 126952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126952&action=edit Bug 26314: Only display volumes link when required This patch makes C4::XSLT query for volumes the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Show volumes' link. To test: 1. Apply the first patch 2. Have a known record without volumes 3. Open the record in the OPAC => FAIL: It shows the 'Show volumes' link 4. Have a record known to have volumes 5. Open the record in the OPAC => SUCCESS: It shows the 'Show volumes' link 6. Apply this patch and restart_all 7. Reload the above records => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed. 8. Repeat for Intranet 9. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Martin Renvoize changed: What|Removed |Added Attachment #126449|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 126953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126953&action=edit Bug 26314: (follow-up) Use clean_search_term This patch uses the now public clean_search_term from bug 28316 to sanitize the title string and prevent crashes in elastic search when title contain reserved characters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314
Martin Renvoize changed:
What|Removed |Added
Attachment #126450|0 |1
is obsolete||
--- Comment #16 from Martin Renvoize ---
Created attachment 126954
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126954&action=edit
Bug 26314: (follow-up) Make title search explicit
This patch updates the get_volumes_query search returned when
UseControlNumber is disabled such that it matches the query produced by
XSLT sheets by replacing the ->title accessor with the more specific
->subfield('245', "a") accessor to just take subfield `a` into account.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #17 from Martin Renvoize --- Created attachment 126955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126955&action=edit Bug 26314: Update for changes to bug 11175 methodology This moves the show_volumes calculation back out of C4::XSLT into the controller scripts and refined the search query builder slightly based on the XSLT equivilent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #18 from Martin Renvoize --- I still think it might be a good idea to pass the search string from the controller instead of constructing it in two places.. keeps it dry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #445 from Martin Renvoize --- (In reply to David Gustafsson from comment #440) > Great :) Thanks everyone. There is a patch for the manual: > https://gitlab.com/gnucifer/koha-manual/commit/ > 593c5da008dbc4b074cac9dee167cce9a6dfc250#c5e2c75dc923f21c5b95185b2f350df00fec > 661f > > But some of the terminology need to change (marc overlay rules instaed of > merge rules for example). Could you submit that as a merge request on gitlab now please.. I can do the tidying up if you like. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29314] Move some OpenURL code to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29314 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Looks reasonable to me.. but I'll defer to Julian for initial testing as I think he's closer to coins and openurl than I am -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29331] New: Batch edit items.itemlost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331 Bug ID: 29331 Summary: Batch edit items.itemlost Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: katrin.fisc...@bsz-bw.de, n...@bywatersolutions.com, oleon...@myacpl.org From IRC "I think Bug 28445 broke the ability to batch update lost status" So I fixed it, but actually it was not possible before 28445. Do we want it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29331 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29331] Batch edit items.itemlost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331 --- Comment #1 from Jonathan Druart --- Created attachment 126956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126956&action=edit Bug 29331: Allow items.itemlost from batch item modification Not done yet, call to LostItem from Koha::Items->batch_update needs to be adjusted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29331] Batch edit items.itemlost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331 --- Comment #2 from Jonathan Druart --- Note that this patch is also displaying subfields that are hidden when editing items. It can be moved to its own bug report if we want it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 --- Comment #9 from Martin Renvoize --- The only thing I wonder about is the 'checked_in' parameter. I'm wondering if there's a use case for 'all' checkouts.. i.e both historic and current? Perhaps a 'state' param instead with 'out, in, both' ? Just a thought, let me know what you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 Martin Renvoize changed: What|Removed |Added Attachment #126637|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 126957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126957&action=edit Bug 29290: Add spec changes This patch adds the new route. It also tweaks the checkout object definition to allow embedding the required related objects (for bug 29275). Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 Martin Renvoize changed: What|Removed |Added Attachment #126638|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 126958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126958&action=edit Bug 29290: Rename relationships borrower => patron This is a trivial change that is required to be able to embed patron objects in the (old) checkout object. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 Martin Renvoize changed: What|Removed |Added Attachment #126639|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 126959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126959&action=edit Bug 29290: Add GET /biblios/:biblio_id/checkouts This patch adds the required controller method. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 --- Comment #13 from Martin Renvoize --- Of course.. the normal checkouts route already uses a 'checked_in' parameter so this is consistent. All works as expected then, QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 --- Comment #14 from Martin Renvoize --- Hold off.. what's our current requirements regards API route testing? I'm not seeing any tasts here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29331] Batch edit items.itemlost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331 --- Comment #3 from Katrin Fischer --- I think the ability to batch edit lost items is quite helpful. A use case would be inventory when you come up with a list of missing items. We had libraries asking for them to be set to "missing" to mark them in the catalog. I believe I used the batch edit item tool (possibly 18.11). When a item is batch edited I think we cannot assume that it has actually be seen/handled, so it should not be handled like a "checkin" where the lost status would be removed automatically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29331] Batch edit items.itemlost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331 --- Comment #4 from Katrin Fischer --- I believe the hidden fields should remain hidden (keep previous behaviour). There is a number of critical fields we might want to think about more before allowing changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 --- Comment #139 from Andrew Nugged --- thanks! Now I am doing my build for piloting library, production, let's see what else pops-up! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28640] Add EDI order status to basket details display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640 Martin Renvoize changed: What|Removed |Added Text to go in the||Clarify the exact status of release notes||EDI orders on the basket ||details display, ||highlighting that a basket ||can be closed but pending ||or closed and sent for ||example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28514] Replace C4::Letters::getletter with Koha::Notice::Templates->find_effective_template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Martin Renvoize changed: What|Removed |Added Summary|C4::Letters::getletter must |Replace |be rewritten|C4::Letters::getletter with ||Koha::Notice::Templates->fi ||nd_effective_template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28514] Replace C4::Letters::getletter with Koha::Notice::Templates->find_effective_template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 Martin Renvoize changed: What|Removed |Added Text to go in the||This patch simplifies and release notes||clarifies the process of ||getting a notice template ||for a notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28572] Replace C4::Debug with Koha::Logger->debug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28572 Martin Renvoize changed: What|Removed |Added Text to go in the||This patch simplifies and release notes||clarifies how developers ||should add debug statements ||to the Koha codebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29214] Lost item checked in shows "Lost item fee refund" instead of "Lost item fee removed"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29214 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Severity|major |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28955] Add option to set default branch from Apache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize changed: What|Removed |Added Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #446 from David Gustafsson --- Ok, thanks! https://gitlab.com/gnucifer/koha-manual/-/merge_requests/1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] New: AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Bug ID: 29332 Summary: AdditionalContents displays blocks for all libraries prior to login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org If you set a content block to display only for one library, you do not want it to show prior to that library being defined. Currently, prior to OPAC login, all blocks will display as the library is not yet set.. only the 'all' block should display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 --- Comment #1 from Martin Renvoize --- Created attachment 126960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126960&action=edit Bug 29332: Set default library limits in search_for_display Koha::AdditionalContents->search_for_display needs to filter to just items with a 'null' branchcode if no library_id is passed. Test plan 1/ Add some additional content blocks that should display only for specific branches. 2/ Navigate to the OPAC and note that blocks display for all libraries prior to login 3/ Login to the OPAC and note that now you only see you users library block 4/ Apply the patch 5/ Repeat steps 2 and 3 and note that now you see only the 'All libraries' blocks display prior to login and that 'All libraries' + 'Your users library' blocks appear after login. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901
Owen Leonard changed:
What|Removed |Added
Attachment #125072|0 |1
is obsolete||
--- Comment #9 from Owen Leonard ---
Created attachment 126961
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126961&action=edit
Bug 28901: showCart incorrectly calculates position if content above navbar
This patch makes changes to the OPAC Cart's CSS and JS so that the cart
pop-up message display more consistently. The CSS is changed to use
position "fixed" instead of "absolute." This allows the message to
display without recalculating the position every time, and keeps the
appearance we expect.
The z-index of the message is also increase to prevent it from being
hidden behind a floating toolbar.
To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Perform a catalog search in the OPAC which will return multiple
results.
- In the list of search results, click the "Add to cart" link next to
several search results. Each time you should see a message appear in
the upper left corner of the screen, "The item has been added to the
cart."
- The position of the messages should be consistent no matter how far
down the page you scroll.
- Test again after adding content to the OpacHeader region. One way to
do this is to add the following to the OpacUserJS preference:
$(document).ready(function(){
$("#wrapper").prepend('https://generative-placeholders.glitch.me/image?width=900&height=200&style=triangles&gap=30";>');
});
- Test at various browser widths, from a phone-sized screen width up to
wide desktop-sized.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #447 from Cab Vinton --- As someone who periodically uses MarcEdit's integration w/ Koha to download, change, & upload records & I'm curious whether this is one of the included update methods for this enhancement (batchimport, zv39.50, intranet, bulkmarcimport (?), import_lexile, batchmod). I believe the MarcEdit integration relies on an API, so I'm thinking probably not? (https://blog.reeset.net/archives/2133; also 1123). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 --- Comment #19 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #18) > I still think it might be a good idea to pass the search string from the > controller instead of constructing it in two places.. keeps it dry. Not sure what you mean here. Constructing the query for components and volumes kind of the same? The shared logic could be moved? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 --- Comment #2 from Martin Renvoize --- Created attachment 126962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126962&action=edit Bug 29332: Unit tests This patch adds unit tests to ensure we do not leak branch specific addtional contents blocks outside of logged in sessions (i.e. where a users branch is not yet set). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize changed: What|Removed |Added Attachment #126960|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 126963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126963&action=edit Bug 29332: Set default library limits in search_for_display Koha::AdditionalContents->search_for_display needs to filter to just items with a 'null' branchcode if no library_id is passed. Test plan 1/ Add some additional content blocks that should display only for specific branches. 2/ Navigate to the OPAC and note that blocks display for all libraries prior to login 3/ Login to the OPAC and note that now you only see you users library block 4/ Apply the patch 5/ Repeat steps 2 and 3 and note that now you see only the 'All libraries' blocks display prior to login and that 'All libraries' + 'Your users library' blocks appear after login. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28955] Add option to set default branch from Apache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize changed: What|Removed |Added Depends on||29332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 [Bug 29332] AdditionalContents displays blocks for all libraries prior to login -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize changed: What|Removed |Added Blocks||28955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 [Bug 28955] Add option to set default branch from Apache -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |oleon...@myacpl.org |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||lu...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Nick Clemens changed: What|Removed |Added Attachment #126682|0 |1 is obsolete|| Attachment #126683|0 |1 is obsolete|| Attachment #126684|0 |1 is obsolete|| Attachment #126685|0 |1 is obsolete|| --- Comment #29 from Nick Clemens --- Created attachment 126964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126964&action=edit Bug 28327: CSVdelimiter special case for tabulation in templates System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in template. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #30 from Nick Clemens --- Created attachment 126965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126965&action=edit Bug 28327: Add unit tests for Koha::Template::Plugin::Koha::CSVDelimiter Run prove t/Koha_Template_Plugin_Koha.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #31 from Nick Clemens --- Created attachment 126966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126966&action=edit Bug 28327: CSVdelimiter special case for tabulation in perl System preference 'CSVdelimiter' has a special case for tabulation. Preference value contains string 'tabulation' but string '\t' must be used in CSV file. This is OK in many places, for exemple Bug 17590. This patch fixed when preference is fetch in perl. Test plan : 1) Set system preference 'CSVdelimiter' = 'tabs'. 2) Create CSV export in impacted pages 3) Check columns are separated by tabulation character and not string 'tabulation' Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 --- Comment #32 from Nick Clemens --- Created attachment 126967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126967&action=edit Bug 28327: (QA follow-up) Add POD Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #52 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #15) > We could also start supporting other ASCII characters like ;/% for subfield > codes.. Does not sound like a good plan to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #53 from Marcel de Rooy --- I have the feeling here that we took the wrong road and now we are on it, lets just continue following it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #124194|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 126968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126968&action=edit Bug 28913: Note cronjob on automatic return settings in itemtypes To test: 1 - go to itemtype config in Admin 2 - confirm it doesn't mention the automatic_return cron 3 - apply patch and restart 4 - confirm note now says "This feature requires the misc/cronjobs/automatic_checkin.pl cronjob. Ask your system administrator to schedule it." Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28913] Automatic checkin setting in item type setup should note required cronjob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Nick Clemens changed: What|Removed |Added Attachment #126324|0 |1 is obsolete|| Attachment #126325|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 126969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126969&action=edit Bug 28537: Improve HTML generated by OverDrive integration This patch makes changes to the way HTML is generated when showing output from OverDrive integration: - Buttons have Bootstrap button classes - Layout of information is improved. - Handling of cover image thumbnails is improved, especially in cases where images were much larger than expected. - An OverDrive-specific CSS file is added. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display well, with item thumbnails showing in a column to the left, and item information showing to the right. - Controls should be styled with standard Bootstrap style. - Confirm that operations work correctly: Acessing titles, checking in, canceling holds, etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, especially thumbnails. - Confirm that operations work correctly: Checking out and placing holds. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 --- Comment #8 from Nick Clemens --- Created attachment 126970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126970&action=edit Bug 28537: (follow-up) Correct and improve OverDrive checkout modal This patch corrects the markup of the modal which is displayed when the user clicks the "Download as" button in their list of OverDrive checkouts. The modal markup had not been updated in the conversion to Bootstrap 4. I have also modified the markup generated when listing the download format options so that they use some standard Bootstrap 4 classes, improving the layout a little. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - In the list of current checkouts, click the "Download as" button for one of the titles. - A modal window should display with a list of radio buttons for each available format. - Confirm that the format text acts as the label for the radio button. - Confirm that closing the modal without making a selection works correctly. - Confirm that making a selection and submitting the form closes the modal and submits your choice. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28537] Improve HTML generated by OverDrive integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28537 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Nick Clemens --- Small patch, big improvement, moving to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28613] Several objects.search-based routes missing parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28613 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens changed: What|Removed |Added Attachment #126533|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Marcel de Rooy changed: What|Removed |Added Attachment #126164|0 |1 is obsolete|| --- Comment #40 from Marcel de Rooy --- Created attachment 126971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126971&action=edit Bug 27358: Unit tests for public items retrieval Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Marcel de Rooy changed: What|Removed |Added Attachment #126165|0 |1 is obsolete|| --- Comment #41 from Marcel de Rooy --- Created attachment 126972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126972&action=edit Bug 27358: Add GET /public/biblios/:biblio_id/items This patch introduces a route to fetch items belonging to a biblio. It is expected to return the 'public' representation of the Koha::Item objects. It is also enforcing the visibility rules, by using Koha::Items->filter_by_visible_in_opac. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Test pass and they cover all the cases! 3. Try your favourite REST tool against the new route. 4. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27358] Add GET /public/biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 Marcel de Rooy changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 Tomás Cohen Arazi changed: What|Removed |Added Attachment #126642|0 |1 is obsolete|| --- Comment #8 from Tomás Cohen Arazi --- Created attachment 126973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126973&action=edit Bug 29288: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 Tomás Cohen Arazi changed: What|Removed |Added Attachment #126643|0 |1 is obsolete|| --- Comment #9 from Tomás Cohen Arazi --- Created attachment 126974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126974&action=edit Bug 29288: Add current_checkouts and old_checkouts methods to Koha::Biblio This patch adds helper methods for accessing current and past checkouts for a given Koha::Biblio object. To test: 1. Apply the unit tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => FAIL: Methods are not implemented 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 Tomás Cohen Arazi changed: What|Removed |Added Depends on||14957 --- Comment #10 from Tomás Cohen Arazi --- Rebased on top of bug 14957. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] New: Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Bug ID: 29333 Summary: Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org Related to bug 17754 MARC::Record and MARC::File::* modules sometimes use the position 09 of the leader to detect encoding. A blank character means 'MARC-8' while an 'a' means 'UTF-8'. In a UNIMARC authority this position is used to store the authority type (see https://www.transition-bibliographique.fr/wp-content/uploads/2021/02/AIntroLabel-2004.pdf [FR]). In this case, 'a' means 'Personal Name'. The result is that the import will succeed for a Personal Name authority, but it will fail for all other authority types. Steps to reproduce: 0. Be sure to have a Koha UNIMARC instance. 1. Download the MARCXML for "Honoré de Balzac" curl -o balzac.marcxml https://www.idref.fr/02670305X.xml 2. Verify that it's encoded in UTF-8 file balzac.marcxml (should output "balzac.marcxml: XML 1.0 document, UTF-8 Unicode text") 3. Go to Tools » Stage MARC for import and import balzac.marcxml with the following settings: Record type: Authority Character encoding: UTF-8 Format: MARCXML Do not touch the other settings 4. Once imported, go to the staged MARC management tool and find your batch. Click on the authority title "Balzac Honoré de 1799-1850" to show the MARC inside a modal window. There should be no encoding issue. 5. Write down the imported record id (the number in column '#') and go to the MARC authority editor. Replace all URL parameters by 'breedingid=THE_ID_YOU_WROTE_DOWN' The URL should look like this: /cgi-bin/koha/authorities/authorities.pl?breedingid=198 You should see no encoding issues. Do not save the record. 6. Import the batch into the catalog. Verify that the authority record has no encoding issue. 7. Now download the MARCXML for "Athènes (Grèce)" curl -o athènes.marcxml https://www.idref.fr/027290530.xml 8. Repeat steps 2 to 6 using athènes.marcxml file. At steps 4 and 5 you should see encoding issues and that the position 9 of the leader was rewritten from 'c' to 'a'. Strangely, importing this batch fix the encoding issue, but we still lose the information in position 09 of the leader -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Julian Maurice changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Julian Maurice changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Julian Maurice changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17754 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 Julian Maurice changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29333 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Julian Maurice changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18533 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18533] MARC::Record->encoding does not handle UNIMARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18533 Julian Maurice changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29333 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 --- Comment #1 from Julian Maurice --- Related to bug 18533 too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29075] OPAC info should not be raw in libraries table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 --- Comment #1 from Jérémy Breuillard --- Created attachment 126975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126975&action=edit Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone here and in opac-library.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29075] OPAC info should not be raw in libraries table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard changed: What|Removed |Added Status|NEW |Needs Signoff CC||jeremy.breuillard@biblibre. ||com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for all libraries prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 Tomás Cohen Arazi changed: What|Removed |Added Depends on|14957 |11175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Tomás Cohen Arazi changed: What|Removed |Added Blocks|29288 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29288 [Bug 29288] Add current_checkouts and old_checkouts methods to Koha::Biblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 Martin Renvoize changed: What|Removed |Added Attachment #126632|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 126976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126976&action=edit Bug 29272: Regression tests This patch introduces regression tests for the described bug. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_password.t => FAIL: Tests fail, excepted failures are considered success Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 Martin Renvoize changed: What|Removed |Added Attachment #126633|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 126977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126977&action=edit Bug 29272: Make public password changing honour category constraints This patch makes the public API routes validate $user->category->effective_change_password before allowing the change. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_password.t => FAIL: Tests fail, it allows the first change instead of returning 403. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29272] API not respecting $category->effective_change_password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29272 Martin Renvoize changed: What|Removed |Added Attachment #126814|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 126978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126978&action=edit Bug 29272: (QA follow-up) Category setup overrides syspref This patch removes an early short-circuit we had, which wasn't correct regarding the OpacPasswordChange syspref. If a patron category is allowed to change password, it overrides the syspref. To test: 1. Tests still pass. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #448 from David Gustafsson --- Good point. There is a ModBiblio in svc/bib, there should absolutely be a context module for that, would be easy to add. But I don't know what API MarcEdit is using. There is a swagger-api that I'm totally unfamiliar with, but from what I can gather from there definitions there don't seem to be any support for updating biblios, but it's pretty impenetrable to me as now nothing about swagger and/or that part of Koha. It's also hard to figure out what MarcEdit actually uses since there is no actual code in that post. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 --- Comment #21 from Nick Clemens --- Created attachment 126979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126979&action=edit Bug 26326: (follow-up) Address qa script failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 126980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126980&action=edit Bug 29290: Unit tests This patch adds unit tests for the new route. All behaviors are tested: To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29332] AdditionalContents displays blocks for every library prior to login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 Martin Renvoize changed: What|Removed |Added Summary|AdditionalContents displays |AdditionalContents displays |blocks for all libraries|blocks for every library |prior to login |prior to login -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #14) > Hold off.. what's our current requirements regards API route testing? I'm > not seeing any tasts here. Good catch, I forgot! Done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29146] Should framework default values be applied to existing records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26326] Add Koha Objects for Import Records and Import Record Matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26326 --- Comment #22 from Nick Clemens --- (In reply to Katrin Fischer from comment #20) > Please fix the QA script POD and merge marker errors. Remaining errors are spurious and can be ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29146] Should framework default values be applied to existing records?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 --- Comment #6 from Marcel de Rooy --- Created attachment 126981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126981&action=edit Bug 29146: Same for item editor Test plan: Put some defaultvalue in an item subfield. Test adding new item; is defaultvalue supplied already? Test adding existing item. Clear the subfield. Save. Open again. Is the subfield still empty now? Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
