[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #13 from Mason James  ---
(In reply to Mason James from comment #12)
> (In reply to Victor Grousset/tuxayo from comment #10)
> > (but it's important for Kyle and Nick to account for that and not fix it by
> > starting from 21.05.05.000 because it's been distributed and ran already)
> 
> i've released a package as 21.05.05.003, so here's the patch for that

root@deb10:/home/mason# apt-cache policy koha-common
koha-common:
  Installed: 21.05.05-3
  Candidate: 21.05.05-3
  Version table:
 *** 21.05.05-3 500
500 http://debian.koha-community.org/koha stable/main amd64 Packages
100 /var/lib/dpkg/status

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #12 from Mason James  ---
(In reply to Victor Grousset/tuxayo from comment #10)
> (but it's important for Kyle and Nick to account for that and not fix it by
> starting from 21.05.05.000 because it's been distributed and ran already)

i've released a package as 21.05.05.003, so here's the patch for that

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Mason James  changed:

   What|Removed |Added

 Attachment #127123|0   |1
is obsolete||

--- Comment #11 from Mason James  ---
Created attachment 127125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127125=edit
DBRev 21.05.05.003

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #10 from Victor Grousset/tuxayo  ---
(but it's important for Kyle and Nick to account for that and not fix it by
starting from 21.05.05.000 because it's been distributed and ran already)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #9 from Victor Grousset/tuxayo  ---
$DBversion = '21.05.05.002';
Minor mistake in the patch. The 4th part should be zeroed when incrementing the
3rd part for a release.

Example from a past release:
https://git.koha-community.org/Koha-community/Koha/commit/b17cf65633107306bd5d423998a50b65aaecce65

This means the version in DB > version in code:
https://git.koha-community.org/Koha-community/Koha/commit/ba30e76d1a08ef84e66583cd4638f6150ffdeee2

I don't think that should cause issues (though I don't know eventual quirks of
version management).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29375] Excessive regular expressions for treating barcodes

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375

Katrin Fischer  changed:

   What|Removed |Added

Summary|Excessive regular   |Excessive regular
   |expressions |expressions for treating
   ||barcodes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Katrin Fischer  ---
Some problems noted by the QA script, can you please fix?

 FAIL   installer/data/mysql/atomicupdate/bug_27360.pl
   OK critic
   FAIL   file permissions
File must have the exec flag
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   OK valid

 FAIL   installer/data/mysql/kohastructure.sql
   OK boolean_vs_tinyint
   OK charset_collate
   OK git manipulation
   FAIL   tinyint_has_boolean_flag
The new column branches.public is using TINYINT(1) as type but
is not defined as boolean in the schema file (Koha/Schema/Result/Branch.pm),
see the SQL12 coding guideline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #12 from Katrin Fischer  ---
I might be missing something, but for me the entry in the "Current maintenance
team" for Newsletter remains empty (label shows, but no name).

Can you please check? Otherwise this looks really good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29329] stray "s" in opac-detail

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126945|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 127124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127124=edit
Bug 29329: Remove stray character in opac-detail.tt

1. Have  OpacBrowseResults on.
2. Make search with many results.
3. Go to the record detail page
4. Click 'Browse results'
5. At the bottom of the container notice the stray "s".
6. apply patch
7. Try again, the "s" is gone!

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29329] stray "s" in opac-detail

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29329

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #8 from Mason James  ---
hi Kyle,
i've attached a patch, to be added to the 21.05 branch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #7 from Mason James  ---
Created attachment 127123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127123=edit
DBRev 21.05.05.002

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Mason James  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28450] Make Account summary print tables configurable

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126134|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 127122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127122=edit
Bug 28450: Make Account summary print tables configurable

This patch adds table settings for the three tables which appear on the
patron's "Print summary" view. This will allow the administrator to
set a default configuration for columns on the print summary page.

To test, apply the patch and restart-all to load the revised columns
settings YAML. Rebuild the staff interface SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Administration -> Table settings -> Circulation.
- Under the "Circulation tables" heading you should see a "Jump to" link
  to "print_summary."
- In the settings for the print_summary page you should see three
  tables: print-summary-checkouts, print-summary-fines, and
  print-summary-holds.
- Locate a patron account which has checkouts, fines, and holds.
  - From the patron detail view click "Print -> Print summary."
  - A new window should open with the print summary view. All tables
should display correctly.
  - Test that the "Columns" buttons work correctly to show and hide
columns.
- Make changes to the default settings for these tables to confirm that
  they work on the print summary page.

Signed-off-by: Lucas Gass 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28450] Make Account summary print tables configurable

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #6 from Mason James  ---
(In reply to Katrin Fischer from comment #4)
> Did it work alright? Leaving this open as we still need to fix it in Koha.

i've pushed a new 21.05.05-2 package, with the database update added

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28450] Make Account summary print tables configurable

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450

--- Comment #3 from Katrin Fischer  ---
I see that some tables have "cannot be toggled" greyed out by default. This
might be a nice addition here too, but doesn't appear to be done consistently
yet (OPAC tables) and so not a blocker for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126813|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 127121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127121=edit
Bug 28910: Correct eslint errors in OPAC basket.js

This patch corrects eslint errors in the OPAC copy of basket.js:
Indentation inconsistencies, undeclared variables, unused functions,
etc.

To test, apply the patch and test the "Cart" functionality in the
OPAC:

- In the OPAC, add an item to the cart.
- A popup message should appear telling you the item has been added.
- The "Add to cart" link should update to read "In your cart."
- The count if cart items in the header should be updated.
- The "In your cart (remove)" link should work correctly.
- Test this process from both the search results and
  detail pages.
- Open the cart.
- The cart should open correctly.
- In the cart, test all the controls:
  - More details
  - Send
  - Download
  - Empty and close
  - Hide window
  - Print
  - Select all / clear all
  - With checked items:
- Remove
- Add to list
- Place hold
- Tag

The following unused functions were removed: readCookieValue,
AllAreChecked, SelectAll, and quit. A search of the Koha codebase should
return no results from the opac-tmpl directory.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28910] Correct eslint errors in OPAC basket.js

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28910

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28901] showCart incorrectly calculates position if content above navbar

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28901

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127022|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 127120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127120=edit
Bug 28901: showCart incorrectly calculates position if content above navbar

This patch makes changes to the OPAC Cart's CSS and JS so that the cart
pop-up message display more consistently. The CSS is changed to use
position "fixed" instead of "absolute." This allows the message to
display without recalculating the position every time, and keeps the
appearance we expect.

The z-index of the message is also increase to prevent it from being
hidden behind a floating toolbar.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Perform a catalog search in the OPAC which will return multiple
   results.
 - In the list of search results, click the "Add to cart" link next to
   several search results. Each time you should see a message appear in
   the upper left corner of the screen, "The item has been added to the
   cart."
 - The position of the messages should be consistent no matter how far
   down the page you scroll.
 - Test again after adding content to the OpacHeader region. One way to
   do this is to add the following to the OpacUserJS preference:

   $(document).ready(function(){
 $("#wrapper").prepend('https://generative-placeholders.glitch.me/image?width=900=200=triangles=30;>');
   });

 - Test at various browser widths, from a phone-sized screen width up to
   wide desktop-sized.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29275] issuehistory.pl is very slow when there are many historical issues

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275

--- Comment #12 from Victor Grousset/tuxayo  ---
And it has been pushed :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29328] Add missing list parameter to reports parameter menu

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29328

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127068|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 127119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127119=edit
Bug 29328: Add missing list parameter to reports parameter menu

This patch adds an option to insert "list" as a runtime parameter in SQL
reports (As added by Bug 27380).

To test, apply the patch and go to Reports -> Create from SQL.

- Click the "Insert runtime parameter" button and select
  "List."
- Customize the parameter label if you wish and click "Insert
  parameter."
- The parameter should be inserted like this:

  <>

- Use it to create a valid SQL report, for example:

  SELECT * FROM borrowers WHERE categorycode IN  <>
  LIMIT 10

- Confirm that upon running the report you are shown a textarea. Enter
  two or more values in the textarea, each on a separate line.
- Confirm that the report runs correctly. The SQL above would show you
  this when you click "Show SQL code":

  SELECT * FROM borrowers WHERE categorycode IN  ('A','S')  LIMIT 10

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29328] Add missing list parameter to reports parameter menu

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29328

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126949|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 127118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127118=edit
Bug 29265: Add option to pick editor when creating a new content entry

This patch changes the "New entry" button on the additional contents
page to be a split button which offers the alternative of the
non-default editor (as defined by AdditionalContentsEditor).

Also changed: I moved some of the template logic around to consolidate
handling of the editor variables.

To test, apply the patch and go to Tools -> HTML customizations.

 - At the top of the page there should be a split button. The dropdown
   option should offer the non-default editor.
 - If AdditionalContentsEditor is set to "text editor," clicking the
   "main" part of the button should take you to an entry page which uses
   the text editor.
   - The dropdown part of the button should say "New entry using
  WYSIWYG editor."
 - Switch the AdditionalContentsEditor preference and confirm that the
   button reflects the change.
 - Confirm that the individual "Edit" buttons for each existing content
   entry still works correctly according to the system preference.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29265] Can't pick editor to use when adding new news or HTML customization entries

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29265

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29201] biblio_framework missing form list of runtime parameters when editing SQL reports

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29201

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127067|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 127117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127117=edit
Bug 29201: Add option to insert biblio_framework runtime parameter in SQL
report

This patch modifies the SQL report creation process so that the list of
runtime parameters includes an option for bibliographic framework.

To test, apply the patch and go to Reports -> Create from SQL.

- Click the "Insert runtime parameter" menu button and select
  "Bibliographic framework."
- You should be shown a modal dialog in which you can change the label
  on the framework input.
- Click "Insert parameter." The SQL field should now contain the correct
  parameter, e.g. <>
- Use the parameter to define an SQL query, e.g.

  "SELECT * FROM biblio WHERE frameworkcode =
  <> LIMIT 10"

- Run the report. You should be asked to choose a framework. Confirm
  that the report runs correctly.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29201] biblio_framework missing form list of runtime parameters when editing SQL reports

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29201

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127069|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 127116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127116=edit
Bug 29351: Add missing cn_source parameter to reports parameter menu

This patch adds an option to insert "Source of classification or
shelving scheme" as a runtime parameter in SQL reports. The ability to
use cn_source as a parameter seems to have always been part of this
feature but wasn't documented.

To test, apply the patch and go to Reports -> Create from SQL.

 - Click the "Insert runtime parameter" button and select
   "Classification source."
 - Customize the parameter label if you wish and click "Insert
   parameter."
 - The parameter should be inserted like this:

   <>

 - Use it to create a valid SQL report, for example:

   SELECT * FROM items WHERE cn_source = <> LIMIT 10

 - Confirm that upon running the report you are prompted to select a
   classification source.
 - Confirm that the report runs correctly.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29207] Restore Getopt::Long config to not ignore cases

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29207
Bug 29207 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29197] commit_file.pl missing import

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29197
Bug 29197 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28931] use EXPORT_OK in Koha::DateUtils

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28931
Bug 28931 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28763] Undefined subroutine XSLTParse4Display (bug 17600)

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28763
Bug 28763 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28758] Undefined subroutines in C4/ImportBatch.pm (bug 17600)

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28758
Bug 28758 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28750] Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750
Bug 28750 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28731] Subroutines not explicitly imported in reports svc (opac and staff)

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28731
Bug 28731 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28722] tools/batchMod.pl needs to import C4::Auth::haspermission

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28722
Bug 28722 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351
Bug 29351 depends on bug 17600, which changed state.

Bug 17600 Summary: Standardize the EXPORT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|CLOSED  |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17600] Standardize the EXPORT

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||29351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351
[Bug 29351] Add missing cn_source parameter to reports parameter menu
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||17600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
[Bug 17600] Standardize the EXPORT
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29351] Add missing cn_source parameter to reports parameter menu

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29351

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Manual,
   ||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29352] Runtime parameter labels should not be said to be optional

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127066|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 127115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127115=edit
Bug 29352: Runtime parameter labels should not be said to be optional

This patch alters the form shown when using the "Insert runtime
parameter" button in SQL reports. It makes the label field required and
removes "optional" from the field hint.

To test, apply the patch and go to Reports -> Create from SQL.

 - Click the "Insert runtime parameter" button and select "Authorized
   value."
 - Clear the "parameter label" field and click "Insert parameter."
 - The form should display an error asking you to fill in the label
   field.
 - Test that the category field is also required.
 - Close the modal and select a different runtime parameter.
 - Test again that the label field is required.
 - Test that the form submits correctly when the label field is
   populated.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29352] Runtime parameter labels should not be said to be optional

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29352

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #127101|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 127114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127114=edit
Bug 29369: Use Flatpickr in dateaccessioned cataloging plugin

This patch udpates the dateaccessioned cataloging plugin to use the
Flatpickr date picker instead of jQueryUI.

To test, apply the patch and open an item for editing in Cataloging.

- The date acquired field (952$d) should have flatpickr styling.
- Clicking in the field should populate the field with today's date and
  trigger the calendar popup.
- Clicking the "..." next to the field should populate the field (when
  empty) with today's date.
- Verify that tabbing from a different field into the date acquired
  field behaves the same as a click.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29369] Use Flatpickr in dateaccessioned cataloging plugin

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29369

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #13 from Katrin Fischer  ---
I wonder if we could improve on the bug description a little to point out that
this is also a usability enhancement. At the moment it's correct, but doesn't
paint a clear picture.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #126027|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 127113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127113=edit
Bug 28694: Check alert in cataloguing should be a static message

This patch modifies the basic cataloging interface so that form
validation errors are collected in a static "dialog" at the top of the
page instead of showing in a transient JavaScript alert.

The text of the message is roughly the same as it was in the alert, and
links have been added so that the user can click to jump directly to the
field referenced.

If the user scrolls down away from the static error message, a button
appears in the floating toolbar to jump back to the message.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Cataloging and create a new record using the basic cataloging
  editor and a framework which has multiple mandatory fields defined
  (e.g. an unmodified default framework)
- Without entering anything in mandatory fields, click the "Save"
  button.
- You should see a message box appear at the top of the page.
  - It should list each missing mandatory subfield and tag, each with a
"Go to field" link next to it.
  - Clicking the "Go to field" link should switch you to the correct tab
and scroll the mandatory field into view.
- When you have scrolled down far enough for the error messages to be
  offscreen, an "Errors" button should appear in the floating toolbar.
  Clicking it should scroll the box back into view.
- The JS function for scrolling to a particular element on the screen
  has been modified, so test that the links in the toolbar for
  individual tags still work correctly.

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694

--- Comment #11 from Katrin Fischer  ---
I really like this new workflow for resolving the errors with the ability to
jump to fields and errors!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi

--- Comment #7 from Joonas Kylmälä  ---
Just noting down here as well, if bug 28782 gets pushed then this bug is fixed
as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

--- Comment #14 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #12)
> I really like the idea of this, but I wonder if we should use biblionumber=
> for the URL parameter or something a little shorter?

It's what we use basically everywhere in koha for biblionumber so I think it
would be preferable to keep it that way.

> I seem to remember that we had issues with extra long URLs at some point,
> but couldn't pin it down. I looked it up and apparently the max size of an
> URL is 2048 characters?

Yeah, it seems to be a limitation of some browsers. If we wanted to support
browsers that have an URL length limitation then we should start an effort to
fix all places in Koha where we generate URLs with arbitrary length.
Realistically though, here we are not gonna run into that limitation easily,
you would have to make a hold for over 70 biblios (even if your bibnums were in
the millions) to reach the limit.

> ... and the display will look a bit broken.

Thanks, fixed in the follow-up!

> I wonder how this relates to bug 29257?

That would be not needed if this is pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

--- Comment #13 from Joonas Kylmälä  ---
Created attachment 127112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127112=edit
Bug 28782: (follow-up) Pass real array to query_form()

It excepts to receive a real array and not a list, in order to be able
to generate the query parameters.

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28263] AUTO_RENEWALS message for 'too_many' is wrong

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

David Nind  changed:

   What|Removed |Added

Summary|AUTO_RENEWAL message for|AUTO_RENEWALS message for
   |'too_many' is wrong |'too_many' is wrong

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

David Nind  changed:

   What|Removed |Added

  Text to go in the||This corrects the text in
  release notes||the AUTO_RENEWALS and
   ||AUTO_RENEWALS_DGST notices.
   ||These are sent when an item
   ||is setup for automatic
   ||renewal and can no longer
   ||be automatically renewed as
   ||the maximum number of
   ||renewals reached:
   ||- Current
   ||wording: "You have reached
   ||the maximum number of
   ||checkouts possible."
   ||-
   ||Updated wording: "You have
   ||reached the maximum number
   ||of renewals possible."
   ||
   ||For
   ||new installations the
   ||sample notices are updated.
   ||For existing installations
   ||the notices will be updated
   ||if they exist and haven't
   ||been changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes SIP connections
  release notes||so that when system
   ||preference and
   ||configuration changes are
   ||made (for example: enabling
   ||or disabling logging of
   ||issues and returns) they
   ||are picked up automatically
   ||with the next message,
   ||rather than requiring the
   ||SIP connection to be closed
   ||and reopened.
   ||
   ||SIP
   ||connections typically tend
   ||to be long lived - weeks if
   ||not months. Basically the
   ||connection per SIP machine
   ||is initiated once when the
   ||SIP machine boots and then
   ||never closed until
   ||maintenance is required.
   ||Therefore we need to reset
   ||Koha's caches on every SIP
   ||request to get the latest
   ||system preference and
   ||configuration changes from
   ||the memcached cache that is
   ||shared between all the Koha
   ||programs (staff interface,
   ||OPAC, SIP, cronjobs, etc).
   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #6 from David Nind  ---
Testing notes (koha-testing-docker (KTD)):

1.  Install telnet: apt-get install telnet

2.  SIP user already setup in KTD - koha-sip with login name term1 which is
included in the SIPconfig.xml. Accessing SIP server as per step 2 of the test
plan works as expected.

3.  IssueLog is already set to 'Log' in KTD.

4.  Responses for entries - basically checks out a book (barcode -
30001) to Koha Admin (card number - 1) and returns it (note for 4.2
this is all one entry on one line):

4.1 9300CNterm1|COterm1|CPCPL|
=> 941

4.2 11YN2021101010565320211010   
105653AOCPL|AA1|AB30001|ACterm1|BON|BIN|
=> 121NNY20211030200556AOCPL|AA1|AB30001|AJE Street shuffle
:|AH20211104235900|
=> Log entry (when recorded): 
   . Date: 10/30/2021 20:05 [will be the date and time action performed]
   . Librarian: koha_sip (53)
   . Module: Circulation
   . Action: Checkout
   . Object: Koha Admin (1)
   . Info: Item 30001 [Linked to item]
   . Interface: SIP 

4.3 09N2021101010564420211010   
105644APCPL|AOCPL|AB30001|ACterm1|BIN|
=> 101YNN20211030200704AOCPL|AB30001|AQCPL|AJE Street shuffle
:|AA1|
=> Log entry (when recorded): 
   . Date: 10/30/2021 20:07 [will be the date and time action performed]
   . Librarian: koha_sip (53)
   . Module: Circulation
   . Action: Return
   . Object: Koha Admin (1)
   . Info: Item 30001 [Linked to item]
   . Interface: SIP

5.  If the telnet connection is closed or automatically times out enter
9300CNterm1|COterm1|CPCPL| after reconnecting. Note that when you reconnect it
will pick up any system preference changes, so depending on where you are in
testing you may need to start again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871

David Nind  changed:

   What|Removed |Added

 Attachment #126016|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 127111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127111=edit
Bug 26871: Flush SIP2 cache on every SIP request

SIP connections tend to be long lived, weeks if not months, in the
libraries I see. Basically the connection per SIP machine is initiated
once when the SIP machine boots and then never closed until
maintanance needs to be done. Therefore we need to reset the Koha's L1
caches on every SIP request to get the latest sysprefs and configs
from the memcached cache that is shared between all the Koha
programs (intranet, opac, sip, cronjobs) and is guaranteed to be up to
date.

To test:
 0. Have kohadevbox
 1. Enable IssueLog
 2. In one terminal run the command "perl C4/SIP/SIPServer.pm
/etc/koha/sites/kohadev/SIPconfig.xml"
 3. Checkin and return a book using telnet:

$ telnet localhost 6001
9300CNterm1|COterm1|CPCPL|
11YN2021101010565320211010   
105653AOCPL|AA1|AB30001|ACterm1|BON|BIN|
09N2021101010564420211010   
105644APCPL|AOCPL|AB30001|ACterm1|BIN|

 4. Keep the telnet connection open and go to
http://localhost:8081/cgi-bin/koha/tools/viewlog.pl and check that
the *checkout* entry is in the circulation rules 5.
 6. Disable IssueLog
 7. Move back to the telnet prompt and check out and return a book again

11YN2021101010565320211010   
105653AOCPL|AA1|AB30001|ACterm1|BON|BIN|
09N2021101010564420211010   
105644APCPL|AOCPL|AB30001|ACterm1|BIN|

 8. Go check out the circulation logs and notice a new entry was added
when it shouldn't have according to the IssueLog syspref!
 9. Apply patch and repeat steps to notice that the syspref is now
followed correctly.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

--- Comment #9 from Joonas Kylmälä  ---
Created attachment 127110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127110=edit
Bug 28263: (QA follow-up) Use new atomicupdate code style

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29196] Follow-up to Bug 27068 - Remove unnecessary check

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29196

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||joonas.kylm...@iki.fi

--- Comment #6 from Joonas Kylmälä  ---
Kyle, please provide unit tests for the 'holdgroup' and 'patrongroup' cases to
highlight this bug and fix the commit message to describe the bug (so basically
copy the commit message from Nick's patch)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@iki.fi

--- Comment #20 from Joonas Kylmälä  ---
This broke a few scripts, please review bug 29380 which contains fixes for
those.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380

--- Comment #1 from Joonas Kylmälä  ---
Created attachment 127109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127109=edit
Bug 29380: Correct table name in joins to prevent errors

The commit "Bug 29290: Rename relationships borrower =>
patron" (d46492ac23) renamed the relation for the borrowers table from
'borrower' to 'patron' but the joins were not updated accordingly so a
few scripts got broken.

To test:
 1) Notice that
$ perl misc/cronjobs/automatic_renewals.pl -c -s -v
returns 255 error code on exit
 2) Apply patch
 3) Notice the automatic_renewals.pl works now and exit code is 0
 4) Make sure /cgi-bin/koha/tools/batch_extend_due_dates.pl works.
 5) Try to grep for 'borrower' in Koha source code and see if there
are any other join done using the Koha::Checkout or
Koha::Old::Checkout objects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29380] Auto renewing, batch due date extension tool and checkout note previews are broken

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29290] Add routes to fetch checkouts for a given biblio

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290

Joonas Kylmälä  changed:

   What|Removed |Added

 Blocks||29380


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380
[Bug 29380] Auto renewing, batch due date extension tool and checkout note
previews are broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29380] New: Auto renewing, batch due date extension tool and checkout note previews are broken

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29380

Bug ID: 29380
   Summary: Auto renewing, batch due date extension tool and
checkout note previews are broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: critical
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: joonas.kylm...@iki.fi
  Reporter: joonas.kylm...@iki.fi
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.druart+k...@gmail.com,
martin.renvo...@ptfs-europe.com, tomasco...@gmail.com
Depends on: 29290

The table joins were not changed to use the new name in bug 29290 so a few
scripts got broken.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29290
[Bug 29290] Add routes to fetch checkouts for a given biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

Joonas Kylmälä  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi
   |y.org   |
 CC||joonas.kylm...@iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

Joonas Kylmälä  changed:

   What|Removed |Added

 Attachment #126787|0   |1
is obsolete||

--- Comment #8 from Joonas Kylmälä  ---
Created attachment 127108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127108=edit
Bug 28263: Fix too_many auto renewal message

To test:
1. Make an item eligible for auto_renewal.
2. Set circ rule so only 1 auto_renewal is allowd.
3. Run auto_renew once, get a successful message.
4. Run it again and get the too_many error "You have reached the maximum number
of checkouts possible."
5. This has nothing to do with the number of checkouts
6. Apply patch and updatedatabase.
7. Do 1-4 again.
8. Message is now "You have reached the maximum number of renewals possible."

Signed-off-by: David Nind 

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28263] AUTO_RENEWAL message for 'too_many' is wrong

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||joonas.kylm...@iki.fi

--- Comment #5 from Joonas Kylmälä  ---
This messes up the statistic table, people are expecting there to be
'OPACRenew' as the value and not NULL. If you don't want to make this a huge
patch I would suggest to just drop the foreign key for the
'transaction_branchcode' in pseudonymized_transactions table. I also assume
people don't want there to be foreign key relation in order to be able to
delete branches and still keep the stats in place.

However, if you want to go the original patch's route, which I think not, then
the change should be done in Koha::Item::renewal_branchcode instead. The
syspref documentation and database upgrade would need to be provided as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #5 from Pavel Bédi  ---
(In reply to Katrin Fischer from comment #4)
> Did it work alright? Leaving this open as we still need to fix it in Koha.

Yes, thank you very much!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Katrin Fischer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|LATER   |---

--- Comment #4 from Katrin Fischer  ---
Did it work alright? Leaving this open as we still need to fix it in Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Pavel Bédi  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |LATER

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29379] SPAM

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29379

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
Summary|How to Increase your|SPAM
   |Assignment Grades?  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29379] New: How to Increase your Assignment Grades?

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29379

Bug ID: 29379
   Summary: How to Increase your Assignment Grades?
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: About
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alisahwil...@gmail.com
QA Contact: testo...@bugs.koha-community.org

With technological progress, the education system is evolving. Everything can
now be found on the internet. It'll be there on the internet and you name it.
The same applies to assignment tasks as well. It was a challenging time before
their due date to finish them. Now you can search on the Internet for
assignment help online and you'll find efficient writers prepared to schedule
your student database management assignment. Your assignment grades are
determined by two primary aspects i.e. submission before the deadline and
quality of the codes. You should review the profiles before you handle your
work and your money when searching for an assignment to accomplish your
database management project. 
https://www.allassignmenthelp.co.uk/
https://www.allassignmenthelp.co.uk/database-management-assignment-help.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #3 from Katrin Fischer  ---
Ok, the problem is that the version in Koha.pm doesn't match the one in the
database because of a forgotten database update. When they both match again,
you will get out of the installer loop.

Koha.pm has:
$VERSION = "21.05.05.000";

So this should do the trick:
UPDATE systempreferences SET value = "21.0505000" where variable = "Version";

You might need to restart Plack/Memcached for Koha to take notice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

--- Comment #2 from Pavel Bédi  ---
(In reply to Katrin Fischer from comment #1)
> Hi Pavel,
> there is actually a small mistake in the version that is causing this that
> will be fixed as soon as possible. Do you have access to your database with
> SQL?

Yes, I have.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |blocker
 CC||k...@bywatersolutions.com

--- Comment #1 from Katrin Fischer  ---
Hi Pavel,
there is actually a small mistake in the version that is causing this that will
be fixed as soon as possible. Do you have access to your database with SQL?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29378] New: After the automatic update to 21.05.05, the OPAC switches to maintenance mode and the web installer is displayed

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29378

Bug ID: 29378
   Summary: After the automatic update to 21.05.05, the OPAC
switches to maintenance mode and the web installer is
displayed
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: resetka.b...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I wanted to log in to the Staff interface after the automatic update on
21.05.05 but I saw Welcome to the Koha 21.05 web installer. So I logged in with
the data I found in the koha-conf.xml configuration file. After a few steps, I
updated the database from version 21.05.04.003 to 21.05.05.000. It wrote that
the operation was successful and I was able to continue to the login page.
Unfortunately, I got back to the Check Perl dependencies installation wizard.
URL structure is:
http://staff-library.sample.com/cgi-bin/koha/installer/install.pl?step=1=updatestructure

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29377] SPAM

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29377

Katrin Fischer  changed:

   What|Removed |Added

Summary|I am a Software developer   |SPAM
   |.We provide best security   |
   |services in usa.|
 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29375] Excessive regular expressions

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375

Andrii Veremeienko  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29375] Excessive regular expressions

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375

Andrii Veremeienko  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |andriive...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29375] Excessive regular expressions

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29375

--- Comment #1 from Andrii Veremeienko  ---
Created attachment 127107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127107=edit
Bug 29375: Excessive regular expressions

There are several places throughout the application where regular expressions
are used for the whitespaces trimming together with the normalization function
C4::Circulation::barcodedecode.

Solution was to remove those regular expressions, because
C4::Circulation::barcodedecode trimming whitespaces by itself.

How to test:
1. Go to the Koha code base;
2. Do global search by "barcodedecode" key word;
3. Observe that there are several places where barcodedecode used with regular
expression together;
4. Apply the patch;
5. Repeat steps 1, 2;
6. Observe that there are no regular expressions used together with
barcodedecode;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29376] SPAM

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29376

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
Summary|Tech pro service|SPAM
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28448] Record with too many items is not shown in results

2021-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28448

--- Comment #15 from Fridolin Somers  ---
See Bug 10482
We have this code for some libraries with records having more than 1000 items

I don't know which limit is in Zebra against this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/