[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

--- Comment #134 from Victor Grousset/tuxayo  ---
and issue a. is fixed :D

thanks for the other fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #17 from Victor Grousset/tuxayo  ---
works (tested on bib record, auth, item and hold cancel, ram usage decreased),
QA script happy, code look ok.

Passed!

It's surprising that these classes take dozens of MB of RAM to load.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #127081|0   |1
is obsolete||

--- Comment #16 from Victor Grousset/tuxayo  ---
Created attachment 127329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127329=edit
Bug 28413: Reduce background job worker memory footprint

It's loading the modules in RAM then forks.
Then do not need it to have them loaded in the parent process (the
worker/daemon).

Signed-off-by: Martin Renvoize 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This enhancement changes
  release notes||the batch item modification
   ||and deletion tools so that
   ||they now use the task queue
   ||feature (added in Koha
   ||21.05) instead of using
   ||background jobs. For the
   ||library staff member this
   ||provides more information
   ||on the progress of the
   ||task.
   Keywords|release-notes-needed|Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
   Keywords|release-notes-needed|
  Text to go in the||This enhancement to the
  release notes||OPAC enables the display of
   ||multiple cover images on
   ||the detail page for a
   ||record in a light box.
   ||Previously only one image
   ||was displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28769] tabloop not used in cataloguing plugins

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28769

David Nind  changed:

   What|Removed |Added

  Text to go in the||This technical change
  release notes||removes the "tabloop"
   ||variable that is passed
   ||from the add item form
   ||logic to the cataloguing
   ||plugins, as it is never
   ||used.
   Keywords|release-notes-needed|
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds
  release notes||additional logging of
   ||acquisition-related changes
   ||including:
   ||- Order line
   ||creation and cancellation
   ||-
   ||Invoice adjustment
   ||additions, amendments and
   ||deletions
   ||- Order line
   ||receipts against an invoice
   ||- Budget adjustments
   ||- Fund
   ||adjustments
   ||- Order release
   ||date
   ||
   ||The name of the
   ||system preference that
   ||enables logging of
   ||acquisition-related changes
   ||was changed from AcqLog to
   ||AcquisitionLog.
   ||
   ||Note:
   ||Acquisition logging was
   ||added in Koha 21.05.
 CC||da...@davidnind.com
   Keywords|release-notes-needed|Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12561] Remove non-XSLT views

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
   Keywords|release-notes-needed|
  Text to go in the||This removes the non-XSLT
  release notes||views feature that was
   ||deprecated from July 2014.
   ||
   ||As part of this change:
   ||-
   ||system preferences
   ||HighlightOwnItemsOnOPAC and
   ||HighlightOwnItemsOnOPACWhic
   ||h are removed
   ||- a warning
   ||is added to the about page
   ||if a default XSLT file was
   ||removed, or if a file
   ||referenced in one of the
   ||system preferences does not
   ||exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||wizzy...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #1 from Liz Rea  ---
Created attachment 127328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127328=edit
Bug 29420 - 401 Unauthorized pages come back is 200 OK under plack

To test:

- create an alias in your /etc/koha/sites/.conf file for something like
files
   Alias /files "/var/lib/koha/kohadev/public_html/"
   
 Options +Indexes
 AuthUserFile /var/lib/koha/kohadev/.htpasswd
 AuthName ByPassword
 AuthType Basic
 
   require valid-user
 
   
- make a .htpasswd file: https://hostingcanada.org/htpasswd-generator/ and put
it in /var/lib/koha/kohadev
- restart apache
- navigate to http:///files, note that the response header in the
browser inspector says "200 OK" and the basic auth user/pass is not shown
- Apply this patch, restart the things
- navigate to http:///files, note that the response header in the
browser inspector says "401 Unauthorized" and the basic auth user/pass is now
shown

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] New: 401 Unauthorized pages come back as 200 OK under plack

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

Bug ID: 29420
   Summary: 401 Unauthorized pages come back as 200 OK under plack
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org

We have a use case where we define Aliases in Apache for things like
some.koha.url/files that are .htpasswd protected. In 21.05 and later, 401
Unauthorized responses go through Koha and become 200 OK. 

We should make the 401 Unauthorized pages come back as 401 Unauthorized, so
that browsers know what to do when BasicAuth is requested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18984] Remove support for NORMARC

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18984

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||The National library of
  release notes||Norway has replaced NORMARC
   ||with MARC21. Koha instances
   ||that use NORMARC have
   ||either been converted to
   ||MARC21, or will need to
   ||convert as part of any
   ||upgrade (from Koha 21.11
   ||onwards).
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27622] Remove nb-NO installer data

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622

David Nind  changed:

   What|Removed |Added

  Text to go in the|This removes the SQL|This enhancement removes
  release notes|installer directory from|Norwegian installer data.
   |the Koha source code.   |Installer data is now in
   |Installing Norwegian sample |YAML format and there is no
   |data will still be  |need for localized
   |possible, but translations  |installer files (these are
   |have been moved into Koha's |now translated using Koha's
   |translation system using|translation system using
   |.po files maintained on |.po files maintained on
   |https://translate.koha-comm |https://translate.koha-comm
   |unity.org.  |unity.org).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27101] Remove fr-CA installer data

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101

David Nind  changed:

   What|Removed |Added

  Text to go in the|This enhancement removes|This enhancement removes
  release notes|fr-CA installer data.   |fr-CA installer data.
   |Installer data and  |Installer data is now in
   |translations are now in |YAML format and there is no
   |YAML format and there is no |need for localized
   |need for localized  |installer files (these are
   |installer files.|now translated using Koha's
   ||translation system using
   ||.po files maintained on
   ||https://translate.koha-comm
   ||unity.org).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27622] Remove nb-NO installer data

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622

David Nind  changed:

   What|Removed |Added

  Text to go in the||This removes the SQL
  release notes||installer directory from
   ||the Koha source code.
   ||Installing Norwegian sample
   ||data will still be
   ||possible, but translations
   ||have been moved into Koha's
   ||translation system using
   ||.po files maintained on
   ||https://translate.koha-comm
   ||unity.org.
   Keywords|release-notes-needed|
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #133 from Victor Grousset/tuxayo  ---
I can still reproduce easily comment 128 's *f* test on Firefox and Chromium.

I can reproduce c. using Chromium, going in the network dev tab, network
conditions (wireless icon), network throttling, adding a custom profile with 2
seconds of latency.

That 2 second latency allows me to reproduce d. also.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27101] Remove fr-CA installer data

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27101

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement removes
  release notes||fr-CA installer data.
   ||Installer data and
   ||translations are now in
   ||YAML format and there is no
   ||need for localized
   ||installer files.
   Keywords|release-notes-needed|
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29391] Improve output of reservoir search

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #3 from Barbara Johnson  ---
Very nice update.  I especially like that the import date was added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29391] Improve output of reservoir search

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #127216|0   |1
is obsolete||

--- Comment #2 from PTFS Europe Sandboxes  ---
Created attachment 127327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127327=edit
Bug 29391: Improve output of reservoir search

This patch makes the cataloging reservoir search results a configurable
DataTable. The empty edition and date columns are removed, and an import
data column is added.

To test, apply the patch and go to Cataloging.

- Perform a cataloging search which will return results from the
  reservoir.
- The table of reservoir search results should be a DataTable with
  paging, navigation, filtering, column configuration, etc.
  - Confirm that all DataTable controls work correctly.
- Go to Administration -> Table settings -> Cataloging -> addbooks.
  - Try modifying the default configuration and confirm that the
settings take effect.

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #15 from David Cook  ---
(In reply to Katrin Fischer from comment #14)
> Maybe a solution could then be to change the email to be send directly then
> instead of via the message queue?
> 
You're probably right about that being the best way, although it is nice to
have an entry in the message queue for reviewing/logging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573

Rhonda Kuiper  changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

--- Comment #17 from Rhonda Kuiper  ---
Please backport this to 21.05.  The problem fixed by this bug is creating a lot
of extra work for our catalogers that we didn't have to do when we were on
20.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #14 from Katrin Fischer  ---
Maybe a solution could then be to change the email to be send directly then
instead of via the message queue?

The overdue_notices.pl script creates an email with attached overdue messages
to be sent to the library when a user should receive an overdue notice, but has
no email address.

How I would test:

* You'll need a patron without email address with overdues.
* Notice triggers where one or more of the delays match the overdue item.
* Run the overdue_notices.pl with -t (use triggers)
* You don't need to set up fines.

I believe the code is all in the (very long) overdue_notices.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Nick Clemens  changed:

   What|Removed |Added

 Attachment #127325|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 127326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127326=edit
Bug 29418: Screen ending colons from search term

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29419] New: suggest for purchase clears itemtype if bib exists

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419

Bug ID: 29419
   Summary: suggest for purchase clears itemtype if bib exists
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org

From the Submit a New Purchase Suggestion function, if the system recognizes
the title in one way or another,  the system will give the patron the message s
message before proceeding with the purchase suggestion: A similar document
already exists. Click on confirm your suggestion to ignore this message.

At this point, the (document)item type has gone back to, "None." If the patron
scrolls down and clicks on "Confirm your suggestion" anyways, and doesn't
change the item type a second time, then this is where the system allows for
the suggestion to be submitted without the item type. 

The item type needs to be retained.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean search and so results in error

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #1 from Nick Clemens  ---
Created attachment 127325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127325=edit
Bug 29418: Screen ending colons from search term

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29418] New: Zebra clean_search_term does not clean search and so results in error

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Bug ID: 29418
   Summary: Zebra clean_search_term does not clean search and so
results in error
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com

In fixing/moving analytics search code, zebra was set to simply pass the title
through.

For any title with a subtitle, correct marc for subfield a ends with a
semicolon.

This is treated as a field delimiter and the search fails

This is causing a spurious warning for many records under zebra:
There was an error searching for analytic records, please see the logs for
details.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926

--- Comment #6 from Mason James  ---
(In reply to Jonathan Druart from comment #2)
> root@kohadevbox:koha(master)$ apt-cache policy libjson-validator-perl
> libjson-validator-perl:
>   Installed: 3.25+dfsg-1+koha3
>   Candidate: 3.25+dfsg-1+koha3
>   Version table:
>  *** 3.25+dfsg-1+koha3 500
> 500 http://debian.koha-community.org/koha-staging dev/main amd64
> Packages
> 100 /var/lib/dpkg/status
>  0.92+dfsg-1 500
> 500 http://httpredir.debian.org/debian stretch/main amd64 Packages
> 
> 
> Why is JSON::Validator 3.14?

the package name has now been updated/corrected to handle deb12

$ apt-cache policy libjson-validator-perl
libjson-validator-perl:
  Installed: 4.99.1+really3.14-koha3
  Candidate: 4.99.1+really3.14-koha3
  Version table:
 *** 4.99.1+really3.14-koha3 500
500 http://debian.koha-community.org/koha 20.11/main amd64 Packages
100 /var/lib/dpkg/status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #127318|0   |1
is obsolete||

--- Comment #6 from Andrew Fuerste-Henry  ---
Created attachment 127324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127324=edit
Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests

It is a confusing name because we have 'Article Request' as a feature,
and this does not follow Koha terminology.

Test plan:
`updatedatabase` and confirm that the syspref has been renamed
`git grep RequestOnOpac` => No occurrence in the code

QA: The syspref's value is always retrieved using Koha.Preference from
.tt files, we don't need to send it from controllers or C4::Auth

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29357] "Results" in the results browser is untranslatable (intranet)

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29357

Marie-Luce Laflamme  changed:

   What|Removed |Added

 CC||marie-luce.laflamme@inlibro
   ||.com

--- Comment #2 from Marie-Luce Laflamme  ---
I may have found it in Pootle:

fr_CA > Koha version > fr-CA-messages-js.po
Search the word "Results"
location = koha-tmpl/intranet-tmpl/prog/js/browser.js:97


Thanks to Philippe, who pointed me out the file location fr-CA-messages-js.po


Translations were missing in Koha 20.05, and 20.11 only. It was already in the
21.05 version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26394] .mailmap needs to be updated

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26394

Ahmed  changed:

   What|Removed |Added

 CC||ahmedsayeed1...@yahoo.com

--- Comment #12 from Ahmed  ---
no longer builds on aarch64 (native build) after updating to glibc-2.33. 
http://www-look-4.com/services/usb-type-a/

Due to a glibc 2.33 header file change, the file
http://the-hunters.org/category/computers/
nat/aarch64-linux-hw-point.c no longer builds on OSes using this version of
glibc.
https://komiya-dental.com/services/huawei-service/
An enum for PTRACE_SYSEMU is now provided by .  In the 
past, PTRACE_SYSEMU was defined only in .  This is
http://www.iu-bloomington.com/property/properties-in-turkey/
what it looks like...

In : https://waytowhatsnext.com/crypto/cryptocurrency-taxes/

#define PTRACE_SYSEMU 31
http://www.wearelondonmade.com/health/check-ups/

In :
http://www.jopspeech.com/services/surface-duo/
enum __ptrace_request
{ http://joerg.li/services/kia-rio-price/
  ...
  PTRACE_SYSEMU = 31,  
#define PT_SYSEMU PTRACE_SYSEMU

  ... http://connstr.net/services/mobile-games/
}

When  and  are both included in a source
http://fishingnewsletters.co.uk/category/computers/
file, we run into the following build problem when the former is
included before the latter: http://embermanchester.uk/tech/google-drive/

In file included from nat/aarch64-linux-hw-point.c:26:
http://www.go-mk-websites.co.uk/category/computers/
/usr/include/sys/ptrace.h:86:3: error: expected identifier before numeric
constant
   86 |   PTRACE_SYSEMU = 31,
http://www.slipstone.co.uk/technology/cars-interior/
  |   ^

(There are more errors after this one too.)
http://www.logoarts.co.uk/technology/robot-vacuums/
The file builds without error when  is included after
http://www.mconstantine.co.uk/category/computers/
.  I found that this is already done in
http://www.acpirateradio.co.uk/health/transportation-security/ 
nat/aarch64-sve-linux-ptrace.h (which is included by
nat/aarch64-linux-ptrace.c).
http://www.compilatori.com/health/premium-subscription/

A commit for this bug is already on the trunk:
https://www.webb-dev.co.uk/computers/crypto-apps/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26621] .mailmap adjustments

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26621

Ahmed  changed:

   What|Removed |Added

 CC||ahmedsayeed1...@yahoo.com

--- Comment #18 from Ahmed  ---
/gdb/arch/arc.c:117:43:   required from here http://www.compilatori.com/
 /usr/include/c++/4.8.2/bits/hashtable_policy.h:195:39: error: no matching
https://www.mktrade.fi/ function for call to ‘std::pairhttp://www-look-4.com/
target_desc_deleter> >::pair(const arc_arch_features&, target_desc*&)’
  : _M_v(std::forward<_Args>(__args)...) { } http://www.acpirateradio.co.uk/
   ^ 
/usr/include/c++/4.8.2/bits/hashtable_policy.h:195:39: note: candidates are:
https://www.webb-dev.co.uk/
In file included from /usr/include/c++/4.8.2/utility:70:0,
 from /usr/include/c++/4.8.2/tuple:38,
http://www.logoarts.co.uk/
 from /usr/include/c++/4.8.2/functional:55, 
 from ../../gdb/../gdbsupport/ptid.h:35,
https://komiya-dental.com/
 from ../../gdb/../gdbsupport/common-defs.h:123,
 from ../../gdb/arch/arc.c:19: http://www.slipstone.co.uk/
/usr/include/c++/4.8.2/bits/stl_pair.h:206:9: note: templatehttp://the-hunters.org/  class ... _Args2, long
unsigned int ..._Indexes2> std::pair<_T1, http://embermanchester.uk/
_T2>::pair(std::tuple<_Args1 ...>&, std::tuple<_Args2 ...>&, std::_Index_tuple
http://fishingnewsletters.co.uk/
 <_Indexes1 ...>, std::_Index_tuple<_Indexes2 ...>)
 pair(tuple<_Args1...>&, tuple<_Args2...>&, http://connstr.net/
 ^
>8-
http://joerg.li/
Thanks to Tome de Vries' investigation, same fix applies in ARC's case as well:
8<- http://www.jopspeech.com/
diff --git a/gdb/arch/arc.c b/gdb/arch/arc.c
index 3808f9f..a5385ce 100644 http://www.go-mk-websites.co.uk/
--- a/gdb/arch/arc.c
+++ b/gdb/arch/arc.c http://www.wearelondonmade.com/
@@ -114,7 +114,7 @@ struct arc_arch_features_hasher
   target_desc *tdesc = arc_create_target_description (features);
https://waytowhatsnext.com/

   /* Add the newly created target description to the repertoire.  */
http://www.mconstantine.co.uk/
 -  arc_tdesc_cache.emplace (features, tdesc); http://www.iu-bloomington.com/
 +  arc_tdesc_cache.emplace (features, target_desc_up (tdesc));

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Christian Stelzenmüller  changed:

   What|Removed |Added

 CC||christian.stelzenmueller@bs
   ||z-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29417] New: Automatically update 77x fields when records are merged

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29417

Bug ID: 29417
   Summary: Automatically update 77x fields when records are
merged
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When 2 records are merged that are linked to analytical records using 773 (or
potentially other 7xx) fields, it would be great, if Koha could update the
links in the records linked to the losing recoed automatically, similar to how
this is done for authorities.

If the library is using UseControlNumber this should also include the $w
subfields.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27647] Allowing Lists to have a Hierarchical Structure

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27647

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

--- Comment #1 from Sarah Cornell  ---
We are also interested in being able to organize lists hierarchically as well,
at a public library.  At our main branch we have adult, teen, and youth lists,
and each of our 5 schools also makes lists.  Currently they are in one LONG
LIST.  And the pull-down menus are a nightmare when trying to find a particular
one.  

I envision something like the reports module, where we can assign a group and a
subgroup, maybe even metadata/notes suggested in bug 28795.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25498] Cannot change owner of list

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28795] ability to add metadata to lists

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28795

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

--- Comment #1 from Sarah Cornell  ---
Agreed! We have public lists that we would like to describe for users,
indicating when they are updated or their association with a program, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11889] Disown a list

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20172] Add a search bar in list tables

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20172

Sarah Cornell  changed:

   What|Removed |Added

 CC||sbcornell@cityofportsmouth.
   ||com

--- Comment #5 from Sarah Cornell  ---
Agreed!  Especially considering the work being done on bugs 26446 and 19501 to
make the lists module a robust staff tool.  Staff will want to be able to
search within the lists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #6 from Martin Renvoize  ---
All works as expected, nice fix.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127294|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 127323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127323=edit
Bug 29411: Redirect to circulation if circsearch is true

TO test:
 1 - Have a patron with a unique surname i.e. Acosta
 2 - Enter the surename into 'Search patrons' box on staff homepage
 3 - You are redirected to 'members/moremember.pl'
 4 - Enter the surname into 'Check out' box at top of page
 5 - You are redirected to 'members/moremember.pl'
 6 - Apply patch
 7 - Enter the surename into 'Search patrons' box on staff homepage
 8 - You are redirected to 'members/moremember.pl'
 9 - Enter the surname into 'Check out' box at top of page
10 - You are redirected to 'circ/circulation.pl'

Signed-off-by: Owen 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29397] Add a select2 wrapper for the API

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397

Martin Renvoize  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29397] Add a select2 wrapper for the API

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397

--- Comment #9 from Martin Renvoize  ---
Tested and signed off on the follow-up :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29397] Add a select2 wrapper for the API

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127281|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 127322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127322=edit
Bug 29397: Use kohaSelect for pickup locations

This patch makes the pickup location dropdowns that rely on Select2 and
the API use the new wrapper. The original transport function is removed
as it is now embedded in the wrapper.

To test:
1. Follow bug 29404 test plan
=> SUCCESS: All works
2. Apply this patches
3. Repeat 1
=> SUCCESS: All works!
4. sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29397] Add a select2 wrapper for the API

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127280|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 127321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127321=edit
Bug 29397: Add function documentation

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29397] Add a select2 wrapper for the API

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127279|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 127320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127320=edit
Bug 29397: Add .kohaSelect select2 wrapper function

This patch adds a kohaSelect wrapper function to simplify
paging/infinite scrolling with select2 using the Koha RESTful api's.

Invoke select2 select boxes as you normally would from JS, but instead
of calling .select2(config) use .kohaSelect(config).

If an 'ajax' property is defined in your config object, we wrap the
transport such that responses include a pagination key as expected by
select2.

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336

--- Comment #19 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #18)
> Still nice to have in 21.11 ?

I would prefer to not rush it and wait for 22.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29397] Add a select2 wrapper for the API

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397

--- Comment #5 from Martin Renvoize  ---
Thanks for the documentation follow-up Tomas :).. nice to see the
pickup_locations code show this in use too :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136

--- Comment #1 from Jonathan Druart  ---
If anybody is interested in this, please have a look at bug 15812 comment 37.
IMO we shouldn't follow what has been done on bug 15812.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Martin Renvoize  ---
Nice bit of code cleanup and DRYing out.

No regressions found, QA script is happy, and code is clear.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127316|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 127319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127319=edit
Bug 29407: Make the pickup locations dropdown JS reusable

This patch generates a function to be used in places where select2
dropdowns are usesd for choosing pickup locations. This cleans
repeated/almost identical code introduced by different bugs.

To test:
1. Make sure choosing pickup locations works
2. Apply this patch
3. Repeat 1
=> SUCCESS: No functional changes
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Nick Clemens 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on||29416


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416
[Bug 29416] Regression: information from existing bib no longer populating on
suggest for purchase
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||29416


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416
[Bug 29416] Regression: information from existing bib no longer populating on
suggest for purchase
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29416] New: Regression: information from existing bib no longer populating on suggest for purchase

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416

Bug ID: 29416
   Summary: Regression: information from existing bib no longer
populating on suggest for purchase
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 14963
Blocks: 29311

When suggesting an existing title for purchase, we should copy bib information
from the record into the suggestion. This used to happen, but has broken in
master and 21.05 (I think 21.05.04 and later). Maybe due to bug 28941? That's a
shot in the dark, but is the last update to opac-suggestions.pl.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
[Bug 14963] Add the ability to suggest purchase from existing titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311
[Bug 29311] Do not allow editing of bibliographic information when entering
suggestion from existing bibs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29123] Add Dataly Tech to About page

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29123

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29195] Highlighting broken on odd rows in circ-patron-search-results

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29195

--- Comment #3 from Jonathan Druart  ---
Do we go with the '!important'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
   Keywords||rel_21_11_candidate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180

--- Comment #5 from Jonathan Druart  ---
Created attachment 127318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127318=edit
Bug 29180: Rename syspref RequestOnOpac with OPACHoldRequests

It is a confusing name because we have 'Article Request' as a feature,
and this does not follow Koha terminology.

Test plan:
`updatedatabase` and confirm that the syspref has been renamed
`git grep RequestOnOpac` => No occurrence in the code

QA: The syspref's value is always retrieved using Koha.Preference from
.tt files, we don't need to send it from controllers or C4::Auth

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29415] New: Wrong number of received items/quantity shown in several places

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29415

Bug ID: 29415
   Summary: Wrong number of received items/quantity shown in
several places
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

For standing orders there is something not correct with the way the number of
items received is calculated.

A Order
1) Create a basket as standing order
2) Create an order for any record in your catalog
3) Verify quantity is 1 (always for standing orders)

B Receive
1) Receive shipment for your order
2) Make sure to change quantity received to something higher than 1
3) Finish receiving

C Verify display
1) Search for your invoice on the invoices page
2) Verify it shows quantity received as entered
3) Got to invoice details page
   /cgi-bin/koha/acqui/invoice.pl?invoiceid=1
4) Verify it still shows 1 as quantity - should show the received quantity

5) Click on the record's title to go to the detail page
6) Switch to acquistion detail tab
7) Verify it shows 1 too - should differentiate between ordered/received

I think the first (invoice) is clearly a bug, the second might be seen as a
display error, but we should specify which quantity is shown and possibly add a
display for ordered / received. If the status is received the info on the acq
tab is definitely misleading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||29311


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311
[Bug 29311] Do not allow editing of bibliographic information when entering
suggestion from existing bibs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Depends on||14963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
[Bug 14963] Add the ability to suggest purchase from existing titles
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782

Jonathan Druart  changed:

   What|Removed |Added

 CC||andriive...@gmail.com

--- Comment #20 from Jonathan Druart  ---
*** Bug 29259 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29259] Url contains slash '/' instead of encoded slash '%2F'

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29259

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #2 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 28782 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28692] Reduce DB action_log table size

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28692

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29413

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29413] CataloguingLog doesn't allow to see changes for first edit of an item

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29413

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28692
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
See also bug 28692 comment 18.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24147] Objects.t is failing randomly

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24147

--- Comment #21 from Jonathan Druart  ---
Koha_Master_D11_My8/686 Docker_2

13:24:48 koha_1   | #   Failed test 'Koha::Objects->search_related
should work as expected'
13:24:48 koha_1   | #   at t/db_dependent/Koha/Objects.t line 163.
13:24:48 koha_1   | 
13:24:48 koha_1   | #   Failed test 'Koha::Objects->search_related
should work as expected'
13:24:48 koha_1   | #   at t/db_dependent/Koha/Objects.t line 183.
13:24:48 koha_1   | # Looks like you failed 2 tests of 6.
13:24:48 koha_1   | 
13:24:48 koha_1   | #   Failed test 'search_related'
13:24:48 koha_1   | #   at t/db_dependent/Koha/Objects.t line 186.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28474] Pass process_message_queue.pl params to before_send_messages plugin hooks

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28474

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This enhancement passes the
  release notes||parameters received by
   ||process_message_queue.pl
   ||through to the
   ||before_send_messages plugin
   ||calls. This allows plugins
   ||to respect calls that
   ||should only affect certain
   ||letter codes etc.
   Keywords|release-notes-needed|
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28211] Replace use of call_recursive() with call()

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28211

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This enhancement changes
  release notes||the way plugin hooks are
   ||called to transform data.
   ||We now pass object to be
   ||modified as a reference,
   ||thus allowing several
   ||plugins to operate
   ||cumulatively on the same
   ||object.
   Keywords|release-notes-needed|
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153

Nick Clemens  changed:

   What|Removed |Added

   Keywords|release-notes-needed|
  Text to go in the||This enhancement allows
  release notes||staff/patrons to control
   ||individual preferences for
   ||holds reminder noticess in
   ||the patron's messaging
   ||preferences area.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27985] Add option for using a MARC modification template on a single record from the details page

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27985

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This development allows for
  release notes||sending a single record to
   ||'batch' modification in
   ||order to process a MARC
   ||modification template
   ||against the record.
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404

Nick Clemens  changed:

   What|Removed |Added

 Attachment #127262|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 127317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127317=edit
Bug 29404: Add infinite scrolling to pickup location dropdowns

This patch adds infinite scrolling to the pickup locations select2
dropdowns on the staff interface.

It does so by adding a new transport function (in select2.js) to read
the response headers Koha's API sends back, and converting to the right
data structure Select2 expects for the feature to work.

This is manually used in the different pickup locations dropdowns.
There's a separate bug that will introduce a select2 wrapper that will probably
embed this function in it.

To test:
1. Run the [DO NOT PUSH] script inside koha-shell to generate random
   pickup locations:
   $ kshell
  k$ perl generate_pickup_locations.pl
2. Try placing holds. Notice the visible pickup locations dropdowns
   display some pickup locations based on the matches you got. They are
   all fetched once
=> SUCCESS: It works
3. Repeat for the current holds page and the patron holds listing
=> SUCCESS: Same behavior
4. Apply this patch
5. Repeat 2 and 3
=> SUCCESS: Things work, but pickup locations are retrieved as needed,
while you scroll.
6. Sign off :-D

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407

Nick Clemens  changed:

   What|Removed |Added

 Attachment #127278|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 127316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127316=edit
Bug 29407: Make the pickup locations dropdown JS reusable

This patch generates a function to be used in places where select2
dropdowns are usesd for choosing pickup locations. This cleans
repeated/almost identical code introduced by different bugs.

To test:
1. Make sure choosing pickup locations works
2. Apply this patch
3. Repeat 1
=> SUCCESS: No functional changes
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29407] Make the pickup locations dropdown JS reusable

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

--- Comment #18 from Martin Renvoize  ---
Amendments to documentation made, with agreements from Tomas.. back to PQA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

--- Comment #17 from Martin Renvoize  ---
Created attachment 127315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127315=edit
Bug 29408: Add JSDoc documentation for kohaTable function

This patch adds some JSDoc formatted parameter documentation for the
kohaTable function.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127291|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 127314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127314=edit
Bug 29408: Update all existing uses of .api to .kohaTable

This patch goes through the codebase and updates existing revelant calls
to .api referencing the Koha REST dataTables wrapper to use the name
name 'kohaTable'.

Test plan.
1) Ensure the tables on the following pages all continue to work as
   expected
   a) acqui/parcel
   b) admin/branches
   c) admin/cities
   d) admin/smtp_servers
   e) pos/register
   f) tools/quotes

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127290|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 127313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127313=edit
Bug 29408: Rename Koha dataTables wrapper

This patch renames the Koha REST JS dataTables wrapper from the
ambigious 'api' to the clearer 'kohaTable'.

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27949] Batch printing of article request slips

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27949

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||This developments adds a
  release notes||way to select several
   ||article requests and print
   ||slips for them in batch.
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27947] Add default cancellation reasons to article requests

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||This feature adds a way to
  release notes||define a list of possible
   ||cancellation reasons for
   ||article requests. That way,
   ||they can be chosen upon
   ||cancellation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28242] Accessibility: OPAC - add captions and legends to tables and forms

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28242

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26852] Add missing X11$e and remove relator term subfields from MARC21 headings

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26852

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27944] Add new stages to the article request process

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27944

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25464] Add ability to specify client IP and SIP account used in SIP2 logging

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25464

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18631] `cleanup_database.pl` should take an option for modules in action_logs

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18631

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #7)
> Sorry, now I am confused. Can you describe what features are affected by the
> problem and thus broken?

Sending attachments works, the cart, the list, etc. It all was tested, and
works.
And Email::Stuffer can handle attachments correctly.

The problem is messages that go to the message queue, with attachments, and how
the email is rebuilt to be sent.

Can anyone provide 'steps to reproduce' the problem? thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694

Owen Leonard  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

--- Comment #14 from Martin Renvoize  ---
I do have a couple of improvements to make on that last patch though.. I
clarified a few things with Tomas this morning, but Kyle was super quick to
review what was already there before I got to update it ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

--- Comment #13 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #12)
> We already have "KohaTable", isn't this more ambiguous?

I think the difference between `KohaTable('selector', settings)` and
`$('selector').kohaTable(settings)` is clearer than the current
`$('selector').api(settings)`.. what is `.api()`.. the jQuery API, the selected
elements api.. it also doesn't help that datatables itself has an api() method
to get back the datatables api object.

I think we should slowly be migrating from template-driven datatables
(KohaTable) to api driven datatable (kohaTable).. so to me, the similarity is
deliberate and the distinction is clear.

Also, by starting to add JSDoc, my hope is people will reach for kohaTable
first in the future ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27631] Accessibility: Staff Client - on each page is Logo but should be page description/title

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631

--- Comment #81 from Owen Leonard  ---
Rebased. Only the last patch needs signoff!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >