[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

--- Comment #5 from Andreas Roussos  ---
Created attachment 127424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127424=edit
Bug 29434: add UNIMARC relationship codes for authorities

When using the authority finder plugin (authorities/auth_finder.pl),
you can pick an entry from the 'Special relationship:' dropdown menu
in order to set the relationship between authorities.

However, in UNIMARC instances the relationship codes listed are those
for MARC21. The correct codes for UNIMARC are listed in pages 93-94
of the IFLA UNIMARC Manual for Authorities.

Test plan:

1) In a UNIMARC instance, launch authorities/auth_finder.pl in the
   Staff client, by clicking on the 'Tag editor' button. Notice how
   the 'Special relationship:' dropdown menu lists the relationship
   codes for MARC21 instead of UNIMARC.
2) Apply this patch.
3) Launch the authority finder again; this time the correct values
   should be listed in the 'Special relationship:' dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

Andreas Roussos  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

Andreas Roussos  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |a.rous...@dataly.gr
   |ity.org |
URL||authorities/auth_finder.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

--- Comment #4 from Andreas Roussos  ---
Created attachment 127423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127423=edit
the official source (LoC) of MARC21 relationship codes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

--- Comment #3 from Andreas Roussos  ---
Created attachment 127422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127422=edit
relationship codes for MARC21 in the authority finder

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

--- Comment #2 from Andreas Roussos  ---
Created attachment 127421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127421=edit
hierarchical view of sample authorities

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

--- Comment #1 from Andreas Roussos  ---
Created attachment 127420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127420=edit
list of sample authorities in the Staff client

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29434] New: In UNIMARC instances, the authority finder uses MARC21 relationship codes

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

Bug ID: 29434
   Summary: In UNIMARC instances, the authority finder uses MARC21
relationship codes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: a.rous...@dataly.gr
QA Contact: testo...@bugs.koha-community.org

Background information
--
As per the IFLA UNIMARC Manual for Authorities format [1], the 5--
Functional Block (a.k.a. Related Access Point Block) "contains related
authorized access points from which a reference is to be made to see also
the access point of the record".

To put it simply, this allows for linking authority records with other
authority records in order to form, for example, broader/narrower term
hierarchies (see sreenshots 1 and 2).

Control Subfield $5 ("Relationship Control" in IFLA speak, whereas the
UNIMARC Authorities framework in Koha uses the term "Tracing Control")
is key to this idea, because it is used to store a single-character value
that denotes the type of relationship between the authorities being linked.

The actual problem
--
When using the authority finder plugin (authorities/auth_finder.pl),
you can pick an entry from the 'Special relationship:' dropdown menu
in order to set the relationship between authorities.

However, in UNIMARC instances the relationship codes listed are those
for MARC21 [2] (see screenshots 3 and 4). The correct codes for UNIMARC
are listed in pages 93-94 of the IFLA UNIMARC Manual for Authorities.

[1] https://repository.ifla.org/handle/123456789/861
[2] https://www.loc.gov/marc/authority/adtracing.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
I tested for six of the classes and these all worked as expected:

1. no-renew-hold - Not renewable (on hold) [check out an item with renewals
allowed, place an item level hold]

2. no-renew-too-many - Not renewable (too many renwals) [change circulation
rules so only one renewal allowed (change 'Renewals allowed (count)' to 1),
check out an item, from the patron's account summary in the OPAC select renew
and refresh the page]

3. no-renew-unseen - Item must be renewed at the library [set UnseenRenewals to
allow, change circulation rules so that Unseen renewals allowed (count) = 1,
check out an item, in the OPAC summary renew, message now says 'Item must be
renewed at the library.']

4. no-renew-overdue - Not allowed (overdue) [set OverduesBlockRenewing = block
renewing for all the patron's items, check out an item with renewals allowed,
make check out date before current date]

5. no-renewal-before - No renewal before [date] [set circulation rules:
circulation period = 21 and No renewal before = 20; check out an item, in OPAC
renew from summary page]

6. automatic-renewal - Automatic renewal [check out an item with renewals] 

I wasn't able to figure out how to test for the remaining classes:
- no-renew-too-late - No longer renewable
- auto-renew-fines - Automatic renewal failed, you have unpaid fines
- auto-renew-expired - Automatic renewal failed, your account is expired
- no-renew-too-late - No longer renewable

Happy to sign off if this is sufficient, otherwise I will leave for someone
else who knows how to test the remaining classes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #26 from Victor Grousset/tuxayo  ---
Thanks David, you were faster ^^

As for QA all I can help about is say is that the QA script is happy :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #127414|0   |1
is obsolete||

--- Comment #25 from Victor Grousset/tuxayo  ---
Created attachment 127419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127419=edit
Bug 29330: Restore handling of serialized MIME messages in message_queue

This patch changes how multipart MIME messages are handled on the
message_queue table.

The email, with the required attachments, is now generated using
Koha::Email, and serialized using Koha::Email->as_string.

This bug also adds Koha::Email->new_from_string which is used to read
that data from the DB, and produce a Koha::Email object, that can be
further augmented/modified using regular Koha::Email methods.

This implementation should be considered a middle ground, with
backportability in mind. higher-level methods should encapsulate setting
the default headers and addresses, to clean the area a bit further.

Preparation:
- You need a valid SMTP configuration in koha-conf.xml. If you use Gmail
  you can generate an 'app password' and set things like this:

 
smtp.gmail.com
587
5
STARTTLS
youraddr...@gmail.com
youpassword
1
 
- Set KohaAdminAddress to your address.

To test:
1. Pick a patron. Make sure it doesn't have any email address (Acevedo?)
2. Set an overdue notice trigger for its category
3. Check something out, with due date in the past to force an overdue
4. Run:
   $ kshell
  k$ misc/cronjobs/overdue_notices.pl -v
  k$ exit
   $ koha-mysql kohadev
   > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber;
=> SUCCESS: A notice has been created
5. Run:
   $ kshell
  k$ misc/cronjobs/process_message_queue.pl --verbose
=> SUCCESS: SMTP is ok => Email is sent
=> FAIL: Your inbox shows an email with weird content
6. Apply this patches
7. Run:
   $ koha-mysql kohadev
   > DELETE FROM message_queue;
8. Repeat 4 and 5
=> SUCCESS: You got an email with an attachment!
=> SUCCESS: The attachment contains an email that couldn't be delivered!
9. Try all the things that enqueue messages :-D
=> SUCCESS: No behavior change
10. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 
  «Try all the things that enqueue messages»: I only testes an overdue
  notice email.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #127413|0   |1
is obsolete||

--- Comment #24 from Victor Grousset/tuxayo  ---
Created attachment 127418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127418=edit
Bug 29330: Add Koha::Email->new_from_string

This patch introduces a new method to Koha::Email. This method allows us
to parse a MIME email to initialize the Koha::Email object. This is
particularly important when we are restoring emails from the DB. i.e.
from the *message_queue* table.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> SUCCESS: Tests pass! Koha::Email->new_from_string is the correct
counterpart for Koha::Email->as_string!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22204] Leading spaces in barcode should not allowed in cataloguing

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #14 from David Nind  ---
Patch no longer applies 8-(... (using koha-testing-docker and 21.05):

126430 - [21.05] Bug 22204: Use barcodedecode in additem.pl

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22204: Use barcodedecode in additem.pl
Using index info to reconstruct a base tree...
M   cataloguing/additem.pl
Falling back to patching base and 3-way merge...
Auto-merging cataloguing/additem.pl
CONFLICT (content): Merge conflict in cataloguing/additem.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 22204: Use barcodedecode in additem.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fix adds the date
  release notes||format string to the
   ||date_renewed field. This is
   ||to ensure that the
   ||date_renewed field can be
   ||correctly validated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
This is how I tested using koha-testing-docker - hope this is sufficient!

Test plan:

1. Search http://127.0.0.1:8080/api/v1/.html for date_renewed

2. You should find seven occurrences displayed like this (note that other date
fields have a line with "format": "date", as part of their definition):

   "date_renewed": {
  "description": "date the patron's card was last renewed",
  "type": [
"string",
"null"
  ]
},

3. Apply the patch.

4. Reload the page in step 1 and search again for date_rendered. The seven
occurrences should now include "format": "date", :

   "date_renewed": {
  "description": "date the patron's card was last renewed",
  "format": "date",
  "type": [
"string",
"null"
  ]
},

5. Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405

David Nind  changed:

   What|Removed |Added

 Attachment #127260|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 127417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127417=edit
Bug 29405: Fix spec

This patch just adds the 'date' format string to ensure we are
validating the input/output of the date_renewed field correctly.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29405] The patron spec for date_renewed is missing it's format definition

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29405

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #86 from Arthur Suzuki  ---
I just checked by git logging into C4/Auth.pm, and reading commits messages, I
don't see significant changes nor breaking changes about how permissions works
since 20.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes an issue with
  release notes||automatic renewal digest
   ||messages - these were being
   ||sent on every cron run,
   ||even if there was nothing
   ||to renew or no renewal
   ||errors.
   ||
   ||(This error was
   ||caused by a regression in
   ||21.05 from Bug 18532: Add
   ||individual issues to digest
   ||notice and hide
   ||auto_renewals messaging
   ||preference when not
   ||needed.)
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381

David Nind  changed:

   What|Removed |Added

 Attachment #127141|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 127416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127416=edit
Bug 29381: Prevent sending of automatic renewal messages on every cron run

Currently the auto-renewal digest messages are sent on every cron run
even if there was nothing to renew or no renewal errors.

This regression was introduced in the commit "Bug 18532: Add
individual issues to digest notice and hide auto_renewals messaging
preference when not needed".

To test:
 1) set syspref AutoRenewalNotices to be according to patron
preferences
 2) Enable renewal digest messages on a patron's messaging preferences
 3) Checkout a book for patron, during the checkout use the Checkout
 settings menu to check the box "Automatic renewal"
 4) Run
$ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm
--digest-per-branch
$ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm
--digest-per-branch
 5) Notice you have now two renewal messages for the patron
 6) Apply patch
 7) repeat step 4) and notice you don't get anymore these unnecessary
renewal messages

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU creates new authority record

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573

--- Comment #19 from Hayley Pelham  ---
(In reply to Kyle M Hall from comment #18)
> Pushed to 21.05.x for 21.05.05

21.05.06?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374

David Nind  changed:

   What|Removed |Added

   Assignee|martin.renvoize@ptfs-europe |da...@davidnind.com
   |.com|
 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #8 from David Nind  ---
Created attachment 127415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127415=edit
Bug 28374 - Print receipt is blank after patches applied

After the patches are applied (and database update) the receipt has no details
- see the attachment.

Testing notes (koha-testing-docker):

1. Setup for testing:
   i.  Enable EnablePointOfSale and UseCashRegisters system preferences
   ii. Add a new cash register (Administration > Accounting > Cash registers)
   ii. Add one or two products for sale (Administration > Accounting > Debit
types, make sure 'Can be sold?' is ticked)
2. Go to Home > Point of sale
3. Add some items for purchase to a sale
4. Click confirm
5. Click on 'Print receipt' and save the PDF file somewhere
6. Apply patches
7. Update database: updatedatabase
8. Repeat steps 2-5
9. Compare receipt PDFs - should be no changes
10. Check that the default RECEIPT is updated - for print, HTML should be
ticked (Tools > 
11. Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926

Mason James  changed:

   What|Removed |Added

   Keywords||rel_20_11_candidate
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #7 from Mason James  ---
(In reply to Jonathan Druart from comment #5)
> Pushed to master for 21.11, thanks to everybody involved!

hi, can we get this can be backported thru to 19.11?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/