[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #127659|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 127829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127829&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #127660|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 127830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127830&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #127661|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 127831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127831&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #127662|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 127832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127832&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #127663|0 |1 is obsolete|| --- Comment #60 from Martin Renvoize --- Created attachment 127833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127833&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #127664|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 127834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127834&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #62 from Martin Renvoize --- Created attachment 127835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127835&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #63 from Martin Renvoize --- Created attachment 127836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127836&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize changed: What|Removed |Added Attachment #127666|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 127837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127837&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #65 from Martin Renvoize --- Created attachment 127838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127838&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29527] New: Convert item tables from pre-loading all order data to ajax tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29527 Bug ID: 29527 Summary: Convert item tables from pre-loading all order data to ajax tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: mathsaby...@gmail.com QA Contact: testo...@bugs.koha-community.org Hi With many items, a record takes age to display in OPAC (same issue in staff interface). This is a big issue for serials. Koha should fetch the record, display it, then fetch item data and display the table, with a pagination system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29527] Convert item tables from pre-loading all items data to ajax tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29527 mathieu saby changed: What|Removed |Added Summary|Convert item tables from|Convert item tables from |pre-loading all order data |pre-loading all items data |to ajax tables |to ajax tables -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers changed: What|Removed |Added Attachment #116767|0 |1 is obsolete|| --- Comment #4 from Fridolin Somers --- Created attachment 127839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127839&action=edit Bug 27683: Unit test for GetAnalyticsCount Run prove t/db_dependent/Items/GetAnalyticsCount.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers changed: What|Removed |Added Attachment #116768|0 |1 is obsolete|| --- Comment #5 from Fridolin Somers --- Created attachment 127840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127840&action=edit Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. Test plan : 1) Dont apply patch 2) Build an item and a linked analytical record with 773$0 and $9 3) Enable EasyAnalyticalRecords 4) Try to delete the item 5) You have an alert because linked to analytics 6) Disable EasyAnalyticalRecords 7) Try to delete the item 8) You have an alert because linked to analytics 9) Apply patch 10) Try to delete the item 11) No alert, it works :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers changed: What|Removed |Added Attachment #116769|0 |1 is obsolete|| --- Comment #6 from Fridolin Somers --- Created attachment 127841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127841&action=edit Bug 27683: Impact on catalogue/detail.pl Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove test in catalogue/detail.pl. Test plan : 1) Build an item and a linked analytical record with 773$0 and $9 2) Go to record detail page 3) Enable EasyAnalyticalRecords 4) You see analytics tab and analytical count on item 5) Disable EasyAnalyticalRecords 6) You dont see analytics tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Marcel de Rooy changed: What|Removed |Added Attachment #127516|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 127842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127842&action=edit Bug 29437: Unit tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Marcel de Rooy changed: What|Removed |Added Attachment #127517|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 127843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127843&action=edit Bug 29437: Search reservoir for term as title, author, or variations of ISBN The code in the script and the module attempt to determine whether a term is an isbn, or not. Rather than try to do this, we can simply search it on the three fields: isbn, title, author Additionally, we should search as any of the ISBN variations to broaden our matches Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 that doesn't convert the value will be blank - this is another bug To test: 1 - Perform a cataloging search for a valid ISBN 13 with no ISBN10 counterpart: 9798200834976 2 - 500 error 3 - Apply patch 4 - Repeat, no results 5 - Import some records 6 - Search by title/author/isbn 7 - Confirm searching works as expected WNC amended to fix spelling Signed-off-by: David Nind Signed-off-by: Marcel de Rooy AMENDED: Useless call of ISBNs (plural) when you only pass one parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #12 from Marcel de Rooy --- Created attachment 127844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127844&action=edit Bug 29437: (QA follow-up) Remove Business::ISBN from addbooks Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #13 from Marcel de Rooy --- Created attachment 127845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127845&action=edit Bug 29437: (QA follow-up) Update TODO in Breeding.t We now have some tests for BreedingSearch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #14 from Marcel de Rooy --- (In reply to David Nind from comment #8) > Note: Curently only an ISBN 10 is stored in import biblios, so for an ISBN13 > that doesn't convert > the value will be blank - this is another bug Did you open a new report ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #15 from Marcel de Rooy --- Looks good enough to me. A funny side effect is that we find reservoir books via the ISBN variations 10/13/hypens/no hyphens. We wont find them in the catalog. But if we search for a partial isbn 545 (as being part of eg 0-545-01022-5), we will not find anything in the reservoir, but Zebra finds it in the catalog. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy changed: What|Removed |Added Attachment #127593|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 127846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127846&action=edit Bug 29463: Escape utf8 characters before appending search query to url To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. JK: remove period from commit title Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29463] Umlauts in search field get changed into Replacement character
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29393] Ability to send emails from patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #10 from Alex Arnaud --- Created attachment 127847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127847&action=edit Bug 29393 - Don't show notice templates for each language -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #7 from marion.dur...@biblibre.com --- Thank you Jonathan for moving my patch here ! (When I created Bug 29499 I couldn't find this one, sorry for the duplicated bug.) Everything seems good to me. Since I have made one of the patches, should I signoff the other one or not ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #26 from Marcel de Rooy --- (In reply to Nick Clemens from comment #21) > I disagree here, I think we should remove the FK to branches as the quick > fix. > > While we may have opinions about how that feature was implemented, it has > been implemented. Statistics is a ledger of transactions - foreign keys are > going to remove/nullify data after the fact and I think that would be > incorrect. > > If Pseudonymized transactions are meant to mirror the statistics table then > I feel we should remove the FK for now, and fix the larger issue with > OPACRenew etc on a new bug. > > Adding a new branch is going to add the branch in many places throughout > Koha and will impact workflows Fair enough -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 --- Comment #27 from Marcel de Rooy --- KEY `pseudonymized_transactions_ibfk_1` (`categorycode`), KEY `pseudonymized_transactions_borrowers_ibfk_2` (`branchcode`), KEY `pseudonymized_transactions_borrowers_ibfk_3` (`transaction_branchcode`) When removing the FKs, the question is: Do we still need those indexes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What|Removed |Added Attachment #127727|0 |1 is obsolete|| --- Comment #28 from Marcel de Rooy --- Created attachment 127848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127848&action=edit Bug 29341: Remove foreign keys on pseudonymized_transactions Behave like the statistics table and don't remove the code even if the branch or patron's category is removed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #29 from Marcel de Rooy --- OK We took the other turn :) Apart from comment27 no further questions. Trivial enough to combine SO and QA at this late time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #8 from Jonathan Druart --- (In reply to marion.durand from comment #7) > Thank you Jonathan for moving my patch here ! > > (When I created Bug 29499 I couldn't find this one, sorry for the duplicated > bug.) > > Everything seems good to me. Since I have made one of the patches, should I > signoff the other one or not ? Yes, please :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855
--- Comment #5 from Martin Renvoize ---
This looks good.. My one query is around the `||
!C4::Context->preference('CalculateFinesOnReturn')` introduction..
I'm not sure if that's the behaviour we want/expect.. should we still increment
a fine after return here? I realise, it's to do with the job being long
running and so the patron has 'got away with it' as it were.. but we could be
introducing questions if the patron returns their item, pays their fine and
then finds they have a bit more to pay after the fact because the calculations
were still running?
Otherwise, I think this is a great little improvement.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29387] BatchUpdateBiblio does not handle exception correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29387 --- Comment #14 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #13) > Created attachment 127827 [details] [review] > Bug 29387: (QA follow-up) Fix modules in test > > Can't locate object method "new" via package > "Koha::BackgroundJob::BatchUpdateBiblio" (perhaps you forgot to load > "Koha::BackgroundJob::BatchUpdateBiblio"?) at > t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t line 45. > > How did it pass at signoff? > > Signed-off-by: Marcel de Rooy Thanks for the follow-up. It got broken by bug 28413 that was pushed in the meanwhile. (In reply to Marcel de Rooy from comment #10) > Did we consider the allow_blessed/convert_blessed route in JSON? I didn't, we could but I wouldn't introduce such changes for 21.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andreas Roussos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andreas Roussos changed: What|Removed |Added Attachment #127818|0 |1 is obsolete|| --- Comment #2 from Andreas Roussos --- Created attachment 127849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127849&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #14 from Jonathan Druart --- Created attachment 127850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127850&action=edit Bug 29478: (follow-up) Today should select now for pastinclusive This is getting ugly. We need to add 1 minute for the minDate or the 'Today' link may not work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 --- Comment #15 from Jonathan Druart --- (In reply to Owen Leonard from comment #13) > The patch in Comment 9 still needs a signoff. Looks good to me, but I prefer to see someone else testing this. Especially because I found (and fix) yet another problem... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29500] Flatpickr accepting original date in the past for futuredate but also other dates in the past
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29500 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #6 from Martin Renvoize --- Created attachment 127851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127851&action=edit Bug 18855: Don't create duplicate overdue fines if an issue is returned If cronjobs/fines.pl is running during circulation hours, then an issue may be considered for having it's overdue fine updated after the issue has been returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'. In this case UpdateFine will create a duplicate fine because it can't find the specific accountline for the overdue and unreturned fine. This changes UpdateFine to not care about status, so the accountline will be found, until it comes to adjusting the fine. At this point if the fine is 'UNRETURNED' or 'CalculateFinesOnReturn' is off (the book was returned and it's overdue fine status flipped, but the amount wasn't updated), then go ahead and adjust the fine amount. Test plan: 1. find an overdue fine near the end of the list of overdue fines that cronjobs/fines.pl will be considering. 2. start cronjobs/fines.pl. 3. immediately check in the overdue book. 4. once fines.pl is finished observe that a duplicate overdue fine has been created on the patrons account. 5. apply patch. 6. repeat 1 - 4 and observe that the duplicate fine was not created. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #7 from Martin Renvoize --- Created attachment 127852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127852&action=edit Bug 18855: (follow-up) Restore CalculateFinesOnReturn behaviour This patch removes the check for a disabled 'CalculateFinesOnReturn' to restore the behaviour prior to this patch series. If a patron has returned the item during the fines cron run, they may well have been charged a reduced fine at check-in time. However, I feel that the fine should not then increment/decrement behind the scenes after the check-in. This is to reduce confusion for end users and librarians alike. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Martin Renvoize changed: What|Removed |Added Attachment #127816|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize --- Signing off.. leaving to QA/RM to decide whether to keep my follow-up or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 marion.dur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 marion.dur...@biblibre.com changed: What|Removed |Added Attachment #127781|0 |1 is obsolete|| --- Comment #9 from marion.dur...@biblibre.com --- Created attachment 127853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127853&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" Signed-off-by: Marion Durand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #44 from Jonathan Druart --- (In reply to Manos PETRIDIS from comment #43) > Is the "new block for plugin_repos" described somewhere? I see that the the > system preference for plugins has been removed, but existing koha-conf.xmls > have not been updated with the new block, even in commented form. Where is > one to find it? Hi Manos, it's in the source: https://git.koha-community.org/Koha-community/Koha/src/commit/7bddfeb412e427ee8c02c700295382fe4a7340d6/debian/templates/koha-conf-site.xml.in#L406 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Created attachment 127781 [details] [review] > Bug 29496: (bug 27526 follow-up) Fix item form validation > > The validation of the forms were blocked with "X item mandatory fields > empty" when at least one dropdown list subfield was marked as mandatory. > > We need to add the 'input_marceditor' class to the select (does it > actually make sense? select vs input...) > > Caused by > commit 6ed29bccef590a1bc5e4cea175b41b8024483320 > Bug 27526: Fix mandatory and important checks > Which lamentably failed as it was stating: > "Using .input_marceditor let us fix the additem.tt form and prevent to break > the other ones" No test plan? Please explain how the addorderiso2709 change is supposed to work? This template does not use cataloging.js. I do not see the connection (yet)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- (In reply to marion.durand from comment #9) > Signed-off-by: Marion Durand What did you test, Marion ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #28 from Marcel de Rooy --- +code => $code || 'tmp_code', Please explain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #12 from marion.dur...@biblibre.com --- (In reply to Marcel de Rooy from comment #11) > (In reply to marion.durand from comment #9) > > Signed-off-by: Marion Durand > > What did you test, Marion ? I tested test plan given by the first patch and test plan given by Koha Team University Lyon 3 (fist comment) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #13 from Marcel de Rooy --- From IRC: [11:28] <@Joubu> marcelr: it matches the pattern, and the pattern is: select with name="field_value" has input_marceditor class [11:29] <@Joubu> if we don't add on addorderiso, it will be the only place where input_marceditor is not set to selects with name="field_value" That makes sense :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 --- Comment #14 from Marcel de Rooy --- (In reply to marion.durand from comment #12) > (In reply to Marcel de Rooy from comment #11) > > (In reply to marion.durand from comment #9) > > > Signed-off-by: Marion Durand > > > > What did you test, Marion ? > > I tested test plan given by the first patch and test plan given by Koha Team > University Lyon 3 (fist comment) Thanks for your fast response. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What|Removed |Added Attachment #127780|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 127854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127854&action=edit Bug 29496: CheckMandatorySubfields don't work properly with select field in serials-edit.tt Since one of the patches of BZ 27526 (Bug 27526: Fix mandatory and important checks), CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for all field (it is present on text input but not on select input) 5 9- Check that no error appear and that your item has been created. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new serial. Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created JD amended patch: remove comma to separate classes Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What|Removed |Added Attachment #127853|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 127855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127855&action=edit Bug 29496: (bug 27526 follow-up) Fix item form validation The validation of the forms were blocked with "X item mandatory fields empty" when at least one dropdown list subfield was marked as mandatory. We need to add the 'input_marceditor' class to the select (does it actually make sense? select vs input...) Caused by commit 6ed29bccef590a1bc5e4cea175b41b8024483320 Bug 27526: Fix mandatory and important checks Which lamentably failed as it was stating: "Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" Signed-off-by: Marion Durand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113
--- Comment #29 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #28)
> +code => $code || 'tmp_code',
>
> Please explain.
The code is mandatory at DB level so we must add a temporary code during the
insert, then update it after
I feel like it should actually be 'tmp_code' always, at this point we are
creating a new entry and $code should never be set.
We could add the following change
diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl
index e63a44a809a..59721e24b2a 100755
--- a/tools/additional-contents.pl
+++ b/tools/additional-contents.pl
@@ -159,7 +159,7 @@ elsif ( $op eq 'add_validate' ) {
my $additional_content = Koha::AdditionalContent->new(
{
category => $category,
-code => $code || 'tmp_code',
+code => 'tmp_code',
location => $location,
branchcode => $branchcode,
title => $title,
@@ -173,13 +173,11 @@ elsif ( $op eq 'add_validate' ) {
)->store;
eval {
$additional_content->store;
-unless ($code) {
-$additional_content->discard_changes;
-$code = $category eq 'news'
- ? 'News_' . $additional_content->idnew
- : $location . '_' . $additional_content->idnew;
-$additional_content->code($code)->store;
-}
+$additional_content->discard_changes;
+$code = $category eq 'news'
+ ? 'News_' . $additional_content->idnew
+ : $location . '_' . $additional_content->idnew;
+$additional_content->code($code)->store;
};
if ($@) {
$success = 0;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What|Removed |Added Attachment #125696|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Created attachment 127856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127856&action=edit Bug 29113: Hide code for additional contents and generate it additional_contents.code is used to group DB rows together. Each row represent one content in a given language, and the code is used to know they are translation of the lang='default' one. It's not really useful for the end user and we could hide it and generate it. Test plan: Create/Edit/Delete additional contents (news and HTML customizations) and confirm that they are correctly grouped together. You need several languages installed to test this patch correctly. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Marcel de Rooy changed: What|Removed |Added Attachment #127365|0 |1 is obsolete|| --- Comment #31 from Marcel de Rooy --- Created attachment 127857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127857&action=edit Bug 29113: Fix random assignation Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29010] Weight input pattern wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal Keywords||rel_21_11_candidate CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 --- Comment #32 from Marcel de Rooy --- Works, but the 'code' could be nicer. Still time for another QAer today? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 --- Comment #11 from Jonathan Druart --- After bug 28445 I don't recreate the problem. Can you confirm, Nick? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Katrin Fischer changed: What|Removed |Added Attachment #125060|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29415] Wrong number of received items/quantity shown in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29415 --- Comment #1 from Jonathan Druart --- Created attachment 127858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127858&action=edit Bug 29415: Fix quantity display in acq module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29415] Wrong number of received items/quantity shown in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29415 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- Just a try, but I haven't test the patch deeply for different situations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29463] Umlauts in search field get changed into replacement character
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Katrin Fischer changed: What|Removed |Added Summary|Umlauts in search field get |Umlauts in search field get |changed into Replacement|changed into replacement |character |character -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29496] Can't save an order with mandatory items subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29496 Katrin Fischer changed: What|Removed |Added Summary|can't save an order with|Can't save an order with |mandatory items subfields |mandatory items subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29520] addtoadditional-contents wont display News items or HTML customizations if the expiration date is in the past
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29520 Katrin Fischer changed: What|Removed |Added Summary|addtioadditional-contents |addtoadditional-contents |wont display News items or |wont display News items or |HTML customizations if the |HTML customizations if the |expiration date is in the |expiration date is in the |past|past -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Katrin Fischer changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #6 from Katrin Fischer --- (In reply to Owen Leonard from comment #5) > It seems odd to me that the AutoEmailOpacUser preference ONLY works if > you're adding someone from the staff interface. A more comprehensive > solution might add a flag to the patron account so that a cron job could > send the notice to any new (unflagged) accounts periodically, whether they > were created by self-registration, patron import, or manually via the staff > interface. > > If we did it like that it would be relatively easy to trigger the re-sending > of a notice by toggling the flag on the patron's acccount, thereby putting > them back into the notification queue. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 --- Comment #1 from Jonathan Druart --- Created attachment 127859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127859&action=edit Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- This seems to be the way to go, but I don't think it's ready for integration. We should have the logic moved to Koha::ItemTypes and add test coverage. Will try and come back to this later. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Jonathan Druart changed: What|Removed |Added Depends on||3142 Severity|normal |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 [Bug 3142] Standardize how OPAC and staff determine requestability -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Jonathan Druart changed: What|Removed |Added Blocks||29087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 --- Comment #3 from Jonathan Druart --- Galen, thanks for reporting this bug! Are you seeing this in master or stable? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Katrin Fischer changed: What|Removed |Added Attachment #127787|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 127860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127860&action=edit Bug 29514: Remove extraneous HTML entity from breadcrumbs The template file for ILL requests has a small typo in the breadcrumbs section: there exists an extra › HTML entity after "Home". This patch fixes that. Test plan: 1) Access the ILL requests module, and notice how an extra character is displayed after "Home" in the breadcrumbs. 2) Apply this patch. 3) Refresh the page -- the extra character is no longer displayed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29515] Don't require title for HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29528] New: Breadcrumbs on HTML customizations take you to news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Bug ID: 29528 Summary: Breadcrumbs on HTML customizations take you to news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Go to HTML customizations and click on it in the breadbrumbs and you'll end up on News. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29515] Don't require title for HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29515] Don't require title for HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 --- Comment #4 from Katrin Fischer --- Created attachment 127861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127861&action=edit Bug 29515: Make title for HTML customizations optional This adds code to make the title field for HTML customizations optional while it stays mandatory for news entries. 1) Add a new HTML customization, verify you are forced to enter a title 2) Apply patch 3) Repeat and verify that you can now save without title 4) Add a new news entry 5) Verify that the title field remained mandatory there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Katrin Fischer changed: What|Removed |Added Attachment #127786|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 127862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127862&action=edit Bug 29513: Convert remaining breadcrumbs div blocks into nav As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846#c0, breadcrumbs should adhere to the WAI-ARIA Authoring Practices. Most Staff Client template files have already been fixed, but there were a few that were missed. This patch fixes that. Test plan: 1) Apply this patch. 2) Visit these pages in the Staff Client: Home > Acquisitions > TestVendor > Basket TestBasket (1) for TestVendor (*) Home > Administration > Set library checkin and transfer policy (**) Home > Patrons > Merge patron records (***) ...and confirm that the breadcrumbs display correctly. (*) Can be accessed by creating a test basket for a test vendor (**) Can be found under Administration -> Patrons and circulation (***) Can be found by trying to merge two Patron records Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 --- Comment #4 from Katrin Fischer --- Created attachment 127863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127863&action=edit Bug 29513: (QA follow-up) Fix TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||wainuiwitikapark@catalyst.n ||et.nz Depends on||28772 --- Comment #2 from Jonathan Druart --- Wainui, did you see this bug report? You forgot to move the atomicupdate to the updatedatabase.pl script. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772 [Bug 28772] Any user that can work with reports can see API keys of any other user -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28772] Any user that can work with reports can see API keys of any other user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28772 Jonathan Druart changed: What|Removed |Added Blocks||29132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Jonathan Druart changed: What|Removed |Added Severity|normal |trivial Keywords||Academy CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Katrin Fischer changed: What|Removed |Added Attachment #127849|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 127864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127864&action=edit Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #39 from Katrin Fischer --- Created attachment 127865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127865&action=edit Bug 10517: Use `DROP USER IF EXISTS` and remove ` || true`. When restoring a Koha instance, and the database user does not exist, an error is shown, although it is prevented from stopping the script by ` || true`. This patch removes the ` || true` guard, and rather uses `DROP USER IF EXISTS` which does exactly what one would expect, without confusing error messages, whether the user existed or not. To test: 1) Assume your Koha instance is called `asdf`. 1) Export the Koha instance using `koha-dump`. 2) Remove the instance completely using `koha-remove`. 3) Import it again using `koha-restore`. 4) No error should be shown, and the import should work. There was NO user to drop, therefore `DROP USER IF EXISTS` did nothing. 5) A database user called `koha_asdf` should exist, and have all privileges on the database of the same name. 6) Remove the instance again using `koha-remove`. 7) Now create a database user in MySQL called `koha_instance` where instance is the name of your dumped koha instance. 8) Import your koha instance again using `koha-restore`. 9) Again, no error should be shown, and the import should work. There WAS a user to drop, therefore `DROP USER IF EXISTS` dropped the user before creating a new one. 10) Again, a database user called `koha_asdf` should exist, and have all privileges on the database of the same name. Sponsored-by: Reformational Study Centre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Katrin Fischer changed: What|Removed |Added Attachment #96975|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #40 from Katrin Fischer --- Martin, are we missing your sign-off line here? I think you were the one to switch to signed-off. Fixed the author line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Blocks||25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Jonathan Druart changed: What|Removed |Added Depends on||29040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 [Bug 29040] Uninitialized value warning in Languages.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
