[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #34 from Fridolin Somers  ---
Depends on bug 21249 not in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #57 from Fridolin Somers  ---
(In reply to Victor Grousset/tuxayo from comment #51)
> 
> For 20.11.x it might be trickier. Bug 28803 depends on bug 28813 which
> depends on 14723 which might not be an easy 20.11.x backport. So
> circumventing bug 28803 might be the way.

So we can skip for 20.11.x ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28896] Checkin Slip doesn't work for anonymized checkouts

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896

Emmi Takkinen  changed:

   What|Removed |Added

 CC||emmi.takki...@koha-suomi.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177

--- Comment #10 from David Cook  ---
(Also, lovely to hear from you, but you should go to sleep!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177

--- Comment #9 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #8)
> I like 'Location'. The 'My' part of implicit it could be clarified on a
> drop-down title/header. To understand my opinion, lol at the account info in
> OPAC and see how redundant it can get!

Haha. True! I was thinking of keeping it consistent with other items in the
dropdown menu but I'm not opposed to dropping the "My".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177

--- Comment #8 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #7)
> (In reply to Tomás Cohen Arazi from comment #6)
> > 'Session' might be enough?
> 
> Thinking about this again... I think that "session" is a developer concept
> that most staff users wouldn't understand. 
> 
> I think they're all circulation related so maybe "My circulation settings",
> although that's a lot of text. Maybe "My location"? Since it would be
> dealing with their branch, desk, cash register...

I like 'Location'. The 'My' part of implicit it could be clarified on a
drop-down title/header. To understand my opinion, lol at the account info in
OPAC and see how redundant it can get!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29452] Unnecessary warns in sip logs

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29452

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #9 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #10 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29264] SIP config allows use of non-branchcode institution ids causes workers to die without responding

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #10 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29204] Error 500 when execute Circulation report with date period

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29204

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #18 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #13 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #22 from wainuiwitikap...@catalyst.net.nz ---
Could someone please help me with what I should do with this bug for 19.11.x? 

I think it is too late this month to add it to 19.11.x but I can add it next
month?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26871] L1 cache still too long in SIP Server

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26871

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #16 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices between different orders

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #19 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26374] Update for 19974 is not idempotent

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26374

wainuiwitikap...@catalyst.net.nz changed:

   What|Removed |Added

 CC||wainuiwitikapark@catalyst.n
   ||et.nz

--- Comment #12 from wainuiwitikap...@catalyst.net.nz ---
Not backporting to 19.11.x - LTS version will just backport security patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177

--- Comment #7 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #6)
> 'Session' might be enough?

Thinking about this again... I think that "session" is a developer concept that
most staff users wouldn't understand. 

I think they're all circulation related so maybe "My circulation settings",
although that's a lot of text. Maybe "My location"? Since it would be dealing
with their branch, desk, cash register...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177

--- Comment #6 from Tomás Cohen Arazi  ---
'Session' might be enough?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29300] Release team 22.05

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300

--- Comment #17 from wainuiwitikap...@catalyst.net.nz ---
Could someone please help me with what I should do with this bug for 19.11.x?

I think it is too late this month to add it to 19.11.x but I can add it next
month?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
  Component|Templates   |Hold requests
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27850] Search link for 260 a and c in MARC21 XSLT display

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27850

Katrin Fischer  changed:

   What|Removed |Added

  Component|Templates   |MARC Bibliographic data
   ||support

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20688] Add accesskeys for hold confirmation boxes

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688

Katrin Fischer  changed:

   What|Removed |Added

  Component|Templates   |Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24406] Add a span to patron category category type codes in patron search result lists

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406

Katrin Fischer  changed:

   What|Removed |Added

Summary|Remove patron category  |Add a span to patron
   |category type codes from|category category type
   |patron search results   |codes in patron search
   ||result lists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28810] Housebound details should be textarea not text inputs

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28810

Katrin Fischer  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||kyle.m.h...@gmail.com
  Component|OPAC|Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

--- Comment #96 from Katrin Fischer  ---
Maybe another candidate for 'new feature'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28340] Provide improved display of ILL request metadata in notices

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27170] ILL availability should be able to display arbitrary links to related resources

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27170

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14237] Allow bibs to be added to course without items

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237

--- Comment #56 from Katrin Fischer  ---
Should/could we promote this to 'new feature'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25429] `cleanup_database.pl` should remove resolved claims returned after X days

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds the   |This enhancement adds the
  release notes|new |new
   |`CleanUpDatabaseReturnClaim |`CleanUpDatabaseReturnClaim
   |s` system preference|s` system preference
   |allowing administrators to  |allowing administrators to
   |specify how many days after |specify how many days after
   |resolution a claimed return |resolution a claimed return
   |record should be deleted|record should be deleted
   |from the database.
 |from the database.
   |
   |
   |For |For
   |this functionality to be|this functionality to be
   |enabled, the|enabled, the
   |`cleanup_database.pl` must  |`cleanup_database.pl` must
   |be scheduled to run |be scheduled to run
   |regularly with the new  |regularly with the new
   |`--returns_claims`  |`--return_claims` parameter
   |parameter passed.   |passed.

--- Comment #56 from Katrin Fischer  ---
Wondering: return-claims or return_claims?


+   --return-claims Purge all resolved return claims older than the
number of days specified in
+   the system preference CleanUpDatabaseReturnClaims.

vs.

+$return_claims = C4::Context->preference('CleanUpDatabaseReturnClaims') if
$return_claims;
 if ($return_claims) {
 print "Purging return claims older than $return_claims days.\n" if
$verbose;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26177] The 'set library' functionality should be changed to 'session settings' or similar

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26177

--- Comment #5 from David Cook  ---
Wow I do not recall commenting on this previously but still +1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381

--- Comment #9 from David Cook  ---
(In reply to David Cook from comment #8)
> *** Bug 29555 has been marked as a duplicate of this bug. ***

Nick made different changes on bug 29555 and after comparing both patches I'm
thinking that maybe Nick and Joonas should talk and combine the patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381

David Cook  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #8 from David Cook  ---
*** Bug 29555 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au
 Resolution|--- |DUPLICATE
 Status|Signed Off  |RESOLVED

--- Comment #3 from David Cook  ---
Marking this as a duplicate of bug 29381 since it's older and signed off (also
Andrew can't sign off Nick's patches). 

Although after comparing the patches on both issues... I'm not sure that either
is 100% correct...

*** This bug has been marked as a duplicate of bug 29381 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27948] Add disclaimer text to article requests feature

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This enhancement lets you   |This enhancement lets you
  release notes|include text that patrons   |include text that patrons
   |need to accept before they  |need to accept before they
   |can place an article|can place an article
   |request (similar to the |request (similar to the
   |ILLModuleCopyrightClearance |ILLModuleCopyrightClearance
   |system preference). 
   |system preference).
   |
   |
   |Add |Add
   |the text required to the|the text required to the
   |new |new
   |ArticleRequestsDisclaimerTe |ArticleRequestsDisclaimerTe
   |xt entry in the news tool.  |xt entry in the additional
   ||contents tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27287] Make note fields from orders searchable

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||Adds search options for the
  release notes||internal and vendor note
   ||fields from the basket to
   ||the advanced search form in
   ||acquisitions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24190] Add additional Acquisition logging

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds   |This enhancement adds
  release notes|additional logging of   |additional logging of
   |acquisition-related changes |acquisition-related changes
   |including:
 |including:
   |- Order line|- Order line
   |creation and cancellation
  |creation and cancellation
   |-   |-
   |Invoice adjustment  |Invoice adjustment
   |additions, amendments and   |additions, amendments and
   |deletions
  |deletions
   |- Order line|- Order line
   |receipts against an invoice |receipts against an invoice
   |- Budget adjustments
   |- Budget adjustments
   |- Fund  |- Fund
   |adjustments
|adjustments
   |- Order release |- Order release
   |date
   |date (EDIFACT)
   |
   |
   |The name of the |The name of
   |system preference that  |the system preference that
   |enables logging of  |enables logging of
   |acquisition-related changes |acquisition-related changes
   |was changed from AcqLog to  |was changed from AcqLog to
   |AcquisitionLog.
|AcquisitionLog.
   |
   |
   |Note:   |Note:
   |Acquisition logging was |Acquisition logging was
   |added in Koha 21.05.|added in Koha 21.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29558] New: Tabbing through item editor no longer works

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29558

Bug ID: 29558
   Summary: Tabbing through item editor no longer works
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Libraries are reporting a change to the way you can use the TAB button in the
item editor.  Prior to 21.05, you could use the TAB key to move through the
item editor, hit tab and it would confirm the highlighted/upper choice and go
to the next field.  You can't just tab to Not For Loan, hit O (for Ordered),
and hit tab to select that and jump to collection code.  You now have to click
and/or use enter.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28896] Checkin Slip doesn't work for anonymized checkouts

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896

Sara Brown  changed:

   What|Removed |Added

 CC||sbr...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Katrin Fischer  changed:

   What|Removed |Added

Summary|cannot set a new value for  |Cannot set a new value for
   |privacy_guarantor_checkouts |privacy_guarantor_checkouts
   |in memberentry.pl   |in memberentry.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538

--- Comment #2 from John Fawcett  ---
Hi John
probably I misunderstood. I agreed with the suggestion to remove the language
specific installer files in favour of using the english .yml file that would be
translated on pootle, since this would mean being able to keep the Italian
version more aligned to data structure changes in the English version.

I was not aware that this meant that only MARC21 would be supported for
Italian. I assumed that UNIMARC would also be supported.

Is it possible to get UNIMARC back? Is it just a question of doing the
translation on pootle and getting up published? If so I am more than willing to
help out as I imagine other Italian users are too.

Thanks
John

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.05
released in||

--- Comment #33 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847

--- Comment #32 from Nick Clemens  ---
This should be backported to 21.05 - it fixes a bug introduced by 21249 

The code in the scripts joins the branches by 'or' - for ES this must be 'OR'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.05
released in||

--- Comment #56 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519

--- Comment #15 from Martin Renvoize  ---
Tests added to dependancy bug and item relation patch moved there..

Over to QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127815|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127814|0   |1
is obsolete||

--- Comment #14 from Martin Renvoize  ---
Created attachment 127945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127945=edit
Bug 29519: Allow resolution of claims return at checkin

Add a 'Resolve' button in the alert dialogue that is displayed when a
lost item with a return claim is checked in. The button will trigger the
usual resolution modal allowing the user to pick their resolution.

This patch splits the resolution modal out of checkouts.js and
checkouts-table.inc so it can be used outside of the checkouts table.
We then reload it, optionally based upon the presence of the claims
preference, where needed.  This has the added benefit that it saves a
little bit of page load data in cases where the feature is not enabled.

Test plan
1. As we alter the file locations of the resolution handling code we
   need to test that normal claims functionality continue to work as
   expected.
2. Test the new functoinality by checking in an item that has been
   claimed as returned (but not yet resolved). The dialogue box should
   now contain a 'resolve' button next to each claimant and clicking
   upon it should trigger the resolution modal where the librarian can
   subsequently pick the resolution and submit it.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

--- Comment #25 from Martin Renvoize  ---
Added missing unit tests.. we're well covered now.. over to QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

--- Comment #24 from Martin Renvoize  ---
Created attachment 127944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127944=edit
Bug 29495: Add relation tests

This patch adds missing tests for relationship accessors in the
ReturnClaim class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

--- Comment #23 from Martin Renvoize  ---
Created attachment 127943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127943=edit
Bug 29495: (follow-up) Use 'item' relationship

This patch adds the missing 'item' relationship in
Checkouts::ReturnClaim and then uses it from the resolve method.

This improve the reliability of the resolution code so it works when the
item has already been checked in (without having to check
Old::Checkouts).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127813|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 127942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127942=edit
Bug 29495: Update relationship methods

This patch updates the relationship methods found in
Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on
the API.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127812|0   |1
is obsolete||

--- Comment #21 from Martin Renvoize  ---
Created attachment 127941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127941=edit
Bug 29495: Add code level constraint replacement

This patch adds a check in Koha::Checkouts::ReturnClaim::store to
replace the database level foreign key check.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127811|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 127940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127940=edit
Bug 29495: Add DBIC relationships back into Schema

This patch adds the relationship accessors back into the affected Schema
classes, now below the fold so they are retained during dbic rebuilds.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127810|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 127939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127939=edit
Bug 29495: DBIC Schema Rebuild

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127809|0   |1
is obsolete||

--- Comment #18 from Martin Renvoize  ---
Created attachment 127938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127938=edit
Bug 29495: Drop issue_id constraint from return_claims

This patch removes the issue_id constraint from return_claims.

Due to the nature of our dual table approach to checkouts/old_checkouts
we can't safely hae this constraint and not lose data.  Prior to this
commit, when an item is checked in we move the checkout from checkouts
to old_checkouts.. this therefore triggers the delete of the issue_id
from the return_claims table as described by the foreign key constraint.

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

--- Comment #17 from Martin Renvoize  ---
Created attachment 127937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127937=edit
Bug 29495: Unit Tests

Test plan
1. Run updated tests prior to applying new patches.. pass
2. Run updated tests after applying new patches.. pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528

--- Comment #2 from Owen Leonard  ---
(In reply to Owen Leonard from comment #1)
> Since news and HTML
> customizations are separate links on the Tools home page there's no
> reason to have the breadcrumbs imply the two sections are connected in
> any way.

There are other changes I'd like to make to this template along these same
lines, but I don't want to hold up this patch with string changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528

--- Comment #1 from Owen Leonard  ---
Created attachment 127936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127936=edit
Bug 29528: Breadcrumbs on HTML customizations take you to news

This patch removes the "Additional contents" breadcrumb when working
with news items or HTML customizations. Since news and HTML
customizations are separate links on the Tools home page there's no
reason to have the breadcrumbs imply the two sections are connected in
any way. We already have the "See News" link, for example, for switching
quickly between the two areas.

To test, apply the patch and go to Tools -> News.

- The breadcrumbs should be: Home > Tools > News
  - Click "New entry." The breadcrumbs should be: Home > Tools > News >
Add additional content (News). Clicking "News" should take you to
the correct page.
- Go to Tools -> HTML customizations.
  - The breadcrumbs should be Home >  Tools > HTML customizations.
  - Click "New entry." The breadcrumbs should be: Home > Tools >  HTML
customizations > Add additional content (HTML customizations).
Clicking "HTML customizations" should take you to the correct page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22671] Built-in offline circulation applicationCache errors

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #127931|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 127935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127935=edit
Bug 29524: (bug 28935 follow-up) Restore modification of some patron's
attributes

On
  commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3
  Bug 28935: No filtering on patron's data on member entry pages
we restricted the list of the columns from the borrowers table that can
be modified from the patron edit view.
We were too restrictive, the following 3 attributes can be edited from
this form: privacy_guarantor_fines, privacy_guarantor_checkouts,
checkprevcheckout and lang

Test plan:
Turn on the following prefs:
- AllowStaffToSetFinesVisibilityForGuarantor
- AllowStaffToSetCheckoutsVisibilityForGuarantor
- CheckPrevCheckout (set to 'unless overridden *')
- TranslateNotices
Edit a patron and see the 4 different options are now displayed.
Change their value, save, edit again
Confirm that the values have been saved

Signed-off-by: Owen Leonard 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29557] New: auto-renew notices should handle failed renewal due to patron expiration

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557

Bug ID: 29557
   Summary: auto-renew notices should handle failed renewal due to
patron expiration
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The default auto-renew and auto-renew-digest notices should include logic to
tell patrons when their renewals have failed due to upcoming patron expiration.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #127929|0   |1
is obsolete||

--- Comment #2 from Andrew Fuerste-Henry  ---
Created attachment 127934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127934=edit
Bug 29555: Don't push auto_too_soon issues into report

This patch adds a conditional to avoid reporting on issues that are too
soon to be renewed

To test:
 1 - Set  AutoRenewalNotices preference to 'according to patron messaging
preferences'
 2 - Set a patront o request auto renewal emails digested
 3 - Checkout an item to the patron, back dated to be opverdue, and marked for
auto renewal
 4 - Add an email to the patron for testing
 5 - perl misc/cronjobs/automatic_renewals.pl -v -c
 6 - See the issue is renewed (ensure it is now not overdue)
 7 - Confirm the patron was sent a digest with the renewal (on patron 'Notices'
tab)
 8 - perl misc/cronjobs/automatic_renewals.pl -v -c
 9 - See the issue was not renewed
10 - See a notice was sent, with no indication of what happened to the issue
11 - Apply patch
12 - perl misc/cronjobs/automatic_renewals.pl -v -c
13 - Confrim no renewal or notice
14 - Checkout a second item to patron, backdated and set for auto renewal
15 - perl misc/cronjobs/automatic_renewals.pl -v -c
16 - Confirm the correct item is renewed and notice sent
17 - Confirm notice does not include the too soon issue
18 - Checkout a third item
19 - perl misc/cronjobs/automatic_renewals.pl -v -c -b
20 - Confirm correct item is renewed and notice sent, nbot including other two
21 - perl misc/cronjobs/automatic_renewals.pl -v -c -b
22 - Confirm no notice sent

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554

--- Comment #6 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #5)
> We never set the itemtype on biblio level and haven't had any issues with
> that in 18.11 - if there are issues now, that would be quite bad.
> 
> But should this bug report then not be about making the field visible
> independent from the item-level_itype setting?

Yeah the bug title is a bit cryptic, but describes the problem. And the commit
title tells you the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855

marion.dur...@biblibre.com changed:

   What|Removed |Added

   Assignee|didier.gautheron@biblibre.c |marion.dur...@biblibre.com
   |om  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855

marion.dur...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part"

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556

--- Comment #1 from Owen Leonard  ---
Created attachment 127933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127933=edit
Bug 29556: MARC21slim2MODS.xsl broken by duplicate template name "part"

This patch removes a redundant section from MARC21slim2MODS.xsl which
was breaking the option to use unAPI in the OPAC using MODS format.

To test, apply the patch and view a record in the OPAC using unAPI,
e.g.:

/cgi-bin/koha/unapi?id=koha:biblionumber:1=MODS

You should see an XML file where previously there would have been an
error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part"

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554

--- Comment #5 from Katrin Fischer  ---
We never set the itemtype on biblio level and haven't had any issues with that
in 18.11 - if there are issues now, that would be quite bad.

But should this bug report then not be about making the field visible
independent from the item-level_itype setting?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5927] Show series information in search results page

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927

Owen Leonard  changed:

   What|Removed |Added

 Blocks||29556


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556
[Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part"
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29556] New: MARC21slim2MODS.xsl broken by duplicate template name "part"

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556

Bug ID: 29556
   Summary: MARC21slim2MODS.xsl broken by duplicate template name
"part"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 5927

Bug 5927, "Show series information in search results page" made a change to
MARC21slimUtils.xsl, adding a block starting like this:



...this breaks UNAPI in the OPAC when using MODS format because
MARC21slim2MODS.xsl, which imports MARC21slimUtils.xsl, also includes the same
block.

Removing the redundant section from MARC21slim2MODS.xsl should fix the error.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927
[Bug 5927] Show series information in search results page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979

--- Comment #19 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #18)
> (In reply to Nick Clemens from comment #17)
> > I believe the patches on bug 29437 resolve the issue here (if a slightly
> > different implementation)
> > 
> > *** This bug has been marked as a duplicate of bug 29437 ***
> 
> Not the second patch.

Doesn't it? 

The second patch here pushed the conditions to an array depending on whether we
think we have an ISBN or not

Bug 29437 removes the attempt to determine which kind of query we have and
instead uses 'OR' and builds the same condition each time.

As the overlap between title/author and ISBN is very small I think one
condition that searches all the fields resolves the issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979

--- Comment #18 from Jonathan Druart  ---
(In reply to Nick Clemens from comment #17)
> I believe the patches on bug 29437 resolve the issue here (if a slightly
> different implementation)
> 
> *** This bug has been marked as a duplicate of bug 29437 ***

Not the second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709

--- Comment #14 from Nick Clemens  ---
(In reply to David Cook from comment #13)
> (In reply to Nick Clemens from comment #12)
> > > Did you benchmark this patch?
> > with numSearchResults at 50 - standard sample data, search for 'a'
> > Before patch ~2 second
> > After patch ~1.85 seconds
> 
> Is that averaged or based on 1 test each?

I repeated the tests 10 times each, that was the average

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Owen Leonard  changed:

   What|Removed |Added

 Attachment #127928|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 127931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127931=edit
Bug 29524: (bug 28935 follow-up) Restore modification of some patron's
attributes

On
  commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3
  Bug 28935: No filtering on patron's data on member entry pages
we restricted the list of the columns from the borrowers table that can
be modified from the patron edit view.
We were too restrictive, the following 3 attributes can be edited from
this form: privacy_guarantor_fines, privacy_guarantor_checkouts,
checkprevcheckout and lang

Test plan:
Turn on the following prefs:
- AllowStaffToSetFinesVisibilityForGuarantor
- AllowStaffToSetCheckoutsVisibilityForGuarantor
- CheckPrevCheckout (set to 'unless overridden *')
- TranslateNotices
Edit a patron and see the 4 different options are now displayed.
Change their value, save, edit again
Confirm that the values have been saved

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437

--- Comment #19 from Nick Clemens  ---
*** Bug 17979 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Failed QA   |RESOLVED

--- Comment #17 from Nick Clemens  ---
I believe the patches on bug 29437 resolve the issue here (if a slightly
different implementation)

*** This bug has been marked as a duplicate of bug 29437 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17423] patronimage.pl permission is too restrictive

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17423

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29541

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

--- Comment #18 from David Gustafsson  ---
Hi! As it wasn't really ready for signoff I did not change the status. Have
done some manual testing to go through most of the options and catch possible
issues after splitting the code into feature branches. There are no (serious at
least) bugs fixed, and no features added, just a clean up, so what need to make
sure is that the script works as before. There is no test-suite for
bulkmarkimport.pl so it's a lot of work for reviewers to go through all the
options and fully test the script, but I can at least provide some basic steps
wit the most common options.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555

--- Comment #1 from Nick Clemens  ---
Created attachment 127929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127929=edit
Bug 29555: Don't push auto_too_soon issues into report

This patch adds a conditional to avoid reporting on issues that are too
soon to be renewed

To test:
 1 - Set  AutoRenewalNotices preference to 'according to patron messaging
preferences'
 2 - Set a patront o request auto renewal emails digested
 3 - Checkout an item to the patron, back dated to be opverdue, and marked for
auto renewal
 4 - Add an email to the patron for testing
 5 - perl misc/cronjobs/automatic_renewals.pl -v -c
 6 - See the issue is renewed (ensure it is now not overdue)
 7 - Confirm the patron was sent a digest with the renewal (on patron 'Notices'
tab)
 8 - perl misc/cronjobs/automatic_renewals.pl -v -c
 9 - See the issue was not renewed
10 - See a notice was sent, with no indication of what happened to the issue
11 - Apply patch
12 - perl misc/cronjobs/automatic_renewals.pl -v -c
13 - Confrim no renewal or notice
14 - Checkout a second item to patron, backdated and set for auto renewal
15 - perl misc/cronjobs/automatic_renewals.pl -v -c
16 - Confirm the correct item is renewed and notice sent
17 - Confirm notice does not include the too soon issue
18 - Checkout a third item
19 - perl misc/cronjobs/automatic_renewals.pl -v -c -b
20 - Confirm correct item is renewed and notice sent, nbot including other two
21 - perl misc/cronjobs/automatic_renewals.pl -v -c -b
22 - Confirm no notice sent

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29555] Auto-renewals digest reports on 'auto_too_soon'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

--- Comment #2 from Jonathan Druart  ---
Created attachment 127928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127928=edit
Bug 29524: (bug 28935 follow-up) Restore modification of some patron's
attributes

On
  commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3
  Bug 28935: No filtering on patron's data on member entry pages
we restricted the list of the columns from the borrowers table that can
be modified from the patron edit view.
We were too restrictive, the following 3 attributes can be edited from
this form: privacy_guarantor_fines, privacy_guarantor_checkouts,
checkprevcheckout and lang

Test plan:
Turn on the following prefs:
- AllowStaffToSetFinesVisibilityForGuarantor
- AllowStaffToSetCheckoutsVisibilityForGuarantor
- CheckPrevCheckout (set to 'unless overridden *')
- TranslateNotices
Edit a patron and see the 4 different options are now displayed.
Change their value, save, edit again
Confirm that the values have been saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29555] New: Auto-renewals digest reports on 'auto_too_soon'

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29555

Bug ID: 29555
   Summary: Auto-renewals digest reports on 'auto_too_soon'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When a patron has requested auto-renewal digests the cron sends emails when all
items are  'auto_too_soon'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28935] No filtering on patron's data on member entry pages (OPAC, self registration, staff interface)

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29524


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524
[Bug 29524] cannot set a new value for privacy_guarantor_checkouts in
memberentry.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29524] cannot set a new value for privacy_guarantor_checkouts in memberentry.pl

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524

Jonathan Druart  changed:

   What|Removed |Added

   Severity|major   |critical
 Depends on||28935
 CC||jonathan.druart+koha@gmail.
   ||com
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com
 Status|NEW |ASSIGNED

--- Comment #1 from Jonathan Druart  ---
Caused by
  commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3
  Bug 28935: No filtering on patron's data on member entry pages


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935
[Bug 28935] No filtering on patron's data on member entry pages (OPAC, self
registration, staff interface)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504

--- Comment #7 from Jonathan Druart  ---
Batch checkout is broken as well for 'ADDITIONAL_MATERIALS'. I've tried to fix
it but it's not trivial, and I think this patch is impacted by the same
problem.
You can have ADDITIONAL_MATERIALS AND another flags, in that case you shouldn't
be allowed to bypass.
We need to test that ADDITIONAL_MATERIALS is the only flag that needs a
confirmation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554

--- Comment #4 from Marcel de Rooy  ---
Created attachment 127927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127927=edit
Bug 29554: Do not hide display of itemtypes on neworderempty

Hiding them may lead to biblioitems.itemtype==NULL.
We do not want that, since 942$c is mandatory.

Test plan:
Create basket, create order from new empty record.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29554] neworderempty.pl may create records with biblioitems.itemtype NULL

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >