[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

--- Comment #10 from Samu Heiskanen  ---
If you move the line:

323my $biblio = Koha::Biblios->find( $biblionumber );

just before the foreach loop and add the line:

biblio => $biblio,

to:

738 # display infos
739 $template->param(
740reserveloop=> 1,
741itemdata_enumchron => $itemdata_enumchron,
742itemdata_ccode => $itemdata_ccode,
743date   => $date,
744biblionumber   => $biblionumber,
745findborrower   => $findborrower,
746holdsview  => 1,
747C4::Search::enabled_staff_search_views,
748 );

like:

# display infos
$template->param(
reserveloop=> 1,
itemdata_enumchron => $itemdata_enumchron,
itemdata_ccode => $itemdata_ccode,
date   => $date,
biblionumber   => $biblionumber,
findborrower   => $findborrower,
biblio => $biblio,
holdsview  => 1,
C4::Search::enabled_staff_search_views,
);

The patch works. What is your opinion, have I got it done correcly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

--- Comment #7 from David Nind  ---
I think it is the same (better described). I hadn't marked as a duplicate yet,
but did link them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641

Mason James  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29631
 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

Mason James  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29641

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
This is a duplicate of bug 29631 - the screens shots are helpful though!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29642] About page marks several Perl modules as missing (package installation).

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642

Manos PETRIDIS  changed:

   What|Removed |Added

Summary|About page marks several|About page marks several
   |Perl modules as missing |Perl modules as missing
   ||(package installation).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538

Manos PETRIDIS  changed:

   What|Removed |Added

 CC||egpetri...@yahoo.com

--- Comment #9 from Manos PETRIDIS  ---
Am I correct to understand that Jonathan Druart decided to remove functionality
from the koha-common package after consulting a single person? Are there no
other libraries in Italy following the UNIMARC standard? Are there no other
libraries in Italy interested in installing koha?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

Manos PETRIDIS  changed:

   What|Removed |Added

 CC||egpetri...@yahoo.com

--- Comment #6 from Manos PETRIDIS  ---
Could it be related to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641

--- Comment #2 from Manos PETRIDIS  ---
I wonder if it is related to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29642] New: About page marks several Perl modules as missing

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642

Bug ID: 29642
   Summary: About page marks several Perl modules as missing
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: egpetri...@yahoo.com
QA Contact: testo...@bugs.koha-community.org

I notice that in the "Perl modules" tab at /cgi-bin/koha/about.pl some modules
appear as missing, namely

Text::CSV::Unicode (0.40)   Not Installed
Selenium::Remote::Driver (1.27) Not Installed   
Test::DBIx::Class (0.42)Not Installed
HTTPD::Bench::ApacheBench (0.73)Not Installed
Locale::XGettext::TT2 (0.7) Not Installed

As my installation is a vanilla one (koha-common on Debian),
I wonder if they should have been installed by default. 

For example, I see in 
https://git.koha-community.org/Koha-community/Koha/commit/f180314f58c57ce0c6c1094fa19da88502085144
that "Selenium::Remote::Driver (1.27)" should have been included in the
dependencies list years ago. 

Another example: Locale::XGettext::TT2 (0.7) is mentioned in 
https://git.koha-community.org/Koha-community/Koha/commit/3cfc2ec7bd1becef4386404fe7fc9f12740e8c97
as "new dependency" two years ago, yet it is absent from my installation,
despite several upgrades since. 

What gives?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641

--- Comment #1 from Manos PETRIDIS  ---
Created attachment 128250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128250=edit
Error message in web interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29641] New: Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641

Bug ID: 29641
   Summary: Error "Duplicate entry 'IN-region' for key 'uniq_lang'
at /usr/share/koha/lib/C4/Installer.pm line 738" while
upgrading from 21.05.05-3 to 21.11.00-1
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: Linux
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: egpetri...@yahoo.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 128249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128249=edit
Error message in CLI

During both phase one (command line installer) and phase two (web-based
installer) upgrade from 21.05.05-3 to 21.11.00-1 fails, throwing the following
message:

Upgrade to 21.06.00.012 [15:25:02]: Bug 15067 - Add missing languages
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738

Please advise.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29640] [22.05] Documentation changes for 22.05

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29640

--- Comment #1 from David Nind  ---
The spreadsheet lists all bugs pushed to master for 22.05.

This will be used to:
1. Review all bugs
2. Determine if documentation changes are required, and 
3. Manage documentation tasks for a release. 

Process for maintaining the list:
1. Update list each week (or as required) with the bugs pushed to master by
either:
  . using the GitLab mirror at
https://gitlab.com/koha-community/Koha/-/commits/master to identify bugs pushed
  . incorporate changes from the Bugzilla query
https://bugs.koha-community.org/bugzilla3/buglist.cgi?cmdtype=runnamed_id=394355=Doc%20changes%2022.05
2. Review each bug and determine whether any updates are required.
3. Update the appropriate columns in the spreadsheet (apart from assigned to):
   . Reviewed for documentation changes? (Y/N)
   . Documentation changes required? (Y/N/Review)
   . Complexity (Easy/Medium/Hard)
   . Reviewed by
   . Date reviewed
   . Assigned to
   . Completed (Y/N/N/A)
   . Include in what's new? (Y/N)
   . Notes
3. Update the text to go in the release notes where required.
4. Update the log in the spreadsheet and note on this bug,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29640] New: [22.05] Documentation changes for 22.05

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29640

Bug ID: 29640
   Summary: [22.05] Documentation changes for 22.05
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: https://docs.google.com/spreadsheets/d/1fhi7ogwYjtYlal
s5K6_Uxun9LBqRktGOTLC3k3fT1aA/edit?usp=sharing
OS: All
Status: NEW
  Severity: normal
  Priority: P1 - high
 Component: Documentation
  Assignee: da...@davidnind.com
  Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org

This is a placeholder for reviewing all the bugs in 22.05 and determining which
ones require documentation updates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29473] [21.11] Documentation changes for 21.11

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473

David Nind  changed:

   What|Removed |Added

Summary|Documentation changes for   |[21.11] Documentation
   |21.11   |changes for 21.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576

Didier Gautheron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576

--- Comment #1 from Didier Gautheron  ---
Created attachment 128248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128248=edit
Bug 34874: Add streettype and B_streettype to PrefillGuaranteeField

To test :
 1) modify PrefillGuaranteeField system preference
 2) road type for main and alternate addresses aren't in the list
 3) Apply patch
 4) Redo 1, now they are

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #128246|0   |1
is obsolete||

--- Comment #3 from Fridolin Somers  ---
Created attachment 128247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128247=edit
Bug 29621: Add link for Lists on opac-detail.pl

When logged into the OPAC and viewing a results list of titles on
opac-search.pl it is possible to see if a title is contained in a List.  The
link allows the user to click on it to get to the contents of the List.  It
would be helpful if the link for the List was also displayed on opac-detail.pl
so the user could get to the results of the List from that page as well.

This patch uses Koha::Virtualshelves->get_shelves_containing_record() in
opac detail page like it is used in opac results page.

Test plan :
1) Connect to OPAC as user U1
2) Create a public and a private list
3) Add a record B1 to both lists
4) Go to opac detail page of record B1
5) Without patch your see only link to public list, with patch you also
   see link to private list
6) Connect to OPAC as another user U2
7) Add record B1 to a private list
8) Go to opac detail page of record B1
9) With patch, check you see only link to your private list, not to list of
user U1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621

--- Comment #2 from Fridolin Somers  ---
Created attachment 128246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128246=edit
Bug 29621: Add link for Lists on opac-detail.pl

When logged into the OPAC and viewing a results list of titles on
opac-search.pl it is possible to see if a title is contained in a List.  The
link allows the user to click on it to get to the contents of the List.  It
would be helpful if the link for the List was also displayed on opac-detail.pl
so the user could get to the results of the List from that page as well.

This patch uses Koha::Virtualshelves->get_shelves_containing_record() in
opac detail page like it is used in opac results page.

Test plan :
1) Connect to OPAC as user U1
2) Create a public and a private list
3) Add a record B1 to both lists
4) Go to opac detail page of record B1
5) Without patch your see only link to public list, with patch you also
   see link to private list
6) Connect to OPAC as another user U2
7) Add record B1 to a private list
8) Go to opac detail page of record B1
9) With patch, check you see only link to your private list, not to list of
user U1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl

2021-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/