[Koha-bugs] [Bug 29659] QR Code Accompanying material

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #2 from Magnus Enger  ---
I think Fridolin has a good point. But if you really want to display the
QR-code, maybe you could add it as a local cover image? 

(One scenario: The OPAC is displayed in a kiosk setup in the library, where you
do not want patrons to be able to click on anything that takes them outside the
OPAC. But letting them scan the QR-code on their mobile device and enjoy the
content there might be desirable.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694

--- Comment #33 from Magnus Enger  ---
I just discovered that some of my use cases for this bug can be solved by the
development on bug 17826. If the Meröppet vendor can work with 0/1 in a made up
SIP2 field, that bug solves the problem. 

We still need this bug if the vendor only accepts values in field 1 and/or two
of the patron information response.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29657] OpacNavRight is only added to one language for OPACs with multiple active languages

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29657

--- Comment #3 from Katrin Fischer  ---
Default is a 21.11 feature done with the "rename tools" bug 24387. So in older
versions the prefs were added to each language to not break behaviour. It
worked for header, credits and such, but not for OpacNavRight.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29659] QR Code Accompanying material

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659

--- Comment #3 from Afroditi Fragkou  ---
Maybe I lack some knowledge so my understanding is poor, but when I have a QR
code printed on the book, don't I need a qr reader to see the url it leads to?
How can I do that using my regular client pc, so that I can add it in the
bibliographic record?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29667] Gmail>>Compose>>Clicking on send button application throws server error

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29667

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---
This bug tracker doesn't cover GMail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607

Kunal  changed:

   What|Removed |Added

 CC||kunalschakrabo...@gmail.com
   Priority|P5 - low|P1 - high
   Hardware|All |PC
   Severity|enhancement |major
 OS|All |Linux

--- Comment #1 from Kunal  ---
This happened after full web-installation of Koha 21.11.00.000 in Ubuntu
20.04LTS.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #2 from Katrin Fischer  ---
Thx, David. I think Martin/Caroline might also be able to help a bit. We really
need to write things down.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063

Katrin Fischer  changed:

   What|Removed |Added

 CC||da...@davidnind.com
Summary|Manual: Translation issue   |[DOCS] Manual: Translation
   |with repeated strings in|issue with repeated strings
   |system preferences  |in system preferences
  Component|I18N/L10N   |Documentation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607

Owen Leonard  changed:

   What|Removed |Added

 CC||dpav...@rot13.org
   Hardware|PC  |All
Version|unspecified |21.11
  Component|Web services|Authentication
   Priority|P1 - high   |P5 - low
 OS|Linux   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063

--- Comment #1 from Katrin Fischer  ---
For an example:

Asks: ___ cash registers with the accounting system to track payments.

Default: Don't use
Values:
Don't use
Use

So each of those lines get to be a separate string.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22671] Warn the user in offline circulation if applicationCache isn't supported

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671

Owen Leonard  changed:

   What|Removed |Added

Summary|Built-in offline|Warn the user in offline
   |circulation |circulation if
   |applicationCache errors |applicationCache isn't
   ||supported

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228

Owen Leonard  changed:

   What|Removed |Added

 Depends on|22671   |

--- Comment #2 from Owen Leonard  ---
I'm removing the dependency on Bug 22671 because it's not strictly necessary,
it just makes it easier to identify whether you're testing in a browser which
will work.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671
[Bug 22671] Warn the user in offline circulation if applicationCache isn't
supported
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22671] Warn the user in offline circulation if applicationCache isn't supported

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671

Owen Leonard  changed:

   What|Removed |Added

 Blocks|29228   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228
[Bug 29228] Use Flatpickr on offline circulation page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

--- Comment #13 from Ray Delahunty  ---
I have been testing out changes to reservations / holds settings in our test
server and the maxreserves setting is not working for us in the way Katrin
reports. 

We are on 20.11.04 and all our 6 libraries have the same circulation policies
so I have set Total reservations allowed (under Default issue, reserve & return
policy by category) to 5 for all user categories permitted to place
reservations. Our maxreserves is set to 10.  We do not (currently) allow OPAC
item level reservations so I am not yet thinking about how the Reservations
allowed (under Defining circulation & fine rules for all libraries) will work
for us. (Like, how would Koha know the counts of reservations by item type in
our title-level reservation environment, so it could limit reservations using
this very granular functionality?).  I have set Reservations allowed to 10
which I think effectively takes ‘reservations by item type/user category’ out
of the equation).

But I have not been able to place more than 5 reservation using either the OPAC
or the Koha intranet.  I tried this with ReservesControlBranch set to either of
Item’s home library or user’s home library, but I have not been able to achieve
what I thought was how the functionality works- say 5 reservations for items at
library A, 3 reservations at library B and 2 at Library C.

We are trying to unravel how the counts are set so we can set the counts to be
how we want them to be. Being able to advise users that ‘Patrons in Category A
can have a total of 50 holds across all branches’ (or whatever) would be great.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #128315|0   |1
is obsolete||

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 128372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128372&action=edit
Bug 29349: (follow-up) Fix width of item level dropdowns

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #19 from Tomás Cohen Arazi  ---
Signed on the follow-up. Thanks, Lucas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29669] New: Uninitialized value warnings when XSLTParse4Display is called

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669

Bug ID: 29669
   Summary: Uninitialized value warnings when XSLTParse4Display is
called
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: stalkern...@gmail.com
  Reporter: stalkern...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl, nug...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order"

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708

--- Comment #24 from Martin Renvoize  ---
Comment on attachment 127233
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233
Bug 27708: Unify two item object creation blocks to be stored as hash

Review of attachment 127233:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27708&attachment=127233)
-

::: Koha/Edifact/Order.pm
@@ +392,5 @@
> +branchcode => $item->{branchcode},
> +itype  => $item->{itype},
> +location   => $item->{location},
> +itemcallnumber => $item->{itemcallnumber},
> +};

Pretty sure the above block causes breakage.. you are using `$item` as though
it's a hash representation of an item row.. but it's not.. it's the hash of the
AqOrdersItems link table.. so it doesn't contain branchcode, itype, location or
itemcallnumber.

It should be using the actual item row.. as before.. $i_obj

This breaks our live systems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order"

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708

--- Comment #25 from Martin Renvoize  ---
Comment on attachment 127233
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233
Bug 27708: Unify two item object creation blocks to be stored as hash

Review of attachment 127233:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27708&attachment=127233)
-

::: Koha/Edifact/Order.pm
@@ +392,5 @@
> +branchcode => $item->{branchcode},
> +itype  => $item->{itype},
> +location   => $item->{location},
> +itemcallnumber => $item->{itemcallnumber},
> +};

Pretty sure the above block causes breakage.. you are using `$item` as though
it's a hash representation of an item row.. but it's not.. it's the hash of the
AqOrdersItems link table.. so it doesn't contain branchcode, itype, location or
itemcallnumber.

It should be using the actual item row.. as before.. $i_obj

This breaks our live systems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669

Peter Vashchuk  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669

--- Comment #1 from Peter Vashchuk  ---
Created attachment 128373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128373&action=edit
Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called

Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl
(the only places where it is used in the code even) instead of
'xsl_syspref' that is actually used and this is the cause of those
warnings.

Also added honeypot to check if other calls in same way happens.
Honeypot probably not needed, review when QA in the Community.

To reproduce:
1) Prepare some test list with items or use existing one.
2) Go to the lists page (koha/virtualshelves/shelves.pl),
notice multitude of new warnings in the "intranet-error.log" log file
that mostly have to do with "Use of uninitialized value $xslsyspref".
3) Apply the patch.
4) Go back to same page and check it again, warns like that should not
appear in the log file anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] New: Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Bug ID: 29670
   Summary: Fix errors caused by bug 27708
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

Bug 27708 misunderstood how the acquisitions link tables work and thus
incorrectly assigned values from rows in the wrong table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |critical
 Depends on||27708


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708
[Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an
order"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order"

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||29670


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670
[Bug 29670] Fix errors caused by bug 27708
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29671] New: Dropbox mode is unchecked after check in confirm on item with Materials specified

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671

Bug ID: 29671
   Summary: Dropbox mode is unchecked after check in confirm on
item with Materials specified
 Change sponsored?: ---
   Product: Koha
   Version: 20.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: christophe.to...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org

Created attachment 128374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128374&action=edit
Suggested patch

steps to reproduce :


1) Enable System preference CirConfirmItemParts
2) Go to Circulation > Check in
3) Enable Dropbox mode (Book drop mode) in the Checkin settings
4) Enter a barcode of an item having the 'Materials specified' field not empty
5) A Popup is shown, click the confirm button
6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked.


In the template, the modal window lacks the dropboxmode input, so that it stays
on the next page. I attached a patch with my suggested correction.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

--- Comment #1 from Martin Renvoize  ---
Created attachment 128375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128375&action=edit
Bug 29670: Fix EDI for AcqCreateItem = 'placing on order'

The AcqCreatItem at order time functionality was broken by bug 27708.
This patch resolves that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com,
   ||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] New: Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Bug ID: 29672
   Summary: Increase performance of Koha::Plugins->call
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Every call to Koha::Plugins->call do a lot of database queries:
1) One in GetPlugins searches for available plugin_class in plugin_methods
table
2) One in Koha::Plugins::Base::is_enabled for each plugin returned by (1)
3) One or two in Koha::Plugins::Base::new for each plugin returned by (1) to
check the install status and the installed version

All of these requests only need to be made once per HTTP request at most. One
could argue that it's needed only at Koha startup but that besides the point of
this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #1 from Julian Maurice  ---
Created attachment 128376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128376&action=edit
Bug 29672: Increase performance of Koha::Plugins->call

Make use of Koha::Cache::Memory::Lite to avoid hitting the database and
creating plugins object for every call to Koha::Plugins->call

Test plan:
1. Make sure plugins still work by executing
   `prove t/db_dependent/Koha/Plugins/Plugins.t`
2. Run the test script provided in the following patch to see how it
   affects performances

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #2 from Julian Maurice  ---
Created attachment 128377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128377&action=edit
Bug 29672: [DO NOT PUSH] Test script

Run test-plugins-call.pl without arguments with and without the patches,
with some plugins enabled. Make sure to run
misc/devel/install_plugins.pl before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #3 from Julian Maurice  ---
Times I get on master:

1 call(s): Elapsed 0.670997 seconds
10 call(s): Elapsed 0.049056 seconds
100 call(s): Elapsed 0.468099 seconds
1000 call(s): Elapsed 4.762553 seconds

Times I get with the patch:

1 call(s): Elapsed 0.634319 seconds
10 call(s): Elapsed 0.000154 seconds
100 call(s): Elapsed 0.001282 seconds
1000 call(s): Elapsed 0.011682 seconds

As you can see the first call takes the same time with or without the patch,
but subsequent calls are much more faster with the patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Julian Maurice  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28172

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172

Julian Maurice  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29672

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173

--- Comment #5 from Julian Maurice  ---
(In reply to Fridolin Somers from comment #3)
> Oh crap.
> 
> We found a big performance issue with this hook.
> 
> Each store() call is checking in DB the plugin version and if it is enabled.
> 
> Particulary when DB is distant this is bad for performance.

The problem is not this particular hook. It's Koha::Plugins->call that is too
slow. I tried making it faster with bug 29672.
Please test and let me know what you think

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29673] New: Allow an English sql localization script

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673

Bug ID: 29673
   Summary: Allow an English sql localization script
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

There is no default English sql localization obviously. But why shouldnt we
allow it when someone adds a custom script there to do things that are done too
for the other languages like de-DE etc. ?

Tiny adjustment

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

--- Comment #3 from Thibaud Guillot  ---
Created attachment 128378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128378&action=edit
Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU"
(Authority page detail)

Now this action has the same pre-filling behaviour as the "Edit" -> "Edit
Record" -> "Replace Record via Z39.50/SRU Search" action.
Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled
in if the subfield contains data (like the "Edit->Replace" action).
Unimarc and Marc21 specificities are supported.

Test Plan :

1) You must have a Z39.50/SRU server for authorities
2) Go to an authority detail page (Author - Uniform title - Subject)
3) First go to "Edit"-> "Edit record" -> "Replace record via..."
4) See that form is prefilled with form data
5) Go back and now click on "Replace Record.." directly
6) See that form is also prefilled with data now

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

Thibaud Guillot  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173

Thibaud Guillot  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128375|0   |1
is obsolete||

--- Comment #2 from Martin Renvoize  ---
Created attachment 128379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128379&action=edit
Bug 29670: Fix EDI for AcqCreateItem = 'placing on order'

The AcqCreatItem at order time functionality was broken by bug 27708.
This patch resolves that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29674] New: Syspref autoBarcode add just

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29674

Bug ID: 29674
   Summary: Syspref autoBarcode add just 
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: josean...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The System Preference autoBarcode have this option: yymm0001
It would be very useful to our Library if there we have the option just

The other part of the barcode it would be manually inserted.

The reason is to avoid mistakes because our School Librarians always forget to
start barcode with .
Thank you very much

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|k...@bywatersolutions.com   |testo...@bugs.koha-communit
   ||y.org
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29673] Allow an English sql localization script

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673

--- Comment #1 from Marcel de Rooy  ---
DBIx::RunSQL is quite stupid on splitting by newlines btw..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594

--- Comment #4 from Blou  ---
Sponsored by: Ville de Saint-Eustache

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355

--- Comment #7 from George Williams (NEKLS)  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12450] Closing libraries for the summer

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450

--- Comment #12 from Michael Adamyk  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355

Sarah Fletcher  changed:

   What|Removed |Added

 CC||sfletc...@ncrl.org

--- Comment #8 from Sarah Fletcher  ---
NCW Libraries is extremely interested in this enhancement as well! It would
save us a lot of staff time.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 128380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128380&action=edit
Bug 28377: (28937 follow-up) Flatpickr change

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||28937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937
[Bug 28937] Use Flatpickr on circulation and patron pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||28377


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
[Bug 28377] Use the API to suspend/resume holds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 128381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128381&action=edit
Bug 28377: (QA follow-up) Fallback error handling

The code only dealt with 404, this patch makes it have a fallback
message for failure codes.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #128334|0   |1
is obsolete||

--- Comment #3 from Andrew Fuerste-Henry  ---
Created attachment 128382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128382&action=edit
Bug 27868: Add expiration date to holds awaiting pickup

To test:
1. Have some holds awaiting pickup, also have some holds that have been waiting
longer than the ReservesMaxPickUpDelay is set to.
2. Go to /cgi-bin/koha/circ/waitingreserves.pl
3. There is no expiration date
4. Apply patch and restart_all
5. Now there should be a Expiration date column, make sure you can see it in
both Holds waiting and Holds waiting over X days
6. Make sure all the columns Waiting Since, Date hold placed, and expiration
date still sort correctly
6. Go to Table settings, and make sure all the columns hide correctly for both
of the  holds_awaiting_pickup tables ( holdst & holdso )

Note: This patch also corrects 2 other small problems

1. Corrects a problem where the table settings did not account for the checkbox
column at the beginnning of each table
2. Removes the title-string class and uses data-order to sort Waiting Since,
Date hold placed, and expiration date ( see Bug 27934 )

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

--- Comment #19 from Samu Heiskanen  ---
Sorry, I got a little carried away with this bug. But original assignee, Nick
please continue from here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29675] New: Can't get to Holds Ratio page

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29675

Bug ID: 29675
   Summary: Can't get to Holds Ratio page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Go to Circulation and try go click on the Hold Ratios report. (
/cgi-bin/koha/circ/reserveratios.pl )

CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::reserveratios_2epl():
DBI Exception: DBD::mysql::st execute failed:
'koha_kohadev.reserves.reservedate' isn't in GROUP BY at
/usr/share/perl5/CGI/Emulate/PSGI.pm line 30
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29675] Can't get to Holds Ratio page

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29675

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29675] Can't get to Holds Ratio page

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29675

--- Comment #1 from Lucas Gass  ---
In koha-testing-docker, If I turn off SQL strict mode I can access the page. So
I'm not sure if this is a Koha bug or just a koha-testing-docker thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607

--- Comment #2 from Katrin Fischer  ---
Is it possible that you have changed the timeout system preference to a too low
value?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29659] QR Code Accompanying material

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659

--- Comment #4 from Katrin Fischer  ---
It looks like there are barcode scanners that can read QR codes you could use
at a normal computer to 'translate' the QR code to an URL. 
Maybe there are also web apps that can use your laptop camera or webcam?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29676] New: Protect a bib record from being overlaid when matched

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676

Bug ID: 29676
   Summary: Protect a bib record from being overlaid when matched
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aspencatt...@clicweb.org
QA Contact: testo...@bugs.koha-community.org

It would be nice to be able to mark a bibliographic record that would protect
it from being overlaid when "matched" on import.  For example we have records
that are for a book club kit, so there is an ISBN in the record that puts it
available for match when importing records.  We would want to indicate in some
fashion that this record will not be available to attach items on import, nor
be available to be overlaid if that was the choice made on import.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676

AspenCat Team  changed:

   What|Removed |Added

 CC||aspencatt...@clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #105 from Alex Buckley  ---
Hi all, 

I've rebased this patchset, added a missing change to kohastructure.sql, and
merged the following 4 patches into 1 patch:

-  Bug 26346: Add option to make public lists editable by all staff
-  Bug 26346: Add edit_public_lists sub-permission enabling patrons to switch
'owner only' public lists (which they're not the owners of) to 'staff only'
lists
-  Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user
-  Bug 26346: (follow-up) Fixes in response to QA

I have also reworked the test plan to hopefully make it more succinct, and
easier to follow.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley  changed:

   What|Removed |Added

 Attachment #128023|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley  changed:

   What|Removed |Added

 Attachment #128021|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley  changed:

   What|Removed |Added

 Attachment #128020|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley  changed:

   What|Removed |Added

 Attachment #128019|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley  changed:

   What|Removed |Added

 Attachment #128018|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley  changed:

   What|Removed |Added

 Attachment #128017|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #106 from Alex Buckley  ---
Created attachment 128383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128383&action=edit
Bug 26346: Database changes

- Adds allow_change_from_staff to virtualshelves table
- Add edit_public_lists sub-permission

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #107 from Alex Buckley  ---
Created attachment 128384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128384&action=edit
Bug 26346: Updated schema file

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #108 from Alex Buckley  ---
Created attachment 128385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128385&action=edit
Bug 26346: Add option to make public lists editable by all staff

If a staff member has access to the staff client (either because
'catalogue' permission is enabled or they're a superlibrarian
then that user can add items (from OPAC or staff client) to a list
marked 'Staff only'

Test plan:
1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes
to contents
from' there are three options: Nobody, Owner only, Anyone seeing this
list

2. Apply first 3 patches and run updatedatabase.pl
cd installer/data/mysql
sudo koha-shell 
./updatedatabase.pl

3. Restart memcached and plack

4. Create 4 patron accounts:
- User A : Superlibrarian permissions
- User B : 'Staff access, allows viewing of catalogue in staff interface
(catalogue)'
- User C : No permissions
- User D : 'Staff access, allows viewing of catalogue in staff
interface' and 'Lists' > Edit public lists (edit_public_lists)' sub-permission

5. Login to staff client as User A.
Create a public list and select the new 'Staff only' option under 'Allow
changes to contents from'

6. Log into the staff client as User B.
Confirm you can add items to the list from the following staff client pages:
- Individual list page using the 'Add items' button
- Staff client search result page
- Staff client biblio detail page

7. Confirm you can remove items from the list

8. Confirm you can perform an OPAC search when not logged in

9. Log into the OPAC as User B. Confirm you can add items to the list
from the following OPAC pages:
- OPAC search result page
- OPAC biblio detail page

10. Log into the OPAC as User C. Do an OPAC search and confirm you
can view the list, but not add items to it

11. Login to the staff client as User B. Create a new list with the
following settings:
- 'Category'='Private',
- 'Allow changes to contents from'='Staff only'

Notice a red hint message is displayed.
Change 'Category'='Public' and notice the hint is removed

12. Log into the OPAC as User C. Notice the 'Staff only' option is not
available when creating a list

13. Log into the OPAC as User B. Repeat step 11. Confirm the same
outcome

14. Log into the staff client as User A. Create a list with the
following settings:

- Public = 'Public'
- Allow changes to contents from = 'owner only'

15. Log into the staff client as User D. Edit the list from step 14
confirm you can edit the list to have 'Allow changes to contents from' =
'Staff only'

16. Run Patron.t and Virtualshelves.t unit tests:
sudo koha-shell 
prove t/db_dependent/Koha/Patron.t
prove t/db_dependent/Virtualshelves.t

Sponsored-by: Horowhenua District Council, New Zealand

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793

--- Comment #19 from David Cook  ---
(In reply to Ere Maijala from comment #14)
> Ok, fine. :) I trust that there will be something using this soon. I'm
> generally not in favour of adding functionality without anything using it
> since there's always a risk that something happens and it ends up never
> being used.

I don't think there's any core functionality that is using it today
unfortunately.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

--- Comment #109 from Alex Buckley  ---
Ready to test again!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||7923
 CC||fridolin.som...@biblibre.co
   ||m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923
[Bug 7923] Performance omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7923] Performance omnibus

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||29672


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
[Bug 29672] Increase performance of Koha::Plugins->call
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29677] New: SErials logs

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29677

Bug ID: 29677
   Summary: SErials logs
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ha...@orex.es
QA Contact: testo...@bugs.koha-community.org

Serials logs should include more data, now there is no way of knowsing how many
issues has been added by subscription or who has added them,all other modules
haave detailed info in logs

Action_log table should include also modifications on serial table, who, when
and action

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #4 from Fridolin Somers  ---
I see it returns undef when plugins are disabled.
It should return empty array non ?

In order to allow :

my @plugin_responses = Koha::Plugins->call(
'opac_results_xslt_variables',
{
lang   => $lang,
patron_id  => $borrowernumber
}
);
for my $plugin_variables ( @plugin_responses ) {
$variables = { %$variables, %$plugin_variables };
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #5 from Fridolin Somers  ---
(In reply to Fridolin Somers from comment #4)
> I see it returns undef when plugins are disabled.
> It should return empty array non ?
> 
> In order to allow :
> 
> my @plugin_responses = Koha::Plugins->call(
> 'opac_results_xslt_variables',
> {
> lang   => $lang,
> patron_id  => $borrowernumber
> }
> );
> for my $plugin_variables ( @plugin_responses ) {
> $variables = { %$variables, %$plugin_variables };
> }

Oh i see it is covered by a unit test :
t::lib::Mocks::mock_config('enable_plugins', 0);
@responses = Koha::Plugins->call('check_password', { password => '1234' });
is_deeply(\@responses, [], 'call() should return an empty array if plugins
are disabled');

Should be OK :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063

--- Comment #2 from David Nind  ---
Hi Katrin.

Just to make sure I've understand the problem.

Previously you would get something like 'Don't use' and 'Use' as separate
strings to translate.

That way you could translate using the right word, depending on the rest of the
sentence for the system preference.

But now you are getting 'Don't use Use' as one string to translate.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063

David Nind  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |da...@davidnind.com
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #6 from Fridolin Somers  ---
Instead of creating get_enabled_plugins(),
Why not adding a param "only_enabled" in GetPlugins() ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #7 from Julian Maurice  ---
(In reply to Fridolin Somers from comment #6)
> Instead of creating get_enabled_plugins(),
> Why not adding a param "only_enabled" in GetPlugins() ?

GetPlugins already returns only enabled plugins by default (without the 'all'
parameter), but it also have other parameters that make it hard for its result
to be put in cache.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607

--- Comment #3 from Kunal  ---
(In reply to Katrin Fischer from comment #2)
> Is it possible that you have changed the timeout system preference to a too
> low value?

I have not changed anything. I have tried many instructions but the only one
that reached up to web installation and showed that error. Below is the link
for the instruction page that I followed.

https://technicaldigit.com/install-koha-on-ubuntu/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29659] QR Code Accompanying material

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659

--- Comment #5 from Afroditi Fragkou  ---
Ok, I'll look into it. Thank you all!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29659] QR Code Accompanying material

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659

--- Comment #6 from Fridolin Somers  ---
Or use a smartphone app and share the result somehow to your computer.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29672

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28173

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173

Fridolin Somers  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #6 from Fridolin Somers  ---
(In reply to Julian Maurice from comment #5)
> 
> The problem is not this particular hook. It's Koha::Plugins->call that is
> too slow. I tried making it faster with bug 29672.
> Please test and let me know what you think

I agree with you.
Thanks a lot for the perf patch, looks great

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/