[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #22 from Martin Renvoize  ---
I was slow to the game here.. adding to the ndiscussion on tiaga, I've used a
few systems that take the approach Julian suggests and never had any real
performance concerns.  I quite like the idea of not having to maintain the
structure twice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
Summary|Can't use exteral URL for   |Can't use external URL for
   |XSLT stylesheet |XSLT stylesheet

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29682] SPAM

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29682

Fridolin Somers  changed:

   What|Removed |Added

Product|Project Infrastructure  |Koha
   Assignee|wizzy...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org
 Status|NEW |RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m
 QA Contact||testo...@bugs.koha-communit
   ||y.org
 Resolution|--- |INVALID
Summary|Need to realize how to  |SPAM
   |activate cash app card? |
  Component|Project website |Architecture, internals,
   ||and plumbing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29681] SPAM

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29681

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 QA Contact||testo...@bugs.koha-communit
   ||y.org
  Component|Project website |Architecture, internals,
   ||and plumbing
 Status|NEW |RESOLVED
Summary|How to unblock someone on   |SPAM
   |Facebook on android phones? |
Product|Project Infrastructure  |Koha
   Assignee|wizzy...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115

--- Comment #4 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611

--- Comment #4 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565

--- Comment #26 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #17 from David Nind  ---
Patch no longer applies 8-(...

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20076: Overdues: remove redundant message when patrons don't have
email addresses
Using index info to reconstruct a base tree...
M   misc/cronjobs/overdue_notices.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/overdue_notices.pl
CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20076: Overdues: remove redundant message when patrons
don't have email addresses

Testing notes (using koah-testing-docker):

* To get notices generated on Tools > Patrons and circulation > Overdue
notice/status triggers I set the rules for all patron types and the default
library to: delay = 1, Letter = Overdue notice, Email = ticked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #27 from Fridolin Somers  ---
+ alert(_("Your request could not be processed. Check the logs"));
It is in holds.js, shouldn't it use __("foo") ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484

--- Comment #12 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin Somers  ---
I think we should rename the script debarrBorrowersWithFines.pl.
Essentially we use 'patron' now instead of 'borrowers', like
misc/import_patrons.pl.
So maybe debarr_patrons_with_fines.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #32 from Fridolin Somers  ---
I'd like a new QA on this please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #31 from Fridolin Somers  ---
Another point :

Since in opac.pref, syspref PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerMandatoryField contain :
exclusions: sort1|sort2

https://git.koha-community.org/Koha-community/Koha/src/commit/b0767f94d07950e7420deb901b208d131427c535/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref#L837

So should new syspref PatronSelfModificationMandatoryField ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #30 from Fridolin Somers  ---
Created attachment 128409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128409=edit
Bug 13188: (RM follow-up) Several fixes on db changes

Several issues with the atomic update:
 - File must to be .pl
 - File must be executable : chmod a+x
 - Syspref type is 'free' not 'multiple'

Small addition in atomic update:
I've added a print of syspref name and value,
this can be usefull for upgrade logs.

Also a minor issue in installer/data/mysql/mandatory/sysprefs.sql :
The description whas different from the atomic update.
I choose that atomic update is correct.

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|String patch|Trivial patch
 Status|Passed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #29 from Fridolin Somers  ---
Great enhancement but I found some issues in db changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29682] New: Need to realize how to activate cash app card?

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29682

Bug ID: 29682
   Summary: Need to realize how to activate cash app card?
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: jin20010...@gmail.com

Assuming that you are a cash app client and need to activate your cash app card
then you have picked the correct way to your goal. To realize how to activate
cash app card you simply need to tap on this connection and afterward your work
will be done in couple of moments.

https://www.numbersforsupport.net/blog/how-to-activate-cash-app-card/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29681] New: How to unblock someone on Facebook on android phones?

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29681

Bug ID: 29681
   Summary: How to unblock someone on Facebook on android phones?
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: jin20010...@gmail.com

Facebook has a different application for android gadgets. Assuming you are
utilizing an android gadget interestingly, you could deal with an issue in
utilizing the application. We propose clients contact our leaders to realize
How to unblock someone on Facebook. They will disclose to you the least
difficult methodology to eliminate a person from your companion list.

https://www.numbersforsupport.net/blog/unblock-someone-on-facebook/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669

Andrew Nugged  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Andrew Nugged  ---
Please provide second reproduction scheme, for opac-tags.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #10 from David Nind  ---
Thanks Martin!

Happy to figure out and run any manual steps required in the meantime.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #9 from Martin Renvoize  ---
There's a magic URL from manual translations too I believe.  I'm happy to help
on automating more of this.. I did do some work last cycle to automate the
merge requests but I can't remember what state we got to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5697] Automatic linking in guided reports

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697

--- Comment #32 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5697] Automatic linking in guided reports

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29679] Reports result menu shows too much dividers

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5697] Automatic linking in guided reports

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697

--- Comment #31 from Fridolin Somers  ---
Looks really great :D

I'm testing for push to master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680

Fridolin Somers  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29680] New: Reports menu 'Show SQL code' wrong border radius

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680

Bug ID: 29680
   Summary: Reports menu 'Show SQL code' wrong border radius
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In reports menu the 'Show SQL code' button has no right border radius.
And if you click you see 'Hide SQL code' button has no left border radius.

This is because these are two buttons in a group, hidden or displayed.
The CSS ruling border radius is from bootstrap.min.css:
.btn-group > .btn:first-child:not(:last-child):not(.dropdown-toggle) 0px

A way to fix is to create 2 button groups.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29679] Reports result menu shows too much dividers

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=5697

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5697] Automatic linking in guided reports

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29679

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29679] Reports result menu shows too much dividers

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679

--- Comment #2 from Fridolin Somers  ---
Test with report from Bug 5697 :

SELECT biblio.biblionumber , biblio.title, items.itemnumber,
items.itemcallnumber, items.barcode, borrowers.firstname,
borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber
FROM issues
LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber
LEFT JOIN items ON issues.itemnumber=items.itemnumber
LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber
ORDER BY RAND()

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29679] Reports result menu shows too much dividers

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679

--- Comment #1 from Fridolin Somers  ---
Created attachment 128408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128408=edit
Screenshot of the bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29679] Reports result menu shows too much dividers

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679

Fridolin Somers  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||29679


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679
[Bug 29679] Reports result menu shows too much dividers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29679] Reports result menu shows too much dividers

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||29186


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186
[Bug 29186] Move reports result limit menu into toolbar
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29679] New: Reports result menu shows too much dividers

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679

Bug ID: 29679
   Summary: Reports result menu shows too much dividers
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In reports when you have item/biblio/patron records, you see a menu "Batch
operations with ..."

In this menu dividers are double when showing several menu headers.

Looks like it is since Bug 29186.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Fridolin Somers  changed:

   What|Removed |Added

  Text to go in the|Adds the system preference  |Adds the system preference
  release notes|PatronSelfModificationManda |PatronSelfModificationManda
   |toryField in order to   |toryField in order to
   |separate borrower   |separate borrower
   |registration from borrower  |registration from borrower
   |modification.   |modification.
   ||Initial value
   ||is a copy of system
   ||preference
   ||PatronSelfRegistrationBorro
   ||werMandatoryField.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement changes
  release notes||the patron page (detail and
   ||circulation) so that is
   ||uses the API to suspend and
   ||resume holds on the holds
   ||tab.
   ||
   ||It also removes the
   ||svc/hold/{resume|suspend}
   ||files as they are no longer
   ||used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #8 from David Nind  ---
(In reply to Katrin Fischer from comment #7)

>.. Adding
> the manual to it would be too much I think. I'd prefer having a monthly
> update of po files at least or even better continously updates whenever a
> change is made. Especially since we have been backporting fixes/corrections
> to older versions of the manual.

Now that I'm figuring things out, I think monthly would make sense. I've
updated the page to reflect this.

> I believe using the "magic url" to make pull requests for the each language
> would work, but maybe there is an easier way to do them all at once? And
> it's currently missing 21.05 in the pull down.

The "magic URL" seems to only be for Koha itself, so I've used the other page -
pull requests for 20.05 and 20.11 made. I will ask Bernardo about updating it
so 21.05 is available that way.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355

Cheryl  changed:

   What|Removed |Added

 CC||clack...@fargolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571

--- Comment #7 from Jonathan Druart  ---
Hi Andreas, attach a patch here and switch the status back to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #22 from Martin Renvoize  ---
This all appears to make sense and passes the QA scripts.. I believe it
resolves the regression and doesn't cause any new ones.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128372|0   |1
is obsolete||

--- Comment #21 from Martin Renvoize  ---
Created attachment 128407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128407=edit
Bug 29349: (follow-up) Fix width of item level dropdowns

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128370|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 128406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128406=edit
Bug 29349: Do not assume holding branch is a valid pickup location

The original code for pickup locations when placing item-level holds
picked the currently logged-in library.

We made things more robust, as the logged-in library might not be a
valid pickup location for the patron and item. But it was wrongly chosen
to use the holding branch as the default.

A more robust approach is needed, and this precedence is picked this
time (it could be configuration-driven in the future):

- Logged-in library
- Empty

To test:
1. Pick a biblio with various valid pickup locations, some not including
   the logged-in library.
2. Pick a patron for placing the hold
=> FAIL: Notice that (when valid pickup location) the holding branch is
always chosen
3. Apply this patch
4. Repeat 2
=> SUCCESS: If valid pickup location, the logged-in branch is picked as
default for item-type level. When it is not, an empty dropdown is used
as a fallback.
5. Sign off :-D

Signed-off-by: Lucas Gass 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

--- Comment #26 from Martin Renvoize  ---
Retested, back to PQA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128381|0   |1
is obsolete||

--- Comment #25 from Martin Renvoize  ---
Created attachment 128405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128405=edit
Bug 28377: (QA follow-up) Fallback error handling

The code only dealt with 404, this patch makes it have a fallback
message for failure codes.

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128380|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 128404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128404=edit
Bug 28377: (28937 follow-up) Flatpickr change

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127271|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 128403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128403=edit
Bug 28377: (follow-up) Remove svc/hold/{resume|suspend}

This files are no longer used and thus removed. Their functionality is
already present on the API

POST   /holds/:hold_id/suspension
DELETE /holds/:hold_id/suspension

To test:
1. Apply this patch
2. Run:
   $ git grep 'hold/suspend'
   $ git grep 'hold/resume'
=> SUCCESS: No references to the scripts
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28377] Use the API to suspend/resume holds

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127270|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 128402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128402=edit
Bug 28377: Use the API to suspend/resume holds

This patch makes the patron page (detail and circulation) use the API to
suspend/resume holds on the holds tab.

It previously used the old svc/ scripts we plan to replace.

To test
1. Have a patron with some holds
2. Play with suspending/resuming holds. Include the indefinite
   suspension.
=> SUCCESS: Everything works as usual
3. Apply this patch
4. Repeat 2
=> SUCCESS: Nothing changed, a soft breeze surprises you
5. Sign off :-D

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

Thibaud Guillot  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #16 from Thibaud Guillot  ---
Sorry for the message at the bottom of the test plan, I miss my last
attachement with git bz :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

Thibaud Guillot  changed:

   What|Removed |Added

 CC||thibaud.guil...@biblibre.co
   ||m
   Assignee|arthur.suz...@biblibre.com  |thibaud.guil...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074

Thibaud Guillot  changed:

   What|Removed |Added

 CC||thibaud.guil...@biblibre.co
   ||m

--- Comment #19 from Thibaud Guillot  ---
Sorry for disturbing I miss my last bug attachement with git bz :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

--- Comment #15 from Thibaud Guillot  ---
Created attachment 128401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128401=edit
Add syspref to deal with overdues notification

I took the same test plan as victor but I added the system preference to manage
the case more easily, especially for users who do not have access to the koha
server.

Test plan
1. Check the size of the message queue
 With the following SQL query (using an SQL report if you want)
 SELECT COUNT(*) FROM message_queue;
2. Run misc/cronjobs/overdue_notices.pl
3. Check the size of the message queue
 To ensure that no other overdues will create noise in this test plan.
 Or you can take them into account.
4. Choose a patron with no email address
5. Create an overdue (checkout an item and unfold "Checkout settings"
   and set a date in the past which is compatible with what you find in
   staff:/cgi-bin/koha/tools/overduerules.pl
6. Run misc/cronjobs/overdue_notices.pl
7. Check that you have two new messages in the queue
8. Inspect these two messages
   SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G
   1. One has the type "print" and the borrowernumber matching the patron.
   2. The other has
subject: Overdue Notices
borrowernumber: NULL
message_transport_type: email
and contains "These messages were not sent directly to the patrons."
This is the one we don't want anymore.
Because it's now obsolete due to the first message.
9. Apply this patch
10. Change syspref 'EmailOverduesNoEmail' to "Don't send"
11. Delete data from message_queue (if you have access) for a cleaner view
12. Run again misc/cronjobs/overdue_notices.pl
13. Check that only the print message is now generated and not the
  "Overdue Notices" one.

https://bugs.koha-community.org/show_bug.cgi?id=20074

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074

--- Comment #18 from Thibaud Guillot  ---
Created attachment 128400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128400=edit
Add syspref to deal with overdues notification

I took the same test plan as victor but I added the system preference to manage
the case more easily, especially for users who do not have access to the koha
server.

Test plan
1. Check the size of the message queue
 With the following SQL query (using an SQL report if you want)
 SELECT COUNT(*) FROM message_queue;
2. Run misc/cronjobs/overdue_notices.pl
3. Check the size of the message queue
 To ensure that no other overdues will create noise in this test plan.
 Or you can take them into account.
4. Choose a patron with no email address
5. Create an overdue (checkout an item and unfold "Checkout settings"
   and set a date in the past which is compatible with what you find in
   staff:/cgi-bin/koha/tools/overduerules.pl
6. Run misc/cronjobs/overdue_notices.pl
7. Check that you have two new messages in the queue
8. Inspect these two messages
   SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G
   1. One has the type "print" and the borrowernumber matching the patron.
   2. The other has
subject: Overdue Notices
borrowernumber: NULL
message_transport_type: email
and contains "These messages were not sent directly to the patrons."
This is the one we don't want anymore.
Because it's now obsolete due to the first message.
9. Apply this patch
10. Change syspref 'EmailOverduesNoEmail' to "Don't send"
11. Delete data from message_queue (if you have access) for a cleaner view
12. Run again misc/cronjobs/overdue_notices.pl
13. Check that only the print message is now generated and not the
  "Overdue Notices" one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

--- Comment #10 from Tomás Cohen Arazi  ---
(In reply to Lucas Gass from comment #9)
> Tests pass and sorting works so I signed off. Making the Summary/title
> sortable again will happen in Bug 29570?

Yes, that's much more complex to solve.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571

Andreas Roussos  changed:

   What|Removed |Added

 CC||a.rous...@dataly.gr

--- Comment #6 from Andreas Roussos  ---
(In reply to Christophe TORIN from comment #0)
> On the mainpage, the "Suggestions pending approval" block is shown only if
> there are suggestions for the user's current library, even if the other
> library have suggestions.
The suggestions pending approval are also meant to be displayed in the
right hand side of Home > Acquisitions. The change Jonathan suggested
can be applied to koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
as well.

Would it be OK if I submitted a follow-up patch for this here, and also
change the Bug title accordingly (remove "Mainpage : ")?

Or is it best practice to submit a new bug report?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29631] 21.06.000.12 may fail

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_21_11_candidate
   Severity|critical|blocker
 CC||k...@bywatersolutions.com

--- Comment #9 from Jonathan Druart  ---
Upping severity, this is blocker for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571

Andreas Roussos  changed:

   What|Removed |Added

 Attachment #128271|0   |1
is obsolete||

--- Comment #5 from Andreas Roussos  ---
Created attachment 128399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128399=edit
Bug 29571: Display all pending suggestions even if none from logged in library

The number of pending suggestions was only displayed if there are pending
suggestions at the logged in library.

Test plan:
Login at CPL
Create a suggestion (ASKED) for another library
=> Without this patch there is nothing on the mainpage
=> With this patch applied you will see info about pending suggestions:

"Suggestions pending approval: Centerville: 0 / All libraries: 1"

Signed-off-by: David Nind 
Signed-off-by: ThibaudGLT 
Signed-off-by: Andreas Roussos 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571

Andreas Roussos  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

Andreas Roussos  changed:

   What|Removed |Added

 CC||a.rous...@dataly.gr

--- Comment #10 from Andreas Roussos  ---
(In reply to Lucas Gass from comment #8)
> (In reply to Katrin Fischer from comment #6)
> > Hi Lucas, can you please check if this is a duplicate to bug 29571?
> 
> Katrin, looks like a duplicate to me. I will close this one but I am curious
> if Bug 29571 needs Andreas's follow-up. I am unable to reproduce the edge
> case.
Hi Lucas -- by all means, please feel free to close this bug ;-)

Jonathan's fix in Bug 29571 is much shorter/cleaner than my follow-up
patch here, and also deals with the edge case I described.

FWIW, the edge case would manifest after applying the initial patch
submitted for this bug, since in the template file
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt

178 [% IF ( CAN_user_suggestions_suggestions_manage && pendingsuggestions )
%]

was changed to

178 [% IF ( CAN_user_suggestions_suggestions_manage &&
all_pendingsuggestions ) %]

In mainpage.pl, the template parameter `all_pendingsuggestions` would
be equal to 0 if the number of pending suggestions in the currently
selected branch is equal to the number of pending suggestions across
all branches (see line 90 below):

 86 my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED"
});
 87 my $local_pendingsuggestions_count = $pendingsuggestions->search({
'me.branchcode' => C4::Context->userenv()->{'branch'} })->count();
 88 my $pendingsuggestions_count = $pendingsuggestions->count();
 89 $template->param(
 90 all_pendingsuggestions => $pendingsuggestions_count !=
$local_pendingsuggestions_count ? $pendingsuggestions_count : 0,
 91 pendingsuggestions => $local_pendingsuggestions_count
 92 );

Thus, the condition inside the template [% IF %] block would be false
and the "Suggestions pending approval:" text would not appear at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

--- Comment #9 from Lucas Gass  ---
Tests pass and sorting works so I signed off. Making the Summary/title sortable
again will happen in Bug 29570?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Lucas Gass  changed:

   What|Removed |Added

 Attachment #128396|0   |1
is obsolete||

--- Comment #8 from Lucas Gass  ---
Created attachment 128398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128398=edit
Bug 29464: Make GET /acquisitions/orders honour sorting

When bug 20212 was pushed, we lost (didn't dig enough to find out how)
the sorting feature for this route.

This is mainly because biblio+biblioitems filtering prevents the route
to use plain $c->objects->search, so it has baked a custom version of
it. In this case, it missed the call to the dbic_merge_sorting helper,
that takes care of reading the query parameters and inject the sorting
attributes to the resultset.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t
=> FAIL: Tests fail, sorting doesn't actually work
3. Apply this patch
4. Repeat 2
=> SUCCESS: Sorting works!
5. Test sorting the pending orders on parcel.tt
6. Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Lucas Gass  changed:

   What|Removed |Added

 Attachment #128395|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 128397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128397=edit
Bug 29464: Regression tests

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

Katrin Fischer  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com,
   ||martin.renvoize@ptfs-europe
   ||.com

--- Comment #7 from Katrin Fischer  ---
Hi David, reading the wiki page:

String freeze

Currently we have no string freezes for the manual as it doesn't have a real
release date. The translation files on translate.kc.org used to be updated more
continuously I think - but I don't seen an update for your latest changes:

https://translate.koha-community.org/de/ (last update 7 months ago)

I think the current string freeze for Koha is already quite short, which makes
it hard to finish the Koha translations in that amount of time. Adding the
manual to it would be too much I think. I'd prefer having a monthly update of
po files at least or even better continously updates whenever a change is made.
Especially since we have been backporting fixes/corrections to older versions
of the manual.

I believe using the "magic url" to make pull requests for the each language
would work, but maybe there is an easier way to do them all at once? And it's
currently missing 21.05 in the pull down.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #6 from Katrin Fischer  ---
Hi David, not sure about the process, but you don't want to update the po files
locally (your last option). The translation work is already done on another
repo and "just" needs to be merged in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

--- Comment #6 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #0)
> This seems to be from bug 20212 - the sort options in the headers of the
> pending_orders table no longer function.

Done.

> Additionally, the 'Summary' column is now marked as 'orderable: false' - it
> was possible to sort on this column before those patches

Will handle this on bug 29570.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||29464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464
[Bug 29464] GET /acquisitions/orders doesn't honour sorting
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||29570


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570
[Bug 29570] unable to sort pending_orders table on parcel.pl by summary column
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
   ||, n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 128396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128396=edit
Bug 29464: Make GET /acquisitions/orders honour sorting

When bug 20212 was pushed, we lost (didn't dig enough to find out how)
the sorting feature for this route.

This is mainly because biblio+biblioitems filtering prevents the route
to use plain $c->objects->search, so it has baked a custom version of
it. In this case, it missed the call to the dbic_merge_sorting helper,
that takes care of reading the query parameters and inject the sorting
attributes to the resultset.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t
=> FAIL: Tests fail, sorting doesn't actually work
3. Apply this patch
4. Repeat 2
=> SUCCESS: Sorting works!
5. Test sorting the pending orders on parcel.tt
6. Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 128395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128395=edit
Bug 29464: Regression tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #5 from David Nind  ---
(In reply to David Nind from comment #4)

> 3. Tidy ups to .po files?

That should have said .pot files!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #4 from David Nind  ---
I'm still not 100% clear on  the process to update the translations for 20.05
and 20.11.

** Update the translations on koha-community.org/manuals **

1. Follow step 6 - pull request, merge into repository -> builds run and update
k-c.org

OR

2. Use secret URL to make the pull request?

** To get Pootle updated with changed strings  **

Contact Translation manager and ask for strings to be updated.

Or do I use the tools to update the .po files in the repository for the
versions:

1. Create a branch

2. Locally run: make gettext

3. Tidy ups to .po files?

4. Commit and push to branches on GitLab:  Translation update - manual -
2021-12-XX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Sorting broken for  |GET /acquisitions/orders
   |receiving in acquisitions   |doesn't honour sorting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29678] New: Can't use exteral URL for XSLT stylesheet

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678

Bug ID: 29678
   Summary: Can't use exteral URL for XSLT stylesheet
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

If I try to specify an external URL as an XSLT stylesheet it doesn't work. In
the error logs I see messages like this:

[2021/12/10 12:37:50] [WARN] XSLT::Base: Could not create file parser context
for file "https://path/to/MARC21slim2intranetResults.xsl": No such file or
directory at /kohadevbox/koha/Koha/XSLT/Base.pm line 330.

I have verified that the .xsl file is accessible and that internal links (to
MARC21slimUtils.xsl for instance) are valid too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620

--- Comment #10 from Kyle M Hall  ---
I anticipate we may need to backport patches related to these files in 21.11.x
branch. It makes sense to backport these changes for that reason.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|22.05.00|22.05.00,21.11.01
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|22.05.00|22.05.00,21.11.01
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #9 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647

--- Comment #3 from David Nind  ---
I've made my first attempt on documenting the steps - still needs some work:
https://wiki.koha-community.org/wiki/Documentation_management#Translating_the_manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464

--- Comment #3 from Tomás Cohen Arazi  ---
This was certainly working on bug 20212. Will try to check what else changed
after it was pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||k...@bywatersolutions.com
 Version(s)|22.05.00|22.05.00,21.11.01
released in||

--- Comment #7 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|22.05.00|22.05.00,21.11.01
released in||
 CC||k...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #8 from Kyle M Hall  ---
Pushed to 21.11.x for 21.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This patch restores the
  release notes||lost GIR segments in EDI
   ||messages generated by
   ||orders with items attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

Summary|Fix errors caused by bug|Restore functionality
   |27708   |broken by bug 27708 for
   ||AcqCreateItem set to
   ||"placing an order"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Martin Renvoize  ---
Tested on live environments that exhibited problems prior to the patch and
signed off.

The issue was that if your settings meant that items were created at order
time, but 27708 made it so that the GIR segments would not get sent to the
vendor.

The patch fixes that problem, but leaves in place the handling for when items
are not created at order time.  I also corrected the itemtype assignment key
for the case where items are not created as this was incorrect in bug 27708
too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29670] Fix errors caused by bug 27708

2021-12-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #128392|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 128394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128394=edit
Bug 29670: Fix EDI for AcqCreateItem = 'placing on order'

The AcqCreatItem at order time functionality was broken by bug 27708.
This patch resolves that.

Test plan.
1) Run the newly created unit tests that prove both settings work

Signed-off-by: Jonathan Field 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >