[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #4 from Martin Renvoize --- (In reply to Martin Renvoize from comment #3) > Could we not move the eval up a level into the record accessor itself this > catching all cases? OK, we already do and throw an exception.. hence your evals here.. my mistake -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Could we not move the eval up a level into the record accessor itself this catching all cases? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #64 from Fridolin Somers --- Please have a look at Bug 29690. We need to catch invalid metadata record so get_marc_authors() is concerned. I'd like QA to confirm this is the correct way to implement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27266 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29690 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #2 from Fridolin Somers --- If we are OK with this implementation, I will amend unit tests (any help is welcome) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #1 from Fridolin Somers --- Created attachment 128484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128484=edit Bug 29690: Add eval on metadata record fetch in details.pl when invalid MARCXML Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. Test plan : 1) Create a biblio record with invalid MARCXML (see Bug 29690) In koha-testing-docker there is biblionumber=369 2) Go to page cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx 3) You see the page with a message : There is an error with this bibliographic record, the view may be degraded. Error: Invalid data, cannot decode metadata object ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Fridolin Somers changed: What|Removed |Added Blocks||29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What|Removed |Added Depends on||23846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29690] New: Software error in details.pl when invalid MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Bug ID: 29690 Summary: Software error in details.pl when invalid MARCXML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28478] MARC detail and ISBD pages still show suppressed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #4 from Fridolin Somers --- Should we add to Koha::Biblio hidden_in_opac() ? Maybe with a param 'context' = 'search' or 'details' ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28478] MARC detail and ISBD pages still show suppressed records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #3 from Fridolin Somers --- (In reply to Katrin Fischer from comment #2) > (In reply to Fridolin Somers from comment #1) > > Arf indeed, code in only in opac-detail.pl : > > > > https://git.koha-community.org/Koha-community/Koha/src/commit/ > > 3ba74940ee730e92ad7061f27f18390cc6308364/opac/opac-detail.pl#L147 > > > > This needs to be in a module, and if possible with a Koha to MARC mapping > > instead of hardcoded 942$n. > > I think adding a Koha to MARC mapping could be a different bug, also to keep > this as easy as possible for backporting. > Sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #22 from Fridolin Somers --- (In reply to Katrin Fischer from comment #21) > I think we should move forward with it. +1 I'm sure we already have some code with this technique. I follow french translation group, sure they will like this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #41 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #40 from Fridolin Somers --- Useful to find who will have no Christmas gifts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Fridolin Somers changed: What|Removed |Added Keywords||release-notes-needed CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 --- Comment #13 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29631] 21.06.000.12 may fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #19 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29631] 21.06.000.12 may fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29683] Samba4 AD DC integration with koha ldap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29683 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi, at the moment this looks more like an installation/setup issue and as such is better suited for the mailing list where it will also be read by many more people Bugzilla should only be used for filing bugs, with details on how to reproduce the issue, and enhancement requests. You can also find some information on LDAP configuration in 20.11 in the manual: https://koha-community.org/manual/20.11/en/html/apis_protocols.html#ldap Could your user be the issue? cn=, dc=,dc= -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #13 from Katrin Fischer --- I think one problem is the lack of a test plan apart from running the tests, which limits the people who can test, and that there is no easy to understand description of the issue this is trying to fix. - This makes it harder to test, especially for our non-programmer testers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #12 from Katrin Fischer ---
Tbh this doesn't read like a trivial fix from the number of code changes. I
also think we shouldn't hardcode templates, as this breaks the templating
system:
if ( C4::Context->preference('TranslateNotices') ) {
my $translated_languages =
- C4::Languages::getTranslatedLanguages( 'opac',
-C4::Context->preference('template') );
+C4::Languages::getTranslatedLanguages( 'opac', 'bootstrap' );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- I am not sure if .json is parsed by the translation tools, but maybe introducing HTML tags would be worth trying? For the borrowers prefs we use the database column names, so translations weren't needed, but it would be nice if we could make it possible in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date and availability in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #8 from Fridolin Somers --- Ah OK thanks. get_enabled_plugins () is a private method ? maybe rename _get_enabled_plugins() Best regards, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #21 from Victor Grousset/tuxayo --- > I miss up my attachment and some obsolete tag to apply correctly my patch Don't worry, some tools take a bit long to get used to. And sometimes we just don't know an easier way. For the record, here is how I attach two 2 on a ticket. git-bz attach 20076 HEAD~2..HEAD If it's updating an existing patch. This will mark obsolete the old patches based on commit message matching. If the commit message changed, I manually mark the old patch via the UI. I don't know if git-bz is convenient for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #37 from Tomás Cohen Arazi --- (In reply to David Nind from comment #36) > Created attachment 128483 [details] > Bug 29605 - Error when accessing staff interface and OPAC - 2021-12-14 > > Still getting an error trace when accessing staff interface and OPAC after > flush_memcached and restart_all (see attached). > > Testing notes (koha-testing-docker): > > 1. apt-get install libcgi-session-serialize-yaml-perl (comment 16) > > 2. apt-get install libemail-valid-perl (comment 20) > > 3. Use updated test plan in comment 26: >. for perl cp_debian_files.pl... change to: > perl /kohadevbox/misc4dev/cp_debian_files.pl --koha_dir > /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev And a gentle koha-plack --restart kohadev? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #6 from Fridolin Somers --- Actually https://www.elastic.co/fr/support/eol says : 6.8.x EOL on 2022-02-08 If you are in 6 < 6.8, first upgrade to 6.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #5 from Fridolin Somers --- FYI here is the upgrade doc : https://www.elastic.co/guide/en/elasticsearch/reference/current/setup-upgrade.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #36 from David Nind --- Created attachment 128483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128483=edit Bug 29605 - Error when accessing staff interface and OPAC - 2021-12-14 Still getting an error trace when accessing staff interface and OPAC after flush_memcached and restart_all (see attached). Testing notes (koha-testing-docker): 1. apt-get install libcgi-session-serialize-yaml-perl (comment 16) 2. apt-get install libemail-valid-perl (comment 20) 3. Use updated test plan in comment 26: . for perl cp_debian_files.pl... change to: perl /kohadevbox/misc4dev/cp_debian_files.pl --koha_dir /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev 5. As per comment 27 check SQL for steps 4, 5 and 6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Katrin Fischer changed: What|Removed |Added Summary|suggest for purchase clears |Suggest for purchase clears |itemtype, quantity, library |item type, quantity, |and reason if bib exists|library and reason if bib ||exists -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29419] suggest for purchase clears itemtype, quantity, library and reason if bib exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Lucas Gass changed: What|Removed |Added Attachment #127684|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 128482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128482=edit Bug 29419: Retain user's inputs when suggesting for purchase and match found If a user suggests for purchase and a match is found, their inputs was not retained: quantity, item type, library, reason. Test plan: 1. Suggest for purchase 2. Fill the title in with a string that will match an existing record 3. Fill value in quantity, item type, library and reason input/dropdown 4. Submit => Notice that with this patch the values you entered are retained on the confirmation screen Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29419] suggest for purchase clears itemtype, quantity, library and reason if bib exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens changed: What|Removed |Added Attachment #128457|0 |1 is obsolete|| --- Comment #2 from Nick Clemens --- Created attachment 128481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128481=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Henry changed: What|Removed |Added Priority|P3 |P4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Henry changed: What|Removed |Added Priority|P5 - low|P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29689] New: Update to 21.11 broken auto-generated barcode in 0001 option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Bug ID: 29689 Summary: Update to 21.11 broken auto-generated barcode in 0001 option Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jmhenri...@yahoo.com.br QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 128480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128480=edit Error in Chrome console Hi! In version 21.05 the automatic barcode generator for manual addition of items worked. When upgrading to 21.11, it stopped working. The chrome debug shows the following message attached To reproduce the error, clicking on the item "p - barcode" generates the error on the console, and does not show any expected results. The autoBarcode option is set to "yymm0001" . Other autoBarcode options work except "aamm0001" . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What|Removed |Added Attachment #127953|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What|Removed |Added Attachment #127952|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29679] Reports result menu shows too many dividers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 David Nind changed: What|Removed |Added Attachment #128456|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 128479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128479=edit Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29679] Reports result menu shows too many dividers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What|Removed |Added Attachment #127953|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What|Removed |Added Attachment #127952|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #47 from Nick Clemens --- (In reply to Jonathan Druart from comment #45) > (In reply to Jonathan Druart from comment #42) > > For instance if we are facing perf issues with the fetch of the circ rules, > > we should then cache them. Other areas would benefit from that kind of > > change. Code will stay clean and we wouldn't need write acrobatic code in > > this C4::Circ module, it does not need that :) > > I've attached a patch on bug 29623, for discussion. I tested that similar to here, I did not se any significant performance change. I then tested here without the last two patches to see how much passing rules and dates save us. It turns out it make the routine take longer. I am not sure how/why, but it seems fetching the values was faster than passing them. I obsoleted the last two patches, as those are the ones you didn't like hopefully we can move this forward ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What|Removed |Added Attachment #127953|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens changed: What|Removed |Added Attachment #127952|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #13 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > 2. Wondering, should we > return $soonestrenewal if $now < $soonestrenewal; > ? I don't think so There are two cases: with undefined no renewal before: 1 - Automatic renewals wait until it is due 2 - Manual renewals are possible at any time Let me know if I missed something -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #12 from Nick Clemens --- Created attachment 128478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128478=edit Bug 29476: (follow-up) Fix return, add precision test Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Nick Clemens changed: What|Removed |Added Attachment #128096|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 128477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128477=edit Bug 29476: Correct soonest renewal date calculation for checkouts with auto-renewal If a checkout with auto-renewal enabled doesn't have a "norenewalbefore" circulation rule set the code in CanBookBeRenewed() falls back to using due date (to verify this please look for the string "auto_too_soon" in C4/Circulation.pm), the calculation result of GetSoonestRenewDate() however didn't do this, though luckily it was not used in CanBookBeRenewed so we didn't get any issues there. However, GetSoonestRenewDate() is used for displaying the soonest renewal date in the staff interface on the circ/renew.pl page so you would have gotten wrong results there. This patch moves additionally the tests made for Bug 14395 under a new subtest for GetSoonestRenewDate() as they should have been like that already before. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #34 from Katrin Fischer --- I just tested this feature on 20.11.12 and when adding a suggestion from the detail page the biblionumber is not filled in. I think this is a bug, can you confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #27 from Nick Clemens --- Created attachment 128476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128476=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. Signed-off-by: Samu Heiskanen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #26 from Nick Clemens --- Created attachment 128475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128475=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for form name I don't see nay reason we needed this Remove messagetransfert from template Never passed in code Remove totalcount variable Assigned and never referenced Remove 'alreadyres'/'alreadyreserved' from template All references in coide were in template - never set or passed Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Attachment #128421|0 |1 is obsolete|| Attachment #128422|0 |1 is obsolete|| Attachment #128423|0 |1 is obsolete|| --- Comment #25 from Nick Clemens --- Created attachment 128474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128474=edit Bug 29043: Don't load items unless a p[atron has been chosen on request.pl This patch moves the code that we sh9ould run if there is no patron to the head of the biblio loop. If we have no patron we execute this and go to the next loop. A few variables that were being passed to the template in the loop are moved outside - no reason to overwrite each loop To test: 1 - Browse to a bib in the staff client 2 - Click on the holds tab 3 - Note loading time 4 - Add 500 items to bib 5 - Note loading time - it takes longer 6 - Note items are not displayed 7 - Apply patch 8 - Reload page - is much faster 9 - Find/choose a patron 10 - Confirm items are loaded correctly Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #11 from Martin Renvoize --- Thanks Katrin, the yeah, EDI is notoriously difficult to test. I'm really pleased with the unit tests this patch adds personally, I feel like it's a real steel in the right direction for keeping EDI working in future versions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #21 from Katrin Fischer --- I think we should move forward with it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Florian changed: What|Removed |Added Attachment #128426|0 |1 is obsolete|| --- Comment #10 from Florian --- Created attachment 128473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128473=edit Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" Signed-off-by: Florian Bontemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Florian changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #20 from Jonathan Druart --- Do we move forward with this patch or abandon it? It's now or never. Or with bug 20988, maybe one day. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29631] 21.06.000.12 may fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #18 from Manos PETRIDIS --- As mine was one of the installations affected by this bug, I can verify that after running the following statements, web istaller completed successfully. DELETE a FROM language_subtag_registry AS a, language_subtag_registry AS b WHERE a.id < b.id AND a.subtag IS NOT NULL AND a.subtag=b.subtag AND a.type=b.type; DELETE a FROM language_descriptions AS a, language_descriptions AS b WHERE a.id < b.id AND a.subtag IS NOT NULL AND a.subtag=b.subtag AND a.lang IS NOT NULL AND a.lang=b.lang AND a.type=b.type; DELETE a FROM language_rfc4646_to_iso639 AS a, language_rfc4646_to_iso639 AS b WHERE a.id < b.id AND a.rfc4646_subtag IS NOT NULL AND a.rfc4646_subtag=b.rfc4646_subtag AND a.iso639_2_code=b.iso639_2_code; Thank you all for your help in resolving this issue. Manos Petridis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #23 from Jonathan Druart --- (In reply to Martin Renvoize from comment #20) > This all works as expected for me now, no regressions found. Thanks for > finding some time to fit this in David. :) > > I'd love to see a follow-up bug later to use the new function to replace the > various places we look for a psgi/plack app already.. but that can certainly > wait. > > Nice work, signing off. I cannot PQA without a follow-up bug report and patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #22 from Jonathan Druart --- *** Bug 27555 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27555] Use psgi_env from errors/* controller scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 29420 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #21 from Jonathan Druart --- This method exists, and is C4::Auth::psgi_env And this patch exists, on bug 27555. Why are we duplicating work? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com --- Comment #6 from Jonathan Druart --- Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens changed: What|Removed |Added Attachment #127520|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 128472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128472=edit Bug 29454: Use Koha Cache Memory Lite to stash itemtype descriptions for template plugin To test: 1 - Add 1000 items to a record, of varying item types 2 - Bring up the details page 3 - Note time to load 4 - Apply patch 5 - Reload page and compare to previous 6 - Confirm information is correct 7 - Confirm some performance benefit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #25 from Nick Clemens --- Created attachment 128471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128471=edit Bug 26587: Use Koha::Cache::Memory::Lite Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Nick Clemens changed: What|Removed |Added Attachment #127411|0 |1 is obsolete|| Attachment #128446|0 |1 is obsolete|| --- Comment #24 from Nick Clemens --- Created attachment 128470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128470=edit Bug 26587: Cache libraries in Koha/Template/Plugins/Branches.pm to improve performance This patch caches the Koha::Library object in a hashmap in the Branches object (GetName, GetURL) to avoid multiple database lookups while looping many items. To test: 1. Have a biblio with many items (1000's). 2. View in staff (detail.pl) and opac (opac-detail.pl). Note how long it takes to load. 3. Apply patch. 4. Repeat 2. Note that pages load faster. Sponsored-by: Lund University Library JK: replaced tab indendation with spaces Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart changed: What|Removed |Added Attachment #127776|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 128469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128469=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart changed: What|Removed |Added Attachment #127775|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 128468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128468=edit Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29491] Improve display of notices in patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289
Jonathan Druart changed:
What|Removed |Added
Attachment #127494|0 |1
is obsolete||
--- Comment #5 from Jonathan Druart ---
Created attachment 128467
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128467=edit
Bug 29289: 'Show fines to guarantor' should have its own id on patron detail
page
This patch adds an id attribute to the list item containing the "Show
fines to guarantor" information on the patron detail page in the staff
interface. This makes it consistent with the markup for the similar
"Show checkouts to guarantor" list item.
To test, apply the patch and view a patron's details in the staff
client. Inspect the source to confirm that the "Show fines to guarantor"
line has an id, "patron-privacy_guarantor_fines".
Alternatively, add this to the IntranetUserCSS system preference:
#patron-privacy_guarantor_fines { background-color: pink; }
The line on the patron details page should be highlighted in pink.
Signed-off-by: Barbara Johnson
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #4 from Jonathan Druart --- That's inconsistent... Not blocker however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #11 from Jonathan Druart --- Owen, it seems that you needs to adjust the two occurrences at the OPAC as well: opac/opac-authorities-home.pl:pagination_bar => pagination_bar( opac/opac-shelves.pl:pagination_bar => pagination_bar( opac/opac-shelves.pl:pagination_bar => pagination_bar( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 --- Comment #1 from Owen Leonard --- Created attachment 128466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128466=edit Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #12 from Jonathan Druart --- We are loosing the ability to translate syspref's values, is that expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #10 from Jonathan Druart --- Created attachment 128465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128465=edit Bug 28855: (follow-up) adapt specific test Adapt the test of function DelSuggestionsOlderThan to match the new behaviour of the function. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855
Jonathan Druart changed:
What|Removed |Added
Attachment #128411|0 |1
is obsolete||
Attachment #128412|0 |1
is obsolete||
--- Comment #9 from Jonathan Druart ---
Created attachment 128464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128464=edit
Bug 28855: Purging suggestions test should not be on timestamp
DelSuggestionsOlderThan is on "date", a timestamp. It can be a problem
because "date" is updated when we update the database, in consequences
all the suggestions take the same date.
This patch use 'manageddate' instead.
In order to test this patch, you will need to have some suggestions
where "Managed on" (suggestions.manageddate in the database) is older
from "Last updated" (suggestions.date in the database). This can append
during some specific update. If you don't have such data, you will have
to add them via SQL request.
Example of sql for insertion (ID is the patron id of a librarian which
can manage suggestions):
INSERT INTO suggestions (suggestedby, suggesteddate, managedby,
manageddate, acceptedby, accepteddate, STATUS, title) VALUES (1,
'2020-10-13', 1, '2020-10-26', 1, '2020-10-26', 'ACCEPTED', 'title');
Test plan:
1- Choose a date and find (or add) a suggestion where:
- "Last updated" is not older than this date
- "Managed on" is older than this date
- "Status" is different from "Pending" ("ASKED" in database)
Calculate number_days = today's date - chosen date
Example: (Today's date 28/10/2021, chosen date : 28/10/2020,
number_days=365)
Suggestion | .. | Managed on | .. | Last updated | .. | Status
title | .. | 10/26/2020 | .. | 05/15/2021 | .. | Accepted
2- Run cron job
/home/koha/src/misc/cronjobs/purge_suggestions.pl --confirm --days number_days
3- Check that this suggestion has not been deleted
4- Apply the patch
5- Repeat steps 1 and 2
6- Check that this suggestion has been deleted
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #8 from Andrew Fuerste-Henry --- Makes sense to me! Thanks, all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #11 from Marcel de Rooy --- Trivial small fix, waiting for 2 months ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
