[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #811 from Fridolin Somers --- Sure, I'm in. At first look code looks pretty mature. I'll listen to QA team. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #37 from Fridolin Somers --- (In reply to Thibaud Guillot from comment #35) > Thanks for the review Fridolin Your welcome ;) Please add a nice text in "Text to go in the release notes" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #8 from Fridolin Somers --- Created attachment 129519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129519&action=edit Bug 29066: (follow-up) add aria-label -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Fridolin Somers changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #7 from Fridolin Somers --- (In reply to Lucas Gass from comment #6) > I see the button does include a title attribute of 'Search' which is good > but does that cover all accessibility cases? Should this not also include an > aria-label for screen readers and mobile devices? Ah sure. I didn't knew about this. I see we use a lot aria-label="Breadcrumb" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #8 from Fridolin Somers --- Hi, This is a very strange feature in UNIMARC XSLT that aim to look for several $9 in authority fields. We should remove it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #462 from Fridolin Somers --- What a complex situation. This also linked to Bug 15516 - Allow to place a hold on first available item from a group of titles And maybe a bit to Bug 15565 - Place multiple item-level holds at once for the same record Holds system is already really complex, we must be careful what we add in it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #413 from Fridolin Somers --- Arf, this is somehow linked to other feature in development : Bug 24857 - Add ability to group items for records Bug 24023 - Add ability to create bundles of items Bug 28854 - [ALTERNATIVE] Add ability to create bundles of items We should think on how not put too much complexity in the system (already really complex). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869
--- Comment #27 from Jonathan Druart ---
> C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber });
Calling a C4 method from Koha is bad. Calling a private method from outside the
module is very bad. Calling a private C4 method from Koha is very very bad...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24857] Add ability to group items for records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #30 from Fridolin Somers --- Does not apply. Is first patch obsolete ? Applying only patch with "Bug 20390: ..." does not work eather. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #6 from Eugene Espinoza --- Before signing this one off, just want to post my observation. Regarding "There should be an expanded tree menu at the top of the authority" means I am in the details page of the authority record. Because after searching for an authority record, I am presented with search results and when I go to the details page (/cgi-bin/koha/opac-authoritiesdetail.pl), that's the time I see a tree-like structure in the authorities. When I inspect the element for it, I see class "jstree-icon jstree-ocl" screenshot here: https://issuances-library.senate.gov.ph/sites/default/files/2022-01/jstree_screenshot.png. I can confirm that this is also present in MARC view as well as in the Administration panel. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #3 from Mason James --- (In reply to Tomás Cohen Arazi from comment #2) > What is it used for? Test::DBIx::Class? i think its only used for the ./misc/cronjobs/create_koc_db.pl file, see BZ-4269 create_koc_db.pl can use both sqlite2 and sqlite3, so no upgrade problem to deb12 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #2 from Tomás Cohen Arazi --- What is it used for? Test::DBIx::Class? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #2 from Lucas Gass --- Created attachment 129518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129518&action=edit Bug 29887: database update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #1 from Lucas Gass --- Created attachment 129517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129517&action=edit Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Caroline Cyr La Rose changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca --- Comment #8 from Caroline Cyr La Rose --- *** Bug 19342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19342] Show private list on detail page in OPAC when user is logged in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19342 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #2 from Caroline Cyr La Rose --- *** This bug has been marked as a duplicate of bug 29621 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 --- Comment #5 from Nick Clemens --- Created attachment 129516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129516&action=edit Bug 29719: Do not clear onloan value when not passed in MARC We blank the field to prevent users from setting it during import, but this has the affect of blanking it in the DB. This patch replaces the onloan field when not passed in to 'ModItemFromMARC' to preserve the value To test: 1 - Check an item out to a paron 2 - Export the item using Tools->Export data 3 - Stage the record for import 4 - Match on 999c and replace items 5 - Import the batch 6 - View the record and note item is checked out and Available 7 - In the DB note the onloan value is now null 8 - Check in the item 9 - Apply patch 10 - Repeat 1-5 11 - View the record and note item is checked out 12 - In the DB note the onloan value matches the due date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Nick Clemens changed: What|Removed |Added Attachment #128635|0 |1 is obsolete|| Attachment #128636|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 129515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129515&action=edit Bug 29719: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 --- Comment #1 from Owen Leonard --- Created attachment 129514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129514&action=edit Bug 29889: Incorrect library check in patron message deletion logic This patch corrects the logic controlling whether a patron message on the circulation or patron details page has a "Delete" link. An error in the logic prevented messages from being removed by staff who should have been authorized to do so. To reproduce the bug, check that your AllowAllMessageDeletion preference is disabled. - In the staff client, check out to a patron whose home library doesn't match the library you're logged in at. - Add a message to the patron's account. - You should see no "Delete" link next to the newly-added message. - If you edit the patron so that their home library matches the library you're logged in at the delete link will appear. To test, apply the patch and follow the steps above. The delete link should aways appear if the message was left by someone logged in at the same library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Owen Leonard changed: What|Removed |Added Blocks||29889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 [Bug 29889] Incorrect library check in patron message deletion logic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29889] New: Incorrect library check in patron message deletion logic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Bug ID: 29889 Summary: Incorrect library check in patron message deletion logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 21757 If you DON'T have AllowAllMessageDeletion enabled, message deletion is supposed to be limited by library: Staff from the same library can delete each other's messages, but not messages left by other libraries. At some point the logic around the display of the "Delete" link got changed, I think by Bug 21757. Now the check compares the branchcode of the staff member who left the message with the branchcode of the patron: patron_message.branchcode == patron.branchcode I think this is meant to compare patron_message.branchcode to the logged-in library. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 [Bug 21757] Patron detail script (moremember.pl) cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #30 from Tomás Cohen Arazi --- Nick, I stripped the Koha::Suggestions->search_limited and moved to 29886. I found issues when writing unit tests for it, and they might be responsible for the problems you found. I have attached a new patchset, which is the same as before, without that. But given the fact I fixed some issues on how ->search_limited worked, it might be good if you could re-test. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 129513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129513&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-related pages rely on array size instead of querying the DB each time they need to. In the case of suggestion/suggestion.pl it goes from 4 COUNT(*) to 1. To test, with KTD: 1. Run on the host machine: $ docker exec -ti koha_db_1 bash $ mysql -ppassword > SET GLOBAL general_log_file='/var/log/mysql/mycustom.log'; > SET GLOBAL log_output = 'FILE'; > SET GLOBAL general_log = 'ON'; > \q $ tail -f /var/log/mysql/mycustom.log | grep suggestions 2. Visit the different pages changed on this bug => SUCCESS: Some queries 3. Apply this patch 4. Repeat 2 => SUCCESS: Less queries! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 129512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129512&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 129511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129511&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128071|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128075|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128074|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128073|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128072|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Michael Hafen changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Michael Hafen changed: What|Removed |Added Attachment #128684|0 |1 is obsolete|| --- Comment #16 from Michael Hafen --- Created attachment 129510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129510&action=edit Bug 28977: Add GROUP_CONCAT to some of the selected columns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #15 from Michael Hafen --- Looking at things again, only the title, rank, id and $colfield columns reach the template. All the other columns in the SELECT clause (all the GROUP_CONCATs except $colfield) could probably be dropped. Also, the $colfield column should probably be pulled out of the GROUP_CONCAT since it's also added to the GROUP BY clause. Also, grouping by biblionumber is required, because the report contains a link to the biblio record. Coming back to the question about DISTINCT. I had to look up how it works; it seems I didn't understand it completely. It works like the GROUP BY clause for all the columns in the SELECT clause. Given that it should probably be dropped for the sake of performance. I tried running the query again, with and without the DISTINCT, and there was no difference in the number or rows returned. I don't know what I was doing before, but I think the previous runs were flawed; this result makes more sense. This amounts to a big change in the patch, and the status should probably be moved back to Needs Signoff if the patch is updated. Which I think it should be at this point; I really didn't understand this report completely when I started this. So I'm going to go and work up another patch now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29888 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29888] ->search_limited logic breaks searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29888 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29886 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29888] New: ->search_limited logic breaks searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29888
Bug ID: 29888
Summary: ->search_limited logic breaks searches
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
When writing unit tests for bug 29886, in which I was moving bug 23991 addtion
of Koha::Suggestions->search_limited I noticed a problem with how the query is
amended to deal with limitations: instead of relying on chained searches, it
tries (badly) to tweak the passed parameters.
This line was disturbing to me:
$params->{branchcode} = { -or => [ $userenv->{branch}, '' ] };
it means any query on branchcode will be overwritten! (another bug could be
filed to discuss that '' in there).
I propose to revisit the current ->search_limited implementations, and fix
them:
$ git grep 'sub search_limited'
Koha/ArticleRequests.pm:sub search_limited {
Koha/Patron/Discharge.pm:sub search_limited {
Koha/Patrons.pm:sub search_limited {
Koha/Reviews.pm:sub search_limited {
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||jonathan.druart+koha@gmail. ||com, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com Assignee|jonathan.druart+koha@gmail. |tomasco...@gmail.com |com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129509&action=edit Bug 29886: Add Koha::Suggestions->search_limited Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129508&action=edit Bug 29886: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #26 from Kyle M Hall --- Created attachment 129507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129507&action=edit Bug 29869: (QA follow-up) import t::lib::Mocks for Hold.t for mock_preference Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #25 from Kyle M Hall --- Created attachment 129506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129506&action=edit Bug 29869: Teach log viewer about FILL Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #24 from Kyle M Hall --- Created attachment 129505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129505&action=edit Bug 29869: Remove C4::Reserves::ModReserveFill Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #23 from Kyle M Hall --- Created attachment 129504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129504&action=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #22 from Kyle M Hall --- Created attachment 129503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129503&action=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What|Removed |Added Attachment #129417|0 |1 is obsolete|| Attachment #129418|0 |1 is obsolete|| Attachment #129419|0 |1 is obsolete|| Attachment #129420|0 |1 is obsolete|| Attachment #129421|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 129502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129502&action=edit Bug 29869: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #16 from Andrew Fuerste-Henry --- Accidentally put a signoff for another bug here. I've now *actually* signed off here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129501|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129500|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129499|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129454|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] New: Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Bug ID: 29887 Summary: Create system preference IndependentBranchesLoggedInLibrary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently if IndependentBranches is turned on it makes it so staff cannot switch branches or 'Set library' unless they are a superlibrarian. Some libraries like this aspect of IndependentBranches but don't want everything else that comes with turning on IndependentBranches. A new system pref 'IndependentBranchesLoggedInLibrary' would allow libraries to utilize this aspect of IndependentBranches without having to turn on everything else that comes with that system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Attachment #129453|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #127885|0 |1 is obsolete|| --- Comment #15 from Andrew Fuerste-Henry --- Created attachment 129501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129501&action=edit Bug 29483: Further improve performance of script This patch adds a few tests to cover more cases, and to highlight current functionality. The script only allows renewal if all outstanding holds can be filled by available items. This means we can return as soon as we have determined that not all holds can be filled. I add FIXME and some explanatory comments - I will file a follow-up bug for those, but I feel we can accept these improvements to the performance and deal with the issues of how it 'should' work versus how it does work on another report. To test: 1 - prove -v t/db_dependent/Circulation.t Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #127884|0 |1 is obsolete|| --- Comment #14 from Andrew Fuerste-Henry --- Created attachment 129500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129500&action=edit Bug 29483: Check ItemsAnyAvailableAndNotRestricted once per patron ItemsAnyAvailableAndNotRestricted can take a long time and create nested loops. We can check it once per patron, however, this requires us to flip the loops. Since an item can only be used once, we now add a check to see if this item has already been assigned to a borrower. To test: 1 - Find or create a biblio with 100 items 2 - Place ten 'Next available' holds on a biblio 3 - Set preference 'AllowRenewalIfOtherItemsAvailable' to 'Allow' Set circ rules 'On shelf holds allowed' to 'If any unavailable' 4 - Checkout one of the items to a patron, backdated to be overdue 5 - Note a long loading time for the patron's checkouts 6 - Apply patch, restart_all 7 - Patron loads much faster Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #127883|0 |1 is obsolete|| --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 129499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129499&action=edit Bug 29483: Unit tests This patch updates the AllowRenewalIfOtherItemsAvailable tests to remove deletion of all data, and create specific circ rules for this test. It adjust several other tests that were relying on the rules from this test, so thy too create their opwn specific rules. Additionally, we add tests to cover the case of mutliple items on the record, and some items cannot fill some reserves. What is uncovered here is that the same patron is checked twice, so two holds can be filled, but they only satisfy a single patron Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #38 from Jonathan Druart --- Rebased and fixed a bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043
--- Comment #37 from Jonathan Druart ---
@ reserve/request.pl:199 @ $template->param(
multi_hold => $multi_hold,
);
+# If we are coming from the search result and only 1 is selected
+$biblionumber ||= $biblionumbers[0] unless $multi_hold;
# If we have the borrowernumber because we've performed an action, then we
# don't want to try to place another reserve.
if ($borrowernumber_hold && !$action) {
@ reserve/request.pl:297 @ $template->param(
messageclub => $messageclub
);
+# Load the hold list if
+# - we are searching for a patron or club and found one
+# - we are not searching for anything
+if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold )
+|| ( !$findborrower && !$findclub ) )
+{
# FIXME launch another time GetMember perhaps until (Joubu: Why?)
my $patron = Koha::Patrons->find( $borrowernumber_hold );
@ reserve/request.pl:771 @ foreach my $biblionumber (@biblionumbers) {
$template->param( biblioloop => \@biblioloop );
$template->param( no_reserves_allowed => $no_reserves_allowed );
-$template->param( biblionumbers => join('/', @biblionumbers) );
$template->param( exceeded_maxreserves => $exceeded_maxreserves );
$template->param( exceeded_holds_per_record => $exceeded_holds_per_record
);
$template->param( subscriptionsnumber =>
CountSubscriptionFromBiblionumber($biblionumber));
+} elsif ( ! $multi_hold ) {
+my $biblio = Koha::Biblios->find( $biblionumber );
+$template->param( biblio => $biblio );
+}
+if ( $multi_hold ) {
+$template->param( biblionumbers => join('/', @biblionumbers) );
+} else {
+$template->param( biblionumber => $biblionumber || $biblionumbers[0] );
+}
# pass the userenv branch if no pickup location selected
$template->param( pickup => $pickup || C4::Context->userenv->{branch} );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Attachment #128971|0 |1 is obsolete|| Attachment #128972|0 |1 is obsolete|| Attachment #128973|0 |1 is obsolete|| Attachment #129200|0 |1 is obsolete|| --- Comment #36 from Jonathan Druart --- Created attachment 129498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129498&action=edit Bug 29043: Don't fetch biblios info unless a patron is picked If we haven't picked a patron or a club yet we don't need to fetch biblios, items and holdability infos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 --- Comment #1 from Owen Leonard --- Created attachment 129497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129497&action=edit Bug 17018: Split AdvancedSearchTypes for staff and OPAC This patch adds a new system preference, OpacAdvancedSearchTypes, as an OPAC-specific version of the AdvancedSearchTypes preference. Values from AdvancedSearchTypes are copied to OpacAdvancedSearchTypes so that behavior is consistent. To test, apply the patch and run the database update process. - Go to Administration -> System preferences. - Search for AdvancedSearchTypes. You should get two results, one for the OPAC preference and one for the staff interface. - Check that the OpacAdvancedSearchTypes settings match the AdvancedSearchTypes settings. - View the advanced search pages in the staff interface and OPAC to confirm that the tabs look correct. - Change the OpacAdvancedSearchTypes and AdvancedSearchTypes settings to be different and confirm that each is applied separately to each interface. - Enable the OpacTopissue system preference. - View the "Most popular" page in the OPAC. - The OpacAdvancedSearchTypes settings should be reflected in the "Refine your search" sidebar: If "Collection" is checked, a filter for collection should appear. If "Item types" is checked, a filter for item types should appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard changed: What|Removed |Added Blocks||17018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 [Bug 17018] Split AdvancedSearchTypes for staff and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Owen Leonard changed: What|Removed |Added Depends on||29878 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5697] Automatic linking in guided reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Nick Clemens changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #33 from Nick Clemens --- *** Bug 22535 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22535] Use Link Shortcuts when creating reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22535 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE CC||n...@bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 5697 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #78 from Andrew Fuerste-Henry --- Initial notes (more to follow): - Items WERE NOT created when receiving orders in a basket set to Create Items On Receiving for orders created either on an existing bib or a new bib (not tied to a subscription or purchase suggestion). - For orders tied to a purchase suggestion, the purchase suggestion link displays as "(suggestion #undefined)" and the link doesn't work (points to /cgi-bin/koha/suggestion/suggestion.pl?suggestionid=undefined&op=show) - on /acqui/orderreceive.pl?multiple_orders, the list of all selected order numbers is ugly. it shows like "[Vendor] [basket] (order #27667,27673)." With a lot of orders, it's not nice to look at. Do we need to list them all? Could we at least add spaces so it breaks across lines? - when increasing the quantity received for an order from a basket set to create items when cataloging, we got this warning: "Order 27690: Warning, you have entered more items than expected. Items will not be created." This is technically true, but seems unneeded. We didn't ever expect this order to make items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Blocks||23991 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 [Bug 29886] Add Koha::Suggestions->search_limited -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29886] New: Add Koha::Suggestions->search_limited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Bug ID: 29886 Summary: Add Koha::Suggestions->search_limited Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org SearchSuggestion does filtering on IndependentBranches, etc. We need to implement Koha::Suggestions->search_limited that does that as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29885] Add the option to customise Z39.50 searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885 Jake Deery changed: What|Removed |Added CC||jake.de...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29885] New: Add the option to customise Z39.50 searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885 Bug ID: 29885 Summary: Add the option to customise Z39.50 searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: jake.de...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Hi, Foremost, this is my first bug report. If the community has preferences on how this system is best used, please do let me know, and I'll be happy to learn! One of our customers recently asked me to file this bug report. Their exact comments were: "Also, I wondered if it would be worth to put this on the bugzilla as a desired implementation in one of the coming Koha versions, to add Title series and Publisher. I can imagine other libraries also finding this useful. And to have the option to 'hide' fields from the Z39.50/SRU search form that are not relevant to a certain library (maybe in the same way you can now hide certain columns from showing in e.g. the item record)." I think it would be a great Koha enhancement to be able to pick which attributes are used in Z39.50 / SRU searches, hide/remove unnecessary values, and even add custom search attributes as required. If anyone has anything to add/suggest, please be my guest, and take the floor! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #26 from Nick Clemens --- bug 23991 - I ran the script to generate random suggesstions - I can see them - apply patch, I don't see them If I load from library link on homepage, I see them but if i change library using pulldown I can't the 'all libraries' link form homepage does not work either http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL&displayb[…]eptedby=&accepteddate_from=&accepteddate_to=&budgetid=__ANY__ that shows nothing http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL That shows things Logs show this often: [2022/01/14 15:21:34] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 113. [2022/01/14 15:21:34] [WARN] Use of uninitialized value $v in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 115. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Jonathan Druart changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Nick Clemens changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #66 from Nick Clemens --- *** Bug 22157 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22157] HideLostItems items still show in OPAC when patron places a hold on a specific item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22157 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE CC||n...@bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Nick Clemens --- Fixed by bug 24254 *** This bug has been marked as a duplicate of bug 24254 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129479|0 |1 is obsolete|| --- Comment #29 from Andrew Fuerste-Henry --- Created attachment 129496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129496&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129478|0 |1 is obsolete|| --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 129495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129495&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129477|0 |1 is obsolete|| --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 129494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129494&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129476|0 |1 is obsolete|| --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 129493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129493&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129475|0 |1 is obsolete|| --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 129492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129492&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Kyle M Hall changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11.02 released in|| Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Version(s)|22.05.00|22.05.00,21.11.02 released in|| Status|Pushed to master|Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29813] skeleton.pl missing semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.05.00|22.05.00,21.11.02 released in|| --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29813] skeleton.pl missing semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29813] skeleton.pl missing semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29813] skeleton.pl missing semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
