[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #91 from Marcel de Rooy --- While working on follow-up reports, I still find an issue. Sorry :) The following scheme shows a different response with this patch set and without: [1] Login with a good or bad userid and wrong password (staff). You should get the error Invalid username or password. [2] On this form with the error, login again with the same wrong credentials. You do not get the previous error. Which you should have got! But you will crash on line 87 of mainpage. Can't use an undefined value as a HASH reference at /usr/share/koha/mainpage.pl line 87 Changing status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29911] New: Default amounts for fee types display with comma in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29911 Bug ID: 29911 Summary: Default amounts for fee types display with comma in some cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When CurrencyFormat is set to "FR" and you are manually adding a copier fee or similar to a patron account, the amount will show up with a decimal comma instead of a decimal dot, which won't work correctly. This is because we are missing the on_editing => 1 filter here: maninvoice.tt
[Koha-bugs] [Bug 29912] New: Technomiz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29912 Bug ID: 29912 Summary: Technomiz Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: technomiz@gmail.com QA Contact: testo...@bugs.koha-community.org Technomiz is an online news portal that provides latest news on the categories, such as sports, tech, health, entertainment, business and miscellaneous. http://www.technomiz.com/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29911] Default amounts for fee types display with comma in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29911 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 241] Extra td in html creates an extra little rectangle.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=241 how much does volaris charge for extra baggage changed: What|Removed |Added CC||airfleetratin...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29913] New: how much does volaris charge for extra baggage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29913 Bug ID: 29913 Summary: how much does volaris charge for extra baggage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: airfleetratin...@gmail.com QA Contact: testo...@bugs.koha-community.org Traveling with Volaris Airlines, passengers must bring the luggage as per size limitation. They may bring maximum size of bags up to 62 inches as their maximum dimensions. The Volaris carry-on size limitation is 41.2 inches or 104.6 centimeters. For individual dimensions, the size of luggage 22.4″ x 15.7″ x 12.9″/56 x 39 x 32 cm, approximately. On Volaris Airlines, when oversized limitation of luggage size should be 62 linear inches. Any extra luggage cannot be considered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29913] how much does volaris charge for extra baggage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29913 how much does volaris charge for extra baggage changed: What|Removed |Added URL||https://www.airfleetrating. ||com/baggage/volaris-airline ||s-baggage-policy/ --- Comment #1 from how much does volaris charge for extra baggage --- Traveling with Volaris Airlines, passengers must bring the luggage as per size limitation. They may bring maximum size of bags up to 62 inches as their maximum dimensions. The Volaris carry-on size limitation is 41.2 inches or 104.6 centimeters. For individual dimensions, the size of luggage 22.4″ x 15.7″ x 12.9″/56 x 39 x 32 cm, approximately. On Volaris Airlines, when oversized limitation of luggage size should be 62 linear inches. Any extra luggage cannot be considered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29914] New: check_cookie_auth not strict enough
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 Bug ID: 29914 Summary: check_cookie_auth not strict enough Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Authentication Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org This has been found on bug 28786 comment 91. check_cookie_auth is assuming that the user is authenticated if a cookie exists and that the login/username exists in the DB. This is very bad! I have no idea what are the possible breaches it opens, but there are certainly some. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29914] check_cookie_auth not strict enough
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29914] check_cookie_auth not strict enough
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 --- Comment #1 from Jonathan Druart --- Created attachment 129634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129634&action=edit Bug 29914: Make check_cookie_auth compare the userid check_cookie_auth is assuming that the user is authenticated if a cookie exists and that the login/username exists in the DB. So basically if you hit the login page, fill the login input with a valid username, click "login" => A cookie will be generated, and the sessions table will contain a line with this session id. On the second hit, if the username is in the DB, it will be enough to be considered authenticated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29913] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29913 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID URL|https://www.airfleetrating. | |com/baggage/volaris-airline | |s-baggage-policy/ | Status|NEW |RESOLVED Summary|how much does volaris |SPAM |charge for extra baggage| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Jonathan Druart changed: What|Removed |Added Attachment #129484|0 |1 is obsolete|| Attachment #129485|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 129635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129635&action=edit Bug 21652: Unit test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 --- Comment #12 from Jonathan Druart --- Created attachment 129636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129636&action=edit Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 --- Comment #13 from Jonathan Druart --- Created attachment 129637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129637&action=edit Bug 21652: Simplify code And add a test. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29913] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29913 how much does volaris charge for extra baggage changed: What|Removed |Added URL||https://www.airfleetrating. ||com/baggage/volaris-airline ||s-baggage-policy/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Jonathan Druart changed: What|Removed |Added Attachment #126824|0 |1 is obsolete|| Attachment #126825|0 |1 is obsolete|| Attachment #126826|0 |1 is obsolete|| Attachment #127250|0 |1 is obsolete|| Attachment #129620|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 129638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129638&action=edit Bug 29212: Use Flatpickr on OPAC pages This patch adds Flatpickr assets to the OPAC (JS and SCSS). A few pages are updated to use Flatpickr instead of jQueryUI datepickers. jQueryUI CSS files are updated because they contain some font family definitions which are simple to remove but overly complicated to override. Without this change some Font Awesome icons are broken when they appear inside jQueryUI widgets like tabs. We don't run the risk of having this change overwritten by a future jQueryUI upgrade because there won't be any more. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Log into the OPAC and check that date pickers on the following pages work correctly, including month selection, year selection, forward and back arrows, and "Clear date" controls: - Go to the "Your personal details" page. - Check the "Date of birth" field. - With SuspendHoldsOpac enabled, view the "Your summary" page for a patron with pending holds. - Click "Suspend" to confirm that the "Suspend until" datepicker works correctly for more than one hold. - From the catalog search results page, select multiple results and click the "Place hold" link. - On the hold confirmation page, click "Show more options" to test the "Hold starts on date" (with OPACAllowHoldDateInFuture enabled) and the "Hold not needed after" fields. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #18 from Jonathan Druart --- Created attachment 129639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129639&action=edit Bug 29212: (follow-up) Incorporate linked date field code from Bug 29240 Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #19 from Jonathan Druart --- Created attachment 129640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129640&action=edit Bug 29212: (follow-up) Update missing date input I missed the "Suspend all holds" date input in previous patches. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #20 from Jonathan Druart --- Created attachment 129641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129641&action=edit Bug 29212: (follow-up) Fixes to suspend hold process This patch reworks the process of suspending an individual hold from the patron's hold list. Instead of repeating the modal markup in each line of the holds table, a single modal is re-used. A "focus: false" is added to the modal via a data-attribute in order to overcome problems with selecting months and using keyboard navigation in the calendar popup. To test, apply the patch and log into the OPAC as a user with holds. - View the holds tab under "Your summary." - Click the "Suspend" button next to one of the holds. - You should see a modal which shows the title of the item in question. - Test that the date picker works correctly: - Test selecting a month and year - Test selecting a date both with the mouse and by using arrow keys. - Test that you can clear the selected date both by clicking the X and by clicking the text link. - Select a date and close the modal without submitting the suspension. - Click the "Suspend" link on another title to confirm that the date picker still works correctly. - Submit a suspension and confirm that the it completes successfully. - Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #21 from Jonathan Druart --- Created attachment 129642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129642&action=edit Bug 29212: (follow-up) Add futuredate attribute to date picker This patch adds the "futuredate" attribute to the "Hold not needed after" date field in the OPAC hold process. To test, apply the patch and log into the OPAC. - Locate a bibliographic record and being the process of placing a hold. - Click "Show more options" to display the date fields. - If the OPACAllowHoldDateInFuture system preferences is enabled: - Set "Hold starts on date" to a date in the future. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates *after* the date you selected above. - If OPACAllowHoldDateInFuture is disabled: - The "Hold starts on date" will no longer be present. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates after today. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29909] Search failovers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29909 --- Comment #1 from Owen Leonard --- I could see there being a link that said "Did you mean to do a catalog search?" which triggered the switch, but I don't think it would be good to completely switch the user's context without warning. The second step after a failed search is usually to re-evaluate the search terms. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29916] New: PAM Company
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29916 Bug ID: 29916 Summary: PAM Company Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: packersnmoversservi...@gmail.com QA Contact: testo...@bugs.koha-community.org PAM Company is a local packers and movers in Bangalore with experts and professionals, who cater to customer needs with safety, care and love. Call us now: +91 8076805695 https://www.packersmoversinbangalore.co.in/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #5 from Jonathan Druart --- Please detail, it does not work for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 --- Comment #6 from Jonathan Druart --- Created attachment 129645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129645&action=edit Bug 29906: Add test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #7 from Jonathan Druart ---
Test is failing, I am getting a 400
{"errors":[{"message":"Expected string - got
null.","path":"\/body\/suspended_until"}],"status":400} at
/kohadevbox/koha/t/lib/Mojo.pm line 8.
Looks like we are not supposed to pass undef.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29912] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29912 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Technomiz |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29916] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29916 Owen Leonard changed: What|Removed |Added Summary|PAM Company |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24223] Convert OpacNav system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Owen Leonard changed: What|Removed |Added Attachment #111049|0 |1 is obsolete|| Attachment #129607|0 |1 is obsolete|| --- Comment #17 from Owen Leonard --- Created attachment 129646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129646&action=edit Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #18 from Owen Leonard --- Created attachment 129647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129647&action=edit Bug 26537: (follow-up) fix paging of results Also I renamed "es_query" variable for better understanding (this script works with Elastic search but also Zebra) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Owen Leonard changed: What|Removed |Added Attachment #129546|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 129648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129648&action=edit Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29787] Add plugin version to plugin search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29787] Add plugin version to plugin search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 Owen Leonard changed: What|Removed |Added Attachment #129250|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 129649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129649&action=edit Bug 29787: Add plugin version to plugin search results This patch adds a new column to plugins search results: 'Latest version'. It takes the tag_name in both GitHub and GitLab cases and passes it to the template. To test: 1. Have this on your koha-conf.xml file: ByWater Solutions bywatersolutions github Theke Solutions thekesolutions gitlab PTFS Europe ptfs-europe github 2. Restart all services: $ restart_all 3. Search for the term 'barclaycard' => SUCCESS: You get results from PTFS Europe (Github) => FAIL: They don't include plugin version 4. Search for the term 'innreach' => SUCCESS: You get results from Theke (Gitlab) => FAIL: They don't include plugin version 5. Apply this patch 6. Repeat 2-4 => SUCCESS: Results show up => SUCCESS: Results include the plugin version 7. Sign off :-D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #5 from Kevin Carnes --- It's possible to search the circulation rules for the branch code, category code, and item type with either the specified values or null. The results can be sorted to get the most relevant value for each of the 3 parameters. These 3 values can be used to search for the rule. If there is no rule, the default value of the rule can be used. This should give the same result as the patch, but it makes looking up a rule a little more complicated. If it's better to keep the ability to inherit or fall back to a less specific set of rules, it would be necessary to specify if a value should be default or inherited when defining the rules (e.g. using a special value or checking a box). Rules that should be inherited wouldn't be saved and the current method of finding rules should fall back to the most relevant value of the rule. There is a problem since some rules depend on other rules (e.g. lengthunit). It would be necessary to either make sure that these rules are retrieved from the same set of rules or make these values self-contained (e.g. length and unit in the same value). As it is now, it's possible to retrieve the lengthunit from a set of rules without an issuelength and the issuelength from a less specific set of rules with a different lengthunit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #92 from Marcel de Rooy --- I am revisiting the Auth part here now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906
--- Comment #8 from Andrew Nugged ---
it doesn't mean undef explicitly in parameters, but it was meant those two vars
to BE undef on the moment when calling:
my $params = {
...
suspend_until => $suspended_until
as I understand this:
> Breaks passing "undef" in $hold->suspend_until
> as well as "undef" in $body->{suspended_until}
this means when on the beginning before this code:
my $suspended_until = ...
$hold->suspend_until will return undef, or
$body->{suspended_until} will be absent at all, so be undef in place,
then this code:
+my $suspended_until =
+ exists $body->{suspended_until}
+ ? dt_from_string( $body->{suspended_until}, 'rfc3339' )
+ : dt_from_string( $hold->suspend_until, 'iso' );
won't allow for $suspended_until TO BECOME UNDEF, it will always have the date,
and unwanted "TODAY" because when you pass undef to dt_from_string, as it is
in:
...
return DateTime->now( time_zone => $tz ) unless $date_string;
thus that will make any call to this API endpoint to suspend hold.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 --- Comment #9 from Andrew Nugged --- Let me update the test you provided to show how that will happen... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Andrew Nugged changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906
Andrew Nugged changed:
What|Removed |Added
Attachment #129626|0 |1
is obsolete||
Attachment #129645|0 |1
is obsolete||
--- Comment #10 from Andrew Nugged ---
Created attachment 129650
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129650&action=edit
Bug 29906: fix when hold record forcibly gets unwanted "suspended" state
This code allows for "Perl false" to pass through to $suspended_until
if it is in $hold->suspend_until and in $body->{suspended_until}
But in case of "Perl truth" it calls dt_from_string for that value.
Reproduction:
1. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
2. see the test fails with something like:
# Failed test 'Location change shouldn't touch suspended status'
# at t/db_dependent/api/v1/holds.t line 1067.
# got: '1'
# expected: '0'
# Failed test 'suspended_until should be undef'
# at t/db_dependent/api/v1/holds.t line 1068.
# got: '2022-01-20 00:00:00'
# expected: undef
# Looks like you failed 2 tests of 39.
3. apply the changes in this patch to Koha/REST/V1/Holds.pm
4. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
5. test will pass.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 Thibault Keromnès changed: What|Removed |Added CC||thibault.keromnes@univ-pari ||s8.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906
Andrew Nugged changed:
What|Removed |Added
Attachment #129650|0 |1
is obsolete||
--- Comment #11 from Andrew Nugged ---
Created attachment 129651
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129651&action=edit
Bug 29906: fix when hold record forcibly gets unwanted "suspended" state
This code allows for "Perl false" to pass through to $suspended_until
if it is in $hold->suspend_until and in $body->{suspended_until}
But in case of "Perl truth" it calls dt_from_string for that value.
Reproduction:
1. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
2. see the test fails with something like:
# Failed test 'Location change shouldn't touch suspended status'
# at t/db_dependent/api/v1/holds.t line 1067.
# got: '1'
# expected: '0'
# Failed test 'suspended_until should be undef'
# at t/db_dependent/api/v1/holds.t line 1068.
# got: '2022-01-20 00:00:00'
# expected: undef
# Looks like you failed 2 tests of 39.
3. apply the changes in this patch to Koha/REST/V1/Holds.pm
4. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
5. test will pass.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23674] Allowing editable notes on all entries in patron Transactions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Allowing editable notes |Allowing editable notes on |when posting|all entries in patron |Payments/Writeoffs |Transactions table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23674] Allowing editable notes on all entries in patron Transactions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 --- Comment #4 from Andrew Fuerste-Henry --- Changed the bug title to reflect a broadened scope. Every accountlines entry has a notes field, so why not just put an Edit Note option on every line in the Transactions table. As George says, we'd want access to that button to be tied to a specific permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Attachment #129561|0 |1 is obsolete|| Attachment #129562|0 |1 is obsolete|| Attachment #129563|0 |1 is obsolete|| Attachment #129564|0 |1 is obsolete|| Attachment #129565|0 |1 is obsolete|| Attachment #129566|0 |1 is obsolete|| Attachment #129567|0 |1 is obsolete|| Attachment #129568|0 |1 is obsolete|| Attachment #129569|0 |1 is obsolete|| --- Comment #93 from Jonathan Druart --- Created attachment 129654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129654&action=edit Bug 28786: Two-factor authentication for staff client - TOTP This patchset introduces the Two-factor authentication (2FA) idea in Koha. It is far for complete, and only implement one way of doing it, but at least it's a first step. The idea here is to offer the librarian user the ability to enable/disable 2FA when logging in to Koha. It will use time-based, one-time passwords (TOTP) as the second factor, an application to handle that will be required. https://en.wikipedia.org/wiki/Time-based_One-Time_Password More developements are possible on top of this: * Send a notice (sms or email) with the code * Force 2FA for librarians * Implementation for OPAC * WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/ Test plan: 0. a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all b. To test this you will need an app to generate the TOTP token, you can use FreeOTP that is open source and easy to use. 1. Turn on TwoFactorAuthentication 2. Go to your account, click 'More' > 'Manage Two-Factor authentication' 3. Click Enable, scan the QR code with the app, insert the pin code and register 4. Your account now requires 2FA to login! 5. Notice that you can browse until you logout 6. Logout 7. Enter the credential and the pincode provided by the app 8. Logout 9. Enter the credential, no pincode 10. Confirm that you are stuck on the second auth form (ie. you cannot access other Koha pages) 11. Click logout => First login form 12. Enter the credential and the pincode provided by the app Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #94 from Jonathan Druart --- Created attachment 129655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129655&action=edit Bug 28786: Improve readability in C4::Auth::checkauth Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #95 from Jonathan Druart --- Created attachment 129656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129656&action=edit Bug 28786: Correctly inherit from Auth::GoogleAuth Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #96 from Jonathan Druart --- Created attachment 129657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129657&action=edit Bug 28786: Add tests for checkauth Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #97 from Jonathan Druart --- Created attachment 129658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129658&action=edit Bug 28786: DO NOT PUSH - DBIx schema changes Added for testing purposes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #98 from Jonathan Druart --- Created attachment 129659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129659&action=edit Bug 28786: (QA follow-up) Upgrade atomicupdate to new style Test plan: Run dbrev again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #99 from Jonathan Druart --- Created attachment 129660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129660&action=edit Bug 28786: (QA follow-up) Fix qa warnings FAIL members/two_factor_auth.pl FAIL file permissions File must have the exec flag FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt FAIL filters missing_filter at line 42 (Account: [% issuer %]) missing_filter at line 43 (Key: [% key_id %]) missing_filter at line 54 () missing_filter at line 58 ( ) FAIL Koha/Auth/TwoFactorAuth.pm FAIL pod coverage POD is missing for 'new' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #100 from Jonathan Druart --- Created attachment 129661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129661&action=edit Bug 28786: (QA follow-up) Do not call generate_secret32 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #101 from Jonathan Druart --- Created attachment 129662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129662&action=edit Bug 28786: (QA follow-up) Check the returned CSRF token We're doing this in the registering stage and at disabling. Test plan: Ënable two-factor auth but logout/login on another tab. You should get the Wrong CSRF token when submitting. Do similar thing while disabling. Verify that you can register / disable when in the same session. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Depends on||29915 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #102 from Jonathan Druart --- Patches rebased on top of bug 29915. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906
Martin Renvoize changed:
What|Removed |Added
Attachment #129651|0 |1
is obsolete||
--- Comment #12 from Martin Renvoize ---
Created attachment 129663
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129663&action=edit
Bug 29906: fix when hold record forcibly gets unwanted "suspended" state
This code allows for "Perl false" to pass through to $suspended_until
if it is in $hold->suspend_until and in $body->{suspended_until}
But in case of "Perl truth" it calls dt_from_string for that value.
Reproduction:
1. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
2. see the test fails with something like:
# Failed test 'Location change shouldn't touch suspended status'
# at t/db_dependent/api/v1/holds.t line 1067.
# got: '1'
# expected: '0'
# Failed test 'suspended_until should be undef'
# at t/db_dependent/api/v1/holds.t line 1068.
# got: '2022-01-20 00:00:00'
# expected: undef
# Looks like you failed 2 tests of 39.
3. apply the changes in this patch to Koha/REST/V1/Holds.pm
4. run provided test in kshell: prove t/db_dependent/api/v1/holds.t
5. test will pass.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- Good catch! Must admit, I'd missed entirely that this route is a partial update/patch rather than a full object replace/put. I'm still stuck on what route we should take for such routes, as there are various methods already in the codebase and we should try to work back to consistency. However, this patch certainly resolves the issue as it stands. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #14 from Martin Renvoize --- Oop, Jonathan and I clashed.. just taking a look at his test to compare you Andrews before I finish SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #103 from Jonathan Druart --- Some REST API tests are failing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #104 from Jonathan Druart --- Created attachment 129665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129665&action=edit Bug 28786: Don't expose secret and auth_method to the REST API This can be done later if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906
--- Comment #15 from Martin Renvoize ---
Comment on attachment 129663
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129663
Bug 29906: fix when hold record forcibly gets unwanted "suspended" state
Review of attachment 129663:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29906&attachment=129663)
-
::: Koha/REST/V1/Holds.pm
@@ +282,4 @@
> # suspended_until can also be set to undef
> my $suspended_until =
>exists $body->{suspended_until}
> + ? $body->{suspended_until} && dt_from_string(
> $body->{suspended_until}, 'rfc3339' )
I don't think we need this line changed.. just the second one.
At least.. it's the second line your test is testing and as Jonathan has
highlighted, it appears you can't unset the suspension by just passing 'null'
to suspend_until at the moment.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #9 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > I do like to have only a secret parameter and handle the secret/secret32 > stuff inside the module only. Expirementing a bit now. I am skipping this. Too much shuffling. But will improve validation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #16 from Martin Renvoize --- This route is kinda horrible.. it's neither a proper PUT or a PATCH.. it allows for setting pickup_location and/or priority and finally allows for suspending but not unsuspending a hold by setting the suspend_until date. There are explicit routes for all those too, which are significantly clearer in my opinion. Jonathans test was indeed incorrect as compared to what the swagger spec allows to be PUT/PATCHed as suspend_until is allowed to be missing but not allowed to be null. So, finally.. I think I can mark this as signed off.. as it's consistent with how things work now. But.. I really don't like it ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 --- Comment #17 from Martin Renvoize --- Created attachment 129666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129666&action=edit Bug 29906: (follow-up) Clarify actual code use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #10 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #4) > Still thinking about what we do now in registering: create secret, pass it > out, get it back, etc. > Easy way to build the qr but not pass the secret in that process? The CSRF token protects the secret. Fine enough probably. Especially if we would send a notice when we register or deregister 2FA to inform the user about such a change. That notice might be a simple pragmatic additional precaution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28984] Unify MARC21 ISBN/ISSN handling in XSLT in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28984 --- Comment #1 from Marcel de Rooy --- Created attachment 129667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129667&action=edit Bug 29894: Add some exceptions to TwoFactorAuth module Test updated accordingly. Adding utf8 flag to CGI in staff script. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28984] Unify MARC21 ISBN/ISSN handling in XSLT in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28984 --- Comment #2 from Marcel de Rooy --- Created attachment 129668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129668&action=edit Bug 28984: Clear secret when disabling 2FA Test plan: Deregister 2FA for patron. Check if secret is empty in borrowers.secret. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28984] Unify MARC21 ISBN/ISSN handling in XSLT in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28984 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Sorry mixing up numbers here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28984] Unify MARC21 ISBN/ISSN handling in XSLT in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28984 Marcel de Rooy changed: What|Removed |Added Attachment #129667|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28984] Unify MARC21 ISBN/ISSN handling in XSLT in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28984 Marcel de Rooy changed: What|Removed |Added Attachment #129668|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29833] Gateway Timeout for Overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29833 --- Comment #1 from Mohd Hafiz Yusoff --- Hi, anybody can answer this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #11 from Marcel de Rooy --- Created attachment 129669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129669&action=edit Bug 29894: Add some exceptions to TwoFactorAuth module Test updated accordingly. Adding utf8 flag to CGI in staff script. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #12 from Marcel de Rooy --- Created attachment 129670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129670&action=edit Bug 29894: Clear secret when disabling 2FA Test plan: Deregister 2FA for patron. Check if secret is empty in borrowers.secret. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Summary|Trying to still improve |2FA: Add few validations, |Koha/Auth/TwoFactorAuth |clear secret, send register ||notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906
Martin Renvoize changed:
What|Removed |Added
Text to go in the||The PATCH/PUT
release notes||/api/v1/holds/{hold_id} API
||endpoint allows for partial
||updates of Holds. Priority
||and Pickup Location are
||both available to change
||(though it is preferred to
||use the routes specifically
||added for manipulating
||them).
||
||Suspend_until can
||also be added/updated to
||add or lengthen an existing
||suspension, but the field
||cannot be set to null to
||remove the suspension at
||present.
||
||This patch
||restores the suspen_until
||function to ensure
||suspensions are not
||triggered by unrelated
||pickup location or priority
||changes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Attachment #129538|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Attachment #129539|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20784] Capture more changes made in the Administration module in logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20784 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29917] New: Logging Plug-In Usage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29917 Bug ID: 29917 Summary: Logging Plug-In Usage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: rco...@arlingtonva.us QA Contact: testo...@bugs.koha-community.org Plug-in Usage is not tracked at all & it would be very helpful to have the date a plug-in was last run/generated/used added to the Home › Tools › Plugins screen. It has a "Last Updated" column which is helpful, but this information would also be useful. Alternatively, it would be great to have this added to the system logs like the cronjobs are. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29917] Logging Plug-In Usage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29917 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29918] New: Batch Patron Modification - Creation of "Add Number of Days" to Expiry date field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29918 Bug ID: 29918 Summary: Batch Patron Modification - Creation of "Add Number of Days" to Expiry date field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: rco...@arlingtonva.us QA Contact: testo...@bugs.koha-community.org It would be useful to have the Batch Patron Modification "Expiry Date" field have the option to either set a hard date or "Or add number of days:", as you do with the Batch Extend Due Dates function. Use Case: This came about from adjusting 28,500 accounts this week due to COVID closures. I had to manually adjust the dates in batches of 1000 to ensure that I didn't "over-crowd" one day with too many expiring cards. Had I been able to say extend "200 days" for each account, the dispersal of accounts could have been more randomized. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] Messaging preferences for auto renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Caroline Cyr La Rose changed: What|Removed |Added Keywords||Manual-updated CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #19 from Lucas Gass --- This is quite a pain point for many libraries, is there a chance to get this one backported? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #45 from Owen Leonard --- I ran into a few other issues: * Reservoir search (addbooks.pl) is missing the columns control button * waitingreserves.pl has a JS error: "holdst_columns_settings is not defined" * marc_modification_templates columns not hiding according the the configuration, and the columns control button is missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 Owen Leonard changed: What|Removed |Added Attachment #129046|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 129671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129671&action=edit Bug 29761: Batch patron modification page should display patrons once if the same ID is inputted multiple times If a cardnumber, SMS number, or borrower number is inputted multiple times then the batch patron modification page should not display that patron multiple times. Test plan: 1. Create three text files that list card numbers, SMS numbers, and borrower numbers for three patrons. Example lists are below, notice in each there is one number duplicated: Card numbers: 2352935676 23529000651225 2352980862 2352935676 Borrower numbers: 19 49 7 49 SMS numbers: 2125551212 2125551212 2125551213 2125551214 2. Enable sending of SMS messages: * Set SMSSendDriver system preference to Email 3. Make sure the cardnumbers, borrower numbers, and SMS numbers listed above belong to patrons in your Koha 4. Go to Tools > Batch patron modification 5. Upload lists of cardnumbers, SMS numbers, and borrower numbers above, and confirm the following is happening in the batch patron modification page: - Upload the text file of cardnumbers. Notice one patron is displayed twice - Paste in the list of cardnumbers. Notice one patron is displayed twice - Upload the text file of SMS numbers. Notice one patron is displayed twice - Paste in the list of SMS numbers. Notice one patron is displayed twice - Upload the text file of borrower numbers. Notice one patron is displayed twice - Paste in the list of borrower numbers. Notice one patron is displayed twice 6. Apply patch and restart services 7. Repeat step 5 and this time observe that the patron record is not duplicated in the batch patron modification page Sponsored-By: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 David Nind changed: What|Removed |Added Attachment #129671|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 129672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129672&action=edit Bug 29761: Batch patron modification page should display patrons once if the same ID is inputted multiple times If a cardnumber, SMS number, or borrower number is inputted multiple times then the batch patron modification page should not display that patron multiple times. Test plan: 1. Create three text files that list card numbers, SMS numbers, and borrower numbers for three patrons. Example lists are below, notice in each there is one number duplicated: Card numbers: 2352935676 23529000651225 2352980862 2352935676 Borrower numbers: 19 49 7 49 SMS numbers: 2125551212 2125551212 2125551213 2125551214 2. Enable sending of SMS messages: * Set SMSSendDriver system preference to Email 3. Make sure the cardnumbers, borrower numbers, and SMS numbers listed above belong to patrons in your Koha 4. Go to Tools > Batch patron modification 5. Upload lists of cardnumbers, SMS numbers, and borrower numbers above, and confirm the following is happening in the batch patron modification page: - Upload the text file of cardnumbers. Notice one patron is displayed twice - Paste in the list of cardnumbers. Notice one patron is displayed twice - Upload the text file of SMS numbers. Notice one patron is displayed twice - Paste in the list of SMS numbers. Notice one patron is displayed twice - Upload the text file of borrower numbers. Notice one patron is displayed twice - Paste in the list of borrower numbers. Notice one patron is displayed twice 6. Apply patch and restart services 7. Repeat step 5 and this time observe that the patron record is not duplicated in the batch patron modification page Sponsored-By: Catalyst IT Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 --- Comment #8 from David Nind --- Testing notes (koha-testing-docker): 1. For step 5, before the patch is applied, the tab for 'By SMS number' is not available (at the date of testing) unless you apply patch 23291 first. Otherwise, it will appear once the patch for this bug is applied. 2. To add the SMS numbers, you need to edit each patron and add the mobile number to the SMS number field that appears as part of Patron messaging preferences (once the SMSSendDriver system preference is changed to Email). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- Since this change affects only one page and there is already some inline CSS on that page I think it's better to add it to the template and not the global SCSS file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 --- Comment #1 from Kyle M Hall --- Created attachment 129673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129673&action=edit Bug 27424: Update schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Kyle M Hall changed: What|Removed |Added Attachment #129673|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 129674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129674&action=edit Bug 27424: Update schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
