[Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Why are there no tests for this routine btw ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 --- Comment #6 from Fridolin Somers --- (In reply to Jonathan Druart from comment #4) > Then I would also change the following line: > 156 __PACKAGE__->new($marc, $row->biblionumber); Good catch ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 Fridolin Somers changed: What|Removed |Added Attachment #129629|0 |1 is obsolete|| --- Comment #5 from Fridolin Somers --- Created attachment 129839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129839=edit Bug 29625: Fix var name in Koha::BiblioUtils get_all_biblios_iterator In Koha::BiblioUtils, get_all_biblios_iterator method is a class level method like get_from_biblionumber. So its first arg should be named $class instead of $self. Even if this var in not used. Test plan : 1) Run Elasticsearch full rebuild with and without patch 2) Check all biblio records are in index -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29924] Introduce password expiration to patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #9 from David Cook --- Another thought... rather than purging the data... make it more obvious on the Hea webapp what numbers belong to what year? That could be really interesting as you could see changes in data over time. Then it might be worthwhile keeping maybe the last 5 years of data, if long-term storage of data is a problem. Of course, numbers can also be misleading. A drop in numbers in more recent years might make it seem like fewer people using Koha when really it's just fewer people reporting their usage... But anyway, that's my 2 cents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28201] Add API routes to create biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29953 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29953] Possible inefficiency in REST API for biblios endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29953 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28201 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29953] New: Possible inefficiency in REST API for biblios endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29953
Bug ID: 29953
Summary: Possible inefficiency in REST API for biblios endpoint
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: dc...@prosentient.com.au
CC: tomasco...@gmail.com
I was looking at Koha/REST/V1/Biblios.pm because of bug 28201 when I noticed it
looks like we're running $record->$method calls more than we need to in the
"get" function.
Consider the following block of code:
if ( $c->req->headers->accept =~ m/application\/json/ ) {
return $c->render(
status => 200,
json => $biblio->to_api
);
}
else {
my $record = $biblio->metadata->record;
$c->respond_to(
marcxml => {
status => 200,
format => 'marcxml',
text => $record->as_xml_record
},
mij => {
status => 200,
format => 'mij',
text => $record->to_mij
},
marc => {
status => 200,
format => 'marc',
text => $record->as_usmarc
},
txt => {
status => 200,
format => 'text/plain',
text => $record->as_formatted
},
any => {
status => 406,
openapi => [
"application/json",
"application/marcxml+xml",
"application/marc-in-json",
"application/marc",
"text/plain"
]
}
);
}
If there is an Accept header for application/json, then we run $biblio->to_api,
and that's it.
However, if there isn't an Accept header for application/json, it looks like we
create a hash of hashrefs that output the $record in 4 different formats.
I think it would make more sense (based on what I see in
https://docs.mojolicious.org/Mojolicious/Plugin/DefaultHelpers#respond_to) to
provide anonymous functions instead of hashrefs so that $record->$method calls
are only run when a specific format is actually chosen by Mojolicious.
In terms of performance, it might be only a marginal gain, but if you're doing
a lot of API calls, small gains can translate into large scale time savings.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28201] Add API routes to create biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 --- Comment #11 from David Cook --- I'll open a separate report for that so I stop distracting from the real purpose of this report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28201] Add API routes to create biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 --- Comment #10 from David Cook --- (In reply to Tomás Cohen Arazi from comment #9) > (In reply to David Cook from comment #8) > > Looking at > > https://docs.mojolicious.org/Mojolicious/Plugin/DefaultHelpers#respond_to > > and it looks to me like Koha/REST/V1/Biblios.pm might actually be a bit > > inefficient. It looks like it runs every output option (e.g. > > "as_xml_record", "to_mij", "as_usmarc", "as_formatted") regardless of what > > content type is actually served to the user... might be worthwhile wrapping > > those method calls in anonymous functions... > > > > But that's neither here nor there > > I don't think it is working as you suggest. Not I read the docs the same way > you do. Let's run it on a debugger. There is a little error in what I said. If application/json is sent as an Accept header, then only a JSON response will be generated. However, looking at the code, if application/json is not sent in the Accept header, then we're creating a hash composed of marcxml, mij, marc, txt, and any keys with their corresponding values. That's just straight up Perl code. That said, it is possible I'm wrong about wrapping the method calls in anonymous functions though. I don't think the method should be called until the anonymous function is run, but it could be worth checking with a debugger. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28201] Add API routes to create biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 --- Comment #9 from Tomás Cohen Arazi --- (In reply to David Cook from comment #8) > Looking at > https://docs.mojolicious.org/Mojolicious/Plugin/DefaultHelpers#respond_to > and it looks to me like Koha/REST/V1/Biblios.pm might actually be a bit > inefficient. It looks like it runs every output option (e.g. > "as_xml_record", "to_mij", "as_usmarc", "as_formatted") regardless of what > content type is actually served to the user... might be worthwhile wrapping > those method calls in anonymous functions... > > But that's neither here nor there I don't think it is working as you suggest. Not I read the docs the same way you do. Let's run it on a debugger. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Lucas Gass changed: What|Removed |Added Attachment #129198|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 129838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129838=edit Bug 20894: Add barcode size parameters to /svc/barcode This patch adds a couple of new parameters to the barcode generator service: "modulesize," which controls the size of QRcodes*, and "height," which can be applied to all other barcode types. * The "modulesize" number refers to the pixel dimensions of each black and white square in the generated QRcode. The dimensions in "squares" of the QR code depends on how much data is being encoded. For QRcodes, one default parameters is used: An error-correction level of "M" (Medium, https://en.wikipedia.org/wiki/QR_code#Error_correction). To test, apply the patch and restart services. Test various settings to confirm that barcodes are displayed correctly: http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=QRcode=3=https%3A%2F%2Fkoha-community.org http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=QRcode=6=https%3A%2F%2Fkoha-community.org http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Code39=50=3200203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Code39=20=3200203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=COOP2of5=50=3200203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=IATA2of5=50=3200203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Industrial2of5=50=3200203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=ITF=50=3200203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Matrix2of5=50=3200203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=NW7=50=3200203734 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28201] Add API routes to create biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 --- Comment #8 from David Cook --- Looking at https://docs.mojolicious.org/Mojolicious/Plugin/DefaultHelpers#respond_to and it looks to me like Koha/REST/V1/Biblios.pm might actually be a bit inefficient. It looks like it runs every output option (e.g. "as_xml_record", "to_mij", "as_usmarc", "as_formatted") regardless of what content type is actually served to the user... might be worthwhile wrapping those method calls in anonymous functions... But that's neither here nor there -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28201] Add API routes to create biblio record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201
--- Comment #7 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #6)
> (In reply to Julian Maurice from comment #5)
> > (In reply to Tomás Cohen Arazi from comment #4)
> > > I like where this is going, but I think this needs some more thinking.
> > >
> > > In my opinion:
> > > - The request body should include the raw record
> > > - Content/Type should tell the controller how it should handle the raw
> > > record in terms of serialization format (i.e. application/marcxml+xml,
> > > application/marc-in-json, etc)
> >
> > That's what I wanted to do at first, but I couldn't figure out how to pass
> > non-json data to the API. If I remember correctly the body was always empty
> > when trying to use it in the controller. So I opted for the easy way.
> > Do we have examples of Koha API routes that accept data other than JSON ?
>
> Try
>
> "schema": { "type": "string" }
>
> for the body parameter.
O that's cool. Previously, I had no luck getting the validator to accept
anything but JSON, but if that works that would be awesome...
So for examples...
api/v1/swagger/paths/biblios.json
Koha/REST/V1/Biblios.pm
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15787] Show and export itemnumber and biblionumber via the item search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15787 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #2 from Caroline Cyr La Rose --- This is still valid, especially for non-lending libraries who do not use barcodes. It renders the item search for batch modification useless if we can export a list of itemnumbers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29952] New: Filter Paid Transactions Broken on Transactions tab in Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Bug ID: 29952 Summary: Filter Paid Transactions Broken on Transactions tab in Staff Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisettesla...@gmail.com QA Contact: testo...@bugs.koha-community.org I tested in both master and on 21.05.08 and the "Filter paid transactions" link on members/boraccount.pl does nothing anymore. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 --- Comment #8 from Fridolin Somers --- In my opinion keeping 1 year is a good compromise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 The Minh Luong changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 The Minh Luong changed: What|Removed |Added Status|NEW |Needs Signoff CC||the-minh.lu...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967 --- Comment #1 from The Minh Luong --- Created attachment 129837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129837=edit Bug 28967: Patrons with no checkouts report shows patrons from other libraries with IndependentBranches When IndependentBranches is activated and a non-superlibrarian user looks at the "Patrons with no checkouts" report, it shows patrons from other libraries. To recreate: 1) Activate IndependentBranches, IndependentBranchesPatronModifications and IndependentBranchesTransfers 2) Create a staff user with limited permissions (NOT a superlibrarian), including reports permissions. Here are mine as an example - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 3) Create (or make sure you already have) a patron in another branch (if using an existing patron, make sure they have no checkouts or checkout history) 4) Log in as your limited staff patron 5) Go to Reports > Inactive > Patrons who haven't checked out 6) Don't put in any limitations and click Submit -- The patron from the other library appears in the list 7) Try to search for that other patron in the patron module -- The patron from the other library is inaccessible 8) Apply the patch 9) Notice that the limited patron can only see patrons from his own library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29951] New: Cannot add splitting rule to classification sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951 Bug ID: 29951 Summary: Cannot add splitting rule to classification sources Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Home -> Administration -> Classification sources -> New splitting rule Can't locate object method "subclasses" via package "C4::ClassSplitRoutine" at /kohadevbox/koha/C4/ClassSplitRoutine.pm line 53 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
--- Comment #3 from Lucas Gass ---
before patch:
root@kohadevbox:koha(master)$ git grep 'title-numeric'
koha-tmpl/intranet-tmpl/lib/datatables/datatables.js:*
$.fn.dataTable.ext.type.search['title-numeric'] = function ( d ) {
koha-tmpl/intranet-tmpl/prog/js/datatables.js: *{ "sType":
"title-numeric" },
koha-tmpl/intranet-tmpl/prog/js/datatables.js:"title-numeric-pre": function
( a ) {
koha-tmpl/intranet-tmpl/prog/js/datatables.js:"title-numeric-asc": function
( a, b ) {
koha-tmpl/intranet-tmpl/prog/js/datatables.js:"title-numeric-desc":
function ( a, b ) {
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt:
{ "type": "title-numeric", "targets" : [ "title-num"] },
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js: *{ "sType":
"title-numeric" },
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js:"title-numeric-pre":
function ( a ) {
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js:"title-numeric-asc":
function ( a, b ) {
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js:"title-numeric-desc":
function ( a, b ) {
after patch:
root@kohadevbox:koha(master)$ git grep 'title-numeric'
koha-tmpl/intranet-tmpl/lib/datatables/datatables.js:*
$.fn.dataTable.ext.type.search['title-numeric'] = function ( d ) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 Lucas Gass changed: What|Removed |Added Attachment #129824|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 129836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129836=edit Bug 29949: Remove use of title-numeric sorting routine from OPAC datatables JS This patch removes the use of a specific "title-numeric" sorting routine from the DataTables configuration of the "Most popular" table. We can use a "data-order" attribute instead. The patch also removes the now unused code from our custom DataTables JS file in both the OPAC and the staff interface (where it was unused). To test, apply the patch and make sure the OpacTopissue system preference is enabled. - In the OPAC, view the "Most popular" page. - Change the filter settings, if necessary, to get multiple results. - In the results table, confirm that sorting by number of checkouts still works correctly. A search of the code for instances of "title-numeric" should return only one in a comment in the official DataTables library. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29940] Phase out jquery.cookie.js in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Owen Leonard changed: What|Removed |Added Attachment #129749|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 129835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129835=edit Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #11 from Owen Leonard --- Remote branch updated to remove the non-minified version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Amy Schapiro changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29950 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29950] New: Staff client Suggest for purchase clears item type, quantity, library and reason if bib exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29950 Bug ID: 29950 Summary: Staff client Suggest for purchase clears item type, quantity, library and reason if bib exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: a...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org This bug is related to bug 29419; where 29419 fixed this issue in the OPAC, it was not corrected in the staff client. When a similar item is detected and suggested, the staff user can submit the form without replacing the item type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Thibaud Guillot changed: What|Removed |Added Status|NEW |Needs Signoff CC||thibaud.guil...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #5 from Thibaud Guillot --- Created attachment 129834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129834=edit New syspref EnhancedMessaging for clearer functionality Actually there is EnhancedMessagingPreferences that can be set on "Allow" or "Don't allow" to show or not show messaging preferences for patrons. But this syspref does not prevent notifications from being sent. From your comments, I decide to create a new syspref which show dialog alert on patron details (Patron messaging preferences section) but prevent misc/cronjobs/advance_notices.pl script. EnhancedMessagingPreferences keep the same behavior I just took over preferences descriptions to make clearer context (on EnhancedMessagingPreferencesOPAC too). Test plan : 1 - Be sure to have a patron with a loan 2 - Also be sure to have a model on your library in "Notices & slips" 3 - Set max days for advance_notices on patron details table 4 - Then set EnhancedMessagingPreferences to "Allow" 5 - On Patron details you will see the table for settings notifications 6 - Run the misc/cronjobs/advance_notices.pl script manually 7 - The script find a notice and add a message in message_queue table 8 - Set now EnhancedMessagingPreferences to "Don't allow" 9 - Repeat the step 5, you don't see the table right now 10 - Repeat the step 6, same behavior, a message is created and stored 11 - Now apply this patch and launch updatedatabase.pl 12 - You will see the new syspref "EnhanceMessaging" 13 - If you want you can repeat steps 4 to 10 - same behavior again 14 - But now, you can set to "Don't send" on EnhancedMessaging 15 - See on patron details page, there is a dialog alert to inform 16 - Run again the step 6, normally it will send you a warn and no message was created or stored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29945] Item Level Hold Library Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29945 --- Comment #2 from Daniel Gaghan --- (In reply to Katrin Fischer from comment #1) > Hi Daniel, which version are you seeing this in? I seem to remember another > bug about this but can't locate it right now. 21.05.08 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576 Sally changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #3 from Sally --- Changing status to Signed Off, as per comment 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27208] Add a configurable time delay feature to hold notice templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29940] Phase out jquery.cookie.js in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- Same as bug 11873, I would remove the non-minified version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #10 from Jonathan Druart --- (In reply to Owen Leonard from comment #9) > (In reply to Jonathan Druart from comment #8) > > Do we really need to include the non-minified version of jstree? > > It's not strictly necessary as long as the minified version includes version > number information in it. Yes, that's my point. If someone wants to debug it is easy to retrieve the corresponding non-minified version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #9 from Owen Leonard --- (In reply to Jonathan Druart from comment #8) > Do we really need to include the non-minified version of jstree? It's not strictly necessary as long as the minified version includes version number information in it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Then I would also change the following line: 156 __PACKAGE__->new($marc, $row->biblionumber); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 Jonathan Druart changed: What|Removed |Added Attachment #129628|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 129825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129825=edit Bug 29482: Replace the term branch with library This patch replaces the word "branch" with the word "library" in the self-checkout template, as per terminology guidelines. To test, apply the patch and go to Administration -> System preferences. - Set the "IndependentBranches" preference to "Yes." - Log into the self checkout system using a staff user with permission to do self-checkout but not superlibrarian status. - Try to check out an item which belongs to a library that's different to the one you're logged in with. - You should see a message, "Item cannot be checked out," including the text "This item belongs to another library." Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #8 from Jonathan Druart --- Do we really need to include the non-minified version of jstree? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > (In reply to Jonathan Druart from comment #3) > > > select year(modification_time) as , count(*) from installation group > > > by ; > > +--+--+ > > | | count(*) | > > +--+--+ > > | 2014 |8 | > > | 2019 | 114 | > > | 2020 | 2726 | > > | 2021 | 5893 | > > | 2022 | 4987 | > > +--+--+ > > > > What do we remove? What does "periodically" mean? > > Nothing between 2014 and 2019 is a little bit odd? I've purged them already some years ago. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 --- Comment #1 from Owen Leonard --- Created attachment 129824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129824=edit Bug 29949: Remove use of title-numeric sorting routine from OPAC datatables JS This patch removes the use of a specific "title-numeric" sorting routine from the DataTables configuration of the "Most popular" table. We can use a "data-order" attribute instead. The patch also removes the now unused code from our custom DataTables JS file in both the OPAC and the staff interface (where it was unused). To test, apply the patch and make sure the OpacTopissue system preference is enabled. - In the OPAC, view the "Most popular" page. - Change the filter settings, if necessary, to get multiple results. - In the results table, confirm that sorting by number of checkouts still works correctly. A search of the code for instances of "title-numeric" should return only one in a comment in the official DataTables library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29949] New: Remove use of title-numeric sorting routine from OPAC datatables JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 Bug ID: 29949 Summary: Remove use of title-numeric sorting routine from OPAC datatables JS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org There is one template in the OPAC, opac-topissues.tt, which uses a special DataTables sorting routine called "title-numeric." This can be replaced with sorting via a data-order attribute, and the custom routine can be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > > select year(modification_time) as , count(*) from installation group by > > ; > +--+--+ > | | count(*) | > +--+--+ > | 2014 |8 | > | 2019 | 114 | > | 2020 | 2726 | > | 2021 | 5893 | > | 2022 | 4987 | > +--+--+ > > What do we remove? What does "periodically" mean? Nothing between 2014 and 2019 is a little bit odd? I agree with Katrin: 6 months or perhaps 12 months to be safe should be the cutoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 --- Comment #5 from Katrin Fischer --- (In reply to Katrin Fischer from comment #4) > I think it's supposed to report every month... so maybe we could keep a > timeframe of like 6 months back? Assuming the date updates if a new report comes in - or is it only updated if data actually changes (like a timestamp on the database)? We'd want the date last reported I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 --- Comment #4 from Katrin Fischer --- I think it's supposed to report every month... so maybe we could keep a timeframe of like 6 months back? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29910] Purge old Hea data periodically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 Jonathan Druart changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Jonathan Druart --- > select year(modification_time) as , count(*) from installation group by > ; +--+--+ | | count(*) | +--+--+ | 2014 |8 | | 2019 | 114 | | 2020 | 2726 | | 2021 | 5893 | | 2022 | 4987 | +--+--+ What do we remove? What does "periodically" mean? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29924] Introduce password expiration to patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #12 from Nick Clemens --- (In reply to Owen Leonard from comment #10) > Some thoughts: > > - Why is the "Your password has expired" page in the OPAC empty, whereas the > "Incorrect password" page shows the search bar and the other search links? Fixed - we generate a lot of necessary content for the template in the routine, so I delay the output until the end > - Should we show the password expiration on the patron detail page? Under > the password line? > > - Should we show a (non-blocking) warning on the checkout page when a > patron's password has expired like we do when their account has expired? I am not sure on these, on other systems where my password expires I don't see these. It is debatable whether general staff need to know this, I think these options would need to be configurable, open a follow-up bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29924] Introduce password expiration to patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #11 from Nick Clemens --- Created attachment 129823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129823=edit Bug 29924: (follow-up) Generate necessary template variables before output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 Johanna Räisä changed: What|Removed |Added CC||johanna.ra...@koha-suomi.fi --- Comment #26 from Johanna Räisä --- Removing hyphens from the marcxml record is against the standard. I liked the idea in the bug 27774 and now we have elasticsearch, so could this be done with a system preference? When using elasticsearch keep hyphens on the marcxml for example. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Thibault Keromnès changed: What|Removed |Added CC||thibault.keromnes@univ-pari ||s8.fr --- Comment #13 from Thibault Keromnès --- Hi Alex We tested the patch last week, most of it works great, thanks. Only three indexes we couldn't use : - carrier-type - identifier-persistent (we were not able to reproduce comment #12 search) - char-encoding I'm not sure if we had the syntax right (we used intranet search, with "Index-name:search", it worked for most, not for those 3) or if it's a problem with the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #43 from Jonathan Druart --- Created attachment 129821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129821=edit Bug 29043: Don't fetch items if when are not on the 'Place a hold on' form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Attachment #129498|0 |1 is obsolete|| Attachment #129531|0 |1 is obsolete|| --- Comment #42 from Jonathan Druart --- Created attachment 129820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129820=edit Bug 29043: Don't fetch biblios info unless a patron is picked If we haven't picked a patron or a club yet we don't need to fetch biblios, items and holdability infos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29859] Favor iterators over as_list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29948] Display author information for researches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29948 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||ha...@orex.es -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What|Removed |Added Blocks||29948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29948 [Bug 29948] Display author information for researches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29948] New: Display author information for researches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29948 Bug ID: 29948 Summary: Display author information for researches Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jonathan.druart+k...@gmail.com Reporter: jonathan.druart+k...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 29897 Display author's information from 371, 372, 373 (email, activity, etc.) in the same area than identifiers (from bug 29897). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 [Bug 29897] Display author identifiers for researchers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29945] Item Level Hold Library Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29945 --- Comment #1 from Katrin Fischer --- Hi Daniel, which version are you seeing this in? I seem to remember another bug about this but can't locate it right now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #5 from Jonathan Druart --- The goal of these patches is to adapt the code from https://gitlab.com/sibeprod/datosautores to Koha core. It can be viewed there: https://biblioteca.ecosur.mx/cgi-bin/koha/opac-authoritiesdetail.pl?authid=12374 https://biblioteca.ecosur.mx/cgi-bin/koha/opac-detail.pl?biblionumber=10794 To be integrated correctly into Koha I have decided to add the identifiers in a new tab, but this can be adjusted if someone has a better suggestion. Also I am suggesting to deal with other author's information from 371, 372, 373 (email, activity, etc.) on a separate bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #4 from Martin Renvoize --- In fact.. our customer doesn't want SIP returns to result in holds captured at all in my understanding. They often have patrons just ignore the self check prompt to put the item into the exceptions bin and thus items are reshelved and not actually captured for the hold at all.. SO what they want is for the message to appear just in case the patron pays attention and thus puts the item in the exceptions bin.. but for the actual capture to require a staff check-in as the next step. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29939] Improve auth check in opac-ratings-ajax.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 --- Comment #2 from Katrin Fischer --- If I am correct that these are the star ratings, there has been additions in the last versions to it which I think shows it must be used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #4 from Jonathan Druart --- Created attachment 129819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129819=edit Bug 29897: Display author's identifiers This new enhancement add the capability to list the different identifiers of authors. It is helpful for research publications for instance. This patch will add a new "Author identifiers" tab on the detail page (OPAC) of a bibliographic record, with the list of the authors and their identifiers. On the detail page of the authority record, the same identifier list will be displayed. Test plan: Create some authority with 024 $a source $2 number $6 link to the source With the pref turned ON you will be able to see the new information. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #3 from Jonathan Druart --- Created attachment 129818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129818=edit Bug 29897: Add new pref OPACAuthorIdentifiers Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #2 from Jonathan Druart --- Created attachment 129817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129817=edit Bug 29897: Move code to private method for reusability Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #1 from Jonathan Druart --- Created attachment 129816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129816=edit Bug 29897: Rename get_marc_authors with get_marc_contributors get_marc_authors actually return authors from 700..712, not the first author from 200 Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29939] Improve auth check in opac-ratings-ajax.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29939 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- Do we know if this feature is even used ? Looks like a very old pre-social-network feature. In HEA we see preference is enabled, but it is by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #3 from Martin Renvoize --- I really wish Holds and Transfers were better tied together.. it's somewhat mad that a hold can be set to in transfer without it actually triggering a transfer (in code) and thus you have to follow any call to ModReserveAffect with a Transfer anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29936] Add ability to disable hold capture via SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #2 from Martin Renvoize --- Interesting.. very nearly. I had entirely forgotten about that new preference.. however, it doesn't appear to resolve the transfers issue.. i.e. the hold is still captured, though it's marked as processing.. in the SIP code itself, the item may then be set to in transfer.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29947] New: Show an estimated waiting time when placing hold in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29947 Bug ID: 29947 Summary: Show an estimated waiting time when placing hold in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Do some calculation based on number of holds and max loan period. Would have to take decreaseLoanHighHolds into account too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
