[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #30 from Jonathan Druart --- (In reply to David Cook from comment #29) > Anyone interested in this one? I will have a look again if you provide a patch on the follow-up bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #29 from David Cook --- Anyone interested in this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #14 from David Cook --- (In reply to Tomás Cohen Arazi from comment #12) > I'm more than happy to rewrite it all on a follow-up bug, add an on/off > switch for holds and remove maxreserves too :-D On a separate bug :-D Yes please :3. I had some thoughts on this at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565#c266 but didn't have funds/scope to do anything about it... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30039] Add published_on column to missing issues table on claims.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #8 from David Cook --- (In reply to Florian from comment #7) > But it's already there in the code. The current version already supports > vast majority of exit codes, this patch aims to make sure we support even > more. I'm not sure if you're referring to Koha or your Koha plugin here. If it's Koha, no it doesn't? Anyway, that's just my 2 cents. Testers and QA might think differently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30049] Add ability to download list as a spreadsheet.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30049 --- Comment #1 from Katrin Fischer --- Hi Esther, have a look at tools > CSV profiles. You can make up your own spreadsheet format to export the cart and lists there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30046] ILS-DI: GetPatronInfo doesn't return the category description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30046 Katrin Fischer changed: What|Removed |Added Summary|GetPatronInfo doesn't |ILS-DI: GetPatronInfo |return the category |doesn't return the category |description |description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 --- Comment #13 from Katrin Fischer --- Sorry, was not clear enough maybe: not super happy, but ok with the patch as is. ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30054] Add SMS equivalent to EmailOverduesNoEmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30054 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28556] Make guarantor information available in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 The Minh Luong changed: What|Removed |Added Status|NEW |Needs Signoff CC||philippe.blo...@inlibro.com ||, ||the-minh.lu...@inlibro.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28556] Make guarantor information available in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 The Minh Luong changed: What|Removed |Added Attachment #130339|0 |1 is obsolete|| --- Comment #2 from The Minh Luong --- Created attachment 130340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130340=edit Bug 28556: Guarantor's information is available in notice This patch adds the guarantor's information when sending sending overdue notice. To test: 1. Make sure that there is an overdue letter. a) Go in Tools/Notices & Slips. b) Search for the code "ODUE" and note the "Name" of the letter. c) Click on "Edit". d) Click on "Email" and make sure that there is text inside the box. e) Add the following code in the textbox: C/O <> <> f) Click on "Save". 2. Set up the status trigger. a) Go in Tools/Overdue notice/status triggers. b) In "First" tab, put a number of days in the "Delay" column (ex: 1). c) In the column "Letter", put the "Name" of the letter of step 1a) . d) Check "Email". e) Click "Save". 3. Create a patron with a guarantor. a) Go in Administration/Patron categories. b) Create a child category AND a adult category. c) Create an adult patron. d) Create a child patron. e) Go in the child patron's page and click "Edit". f) In the "Patron guarantor" section, click add guarantor. g) Search for your adult patron and click "Select". h) Select a relationship for the guarantor (ex: Mother). i) Click on "Save". 4. Borrow an overdue item. a) Click on the arrow next to "Search button" (Top of the screen). b) Click on "Items search". c) Click on search. d) Copy a barcode in the list. e) Search for your child patron. f) Go in his page and click on "Checkout". g) Paste the barcode copied at step 4d) . h) Click on "Checkout settings". i) Put a date in the past greater than the number of days that you put on step 2b). j) Click on "Check out". k) Click on "Yes" Notice tht there is a message saying that Patron has ITEMS OVERDUE. 5. Test the patch. a) In the terminal, run ./misc/cronjobs/overdue_notices.pl b) Return in your child patron's page. c) Click on "Notice" and you should see a letter. d) Click on the letter to see the content. c) Notice that you can't see the guarantor's informations (Adult patron). d) Apply the patch. e) Reapeat steps a) to d) f) Notice that you can see the guarantor's informations. NOTE: If you want to delete the letters, do in your terminal: - my - delete from message_queue; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28556] Make guarantor information available in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 --- Comment #1 from The Minh Luong --- Created attachment 130339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130339=edit Bug 28556: Guarantor's information is available in notice This patch adds the guarantor's information when sending sending overdue notice. To test: 1. Make sure that there is an overdue letter. a) Go in Tools/Notices & Slips. b) Search for the code "ODUE" and note the "Name" of the letter. c) Click on "Edit". d) Click on "Email" and make sure that there is text inside the box. e) Add the following code in the textbox: C/O <> <> f) Click on "Save". 2. Set up the status trigger. a) Go in Tools/Overdue notice/status triggers. b) In "First" tab, put a number of days in the "Delay" column (ex: 1). c) In the column "Letter", put the "Name" of the letter of step 1a) . d) Check "Email". e) Click "Save". 3. Create a patron with a guarantor. a) Go in Administration/Patron categories. b) Create a child category AND a adult category. c) Create an adult patron. d) Create a child patron. e) Go in the child patron's page and click "Edit". f) In the "Patron guarantor" section, click add guarantor. g) Search for your adult patron and click "Select". h) Select a relationship for the guarantor (ex: Mother). i) Click on "Save". 4. Borrow an overdue item. a) Click on the arrow next to "Search button" (Top of the screen). b) Click on "Items search". c) Click on search. d) Copy a barcode in the list. e) Search for your child patron. f) Go in his page and click on "Checkout". g) Paste the barcode copied at step 4d) . h) Click on "Checkout settings". i) Put a date in the past greater than the number of days that you put on step 2b). j) Click on "Check out". k) Click on "Yes" Notice tht there is a message saying that Patron has ITEMS OVERDUE. 5. Test the patch. a) In the terminal, run ./misc/cronjobs/overdue_notices.pl b) Return in your child patron's page. c) Click on "Notice" and you should see a letter. d) Click on the letter to see the content. c) Notice that you can't see the guarantor's informations (Adult patron). d) Apply the patch. e) Notice that you can see the guarantor's informations. NOTE: If you want to delete the letters, do in your terminal: - my - delete from message_queue; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30053] Separate serials enum/pub date into columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30053 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30054] New: Add SMS equivalent to EmailOverduesNoEmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30054 Bug ID: 30054 Summary: Add SMS equivalent to EmailOverduesNoEmail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Bug 20076 introduced a new system preference 'EmailOverduesNoEmail' which is great. Koha will still generate a print notice when SMS is selected in overdue notice/status triggers and a patron does not have an smsalertnumber. It would be nice if there was an SMS equivalent system pref like 'SMSOverduesNoSMS' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Charles Kelley changed: What|Removed |Added CC||cmkelley...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #78 from Andrew Fuerste-Henry --- I see this bug is a bit stuck, but commenting to say I like the idea! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30053] New: Separate serials enum/pub date into columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30053 Bug ID: 30053 Summary: Separate serials enum/pub date into columns Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org Currently in the holdings table for a serial the enum column forces the enum value, numbering pattern, and pub date. While these can individually be hidden, often a library needs all three pieces of data, but needs them to display in separate columns. With the table settings controlling the display now, this would be a welcomed addition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30052] New: When adding a 'New child record' the 773 field is not pre-populated in advanced editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30052 Bug ID: 30052 Summary: When adding a 'New child record' the 773 field is not pre-populated in advanced editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To recreate: 1 - Enable Advanced Cataloging Editor 2 - Edit a record and confirm you are using, or switch to advanced editor 3 - From an existing record Click 'New->New child record' 4 - Fill in required fields and save 5 - Record is not linked to parent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What|Removed |Added Summary|Remove Date::Calc use in|Remove Date::Calc use |batch_anonymize.pl | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #12 from Tomás Cohen Arazi --- Hi, I would like us to not get distracted by Koha lacking things or not ideal, and focus on the fact that this is the current behavior, and the API is not respecting it and is affecting stable. I'm more than happy to rewrite it all on a follow-up bug, add an on/off switch for holds and remove maxreserves too :-D On a separate bug :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30051] New: Changing AcqCreateItems value impacts baskets set to follow default behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30051 Bug ID: 30051 Summary: Changing AcqCreateItems value impacts baskets set to follow default behavior Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When creating a basket in acquisitions, we record the user's choice for item creation in aqbasket.create_items. However, if one sets the basket to follow the default behavior determined in the AcqCreateItems syspref then we leave aqbasket.create_items NULL. This can create issues if the syspref gets changed. For example: - set AcqCreateItems to "placing an order" - create a basket, leaving item creation set to the default - confirm aqbasket.create_items is null - add an order to your basket from a new bib. confirm your bib and 1 item are created. - close your basket - set AcqCreateItems to "receiving an order" - receive your order - confirm receiving the order creates a second item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30050] Koha::DateUtils needs usable POD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30050 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30050] New: Koha::DateUtils needs usable POD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30050 Bug ID: 30050 Summary: Koha::DateUtils needs usable POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org There's no mention of the possible values. For example, the valid formats. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #19 from Tomás Cohen Arazi --- I like it. Maybe the interaction between marking the return claim as resolved and the previous checkin modal could be revisited at some point (i.e. it still lets you choose the 'Resolve' button). Not a blocker IMHO. Great -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129700|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 130338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130338=edit Bug 29519: Allow resolution of claims return at checkin Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #79 from Andrew Fuerste-Henry --- On parcel.pl, when selecting orders to receive, we should have a "Select all" option to check the boxes for all orders currently onscreen. In this multi-receiving workflow, for order set to create items in cataloging, quantity received is defaulting to 0 and requiring the user to manually change it to match quantity ordered. When following the normal single order receiving workflow, Koha will assume that quantity received = quantity ordered if your basket was set to create items in cataloging. This change needs to be corrected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #7 from David Nind --- Issues from testing: 1. The patch works for me - it stops mappings being deleted as reported. I had to clear the browser cache for this to work. 2. However, with mappings either filtered or unfiltered, if you: 2.1: Change one (for example: Authorities > Heading-Main, 155a - change the Yess to Nos), save, the change to the mapping is not saved. 2.2: Delete one, save, the deleted mapping is not deleted. 2.3: Add a new one (for example: Heading-Main, Yes for all options, 155b), the new mapping is not saved. 3. I also noted that when adding a new mapping, the options available for the sortable column are Undef, 0 and 1. For all the other columns the options are Yes and No. I'm not familiar enough with Elastic to know whether this is correct or not. Tested using Firefox Developer Edition. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |RESOLVED Resolution|--- |LATER -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #4 from Jonathan Druart --- Why this script and not all other occurrences then? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #36 from Jonathan Druart --- Should we then move it out of the NQA queue and revive it when we will need it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #18 from Jonathan Druart --- Do we want to display the author for the multi-holds view as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #17 from Jonathan Druart --- Created attachment 130337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130337=edit Bug 28405: Add author for multi holds view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130311|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 130336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130336=edit Bug 29570: Simplify for loop Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #42 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #40) > +my $patron = Koha::Patrons->find( $borrowernumber );; > > Trailing semi-colon here. Good catch, fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130267|0 |1 is obsolete|| --- Comment #41 from Tomás Cohen Arazi --- Created attachment 130335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130335=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30049] New: Add ability to download list as a spreadsheet.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30049 Bug ID: 30049 Summary: Add ability to download list as a spreadsheet. Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: esth...@sodaspringsid.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Currently the only options for downloading a list in the list tab is iso2709, RIS, Bibtex. It would be nice to be able to download a list as an Excel or LibreOffice Calc file, perhaps a CSV too. The ability to download a spreadsheet is available in other areas of Koha, and it would be nice if it was available in Lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #35 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #34) > (In reply to Tomás Cohen Arazi from comment #26) > > (In reply to Marcel de Rooy from comment #6) > > > Just reading diagonally, sounds like yet another configuration to manage? > > > Moving all preferences into it would be a dramatic refactoring that we > > > probably do not finish? > > > > I agree. I will probably abandon this bug. > > Hum... What's next here? I see this pattern will become useful, I thought we would assign SMTP servers to libraries in a circ rules-like fashion, but I couldn't have that dev depend on this one so it moved forward in another direction. But it is not a priority until devs find it useful. As of the question, to make it useful: - It should consider library groups from the beginning - We need some UI for dealing with this, that can be reused to make configuration pages for modules/tools relying on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952
David Nind changed:
What|Removed |Added
Text to go in the||This fixes the "Filter paid
release notes||transactions" link in the
||staff interface on the
||Patron account > Accounting
||> Transactions tab. It now
||correctly filters the list
||of transactions - only
||transactions with an
||outstanding amount greater
||than zero are shown ("Show
||all transactions" clears
||the filter). Before this
||fix, clicking on the link
||didn't do anything and
||didn't filter any of the
||transactions as expected.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|Signed Off |Passed QA --- Comment #10 from Jonathan Druart --- No UNIMARC user in the QA team, trusting author and testers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 Jonathan Druart changed: What|Removed |Added Status|Signed Off |BLOCKED CC||jonathan.druart+koha@gmail. ||com --- Comment #9 from Jonathan Druart --- Blocked by bug 23291. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23291] Patron batch modification based on SMS number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #34 from Jonathan Druart --- Alex, what do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #1) > There is no occurrence of Date::Calc in tools/cleanborrowers.pl Right, sorry for that. I read 'the cronjob' on bug 29843 and jumped to file this one so we don't forget, but didn't check if the file was the right one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 130334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130334=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26129] Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #34 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #26) > (In reply to Marcel de Rooy from comment #6) > > Just reading diagonally, sounds like yet another configuration to manage? > > Moving all preferences into it would be a dramatic refactoring that we > > probably do not finish? > > I agree. I will probably abandon this bug. Hum... What's next here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Jonathan Druart changed: What|Removed |Added Attachment #130160|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 130333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130333=edit Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > (In reply to Katrin Fischer from comment #8) > > Also I wonder if we could avoid querying the record twice, but someone else > > might be better suited to comment on that: > > > > my $record = GetAuthority($authid); > > my $authobj = Koha::Authorities->find($authid); > > Agreed, that certainly could be replaced with > > my $authority = Koha::Authorities->find($authid); > my $record = $authority->record; What about this, Thibaud? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What|Removed |Added Summary|Remove Date::Calc use in|Remove Date::Calc use in |cleanborrowers.pl |batch_anonymize.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #87 from Martin Renvoize --- We wrote some documentation for this, but bugzilla doesn't want to allow me to attach it.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30042] Remove Date::Calc use in cleanborrowers.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #1 from Jonathan Druart --- There is no occurrence of Date::Calc in tools/cleanborrowers.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #40 from Jonathan Druart --- +my $patron = Koha::Patrons->find( $borrowernumber );; Trailing semi-colon here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #86 from Martin Renvoize --- Created attachment 130332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130332=edit Bug 28854: (follow-up) Fix rebase re-indroduction of .json The API schema's all changed to .yaml but a rebase here re-introduced the .json links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #85 from Martin Renvoize --- Created attachment 130331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130331=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #84 from Martin Renvoize --- Created attachment 130330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130330=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #83 from Martin Renvoize --- Created attachment 130329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130329=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #82 from Martin Renvoize --- Created attachment 130328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130328=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #81 from Martin Renvoize --- Created attachment 130327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130327=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #80 from Martin Renvoize --- Created attachment 130326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130326=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #79 from Martin Renvoize --- Created attachment 130325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130325=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #78 from Martin Renvoize --- Created attachment 130324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130324=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Test plan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #77 from Martin Renvoize --- Created attachment 130323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130323=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #76 from Martin Renvoize --- Created attachment 130322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130322=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #75 from Martin Renvoize --- Created attachment 130321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130321=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #74 from Martin Renvoize --- Created attachment 130320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130320=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #73 from Martin Renvoize --- Created attachment 130319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130319=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #72 from Martin Renvoize --- Created attachment 130318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130318=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #71 from Martin Renvoize --- Created attachment 130317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130317=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #70 from Martin Renvoize --- Created attachment 130316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130316=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #69 from Martin Renvoize --- Created attachment 130315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130315=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #68 from Martin Renvoize --- Created attachment 130314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130314=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #67 from Martin Renvoize --- Created attachment 130313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130313=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29385] Add missing cash register support to SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Jonathan Druart changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |jonathan.druart+koha@gmail. |.com|com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- What about batch checkouts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30041] Add MARC and Card preview to biblio search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 Lucas Gass changed: What|Removed |Added Attachment #130251|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 130312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130312=edit Bug 30041: Add MARC and Card preview to biblio search results This enhancement adds MARC preview and Card preview links to the normal catalogue search results. To test: 1) Do a catalogue search in the staff client (use the 'Search the catalogue' tab, do not do a search that searches both the catalogue and the reservoir). 2) Notice there is no quick way to view the MARC and Card previews for each search result. 3) Apply patch and refresh the search results page 4) Confirm there are now links for both the MARC and Card previews 5) Confirm these popups show details of the records as expected Sponsored-by: Education Services Australia SCIS Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30041] Add MARC and Card preview to biblio search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #21 from Jonathan Druart --- Created attachment 130311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130311=edit Bug 29570: Simplify for loop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #20 from Jonathan Druart --- Created attachment 130310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130310=edit Bug 29570: Enable sorting orders by summary This patch enables (on receiving) sorting orders by the summary column. It needs the previous patches to work. Title is given more precedence as expressed by users on the bug report. Which, by the way, makes sense. To test: 1. Create a basket 2. Create orders 3. Close basket 4. Receive shipment 5. Enter invoice information => SUCCESS: You should see your pending orders => FAIL: Verify the 'Summary' column is not sortable 7. Apply this patches 8. Restart Plack 9. Reload the page => SUCCESS: Can sort by the summary column 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570
--- Comment #19 from Jonathan Druart ---
Created attachment 130309
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130309=edit
Bug 29570: Fix sorting orders by biblioitems columns
The API representation of Koha::Biblio objects includes the
biblioitems.* columns too. This proved problematic as queries had to get
translated so they work (i.e. if a query passes q={"biblio.ean":"123%"}
then the query needs to be tweaked so biblio.ean is translated into
biblio.biblioitem.ean. This is solved, locally, in the controller.
But sorting needs the same kind of tweak, and it was missing. This patch
solves that by doing a similar conversion.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/acquisitions_orders.t
=> FAIL: Tests fail, searching on a 'biblioitems' column generates a 500
error.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! We can sort on those fields
5. Sign off :-D
Note: you will notice the tests only cover sorting by ISBN. I consider
it enough as sorting is a DB problem, and we only want to know if the
generated ORDER BY is valid for the underlying query, and MySQL would
complain if it wasn't the case.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Lucas Gass
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Jonathan Druart changed: What|Removed |Added Attachment #130125|0 |1 is obsolete|| Attachment #130126|0 |1 is obsolete|| Attachment #130127|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart --- Created attachment 130308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130308=edit Bug 29570: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #17 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #14) > (In reply to Jonathan Druart from comment #12) > > Tomas, shouldn't we deal with all biblioitem's attributes? > > It is your fault :P > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115963 Sorry, misunderstood what you were referring to. Fair enough then! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Andy Boze changed: What|Removed |Added CC||boz...@nd.edu --- Comment #1 from Andy Boze --- I especially agree with Andrew Fuerste-Henry that a unique patron attribute might be used at checkout on a selfcheck. We will soon find ourselves in that situation. My university will enable students to use up to three smart devices (phones and watches) instead of their barcoded ID cards. Each smart device will have its own unique ID number. It will be important that students be able to use those devices at our self-check stations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #27 from Jonathan Druart --- (In reply to Jonathan Druart from comment #26) > (In reply to Marcel de Rooy from comment #19) > > (In reply to Jonathan Druart from comment #0) > > > We must have a generic full_message method in the Koha::Exceptions base > > > class to display all the info we have about the exception. > > > The current state is bad as we are displaying the "description" of the > > > exception but it does not contain useful information. > > > > Exception 'Koha::Exception::TestMR' thrown 'Something went wrong!' with > > status => x, type => HASH(0x5653eb753278) > > > > How useful is HASH(0x5653eb753278) ? > > We should call Dumper if it's a struct. Marcel, did you find an example in the code or it's theoretical? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #26 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #19) > (In reply to Jonathan Druart from comment #0) > > We must have a generic full_message method in the Koha::Exceptions base > > class to display all the info we have about the exception. > > The current state is bad as we are displaying the "description" of the > > exception but it does not contain useful information. > > Exception 'Koha::Exception::TestMR' thrown 'Something went wrong!' with > status => x, type => HASH(0x5653eb753278) > > How useful is HASH(0x5653eb753278) ? We should call Dumper if it's a struct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #25 from Jonathan Druart --- IMO we are going too far here. Please provide patches on follow-up bug reports instead. I don't understand why the "Virtualshelves exceptions" part is in Koha::Exception::Generic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #21 from Martin Renvoize --- All works as described, new allowance hard coded. Everything works here and QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What|Removed |Added Attachment #130089|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 130307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130307=edit Bug 28576: Update the maximum size of an image. This patch modifies the maximum size of a patron's image, from 500KB to 2MB. Also, in Home/Patrons/anyPatron, when you try to add an image to a patron, you can now see the supported file types AND the maximum size. The following places are affected by this patch: - Home/Patrons/anyPatron - Home/Tools/Upload patron images - Home/Tools/Patron card creator/Images To test: 1)Search for any patron and go to his page. 2)Hover over the image area on the left and click on the "Add" button. 3)Notice that the message above the choose file button only specifies file types without the maximum size. 4)Add an image bigger than 500KB. 5)Nothing happens. (This is because the maximum size is 5KB) 6)Apply the patch. 7)Repeat steps from 1 to 3. 8)Notice that the message now includes the maximum size. 9)Add an image bigger than 500KB, but smaller than 2MB. 10)The image is succesfully uploaded. 11)Add an image bigger than 2MB. 12)Nothing happens. (The maximum size is now 2MB) 13)Repeat the steps 9 to 12 in "Home/Tools/Upload patron images" and "Home/Tools/Patron card creator/Images". 14)Notice that the maximum size is updated. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What|Removed |Added Attachment #130088|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 130306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130306=edit Bug 28576: Add patron image in patron detail section does not specify image size limit When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29966] SCO Help page passes flags while not needing authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29966 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Trivial patch, no breakage, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29966] SCO Help page passes flags while not needing authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29966 Martin Renvoize changed: What|Removed |Added Attachment #129921|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 130305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130305=edit Bug 29966: Dont pass authnotrequired true and flags together Test plan: Logout in OPAC. Goto sco help page. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize --- Nice one! Works as described, code is good and covered by tests.. QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What|Removed |Added Attachment #130172|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 130304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130304=edit Bug 27424: Clarify logic This patch simplifies how Koha::SMTP::Servers->get_default is written, to help readability. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What|Removed |Added Attachment #130171|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 130303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130303=edit Bug 27424: (QA follow-up) Make Koha::SMTP::Server->store deal with defaults This patch makes the ->store method take care of setting the server as the only default one. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => SUCCESS: Tests pass! 3. The UI keeps working as it should. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
