[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Bug 29806 depends on bug 29804, which changed state. Bug 29804 Summary: Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED CC||vic...@tuxayo.net Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo --- What would the scenario to trigger this bug? The fix rely on bug 27131 which isn't in 20.11.x so that make things hard. (can't backport 27131) And raise the question of the 20.11.x being affected or not. So, can't backport to 20.11.x. If there is an interest in having this backported, please confirm validity or help to check for it as a first step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #9 from Katrin Fischer --- I believe only the publisher's name in this case? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #20 from Katrin Fischer --- Hi Bill, thx for providing a patch! Jonathan provided you some good feedback on things that need to be fixed, please let us know if something is not clear! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29919] Elasticsearch missing alias pl for place-of-publication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29919 Fridolin Somers changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #69 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. (congrats on closing a 13 years old ticket!!!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||barbara.johnson@bedfordtx.g ||ov --- Comment #3 from Barbara Johnson --- Very nice feature! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 ByWater Sandboxes changed: What|Removed |Added Attachment #129205|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 130905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130905=edit Bug 29824: Allow editing of quick spine labels To test: 1. Apply patch 2. Go to the quick spine label tool and enter a barcode of an item with a itemcallnumber 3. Notice the 'Edit this label' button at the bottom of the page, click it 4. Edit the itemcallnumber in some way: add some line breaks, remove some, insert some new characters, remove some characters. 5. You can now print the label with your edits. Note: This changes nothing in the database, if you relaod the same item/itemcallnumer it will have returned to its original form Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30129] 500 error when search reports by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30129 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30129] 500 error when search reports by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30129 ByWater Sandboxes changed: What|Removed |Added Attachment #130825|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 130904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130904=edit Bug 30129: remove the third required date that was causing 500 error This problem appeared because of this commit: Bug 14435 Add the ability to store result's report cf9031711282f4be23e4a639797d0fd178940e1f This patch fixes it by removing the third $date that wasn't removed back then. To reproduce: 1) Head over to Reports page. 2) Search for report by date. It should cause 500 error. 3) Apply the patch. 4) Repeat the search again, it should be working now. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov Status|Needs Signoff |Signed Off --- Comment #6 from Barbara Johnson --- Worked very well. I tested it on opac-search.pl, opac-detail.pl and various patrons pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 ByWater Sandboxes changed: What|Removed |Added Attachment #130897|0 |1 is obsolete|| --- Comment #5 from ByWater Sandboxes --- Created attachment 130903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130903=edit Bug 30136: [DO NO PUSH] CSS styling for OPAC This patch is for easy testing of the CSS to apply on button. If feature is validated this must be written in opac SCSS file. Maybe this sould only appear on large screens. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 ByWater Sandboxes changed: What|Removed |Added Attachment #130896|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 130902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130902=edit Bug 30136: Add back to top button to OPAC Like in many websites, when scrolling down the page make a button appear to go back to top. This can be very useful specially in search results page. This patch adds to OPAC using Javascript a button with id "backtotop". Button appears when 300 pixels from top are hidden. This value may be adapted. Test plan 1) Go to OPAC 2) Perform a search with many results 3) Scroll down => Back to top button appears 4) Manually scroll back to top => Button disappears 5) Scroll down and click on Back to top button => You get to top Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- Which workflow does this break or triggers a warning? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #11 from Victor Grousset/tuxayo --- Right, I don't understand what is it about. But it looks like something not covered by tests and basic workflow. I'll ask there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #10 from Barbara Johnson --- Created attachment 130901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130901=edit wimpy kid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #9 from Barbara Johnson --- Created attachment 130900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130900=edit acq_ordered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #8 from Barbara Johnson --- Created attachment 130899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130899=edit acq_basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27817] Enhance display of 245 fields throughout Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27817 --- Comment #7 from Barbara Johnson --- Here's what I have found so far in my testing: On basket.pl the title and subtitle display correctly in the 245|a and 245|b. However, it is also incorrectly including series data from the 490|a and 490|v. See the attachment acq_basket.png. The info highlighted in yellow is coming from the 490 tag. On ordered.pl only data from the 245|a is displaying. See the attachment acq_ordered.png. Each title that has been highlighted has a subtitle in the 245|b but it is not displaying. On orderreceive.pl, parcel.pl and invoice.pl the 245|a and 245|b display correctly. Actually parcel.pl is the the place the extra info from the 245|b would be most useful. I attached a screenshot (which_wimpy_kid_is_it.png) showing the display a staff person sees when receiving. In the example all four books are different wimpy kid titles, but without the subtitle displayed it's not readily apparent which is the correct book to receive. Staff then has to start looking at the ISBNS which is more time consuming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #10 from Fridolin Somers --- Bug 22520 is not a mandatory dependency ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #7 from Fridolin Somers ---
(In reply to Jonathan Druart from comment #5)
> +if (version->parse($self->{es_version}) >= version->parse('7.0.0')) {
>
> It's going to be mess very quickly if we are starting to add conditions on
> the version. Cannot we avoid that?
+1
This may impact a lot search performance.
Or we should add a cache on parsed ES version.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|22.05.00,21.11.03,21.05.11 |22.05.00,21.11.03,21.05.11, released in||20.11.15 --- Comment #12 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 --- Comment #3 from Fridolin Somers --- Created attachment 130898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130898=edit Screenshot with patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 Fridolin Somers changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 --- Comment #2 from Fridolin Somers --- Created attachment 130897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130897=edit Bug 30136: [DO NO PUSH] CSS styling for OPAC This patch is for easy testing of the CSS to apply on button. If feature is validated this must be written in opac SCSS file. Maybe this sould only appear on large screens. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 --- Comment #1 from Fridolin Somers --- Created attachment 130896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130896=edit Bug 30136: Add back to top button to OPAC Like in many websites, when scrolling down the page make a button appear to go back to top. This can be very useful specially in search results page. This patch adds to OPAC using Javascript a button with id "backtotop". Button appears when 300 pixels from top are hidden. This value may be adapted. Test plan 1) Go to OPAC 2) Perform a search with many results 3) Scroll down => Back to top button appears 4) Manually scroll back to top => Button disappears 5) Scroll down and click on Back to top button => You get to top -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 Fridolin Somers changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 Fridolin Somers changed: What|Removed |Added Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] New: Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 Bug ID: 30136 Summary: Add back to top button when scrolling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Like in many websites, when scrolling down the page make a button appear to go back to top. This can be very useful specially in search results page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- the span with typeOf Organization is changed after this patch, I am not sure what is supposed to be inside of that span - just the 'a'? or the 'a' and 'b'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #31 from Nick Clemens --- This works well, I do wonder if there should be a public holds API to allow the user to change their own holds, but the modal works nicely. Two issues: The test should be in their own subtest as they are covering a new subroutine The opac-modrequest.pl script needs to check that the hold belongs to the signed in user, it is possible with these patches to alter another users hold via URL manipulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Victor Grousset/tuxayo changed: What|Removed |Added CC||kevin.car...@ub.lu.se --- Comment #9 from Victor Grousset/tuxayo --- With Bug 25669, Bug 25684, Bug 27770 and Bug 28610 applied the tests pass[1] on ES7 and searching works and cataloguing indexes correctly a new or modified title. So that would be it? :D Anything else to test? Or these bugs reaching master and being backported will be enough to claim ES7 support? [1] minus some local failures I also have on master without any patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Nick Clemens changed: What|Removed |Added Attachment #130873|0 |1 is obsolete|| --- Comment #37 from Nick Clemens --- Created attachment 130895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130895=edit Bug 28782: (QA follow-up) Fix missing filter Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Nick Clemens changed: What|Removed |Added Attachment #130872|0 |1 is obsolete|| --- Comment #36 from Nick Clemens --- Created attachment 130894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130894=edit Bug 28782: (QA follow-up) Bug 29844 follow-up Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Summary|Pagination broken on|Pagination broken on |pickup_location routes when |pickup_locations routes |AllowHoldPolicyOverride=1 |when ||AllowHoldPolicyOverride=1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Pagination broken on pickup_location routes when AllowHoldPolicyOverride=1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Summary|Incorrect list of libraries |Pagination broken on |returned when more |pickup_location routes when |libraries than |AllowHoldPolicyOverride=1 |RESTdefaultPageSize and | |AllowHoldPolicyOverride | |enabled | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #130889|0 |1 is obsolete|| --- Comment #15 from Andrew Fuerste-Henry --- Created attachment 130893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130893=edit Bug 30133: Fix pagination in /biblios/:bibio_id/pickup_locations This patch does the same thing we did for items on the previous patch, but for biblios. The tests are almost the same as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry https://bugs.koha-community.org/show_bug.cgi?id=30113 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #130888|0 |1 is obsolete|| --- Comment #14 from Andrew Fuerste-Henry --- Created attachment 130892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130892=edit Bug 30133: Simplify code This patch simplifies the code, and also fixes a problem with branchcode comparisson failing, highlighted when running the tests To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail. Notably: - Link header pagination is wrong - X-*Total-Count headers have two values (dupicated) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Andrew Fuerste-Henry https://bugs.koha-community.org/show_bug.cgi?id=30113 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #130887|0 |1 is obsolete|| --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 130891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130891=edit Bug 30133: Avoid calling c->objects->search twice Calling this twice sets double pagination headers, which messes up the page for the requests and retrieves on ly the end of the list This patch simply avoids a doulbe call TO DO: must implement same for Biblio->pickup_locations and cover with tests this also returns all as needing override Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry https://bugs.koha-community.org/show_bug.cgi?id=30113 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #130886|0 |1 is obsolete|| --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 130890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130890=edit Bug 30133: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry https://bugs.koha-community.org/show_bug.cgi?id=30113 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 130889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130889=edit Bug 30133: Fix pagination in /biblios/:bibio_id/pickup_locations This patch does the same thing we did for items on the previous patch, but for biblios. The tests are almost the same as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 130888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130888=edit Bug 30133: Simplify code This patch simplifies the code, and also fixes a problem with branchcode comparisson failing, highlighted when running the tests To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail. Notably: - Link header pagination is wrong - X-*Total-Count headers have two values (dupicated) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 130887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130887=edit Bug 30133: Avoid calling c->objects->search twice Calling this twice sets double pagination headers, which messes up the page for the requests and retrieves on ly the end of the list This patch simply avoids a doulbe call TO DO: must implement same for Biblio->pickup_locations and cover with tests this also returns all as needing override Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 130886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130886=edit Bug 30133: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130885|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130884|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130883|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 130885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130885=edit Bug 30133: Simplify code This patch simplifies the code, and also fixes a problem with branchcode comparisson failing, highlighted when running the tests To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => FAIL: Tests fail. Notably: - Link header pagination is wrong - X-*Total-Count headers have two values (dupicated) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 130884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130884=edit Bug 30133: Avoid calling c->objects->search twice Calling this twice sets double pagination headers, which messes up the page for the requests and retrieves on ly the end of the list This patch simply avoids a doulbe call TO DO: must implement same for Biblio->pickup_locations and cover with tests this also returns all as needing override Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 130883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130883=edit Bug 30133: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 --- Comment #4 from Martin Renvoize --- Might be an unpopular view.. but don't we already pull in moment.js for other date manipulations.. so couldn't we use https://momentjs.com/docs/#/displaying/difference/ to get a rather accurate result? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130855|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- I added a bit, could use another QA eye -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #7 from Nick Clemens --- Created attachment 130882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130882=edit Bug 29965: (follow-up) Use a new class for the preview With previous patches everythign worked, however, clicking the heading in authority search results now launched the preview instead of taking you to the authority details This patch uses a new class to launch the modal and conditionally applies it to authority results as we expect different behaviours when searching from the popup vs authority module To test: 1 - Repeate previous tests, confirm they pass 2 - Search for authorities in the authority module 3 - COnfirm clicking on heading takes you to detail page for authority Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #6 from Nick Clemens --- Created attachment 130881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130881=edit Bug 29965: (follow-up) Move repeated JS to its own file Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Nick Clemens changed: What|Removed |Added Attachment #130635|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 130880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130880=edit Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30130] Allow setting EDI type at the vendor level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30130] Allow setting EDI type at the vendor level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Martin Renvoize changed: What|Removed |Added CC||jon.tur...@ptfs-europe.com, ||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added CC||jon.tur...@ptfs-europe.com, ||jonathan.field@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 --- Comment #1 from Martin Renvoize --- Created attachment 130879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130879=edit Bug 30135: Add EdifactLSQ mapping preferenec This patch adds a new system preference, EdifactLSQ, to allow configuration of the ambiguous LSQ, sequence code, field included in the EDIFACT specifications. Originally the field was hard coded to map to 'location', but as per the specification it could have been mapped to 'ccode'. From the specification: A code or other designation which identifies stock which is to be shelved in a specified sequence or collection. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27641] Action buttons on borraccount.pl should allow notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27641 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- Bug 23674 asks for the ability to click on any accountlines entry and edit its note. Am I correct that what you're suggesting is to add an editable notes field into the interface as part of each of these processes? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Nick Clemens changed: What|Removed |Added Attachment #130662|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 130878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130878=edit Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #3 from Nick Clemens ---
get_age('1979-02-17') = 43
get_age('1979-02-18') = 43
get_age('1979-02-19') = 43 XXX Today is 2022-02-18 - Not birthday yet! Stop
calling me old!!!
get_age('1979-02-20') = 42
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29962] Table of items on item edit page missing columns button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962
Nick Clemens changed:
What|Removed |Added
Attachment #130584|0 |1
is obsolete||
--- Comment #5 from Nick Clemens ---
Created attachment 130877
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130877=edit
Bug 29962: (bug 27526 follow-up): Fix columns button on item list
The "Columns" button on the item list view has been broken (hidden) by
bug 27526.
"column_name" was removed from the item_header_loop:
-if ( $kohafield && $kohafield =~ /items.(.+)/ ) {
-$header_value{column_name} = $1;
-}
We can still access the attribute name using 'attribute' however.
The difference is that non-mapped subfield will have an "attribute", but
there is a net to prevent a crash in columns_settings.inc:
12 var named_id = $( 'thead th[data-colname="' + this.columnname +
'"]', selector ).index( selector + ' th' );
13 var used_id = dt_parameters.bKohaColumnsUseNames ? named_id :
counter;
14 if ( used_id == -1 ) return;
We should simply pass attribute.
Test plan:
Create a non-mapped subfield (952$k)
Edit an item, add a value for k
On the item table at the top of the edit form notice that the "Columns"
button is back and that it's working correctly.
Note that 'k' cannot be hidden (may be considered as a bug, but it's not
a regression).
Signed-off-by: Lucas Gass
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29962] Table of items on item edit page missing columns button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #11 from Nick Clemens --- Created attachment 130876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130876=edit Bug 29136: (QA follow-up) missing filters Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #10 from Nick Clemens --- Created attachment 130875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130875=edit Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Nick Clemens changed: What|Removed |Added Attachment #130245|0 |1 is obsolete|| Attachment #130246|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 130874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130874=edit Bug 29136: Ajaxify the patron search when placing a hold Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #35 from Nick Clemens --- Created attachment 130873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130873=edit Bug 28782: (QA follow-up) Fix missing filter Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #34 from Nick Clemens --- Created attachment 130872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130872=edit Bug 28782: (QA follow-up) Bug 29844 follow-up Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #33 from Nick Clemens --- Created attachment 130871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130871=edit Bug 28782: Fix cancel holds in bulk See also bug 29969. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #32 from Nick Clemens --- Created attachment 130870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130870=edit Bug 28782: Fix link when placing a hold for a patron from patron list Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #31 from Nick Clemens --- Created attachment 130869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130869=edit Bug 28782: (follow-up) Pass real array to query_form() It excepts to receive a real array and not a list, in order to be able to generate the query parameters. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Nick Clemens changed: What|Removed |Added Attachment #129939|0 |1 is obsolete|| Attachment #129940|0 |1 is obsolete|| Attachment #130663|0 |1 is obsolete|| Attachment #130664|0 |1 is obsolete|| --- Comment #30 from Nick Clemens --- Created attachment 130868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130868=edit Bug 28782: Use query param list instead of splitting elements using '/' This removes the need to handle single and multiple cases separately, thus removing bunch if-else cases and simplifying our code. This coding style is also in line with our other .pl scripts. To test: 1) Make sure placing a hold still works from the following pages: /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX /cgi-bin/koha/catalogue/search.pl?q=a /cgi-bin/koha/virtualshelves/shelves.pl?op=view= /cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron there and through the clubs.pl create a hold to a bib) Signed-off-by: Hayley Pelham Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29803] Local cover images don't show in detail page, but only in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #22 from Nick Clemens --- Created attachment 130867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130867=edit Bug 29803: Do not wait for the images more than 5 seconds In case of the previous bug, the page was calling the callback function every 100ms, endlessly. We should add a test to prevent future similar problem. Test plan: Remove the previous patch "Prevent local cover image to be hidden if Coce is enabled" Recreate the test plan => You should see the local image displayed after 5 seconds, and a log in the JS console Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29803] Local cover images don't show in detail page, but only in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Nick Clemens changed: What|Removed |Added Attachment #130579|0 |1 is obsolete|| Attachment #130580|0 |1 is obsolete|| --- Comment #21 from Nick Clemens --- Created attachment 130866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130866=edit Bug 29803: Prevent local cover image to be hidden if Coce is enabled If Coce is enabled by no image are returned by the service, then no other image will be displayed (actually un-hidden) The getURL is returning early if no image is returned by the service and the "done" flag is never set. Test plan: Add a local cover image to a bibliographic record (ktd biblionumber=14 is good) Set CoceHost = http://coce.bywatersolutions.com Select all CoceProviders Enable OpacCoce => If no image is returned by Coce then the local image should be displayed anyway Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29803] Local cover images don't show in detail page, but only in results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 --- Comment #6 from Jonathan Druart --- I've removed the condition, and the tests are passing under ES6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 --- Comment #5 from Nick Clemens --- Created attachment 130865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130865=edit Bug 30089: (bug 29844 follow-up) Fix placing holds - OPAC The method Koha::AuthorisedValues->authorised_value is not covered by tests! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29969] Cannot update hold list after holds cancelled in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
||com,
||n...@bywatersolutions.com
Severity|enhancement |normal
Assignee|koha-b...@lists.koha-commun |kevin.car...@ub.lu.se
|ity.org |
--- Comment #5 from Jonathan Druart ---
+if (version->parse($self->{es_version}) >= version->parse('7.0.0')) {
It's going to be mess very quickly if we are starting to add conditions on the
version. Cannot we avoid that?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 Emmanuel Bétemps changed: What|Removed |Added CC||e.bete...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #6 from Jonathan Druart --- Should this be enforced at lower (Koha:: module) level as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30133] Incorrect list of libraries returned when more libraries than RESTdefaultPageSize and AllowHoldPolicyOverride enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #4 from Nick Clemens --- *** Bug 30126 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
