[Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 Fridolin Somers changed: What|Removed |Added Blocks||7923 CC||fridolin.som...@biblibre.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin Somers changed: What|Removed |Added Depends on||30085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 [Bug 30085] Improve performance of CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30148] Pipe separated online resource links are hard to customize (staff interface)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30148 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30151] branchcode should always be in PatronSelfRegistrationBorrowerMandatoryField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30151 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19360] Give items URL a link text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #31 from David Cook --- Locally, we have a few customizations for this one, but the one typically used is to just render "Link to resource" instead of the URI as the link text. (The main complaint we got was just that long/complicated URLs are annoying/ugly.) (Also added support for URLLinkText, and the option to use the item's item type as the link text.) It's a lightweight touch that doesn't require any schema changes, although it wouldn't be as full featured as this one. But just a thought. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19360] Give items URL a link text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360
--- Comment #30 from David Cook ---
Comment on attachment 70968
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70968
Bug 19360 - Added missing atomicupdate SQL file
Review of attachment 70968:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19360=70968)
-
:::
installer/data/mysql/atomicupdate/Bug-19360_Add_Link_text_field_to_items.sql
@@ +9,5 @@
> +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0,
> 'IR', NULL),
> +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0,
> 'KT', NULL),
> +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0,
> 'SER', NULL),
> +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0,
> 'SR', NULL),
> +(952, 'k', 'Link text', 'Link text', 0, 0, 'items.link_text', 10, 1, 0,
> 'VR', NULL)
Good call. I did some digging around and it looks like once upon a time 952$k
did exist.
git log --follow --name-only --
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql
git show f8e9fb6445dadbdef91e13a253c9c6bcb75e0eec
+INSERT INTO `marc_subfield_structure` VALUES ('952', 'k', 'Call number
(similar to 852 $k $h $i $m combined)', 'Call number', 0, 0,
'items.itemcallnumber', 10, '', '', NULL, 0, 0, '', '', '');
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #2 from Aleisha Amohia --- I've attached this patch on behalf of Adam Styles, who is the assignee. The author line on the patch is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Aleisha Amohia changed: What|Removed |Added Text to go in the||This patch adds a check for release notes||both mandatory and ||important fields when ||validating bibliographic ||records during cataloguing. Assignee|koha-b...@lists.koha-commun |adam.sty...@esa.edu.au |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #11 from Katrin Fischer --- (In reply to Nick Clemens from comment #10) > (In reply to Katrin Fischer from comment #9) > > I think the confusing bit could be it having "independentbranches" when it > > doesn't depend on the pref itself. But we also have > > IndependentBranchesPatronModifications that doesn't depend on it. So the > > situation is not really clear. > > > > Maybe: AllowStaffChangeLoggedInBranch ? > > > > (too long?) > > The idea with this pref, and IndependentBranchesPatronModifications is that > they were once a part of 'IndependentBranches' > > The goal is to make that preference more granular and allow libraries to set > parts of it without others, and keeping them all related with > 'IndependentBranches' in the name - possibly it could be a category for the > prefs? I like the idea of making it a category and we should maybe note in the description it works independently from Independentbranches? I am ok with the pref name as is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #1 from Aleisha Amohia --- Created attachment 131030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131030=edit Bug 30159: Fix Check() to validate both mandatory and important fields This patch adds a check for both mandatory and important fields when validating bibliographic records during cataloguing. To test: 1. Go to Admin -> Biblio frameworks. View the MARC structure of your default framework. 2. Search for tag 082. Edit the subfields for this tag. 3. Check the 'important' checkbox for subfield a and Save. 4. Go to add or edit a new biblio record under Cataloguing. 5. Ensure the 082$a field is empty and hit Save. 6. Notice the confirmation pop-up is an unreadable display of HTML. 7. Click Cancel on the pop-up box. 8. Apply the patch and refresh the editor page. 9. Ensure the 082$a field is empty and hit Save. 10. Notice the confirmation pop-up is more helpful this time. Click Cancel on the pop-up box. 11. Notice the 082$a field is displayed at the top of the page as an important field that is missing information. Use the 'go to field' link and confirm this works as expected. 12. Leave 082$a empty and hit Save. 13. This time click OK on the confirmation pop-up. Confirm you are able to save your record as normal. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Aleisha Amohia changed: What|Removed |Added Blocks||30159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 [Bug 30159] Fix display of validation of important fields when biblio cataloguing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Aleisha Amohia changed: What|Removed |Added Depends on||28694 Status|NEW |Needs Signoff Patch complexity|--- |Small patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a static message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 --- Comment #10 from Katrin Fischer --- (In reply to Kevin Carnes from comment #9) > (In reply to Jonathan Druart from comment #6) > > I've removed the condition, and the tests are passing under ES6. > > Great, ES6 supports track_total_hits. That makes it much easier. Not sure someone told you yet, but great to see these updates for Elasticsearch 7 going on - thx Kevin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30159] New: Fix display of validation of important fields when biblio cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Bug ID: 30159 Summary: Fix display of validation of important fields when biblio cataloguing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 131029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131029=edit Popup box showing HTML dump of validation for important fields Fields that are marked as important in a biblio framework will trigger a confirmation box to the cataloguer if not filled, asking if they would still like to save. Since Bug 28694, the validation for mandatory fields is nice and pretty, but it appears the validation for important fields was not tested. The confirmation pop-up now spits out the HTML markup and is unreadable. This should be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30158] New: Add a QR code for the list of results when doing a research on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30158 Bug ID: 30158 Summary: Add a QR code for the list of results when doing a research on the OPAC Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: noemie.lab...@collecto.ca QA Contact: testo...@bugs.koha-community.org Would it be possible to get a QR code for a list of results the same way we can scan one when we're on the details page for a single record ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30157] Make hold notes visible from the holds tab in patrons account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30157 Noémie Labine changed: What|Removed |Added Summary|Make hold notes visible |Make hold notes visible |from the holds tab in |from the holds tab in |patrons record |patrons account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30157] Make hold notes visible from the holds tab in patrons record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30157 --- Comment #1 from Noémie Labine --- Created attachment 131028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131028=edit Holds tab from document's record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30157] New: Make hold notes visible from the holds tab in patrons record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30157 Bug ID: 30157 Summary: Make hold notes visible from the holds tab in patrons record Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: noemie.lab...@collecto.ca QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 131027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131027=edit Patron's account When there's a note on an hold, this note is not visible from the patron's account. You need to go to the holds tab in the document's record to see the note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30156] New: asterisk is needed before and after barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30156 Bug ID: 30156 Summary: asterisk is needed before and after barcode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: bugzi...@mediapipe.de QA Contact: testo...@bugs.koha-community.org Created attachment 131026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131026=edit Asterisk added before and after barcode An asterisk is needed before and after barcode to show Code39 barcode correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14393] Add collection code filter to inventory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Nick Clemens changed: What|Removed |Added Attachment #44772|0 |1 is obsolete|| --- Comment #27 from Nick Clemens --- Created attachment 131025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131025=edit Bug 14393 - Add collection code filter to inventory This patch adds the ability to do inventory by collection. _TEST PLAN_ Before applying: 1) Go to "Tools > Inventory/stocktaking" 2) Note that there is no "Collection code:" option Optionally: 2b) You can create a Barcode file with a single barcode 2c) Don't select anything from "Select items you want to check" (or filter if you know how to filter to make it faster... doesn't matter) 2d) Click "Submit" at the bottom of the screen 2e) Note that there is no "Collection code" column in the screen output or CSV output (ie with/without the "Export to CSV file" box ticked before submitting) Apply the patch. After applying: 3) Note that there is a "Collection code" filter on the main inventory screen 4) Create a Barcode file with a single barcode for an item with a collection and upload it using the "Choose file" button. 5) Select that item's collection code from the "Collection code" filter 6) Click "Submit" 7) Note that the screen output and the CSV output contains a "Collection code" column (ie with/without the "Export to CSV file" box ticked before submitting) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14393] Add collection code filter to inventory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #15 from Jonathan Druart --- Try: deb http://debian.koha-community.org/koha stable main jessie then apt update; apt upgrade -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #14 from Father Vlasie --- And I have installed the missing Perl modules but the problem persists... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #13 from Father Vlasie --- less /etc/apt/sources.list.d/koha.list contains: deb http://debian.koha-community.org/koha stable main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #12 from Father Vlasie --- Yes it is Debian 9. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27510] Download the report in HTML format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #18 from Katrin Fischer --- I still quite like the idea of this. I think it would be helpful for staff users and others that have no access to the Reports module, but could profit from the links in an HTML export file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19360] Give items URL a link text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30155] We shouldn't calculate get_items_that_can_fill when we don't have any holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30155 --- Comment #1 from Nick Clemens --- Created attachment 131024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131024=edit Bug 30155: Don't get items that can fillholds if there are no holds This makes two changes: 1 - We no longer call get_items_that_can_fill if there are no holds 2 - The subroutine will return an empty Koha::Items object if there are no holds passed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30155] We shouldn't calculate get_items_that_can_fill when we don't have any holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30155 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30155] New: We shouldn't calculate get_items_that_can_fill when we don't have any holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30155 Bug ID: 30155 Summary: We shouldn't calculate get_items_that_can_fill when we don't have any holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com This breaks the 'Holds to pull' report in 21.05.09 if there are no holds "Fixed" by bug 3142 in 21.05.11 and master The problem is essentially that calculation of @bibs_or_items can be empty if no holds are passed, so our SQL Abstract call ends up with an emptpy -or block, which in turn leads to our where beginning with "AND" DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'AND `itemlost` = '0' AND `itemnumber` NOT IN ( '156269' ) AND 1=1 AND `notforloa' at line 1 [for Statement "SELECT `me`.`itemnumber`, `me`.`biblionumber`, `me`.`biblioitemnumber`, `me`.`barcode`, `me`.`dateaccessioned`, `me`.`booksellerid`, `me`.`homebranch`, `me`.`price`, `me`.`replacementprice`, `me`.`replacementpricedate`, `me`.`datelastborrowed`, `me`.`datelastseen`, `me`.`stack`, `me`.`notforloan`, `me`.`damaged`, `me`.`damaged_on`, `me`.`itemlost`, `me`.`itemlost_on`, `me`.`withdrawn`, `me`.`withdrawn_on`, `me`.`itemcallnumber`, `me`.`coded_location_qualifier`, `me`.`issues`, `me`.`renewals`, `me`.`reserves`, `me`.`restricted`, `me`.`itemnotes`, `me`.`itemnotes_nonpublic`, `me`.`holdingbranch`, `me`.`timestamp`, `me`.`location`, `me`.`permanent_location`, `me`.`onloan`, `me`.`cn_source`, `me`.`cn_sort`, `me`.`ccode`, `me`.`materials`, `me`.`uri`, `me`.`itype`, `me`.`more_subfields_xml`, `me`.`enumchron`, `me`.`copynumber`, `me`.`stocknumber`, `me`.`new_status`, `me`.`exclude_from_local_holds_priority` FROM `items` `me` WHERE ( ( AND `itemlost` = ? AND `itemnumber` NOT IN ( ? ) AND 1=1 AND `notforloan` = ? AND `onloan` IS NULL AND `withdrawn` = ? ) )" with ParamValues: 0=0, 1=156269, 2=0, 3=0] at /usr/share/koha/lib/Koha/Objects.pm line 145 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #6 from Martin Renvoize --- Created attachment 131023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131023=edit Bug 30153: (QA follow-up) Fix unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #5 from Martin Renvoize --- This a trivial patch, and given I've just QA'd bug 25616 now it's been brought to my attention, I'm going to go ahead and QA this one too. Unit test update inbound, then it'll be a pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize --- Good catch, no regressions found and QA scripts are happy. I found another obvious case, and there are lots more `' and '` occurrences in the codebase that a possible cases of this. I think we should push this one as is and handle follow-ups in more bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #17 from Martin Renvoize --- Created attachment 131022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131022=edit Bug 25616: (QA follow-up) Catch a case in labels/label-item-search.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Attachment #130916|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 131021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131021=edit Bug 25616: (follow-up) Use uppercase in advanced search booleans Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Attachment #130915|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 131020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131020=edit Bug 25616: Fix t/db_dependent/Search.t Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Attachment #130914|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 131019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131019=edit Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch Uppercase occurances of all (hopefully) lowercase "and" used in ElasticSearch Query String Query contexts Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Kevin Carnes changed: What|Removed |Added Attachment #131017|0 |1 is obsolete|| --- Comment #5 from Kevin Carnes --- Created attachment 131018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131018=edit Bug 30152: Elasticsearch - queries with OR don't work with limits When a query with "OR" is combined with a limit in Elasticsearch, the precedence is not preserved and the results are not correct. To test: 1) Set SearchEngine to Elasticsearch 2) Index records in Elasticsearch 3) Do an advanced search 4) Select More options 5) Enter a value for the first Keyword (e.g. Novels) 6) Change "and" before the second Keyword to "or" 7) Enter another value for the second Keyword (e.g. Prose) 8) Limit the search (e.g. Item type Books) 9) Do the search 10) Observe that records with the first keyword are not in the results 11) Apply the patch 12) Repeat the search 13) Observe that results with both keywords are in the results 14) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152
--- Comment #4 from Kevin Carnes ---
Comment on attachment 131017
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131017
Bug 30152: Elasticsearch - queries with OR don't work with limits
>From b4cfe66eea7d100d319a5ee256061e8eea15bd99 Mon Sep 17 00:00:00 2001
>From: Kevin Carnes
>Date: Tue, 22 Feb 2022 14:29:15 +0100
>Subject: [PATCH] Bug 30152: Elasticsearch - queries with OR don't work with
> limits
>
>When a query with "OR" is combined with a limit in Elasticsearch, the
>precedence is not preserved and the results are not correct.
>
>To test:
>1) Set SearchEngine to Elasticsearch
>2) Index records in Elasticsearch
>3) Do an advanced search
>4) Select More options
>5) Enter a value for the first Keyword (e.g. Novels)
>6) Change "and" before the second Keyword to "or"
>7) Enter another value for the second Keyword (e.g. Prose)
>8) Limit the search (e.g. Item type Books)
>9) Do the search
>10) Observe that records with the first keyword are not in the results
>11) Apply the patch
>12) Repeat the search
>13) Observe that results with both keywords are in the results
>14) Sign off
>
>Sponsored-by: Lund University Library
>---
> Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>index 3e2cb1b784..b2ef8aa8d9 100644
>--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
>@@ -306,9 +306,7 @@ sub build_query_compat {
> # them into a structured ES query itself. Maybe later, though that'd
> be
> # more robust.
> $search_param_query_str = join( ' ',
> $self->_create_query_string(@search_params) );
>-$query_str = join( ' AND ',
>-$search_param_query_str || (),
>-$self->_join_queries( $self->_convert_index_strings(@$limits) )
>|| () );
>+$query_str = join( ' AND ', map { "($_)" } grep { $_ } (
>$search_param_query_str, $self->_join_queries(
>$self->_convert_index_strings(@$limits) ) ) );
>
> # If there's no query on the left, let's remove the junk left behind
> $query_str =~ s/^ AND //;
>--
>2.17.1
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30153 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25616 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30154] New: Can't write in the second indicator box in field 830 after adding a new authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154 Bug ID: 30154 Summary: Can't write in the second indicator box in field 830 after adding a new authority Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: noemie.lab...@collecto.ca QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl I'm not sure I can explain it clearly in english :-) so here is the test plan : 1. Add a new record. 2. In 830$a, enter a title that can't be link, for exemple Lion. 3. Click on Link authority automatically, you will have a No matching authority found result. 4. Next to the $9 subfield, the + icon will appear to create an authority. 5. Click on it and create the authority. 5. Save the new authority and come back to your record. 6. Click on the second indicator box and try to enter an indicator. You will not be able to enter anything. To be able to enter a second indicator you either have to 1. click on the first indicator box than use TAB to make your cursor go in the second box 2. save the record then edit it to add the indicator 3. enter the indicator when you create the authority Tested it with other fields (800, 810...) and 830 is the only field where this happens. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Kevin Carnes changed: What|Removed |Added Attachment #131011|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 --- Comment #3 from Kevin Carnes --- Created attachment 131017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131017=edit Bug 30152: Elasticsearch - queries with OR don't work with limits When a query with "OR" is combined with a limit in Elasticsearch, the precedence is not preserved and the results are not correct. To test: 1) Set SearchEngine to Elasticsearch 2) Index records in Elasticsearch 3) Do an advanced search 4) Select More options 5) Enter a value for the first Keyword (e.g. Novels) 6) Change "and" before the second Keyword to "or" 7) Enter another value for the second Keyword (e.g. Prose) 8) Limit the search (e.g. Item type Books) 9) Do the search 10) Observe that records with the first keyword are not in the results 11) Apply the patch 12) Repeat the search 13) Observe that results with both keywords are in the results 14) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29397] Add a select2 wrapper for the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Kyle M Hall changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11.03 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Jérémy Breuillard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Attachment #131014|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- I tested against Zebra and found no obvious regressions, ES issue is resolved... Signing off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153
--- Comment #3 from Martin Renvoize ---
Created attachment 131016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131016=edit
Bug 30153: Use uppercase AND to join query parts
C4::Search->FindDuplicate joins title and author using 'and'
(lowercase). When this query is passed on to ElasticSearch, it
interprets the lowercase 'and' as a term to search for, because the
operator has to be in uppercases ('AND').
Test plan:
* Reproduce the bug:
- Set SearchEngine to ElasticSearch (and make sure you have the data
indexed etc)
- Find an existing book, note the title (245a) and the author (100a)
- Create a new book (Cataloging -> New Record)
- Fill in the same title and author using the same data as in an
existing book (and any other fields that might be required)
- Click "save"
=> A new book will be created, the Duplicate Finder has failed
* Apply the patch
* Check if it's working now:
- Create a new book (Cataloging -> New Record)
- Fill in the same title and author using the same data as in an
existing book (and any other fields that might be required)
- Click "save"
- The DuplicateFinder should now report the already exising book
Maybe we should also check if Zebra does not have any problems with the
uppercase 'AND'? In that case, repeat the above steps, but set
SearchEngine to Zebra :-)
Sponsored-by: Steiermärkische Landesbibliothek
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 --- Comment #1 from Jérémy Breuillard --- Created attachment 131015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131015=edit Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27928] FindDuplicate is hardcoded to use Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 Martin Renvoize changed: What|Removed |Added Blocks||30153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||27928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27928 [Bug 27928] FindDuplicate is hardcoded to use Zebra -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 --- Comment #22 from Nick Clemens --- *** Bug 20208 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20208] Custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED CC||n...@bywatersolutions.com --- Comment #10 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 19318 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19884] Improve performance of GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #59 from Nick Clemens --- GetItems is gone, but I think some of the thoughts here are valid -doing a single fetch for each item of a biblio is excessive - EmbedItemsInBarcBiblio should use Koha::Items->search() - limiting to the biblionumber, filtering against "$itemnumbers" and checking for opac visibility (filter_by_visible_in_opac) GetMarcItem should accept a Koha item object too, to avoid re-fetching the items It may be worth filing new bugs, as this one is lengthy now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Thomas Klausner changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #2 from Thomas Klausner --- Created attachment 131014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131014=edit Use uppercase AND to join query parts Fix Bug 30153 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #8 from Lari Taskula --- Created attachment 131013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131013=edit Bug 22321: Fix store() crash when modifying borrowernumber of a new ILL request To test: 1. prove t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Lari Taskula changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321
Lari Taskula changed:
What|Removed |Added
CC||lari.task...@hypernova.fi
--- Comment #7 from Lari Taskula ---
(In reply to Magnus Enger from comment #5)
> After applying these patches I get this when I try to create a new
> illrequest:
>
> Can't call method "borrowernumber" on an undefined value at
> /home/me/kohaclone/Koha/Illrequest.pm line 1643.
>
> 1637 my @holds;
> 1638 if( defined $updated_columns{'borrowernumber'} and
> 1639 Koha::Patrons->find( $updated_columns{'borrowernumber'} ) )
> 1640 {
> 1641 # borrowernumber has changed
> 1642 my $old_illreq = $self->get_from_storage;
> 1643 @holds = Koha::Holds->search( {
> 1644 borrowernumber => $old_illreq->borrowernumber,
> 1645 biblionumber => $self->biblio_id,
> 1646 } )->as_list;
> 1647 }
>
> Not sure what the problem is, but could it be that this works for existing
> requests, but for new ones there just isn't an $old_illreq to get the
> borrowernumber from?
Good catch. I've added an unit test to cover this bug.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #1 from Thomas Klausner --- See Also 27928 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #6 from Lari Taskula --- Created attachment 131012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131012=edit Bug 22321: Unit test for new()->borrowernumber()->store() -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30153] New: FindDuplicate ElasticSearch should not use lowercase 'and'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153
Bug ID: 30153
Summary: FindDuplicate ElasticSearch should not use lowercase
'and'
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: koha-bugs@lists.koha-community.org
Reporter: d...@plix.at
C4::Search->FindDuplicate joins title and author using 'and' (lowercase). When
this query is passed on to ElasticSearch, it interprets the lowercase 'and' as
a term to search for, because the operator has to be in uppercases ('AND').
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Kevin Carnes changed: What|Removed |Added Attachment #131010|0 |1 is obsolete|| --- Comment #2 from Kevin Carnes --- Created attachment 131011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131011=edit When a query with "OR" is combined with a limit in Elasticsearch, the precedence is not preserved and the results are not correct. To test: 1) Set SearchEngine to Elasticsearch 2) Index records in Elasticsearch 3) Do an advanced search 4) Select More options 5) Enter a value for the first Keyword (e.g. Title) 6) Change "and" before the second Keyword to "or" 7) Enter another value for the second Keyword (e.g. Prose) 8) Limit the search (e.g. Item type Books) 9) Do the search 10) Observe that records with the first keyword are not in the results 11) Apply the patch 12) Repeat the search 13) Observe that results with both keywords are in the results 14) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 --- Comment #1 from Kevin Carnes --- Created attachment 131010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131010=edit When a query with "OR" is combined with a limit in Elasticsearch, the precedence is not preserved and the results are not correct. To test: 1) Set SearchEngine to Elasticsearch 2) Index records in Elasticsearch 3) Do an advanced search 4) Select More options 5) Enter a value for the first Keyword (e.g. Title) 6) Change "and" before the second Keyword to "or" 7) Enter another value for the second Keyword (e.g. Prose) 8) Limit the search (e.g. Item type Books) 9) Do the search 10) Observe that records with the first keyword are not in the results 11) Apply the patch 12) Repeats the search 13) Observe that results with both keywords are in the results 14) Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Kevin Carnes changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > I am not sure the patch is the correct way to fix it. > If no value has not been filled in, we shouldn't default. > > In my opinion we should better improve the way we calculate/retrieve the > rules instead. I think this fix is correct for current use of rules as a 'row' - we have all the current rules inthe table grouped, and don't expect to fall back on any individual column if a row is set for a patron/category type I do think there are other issues: bug 28774 made rentaldiscount not save if blank, but creates the same issue here of defaulting to a higher rule level unseen_renewals of '0' seems to translate to 'unlimited' - I don't think that's correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30152] New: Elasticsearch - queries with OR don't work with limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152 Bug ID: 30152 Summary: Elasticsearch - queries with OR don't work with limits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: kevin.car...@ub.lu.se When a query with "OR" is combined with a limit in Elasticsearch, the precedence is not preserved and the results are not correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29722] Add some diversity to sample quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #13 from Andrew Fuerste-Henry --- (In reply to Katrin Fischer from comment #12) > Love this patch, but please keep in mind that strings added to the installer > are now showing up in translations on pootle too (which is pretty awesome, > but means they are string changes :) ) My apologies for that! For some reason I thought these didn't get translated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #6 from Kevin Carnes --- (In reply to Victor Grousset/tuxayo from comment #5) > Which workflow does this break or triggers a warning? In ES6, the type is specified in the URL to index a single record, but in ES7, _doc should be used instead. So if ES6 has a type of _doc, the URL for indexing single records doesn't need to be changed when upgrading to ES7. Koha indexes in bulk, so changing the type name doesn't affect the URL for bulk indexing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #4) > Might be an unpopular view.. but don't we already pull in moment.js for > other date manipulations.. so couldn't we use > https://momentjs.com/docs/#/displaying/difference/ to get a rather accurate > result? I'd agree with this. I also wonder... if the browser date should be used, or the server's... I guess it is not that important. But if we think the UI could make a decision, based on the age, and place a request, this could be rejected because the server could have its own age check, leading to inconsistent behavior. In that case, I'd just allow embedding the age like in: GET /patrons x-koha-emebed: age (it would require renaming the ->get_age method) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #10 from Nick Clemens --- (In reply to Katrin Fischer from comment #9) > I think the confusing bit could be it having "independentbranches" when it > doesn't depend on the pref itself. But we also have > IndependentBranchesPatronModifications that doesn't depend on it. So the > situation is not really clear. > > Maybe: AllowStaffChangeLoggedInBranch ? > > (too long?) The idea with this pref, and IndependentBranchesPatronModifications is that they were once a part of 'IndependentBranches' The goal is to make that preference more granular and allow libraries to set parts of it without others, and keeping them all related with 'IndependentBranches' in the name - possibly it could be a category for the prefs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30149] addbiblio.pl tab closes when saving new authority (biblio record opened from manage-marc-import.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30149 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059
--- Comment #6 from Nick Clemens ---
(In reply to Jonathan Druart from comment #5)
> Are you sure?
Yes, tested again this morning, same results, I believe time portion causes
problems:
let dob = new Date('2022-02-23');
dob: Date Thu Feb 22 1979 19:00:00 GMT-0500 (Eastern Standard Time)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #10 from Kevin Carnes --- (In reply to Victor Grousset/tuxayo from comment #7) > Thanks it works :D > > (In reply to Kevin Carnes from comment #4) > > Should I create a new bug to remove support for multiple types when using > > mappings in Elasticsearch? > > If that's needed for ES7 support or just to have a cleaner ES support then > yes. Don't hesitate to open tickets. No, it's not needed for ES7, it is just cleaner. It's already included, but can be moved to a new bug. I also removed version checking and added a temporary elasticsearch_no_type configuration value that can be removed in the future when support for ES6 is dropped -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What|Removed |Added Attachment #130811|0 |1 is obsolete|| --- Comment #9 from Kevin Carnes --- Created attachment 131009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131009=edit Bug 25669: ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) Starting with version 7.0 of Elasticsearch type names should not be used and in version 6.8 there is a warning if you don't use include_type_name when using put_mapping (requires Search::Elasticsearch@6.8). To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) Observe any deprecation warnings or errors about types 3) Apply patch 4) Install Search::Elasticsearch with the same version as Elasticsearch 5) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 6) Observe no warning or errors about types 7) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Kevin Carnes changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #9 from Kevin Carnes --- (In reply to Jonathan Druart from comment #6) > I've removed the condition, and the tests are passing under ES6. Great, ES6 supports track_total_hits. That makes it much easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Kevin Carnes changed: What|Removed |Added Attachment #130844|0 |1 is obsolete|| --- Comment #8 from Kevin Carnes --- Created attachment 131008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131008=edit Bug 28610: Elasticsearch 7 - hits.total is now an object In Elasticsearch 7 hits.total is now an object which is not always an exact value. You can always get an exact total by adding a track_total_hits parameter set to true when using the Elasticsearch search method To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe that tests with count fail 5) Apply patch 6) Observe that tests with count pass 7) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #11 from Katrin Fischer --- From the uname... Debian 9 perhaps? Could you confirm? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #10 from Jonathan Druart --- And post what you have in /etc/apt/sources.list.d/koha.list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26893] New version of JSON::Validator (D11) breaks our REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26893 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29964 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26893 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #9 from Jonathan Druart --- (In reply to Father Vlasie from comment #8) > uname -a says > > #1 SMP Debian 4.9.290-1 (2021-12-12) x86_64 GNU/Linux > > And About Koha says > > 21.11.01.000 > > I just checked and some of my Perl modules need upgrading: > > JSON::Validator (3.14) 0.97 > Mojolicious (8.12) 7.21 > Mojolicious::Plugin::OpenAPI (2.16) 1.15 > > Could this be it? Yes, upgrade them. Which OS do you have? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #7 from Katrin Fischer --- I had filed the same bug earlier as bug 29615 and I very much agree with Sally. We should start out by duplicating the behaviour of the OPAC preference to make things consistent. Then having a SearchMyLibraryFrist equivalent for the staff interface would make a lot of sense as a second step. For our installations not wanting to limit would currently be the more common setting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #6 from Sally --- Sorry, I have a note of dissent here. I think the idea is great - having the drop down menu available, mirroring the OPAC functionality, would be very useful. But I disagree with this part: "and by default, should limit to the library you are logged in to, with the option via the dropdown to search all libraries." The default search option on the OPAC is customisable, using the 'SearchMyLibraryFirst' preference. I think that the configuration for this should be similarly customisable, because reading through the bug report, my stance would be opposite to Donna's. Obviously, both workflows are equally valid - and it will entirely depend on the library's set up. Is it possible to have a second system preference so the default search behaviour could be configured? For example: IntranetAddMastheadLibraryPulldown: Show SearchLoggedInLibraryFirst: Yes This meets Donna's criteria - defaulting the search to the logged in library. Or: IntranetAddMastheadLibraryPulldown: Show SearchLoggedInLibraryFirst: No This meets our criteria - having the drop down menu visible so it can be used, but defaulting to 'All Libraries'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30122] Display note fields in authority result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30122 --- Comment #8 from Hugo Agud --- I think that it is necessary to be able to select what tags to publish, as there are some notes that are automatically created and not provide useful informationn, for example 667 automatica creation, it doesn't gives useful information for users syspref for selecting what to publish from notes? if none selected, publish nothing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Martin Renvoize --- Thanks Katrin, all fixed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added Attachment #130972|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 131007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131007=edit Bug 30135: Unit tests Add a unit test for EdifactLSQ preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Martin Renvoize changed: What|Removed |Added Attachment #130971|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 131006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131006=edit Bug 30135: Add EdifactLSQ mapping preference This patch adds a new system preference, EdifactLSQ, to allow configuration of the ambiguous LSQ, sequence code, field included in the EDIFACT specifications. Originally the field was hard coded to map to 'location', but as per the specification it could have been mapped to 'ccode'. From the specification: A code or other designation which identifies stock which is to be shelved in a specified sequence or collection. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30122] Display note fields in authority result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30122 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > I am not sure about this one, it looks like actual notes are only 667-688. It's the current that is retrieving 6.. I need to check if it's used somewhere else. > I wonder if it could not make the entries in the results list a little too > lenghty. But I see that there is a class to hide. Could be a syspref otherwise. > How are we doing performance wise here? No change is done in the logic, we retrieve them (but don't use them) already. Will get back to it later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Jonathan Druart changed: What|Removed |Added Keywords|dependency | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
