[Koha-bugs] [Bug 26975] Reindent authorities editor template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26975] Reindent authorities editor template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #18 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #14 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Fridolin Somers changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #48 from Fridolin Somers --- Patch 'Bug 29844: Fix advanced editor' pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger changed: What|Removed |Added Attachment #130544|0 |1 is obsolete|| --- Comment #9 from Magnus Enger --- Created attachment 131055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131055&action=edit Bug 22321: Add unit tests To test: 1. prove t/db_dependent/Illrequests.t 2. Observe test failure 1..3 ok 1 - before change, original borrowernumber found not ok 2 - after change, changed borrowernumber found in holds # Failed test 'after change, changed borrowernumber found in holds' # at t/db_dependent/Illrequests.t line 167. # got: '3786' # expected: '3787' ok 3 - after change, changed borrowernumber found in illrequests # Looks like you failed 1 test of 3. not ok 4 - store borrowernumber change also updates holds Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger changed: What|Removed |Added Attachment #130545|0 |1 is obsolete|| --- Comment #10 from Magnus Enger --- Created attachment 131056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131056&action=edit Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger changed: What|Removed |Added Attachment #130546|0 |1 is obsolete|| --- Comment #11 from Magnus Enger --- Created attachment 131057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131057&action=edit Bug 22321: Allow managing the borrowernumber tied to ILL request Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. This commit makes it possible to edit illrequests.borrowernumber. To test: 1. Apply patch 2. Create two patrons, A and B 3. Create a new ILL request for patron A 4. Add a hold for patron A where biblionumber is the biblio tied to this ILL request 5. Go to cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161 6. Observe Patron ID is editable 7. Change borrowernumber to patron B's borrowernumber 8. Click save 9. Observe ILL request is now for patron B 10. Go to patron B's details at cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber 11. At the bottom section of the page, click 1 Hold(s) 12. Observe the hold you placed at step 4 has transferred to patron b Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger changed: What|Removed |Added Attachment #131012|0 |1 is obsolete|| --- Comment #12 from Magnus Enger --- Created attachment 131058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131058&action=edit Bug 22321: Unit test for new()->borrowernumber()->store() Signed-off-by: Magnus Enger -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger changed: What|Removed |Added Attachment #131013|0 |1 is obsolete|| --- Comment #13 from Magnus Enger --- Created attachment 131059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131059&action=edit Bug 22321: Fix store() crash when modifying borrowernumber of a new ILL request To test: 1. prove t/db_dependent/Illrequests.t Signed-off-by: Magnus Enger Tried to change the borrowernumber connected to an ILL request and checked that the associated hold was updated to the new patron as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #14 from Magnus Enger --- I have signed off on these patches, as they work for me. However, I am involved in commissioning these patches, so I do not update the BZ status from NSO to SO. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30172] BackGround jobs failing due to race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30172] BackGround jobs failing due to race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172 --- Comment #4 from Jonathan Druart --- Created attachment 131060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131060&action=edit Bug 30172: Prevent race condition when enqueuing a new task As we are sending the job to the rabbitmq before in the transaction, the worker can receive the job to process before the transaction committed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30172] BackGround jobs failing due to race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #21 from Martin Renvoize --- Welcome Bill, This looks like a great new feature and I'm really glad the discussion continued past comment 4 to get the refinements I also felt were necessary. Regarding the actual submission, did you read the coding guidelines available https://wiki.koha-community.org/wiki/Coding_Guidelines ? These are what the QA people will base their most basic feedback upon and are 'hard fails' in most cases when not adhered to. They are voted upon by a council of community members and have good reasoning behind each (though they do not cover all cases and being updated fairly regularly as we come across various patterns.. for exapme the 'filter_by_' requirement is not yet a formal guideline, but will become one very soon) Beyond hard fails, the QA persons role is to help spot regressions and ensure coding of a minimum standard is maintained for submissions so we can maintain the features going forward. Such advice can be argued against, but should generally be considered constructive. So, taking Jonathans list. 1. Style, this may fail guidelines given our perlcritic requirements. It's a 1s fix anyway. 2. Will be in the guidelines imminently, a few minutes to fix. 3. Style, improved coding style, readability improvement. Not a hard fail, but constructive. 4. Hard fail, all module changes have required corresponding unit tests since 2017. If you are stuck here, just ask for some guidance. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_are_required_.28updated_Apr_26.2C_2017.29 5. This is an unwritten rule.. I've made a note to add it to the guidelines. It just makes submissions considerably simpler for maintainers to add to all the supported branches. 6. Style, no guidelines broken, but it's a fair comment to help improve the developer. Another 10s fix. 7. Style, this will be fixed at push. 8. Hard fail: https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence 9. Superfluous comments confuse future maintenance and cost everybody time. 10. Style, developers do things in their own way. Whilst I agree an ajax method would have been preferable (I'd probably have gone for a new REST route myself, rather than svc), this isn't a hard fail but more of a guide for future developments. 11. This is highlighting some red flags for future maintenance again. This is the most 'human' comment here. To me, this code looks rather 'copy/paste', which is fine but there should be evidence that you've stripped out all unnecessary boilerplate and given the development some thought as to what it's actually doing and requires. Hope that helps clarify things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #22 from Martin Renvoize --- Comment on attachment 130516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130516 Bug 12029: Patrons should be able to delete their patron messages Review of attachment 130516: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12029&attachment=130516) - ::: installer/data/mysql/kohastructure.sql @@ +3739,4 @@ >`message` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'the text > of the message', >`message_date` timestamp NOT NULL DEFAULT current_timestamp() COMMENT 'the > date and time the message was written', >`manager_id` int(11) DEFAULT NULL COMMENT 'creator of message', > + `patron_read_date` timestamp NULL DEFAULT NULL COMMENT 'date and time the > patron dismissed the message', Final additional note from my own review: Shouldn't this be a DATETIME rather than a TIMESTAMP field? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #70 from Martin Renvoize --- Whilst 19.11 probably falls fowl of this bug, I don't think it warrants a backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30160] Rewrite cities admin view in React
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30160 --- Comment #15 from Martin Renvoize --- I too would love to see a Vue version side by side with this. The code looks nice enough to me here, though I'm by no means an expert in any of the JS frameworks. I think React has come a long way since I last looked at it as this looks a little more elegant at first look.. though it does feel like a lot of boilerplate. For me, React and Vue are the two contenders.. we've already ruled out Angular I believe as it's just too 'build from scratch' for our needs and given our slow adoption of these things I feel we should stick to the two biggest/most popular frameworks of the moment with tried and tested long term records. Thus Vue vs react for me. I'll have a play with this and see how it feels.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30160] Rewrite cities admin view in React
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30160 --- Comment #16 from Marcel de Rooy --- Very interesting indeed. Thanks for testing this, Jonathan. I am not very familiar with both tools, but iiuc React needs more skills than Vue while React has a larger community and some Vue documentation is only in Chinese :) ? Would choosing a tool that might create a barrier for developers to join us, eventually be a problem in the long run? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30172] BackGround jobs failing due to race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172 Jonathan Druart changed: What|Removed |Added Attachment #131060|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 131061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131061&action=edit Bug 30172: Prevent race condition when enqueuing a new task As we are sending the job to the rabbitmq before in the transaction, the worker can receive the job to process before the transaction committed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30172] BackGround jobs failing due to race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172 --- Comment #6 from Jonathan Druart --- Nick suggested me to set the status to "failed" in case the job was not enqueued. I am not sure it's the best we can do. If a job is started but the connection failed, the exception will be thrown but the job will appear in the DB table. If the user already got the error on the UI I don't know if the job should be inserted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30172] BackGround jobs failing due to race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172
--- Comment #7 from Nick Clemens ---
There is another approach we could try.
In misc/background_jobs_worker.pl we have:
61 my $job = Koha::BackgroundJobs->find($args->{job_id});
62
63 process_job( $job, $args );
64 $conn->ack( { frame => $frame } ); # FIXME depending on success?
Perhaps:
61 my $job = Koha::BackgroundJobs->find($args->{job_id});
62 $conn->nack({frame=>$frame}) unless $job;
63 process_job( $job, $args );
64 $conn->ack( { frame => $frame } ); # FIXME depending on success?
Though could we end up in a loop? The queue should expire eventually - and we
could store soemthing in the job about retries when we send nack?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30160] Rewrite cities admin view in React
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30160 --- Comment #17 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #16) > Very interesting indeed. Thanks for testing this, Jonathan. > > I am not very familiar with both tools, but iiuc React needs more skills > than Vue while React has a larger community and some Vue documentation is > only in Chinese :) ? > > Would choosing a tool that might create a barrier for developers to join us, > eventually be a problem in the long run? That is precisely my concern. Having said that, I think there are allot of Vue and React developers out there.. Finding new devs will likely become easier once we adopt one of these.. maintaining some of the existing ones may be more difficult.. I think we need a lean learning curve, which is what drew me to Vue (But I've barely scratched the surface of tutorials yet myself). We want something that won't exclude the likes of Owen or Katrin for example. I wasn't aware that some Vue docs are only in Chinese.. everything I've come across has been in english. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30175] New: Digest options not enabled when populating messaging preferences for a selected category during patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175 Bug ID: 30175 Summary: Digest options not enabled when populating messaging preferences for a selected category during patron entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1 - Define default messaging preferences for a patron category, checking a transport and the digest only boxes 2 - Create a new patron of a different category 3 - Change the category to the one set above 4 - Note that checkboxes are checked, but digest boxes are disabled 5 - Save patron - the digest boxes are not saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30175] Digest options not enabled when populating messaging preferences for a selected category during patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Depends on||13613 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 [Bug 13613] Don't allow digest to be selected without a digest-able transport selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13613] Don't allow digest to be selected without a digest-able transport selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 Nick Clemens changed: What|Removed |Added Blocks||30175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175 [Bug 30175] Digest options not enabled when populating messaging preferences for a selected category during patron entry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30175] Digest options not enabled when populating messaging preferences for a selected category during patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175 --- Comment #1 from Nick Clemens --- Created attachment 131062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131062&action=edit Bug 30175: Toggle digest boxes when loading messaging preferences To test: 1 - Define default messaging preferences for a patron category, checking a transport and the digest only boxes 2 - Create a new patron of a different category 3 - Change the category to the one set above 4 - Note that checkboxes are checked, but digest boxes are disabled 5 - Save patron - the digest boxes are not saved 6 - Apply patch 7 - Repeat 2&3 8 - Note checkboxes for digest are checked and enabled 9 - Save patron and confirm options are saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30176] New: Koha Manual Link for latest manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30176 Bug ID: 30176 Summary: Koha Manual Link for latest manual Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Up until recently, the link: https://koha-community.org/manual/latest/en/html would bring the user to the most recent version of Koha manual, which should be 21.11, however, at this time, the 'latest' link is still referring to the 20.11 version. Can this be updated? Thanks! Kelly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #7 from George Veranis --- Created attachment 131063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131063&action=edit Bug 20362: (Follow-up) Direct link to authority records missing in staff detail view (1xx , 7xx) I change the magnigying glass icon to FA icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30169] Prefetching is expensive for performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169 --- Comment #1 from Nick Clemens --- Tested with Tomas this morning, a few notes: using the correct relationships for prefetch: item,patron that reduces DB calls, otherwise we are still doing a hit every time we use related object that still doesn't increase performance Using DBIC directly to avoid Koha objects does not change things, we still see much great performance without prefetch Using SQL directly is faster, as expected, fetching 500 rows it was about ~1.5 seconds vs ~3 seconds with Koha:Objects, no prefetch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30175] Digest options not enabled when populating messaging preferences for a selected category during patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29687] Get rid of an uninitialized warning in XSLT.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Marcel de Rooy changed: What|Removed |Added Summary|Get rid of a few OPAC |Get rid of an uninitialized |warnings|warning in XSLT.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29687] Get rid of an uninitialized warning in XSLT.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #2 from Marcel de Rooy --- Had much more of these warns, but no time to remove them all ;) Just submitting this one now here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29687] Get rid of an uninitialized warning in XSLT.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- Super trivial: self SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30175] Digest options not enabled when populating messaging preferences for a selected category during patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30175] Digest options not enabled when populating messaging preferences for a selected category during patron entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175 Lucas Gass changed: What|Removed |Added Attachment #131062|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 131064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131064&action=edit Bug 30175: Toggle digest boxes when loading messaging preferences To test: 1 - Define default messaging preferences for a patron category, checking a transport and the digest only boxes 2 - Create a new patron of a different category 3 - Change the category to the one set above 4 - Note that checkboxes are checked, but digest boxes are disabled 5 - Save patron - the digest boxes are not saved 6 - Apply patch 7 - Repeat 2&3 8 - Note checkboxes for digest are checked and enabled 9 - Save patron and confirm options are saved Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30127] By default show pending suggestions tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30127 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30169] Prefetching is expensive for performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169
Julian Maurice changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
--- Comment #2 from Julian Maurice ---
Can confirm, and the issue is not with Koha::Objects because using DBIC
directly shows the same problem:
# 163..212 is just the range of itemnumbers I had in my issues table
time perl -e 'use Koha::Database; my $schema = Koha::Database->schema; for
(163..212) { my $issue = $schema->resultset("Issue")->find({itemnumber => $_},
{prefetch => ["item", "patron"]}); my $info = $issue->item->barcode .
$issue->patron->firstname }'
perl -e 1,55s user 0,06s system 97% cpu 1,646 total
time perl -e 'use Koha::Database; my $schema = Koha::Database->schema; for
(163..212) { my $issue = $schema->resultset("Issue")->find({itemnumber => $_},
{prefetch => []}); my $info = $issue->item->barcode . $issue->patron->firstname
}'
perl -e 1,04s user 0,06s system 96% cpu 1,138 total
I ran both commands multiple times and had the same times
It's weird, as I have seen some improvements in other areas by using prefetch
(see bug 30004)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30177] New: When changing patron categories of existing accounts should not reset message prefs without first warning staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Bug ID: 30177 Summary: When changing patron categories of existing accounts should not reset message prefs without first warning staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To recreate: 1 - Define default messaging preferences for a patron category 2 - Go into an existing account and change the patron category to the one set in step 1. 3. Confirm that the messaging prefs have been reset to that of the default patron category There should be a warning to staff that messaging prefs are being changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30169] Prefetching is expensive for performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169
--- Comment #3 from Martin Renvoize ---
I just wrote a benchmark for this:
#!/usr/bin/env perl
use strict;
use warnings;
use Benchmark qw/cmpthese timethese/;
use Koha::Libraries;
use Koha::Database;
my $schema = Koha::Database->schema;
cmpthese(
-10,
{
kohaPrefetch => sub {
my $checkouts = Koha::Checkouts->search({},{ prefetch => [ 'item',
'patron' ]});
while ( my $checkout = $checkouts->next ) {
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
},
kohaJoin => sub {
my $checkouts = Koha::Checkouts->search({});
while ( my $checkout = $checkouts->next ) {
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
},
dbicPrefetch => sub {
my $checkouts = $schema->resultset('Issue')->search({},{ prefetch
=> [ 'item', 'patron' ]});
while ( my $checkout = $checkouts->next ) {
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
},
dbicJoin => sub {
my $checkouts = $schema->resultset('Issue')->search({});
while ( my $checkout = $checkouts->next ) {
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
}
}
);
It suggests prefetch is quicker in my findings.. but it's testing at a slightly
different level.. I'm testing one prefetch over a large resultset.. you were
testing lots of prefetches over a single result... I'll write a benchmark for
that too..
I think it's object instantiation that's at fault here.. you are effectively
instantiating the object for each iteration whereas I'm instantiating one
object for all results.
In short.. it depends on how we code as to whether adding prefetch is a good
idea or not.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #8 from George Veranis --- Created attachment 131065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131065&action=edit Bug 20615: Add the link of number of times the authority are used in edit mode Currently when show an authority record you can see the count of records linked with that authority, but when edit that authority record the that detail is dissapeared. Applying this patch will have that information also on edit mode of authority. Test plan: 1) Search for an authority that is already connected with at least one record 2) On detail view of an authority you can check that authority is linked with x records. 3) Edit that authority and the information about in how many records that authority is linked is missing. 4) Apply this patch 5) Edit again that authrity and you can find now the count in how many records is used that authority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30169] Prefetching is expensive for performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169 --- Comment #4 from Martin Renvoize --- Rate kohaJoin dbicJoin kohaPrefetch dbicPrefetch kohaJoin 1.69/s -- -4% -79% -81% dbicJoin 1.76/s 4% -- -78% -80% kohaPrefetch 8.09/s 378% 359% -- -10% dbicPrefetch 9.03/s 434% 413% 12% -- Result from above.. shows dbicPrefetch is fastest (I didn't measure straight SQL with and without a join).. and kohaPrefetch isn't as much slower than dbic than I thought it might be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Nick Clemens changed: What|Removed |Added Attachment #130106|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 131066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131066&action=edit Bug 30004: Prevent TooMany from executing too many SQL queries If a maximum number of checkouts allowed is defined in circulation rules, C4::Circulation::TooMany will loop over all patron's checkouts. When a patron has several hundreds of checkouts, it can really slow down the checkout process by several seconds (or even tens of seconds) This patch does two things: - Always prefetch item data so that `$c->item` does not execute an additional SQL query at every iteration of the loop. Item data is always needed at the first line of the loop, so there is really no downside for doing this. - Build the `@types` array only once, out of the checkouts loop. Since it does not depend at all on patron's checkouts data, it does not make sense to build it inside the loop. Test plan: 1. Before applying the patch, create a patron with a lot of checkouts. I tested with 1000 checkouts, but the slowness should be noticeable with less. 2. Make sure you have a circulation rule (one that apply to your patron and the item(s) you will check out for testing) with a maximum number of checkouts allowed 3. Check out an item for the patron with a lot of checkouts. Measure the time it takes. 4. Apply the patch 5. Check out another item (or check in and then check out the same item used in step 3). Measure the time it takes and compare it to step 3. It should be faster now. 6. Run `prove t/db_dependent/Circulation/TooMany.t` Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Lucas Gass changed: What|Removed |Added Summary|When changing patron|When changing patron |categories of existing |categories of existing |accounts should not reset |accounts it should not |message prefs without first |reset message prefs without |warning staff |first warning staff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30169] Prefetching is expensive for performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169
--- Comment #5 from Martin Renvoize ---
#!/usr/bin/env perl
use strict;
use warnings;
use Benchmark qw/cmpthese timethese/;
use Koha::Libraries;
use Koha::Database;
my $schema = Koha::Database->schema;
cmpthese(
-100,
{
kohaPrefetch => sub {
for ( my $i = 0 ; $i < 250 ; $i++ ) {
my $checkout = Koha::Checkouts->find( { itemnumber => 10 },
{ prefetch => [ 'item', 'patron' ] } );
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
},
kohaJoin => sub {
for ( my $i = 0 ; $i < 250 ; $i++ ) {
my $checkout = Koha::Checkouts->find( { itemnumber => 10 } );
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
},
dbicPrefetch => sub {
for ( my $i = 0 ; $i < 250 ; $i++ ) {
my $checkout =
$schema->resultset('Issue')->find( { itemnumber => 10 },
{ prefetch => [ 'item', 'patron' ] } );
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
},
dbicJoin => sub {
for ( my $i = 0 ; $i < 250 ; $i++ ) {
my $checkout =
$schema->resultset('Issue')->find( { itemnumber => 10 } );
my $item_id = $checkout->item->itemnumber;
my $patron_id = $checkout->patron->borrowernumber;
}
}
}
);
Alternatively, for instantiation speed.. the prefetch creates a bigger,
heavier, object and so clearly will be slower than without.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30169] Prefetching is expensive for performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169 --- Comment #6 from Martin Renvoize --- s/iter dbicPrefetch kohaPrefetch kohaJoin dbicJoin dbicPrefetch 4.51 -- -2% -68% -68% kohaPrefetch 4.42 2% -- -67% -68% kohaJoin 1.45 211% 205% -- -2% dbicJoin 1.43 217% 210% 2% -- Results are interesting there.. I would have expected kohaPrefetch to be slower than dbicPrefetch But still.. clearly instantiating multiple small objects is faster than instantiating a large object lots of times. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 --- Comment #1 from Lucas Gass --- Created attachment 131067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131067&action=edit Bug 30177: When editing an existing patron set message_prefs_dirty to true 1 - Define default messaging preferences for a patron category 2 - Go into an existing account and change the patron category to the one set in step 1. 3 - Confirm that the messaging prefs have been reset to that of the default patron category 4 - Apply patch 5 - Repeat Step 2, this time you should see a warning asking if you want to set messaging prefs to the category default 6 - Press OK and save. Confirm that the messaging prefs are now set to the default for that category 7 - Try it again with an existing account and press Cancel this time. Notice that there should be no change to the patron messaging prefs. 8 - Try making a new patron and switching the category, you should see no warning and the message prefs should be proberly set to the defaults of any category you choose. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13620] Add item when modifying an order (items created when placing an order)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13620 Marjorie Barry-Vila changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17684] add floating table header on acqui-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17684 Marjorie Barry-Vila changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Marjorie Barry-Vila --- from what I have been able to test, it is available now in version 21.05.09 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19749] Report to show all holds placed independent on items being available to pull
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19749 --- Comment #6 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Hurray! Thanks for the analysis :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Bug 25439 depends on bug 22520, which changed state. Bug 22520 Summary: Be Elastic compliant 7.x and 8.x (_doc) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Owen Leonard changed: What|Removed |Added Attachment #130055|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 131068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131068&action=edit Bug 2: Replace the use of jQueryUI tabs on authorized values administration page This patch updates the authorized values edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Normally Bootstrap tabs don't have to be initiated via JavaScript, but this page requires some JS to select the first tab as active if no other tabs are active. Because of the way the template works it's not simple to do it via template logic, so in this case some JS helps. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Authorized values in the staff interface. - Select a category and then add or edit an authorized value in that category. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard changed: What|Removed |Added Attachment #127295|0 |1 is obsolete|| Attachment #127296|0 |1 is obsolete|| Attachment #127297|0 |1 is obsolete|| Attachment #127298|0 |1 is obsolete|| Attachment #127299|0 |1 is obsolete|| Attachment #127300|0 |1 is obsolete|| Attachment #127301|0 |1 is obsolete|| Attachment #127302|0 |1 is obsolete|| Attachment #127303|0 |1 is obsolete|| Attachment #127304|0 |1 is obsolete|| Attachment #127305|0 |1 is obsolete|| Attachment #127306|0 |1 is obsolete|| Attachment #127307|0 |1 is obsolete|| Attachment #127308|0 |1 is obsolete|| Attachment #127309|0 |1 is obsolete|| Attachment #127310|0 |1 is obsolete|| Attachment #127311|0 |1 is obsolete|| Attachment #127432|0 |1 is obsolete|| Attachment #127456|0 |1 is obsolete|| --- Comment #91 from Owen Leonard --- Created attachment 131069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131069&action=edit Bug 27631: Changed around logo to To test: 1) Look at Staff Client and the logo 2) Apply patch 3) Check Koha logo moves to the middle of the page when zooming in 4) Ensure page source shows logo inside and not Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #92 from Owen Leonard --- Created attachment 131070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131070&action=edit Bug 27631: circ folder Changed each of the pages in the circ folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the circ folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #93 from Owen Leonard --- Created attachment 131071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131071&action=edit Bug 27631: labels and members folders Changed each of the pages in the labels and members folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #94 from Owen Leonard --- Created attachment 131072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131072&action=edit Bug 27631: authorities, clubs, common, course_reserves folders Changed each of the pages in the authorities, clubs, common, course_reserves folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the authorities, clubs, common, course_reserves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #95 from Owen Leonard --- Created attachment 131073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131073&action=edit Bug 27631: installer and onboarding folders Changed each of the pages in the installer and onboarding folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Ensure that the page source shows logo inside and not inside 4) Go to each of the pages in the installer and onboarding folders and check that they have an obvious and descriptive heading 5) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #96 from Owen Leonard --- Created attachment 131074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131074&action=edit Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #97 from Owen Leonard --- Created attachment 131075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131075&action=edit Bug 27631: catalogue and tags folders Changed each of the pages in the catalogue and tags folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the catalogue and tags folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #98 from Owen Leonard --- Created attachment 131076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131076&action=edit Bug 27631: tools and virtualshelves folders Changed each of the pages in the tools and virtualshelves folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the tools and virtualshelves folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #99 from Owen Leonard --- Created attachment 131077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131077&action=edit Bug 27631: reports and serials folders Changed each of the pages in the reports and serials folders to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the reports and serials folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #100 from Owen Leonard --- Created attachment 131078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131078&action=edit Bug 27631: cataloguing folder Changed each of the pages in the cataloguing folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the cataloguing folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #101 from Owen Leonard --- Created attachment 131079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131079&action=edit Bug 27631: acqui folder Changed each of the pages in the acqui folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the acqui folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #102 from Owen Leonard --- Created attachment 131080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131080&action=edit Bug 27631: Hidden on intranet-main.tt This patch visually hides a on intranet-main.tt so that the heading is available to be read out by screenreaders in the summary of headings on the page. Test plan: 1) Ensure the "Koha home" heading on the staff client main/home page is hidden visually, but in the source code you can see it Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11989] Holds Queue Scheduling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11989 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- (In reply to Christopher Brannon from comment #1) > Seriously, this is good stuff here. :) +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #103 from Owen Leonard --- Created attachment 131081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131081&action=edit Bug 27631: admin folder Changed each of the pages in the admin folder to have one tag showing that describes the page, rather than the describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the admin folder and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #104 from Owen Leonard --- Created attachment 131082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131082&action=edit Bug 27631: (follow-up) course_reserves/course-details.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to course_reserves/course-details and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #105 from Owen Leonard --- Created attachment 131083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131083&action=edit Bug 27631: (follow-up) tools/marc_modification_templates.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to tools/marc_modification_templates and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #106 from Owen Leonard --- Created attachment 131084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131084&action=edit Bug 27631: (follow-up) reports/guided_reports_start.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this wil be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to reports/guided_reports_start and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #107 from Owen Leonard --- Created attachment 131085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131085&action=edit Bug 27631: (follow-up) circ/branchtransfers.tt Changed file to have one tag showing that describes the page, rather than the around the logo. The hierarchy of other heading tags may be wrong, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to circ/branchtransfers and check that it has an obvious and descriptive heading 4) Ensure that the heading is Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #108 from Owen Leonard --- Created attachment 131086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131086&action=edit Bug 27631: (follow-up) Some minor corrections This patch makes some corrections to issues found during testing: Some duplicate headings, a markup error in labeledMARCdetail.tt, a change of the transfers heading from "Branch transfers" to "Item transfers." This patch also undoes the changes to the position of the toolbar on several pages. I think those changes don't belong in this bug. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #109 from Owen Leonard --- Created attachment 131087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131087&action=edit Bug 27631: (follow-up) Modify logo CSS to give better alignment This patch modifies the CSS of the Koha logo and its container so that it more closely matches the previous version and so that alignment is handled better at various browser widths. To test, apply the patch and build the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Check various pages in the staff interface to confirm that the position of the Koha logo is correct. Adjust your browser width to confirm that the alignment adapts at narrow widths. Test also on pages where the header search form can be expanded, e.g. Patrons -> [+] to expand search options. Or Acquisitions -> Orders search -> [+]. Confirm that logo alignment is correct on these pages too. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add option for building the holds queue for a single bib in background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add option for building the holds queue for a single bib in background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add option for building the holds queue for a single bib in background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add option for building the holds queue for a single bib in background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 131088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131088&action=edit Bug 29346: Refactor loop code into a subroutine The CreateQueue() method deletes the holds queue data, fetches some configuration (branches to use, transport cost matrix) and then loops through a list of biblionumbers, generating the tmp_holdsqueue and hold_fill_targets rows for the specified biblio. This patch simply moves that last bit that is run inside the biblios loop into a separate sub. The update_queue_for_biblio sub is designed so it does the exact same thing it did inside the loop, but also gets added the capability of querying those parameters if not passed, and it also gets a 'delete' parameter so it deletes the biblio-specific holds queue rows before starting to work. This way, it can be reused to write a background job for real-time holds queue update :-D To test: 1. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! Behavior is kept! 4. Sign off :-D Sponsored-by: Montgomery County Public Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add option for building the holds queue for a single bib in background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 131089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131089&action=edit Bug 29346: Add holds queue update background job This patch adds a background job that takes care of updating the holds queue rows for a given list of biblios. It is designed to be used for real-time batch updating the holds queue when required. Tasks would be added by the relevant methods under the right use cases. Sponsored-by: Montgomery County Public Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add option for building the holds queue for a single bib in background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #4 from Tomás Cohen Arazi --- Submitting early to get feedback from interested community members. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22180] SERIAL_ALERT email does not send if the status is Claimed before becoming Arrived.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22180 --- Comment #1 from Marjorie Barry-Vila --- still valid in 21.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14085] Search for biblionumber in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14085 --- Comment #1 from Marjorie Barry-Vila --- still valid in 21.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] New: Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 Bug ID: 30178 Summary: Every librarian can edit every item with IndependentBranches on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: janus...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Problem arises after applying bugfix #27526: with IndependentBranches on, a librarian without superlibrarian privileges, can edit every item (i.e. also from a foreign branch). This is because can_be_edited calculation is buggy. A patch will follow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 --- Comment #1 from Janusz Kaczmarek --- Created attachment 131090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131090&action=edit [SOLVED] Every librarian can edit every item with IndependentBranches on Test plan: = 1. Have (at least) two branches defined. 2. Have IndependentBranches set. 3. Have a biblio record with items belonging to different branches. 4. Be a librarian without superlibrarian rights. 5. Go to Edit -> Edit items view (cataloguing/additems.pl). 6. You will be able to edit every item, also ones not from the branch you are from. 7. Apply the patch. 8. Repeat 5. 9. You should be able to edit only the items from your branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 The Minh Luong changed: What|Removed |Added Attachment #114458|0 |1 is obsolete|| --- Comment #91 from The Minh Luong --- Created attachment 131091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131091&action=edit Bug 12532 - Send emails to guarantee and guarantor Checks for the syspref "RedirectGuaranteeEmail" in Koha::Patrons::notice_email_address. When enabled, emails to a patron with a guarantor will be sent to both guarantor and guarantee. It does not affect values in the message_queue table. Test plan: Before applying 1) Search, or create, a patron with guarantor 2) Enable checkout emails 3) Checkout an item. An email should be sent only to the guarantee 4) Apply this patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 The Minh Luong changed: What|Removed |Added Attachment #114459|0 |1 is obsolete|| --- Comment #92 from The Minh Luong --- Created attachment 131092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131092&action=edit Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 The Minh Luong changed: What|Removed |Added Attachment #114461|0 |1 is obsolete|| --- Comment #93 from The Minh Luong --- Created attachment 131093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131093&action=edit Bug 12532 - Correction of tests involving guarantorid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #94 from The Minh Luong --- Created attachment 131094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131094&action=edit Bug 12532: Send email to guarantee and guarantor; This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. NOTE: Attachment "Rebase and correction of the patch by adding the possibility of sending emails to several guarantors" generate an sha1 error. I had to took its content and put it in another commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) Enable checkout emails for both guarantors and guarantees. 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Run misc/cronjobs/process_message_queue.pl 8) Notice that the email should be sended to both the guarantee AND the guarantor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 Janusz Kaczmarek changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |janus...@gmail.com |ity.org | CC||jonathan.druart+koha@gmail. ||com Priority|P5 - low|P2 Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 The Minh Luong changed: What|Removed |Added CC||the-minh.lu...@inlibro.com Attachment #114460|1 |0 is patch|| Attachment #114460|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #71 from wainuiwitikap...@catalyst.net.nz --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
