[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks|30295 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 [Bug 30295] Send a notification when a recall is manually cancelled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia changed: What|Removed |Added Depends on|19532 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Attachment #104984|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 131702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131702=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Eric Phetteplace changed: What|Removed |Added CC|ephettepl...@cca.edu| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia changed: What|Removed |Added Blocks||30295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 [Bug 30295] Send a notification when a recall is manually cancelled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia changed: What|Removed |Added Depends on||23781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 [Bug 23781] Recalls notices and messaging preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #909 from Aleisha Amohia --- Created attachment 131701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131701=edit Bug 19532: (QA follow-up) Fixing typo Introduced by: Bug 19532: (QA follow-up) Simplify resultset accessors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Blocks||30295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 [Bug 30295] Send a notification when a recall is manually cancelled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia changed: What|Removed |Added Depends on||19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30295] New: Send a notification when a recall is manually cancelled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Bug ID: 30295 Summary: Send a notification when a recall is manually cancelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The process would be: 1. Recall is cancelled by library staff or the requester. 2. Notification of the recall cancellation is sent via email and SMS to the recall requester. So it would be exactly the same as the HOLD_MANUAL_CANCEL notice that we currently have for reserves, only relevant to recalls. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #114 from Alex Buckley --- Rebased and ready to test again! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #113 from Alex Buckley --- Created attachment 131700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131700=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply first 3 patches and run updatedatabase.pl cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Restart memcached and plack 4. Create 4 patron accounts: - User A : Superlibrarian permissions - User B : 'Staff access, allows viewing of catalogue in staff interface (catalogue)' - User C : No permissions - User D : 'Staff access, allows viewing of catalogue in staff interface' and 'Lists' > Edit public lists (edit_public_lists)' sub-permission 5. Login to staff client as User A. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 6. Log into the staff client as User B. Confirm you can add items to the list from the following staff client pages: - Individual list page using the 'Add items' button - Staff client search result page - Staff client biblio detail page 7. Confirm you can remove items from the list 8. Confirm you can perform an OPAC search when not logged in 9. Log into the OPAC as User B. Confirm you can add items to the list from the following OPAC pages: - OPAC search result page - OPAC biblio detail page 10. Log into the OPAC as User C. Do an OPAC search and confirm you can view the list, but not add items to it 11. Login to the staff client as User B. Create a new list with the following settings: - 'Category'='Private', - 'Allow changes to contents from'='Staff only' Notice a red hint message is displayed. Change 'Category'='Public' and notice the hint is removed 12. Log into the OPAC as User C. Notice the 'Staff only' option is not available when creating a list 13. Log into the OPAC as User B. Repeat step 11. Confirm the same outcome 14. Log into the staff client as User A. Create a list with the following settings: - Public = 'Public' - Allow changes to contents from = 'owner only' 15. Log into the staff client as User D. Edit the list from step 14 confirm you can edit the list to have 'Allow changes to contents from' = 'Staff only' 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Attachment #131699|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #112 from Alex Buckley --- Created attachment 131699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131699=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply first 3 patches and run updatedatabase.pl cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 3. Restart memcached and plack 4. Create 4 patron accounts: - User A : Superlibrarian permissions - User B : 'Staff access, allows viewing of catalogue in staff interface (catalogue)' - User C : No permissions - User D : 'Staff access, allows viewing of catalogue in staff interface' and 'Lists' > Edit public lists (edit_public_lists)' sub-permission 5. Login to staff client as User A. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 6. Log into the staff client as User B. Confirm you can add items to the list from the following staff client pages: - Individual list page using the 'Add items' button - Staff client search result page - Staff client biblio detail page 7. Confirm you can remove items from the list 8. Confirm you can perform an OPAC search when not logged in 9. Log into the OPAC as User B. Confirm you can add items to the list from the following OPAC pages: - OPAC search result page - OPAC biblio detail page 10. Log into the OPAC as User C. Do an OPAC search and confirm you can view the list, but not add items to it 11. Login to the staff client as User B. Create a new list with the following settings: - 'Category'='Private', - 'Allow changes to contents from'='Staff only' Notice a red hint message is displayed. Change 'Category'='Public' and notice the hint is removed 12. Log into the OPAC as User C. Notice the 'Staff only' option is not available when creating a list 13. Log into the OPAC as User B. Repeat step 11. Confirm the same outcome 14. Log into the staff client as User A. Create a list with the following settings: - Public = 'Public' - Allow changes to contents from = 'owner only' 15. Log into the staff client as User D. Edit the list from step 14 confirm you can edit the list to have 'Allow changes to contents from' = 'Staff only' 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Attachment #128385|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia changed: What|Removed |Added Attachment #131648|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 131698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131698=edit Bug 30288: Provide links to OPACUserJS and OPACUserCSS in tools This patch provides easy access to the OPACUserJS and OPACUserCSS system preferences in the Additional Contents (News and HTML customisations) sections. These links can be enabled or disabled with the new system preference OPACEnhancementPreferencesLinks. To test: 1. Apply the patch and update the database to apply the new system preference. 2. In the staff client, go to Tools -> Additional Contents (either News or HTML customisations). Notice there is a link "See News" or "See HTML customisations". 3. Go to Koha Administration -> system preferences -> Tools tab, find the OPACEnhancementPreferencesLinks system preference. Confirm it is disabled by default. Enable it (set to 'provide'). 4. Go back to Tools -> Additional contents. Confirm there are now links to "See OPACUserCSS" and "See OPACUserJS". Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30289] Use Template::Toolkit WRAPPER to reduce template boilerplate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30289 --- Comment #4 from David Cook --- (In reply to Marcel de Rooy from comment #3) > Interesting. You might convince the community even more by implementing into > various opac templates. Getting it to work with a bunch of templates should > show how beneficial it is. I was thinking the same thing, although I figure they need to be low-risk changes to be accepted. Maybe opac-library.pl and opac-tags.pl? I was also thinking I need to convince Owen most of all . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED --- Comment #111 from Alex Buckley --- (In reply to shi-yao.wang from comment #110) Thanks, Shi-Yao I will rebase my patches against master and re-attach them to this ticket to re-test. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 --- Comment #20 from Katrin Fischer --- Not sure I can finish there, but I can at least start? 1) POD (not blocker) +--uploaded_files Include uploaded files. +--uploaded_temp_files Include temporary uploaded files. Does this mean that --uploaded_files includes or excludes the temporary uploaded files? Taking a closer look it looks like temporary and other uploaded files go to different directories, so the first would be excluding temporary files. Just wondering if someone setting this up would be aware - might still be worth adding a little note. 2) What do I need to do to make this work on ktd? I seem to remember having to copy the files somewhere for these changes to take effect. At the moment sudo koha-dump -h doesn't list the new options. Not a reason to fail, but maybe you can help me to test this? Also happy if Tomas wants to finish here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #84 from Katrin Fischer ---
1) Can you please explain this change in Items.pm?
This would also affect the item form in serials IIRC.
@@ -1559,6 +1559,8 @@ sub PrepareItemrecordDisplay {
my $itemrecord;
if ($itemnum) {
$itemrecord = C4::Items::GetMarcItem( $bibnum, $itemnum );
+}elsif ($defaultvalues && $defaultvalues->{'itemrecord'} ) {
+$itemrecord = $defaultvalues->{'itemrecord'};
}
2) GetMarcFieldsToOrderValues in Koha/Acquisition/Utils.pm
* Method names in Koha should be using snake case.
* Is it possible that the $syspref parameter has been removed/not implemented?
It appears to be hardcoded to Koha/Acquisition/Utils.pm.
+=head3 GetMarcFieldsToOrderValues($syspref_name, $record, $field_list)
+
+my $data =
Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder',
$marcrecord, ['price', 'quantity', 'budget_code', etc.]);
+
+sub GetMarcFieldsToOrderValues {
+my ($record, $field_list) = @_;
+my $syspref = C4::Context->preference('MarcFieldsToOrder');
3) GetMarcItemFieldsToOrderValues in Koha/Acquisition/Utils.pm
Same questions as for 2) actually.
4) Test plan
None of the commit messages contain much of a description or test plan. I found
this - is it still accurate? Could you add some notes for how
GetMarcFieldsToOrder and GetMarcItemFieldsToOrder should be set up/tested? I
haven't used these features so far.
To test:
1) Choose an existing record from "Add order to basket" area either searching a
record or clicking "From a staged file" section
2) After you reach "New order" page for existing record you will see new
fieldset called "Existing items" which are existing items belong to a record
not previously ordered
3) When you choose item(s) from this new tab fields of "Accounting details" tab
will be automatically filled
4) When you finished click save button.
If you could at least enhance the first commit message that would be great.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #54 from Katrin Fischer --- I am sorry, but patches no longer apply, could you please rebase? Bug 14364 - Allow automatically canceled expired waiting holds to fill the next hold 128757 - Bug 14364: Allow automatically canceled expired waiting holds to fill the next hold 128758 - Bug 14364: (QA follow-up) Generate message for transfers as well 128759 - Bug 14364: (follow-up) Cleanup duplicate code and adjust notices and prefs Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14364: Allow automatically canceled expired waiting holds to fill the next hold Using index info to reconstruct a base tree... M C4/Reserves.pm M Koha/Hold.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging Koha/Hold.pm Auto-merging C4/Reserves.pm Applying: Bug 14364: (QA follow-up) Generate message for transfers as well Applying: Bug 14364: (follow-up) Cleanup duplicate code and adjust notices and prefs error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor Patch failed at 0001 Bug 14364: (follow-up) Cleanup duplicate code and adjust notices and prefs hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14364-follow-up-Cleanup-duplicate-code-and-adj-QGOiaL.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #336 from Katrin Fischer --- Patches still apply with a tiny rebase :) I've added the rebased patch set with 2 tiny follow-ups, but have some issues I am struggling with: 1) Tests don't pass and there is a warning that might relate to some rebase issue: kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. Subroutine libraries_where_can_see_patrons redefined at /kohadevbox/koha/Koha/Patron.pm line 1610. 2) Permission descriptions We now have: * Edit any item. If not set the logged in user can only edit items whose home library matches the logged in library. (edit_any_item) * Edit items (edit_items) I think we need to actually rephrase Edit items if the note on edit_any_item rings true. Also, we need to factor in the library group feature somehow... Edit all items with user's home library and from libaries within the edit item library group (edit_items) It makes me realize I am not super sure yet how the library groups and permissions work together, can you please check and maybe explain a little more? 3) Library groups Limit item editing for librarians outside of this group. Maybe this would be clearer as: Limit item editing to librarians inside of this group But I might be misunderstanding something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #335 from Katrin Fischer --- Created attachment 131697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131697=edit Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #334 from Katrin Fischer --- Created attachment 131696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131696=edit Bug 20256: (QA follow-up) Fix number of tests in Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128753|0 |1 is obsolete|| --- Comment #333 from Katrin Fischer --- Created attachment 131695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131695=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128752|0 |1 is obsolete|| --- Comment #332 from Katrin Fischer --- Created attachment 131694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131694=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128751|0 |1 is obsolete|| --- Comment #331 from Katrin Fischer --- Created attachment 131693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131693=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128750|0 |1 is obsolete|| --- Comment #330 from Katrin Fischer --- Created attachment 131692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131692=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128749|0 |1 is obsolete|| --- Comment #329 from Katrin Fischer --- Created attachment 131691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131691=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128748|0 |1 is obsolete|| --- Comment #328 from Katrin Fischer --- Created attachment 131690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131690=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128747|0 |1 is obsolete|| --- Comment #327 from Katrin Fischer --- Created attachment 131689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131689=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128746|0 |1 is obsolete|| --- Comment #326 from Katrin Fischer --- Created attachment 131688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131688=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128745|0 |1 is obsolete|| --- Comment #325 from Katrin Fischer --- Created attachment 131687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131687=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128744|0 |1 is obsolete|| --- Comment #324 from Katrin Fischer --- Created attachment 131686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131686=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128743|0 |1 is obsolete|| --- Comment #323 from Katrin Fischer --- Created attachment 131685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131685=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128742|0 |1 is obsolete|| --- Comment #322 from Katrin Fischer --- Created attachment 131684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131684=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128741|0 |1 is obsolete|| --- Comment #321 from Katrin Fischer --- Created attachment 131683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131683=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128740|0 |1 is obsolete|| --- Comment #320 from Katrin Fischer --- Created attachment 131682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131682=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128739|0 |1 is obsolete|| --- Comment #319 from Katrin Fischer --- Created attachment 131681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131681=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128738|0 |1 is obsolete|| --- Comment #318 from Katrin Fischer --- Created attachment 131680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131680=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128737|0 |1 is obsolete|| --- Comment #317 from Katrin Fischer --- Created attachment 131679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131679=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128736|0 |1 is obsolete|| --- Comment #316 from Katrin Fischer --- Created attachment 131678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131678=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128735|0 |1 is obsolete|| --- Comment #315 from Katrin Fischer --- Created attachment 131677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131677=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Katrin Fischer changed: What|Removed |Added Attachment #128734|0 |1 is obsolete|| --- Comment #314 from Katrin Fischer --- Created attachment 131676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131676=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- I am sorry, but these no longer apply, could you please rebase? Bug 27138 - Host items are not included in Z39 results when using EasyAnalytics 128175 - Bug 27138: Index host items in child records when sending to search engine 128176 - Bug 27138: (follow-up) Embed host items when performing index from command line 128177 - Bug 27138: Add preference EmbedHostItemsInSearchEngine 128178 - Bug 27138: Import needed subroutines 128179 - Bug 27138: (follow-up) Remove extraneous require and use Koha::Items Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27138: Index host items in child records when sending to search engine Applying: Bug 27138: (follow-up) Embed host items when performing index from command line Using index info to reconstruct a base tree... M Koha/BiblioUtils.pm Falling back to patching base and 3-way merge... Auto-merging Koha/BiblioUtils.pm Applying: Bug 27138: Add preference EmbedHostItemsInSearchEngine error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor Patch failed at 0001 Bug 27138: Add preference EmbedHostItemsInSearchEngine hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27138-Add-preference-EmbedHostItemsInSearchEng-GFwjoV.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #41 from Katrin Fischer --- (In reply to Katrin Fischer from comment #40) > Martin, are we missing your sign-off line here? I think you were the one to > switch to signed-off. > > Fixed the author line. Ping? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30248] Multiple Select elements randomly have small width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30248 Owen Leonard changed: What|Removed |Added Severity|enhancement |normal Version|unspecified |master Summary|Select2 elements randomly |Multiple Select elements |have small width|randomly have small width --- Comment #3 from Owen Leonard --- These use a different plugin: Multiple Select (https://multiple-select.wenzhixin.net.cn/). I don't see the described problem, so if someone is able to better isolate the conditions that cause it please let us know. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30259] [Omnibus] Standardize how lists of items are created in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30259 Owen Leonard changed: What|Removed |Added Status|REOPENED|NEW --- Comment #3 from Owen Leonard --- (In reply to Christopher Brannon from comment #2) > I would like to keep this open for consideration of having it work like > other digests I think reopening the report necessitates updating the bug title to be descriptive of the new goal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Owen Leonard changed: What|Removed |Added Attachment #131674|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 131675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131675=edit Bug 25251: Remove alert from disabled buttons This patch removes the alert, but adds a stopPropagation call in order to not close the menu when the disabled buttons are clicked To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated, menu is closed 6 - Apply patch 7 - Reload page 8 - Click on each disabled option and confirm - there is no more alert - the menu does not close 9 - Confirm tooltip is displayed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Nick Clemens changed: What|Removed |Added Attachment #131669|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 131674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131674=edit Bug 25251: Remove alert from disabled buttons This patch removes the alert, but adds a stopPropagation call in order to not close the menu when the disabled buttons are clicked To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated, menu is closed 6 - Apply patch 7 - Reload page 8 - Click on each disabled option and confirm - there is no more alert - the menu does not close 9 - Confirm tooltip is displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251
--- Comment #6 from Nick Clemens ---
(In reply to Owen Leonard from comment #5)
> Nick what would you think of this:
>
> $("#batchedit-disabled,#batchdelete-disabled,#deleteallitems-disabled")
> .on("click",function(e){
> -e.preventDefault();
> -alertNoItems();
> +e.stopPropagation();
> })
> .tooltip();
>
> This would remove the alert, but it would also prevent the menu from closing
> when the user clicks on a disabled link. This makes sense to me because a
> user clicking on a disabled link probably means they're not paying
> attention. In that case having nothing happen is better than having
> something happen (even if it's just the menu closing).
I would like that :-) I wanted it, but didn't know how to attain it - would you
like to add the followup?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251
--- Comment #5 from Owen Leonard ---
Nick what would you think of this:
$("#batchedit-disabled,#batchdelete-disabled,#deleteallitems-disabled")
.on("click",function(e){
-e.preventDefault();
-alertNoItems();
+e.stopPropagation();
})
.tooltip();
This would remove the alert, but it would also prevent the menu from closing
when the user clicks on a disabled link. This makes sense to me because a user
clicking on a disabled link probably means they're not paying attention. In
that case having nothing happen is better than having something happen (even if
it's just the menu closing).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 131673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131673=edit Bug 30059: Deal with timezones Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059
--- Comment #11 from Tomás Cohen Arazi ---
Created attachment 131672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131672=edit
Bug 30059: Add JS equivalent for Koha::Patron->get_age
On bug 30055 we are going to use the REST API to display the patron
search result, we will then need to calculate patron's age client-side.
This is moved to its own bug report in case we need to reuse it
somewhere else.
Test plan:
Copy/paste the JS function in your browser's console then call it and
confirm that the result is correct
For instance:
$get_age('2000-01-01')
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131309|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130665|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I think the links should be wrapped in a permissions check. My preference, I think, would be for the links to be smaller text links alongside the "See: News" links, but that's just a suggestion. My reasoning is that *usually* the buttons are reserved for "actions" not navigation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30058] Add a Koha::Patrons method to filter by permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 131671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131671=edit Bug 30058: Add Koha::Patrons->filter_by_have_subpermission This method will allow to filter a patron set by a given subpermission. It will be useful on bug 30055 where we want to display only patron with suggestion or acquisition subpermission. Note that it could be extended to allow several subpermissions, but we don't need it so far. Test plan: prove t/db_dependent/Koha/Patrons.t must return green Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30058] Add a Koha::Patrons method to filter by permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 Tomás Cohen Arazi changed: What|Removed |Added Attachment #130666|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30058] Add a Koha::Patrons method to filter by permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30058] Add a Koha::Patrons method to filter by permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Patch doesn't apply QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | --- Comment #86 from Tomás Cohen Arazi --- I'm sorry, can you please rebase the last patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30294] Rename Koha::Recall->* used relationship names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Tomás Cohen Arazi changed: What|Removed |Added Component|Acquisitions|Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30294] Rename Koha::Recall->* used relationship names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30294] Rename Koha::Recall->* used relationship names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 131670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131670=edit Bug 30294: Rename Koha::Recall->* used relationship names This patch renames the underlaying relationship names used in the 'patron' and 'library' subs so they are more clearly prefetchable and also enabling them to be embeddable and searchable through an eventual API route for recalls. To test: 1. Apply the patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Recall* => SUCCESS: Tests pass, nothing really changes 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 [Bug 30294] Rename Koha::Recall->* used relationship names -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30294] Rename Koha::Recall->* used relationship names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Tomás Cohen Arazi changed: What|Removed |Added Depends on||19532 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30294] New: Rename Koha::Recall->* used relationship names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30294 Bug ID: 30294 Summary: Rename Koha::Recall->* used relationship names Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Our coding guidelines are not quite precise regarding this, but in order to make accessors for related objects embeddable/searchable on the REST API, the relationships should share the name with the method, as the 'sub biblio' example in the guidelines: https://wiki.koha-community.org/wiki/Coding_Guidelines#Koha::Object.28s.29 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #908 from Tomás Cohen Arazi --- Ok, I removed the schema updates and hence the force=1 I added by mistake. This will need to be done by the RM as usual. I also removed the changes to the relationship names... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #4 from Nick Clemens --- Created attachment 131669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131669=edit Bug 25251: Remove alert from disabled buttons To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated 6 - Apply patch 7 - Reload page 8 - Confirm no more alert 9 - Confirm tooltip is displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Bug 7923 depends on bug 30085, which changed state. Bug 30085 Summary: Improve performance of CanItemBeReserved https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 Nick Clemens changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #15 from Nick Clemens --- Consider for backport? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 131668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131668=edit Bug 30183: Fetch flatPickr instance prior to custom search definition This patch updates teh search customisations in ill-list-table to properly fetch the existing flatpickr instances for date searches. To test: 1. Have at least one ILL request on the ILL requests page 2. Open the broser inspector 3. Choose a date on the left hand form => FAIL: Errors in the console, search doesn't work 4. Apply this patch 5. Reload 6. Repeat 2-3 => SUCCESS: No more errors, filtering works! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131661|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #1 from Owen Leonard --- In what way is the preview different than the actual email? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 The Minh Luong changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
--- Comment #270 from The Minh Luong ---
Created attachment 131667
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131667=edit
Bug 17015: DiscreteCalendar->new() method is now in a HASH
This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)
TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
~ The error "Can't use string ("branchcode") as a HASH ref while
"strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar
USING THE DISCRETE CALENDAR:
1- New UI
a) Calendar on the left
b) Holidays list on the right
2- New color system for holiday types:
a) Working day : white
b) Unique holiday: red
c) Holiday repeating weekly: yellow
d) Holiday repeating yearly: orange
e) Floating holiday: green
f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #907 from Tomás Cohen Arazi --- Created attachment 131666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131666=edit Bug 19532: (QA follow-up) POD and import fixes This fixes some library imports and POD. To test: 1. Apply this patch 2. Run the tests => SUCCESS: No change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #906 from Tomás Cohen Arazi --- Created attachment 131665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131665=edit Bug 19532: (QA follow-up) Simplify resultset accessors This patch makes the different ->recalls accessors implemented on this bug be more standard. This means: - They don't do special things like default sorting or stripping out special parameters. That's all left to the caller and the methods are clean: they just return the related objects - Useful filtering methods for Koha::Recalls resultsets are added. The only used one (in the end) was ->filter_by_current. It seems like a better approach, because it gives devs more control on how they want to chain things, and there's a single place in which to maintain the criteria of what is 'current' or 'finished'. This clearly makes the 'old' column obsolete IMHO, at least in the use cases I found. This is covered by tests as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #905 from Tomás Cohen Arazi --- Created attachment 131664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131664=edit Bug 19532: Make recalls.status an ENUM This patch makes the status attribute an ENUM, setting the default value as 'requested' as well. The chosen names are easier to read than single letters. Also, renamed F into fulfilled (this impacts methods names as well). This is because 'finished' or 'completed' is more a synonym for old => 1... Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131631|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131630|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131629|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30293] New: ODS report download inserts apostrophe in front of numerical results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30293 Bug ID: 30293 Summary: ODS report download inserts apostrophe in front of numerical results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: he...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When numerical report results are downloaded as ODS format, an apostrophe is inserted in front of the numbers. The result of this is that most functions in spreadsheet programs will not work since the software then doesn't consider those values numbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Andrew Fuerste-Henry --- > 4 - Confirm notices not sent if pref is set to follow messaging preference > and borrower > does not have preferences set for auto_renewals My patron got a non-digest auto-renew notice via email at this step, with the syspref set to follow patron messaging prefs and the patron's messaging prefs set to receive no auto-renew notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27462] Number of suggestions includes archived suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27462 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Martin Renvoize changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30183] ILL table search filtering broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
