[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439

--- Comment #12 from Victor Grousset/tuxayo  ---
Switched to critical (and the dependencies not yet backported) to be sure it's
not skipped for backports. Because it's really bad to not have a supported ES
implementation anymore. If something like the recent log4j critical security
vulnerabilities happens again, ES7 will be the only fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684

--- Comment #6 from Victor Grousset/tuxayo  ---
https://gitlab.com/koha-community/koha-testing-docker/-/issues/292

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key]

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|enhancement |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7)

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|normal  |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29596] Add Yiddish language

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596

--- Comment #23 from Victor Grousset/tuxayo  ---
Thanks, it makes sense. Noted here so it could help in the future:
https://wiki.koha-community.org/wiki/Translating_Koha#Adding_a_new_language

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29910] Purge old Hea data periodically

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910

--- Comment #18 from Victor Grousset/tuxayo  ---
Amazing thanks!

Now oldest reported version is 16.11 instead of 3.09!
Went from 54 million patrons to 40 million.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30319] New: Patron self-modification values not retained if field blocked in PatronSelfRegistrationBorrowerUnwantedField

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30319

Bug ID: 30319
   Summary: Patron self-modification values not retained if field
blocked in PatronSelfRegistrationBorrowerUnwantedField
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When a field is hidden for self-registration, Koha is mistakenly discarding
values for that field in self-modification. Somehow these two sysprefs are not
being enforced distinctly.

To test:
1 - turn on OPACPatronDetails
2 - confirm PatronSelfModificationBorrowerUnwantedField is blank, all fields
allowed
3 - set PatronSelfRegistrationBorrowerUnwantedField to hide Title
4 - log into the opac, go to self mod (/cgi-bin/koha/opac-memberentry.pl), set
a title (it is not hidden, which is correct), and save your updates
5 - go to the patron modification page in the staff interface
(/cgi-bin/koha/members/members-update.pl), confirm your modification request is
there but shows no changes
6 - update PatronSelfRegistrationBorrowerUnwantedField to allow title
7 - repeat step 4
8 - your new modification request shows a change to title

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20076] Overdues email to library for patrons without email should be optional

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30054

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30054] Add SMS equivalent to EmailOverduesNoEmail

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30054

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20076

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222

--- Comment #14 from Andrew Fuerste-Henry  ---
(In reply to Jonathan Druart from comment #13)
> IMO no more change should be done to this script before its code is moved
> and covered by tests.

I understand the need to move this code and add tests for it, but at the same
time this is a very real and immediate pain point for users and I would not
like to see this fix delayed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180

--- Comment #2 from George Veranis  ---
Created attachment 131933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131933=edit
Bug 11180: IP branch attribute should accept CIDR notation and add multiple ip

This patch adds the ability to set more than ip to IP setting of a branch and
also CIDR notation can recognised also.

Test plan:
1) Change systempreference AutoLocation to "Yes"
2) Go to the library settings ( Administration -> Libraries ) and you can add
   only one ip at format xxx.xxx.xxx.xxx or xxx.xxx.*
3) Apply patch
4) Go to the library settings and you can enter to IP setting
   those ip(s) you want seperate by space in any format like xxx.xxx.xxx.xxx or
   xxx.xxx.xxx.0/24 or xxx.xxx.xxx.* or only one also on the same formats.
3) Logout
4) Try to login from an ip that not belong on the set of ip that you enter
   before and now CIDR notation can regognized also and also you can have more
   than one ip for restriction.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180

George Veranis  changed:

   What|Removed |Added

Summary|IP branch attribute should  |IP branch attribute should
   |accept CIDR notation and|accept CIDR notation and
   |add multiple ip(s)  |add multiple ip

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation and add multiple ip(s)

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180

George Veranis  changed:

   What|Removed |Added

Summary|IP branch attribute should  |IP branch attribute should
   |accept CIDR notation|accept CIDR notation and
   ||add multiple ip(s)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

shi-yao.w...@inlibro.com changed:

   What|Removed |Added

 Attachment #131931|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

shi-yao.w...@inlibro.com changed:

   What|Removed |Added

 Attachment #131931|0   |1
is obsolete||

--- Comment #27 from shi-yao.w...@inlibro.com ---
Created attachment 131932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131932=edit
Bug 17983: Add minutes loan to DiscreteCalendar

This is an additional feature to our new Discrete Calendar.
Theses patches add the possibility to choose the loan unit as minutes in
circulations rules.

Test plan:
- Apply patch of Bugzilla 17015
- Apply this patch.
- Run test t/db_dependent/minutes_loan.t
- Create new item type for the new rule.
- Create circulation rule and fill the fields, make sure the unit is set to :
minutes, choose the item type of the one created above.-
- Checkout an item that follow the circulation rule and set due date in the
past.

- Run fines.pl.
- Check if the correct amount was calculated.
- Note: make sure to factor in the fine grace period if set and the system
preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #42 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #41)
> Why is it bad to use __()?
> It will get translated the usual way by translators.

I might be wrong, but have the feeling that any place in which all (say)
borrower table columns need to be displayed, will imply N file accesses if
there's no caching of the file.

I tested it to work correctly and didn't notice any drawbacks, but got me
thinking of the approach.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

shi-yao.w...@inlibro.com changed:

   What|Removed |Added

 Attachment #131929|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

shi-yao.w...@inlibro.com changed:

   What|Removed |Added

 CC||shi-yao.w...@inlibro.com
  Attachment #75480|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

shi-yao.w...@inlibro.com changed:

   What|Removed |Added

 Attachment #131930|0   |1
is obsolete||

--- Comment #26 from shi-yao.w...@inlibro.com ---
Created attachment 131931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131931=edit
Bug 17983: Add minutes loan to DiscreteCalendar

This is an additional feature to our new Discrete Calendar.
Theses patches add the possibility to choose the loan unit as minutes in
circulations rules.

Test plan:
- Apply patch of Bugzilla 17015
- Apply this patch.
- Run test t/db_dependent/minutes_loan.t
- Create new item type for the new rule.
- Create circulation rule and fill the fields, make sure the unit is set to :
minutes, choose the item type of the one created above.-
- Checkout an item that follow the circulation rule and set due date in the
past.

- Run fines.pl.
- Check if the correct amount was calculated.
- Note: make sure to factor in the fine grace period if set and the system
preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

--- Comment #25 from shi-yao.w...@inlibro.com ---
Created attachment 131930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131930=edit
Bug 17983: Add minutes loan to DiscreteCalendar

This is an additional feature to our new Discrete Calendar.
Theses patches add the possibility to choose the loan unit as minutes in
circulations rules.

Test plan:
- Apply patch of Bugzilla 17015
- Apply this patch.
- Run test t/db_dependent/minutes_loan.t
- Create new item type for the new rule.
- Create circulation rule and fill the fields, make sure the unit is set to :
minutes, choose the item type of the one created above.-
- Checkout an item that follow the circulation rule and set due date in the
past.

- Run fines.pl.
- Check if the correct amount was calculated.
- Note: make sure to factor in the fine grace period if set and the system
preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

--- Comment #24 from shi-yao.w...@inlibro.com ---
Created attachment 131929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131929=edit
fixed patch tests and minor adjustments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009

--- Comment #4 from Owen Leonard  ---
How does one create an invalid MARC record?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #41 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #40)
> Ok, it works. Tests pass.
> 
> The question is: is this what we want?
> 
> We are basically moving column descriptions handling into a better place
> (i.e. a Koha class that is more normal that what we had before), we are
> getting rid of a mix XML (columns.def) or json where those descriptions
> lived.
> 
> But on doing so we are:
> - Moving translatable strings to Koha::*
> - Adding some overhead by the way we use __.
> 
> It feels like overall is ok, but the descriptions should live in an external
> per-language file that is translated 'the usual way' and loaded only once
> when the class is instantiated (class?, it should be a proper class, so each
> process that instantiates it can initialize it with the current language).

Why is it bad to use __()?
It will get translated the usual way by translators.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30317] Replace the use of jQueryUI tabs on search history page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317

--- Comment #1 from Owen Leonard  ---
Created attachment 131928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131928=edit
Bug 30317: Replace the use of jQueryUI tabs on search history page

This patch replaces jQueryUI tabs on the staff interface's search
history page, replacing them with Bootstrap tabs.

To test, apply the patch and perform some bibliographic and
authority searches in the staff client if necessary.

Go to the search history page and test that the "Catalog" and
"Authority" tabs work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30317] Replace the use of jQueryUI tabs on search history page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180

--- Comment #1 from George Veranis  ---
Created attachment 131927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131927=edit
Bug 11180: IP branch attribute should accept CIDR notation

This patch adds the ability to set more than ip to IP setting of a branch and
also CIDR notation can recognised also.

Test plan:
1) Change systempreference AutoLocation to "Yes"
2) Go to the library settings ( Administration -> Libraries ) and you can add
   only one ip at format xxx.xxx.xxx.xxx or xxx.xxx.*
3) Apply patch
4) Go to the library settings and you can enter to IP setting
   those ip(s) you want seperate by space in any format like xxx.xxx.xxx.xxx or
   xxx.xxx.xxx.0/24 or xxx.xxx.xxx.* or only one also on the same formats.
3) Logout
4) Try to login from an ip that not belong on the set of ip that you enter
   before and now CIDR notation can regognized also and also you can have more
   than one ip for restriction.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11180] IP branch attribute should accept CIDR notation

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180

George Veranis  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30318] New: Cannot override default patron messaging preferences when creating a patron in staff client

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318

Bug ID: 30318
   Summary: Cannot override default patron messaging preferences
when creating a patron in staff client
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The issue appears to be in C4/Form/MessagingPreferences.pm  

73 sub handle_form_action {
...
104 if (! $prefs_set && $insert){
105 # this is new borrower, and we have no preferences set, use the
defaults
106 $target_params->{categorycode} = $categorycode;
107 C4::Members::Messaging::SetMessagingPreferencesFromDefaults(
$target_params );
108 }
...


To recreate:
1 - Enable EnhancedMessagingPreferences system preference
2 - Set some defaults for a category
3 - Create a new patron in this category
4 - Uncheck all messages before saving
5 - Note patron is created with the defaults set

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

   What|Removed |Added

 Depends on||30317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317
[Bug 30317] Replace the use of jQueryUI tabs on search history page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277

Owen Leonard  changed:

   What|Removed |Added

 Blocks||30317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317
[Bug 30317] Replace the use of jQueryUI tabs on search history page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30317] New: Replace the use of jQueryUI tabs on search history page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317

Bug ID: 30317
   Summary: Replace the use of jQueryUI tabs on search history
page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 29277
Blocks: 29226

As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should
replace the use of the jQueryUI tabs component on the search history page in
the staff interface.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277
[Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30316] Replace the use of jQueryUI tabs on MARC detail page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316

--- Comment #1 from Owen Leonard  ---
Created attachment 131926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131926=edit
Bug 30316: Replace the use of jQueryUI tabs on MARC detail page

This patch replaces jQueryUI tabs on the MARC detail page, replacing
them with Bootstrap tabs.

To test, apply the patch and locate a bibliographic record in the staff
client. View the MARC detail page for that record. Confirm that the
numered tabs work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30316] Replace the use of jQueryUI tabs on MARC detail page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #40 from Tomás Cohen Arazi  ---
Ok, it works. Tests pass.

The question is: is this what we want?

We are basically moving column descriptions handling into a better place (i.e.
a Koha class that is more normal that what we had before), we are getting rid
of a mix XML (columns.def) or json where those descriptions lived.

But on doing so we are:
- Moving translatable strings to Koha::*
- Adding some overhead by the way we use __.

It feels like overall is ok, but the descriptions should live in an external
per-language file that is translated 'the usual way' and loaded only once when
the class is instantiated (class?, it should be a proper class, so each process
that instantiates it can initialize it with the current language).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #39 from Tomás Cohen Arazi  ---
Created attachment 131925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131925=edit
Bug 29695: Add missing POD

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #38 from Tomás Cohen Arazi  ---
Created attachment 131924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131924=edit
Bug 29695: Remove columns.def

No longer in use

Test plan:
 % git grep 'columns.def'
does not return relevant occurrences

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #37 from Tomás Cohen Arazi  ---
Created attachment 131923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131923=edit
Bug 29695: Remove json files

We do no longer need them.

Test plan:
Confirm that their content are in Koha::Database::Columns

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 131922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131922=edit
Bug 29695: Make "modalselect" syspref's values translatable

We are using json files to retrieve the list of the DB columns. We can
reuse what we have done in the previous patch and display translated
strings.

Test plan:
Search for "unwanted" in the sysprefs

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #35 from Tomás Cohen Arazi  ---
Created attachment 131921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131921=edit
Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs

Same as the previous patch but for the inventory.

Test plan:
Same as before but test the inventory tool

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #34 from Tomás Cohen Arazi  ---
Created attachment 131920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131920=edit
Bug 29695: Remove C4::Reports::Guided::_get_column_defs

This subroutine was mostly the same as GetColumnDefs, we replace it
identically as in the previous patch.

Test plan:
Translate some strings in another language
 % gulp po:update --lang es-ES
 % cd misc/translate
 # Translate the relevant strings in po/es-ES-messages.po
 # For instance "Alternate contact: Surname"
 % perl translate install es-ES

Select the language for the interface (enable it in the 'language' syspref
first)

Create a new guided report and confirm that the columns for the borrowers
table are translated

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 131919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131919=edit
Bug 29695: Remove GetColumnDefs

C4::Templates::GetColumnDefs can easily be replaced using the new
Koha::Database::Columns module.

Test plan:
Go to the import patron tool and confirm that you see the same list of
patron's attribute on the import patron form.

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 131918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131918=edit
Bug 29695: Add new module Koha::Database::Columns

This module will contain new strings and make them translatable using
Koha::I18N.

We will need to improve this module to prevent the dozens of __ calls
each time we retrieve the column list. We could either use memcached or
add a method to only retrieve columns for a given table.

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #130111|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #130110|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #130109|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #130108|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #130107|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #130113|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #130112|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009

--- Comment #3 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #1)
> That's expected, there is a warning "the view may be degraded".
> This is not a bug IMO.

Sure, but problem is what we are passing, we should instead pass nothing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009

--- Comment #2 from Nick Clemens  ---
Created attachment 131917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131917=edit
Bug 30009: If no record set MARCNOTES undef, rather than empty array

Currently we pass an empty array if there is no marc record - this
is read as 'true' by template toolkit, and the desciptions tab is loaded

This patch just sets the variable as undef which is false

To test:
1 - Find or create an invalid marc record
2 - View in staff client
3 - Note tab Descriptions(1) has no content
4 - Apply patch, reload
5 - No empty tab

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

   What|Removed |Added

 Depends on||30316


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316
[Bug 30316] Replace the use of jQueryUI tabs on MARC detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277

Owen Leonard  changed:

   What|Removed |Added

 Blocks||30316


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316
[Bug 30316] Replace the use of jQueryUI tabs on MARC detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30316] New: Replace the use of jQueryUI tabs on MARC detail page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316

Bug ID: 30316
   Summary: Replace the use of jQueryUI tabs on MARC detail page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 29277
Blocks: 29226

As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should
replace the use of the jQueryUI tabs component on the MARC detail page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277
[Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

--- Comment #2 from Owen Leonard  ---
Created attachment 131916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131916=edit
Bug 3: Replace the use of jQueryUI tabs on the search engine configuration
page

This patch replaces jQueryUI tabs on the search engine configuration
page, replacing them with Bootstrap tabs.

To test, apply the patch and go to Administration -> Search engine
configuration.

- The "Search fields" tab should be selected by default, and the table
  should be initialized as a DataTable with sorting and filtering.
- When you switch to the "Bibliographic records" and "Authorities" tabs
  the tables on those tabs should also be initialized, each with
  filtering and drag-and-drop row re-ordering.
- All tables should continue to work correctly after switching back and
  forth between tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23838] Add ability to view item renew history

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #55 from Martin Renvoize  ---
Created attachment 131915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131915=edit
Bug 23838: Use $datetime formater

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23838] Add ability to view item renew history

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131892|0   |1
is obsolete||

--- Comment #54 from Martin Renvoize  ---
Created attachment 131914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131914=edit
Bug 23838: Add renewals modal

This patch adds the display of the renewals modal when appropriate. A
"View" link is displayed next to renewals count where appropriate.
Clicking the link opens the modal that displays the logged renewals.

Signed-off-by: Myka Kennedy Stephens 
Signed-off-by: Owen Leonard 
Signed-off-by: Bouzid Fergani 
Signed-off-by: Ben Veasey 

Rescued-by: Martin Renvoize 

I rescued this patchset by squashing previous work and updating it to
utilise the new renewals API routes introduced in bug 30275.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28881] Suggestion not displayed on the order receive page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881
Bug 28881 depends on bug 23376, which changed state.

Bug 23376 Summary: Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28627] Revert the order receive page to display 'Actual cost' as ecost_tax_included/ecost_tax_excluded if unitprice not set

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28627
Bug 28627 depends on bug 23376, which changed state.

Bug 23376 Summary: Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27671] Missing include in orderreceive.tt

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27671
Bug 27671 depends on bug 23376, which changed state.

Bug 23376 Summary: Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26730] Cannot receive orders

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730
Bug 26730 depends on bug 23376, which changed state.

Bug 23376 Summary: Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21811] Add warning when order receive form is saved without entering 'quantity received'

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811
Bug 21811 depends on bug 23376, which changed state.

Bug 23376 Summary: Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
Bug 8179 depends on bug 23376, which changed state.

Bug 23376 Summary: Cleanup order receive page code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23376] Cleanup order receive page code

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

Nick Clemens  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #29 from Nick Clemens  ---
(In reply to Emmi Takkinen from comment #28)
> Created attachment 131857 [details] [review]
> Bug 23376: Fix template error on order receive page
> 
> Order receive page dies on error 500 if orders quantityreceived
> is more than 0. The error logs reads: "Template process failed: undef
> error - The method Koha::Item->count is not covered by tests!"
> In template orderreceive.tt we have "order.items.count" not
> "orders.items.count" as it should be.  Note! It seems that this error
> doesn't occur if template param edit is set as 1.
> 
> To test:
> 1. Find order with quantityreceived value more than 0.
> 2. Try to receive this order.
> => Error 500 page is displayed.
> 3. Apply patch
> 4. Repeat steps 1 and 2.
> => Order receive page is displayed normally.
> 
> Sponsored-by: Koha-Suomi Oy

Please move this to a new bug, dependent on this one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30183] ILL table search filtering broken

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183

--- Comment #4 from Jonathan Druart  ---
It works but it's awkward. I was expecting to see $(selector).val() to retrieve
the formatted value, then use one of our JS function to get a Date() object.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30183] ILL table search filtering broken

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #131668|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 131913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131913=edit
Bug 30183: Fetch flatPickr instance prior to custom search definition

This patch updates teh search customisations in ill-list-table to
properly fetch the existing flatpickr instances for date searches.

To test:
1. Have at least one ILL request on the ILL requests page
2. Open the broser inspector
3. Choose a date on the left hand form
=> FAIL: Errors in the console, search doesn't work
4. Apply this patch
5. Reload
6. Repeat 2-3
=> SUCCESS: No more errors, filtering works!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30183] ILL table search filtering broken

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30183

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802

--- Comment #7 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #4)
> Please show that it breaks in your test. And that your change resolves that.

Tests updated and moved to own patch
> 
> And tell me what this does:
> +my $mocked_context = Test::MockModule->new('C4::Context');
> +$mocked_context->mock( 'yaml_preference', sub {
> +return { biblionumber => [ $biblio2->biblionumber ] };
> +});
> 
> I think it is useless code.

Looks like you are correct - copied from Items.t - seems to have been done for
convenience there, mocking pref directly works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802

Nick Clemens  changed:

   What|Removed |Added

 Attachment #131099|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 131912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131912=edit
Bug 29802: add 'me' to filter_by_visible_in_opac query

This patch prefixes all of the fields in OpacHiddenItems with
"me." before searching.

Unit tests added to cover this case1

To test:
1 - Create a public list
2 - Set OpacHiddenItems to:
biblionumber: [1]
3 - Attempt to view list in OPAC
4 - Booom
5 - Aply patch
6 - Reload list
7 - Success

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802

--- Comment #5 from Nick Clemens  ---
Created attachment 131911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131911=edit
Bug 29802: Unit tests

prove -v t/db_dependent/Koha/Items.t
prove -v t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

--- Comment #53 from Martin Renvoize  ---
The simplest way to test this is to test bug 23838 which relies on this
foundational patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29695] Centralize columns' descriptions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

--- Comment #52 from Martin Renvoize  ---
Created attachment 131910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131910=edit
Bug 30275: Add basic unit test for fetching renewals

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

--- Comment #51 from Martin Renvoize  ---
Created attachment 131909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131909=edit
Bug 30275: Fix checkouts.t unit test

We no longer require a mocked userenv for these tests to pass, we're
setting the userenv in api auth now. The mock just serves to break tests
for the renew method now that AddRenewal required a correctly set
userenv for 'number'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131890|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize  ---
Created attachment 131908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131908=edit
Bug 30275: Add alias to create renewal in api routes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131889|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize  ---
Created attachment 131907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131907=edit
Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131888|0   |1
is obsolete||

--- Comment #48 from Martin Renvoize  ---
Created attachment 131906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131906=edit
Bug 30275: Add renewals relation to Koha::Checkout

Add the new 'renewals' relation to Koha::Checkout to return a list of
Koha::Checkouts::Renewal objects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131887|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize  ---
Created attachment 131905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131905=edit
Bug 30275: Add 'renewals' relation to Issue Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131886|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize  ---
Created attachment 131904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131904=edit
Bug 30275: renewals_count DBIC Update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131885|0   |1
is obsolete||

--- Comment #45 from Martin Renvoize  ---
Created attachment 131903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131903=edit
Bug 30275: Rename issues.renewals to issues.renewals_count

Rename the issues.renewals field to renewals_count to prevent a method
name collision with the new relation accessor introduced by this
patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131884|0   |1
is obsolete||

--- Comment #44 from Martin Renvoize  ---
Created attachment 131902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131902=edit
Bug 30275: Add Koha::Objects for Renewals

Add Koha::Checkouts::Renewals|Renewal classes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131883|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize  ---
Created attachment 131901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131901=edit
Bug 30275: DBIC Schema Additions

Add checkout and old_checkout relations to CheckoutRenewal schema and
mark 'seen' as a boolean.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131882|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize  ---
Created attachment 131900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131900=edit
Bug 30275: Record renewals

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131881|0   |1
is obsolete||

--- Comment #41 from Martin Renvoize  ---
Created attachment 131899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131899=edit
Bug 30275: DBIC Schema Changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131880|0   |1
is obsolete||

--- Comment #40 from Martin Renvoize  ---
Created attachment 131898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131898=edit
Bug 30275: Generated kohastructure.sql

This kohastructure update was generated using `koha-dump --schema-only`
in koha-testing-docker once the atomicupdate had been run against the
previous atomicupdate patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #131879|0   |1
is obsolete||

--- Comment #39 from Martin Renvoize  ---
Created attachment 131897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131897=edit
Bug 30275: Add checkout_renewals table

This patch adds the new checkout_renewals table using an atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30003] Register entries doubled up if form fails validation on first submission

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #12 from Jonathan Druart  ---
I don't know if I am testing this correctly but with the patch I am not seeing
anything on pos/register.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #39 from Nick Clemens  ---
Everything works well, one issue I found:
If I add a new suggestion with acquisition library 'Any' I am returned to view
for logged in branch, but no suggestions are loaded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

--- Comment #38 from Nick Clemens  ---
Created attachment 131896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131896=edit
Bug 23991: (follow-up) Missing semicolon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item types administration page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998

--- Comment #1 from Owen Leonard  ---
Created attachment 131895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131895=edit
Bug 29998: Replace the use of jQueryUI tabs on item types administration page

This patch updates the item type edit interface so that it uses
Bootstrap tabs instead of jQueryUI tabs for displaying icon sets.

Unrelated: The patch removes an invalid "type" attribute from a 
element.

- Go to Administration -> Item types in the staff interface.
- Edit an item type.
- On the edit page you should see tabs under "Choose an icon."
- Confirm that the tabs look correct and work correctly.
- If you did not previously have any icon selected, the "None" tab
  should be active.
- If you had an icon selected, that icon set's tab should be active.
- Confirm that if you specify a remote image (e.g.
  https://via.placeholder.com/50/FF/FF.png ) the tab is
  correctly shown after you save and re-edit.
- Confirm that changing icons works correctly and that the selected
  icon's tab is always active when you return to the edit view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item types administration page

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #121181|0   |1
is obsolete||
 Attachment #131893|0   |1
is obsolete||

--- Comment #257 from Jonathan Druart  ---
Created attachment 131894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131894=edit
Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà

And in the body
✔❤★ aÄÄÄ Äãà éèà

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23838] Add ability to view item renew history

2022-03-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #53 from Martin Renvoize  ---
OK, I squashed the existing patches and reworked them slightly to use the new
API's introduced in bug 30275 to try and get this one moving again.

Keeping the signoff as the feature continue to work as it did in my testing,
but it worth a refreshed round of QA at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >