[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Aleisha Amohia changed: What|Removed |Added Text to go in the||This new release notes||check_marc_errors.pl script ||uses the MARC::Lint package ||to check bibliographic ||records for MARC errors, ||and print any errors found. ||The script can check all ||biblios, or specified ||biblios. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 --- Comment #1 from Aleisha Amohia --- Created attachment 131994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131994&action=edit Bug 30326: check_marc_errors.pl script which prints MARC errors This new check_marc_errors.pl script uses the MARC::Lint package to check bibliographic records for MARC errors, and print any errors found. The script can check all biblios, or specified biblios. To test: 1. Run the script from your commandline. This should not be run from within your koha shell. Replace the --intranet parameter with your staff client URL. sudo koha-shell kohadev -c "misc/cronjobs/check_marc_errors.pl --intranet http://localhost:8081/"; > /tmp/marc_errors.html 2. The above command will run the script for all biblios in your database and print the output to a file /tmp/marc_errors.html. View the file and confirm it has been populated as expected, with errors! cat /tmp/marc_errors.html 3. Run the script again, this time specify one or more biblionumbers. sudo koha-shell kohadev -c "misc/cronjobs/check_marc_errors.pl --bibnum 1 --bibnum 2 --bibnum 3 --intranet http://localhost:8081/"; > /tmp/marc_errors.html 4. Confirm the file is populated as expected cat /tmp/marc_errors.html Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Aleisha Amohia changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] New: Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Bug ID: 30326 Summary: Cronjob that checks biblios for MARC errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz It would be useful to have a script that could be run regularly which reported on biblios with MARC errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 --- Comment #18 from Fridolin Somers --- As Release Manager, I'm OK to change min version here. As long as we tell it in release notes. It is already ES 6 in https://wiki.koha-community.org/wiki/System_requirements_and_recommendations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Fridolin Somers changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30325] (Bug 30098 follow-up) Broken patron search redirect when one result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 --- Comment #1 from Fridolin Somers --- Created attachment 131993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131993&action=edit Bug 30325: (Bug 30098 follow-up) Fix broken patron search redirect when one result Bug 30098 fixed patron search behavior when a later page has only 1 result, but broke the redirect when there is only a single result from search. To test: 1 - Perform a patron search that returns 41 results, on koha-testing-docker, 'a' works 2 - Go to second page of results, works 3 - On third page you remain in results and are not redirected 4 - Perform a patron search that return only 1 result, name or cardnumber 5 - You get redirected to this patron page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30325] (Bug 30098 follow-up) Broken patron search redirect when one result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30325] (Bug 30098 follow-up) Broken patron search redirect when one result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 Fridolin Somers changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30325] (Bug 30098 follow-up) Broken patron search redirect when one result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 --- Comment #12 from Fridolin Somers --- (In reply to Jonathan Druart from comment #11) > This does not work. There is no redirect if only 1 patron is returned. Oh crap ! We did not saw this. I've opened Bug 30325. The fix from comment 3 looks perfect. Lets validate it fast for this month release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 Fridolin Somers changed: What|Removed |Added Blocks||30325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 [Bug 30325] (Bug 30098 follow-up) Broken patron search redirect when one result -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30325] (Bug 30098 follow-up) Broken patron search redirect when one result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 Fridolin Somers changed: What|Removed |Added Depends on||30098 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 [Bug 30098] Patron search redirects when one result on any page of results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30325] New: (Bug 30098 follow-up) Broken patron search redirect when one result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30325 Bug ID: 30325 Summary: (Bug 30098 follow-up) Broken patron search redirect when one result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 30098 fixed patron search behavior when a later page has only 1 result, but broke the redirect when there is only a single result from search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30265] Hide 'Log into your account' in OPAC authentication page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #8 from Fridolin Somers --- An example of this behavior : We don't show catalog search form in advanced search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29385] Add missing cash register support to SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 --- Comment #17 from Fridolin Somers --- (In reply to wainuiwitikapark from comment #16) > Does this need to be backported to 19.11.x? I bet not. Depends on Bug 24828 only in >= 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29857] We must stringify our exceptions correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #18 from Fridolin Somers --- > I think it should be different because it performs a different function. Ah OK I was not aware of that :) Tooltip text is a good first help. But a good icon would be nice. Maybe use "angle" icons to move up/down/top/bottom : https://fontawesome.com/v4/icon/angle-down https://fontawesome.com/v4/icon/angle-double-down And a "angle double down" with underline has 5th icon (toggle lowest priority). Meaning go to bottom and stick there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 --- Comment #10 from Aleisha Amohia --- Noting that I've written a patch for Bug 30250, also a follow-up of Bug 29146, which adds a system preference ApplyFrameworkDefaults to configure when to apply framework defaults - when cataloguing a new record, when editing a record as new (duplicating), or when changing the framework while editing an existing record. I could add a follow-up to my patch on Bug 30250 to also consider the instance of importing a record, whether we should apply framework defaults or not. I don't think we should hardcode a decision like that as libraries will have different ways of cataloguing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com CC||and...@bywatersolutions.com --- Comment #20 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > You also need to determinate which SMTP server to use (from which library?). Hi, I've tried to learn more about the feature to answer you, Jonathan. So correct me if I'm wrong. The feature is not that evolved. It is designed to generate the notice(s) in a directory (shared mount?). Print notices are generated in several ways which should be better documented. CHECKOUT is not one of them :-D Thanks to Andrew I now know that you can generate a print notice when trapping a hold for a patron with no valid email. Once you have that (it shows as 'print' on the patron's notices tab), I ran: $ perl misc/cronjobs/gather_print_notices.pl /tmp --email tomasco...@theke.io,and...@bywatersolutions.com --send --html As you will notice, the --send addresses list is not tied to any Koha feature. You just pass the addresses... I can forsee a development in which we could add print notices addesses configuration to libraries and a --library parameter to the print notices, but it will still require added a library_id column to the message_queue table. Anyway... The follow-up makes it work. It uses the default configured SMTP server. My config: smtp.gmail.com 587 50 starttls tomasco...@gmail.com xxx 1 The password I used was generated on the 'generate applilcation password' on my Google account. debug=1 made the SMTP session super verbose. And email arrived at destination :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 131992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131992&action=edit Bug 29501: Use the default transport This patch makes the script pass the default SMTP transport to the ->send_or_die call. The default is picked as this is the current behavior. New enhancements could add the *library_id* to the message_queue table, and allow using different transports depending on that. But it is out of the scope of this bug. To test: 1. Verify messages are being sent. 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 131991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131991&action=edit Bug 29501: (follow-up) Remove unused MIME::QuotedPrint dependency Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 131990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131990&action=edit Bug 29501: Remove MIME::Lite dependency The library usage is discouraged by the current maintainer and we don't use it in the codebase anymore. To test: 1. Apply this patch 2. Run: $ git grep MIME::Lite => SUCCESS: No uses of the removed library 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 131989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131989&action=edit Bug 29501: Make gather_print_notices.pl use Koha::Email This patch makes the cronjob script use Koha::Email and thus relying on configured SMTP settings instead of just trying localhost. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131447|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131446|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What|Removed |Added Attachment #131448|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > -unless $format =~ m[^html$|^csv$|^ods$]; > +unless $format =~ m/^html$|^csv$|^ods$/; > > Why? Unnecessary change. I think I did it tepmorarily and then forgot, because of this: https://snipboard.io/3GwSsV.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Assignee|jonathan.druart+koha@gmail. |oleon...@myacpl.org |com | --- Comment #95 from Jonathan Druart --- Can I get a signoff on those 2 patches please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Koha Team University Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #165 from Koha Team University Lyon 3 --- Hi, we would like to test this next week during the hackfest Marseille. Is someone still working on this ? Cheers, Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Jonathan Druart changed: What|Removed |Added Attachment #131987|0 |1 is obsolete|| --- Comment #94 from Jonathan Druart --- Created attachment 131988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131988&action=edit Bug 6815: Don't make an AJAX request to generate the modal moremember-patronimage.pl|tt were not needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #93 from Jonathan Druart --- Created attachment 131987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131987&action=edit Bug 6815: Don't make an AJAX request to generate the modal moremember-patronimage.pl|tt were not needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |jonathan.druart+koha@gmail. ||com QA Contact|katrin.fisc...@bsz-bw.de|jonathan.druart+koha@gmail. ||com Status|Signed Off |ASSIGNED --- Comment #92 from Jonathan Druart --- There is something completely wrong. The new pl and tt are useless, we just want to display a modal, we don't need an AJAX request. I am working on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 --- Comment #1 from Owen Leonard --- Created attachment 131986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131986&action=edit Bug 28082: Add acquisitions toolbar to vendors on vendor search page This patch makes a number of changes to the vendor search/view template in order to make it work better in different contexts: - Add a vendor-specific toolbar under each vendor search result. This gives instant access to the options for a new basket, new contract, vendor edit, or to receive shipments. A delete button will appear if available. - Add a summary of the number of baskets and subscriptions. This helps the user know if there are closed baskets and whether an outstanding subscription might be blocking the option to delete. Each number is linked to the view of those entries. - Indicate whether a vendor is inactive. The vendor name appears in a different color when it is inactve and is labeled as such. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - To test you should have multiple vendors in your system, some active and some inactive. Add some baskets and subscriptions to one or more if necessary. - Go to Acquisitions and submit an empty vendor search to show all vendors. - Verify that the page looks correct and that all controls work as expected. - Open the basket view for a single vendor and compare the two views. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #21 from Michael Hafen --- (In reply to Jonathan Druart from comment #20) > Your patch felt a bit dirty at first but I don't have anything else to > suggest actually. > I've added a follow-up patch to tidy a bit the code around your changes. > > I am wondering about the "$counted" variable. When do we need to increment > it? In my understanding it's correct with my patch (and was not before) but > I am not 100% sure. I'd say you are right about the $counted variable. You're follow up looks good. I prefer having the 'has the issue changed' check be closer to UpdateFine(), so that the chance of a race condition is as small as possible. But I could let that slide. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #91 from Jonathan Druart --- Created attachment 131985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131985&action=edit Bug 6815: Display an error in if HTTPS not used and webcam unavailable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #90 from Jonathan Druart --- From https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia """ Secure context: This feature is available only in secure contexts (HTTPS), in some or all supporting browsers. """ Ok, makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] error 500 in advanced editor
Dear Sir, I tried to activate the advanced editor in koha cataloging, but I countered the error 500 problem when I used it, can you help me with this please? Thanks in Advance ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #89 from Jonathan Druart --- (In reply to Jonathan Druart from comment #88) > It does not work for me, the browser does not ask for permission. > > I am getting the following error in the console after I clicked on "Add": > Uncaught TypeError: navigator.mediaDevices is undefined This was the Firefox error. And here is the chromium error: Uncaught TypeError: Cannot read properties of undefined (reading 'getUserMedia') -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 --- Comment #15 from Lucas Gass --- (In reply to Andrew Fuerste-Henry from comment #14) > (In reply to Jonathan Druart from comment #13) > > IMO no more change should be done to this script before its code is moved > > and covered by tests. > > I understand the need to move this code and add tests for it, but at the > same time this is a very real and immediate pain point for users and I would > not like to see this fix delayed. I agree with Andrew, this bug is causing patrons to receive unnecessary emails every day and becoming very painful for libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #88 from Jonathan Druart --- It does not work for me, the browser does not ask for permission. I am getting the following error in the console after I clicked on "Add": Uncaught TypeError: navigator.mediaDevices is undefined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30317] Replace the use of jQueryUI tabs on search history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30317] Replace the use of jQueryUI tabs on search history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317 Jonathan Druart changed: What|Removed |Added Attachment #131928|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 131984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131984&action=edit Bug 30317: Replace the use of jQueryUI tabs on search history page This patch replaces jQueryUI tabs on the staff interface's search history page, replacing them with Bootstrap tabs. To test, apply the patch and perform some bibliographic and authority searches in the staff client if necessary. Go to the search history page and test that the "Catalog" and "Authority" tabs work correctly. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30317] Replace the use of jQueryUI tabs on search history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30317 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30316] Replace the use of jQueryUI tabs on MARC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30316] Replace the use of jQueryUI tabs on MARC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316 Jonathan Druart changed: What|Removed |Added Attachment #131926|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 131983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131983&action=edit Bug 30316: Replace the use of jQueryUI tabs on MARC detail page This patch replaces jQueryUI tabs on the MARC detail page, replacing them with Bootstrap tabs. To test, apply the patch and locate a bibliographic record in the staff client. View the MARC detail page for that record. Confirm that the numered tabs work correctly. JD amended patch: removed commented line Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30316] Replace the use of jQueryUI tabs on MARC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30316 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 Jonathan Druart changed: What|Removed |Added Attachment #131386|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 131982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131982&action=edit Bug 30227: Replace the use of jQueryUI tabs on bibliographic detail page This patch replaces jQueryUI tabs on the bibliographic detail page, replacing them with Bootstrap tabs. To test, apply the patch and locate a bibliographic record in the staff client. Check the tabs on the detail page. Try to test as many variations as possible: - With and without holdings - With and without descriptions (5** note fields) - With alternate holdings (AlternateHoldingsField preference) - With HTML5 media (see Preferences -> Enhanced content -> HTML5 media) - With an associated suggestion - With an associated subscription - With acquisition information - With local cover images - With SeparateHoldings enabled - With other editions available (FRBRizeEditions) - With component parts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||30324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 [Bug 30324] Parent and child itemtype checkout limits not enforced as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30324] New: Parent and child itemtype checkout limits not enforced as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Bug ID: 30324 Summary: Parent and child itemtype checkout limits not enforced as expected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 21946 When creating rules or parent and child item types, checkout limits are enforced confusingly. To recreate: 1: have an itype BK 2: create an itype BK2, set BK as the parent to BK2 3: create a circ rule for All Patrons, item type BK (displays as "Books (All)" in the circ rules interface), setting total checkouts to 1 4: do not create any rule specifically for the BK2 itype 5: have some BK items and some BK2 items 6: check a BK item out to a patron 7: check a BK2 item out to the same patron, observe you are not blocked from doing so 8: try to check out a second BK2 item to the same patron, get message "Too many checked out. 1 checked out, only 1 are allowed." 9: try to check out a second BK item to the same patrons, get message "Too many checked out. 2 checked out, only 1 are allowed." 10: return both items 11: check a BK2 item out to your patron 12: try to check a BK item out to your patron, get message "Too many checked out. 1 checked out, only 1 are allowed." We're somehow not enforcing parent/child rules reciprocally. That forces me to explicitly define my child checkout limit, defeating some of the point of the enhancement from bug 21946. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 [Bug 21946] Group circulation by item type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30323] New: Wrong error messages on OPAC password recovery form when translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30323 Bug ID: 30323 Summary: Wrong error messages on OPAC password recovery form when translated Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org This is a bit of a curious bug in 20.11.16, not yet verified in newer versions: To test: * Activate the password recovery feature in OPAC * Install another language, de-DE or similar and activate it. With English templates: * Go to the OPAC and request a new password, verify success message is correct * Start over and do another new password request * You get an error message telling you that you have already requested a password and offering to resend the email = OK! With translated templates: * Repeat double password request steps like above * You get the general error message instead of the specific one as above. = NOT OK! I am not sure what could be going wrong there, we already checked the translations and everything there appears to be in order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Jonathan Druart --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/elasticsearch-mappings.js). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item types administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #3 from Jonathan Druart --- Tested and QAed with bug 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item types administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Jonathan Druart changed: What|Removed |Added Attachment #131895|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 131981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131981&action=edit Bug 29998: Replace the use of jQueryUI tabs on item types administration page This patch updates the item type edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Unrelated: The patch removes an invalid "type" attribute from a element. - Go to Administration -> Item types in the staff interface. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g. https://via.placeholder.com/50/FF/FF.png ) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item types administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 --- Comment #11 from Jonathan Druart --- Created attachment 131980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131980&action=edit Bug 2: (follow-up) Show the remote image tab if selected This follow-up corrects the markup so that if a value is entered in the "Remote image" field, the correct tab will be selected upon page load. The patch also corrrects the input name on the "No image" field so that the option works correctly. To test, apply the patch and edit an authorized value. - Select an icon from an icon set. Save, and then re-edit. - The correct icon set tab should be activated. - Select "No image," save, and re-edit. - The "No image" tab should be selected. - On the "Remote image" tab, enter a remote image url, e.g. https://via.placeholder.com/50/FF/FF.png. Save and re-edit. - The "Remote image" should be selected. Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Jonathan Druart changed: What|Removed |Added Attachment #131851|0 |1 is obsolete|| Attachment #131852|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 131979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131979&action=edit Bug 2: Replace the use of jQueryUI tabs on authorized values administration page This patch updates the authorized values edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Normally Bootstrap tabs don't have to be initiated via JavaScript, but this page requires some JS to select the first tab as active if no other tabs are active. Because of the way the template works it's not simple to do it via template logic, so in this case some JS helps. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Authorized values in the staff interface. - Select a category and then add or edit an authorized value in that category. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit page. Signed-off-by: Lucas Gass Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 --- Comment #9 from Jonathan Druart --- "No image" is not selected when imageurl is null, but it's not a regression. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 --- Comment #11 from Jonathan Druart --- (In reply to Lucas Gass from comment #9) > Jonathan, > > Your patch works nicely so I signed off and obsoleted Kyle's. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Jonathan Druart changed: What|Removed |Added Attachment #131973|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 131978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131978&action=edit Bug 30199: Do not generate jwt if patron does not exist This is a follow-up patch for bug 29543. If an invalid cardnumber has been used we should not generate a token. Test Plan: 1. Set SelfCheckoutByLogin to 'cardnumber'. 2. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3. Enter an invalid carnumber like 'thisisabadcardnumber' 4. See the appropriate message "Sorry The userid thisisabadcardnumber was not found in the database. Please try again." 5. Try again with a different cardnumber and notice the same exact error message including the 'thisisabadcardnumber' cardnumber. 6. Apply this patch 7. Restart all the things! 8. Repeat steps 2-4 9. Try again with a different cardnumber, you should now see the correct cardnumber! Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30310] Moment.js is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #18 from Jonathan Druart --- Created attachment 131977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131977&action=edit Bug 26328: Add test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 Jonathan Druart changed: What|Removed |Added Attachment #131592|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 131976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131976&action=edit Bug 26328: Cast barcode from varchar to integer for incremental barcode Without this patch, the incremental barcode generation will treat 978e0143019375 as having an exponent and interpret it as a very large number. With this patch, the incremental barcode generation will first cast barcode varchar strings to integers before finding a max() value. In this case 978e0143019375 becomes 978 instead of 1.7976931348623157e308 Test plan: 0. Using koha-testing-docker Before applying patch: 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=autobarcode 2. Set to "generated in the form 1, 2, 3" 3. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additema&searchid=scs_1607059974968 4. Add item with barcode 978e0143019375 5. Click "p - Barcode" 6. Note the barcode is "Inf" After applying patch: 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additema&searchid=scs_1607059974968 2. Click "p - Barcode" 3. Note the barcode is "319194" Signed-off-by: Marjorie Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 --- Comment #8 from Christopher Brannon --- (In reply to Jonathan Druart from comment #7) > I don't think this is 100% accurate. The script is also about cancellation, > suspend, modifying pickup library, etc. > > In my understanding if you have modify_holds_priority you should only be > allowed to modify the priority. This patch should not be touching any other aspect of holds. If it is, it wasn't caught through the testing plan. If it is allowing more that changing priorities, then it should fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #16 from Jonathan Druart --- Hey, you forgot the tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 --- Comment #17 from Kevin Carnes --- (In reply to Jonathan Druart from comment #16) > -requires 'Search::Elasticsearch', '5.01'; > +requires 'Search::Elasticsearch', '6.00'; > > Why this change in this patch? We certainly should upgrade our minimum > version, but it should be done on its own bug report. 6.00 is the minimum version that has track_total_hits in its API for search (look for track_total_hits in https://metacpan.org/release/DRTECH/Search-Elasticsearch-6.00/source/lib/Search/Elasticsearch/Client/6_0/Role/API.pm and https://metacpan.org/release/DRTECH/Search-Elasticsearch-5.02/source/lib/Search/Elasticsearch/Client/5_0/Role/API.pm) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30265] Hide 'Log into your account' in OPAC authentication page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #7 from Jonathan Druart --- Joubu> oleonard What's your opinion on bug 30265? oleonard> Joubu I don't think it's that confusing, but I don't object to the patch. Better safe than confusing. Joubu> To me it's confusing with the patch :) oleonard> Because you think folks will look for the link in the header and not find it? Joubu> yes oleonard> I think we'd have to do actual user testing to be sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #14 from Jonathan Druart --- Created attachment 131975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131975&action=edit Bug 26685: Move Starman out of debian/control.in and into cpanfile (2) defining package as 'recommended', as suggested Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Jonathan Druart changed: What|Removed |Added Attachment #131227|0 |1 is obsolete|| Attachment #131228|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 131974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131974&action=edit Bug 26685: Move starman out of debian/control.in and into cpanfile to test... - apply patch - build and install new package - confirm starman package displays correctly in about.pl page Signed-off-by: Mason James Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #12 from Jonathan Druart --- stretch (oldoldstable) 0.4014-1: all buster (oldstable) 0.4014-3: all bullseye (stable) 0.4015-1: all bookworm (testing) 0.4015-1: all sid (unstable) 0.4015-1: all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 --- Comment #9 from Lucas Gass --- Jonathan, Your patch works nicely so I signed off and obsoleted Kyle's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 --- Comment #7 from Caroline Cyr La Rose --- (In reply to Jonathan Druart from comment #6) > 2. Why did you put the new tab between "checkouts" and "holds"? I don't > think it's the more appropriate. Maybe just before "Restrictions"? Not that I want to get in the middle of the fire here, but I noticed the new tab is right next to the patron's own charge tab. I don't think it would be appropriate to separate the charges tab and the guarantee's charges tab, just like we didn't separate the patron's own checkout tab and the relative's checkout tab and put the latter before the patron's own holds tab. Anyway, just my grain of salt, I don't think the placement of the tab is a problem that should stall this bug. (I don't comment on the other thing about Koha::something bc I don't know what it means.) Caroline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Lucas Gass changed: What|Removed |Added Assignee|k...@bywatersolutions.com |jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Lucas Gass changed: What|Removed |Added Attachment #131364|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Lucas Gass changed: What|Removed |Added Attachment #131860|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 --- Comment #8 from Lucas Gass --- Created attachment 131973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131973&action=edit Bug 30199: Do not generate jtw if patron does not exist Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004
--- Comment #9 from Jonathan Druart ---
(In reply to David Nind from comment #4)
> Is there an easy way to generate 1,000 checkouts for a patron?
The following code will checkout all the items from the DB to the patron with
borrowernumber=51
use Modern::Perl;
use C4::Circulation qw( AddIssue );
use Koha::Items;
use Koha::Patrons;
use t::lib::Mocks;
my $patron = Koha::Patrons->find(51);
t::lib::Mocks::mock_userenv({patron => $patron});
my $items = Koha::Items->search;
my $patron_unblessed = $patron->unblessed;
while ( my $i = $items->next ) {
AddIssue($patron_unblessed, $i->barcode);
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Jonathan Druart changed: What|Removed |Added Attachment #131066|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 131972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131972&action=edit Bug 30004: Prevent TooMany from executing too many SQL queries If a maximum number of checkouts allowed is defined in circulation rules, C4::Circulation::TooMany will loop over all patron's checkouts. When a patron has several hundreds of checkouts, it can really slow down the checkout process by several seconds (or even tens of seconds) This patch does two things: - Always prefetch item data so that `$c->item` does not execute an additional SQL query at every iteration of the loop. Item data is always needed at the first line of the loop, so there is really no downside for doing this. - Build the `@types` array only once, out of the checkouts loop. Since it does not depend at all on patron's checkouts data, it does not make sense to build it inside the loop. Test plan: 1. Before applying the patch, create a patron with a lot of checkouts. I tested with 1000 checkouts, but the slowness should be noticeable with less. 2. Make sure you have a circulation rule (one that apply to your patron and the item(s) you will check out for testing) with a maximum number of checkouts allowed 3. Check out an item for the patron with a lot of checkouts. Measure the time it takes. 4. Apply the patch 5. Check out another item (or check in and then check out the same item used in step 3). Measure the time it takes and compare it to step 3. It should be faster now. 6. Run `prove t/db_dependent/Circulation/TooMany.t` Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #7 from Jonathan Druart --- Compared a call to CanBookBeIssued in a pl script, with 960 checkouts: Without patch: 4.3s With patch : 1.7s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > Sorry Marcel, I didn't you were assigned as QA contact here. Feel free to > switch it back to NQA if you want to have another look. No reason to :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 --- Comment #7 from Jonathan Druart --- Lucas, Kyle, could you test this alternative patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30265] Hide 'Log into your account' in OPAC authentication page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Jonathan Druart changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30265] Hide 'Log into your account' in OPAC authentication page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #6 from Jonathan Druart --- I am not sure about this change. We are introducing an inconsistency IMO. If you are used to click on the login button on the header, you will simply click it, no matter on which page you are. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25251] When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #9 from Jonathan Druart --- Shouldn't we tweak confirm_items_deletion a bit and remove alertNoItems? We wwill never reach it anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 --- Comment #10 from Jonathan Druart --- Sorry Marcel, I didn't you were assigned as QA contact here. Feel free to switch it back to NQA if you want to have another look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Jonathan Druart changed: What|Removed |Added Blocks||29802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 Jonathan Druart changed: What|Removed |Added Depends on||24254 CC||jonathan.druart+koha@gmail. ||com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 [Bug 24254] Add Koha::Items->filter_by_visible_in_opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 --- Comment #9 from Jonathan Druart --- Created attachment 131971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131971&action=edit Bug 29802: add 'me' to filter_by_visible_in_opac query This patch prefixes all of the fields in OpacHiddenItems with "me." before searching. Unit tests added to cover this case1 To test: 1 - Create a public list 2 - Set OpacHiddenItems to: biblionumber: [1] 3 - Attempt to view list in OPAC 4 - Booom 5 - Aply patch 6 - Reload list 7 - Success Signed-off-by: Fridolin Somers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
