[Koha-bugs] [Bug 30390] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30390 Katrin Fischer changed: What|Removed |Added Summary|What Is Cash App Clearance |SPAM |Fee Sugar Daddy When You| |Choose Instant Deposit? | Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30390] New: What Is Cash App Clearance Fee Sugar Daddy When You Choose Instant Deposit?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30390 Bug ID: 30390 Summary: What Is Cash App Clearance Fee Sugar Daddy When You Choose Instant Deposit? Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: starkjames...@gmail.com QA Contact: testo...@bugs.koha-community.org When you choose the instant deposit of your funds from your Cash App account, you have to pay 1.5% cash app clearance fee sugar daddy. However, if you are still having any kind of confusion regarding the same, you have to simply have a word with Cash App geeks who will clarify your worries and doubts in no time. https://www.cashapphelps.us/blog/cash-app-clearance-fee/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #87 from Mason James --- > prove -r t/db_dependent/Koha/REST/Plugin/PluginRoutes.t \ > t/db_dependent/api/v1 hi folks, i get a FAIL on this patchset with the new packages, on deb12 ...oops! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #86 from Mason James --- root@kohadevbox:koha(master)$ cat /etc/debian_version bookworm/sid root@kohadevbox:koha(master)$ dpkg -l | grep really ii libjson-validator-perl 5.99+really5.08-koha1 ii libmojolicious-perl9.90+really8.12-koha1 ii libmojolicious-plugin-openapi-perl 5.99+really5.05-koha1 root@kohadevbox:koha(master)$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t \ >t/db_dependent/api/v1 t/db_dependent/Koha/REST/Plugin/PluginRoutes.t . # Looks like you planned 3 tests but ran 1. t/db_dependent/Koha/REST/Plugin/PluginRoutes.t . 1/4 # Failed test 'Bad plugins tests' # at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 85. Can't locate object method "methods" via package "Mojolicious::Routes::Route" at t/db_dependent/Koha/REST/Plugin/PluginRoutes.t line 269. # Looks like your test exited with 255 just after 1. t/db_dependent/Koha/REST/Plugin/PluginRoutes.t . Dubious, test returned 255 (wstat 65280, 0xff00) Failed 4/4 subtests t/db_dependent/api/v1/acquisitions_funds.t . ok t/db_dependent/api/v1/acquisitions_orders.t ok t/db_dependent/api/v1/acquisitions_vendors.t ... ok t/db_dependent/api/v1/advanced_editor_macros.t . ok t/db_dependent/api/v1/article_requests.t ... ok t/db_dependent/api/v1/auth.t ... 1/3 # Failed test '200 OK' # at t/db_dependent/api/v1/auth.t line 133. # got: '404' # expected: '200' # Looks like you failed 1 test of 4. t/db_dependent/api/v1/auth.t ... 3/3 # Failed test 'spec retrieval tests' # at t/db_dependent/api/v1/auth.t line 138. # Looks like you failed 1 test of 3. t/db_dependent/api/v1/auth.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests t/db_dependent/api/v1/auth_authenticate_api_request.t .. ok t/db_dependent/api/v1/auth_basic.t . ok t/db_dependent/api/v1/biblios.t ok t/db_dependent/api/v1/cashups.t ok t/db_dependent/api/v1/checkouts.t .. ok t/db_dependent/api/v1/cities.t . ok t/db_dependent/api/v1/clubs_holds.t ok t/db_dependent/api/v1/holds.t .. ok t/db_dependent/api/v1/illrequests.t ok t/db_dependent/api/v1/import_batch_profiles.t .. ok t/db_dependent/api/v1/items.t .. ok t/db_dependent/api/v1/libraries.t .. ok t/db_dependent/api/v1/oauth.t .. ok t/db_dependent/api/v1/pagination.t . ok t/db_dependent/api/v1/patrons.t ok t/db_dependent/api/v1/patrons_accounts.t ... ok t/db_dependent/api/v1/patrons_extended_attributes.t ok t/db_dependent/api/v1/patrons_holds.t .. ok t/db_dependent/api/v1/patrons_password.t ... ok t/db_dependent/api/v1/return_claims.t .. ok t/db_dependent/api/v1/smtp_servers.t ... ok t/db_dependent/api/v1/stockrotationstage.t . ok t/db_dependent/api/v1/suggestions.t ok t/db_dependent/api/v1/transfer_limits.t ok t/db_dependent/api/v1/unhandled_exceptions.t ... ok Test Summary Report --- t/db_dependent/Koha/REST/Plugin/PluginRoutes.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 4 tests but ran 1. t/db_dependent/api/v1/auth.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=32, Tests=218, 396 wallclock secs ( 0.32 usr 0.30 sys + 313.25 cusr 75.65 csys = 389.52 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #11 from Aleisha Amohia --- Please take a look at the patches and ensure I caught all of the cases, and do a test of the recalls workflows to make sure everything is as normal with the updated column names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #10 from Aleisha Amohia --- Created attachment 132386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132386=edit Bug 30291: Changes to OPAC files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #9 from Aleisha Amohia --- Created attachment 132385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132385=edit Bug 30291: Changes to staff client files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #8 from Aleisha Amohia --- Created attachment 132384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132384=edit Bug 30291: Changes to controller scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #7 from Aleisha Amohia --- Created attachment 132383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132383=edit Bug 30291: Changes to tests t/db_dependent/Circulation.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Holds.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #6 from Aleisha Amohia --- Created attachment 132382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132382=edit Bug 30291: [DBIx] Package fixes in Recall schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #5 from Aleisha Amohia --- Created attachment 132381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132381=edit Bug 30291: [DBIx] Updating boolean flags in Recall schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #4 from Aleisha Amohia --- Created attachment 132380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132380=edit Bug 30291: [DBIx] Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 --- Comment #3 from Aleisha Amohia --- Created attachment 132379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132379=edit Bug 30291: Database changes to recalls table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30291] Rename recalls.* column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30291 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30382] Refreshing 'Desks menu' page duplicates desk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30382 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #1 from Lucas Gass --- Séverine, I am trying to recreate this but cannot. Is this the URL of the page you refresh to create a duplicate? /cgi-bin/koha/admin/desks.pl?op=add_form_id=1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30121] Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 --- Comment #6 from Lucas Gass --- Created attachment 132378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132378=edit Bug 30121: (follow-up) exclude relationship from PatronQuickAddFields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30121] Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30121] Cannot hide non-patron guarantor relationship via BorrowerUnwantedFields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30121 --- Comment #5 from Lucas Gass --- (In reply to Anneli Österman from comment #4) > Relationship option appears in PatronQuickAddFields but unchecking it > doesn't work when adding kid or juvenile via Quick add new patron. The > Relationship field is still mandatory (required) under the surname field. > > The relationship filed disappears if I emtpy borrowerRelationship but that > is not a good option because then the relationship field disappers from the > Patron guarantor also. > > (Sorry, I didn't know what to choose to the Status) Yes, that is a good catch. The field is not called relationship in the quick add field, instead it is called new_guarantor_relationship. So when we check relationship we get two fields new_guarantor_relationship and relationship. I think in this case we want to exclude relation ship for the PatronQuickAddFields pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Text to go in the||Add a new option for staff release notes||users to make changes to ||the contents of public ||lists from the staff client ||and OPAC. || ||This patchset ||also allows superlibrarian ||users, or those with the ||'edit_public_lists' ||sub-permission, to edit ||existing public lists to ||change them from 'owner ||only' allowed to change ||contents to 'Staff only'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #21 from Katrin Fischer --- I really love the change with the magnifying glass instead of "Go". A little more hesitant about the tooltip for SearchMyLibraryFirst, but I like that it will allow to hide the information if the library wants to, where before they would have had to manipulate the string with jQuery. Curious too to get Owen's opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Katrin Fischer changed: What|Removed |Added Attachment #132375|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 132377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132377=edit Bug 29066: (follow-up) add aria-label and aria-hidden on icons Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Katrin Fischer changed: What|Removed |Added Attachment #130114|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 132376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132376=edit Bug 29066: Remove text in OPAC search form and use Font Awesome icons In modern front-end websites, first think you see in header region is an large input text with a search icon. No need to say it is a search form. We still tell it in 'title' attribut for accessibility. This patch removes 'Search' text. If 'my library first' feature is enabled, shows a text in title of a question mark icon. In submit button, replaces 'Go' with a seach icon and add title 'Search'. Test plan : 1) 1.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Add' SearchMyLibraryFirst to 'Don't limit' 1.2) Go to OPAC main page 1.3) You don't see 'Search' anymore 1.4) You see in submit button an icon 1.5) Move mouse over submit button to see tooltip text 'Search' 2) 2.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Don't add' SearchMyLibraryFirst to 'Limit' 2.2) Go to OPAC main page 2.3) Log in 2.4) You don't see text 'Search (in ) only' 2.5) You see a question mark icon 2.6) Move mouse over submit button to see tooltip text 'Search (in ) only' Signed-off-by: Samu Heiskanen Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Katrin Fischer changed: What|Removed |Added Attachment #130115|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 132375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132375=edit Bug 29066: (follow-up) add aria-label and aria-hidden on icons Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30136] Add back to top button when scrolling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30136 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Hi Frido, can you please check? FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 220) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076
Katrin Fischer changed:
What|Removed |Added
Attachment #132324|0 |1
is obsolete||
--- Comment #7 from Katrin Fischer ---
Created attachment 132374
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132374=edit
Bug 30076: Add ability to check patron messaging preferences from a notice
Some libraries want to be able to use a patron's messaging preferences to
conditionally change the contents of a notice depending on the patron's other
messaging preference. For example, a library has requested to have the note on
the hold slip if the patron has requested phone messages for waiting holds.
This really only entails adding a method to the Koha::Patron class to allow
this type of looking.
Test plan:
1) Apply this patch
2) Enable item checkout notices for a patron for email, but not sms
3) Include the following in the notice:
TEST1: [% borrower.has_messaging_preference({ message_name =>
'Item_Checkout', message_transport_type => 'email' }) %]
TEST2: [% borrower.has_messaging_preference({ message_name =>
'Item_Checkout', message_transport_type => 'sms' }) %]
4) Generate a checkout and notice for that patron
5) Note the generated notice has a 1 for TEST1, but not for TEST2
Signed-off-by: Lucas Gass
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #129 from Alex Buckley --- (In reply to Katrin Fischer from comment #126) > Hi Alex, these are the results when I run the QA tools: > > Processing files before patches > |>| 13 / 13 (100.00%) > Processing files after patches > |>| 13 / 13 (100.00%) > > OK Koha/Patron.pm > OK Koha/Schema/Result/Virtualshelve.pm > OK Koha/Virtualshelf.pm > OK Koha/Virtualshelves.pm > FAIL installer/data/mysql/kohastructure.sql >FAIL tinyint_has_boolean_flag > The new column virtualshelves.public is using TINYINT(1) as > type but is > not defined as boolean in the schema file > (Koha/Schema/Result/Virtualshelve.pm), see the SQL12 coding guideline > The new column virtualshelves.allow_change_from_staff is using > TINYINT(1) > as type but is not defined as boolean in the schema file > (Koha/Schema/Result/Virtualshelve.pm), see the SQL12 coding guideline > > OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc > OK koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt > OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt > OK opac/opac-addbybiblionumber.pl > OK opac/opac-shelves.pl > OK t/db_dependent/Koha/Patron.t > FAIL t/db_dependent/Virtualshelves.t >FAIL spelling >thier ==> their > > OK virtualshelves/shelves.pl Hi Katrin, Could you please re-run the QA test tool now after applying the fourth patch on this bug report? Hopefully, that will fix up those QA errors. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #128 from Alex Buckley --- Created attachment 132373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132373=edit Bug 26346: (follow-up) Fixing for QA tool Adding is_boolean to virtualshelves.public and virtualshelves.allow_change_from_staff in Virtualshelve.pm DBIC schema file. Fixing typo in Virtualshelves.t Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Katrin Fischer changed: What|Removed |Added Attachment #132297|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 132372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132372=edit Bug 29609: Centralized code to build the link to a biblio detail page There are 2 prefs that control the default view of biblio detail pages: IntranetBiblioDefaultView for staff and BiblioDefaultView for OPAC. There are as well viewISBD, viewLabeledMARC and viewMARC to allow/don't allow access to those page for staff members. This code need to be in a single place to avoid discrepancy. Test plan: Play with BiblioDefaultView and IntranetBiblioDefaultView and confirm that the links of biblio point to the correct view. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #127 from Alex Buckley --- Hi Katrin, Thank you very much, I'll get onto fixing this right away! Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #126 from Katrin Fischer --- Hi Alex, these are the results when I run the QA tools: Processing files before patches |>| 13 / 13 (100.00%) Processing files after patches |>| 13 / 13 (100.00%) OK Koha/Patron.pm OK Koha/Schema/Result/Virtualshelve.pm OK Koha/Virtualshelf.pm OK Koha/Virtualshelves.pm FAIL installer/data/mysql/kohastructure.sql FAIL tinyint_has_boolean_flag The new column virtualshelves.public is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Virtualshelve.pm), see the SQL12 coding guideline The new column virtualshelves.allow_change_from_staff is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Virtualshelve.pm), see the SQL12 coding guideline OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt OK opac/opac-addbybiblionumber.pl OK opac/opac-shelves.pl OK t/db_dependent/Koha/Patron.t FAIL t/db_dependent/Virtualshelves.t FAIL spelling thier ==> their OK virtualshelves/shelves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30107] When editing a desk, the currently logged in library is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer changed: What|Removed |Added Attachment #132331|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 132371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132371=edit Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. 6. Try making a new desk and make sure it defaults to the logged in branch Signed-off-by: Séverine Queune Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30107] When editing a desk, the currently logged in library is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30107] When editing a desk, the currently logged in library is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer changed: What|Removed |Added Text to go in the|Corrects a problem on the |Corrects a problem on the release notes|adminitration page for |administration page for |circulation desks where the |circulation desks where the |default library was always |default library was always |being set to the logged in |being set to the logged in |library instead of the |library instead of the |library of the desk.|library of the desk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #15 from Alex Buckley --- Thanks for testing and QA Andrew and Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30107] When editing a desk, the currently logged in library is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer changed: What|Removed |Added Text to go in the|Corrects a problem on the |Corrects a problem on the release notes|circulation desk page where |adminitration page for |the default library was |circulation desks where the |always being set to the |default library was always |logged in library instead |being set to the logged in |of the library of the desk. |library instead of the ||library of the desk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30107] When editing a desk, the currently logged in library is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer changed: What|Removed |Added Text to go in the|Corrects a problem on the |Corrects a problem on the release notes|Circulation desk page where |circulation desk page where |the default library was |the default library was |always being set to the |always being set to the |logged in library instead |logged in library instead |of the library of the desk. |of the library of the desk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #27 from Katrin Fischer --- I wonder if it would make sense to have a separate preference, but I think we can leave that to the libraries using Syndetics :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #26 from Katrin Fischer --- Created attachment 132370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132370=edit Bug 21225: (QA follow-up) Update pref description of SyndeticsCoverImages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer changed: What|Removed |Added Attachment #132357|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 132369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132369=edit Bug 21225: (follow-up) correct filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer changed: What|Removed |Added Attachment #130698|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 132368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132368=edit Bug 21225: (follow-up) Account for Syndetics lightbox To test: -Make sure when you apply all the patches that when you click on the Syndetics image in the detail page that it correctly displays the lightbox. -Turn on some other cover image services and make sure you can toggle through each of them. Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer changed: What|Removed |Added Attachment #130697|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 132367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132367=edit Bug 21225: (follow-up) Make SyndeticCovers work on catalog detail page Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer changed: What|Removed |Added Attachment #130696|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 132366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132366=edit Bug 21225: Add Syndetics cover images to staff client. To test: 1 - Enable system preferences: SyndeticsEnabled SyndeticsCoverImages SyndeticsClientCode (you will need a valid code for testing) 2 - Perform a search on the staff client 3 - Check that results have images if upc,oclc number, or isbn existin record 4 - Confirm that dtails paeg displays same image 5 - Confirm size on details page follows syspref SyndeticsCoverImageSize Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Lucas Gass changed: What|Removed |Added Summary|IndependentBranches allows |IndependentBranches allows |users to change libraries |users to change libraries |when the should not be able |when they should not be |to |able to -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 --- Comment #12 from Lucas Gass --- Created attachment 132365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132365=edit Bug 22659: (follow-up) Add category to redirect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #60 from The Minh Luong --- Created attachment 132364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132364=edit Bug 27113: Rebase and correct autocomplete appearance Rebase of previous patches and correct the buggy behavior (See "GIF showing buggy behavior attachment") Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #59 from The Minh Luong --- Created attachment 132363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132363=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #58 from The Minh Luong --- Created attachment 132362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132362=edit Bug 27113: (follow-up) Correction with Session I have changed CGI::Session->new() from CGI::Session->load() for use session. This condition - 'CGI::Session->load() or die CGI::Session->errstr();' I am not sure that was good idea to use 'die' in this condition...What do you think? Thanks! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #57 from The Minh Luong --- Created attachment 132361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132361=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 The Minh Luong changed: What|Removed |Added Attachment #131207|0 |1 is obsolete|| Attachment #131208|0 |1 is obsolete|| Attachment #131209|0 |1 is obsolete|| Attachment #131210|0 |1 is obsolete|| Attachment #131211|0 |1 is obsolete|| --- Comment #56 from The Minh Luong --- Created attachment 132360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132360=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 --- Comment #1 from Owen Leonard --- Created attachment 132359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132359=edit Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC file This patch updates addorderiso2709.tt so that it uses Bootstrap tabs intead of jQuery. The patch contains indentation changes, so diff accordingly. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that the tabs work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30389] New: Switch to Bootstrap tabs on the page for adding orders from MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 Bug ID: 30389 Summary: Switch to Bootstrap tabs on the page for adding orders from MARC file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30388 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the 'Add orders from MARC file' page with Bootstrap tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 [Bug 30388] Fix some errors in the template for ordering from a MARC file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30388] Fix some errors in the template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Owen Leonard changed: What|Removed |Added Blocks||30389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389 [Bug 30389] Switch to Bootstrap tabs on the page for adding orders from MARC file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30383] Column suggestion is too wide when displaying more than 20 suggestions (suggestion.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30383 --- Comment #2 from Marjorie Barry-Vila --- (In reply to Owen Leonard from comment #1) > I don't see this problem in my test system. What version of Koha are you > using? Hi, I tested on 20.05.03. Looks like it mostly concerns the Accepted tab https://www.screencast.com/t/smvcBvOlvnc Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30383] Column suggestion is too wide when displaying more than 20 suggestions (suggestion.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30383 --- Comment #1 from Owen Leonard --- I don't see this problem in my test system. What version of Koha are you using? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30388] Fix some errors in the template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 --- Comment #1 from Owen Leonard --- Created attachment 132358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132358=edit Bug 30388: Fix some errors in the template for ordering from a MARC file This patch fixes a few markup errors in the addorder2709 template. The modal dialog markup is corrected and moved out of the loop of records so that it doesn't create repeating id attributes. Obsolete CSS is removed, fixing the width of the MARC preview modal. The calendar include is added, fixing a Flatpickr error in the console. Double ID attributes are removed from the Statistics 1 and Statistics 2 fields. To test, apply the patch and test the process of adding an order to a basket from a staged MARC file. Test in particular: - The MARC and Card previews - The "Date acquired" field under the "Item information" tab should trigger a Flatpickr widget. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30388] Fix some errors in the template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30388] Fix some errors in the template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Owen Leonard changed: What|Removed |Added Summary|Fixe some errors in the |Fix some errors in the |template for ordering from |template for ordering from |a MARC file |a MARC file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #21 from Lucas Gass --- Created attachment 132357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132357=edit Bug 21225: (follow-up) correct filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #19 from Lucas Gass --- rebased changes from Bug 30387 on to this patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #18 from Lucas Gass --- Created attachment 132356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132356=edit Bug 29887: (follow-up) Create a system pref category for Independent branches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #17 from Lucas Gass --- Created attachment 132355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132355=edit Bug 29887: (follow-up) show all branches to non superlibraians Signed-off-by: Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #16 from Lucas Gass --- Created attachment 132354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132354=edit Bug 29887: database update Signed-off-by: Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Attachment #130674|0 |1 is obsolete|| Attachment #130675|0 |1 is obsolete|| Attachment #130676|0 |1 is obsolete|| Attachment #131380|0 |1 is obsolete|| --- Comment #15 from Lucas Gass --- Created attachment 132353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132353=edit Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches Signed-off-by: Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when the should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 --- Comment #1 from Lucas Gass --- Created attachment 132352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132352=edit Bug 30387: Only allow superlibrarians to set library with IndependentBranches enabled To test: 1. Turn on IndependentBranches. 2. Give a staff member editcatalogue permissions but not superlibrarian permissions. 3. Once logged in as that staff member click on the name in the top right corner, notice that the 'Set library' button is there. 4. Turn on the CircSidebar system preference and go to any page that includes the CircSidebar. ( returns.tt, circulation,tt ). Notcie the Set library button is visibile. 5. Go to '/cgi-bin/koha/circ/set-library.pl', notice you can set your library to something else. 6. Apply patch 7. Again with the staff member who has editcatalogue permissions but not superlibrarian permissions try steps 3-5. This time you should not see the 'Set library' links. On '/cgi-bin/koha/circ/set-library.pl' you should not be able to change your library. 8. With a superlibrarian try steps 3-5, you should see the 'Set library' links and on '/cgi-bin/koha/circ/set-library.pl' you should be able to set your library 9. Turn on 'UseCirculationDesks'. 10. When repeating 3-5 make sure you can see only the 'Set desk' links while logged in as the non-superlibrarian. On '/cgi-bin/koha/circ/set-library.pl' you should only be able to 'Set desk'. 11. Now with a staff member who has neither superlibrarian permissions OR editcatalogue permissions do steps 3-5. You should NOT see the 'Set library links' but you should see the 'Set desk' links. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when the should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30384] Reindent template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Owen Leonard changed: What|Removed |Added Blocks||30388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 [Bug 30388] Fixe some errors in the template for ordering from a MARC file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30388] New: Fixe some errors in the template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 Bug ID: 30388 Summary: Fixe some errors in the template for ordering from a MARC file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 30384 While working on Bug 30384 I noticed some small fixes to be done in the addorderiso2709 template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 [Bug 30384] Reindent template for ordering from a MARC file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30384] Reindent template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 --- Comment #2 from Owen Leonard --- Created attachment 132351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132351=edit Bug 30384: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30384] Reindent template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 --- Comment #1 from Owen Leonard --- Created attachment 132350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132350=edit Bug 30384: Reindent template for ordering from a MARC file This patch updates the template for ordering from a MARC file so that the indentation is consistent. This patch does not fix a couple of bugs which will be fixed in a later patch: The MARC modal window has the wrong width, and there is a Flatpickr error in the console. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that everything still works correctly: - Tabs work correctly - JavaScript controls (select all, show inactive, etc.) work - MARC and Card previews work - Adding orders works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30384] Reindent template for ordering from a MARC file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when the should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Lucas Gass changed: What|Removed |Added Blocks||29887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Depends on||30387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 [Bug 30387] IndependentBranches allows users to change libraries when the should not be able to -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] New: IndependentBranches allows users to change libraries when the should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Bug ID: 30387 Summary: IndependentBranches allows users to change libraries when the should not be able to Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When IndependentBranches is turned on it should prevent all non-superlibrarians from changing their logged in branch. There are a few places where it incorrectly will allow non-superlibrarians with CAN_user_editcatalogue_edit_catalogue permissions to change their library. -circ-nav.inc -header.inc -set-library.tt With IndependentBranches turned on only super librarians should be allowed to change libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Katrin Fischer changed: What|Removed |Added Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16723] Add additional subscription fields to serial claim notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16723 --- Comment #1 from Katrin Fischer --- Is this maybe possible with TT somehow? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30386] Prevent search errors if deleted record still remains in search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30386 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30386] Prevent search errors if deleted record still remains in search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30386 --- Comment #1 from Kyle M Hall --- Created attachment 132349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132349=edit Bug 30386: Prevent search errors if deleted record still remains in search indexes If a bib is deleted, but for some reason doesn't get deleted from the search indexes, any search where that record is a result will produce the error: Can't call method "items" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 2064. Test Plan: 1) Enable item-level_itypes 2) Create 3 records in Koha that share a word 3) Search for that word, note your 3+ results 4) Delete one of those recordst from the database using koha-mysql 5) Search for the word again 6) Note the error! 7) Apply this patch 8) Search for the word again 9) Note you get results! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30386] Prevent search errors if deleted record still remains in search indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30386 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17506] Offline circ needs to be logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- Looking at the code for this today, it appears that checkouts and renewals *will* get written to the action logs from offline circ, but returns are not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #54 from Jonathan Druart --- Created attachment 132348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132348=edit Bug 29810: Add 'x-koha-embed' to reserved words The maintainers of Mojolicious::Plugin::OpenAPI and friends fixed the problem with using collectionFormat for Headers in the upstream library. However, this highlighted an outstanding issue in our code when I ran the unit tests. We have not been stripping x-koha-embed at the query level as it did not exist in the reserved_words list. This patch resolves that and gets the acquisitions_orders test passing again. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #53 from Jonathan Druart --- Created attachment 132347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132347=edit Bug 29810: Document x-koha-embed header on orders endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #52 from Jonathan Druart --- Created attachment 132346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132346=edit Bug 29810: Document x-koha-embed header on libraries endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #51 from Jonathan Druart --- Created attachment 132345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132345=edit Bug 29810: Document x-koha-embed header on cash registers endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #50 from Jonathan Druart --- Created attachment 132344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132344=edit Bug 29810: Document x-koha-embed header on biblios endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #49 from Jonathan Druart --- Created attachment 132343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132343=edit Bug 29810: Document x-koha-embed header on checkouts endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #48 from Jonathan Druart --- Created attachment 132342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132342=edit Bug 29810: Document x-koha-embed header on patrons endpoints Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Jonathan Druart changed: What|Removed |Added Attachment #132255|0 |1 is obsolete|| Attachment #132256|0 |1 is obsolete|| Attachment #132257|0 |1 is obsolete|| Attachment #132258|0 |1 is obsolete|| Attachment #132259|0 |1 is obsolete|| Attachment #132260|0 |1 is obsolete|| Attachment #132261|0 |1 is obsolete|| Attachment #132262|0 |1 is obsolete|| --- Comment #47 from Jonathan Druart --- Created attachment 132341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132341=edit Bug 29810: Add summary of x-koha-embed header to api spec Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #85 from Jonathan Druart --- Created attachment 132340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132340=edit Bug 30194: (follow-up) Remove reference to swagger-v2-schema This file is now bundled directly an no longer needs to be refered to separately. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #84 from Jonathan Druart --- Created attachment 132339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132339=edit Bug 30194: (follow-up) Simply OpenAPI Specification This patch simplifies the specification directory further by doing the following: * Inlines paths.yml into swagger.yaml * Inlines definitions.yaml into swagger.yaml * Inlines parameters.yaml into swagger.yaml * Drops x-primitives.yaml Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194
--- Comment #83 from Jonathan Druart ---
Created attachment 132338
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132338=edit
Bug 30194: Auto generate swagger.yaml
It was not sorted correct and had inconsistencies.
use YAML;
use File::Slurp qw( write_file );
my $hash = YAML::LoadFile('api/v1/swagger/swagger.yaml');
YAML::Bless($hash)->keys([qw(swagger basePath definitions parameters paths info
tags)]);
my $info = $hash->{info};
YAML::Bless($info)->keys([qw(title version license contact description)]);
my $yaml= YAML::Dump($hash);
$yaml =~ s|'|"|xmsg;
write_file('api/v1/swagger/swagger.yaml', $yaml);
Signed-off-by: Martin Renvoize
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #82 from Jonathan Druart --- Created attachment 132337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132337=edit Bug 30194: (26351 follow-up) Silence useless warning Every place in which Koha::Plugin::Test is loaded, and a patron is updated, this hook needs to be silenced. To reproduce: 1. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/PluginRoutes.t => FAIL: There's a warn about patron_barcode_transform 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Mason James Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
