[Koha-bugs] [Bug 28477] INTRANET and OPAC loggers should print to STDERR instead of to file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28477 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25384] Label maker font list is not configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|cnighswon...@foundations.ed ||u -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28011] Add CLI script to update bibs from linked authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28011 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26055] Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25523] Address lintian warnings when packaging Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25523 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22344] Limits cannot contain parentheses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22344 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12442] Query... variables should be defined within loop in Search.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12442 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24781] Parse and build query strings more reliably
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24781 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26586] Koha should return a SIP2 64 response to a 63 request for fee items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26586 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21359] Add RDF support to OAI-PMH harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21359 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18585] Connect to RDF triplestore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28457] cleanup_database.pl self-registration options are not configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28457 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #36 from David Cook --- Should the status of this one be updated? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26684] Remove 'marc' column from auth_header table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26684 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11583] Add WYSIWYG editor for HTML notices/letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26305] Warn IE users of staff interface that it is no longer supported and to use a supported browser instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26305 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #6 from Tomás Cohen Arazi --- (In reply to David Cook from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > There's a clear example in the patches. > > Thanks > > I suppose the plugin's "name" isn't usable since it's human-friendly and not > machine friendly. > > I suppose free text and auto-generated both have their pros and cons... The main problem is how big the column needs to be. I suggest you go try and sign the patches. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 132952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132952=edit Bug 30360: Add methods for dealing with the JSON payload This patch adds high-level methods to handle the JSON payload (de)serialization as needed. This allows devs implementing background jobs to abstract themselves from the internals of the jobs handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/BackgroundJob.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 --- Comment #4 from Tomás Cohen Arazi --- Can we move this forward to be closer to finish this cleaning stage? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #13 from Jake Deery --- Thanks for all your input, Katrin! I'll probably be back with some more questions, when I think of some. I need to get into the habit of using IRC to chat with everyone! :-) I can see this as being possibly a very good way to add new functionality, though! Take CSS, where we could introduce CSS::Sass to the mix and make OpacUserCss work with SASS for some super cool results (OpacUserScss)!! Or with JavaScript::JSLint for JavaScript validation prior to save ;-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #12 from Katrin Fischer --- I'll have to leave those questions for someone else I am afraid - a bit out of my depth here. :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #11 from Jake Deery --- Thank you, so far it's been very mild, so thankfully I'm feeling I will pass through it quickly and be able to return to normality soon! That's a valid point! Plus, provided the file is being stored somewhere that is unlikely to be touched, it shouldn't be an issue (assuming the static file route is chosen). I believe this is the case, too, using Memcached? While this is definitely beneficial from a performance standpoint, if delivering via a Perl script is chosen, it still wouldn't be quite as fast as using static files with 'Expire' headers set in the Apache2 config. In theory - the weight of Perl could be reduced a bit by moving this stuff out to static files! But it does come with the downside of having to manage the static file, and handle the behaviour quirks of that file being managed. My experience in Koha is still quite new - so I don't know how good it is at things like file management and database access! Do you think Koha/Perl is performant enough to make the benefit of static files worthwhile? And do you think on busier systems, the reduction of frequent dynamic requests to a Perl script would be beneficial enough to warrant a static file in place of a Perl script request? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #10 from Katrin Fischer --- Hi Jake - first of all: hope you feel better soon! I worry about having silly suggestions too, so maybe that is not related :) I am not sure if save and rebuild being separate makes sense, if you save, you'd probably want to see if it works? I believe we cache system preferences, so maybe there would not necessary be a database call for every page. Would that change things? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #9 from Jake Deery --- Katrin - I didn't realise you could set 'unsafe-inline'. That would be a great first step, and something we could probably implement quite quickly with minimal disruption :-) The OpacUserJs problem is one that will need more thought and discussion. There are many ways to solve it, each with different benefits and drawbacks in my eyes * You could keep everything in the database, and have a Perl script fetch it on each pageload. E.g. . This has the benefit of keeping everything in the database, but the drawback of being slow (you're making a dynamic call on each pageload). * Or, you can keep everything in the database, and rebuild a file when you save the syspref. For example, using a filehandler to write to somewhere in /var/lib/koha (or another location, /tmp maybe?). This has the benefit of being faster and cachable using Apache headers, but the drawback of maybe being inconsistent for sites that are configured poorly. * The other option is to maybe do a bit of both? Keep everything in the database, but have the option in the Koha sysprefs page of having a save button and a rebuild button separate from each other. So you can manually rebuild the JS file in the filesystem if it becomes unusable or missing! Of course, these are ideas - and I have COVID at the moment, so I may be writing 100 words where I would usually find what I need to say in ten. Again - open discussion; please say if you think these ideas are all silly, or not useful for Koha's usecase. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #8 from Katrin Fischer --- New to the topic, so I hope what I gathered from reading documentation is about right: "Aiming for default-src https: is a great first goal, as it disables inline code and requires https. For existing websites with large codebases that would require too much work to disable inline scripts, default-src https: 'unsafe-inline' is still helpful, as it keeps resources from being accidentally loaded over http. However, it does not provide any XSS protection." I think disabling all inline script would cause quite a lot of side effects at this point in time. I believe, we do still have page specific JS. Maybe we should start with default-src https: 'unsafe-inline' ? Content-Security-Policy-Report-Only might also be useful to get a better idea of the work that needs to be done. We'd also definitely need a solution for OpacUserJs and it needs to be something that doesn't require anything server side to be triggered manually as a lot of libraries don't have easy access. I know we have some use cases where we load external Javascript libraries for tracking, cookie banners and catalog enrichment. Would we need to be able to set script-src in configuration in order to keep that working? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 Tomás Cohen Arazi changed: What|Removed |Added Attachment #132950|0 |1 is obsolete|| --- Comment #29 from Tomás Cohen Arazi --- Created attachment 132951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132951=edit Bug 27783: Add queue handling in packaging tools This patch adds queue name handling in is_worker_running and a handy method to centralize process name handling for queue-specific workers. To test: 1. Apply this patch 2. Run: $ source debian/scripts/koha-functions.sh $ get_worker_name kohadev kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev default kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev long_tasks kohadev-koha-worker-long_tasks => SUCCESS: Queue name appended to the name 4. Run: $ perl misc4dev/cp_debian_files.pl \ --koha_dir /kohadevbox/koha \ --gitify /kohadevbox/gitify \ --instance kohadev 5. Run: $ koha-worker --start --queue oleonard kohadev => SUCCESS: Starts! 6. Check: $ ps waux | grep oleonard => SUCCESS: It is running 7. Play with --stop, --restart, --status and different queue names, including 'default' and without the --queue param as well. => SUCCESS: All as expected! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 132950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132950=edit Bug 27783: Add queue handling in packaging tools This patch adds queue name handling in is_worker_running and a handy method to centralize process name handling for queue-specific workers. To test: 1. Apply this patch 2. Run: $ source debian/scripts/koha-functions.sh $ get_worker_name kohadev kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev default kohadev-koha-worker => SUCCESS: Default queue means no queue name included $ get_worker_name kohadev long_tasks kohadev-koha-worker-long_tasks => SUCCESS: Queue name appended to the name 4. Run: $ perl misc4dev/cp_debian_files.pl \ --koha_dir /kohadevbox/koha \ --gitify /kohadevbox/gitify \ --instance kohadev 5. Run: $ koha-worker --start --queue oleonard kohadev => SUCCESS: Starts! 6. Check: $ ps waux | grep oleonard => SUCCESS: It is running 7. Play with --stop, --restart, --status and different queue names, including 'default' and without the --queue param as well. => SUCCESS: All as expected! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30451] Delete a subscription delete the linked order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 --- Comment #1 from Katrin Fischer --- +1 The least would be a warning, but I also think it should just 'unlink' the subscription from the order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- +my $patron = Koha::Patrons->find({ userid => $q_userid }) if $q_userid; "my $var if condition" does not meet the coding guidelines, at least I hope so :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17506] Offline circ needs to be logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506 --- Comment #2 from Rebecca Coert --- I agree with Christopher - all Offline Circulation transactions should be logged for possible troubleshooting. Issues, Renewals AND Returns. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15750] Koha offline circulation Firefox addon does not prompt to clear old entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15750 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- Comment #1 from Rebecca Coert --- This would be a useful addition to the add-on and I completely support the request. We recently had an issue where transactions from 2021 were uploaded and processed because staff did not clear the data beforehand. Having a prompt at the beginning of a session would help alleviate any errors of this nature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30114] Koha offline circulation will always cancel the next hold when issuing item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #26 from Owen Leonard --- Thank you for the follow-up Hayley! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Attachment #132918|0 |1 is obsolete|| --- Comment #25 from Owen Leonard --- Created attachment 132949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132949=edit Bug 12029: (follow-up) Adhering to coding guidelines This is a follow-up patch which (based on comment #19) does the following: 1) Removes newline from top of Koha/Patron/Messages.pm 2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread 3) Removes method Koha::Patron::Messages->unread_count 4) (Will address tests in separate patch) 5) Removes changes to Koha/Schema/Result/Message.pm 6) Changes atomicupdate from qq{} to q{} 7) (Left for RM) 8) Removes extra copyright statement in opac/dismiss_message.pl 9) Removes extra comments from opac/dismiss_message.pl 10) (Left for now) 11) (Left for now) Sponsored-by: Horowhenua Library Trust Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #19 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Owen Leonard from comment #17) > > I'm getting an error from the test: > > > > t/db_dependent/HoldsQueue.t .. 1/58 No property queue for > > Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue# Looks like your test > > exited with 11 just after 2. > > t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) > > Failed 56/58 subtests > > > > Test Summary Report > > --- > > t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 2 Failed: 0) > > Non-zero exit status: 11 > > Parse errors: Bad plan. You planned 58 tests but ran 2. > > You need to run dbic on one of the dependencies I've added a [DO NOT PUSH] patch on bug 27783 for that. Please retry :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27783] Introduce background job queues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 132948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132948=edit Bug 27783: DBIC update [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 [Bug 30454] Convert holds awaiting pickup tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30454] New: Convert holds awaiting pickup tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454 Bug ID: 30454 Summary: Convert holds awaiting pickup tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the holds awaiting pickup template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29695] Centralize columns' descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #43) > (In reply to Tomás Cohen Arazi from comment #42) > > (In reply to Jonathan Druart from comment #41) > > > Why is it bad to use __()? > > > It will get translated the usual way by translators. > > > > I might be wrong, but have the feeling that any place in which all (say) > > borrower table columns need to be displayed, will imply N file accesses if > > there's no caching of the file. > > You are wrong. Translations are cached, see Koha::I18N->init Thanks for explaining! > > I tested it to work correctly and didn't notice any drawbacks, but got me > > thinking of the approach. > > This is the correct way, we need to let perl code access the translation of > columns. Think CSV headers for instance, now we have to use TT for that, and > build the CSV manually when we could use a dedicated library (Text::CSV_XS > in our case). See also the code for reports to see how easy it is now. Gotcha. This is ready then :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #26 from Owen Leonard --- I'm not trying to derail the progress of this patch, but I thought this follow-up would be helpful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #25 from Owen Leonard --- Created attachment 132947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132947=edit Bug 29066: (follow-up) Use tooltip when SearchMyLibraryFirst in effect This patch proposes to add a Bootstrap tooltip to the OPAC masthead's search field to indicate to the user when SearchMyLibraryFirst is in effect. I think this lets the form layout stay clean-looking and is more informative to the user because they don't have to look for the HTML title tag tooltip. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Global system preferences. - Set the OpacAddMastheadLibraryPulldown preference to "Don't add." - Set the SearchMyLibraryFirst preference to "Limit." - Go to the OPAC and confirm that the main search field in the masthead has a filter icon in the background, indicating that searches will be limited. - Hover your mouse over the search field and a tooltip should pop up, "Searching in only" - The message should also be triggered when you click inside the form field. - Change the OpacAddMastheadLibraryPulldown and SearchMyLibraryFirst preferences again and the form should return to its normal behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Thibault Keromnès changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #23 from Thibault Keromnès --- Does what it's supposed to do but we need to clarify a few changes in the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 Jake Deery changed: What|Removed |Added CC|jake.de...@ptfs-europe.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #7 from Jake Deery --- Hi Michal, I agree; long-term, having a syspref or sysprefs to manage these things would be preferable. In the meantime, I think our starting goal should be implementing something along the lines of: # Disable unsafe inline/eval, only allow loading of resources (images, fonts, scripts, etc.) over https # Note that this does not provide any XSS protection Content-Security-Policy: default-src https: ... as a basic (mandatory) rule. It does not provide any real security gains, but it begins to encourage good practice regarding not placing JavaScript inline in future (as it simply won't work). Once we've covered this as a base, I think that would be the time to move on to adding stricter and more customisable CSP headers. Discussion time; what are everyone's thoughts on this? I could perhaps write a patch as a proof-of-concept? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What|Removed |Added Depends on||30453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 [Bug 30453] Convert offline circulation tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30453] New: Convert offline circulation tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 Bug ID: 30453 Summary: Convert offline circulation tabs to Bootstrap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the offline circulation template with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #132945|0 |1 is obsolete|| --- Comment #65 from Shi Yao Wang --- Created attachment 132946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132946=edit Bug 27113: Removes items in OPACHiddenItems from autocomplete Items specified in OPACHiddenItems preference are removed from search suggestions in OPAC. Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. 11- Search for an item with basic search and click on one of the options. 12- Notice it automatically sends you to the selected items page. 13- This time, search an item using the advanced search and click on one of the options. 14- Notice it just writes the chosen option in the input instead. 15- Go to Administration -> system preferences -> OPACHiddenItems. 16- Define a rule that applies to an existing item. 17- Search that item in OPAC and notice it doesn't give you the suggestion for that item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #64 from Shi Yao Wang --- Sorry. I meant double nested loops. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com --- Comment #63 from Shi Yao Wang --- My concern is that searching with more than 1 prefix is going to be too slow when there are lots of items since it will go through a triple nested loop. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30452] New: Add ability to use more than one Claims Returned status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30452 Bug ID: 30452 Summary: Add ability to use more than one Claims Returned status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Other systems distinguish between "claims returned" and "claims never had." To replicate this distinction, it would be helpful if Koha could tie multiple LOST values to claims and allow the user to select which to use when creating the claim. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #62 from Shi Yao Wang --- Created attachment 132945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132945=edit Bug 27113: Removes items in OPACHiddenItems from autocomplete Items specified in OPACHiddenItems preference are removed from search suggestions in OPAC. Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. 11- Search for an item with basic search and click on one of the options. 12- Notice it automatically sends you to the selected items page. 13- This time, search an item using the advanced search and click on one of the options. 14- Notice it just writes the chosen option in the input instead. 15- Go to Administration -> system preferences -> OPACHiddenItems. 16- Define a rule that applies to an existing item. 17- Search that item in OPAC and notice it doesn't give you the suggestion for that item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 --- Comment #25 from Owen Leonard --- Created attachment 132944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132944=edit Bug 28371: Passpreviously fetched branches and itemtypes through and fetch all needed AV at once This patch updates the searchResuls code to pass through the pre-constructed branches and itemtype lookups to XSLTParse4Display to avoid repeating this It also updates getAuthorisedValues4MARCSubfields to fetch the values for mapped subfields and pass then through to transforMarc4XSLT Note that we currently blank invalid branches and itemtypes - I presrve this, we should open another bug if we want to change this behaviour Changes are covered by tests To test: 1 - Perform searches in OPAC and staff client that return many records 2 - Use the 'Network' tab on the browser console (opened with F12 usually) to see the time taken 3 - Note the speed before the patch 4 - Apply patch 5 - restart all the things 6 - Note improvement in speed **Note: The improvement is more drastic the more items per record, try adding large numbers of items to your search results to test** Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Owen Leonard changed: What|Removed |Added Attachment #132801|0 |1 is obsolete|| Attachment #132802|0 |1 is obsolete|| --- Comment #24 from Owen Leonard --- Created attachment 132943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132943=edit Bug 28371: Unit tests Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30451] New: Delete a subscription delete the linked order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Bug ID: 30451 Summary: Delete a subscription delete the linked order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: severine.que...@bulac.fr QA Contact: testo...@bugs.koha-community.org Several issues happened when you delete a subscription linked to an order : - the warning message doesn't mentioned an existing order - the deletion of the subscription deleted the order too. That's annoying... I think the deletion should only empty the aqorder.subscriptionid datafield. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #6 from Michal Denar --- Hi, we can take inspiration from VuFind. It's not in Perl, but the basic principle is the same or similar. https://vufind.org/wiki/administration:security:content_security_policy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22632] Add logging of merged patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30450] New: Batch extend due dates should filter on-site checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30450 Bug ID: 30450 Summary: Batch extend due dates should filter on-site checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: severine.que...@bulac.fr QA Contact: testo...@bugs.koha-community.org The 'batch extend due dates' menu should have an option to unselect/exclude on-site checkouts form the batch modification. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20397] Implement Content Security Policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #5 from Jake Deery --- Hi, We are seeing more and more customers flag this in their security audits. Is there anything that can be done to expedite this bug (I was planning on taking a look at this myself in the near future, but if anyone has already taken an in-depth look, I would be more than happy to collaborate / offer a helping hand). In the land of Moodle, of which I was previously familiar, we used a combination of a SASS compiler to generate and deposit CSS user customisations from database to a file, and JShint to do the same for user JS user customisations. This has the added benefit of not having to call a Perl script more than once. Could this be applicable to Koha's usecase? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27859] MARC export for search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||severine.que...@bulac.fr --- Comment #10 from Séverine Queune --- Sorry David, patch needs rebase :/ Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27859: marc search result export Using index info to reconstruct a base tree... M Koha/SearchEngine/Elasticsearch/Search.pm M catalogue/search.pl M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging catalogue/search.pl Auto-merging Koha/SearchEngine/Elasticsearch/Search.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 27859: marc search result export hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28264] Transaction type is empty in cash register statistics wizard report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 --- Comment #10 from Katrin Fischer --- I see this problem in a 20.11.16 :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|Needs Signoff |Failed QA --- Comment #4 from Séverine Queune --- I not sure I totally understood the expected behaviour of this patch, but here as some feedback about my first quick tests. If patrons have several entries for one attribute, the batch modification replace all the attributes by only the new value. I assume so but can you confirm it's the behaviour expected ? I also noticed : - when I check the box to empty the field, I still have empty entries in database instead of having no entries at all, e.g; : select * from borrower_attributes --> id borrowernumber codeattribute --> 124 21 discMaths --> 125 21 disc --> 126 21 discMaths Shouldn't line 125 have been deleted ? -you can create several empty datas : to reproduce, select an attribute, checkbox the box, add the same attribute and check the box again. Is there a way to lock the use of an attribute that is selected 'to delete' ? Expect that points, I've tests with both free input and authorized values linked attributes and it seems to work quite fine. Failed though for the empty data issues in borrower_attributes table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Owen Leonard from comment #17) > I'm getting an error from the test: > > t/db_dependent/HoldsQueue.t .. 1/58 No property queue for > Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue# Looks like your test > exited with 11 just after 2. > t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) > Failed 56/58 subtests > > Test Summary Report > --- > t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 2 Failed: 0) > Non-zero exit status: 11 > Parse errors: Bad plan. You planned 58 tests but ran 2. You need to run dbic on one of the dependencies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #37 from David Gustafsson --- Created attachment 132942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132942=edit Bug 29440: Fix QA-tool issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- I'm getting an error from the test: t/db_dependent/HoldsQueue.t .. 1/58 No property queue for Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue# Looks like your test exited with 11 just after 2. t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 56/58 subtests Test Summary Report --- t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 2 Failed: 0) Non-zero exit status: 11 Parse errors: Bad plan. You planned 58 tests but ran 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news and HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|Needs Signoff |Failed QA --- Comment #13 from Séverine Queune --- If I follow Katrin's test plan : 1) Add a new HTML customization 2) Leave title empty 3) Save and continue --> no more redirection problems Katrin found, but the 'Content' field is reset This problem (or expected behaviour ?) exists for 'News' menu but only for the language specific tabs. For 'Default' tab, we have a warning pop-up asking to specify a title. I think it should be the same for 'HTML customization' menu. I also noticed that for HTML menu, it's possible to save a content only for a specific language without any content in 'Default' : is that expected ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30358] Strip leading/trailing whitespace characters from input fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- This seems to work but the test does pass: t/db_dependent/Biblio/ModBiblioMarc.t .. 1/2 # Failed test 'Title still has whitespace characters because StripWhitespaceChars is disabled' # at t/db_dependent/Biblio/ModBiblioMarc.t line 67. # got: 'My title' # expected: ' My title # ' # Looks like you failed 1 test of 3. # Failed test 'StripWhitespaceChars tests' # at t/db_dependent/Biblio/ModBiblioMarc.t line 75. # Looks like you failed 1 test of 2. t/db_dependent/Biblio/ModBiblioMarc.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Owen Leonard changed: What|Removed |Added Attachment #132935|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 132941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132941=edit Bug 30447: Check if transfers arrived or cancelled TO test: 1 - Find a bib with a single item 2 - Browse to Circulation->Transfer 3 - Transfer the item to another branch 4 - Check the item in at current branch and cancel the transfer on the dialog 5 - Place a hold on the biblio for a patron at current branch 6 - Browse to Circulation->Holds to pull 7 - Item does not show 8 - Apply patch, restart all 9 - Browse to Circulation->Holds to pull 10 - Item shows Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #5 from Séverine Queune --- Nice re-indentation Owen ! Everything seemed ok for me using the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What|Removed |Added Attachment #132866|0 |1 is obsolete|| --- Comment #4 from Séverine Queune --- Created attachment 132940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132940=edit Bug 30424: (follow-up) Markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What|Removed |Added Attachment #132865|0 |1 is obsolete|| --- Comment #3 from Séverine Queune --- Created attachment 132939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132939=edit Bug 30424: Reindent advanced search template in the staff interface This patch reindents the advanced search template. Some lines have been split to make the markup more readable. To test, apply the patch and test the advanced search page in the staff interface. Everything should work as normal. Be sure to test both the "More options" and "Fewer options" views. When viewing the diff for this change, ignore whitespace. The only visible changes should be split lines. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30424] Reindent advanced search template in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30424 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #75 from David Gustafsson --- Thanks again for the feedback, I think at least the most important issues should now be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Owen Leonard changed: What|Removed |Added Attachment #132494|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 132938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132938=edit Bug 30402: Import authorities subroutines to ImportBatch script The following authorities subroutines are used by the ImportBatch script but are not accessible, because they aren't imported. This caused MARC importing errors. - GetAuthorityXML - ModAuthority - DelAuthority These affected the BatchCommitRecords and BatchRevertRecords routines, and it wasn't caught because there are no tests written for them. To test: 1. Find an existing authority record, or import one to use. 2. Save this authority record (export/download). 3. Go to Admin -> Record matching rules. Create a new record matching rule for authorities that matches on 001, Local-Number index. 4. Go to Tools -> Stage MARC for import. Upload the authority file you just downloaded. 5. Change record type to authority. 6. Under 'Look for existing items in catalog?', set the record matching rule to the rule you just made which matches on 001. If matching record found, replace the existing one. If no match is found, ignore. 7. Stage the record. Once complete, a match should've been found. 8. Go to Staged MARC management. 9. Import the batch into the catalog. Notice it hangs and never completes. 10. Apply the patch and restart services. 11. Repeat steps 4-9. This time importing should be successful. Sponsored-by: Educational Services Australia SCIS Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30402] Authority import hanging when replacing matched record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30402 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #74 from David Gustafsson --- Created attachment 132937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132937=edit Bug 20551: Refactor unmotivated partially applied validator function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #73 from David Gustafsson --- Created attachment 132936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132936=edit Bug 20551: Fetch deleted biblios through _get_record_export -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com --- Comment #20 from Kelly McElligott --- *** Bug 30448 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30448] CircConfirmItemParts works differently depending on staff permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30448 Kelly McElligott changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Kelly McElligott --- *** This bug has been marked as a duplicate of bug 29504 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30449] New: Missing FK constraint on borrower_attribute_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449 Bug ID: 30449 Summary: Missing FK constraint on borrower_attribute_types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Not in kohastructure, but present for a long time already in updatedatabase: $DBversion = "3.07.00.034"; $dbh->do("ALTER TABLE borrower_attribute_types ADD CONSTRAINT category_code_fk FOREIGN KEY (category_code) REFERENCES categories(categorycode)"); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30448] New: CircConfirmItemParts works differently depending on staff permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30448 Bug ID: 30448 Summary: CircConfirmItemParts works differently depending on staff permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a library has turned on the system preference CircConfirmItemParts, the option to confirm the message in the 952$3 is turned on. However, if a staff member doesn't have the permission, Force checkout if a limitation exists, the staff member at checkout will not get the option of checkout or not checkout, they will just see a "continue" option. At check-in, the staff member without the force's permission will see the appropriate options. Test: !. Turn on system preference, circconfirmitemparts 2. Have a staff member without permission, "Force checkout if a limitation exists " check out a book with text in 952$y. 3. Observe staff will only see the yellow box, with the option to continue. 4. Have a staff member with this permission, Force checkout if a limitation exists " check out a book with text in the 952$y, see they get a yellow box with the option to "yes checkout" or "no checkout" We should have this consistent regardless of permission. The confirmcircparts option is important to libraries to identify to their staff that there are steps to be done prior to checkout. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 --- Comment #1 from Nick Clemens --- Created attachment 132935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132935=edit Bug 30447: Check if transfers arrived or cancelled TO test: 1 - Find a bib with a single item 2 - Browse to Circulation->Transfer 3 - Transfer the item to another branch 4 - Check the item in at current branch and cancel the transfer on the dialog 5 - Place a hold on the biblio for a patron at current branch 6 - Browse to Circulation->Holds to pull 7 - Item does not show 8 - Apply patch, restart all 9 - Browse to Circulation->Holds to pull 10 - Item shows -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/