[Koha-bugs] [Bug 25253] Allow to apply modification template when exporting checkouts

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25253

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #2 from Séverine Queune  ---
Quite an old one, rebase is needed :/

$ git bz apply 25253

Bug 25253 Depends on bug 24679 (Failed QA)
Follow? [(y)es, (n)o] y

Bug 24679 - Allow to apply a MARC modification template in export tool

111519 - Bug 24679: Allow to apply a MARC modification template in export tool
111520 - Bug 24679: Return the correct id in AddModificationTemplate
111521 - Bug 24679: Fix exporter tests

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 24679: Allow to apply a MARC modification template in export tool
Using index info to reconstruct a base tree...
M   C4/Record.pm
M   Koha/Exporter/Record.pm
M   koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt
M   t/db_dependent/Exporter/Record.t
M   tools/export.pl
Falling back to patching base and 3-way merge...
Auto-merging tools/export.pl
CONFLICT (content): Merge conflict in tools/export.pl
Auto-merging t/db_dependent/Exporter/Record.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt
Auto-merging Koha/Exporter/Record.pm
Auto-merging C4/Record.pm
CONFLICT (content): Merge conflict in C4/Record.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 24679: Allow to apply a MARC modification template in
export tool
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-24679-Allow-to-apply-a-MARC-modification-templ-6_q4PP.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27783] Introduce background job queues

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   ||,
   ||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30194] Update required JSON::Validator version

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|rel_22_05_candidate |release-notes-needed

--- Comment #97 from Tomás Cohen Arazi  ---
(In reply to Ere Maijala from comment #96)
> I think the relnotes should be expanded a bit since this affects
> backwards-compatibility. At least the fact that the validation is now
> stricter and doesn't allow the invalid refs it used to should be mentioned,
> as these can have a direct effect on REST API plugins.

Indeed. We will need to add technical release notes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30360] Add helper methods to Koha::BackgroundJobs

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30360

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 132953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132953&action=edit
Bug 30360: Make UpdateElasticIndex use the helper methods

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30182] background_jobs.status should be an ENUM

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30182

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30332] SRU does not work via https

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332

--- Comment #4 from Thomas Klausner  ---
(In reply to Marcel de Rooy from comment #3)

> Not sure what your proxy script does. But if you would use nginx as a
> reverse proxy between internet and Koha, I would not consider that an ugly
> solution. The SSL with its certificates etc is handled in the reverse proxy.
> Koha does not have to deal with that anymore. (We run Koha in a container at
> the same time.)

Hm, yes, using an external server as a proxy would also be a good workaround.
But (at least on one installation we manage) we don't have nginx (only Apache,
which can of course also proxy), but the Apache config is managed by the IT
department, which is far, far away and does not care about the library a lot.
So changes there are rather hard to get..

Anyway, I've since improved the code a bit and put it into a plugin:

https://github.com/HKS3/HKS3-SRU-HTTPS-Proxy

This allows the librarians to add/edit/remove new HTTPS SRU Servers without any
action either our or the IT departments part.

But this is still a hack, a proper solution would be to add HTTPS support to
SRU, but I think this is not possible (or only with some work on the underlying
ZOOM C code).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24161] Add ability to track the claim dates of later orders

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #74 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #73)
> I am not sure if the database for this one works correctly. It looks like
> the timestamp was always set to the 'update date' instead of the last known
> claim date as it should have been. :(
> 
> 
> $DBversion = '19.12.00.085';
> if( CheckVersion( $DBversion ) ) {
> unless ( TableExists( 'aqorders_claims' ) ) {
> $dbh->do(q|
> CREATE TABLE aqorders_claims (
> id int(11) AUTO_INCREMENT,
> ordernumber INT(11) NOT NULL,
> claimed_on TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
> PRIMARY KEY (id),
> CONSTRAINT aqorders_claims_ibfk_1 FOREIGN KEY (ordernumber)
> REFERENCES aqorders (ordernumber) ON DELETE CASCADE ON UPDATE CASCADE
> ) ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE =
> utf8mb4_unicode_ci
> |);
> 
> my $orders = $dbh->selectall_arrayref(q|
> SELECT ordernumber, claims_count, claimed_date
> FROM aqorders
> WHERE claims_count > 0
> |, { Slice => {} });
> my $insert_claim_sth = $dbh->prepare(q|
> INSERT INTO aqorders_claims (ordernumber, claimed_on)
> VALUES (?,?)
> |);
> 
> for my $order ( @$orders ) {
> for my $claim (1..$order->{claims_count}) {
> $insert_claim_sth->execute($order->{ordernumber},
> $order->{claimed_on});
> }
> }
> 
> $dbh->do(q|ALTER TABLE aqorders DROP COLUMN claims_count, DROP
> COLUMN claimed_date|);
> }
> 
> NewVersion( $DBversion, 24161, "Add new join table aqorders_claims to
> keep track of claims");
> }

Looks like the following line
22065 $insert_claim_sth->execute($order->{ordernumber},
$order->{claimed_on});
should have used $order->{claimed_on} instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)|22.05.00|
released in||

--- Comment #71 from Jonathan Druart  ---
Thanks to everybody involved in this huge patch series!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #37 from Jonathan Druart  ---
Back to "Resolved fixed"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #132221|0   |1
is obsolete||

--- Comment #2 from Emmi Takkinen  ---
Created attachment 132954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132954&action=edit
Bug 30328: Add ability to generate barcode with branch specific prefix

We should add more flexibility to generating barcodes by letting libraries
define branch specific prefix for their barcodes. This patch adds new option
"premmincr" in systempreference "autoBarcode" and new systempreference
"BarcodePrefix" to define branch specific prefix

Test plan:

1. Apply patch and update database
2. Set syspref "autoBarcode" as
3. Add some values to syspref "Barcodeprefix" e.g.:
Default: DEF
CPL: CPL
FFL: FFL
4. Now change your library to CPL (if needed) and add an item
5. Click barcode input field
   => barcode should be CPL1
6. Add another item and click barcode field
   => barcode should be CPL2
7. Change your library to FFL and add an item
   => barcode should now be FFL1
8. Change your library to e.g. FPL (or another as long as it doesn't have
prefix value
in "Barcodeprefix"), add an item and click barcode field
   => barcode should now be DEF1
9. Try to add multiple items
   => barcodes incremental value should increase in order (no skipping values,
no errors)

Also prove t/db_dependent/Barcodes_ValueBuilder.t and
t/Barcodes_premmincr.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30172] Background jobs failing due to race condition

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172

Owen Leonard  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30172] Background jobs failing due to race condition

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30172] Background jobs failing due to race condition

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30172

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30345] Koha::BackgroundJob->enqueue should set borrowernumber=undef if no userenv

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30345

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30453] Convert offline circulation tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30453] Convert offline circulation tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453

--- Comment #1 from Owen Leonard  ---
Created attachment 132955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132955&action=edit
Bug 30453: Convert offline circulation tabs to Bootstrap

This patch updates the offline circulation page in the staff interface
to use Bootstrap tabs instead of jQueryUI.

To test, apply the patch and make sure the AllowOfflineCirculation
system preference is enabled.

- Go to Circulation -> Built-in offline circulation interface
- Submit a patron barcode in the "Check out" field.
- Under the barcode input field you should see two tabs: Checkouts and
  Fines. Confirm that they look correct and work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24644] Hold not marked filled if item set to positive not for loan value

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24644

Andreas Jonsson  changed:

   What|Removed |Added

 CC||andreas.jons...@kreablo.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30454] Convert holds awaiting pickup tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30454] Convert holds awaiting pickup tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30454

--- Comment #1 from Owen Leonard  ---
Created attachment 132956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132956&action=edit
Bug 30454: Convert holds awaiting pickup tabs to Bootstrap

This patch updates the holds awaiting pickup page to replace jQueryUI
tabs with Bootstrap tabs. A minor JavaScript change is required to work
with the new HTML structure.

To test you should have multiple holds for one library: Some which are
waiting for less than the number of days specified in
ReservesMaxPickUpDelay, some which are waiting longer.

- Apply the patch and go to Circulation -> Holds awaiting pickup.
- You should see two tabs: "Holds waiting" and "Holds waiting over..."
- Confirm that the tabs look correct and work correctly.
- Confirm that the "Cancel selected" buttons work correctly under each
  tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30155

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30155] We shouldn't calculate get_items_that_can_fill when we don't have any holds

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30155

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29087

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30455] New: Incorrect template filter breaks holds

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455

Bug ID: 30455
   Summary: Incorrect template filter breaks holds
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: critical
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 30063

An incorrect filter was added to patron-search.inc:

let defer_loading = [% defer_loading | html ? 1 : 0 %];

Filters don't belong inside conditionals. This makes request.pl break with an
error:

Template process failed: file error - parse error - patron-search.inc line 252:
unexpected token (?)
  [% defer_loading | html ? 1 : 0 %] at /kohadevbox/koha/C4/Templates.pm line
127


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
[Bug 30063] Make the main patron search use the /patrons REST API route
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Owen Leonard  changed:

   What|Removed |Added

 Blocks||30455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455
[Bug 30455] Incorrect template filter breaks holds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30455] Incorrect template filter breaks holds

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455

--- Comment #1 from Owen Leonard  ---
(In reply to Owen Leonard from comment #0)
> This makes request.pl break with an error

...Or any other page which uses patron-search.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30455] Incorrect template filter breaks holds

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30455] Incorrect template filter breaks holds

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455

--- Comment #2 from Owen Leonard  ---
Created attachment 132957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132957&action=edit
Bug 30455: Incorrect template filter breaks holds

This patch removes an incorrect template filter from inside a T:T
conditional. This change should fix a non-functional request.pl and
anywhere else patron-search.inc is used.

The QA failure for a missing filter is a false positive.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

--- Comment #72 from Jonathan Druart  ---
Created attachment 132958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132958&action=edit
Bug 30063: (follow-up) Fix missing TT filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30455] Incorrect template filter breaks holds

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |---
 Status|Needs Signoff   |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Owen Leonard  ---
Will be patched on 30063

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30332] SRU does not work via https

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30332

--- Comment #5 from Marcel de Rooy  ---
(In reply to Thomas Klausner from comment #4)
> Hm, yes, using an external server as a proxy would also be a good
> workaround. But (at least on one installation we manage) we don't have nginx
> (only Apache, which can of course also proxy), but the Apache config is
> managed by the IT department, which is far, far away and does not care about
> the library a lot. So changes there are rather hard to get..

Yes, this sounds awkward.

> But this is still a hack, a proper solution would be to add HTTPS support to
> SRU, but I think this is not possible (or only with some work on the
> underlying ZOOM C code).

I would not recommend doing so. You'd better concentrate on running Koha in a
container and put a (standard) nginx container or so before it as reverse proxy
handling https.
By the way, you should be able to handle the same thing in Apache too without
touching Zoom C code. Catch the https request, proxy it to the local http port
where Zebra listens, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373

--- Comment #11 from Jonathan Druart  ---
Hola Bernardo,

About the test plan of "Bug 30373: Enable translation of UNIMARC frameworks":

3. Create (or update) some language
Ej.
misc/translation/translate create xx-YY

verify new file misc/translation/po/xx-YY-installer-UNIMARC.po

The correct path is misc/translator/po/xx-YY-installer-UNIMARC.po

Yes it got created!

But:

4. Install new language
misc/translation/translate install xx-YY

verify new dirs:
installer/data/mysql/xx-YY/marcflavour/unimarc/{mandatory,optional}

The 'unimarc' directory is not created. Tried with "fr-FR" and "es-ES".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373

--- Comment #12 from Jonathan Druart  ---
kohadev-koha@kohadevbox:/kohadevbox/koha/misc/translator$ perl translate create
es-ES
kohadev-koha@kohadevbox:/kohadevbox/koha/misc/translator$ perl translate
install es-ES

kohadev-koha@kohadevbox:/kohadevbox/koha/misc/translator$ ls
/kohadevbox/koha/installer/data/mysql/es-ES/marcflavour/
marc21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #132921|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  ---
Created attachment 132959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132959&action=edit
Bug 30406: Add column filters before hiding columns

The code that adds column filters works only on visible columns, so we
should hide columns after filters are created

Test plan:
1. Apply patch
2. Go to Tables settings. Hide city_state for the cities table.
3. Create some cities and go to the cities page
4. Verify that filtering works as expected.
5. Make the city_state column appear. Verify that filtering on this
   column works too

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406

--- Comment #6 from Jonathan Druart  ---
Ha! Good workaround, thanks Julian!

We could apply the same fix to includes/columns_settings.inc but I didn't
manage to recreate the problem on catalogue/detail.pl (I think it's the only
place where column filters are used with KohaTable).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30063

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30406

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525

pierre.ge...@biblibre.com changed:

   What|Removed |Added

 CC||pierre.ge...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #132929|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  ---
Created attachment 132960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132960&action=edit
Bug 30426: Add missing C4::Auth and C4::Output imports

This patch adds missing function imports for C4::Auth and C4::Output
in the opac/svc/suggestion script.

Test plan:

1. Go to http://localhost:8081/cgi-bin/koha/admin/didyoumean.pl
2. Turn on some plugins
3. Go to
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
4. Note in your browser's Network tab that the call to
   http://localhost:8080/cgi-bin/koha/svc/suggestion?render=stub&q=test
   generates a 200 response instead of a 500 error

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29897] Display author identifiers for researchers

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #129816|0   |1
is obsolete||
 Attachment #129817|0   |1
is obsolete||
 Attachment #129818|0   |1
is obsolete||
 Attachment #129819|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  ---
Created attachment 132961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132961&action=edit
Bug 29897: Rename get_marc_authors with get_marc_contributors

get_marc_authors actually return authors from 700..712, not the first
author from 200

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29897] Display author identifiers for researchers

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #11 from Jonathan Druart  ---
Created attachment 132962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132962&action=edit
Bug 29897: Move code to private method for reusability

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29897] Display author identifiers for researchers

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #12 from Jonathan Druart  ---
Created attachment 132963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132963&action=edit
Bug 29897: Add new pref OPACAuthorIdentifiers

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29897] Display author identifiers for researchers

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #13 from Jonathan Druart  ---
Created attachment 132964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132964&action=edit
Bug 29897: Display author's identifiers

This new enhancement add the capability to list the different
identifiers of authors. It is helpful for research publications for
instance.

This patch will add a new "Author identifiers" tab on the detail page
(OPAC) of a bibliographic record, with the list of the authors and their
identifiers.
On the detail page of the authority record, the same identifier list
will be displayed.

Test plan:
Create some authority with
024
  $a source
  $2 number
  $6 link to the source
With the pref turned ON you will be able to see the new information.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30456] New: Convert checkout history tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456

Bug ID: 30456
   Summary: Convert checkout history tabs to Bootstrap
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 29226

Continuing the process of phasing out jQueryUI, this patch will replace
jQueryUI tabs in the checkout history template with Bootstrap.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

   What|Removed |Added

 Depends on||30456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456
[Bug 30456] Convert checkout history tabs to Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30449] Missing FK constraint on borrower_attribute_types

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30449] Missing FK constraint on borrower_attribute_types

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

--- Comment #1 from Marcel de Rooy  ---
Created attachment 132965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132965&action=edit
Bug 30449: Add missing FK constraint on borrower_attribute_types

Old Koha databases probably have it, newer ones might not.
See also BZ description.

Test plan:
[1} Check SHOW CREATE TABLE borrower_attribute_types to see if you
have any index and FK constraint on category_code.
[2] Run updatedatabase.
[3] If you had category_code_fk, it should be replaced.
[4] Remove index and constraint again using things like:
alter table borrower_attribute_types drop constraint
`borrower_attribute_types_ibfk_1`;
alter table borrower_attribute_types drop index category_code;
[5] Run updatedatabase.
[6] You should have KEY category_code and FK borrower_attribute_types_ibfk_1.
[7] Run updatedatabase. Idempotent, no changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30449] Missing FK constraint on borrower_attribute_types

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30449] Missing FK constraint on borrower_attribute_types

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

Marcel de Rooy  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30449] Missing FK constraint on borrower_attribute_types

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #132965|0   |1
is obsolete||

--- Comment #2 from Marcel de Rooy  ---
Created attachment 132966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132966&action=edit
Bug 30449: Add missing FK constraint on borrower_attribute_types

Old Koha databases probably have it, newer ones might not.
See also BZ description.

Test plan:
[1} Check SHOW CREATE TABLE borrower_attribute_types to see if you
have any index and FK constraint on category_code.
[2] Run updatedatabase.
[3] If you had category_code_fk, it should be replaced.
[4] Remove index and constraint again using things like:
alter table borrower_attribute_types drop constraint
`borrower_attribute_types_ibfk_1`;
alter table borrower_attribute_types drop index category_code;
[5] Run updatedatabase.
[6] You should have KEY category_code and FK borrower_attribute_types_ibfk_1.
[7] Run updatedatabase. Idempotent, no changes.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456

--- Comment #1 from Owen Leonard  ---
Created attachment 132967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132967&action=edit
Bug 30456: Convert checkout history tabs to Bootstrap

This patch updates the circulation history page to replace jQueryUI tabs
with Bootstrap tabs. A minor JavaScript change is required to work
with the new HTML structure.

To test you'll view the staff interface circulation history page with
the OnSiteCheckouts system preference on and off.

- With OnSiteCheckouts off, locate a patron who has current and/or
  past checkouts.
- View the "Circulation history" page for that patron.
- The table of checkouts should display with no tabbed interface.

- With OnSiteCheckouts on, the page should show three tabs: All,
  Checkouts, and On-site checkouts.
- Confirm that clicking on each tab correctly filters the table, e.g.
  the On-site checkouts tab should show only on-site checkouts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #46 from Jonathan Druart  ---
This got broken at some point

data: {"messages":[{"code":"index_error","type":"error","error":"Can't locate
object method \"new\" via package \"Koha::SearchEngine::Indexer\" (perhaps you
forgot to load \"Koha::SearchEngine::Indexer\"?) at
/kohadevbox/koha/Koha/BackgroundJob/UpdateElasticIndex.pm line
78.\n"}],"record_ids":["14"],"report":{"total_records":1,"total_success":0},"record_server":"biblioserver"}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456

Owen Leonard  changed:

   What|Removed |Added

 Attachment #132967|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 132968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132968&action=edit
Bug 30456: Convert checkout history tabs to Bootstrap

This patch updates the circulation history page to replace jQueryUI tabs
with Bootstrap tabs. A minor JavaScript change is required to work
with the new HTML structure.

To test you'll view the staff interface circulation history page with
the OnSiteCheckouts system preference on and off.

- With OnSiteCheckouts off, locate a patron who has current and/or
  past checkouts.
- View the "Circulation history" page for that patron.
- The table of checkouts should display with no tabbed interface.

- With OnSiteCheckouts on, the page should show three tabs: All,
  Checkouts, and On-site checkouts.
- Confirm that clicking on each tab correctly filters the table, e.g.
  the On-site checkouts tab should show only on-site checkouts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #47 from Jonathan Druart  ---
Created attachment 132969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132969&action=edit
Bug 27344: Add missing imports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #48 from Jonathan Druart  ---
Created attachment 132970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132970&action=edit
Bug 27344: Warn the error in the log

Otherwise info about the failure is hidden in DB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27783] Introduce background job queues

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #30 from Jonathan Druart  ---
1. Shouldn't we force the job to define its queue? Otherwise I have the feeling
that we will end up with "default" everywhere.
2. What could be other queues?
3. Is BatchCancelHold really a long task? How do you define a short/long task
then?
4. Do we really want long/short task distinction? If you index 1000 records
(using batch update), it will be considered as "default" (/not long task), but
it will take a while.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #49 from Jonathan Druart  ---
Minor: Progress is 0/1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344

--- Comment #50 from Jonathan Druart  ---
Batch item modification (for instance) will run in background, but will also
run a new task for the indexation.
I don't think we should run another task for the indexation in case of batch
operations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17506] Offline circ needs to be logged

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17506] Offline circ needs to be logged

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506

--- Comment #3 from Kyle M Hall  ---
Created attachment 132971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132971&action=edit
Bug 17506: Offline circ needs to be logged

Returns via offline circ are not logged.

Test Plan:
1) Via offline circ
   * Return some items checked out to patrons
   * Check out some items that are currently checked out to other
 patrons
2) Apply the offline circs to Koha
3) Note the checkouts are logged, but not the returns
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the checkins are now logged both for returns and for checkouts
   where the item was checked out to a different patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #124174|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #12 from Andrew Isherwood  ---
Hi Katrin

It looks like one of the patches got obsoleted at some point, no idea how that
happened! Anyway, it should apply now. I'm just working on a development that
depends on this bug, and it applied cleanly, so hopefully you won't have any
problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29859] Favor iterators over as_list

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859

--- Comment #13 from Jonathan Druart  ---
Created attachment 132972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132972&action=edit
Bug 29859: Fix club/enroll

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29859] Favor iterators over as_list

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312

Séverine Queune  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312

--- Comment #1 from Séverine Queune  ---
Created attachment 132973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132973&action=edit
Bug 29312: Remove unnecessary point

This patch removes an extra point after the number of shown results.

Test plan :
 - don't apply patch
 - run a report that brings you more than 20 results, e.g. SELECT * FROM biblio
LIMIT 50
 - see extra ' .' after the number of shown results
 - apply patch
 - run the report again and see the point isn't displayed anymore
 - check the behaviour is still correct when you change the number of rows
displayed
 - sign off !

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
   Assignee|koha-b...@lists.koha-commun |severine.que...@bulac.fr
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27783] Introduce background job queues

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #31 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #30)
> 1. Shouldn't we force the job to define its queue? Otherwise I have the
> feeling that we will end up with "default" everywhere.

I think this can be caught at QA time. See 4.

> 2. What could be other queues?

Chatter on this and bug 27344 pointed to devs wantings some flexibility to run
their own queues. That's why I reorganized things, keeping that in mind. Maybe
later someone adds a configuration page/file to point specific tasks to
specific queues, in order to offload some tasks to a separate physical server.

> 3. Is BatchCancelHold really a long task? How do you define a short/long
> task then?

I think that was a mistake I made. i.e. cancelling holds shouldn't wait for a
long running batch import to finish.

> 4. Do we really want long/short task distinction? If you index 1000 records
> (using batch update), it will be considered as "default" (/not long task),
> but it will take a while.

We do want that. And maybe in the future we can add more queues... and
priorities.
I think a follow-up is needed in bug 27344 to make it resort to long_tasks if
the record count is high (for example, because of a batch operation) and be
real-time if we are just updating an item index because it's been checked-in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30457] New: Convert holds page tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457

Bug ID: 30457
   Summary: Convert holds page tabs to Bootstrap
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 29226

Continuing the process of phasing out jQueryUI, this patch will replace
jQueryUI tabs in the holds template with Bootstrap.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226
[Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226

Owen Leonard  changed:

   What|Removed |Added

 Depends on||30457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457
[Bug 30457] Convert holds page tabs to Bootstrap
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #128204|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  ---
Created attachment 132974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132974&action=edit
Bug 29420: HTTP status code incorrect when calling error pages directly under
Plack/PSGI

The error pages wrote a HTTP status code of 200 for all PSGI requests, even
though it should have only done it for PSGI requests from the ErrorDocument
middleware. This patch fixes that.

0) Do not apply patch
1) Open F12 dev tools and go to Network tab
2) Go to http://localhost:8081/files/blah
3) Note that the webpage is a 404 error but HTTP status code is 200
4) Go to http://localhost:8081/cgi-bin/koha/circ/blah
5) Note that the webpage is a 404 error and HTTP status code is 404

6) Apply patch
7) Go to http://localhost:8081/files/blah
8) Note that the webpage is a 404 error and HTTP status code is 404
9) Go to http://localhost:8081/cgi-bin/koha/circ/blah
10) Note that the webpage is a 404 error and HTTP status code is 404

Signed-off-by: Martin Renvoize 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

--- Comment #3 from Jonathan Druart  ---
Bug 27555 comment 3

"""
I don't understand why psgi_env and safe_exit were in the BEGIN block.
Should we expect a regression from CAS or Shib auth here?
"""

Will see once it's pushed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #132299|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  ---
Created attachment 132975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132975&action=edit
Bug 29744: Harmonize psgi/plack detection methods

This patch updates and moves the existing psgi_env method out of Auth
and into Context and then replaces any manual references of the same
code to use the new method.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] New: Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Bug ID: 30458
   Summary: Librarian ( manager_id ) not included in accountline
when using "Payout amount" button
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

--- Comment #1 from Kyle M Hall  ---
Created attachment 132976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132976&action=edit
Bug 30458:- Librarian ( manager_id ) not included in accountline when using
"Payout amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27783] Introduce background job queues

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #32 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #31)
> (In reply to Jonathan Druart from comment #30)
> > 1. Shouldn't we force the job to define its queue? Otherwise I have the
> > feeling that we will end up with "default" everywhere.
> 
> I think this can be caught at QA time. See 4.

We have job_type that is doing that already.
Why asking a human to catch something that can be caught by a machine? :)

170 sub job_type { croak "This method must be subclassed" }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27783] Introduce background job queues

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

--- Comment #33 from Jonathan Druart  ---
I am not sure I am understanding what bring 'queue' that cannot be done with
the job_type.

We could have --job-type and a negation for this option.

perl background_jobs_worker.pl --job-type update_elastic_index
=> Run only indexation tasks

perl background_jobs_worker.pl --not-job-type update_elastic_index
=> Run all but indexation tasks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30456] Convert checkout history tabs to Bootstrap

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30456

Séverine Queune  changed:

   What|Removed |Added

 Attachment #132968|0   |1
is obsolete||

--- Comment #3 from Séverine Queune  ---
Created attachment 132977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132977&action=edit
Bug 30456: Convert checkout history tabs to Bootstrap

This patch updates the circulation history page to replace jQueryUI tabs
with Bootstrap tabs. A minor JavaScript change is required to work
with the new HTML structure.

To test you'll view the staff interface circulation history page with
the OnSiteCheckouts system preference on and off.

- With OnSiteCheckouts off, locate a patron who has current and/or
  past checkouts.
- View the "Circulation history" page for that patron.
- The table of checkouts should display with no tabbed interface.

- With OnSiteCheckouts on, the page should show three tabs: All,
  Checkouts, and On-site checkouts.
- Confirm that clicking on each tab correctly filters the table, e.g.
  the On-site checkouts tab should show only on-site checkouts.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

--- Comment #25 from Fridolin Somers  ---
Created attachment 132978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132978&action=edit
Bug 30063: Fix missing TT filters

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Fridolin Somers  changed:

   What|Removed |Added

 Attachment #132978|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373

--- Comment #13 from Bernardo Gonzalez Kriegel  ---
> 
> The correct path is misc/translator/po/xx-YY-installer-UNIMARC.po
You're right, sorry

> But:
> 
> 4. Install new language
> misc/translation/translate install xx-YY
> 
> verify new dirs:
>
> installer/data/mysql/xx-YY/marcflavour/unimarc/{mandatory,optional}
> 
> The 'unimarc' directory is not created. Tried with "fr-FR" and "es-ES".

My tests using biblibre branch:

$ git status
En la rama bz30373
Tu rama está actualizada con 'biblibre/bz30373'.

$ misc/translator/translate create xx-YY

$ ls -l misc/translator/po/xx-YY-installer*
-rw-rw-r-- 1 bgkriegel bgkriegel 288499 abr  5 07:10
misc/translator/po/xx-YY-installer-MARC21.po
-rw-rw-r-- 1 bgkriegel bgkriegel 107615 abr  5 07:10
misc/translator/po/xx-YY-installer.po
-rw-rw-r-- 1 bgkriegel bgkriegel 201055 abr  5 07:10
misc/translator/po/xx-YY-installer-UNIMARC.po

$ misc/translator/translate install xx-YY
ERROR parsing plural forms header [nplurals=INTEGER; plural=EXPRESSION;]

$ ls -l installer/data/mysql/xx-YY/marcflavour/
total 8
drwxrwxr-x 4 bgkriegel bgkriegel 4096 abr  5 11:37 marc21
drwxrwxr-x 4 bgkriegel bgkriegel 4096 abr  5 11:37 unimarc


NOTE: check that installer/data/mysql/xx-YY (or es-ES) does *not* exists before
doing the install phase. By design that dir is not overwritten or updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13952] Import and export of authority types

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #173 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Fridolin Somers  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #73 from Fridolin Somers  ---
> Bug 30063: (follow-up) Fix missing TT filters
Was also missing :
  $("#[% sticky_header | html %]").show();
I've added my commit :
c636b39a89 Bug 30063: Fix missing TT filters
Then yours :
5fdfed1ee5 Bug 30063: (follow-up) Fix missing TT filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29859] Favor iterators over as_list

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859

Fridolin Somers  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

--- Comment #14 from Fridolin Somers  ---
> Bug 29859: Fix club/enroll
Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29915] Anonymous session generates 1 new session ID per hit

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915

--- Comment #127 from Fridolin Somers  ---
(In reply to Fridolin Somers from comment #126)
> > Bug 29915: Prevent bad cookie from corrupted session
> Pushed to master

@Kyle : backport this in 21.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Fridolin Somers  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Passed QA   |Pushed to master

--- Comment #15 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26669] Last Run column not updated when report is run publicly (via CoverFlow or elsewhere)

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26669

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

--- Comment #18 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 Status|Passed QA   |Pushed to master

--- Comment #23 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29501] gather_print_notices.pl does not use SMTP servers

2022-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29501

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)||22.05.00
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Passed QA   |Pushed to master

--- Comment #25 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 🦄

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >