[Koha-bugs] [Bug 28998] Encrypt borrowers.secret
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |BLOCKED --- Comment #9 from Marcel de Rooy --- Looking here. Might propose some changes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #22 from Marcel de Rooy --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Attachment #129692|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 133289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133289&action=edit Bug 29894: Send a confirmation notice When registering or deregistering, send a confirmation. Test plan: Register or deregister with patron having email address. Verify that you got a confirmation mail. Run t/db_dependent/Koha/Auth/TwoFactorAuth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Attachment #129691|0 |1 is obsolete|| --- Comment #20 from Marcel de Rooy --- Created attachment 133288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133288&action=edit Bug 29894: Db rev for adding notices This dbrev adds two notices: 2FA_REGISTER and 2FA_DEREGISTER Test plan: Run the dbrev. Check if you see them on Tools/Notices. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Attachment #129690|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 133287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133287&action=edit Bug 29894: Clear secret when disabling 2FA Test plan: Deregister 2FA for patron. Check if secret is empty in borrowers.secret. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Attachment #129689|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 133286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133286&action=edit Bug 29894: Add some exceptions to TwoFactorAuth module Test updated accordingly. Adding utf8 flag to CGI in staff script. Test plan: Run t/db_dependent/Koha/Auth/TwoFactorAuth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 Marcel de Rooy changed: What|Removed |Added Depends on||29894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 [Bug 29894] 2FA: Add few validations, clear secret, send register notice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29894] 2FA: Add few validations, clear secret, send register notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Blocks||20476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 [Bug 20476] Two factor authentication for the staff client - omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29155] Upgrade jquery version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- Applies without issue on master (412d4f4864) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30538] New: Regression: rotating collections does not update status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30538 Bug ID: 30538 Summary: Regression: rotating collections does not update status Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org In 20.05, when a rotating collection is transferred, the status of the items update to indicate the item is In Transit to the library the collection is being sent to. In 21.05. the status is no longer updating. If an item is checked in, the correct message shows to transfer the item to the appropriate location, and updates when checked in at the correct location. However the functionality of having the status update when the collection is transferred is a key part of the process and needs to be restored. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30537] New: Patron searches are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30537 Bug ID: 30537 Summary: Patron searches are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P1 - high Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: -Go to "cgi-bin/koha/members/members-home.pl". -Try and do any patron search -You won't see any results -Open your console and notice the "400 Bad request" error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 [Bug 30536] Embeds should be defined in a single place -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29810 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 [Bug 29810] Add embed options documentation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30536] New: Embeds should be defined in a single place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30536 Bug ID: 30536 Summary: Embeds should be defined in a single place Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com CC: tomasco...@gmail.com Right now, our specs need two places: (1) path top level x-koha-embed entry (2) path header parameters definition for x-koha-embed as an enum The first one was the right one in the first place, but JSON::Validator didn't manage that correctly (reliably I'd say). So we used it as in (1). Bug 29810 added (2), which is great and correct, but our 'stash_embed' helper [1] called from Koha/REST/V1/Auth.pm is relying on (1) to build the allow-list for embeds. So we need to have both, and we should fix it. [1] Koha/REST/Plugin/Query.pm:237 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Tomás Cohen Arazi changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29810] Add embed options documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #66 from Tomás Cohen Arazi --- Created attachment 133285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133285&action=edit Bug 29810: Fix patron embed definitions Due to a race and a bad rebase, the patrons embeds added on bug 30063 didn't get copied to the parameters secition, thus breaking embedding. To test: 1. In master, open the patron search page and the inspector 2. Perform a search => FAIL: No results => FAIL: There's an error 500 in the API response, mentioning embedding is not allowed 3. Apply this patch 4. Restart all 6. Repeat 2 => SUCCESS: Results are back! => SUCCESS: No more API errors 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Lucas Gass changed: What|Removed |Added Attachment #133281|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 133284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133284&action=edit Bug 18392: Add noExport of rows and don't export 'edit' row Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Lucas Gass changed: What|Removed |Added Attachment #133280|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 133283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133283&action=edit Bug 18392: use KohaTable for circ rules to allow export of matrix To test: 1 - Define some circ rules 2 - View them, note the appearance 3 - Apply patch 4 - Reload and note change of header 5 - Use the new button to export, try various formats 6 - Test the filter and export Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30534] borrowers.guarantorid not present on database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30534] borrowers.guarantorid not present on database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 133282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133282&action=edit Bug 30534: Remove guarantor_id attribute from the patron object This patch removes an attribute that was actually removed 3 years ago and causes an exception when trying to search for it. The API responses don't include it anyways. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30535] New: Add "Tool plugins" to the main tools screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30535 Bug ID: 30535 Summary: Add "Tool plugins" to the main tools screen Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: fred.k...@medstar.net QA Contact: testo...@bugs.koha-community.org On the main Tools page in 21.05, "Tool plugins" is missing from "Additional tools." If you select any one of the tools, it appears in the column of tools on the left side of the screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||n...@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 --- Comment #4 from Nick Clemens --- Created attachment 133281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133281&action=edit Bug 18392: Add noExport of rows and don't export 'edit' row -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 --- Comment #3 from Nick Clemens --- Created attachment 133280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133280&action=edit Bug 18392: use KohaTable for circ rules to allow export of matrix To test: 1 - Define some circ rules 2 - View them, note the appearance 3 - Apply patch 4 - Reload and note change of header 5 - Use the new button to export, try various formats 6 - Test the filter and export -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18392] Allow importing/exporting circulation conditions as CSV or spreadsheet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534 [Bug 30534] borrowers.guarantorid not present on database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30534] borrowers.guarantorid not present on database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534 Tomás Cohen Arazi changed: What|Removed |Added CC||lu...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |ASSIGNED Depends on||14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30534] New: borrowers.guarantorid not present on database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534
Bug ID: 30534
Summary: borrowers.guarantorid not present on database
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
CC: tomasco...@gmail.com
The column was removed on bug 14570 (19.11) but the API mapping was
inadvertedly kept.
We should remove it.
To test:
- Try to filter a request by that attribute:
http://kohadev-intra.myDNSname.org:8081/api/v1/patrons?guarantor_id=1
http://kohadev-intra.myDNSname.org:8081/api/v1/patrons?q={"guarantor_id"=1}
=> FAIL: You get a 500
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17500] Use Elasticsearch to search for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30533 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30533] New: Add exact search option for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30533 Bug ID: 30533 Summary: Add exact search option for patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com A patron search for names like "JOHN JOHNSON" ends up getting parsed something like "WHERE surname like "%JOHN%" OR firstname like "%JOHN%" OR surname like "%JOHNSON%" OR firstname like "%JOHNSON%"" and finds a really unhelpfully large pile of patrons. Bug 17500 suggests implementing Elastic for patron searching, which would be great. In the meantime, we could give a little help for searches like this by giving an exact search option -- so the query would parse more or less the same but without the wildcards. That's also a problematic search for many situations, but would work better here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30532] guided_reports.pl has a problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532 --- Comment #1 from Owen Leonard --- This is basically the same issue as Bug 30525, though the problematic code is different than what I'd searched for to fix that bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30194] Update required JSON::Validator version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #103 from Michael Hafen --- Yep, that fixed it. Thanks. (In reply to Mason James from comment #102) > (In reply to Michael Hafen from comment #100) > > Please keep the exp repo until the dev repo has the newer packages for all > > the affected libraries. > > Also, shouldn't the required module versions be updated on the About Koha > > page? > > Also, I seem to have the wrong version of Mojolicious::Plugin::OpenAPI in my > > dev install. It's complaining about JSON::Validator::Ref being missing. I > > have 2.16 from the dev repo. > > hi Michael, if you use the 'koha-staging' repo, your problems should be > resolved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28634] ILL partner request notices are attached to the request creator rather than the partner recipient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28634 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30532] New: guided_reports.pl has a problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30532 Bug ID: 30532 Summary: guided_reports.pl has a problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P1 - high Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: Go to: Home > Reports > Create from SQL Can't call method "value" on unblessed reference at /kohadevbox/koha/reports/guided_reports.pl line 80 Maybe caused by Bug 26019? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30453] Convert offline circulation tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 Owen Leonard changed: What|Removed |Added Attachment #132955|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 133279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133279&action=edit Bug 30453: Convert offline circulation tabs to Bootstrap This patch updates the offline circulation page in the staff interface to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and make sure the AllowOfflineCirculation system preference is enabled. - Go to Circulation -> Built-in offline circulation interface - Submit a patron barcode in the "Check out" field. - Under the barcode input field you should see two tabs: Checkouts and Fines. Confirm that they look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Owen Leonard changed: What|Removed |Added Attachment #132868|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 133278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133278&action=edit Bug 30434: Convert catalog merge page tabs to Bootstrap This patch updates the catalog merge template so that it uses Bootstrap tabs instead of jQueryUI. Some JavaScript is modified to accommodate the new DOM structure. The patch also makes a minor HTML correction, adding a missing "". To test, apply the patch and search the catalog in the staff client. - In the search results, check the checkbox for two records. - Choose Edit -> Merge records. - Click next to accept the merge reference selection. - On the next page you should see two tabs under "Source records." Confirm that they work correctly. - All checkboxes in the first tab should be checked by default. - Confirm that tag and subfield selection still works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27750] Remove jquery.cookie.js plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 Owen Leonard changed: What|Removed |Added Attachment #131118|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 133277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133277&action=edit Bug 27750: Remove jquery.cookie.js plugin This patch removes references to the jquery.cookie.js plugin which is now unused, replaced by js-cookie. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #20 from Owen Leonard --- Created attachment 133276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133276&action=edit Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled This patch adds the new OPACBakerTaylorEnabled preferences to OPAC templates and scripts which were missed in the first patch. The patch also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql. Check these pages in the OPAC: - Catalog -> Search results - And search results -> RSS - Catalog -> Bibliographic details page -> Shelf browser - Catalog -> Lists -> List contents - Catalog -> Recent comments - And recent comments -> RSS - Your summary -> Checkouts and Overdues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 --- Comment #19 from Owen Leonard --- Created attachment 133275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133275&action=edit Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled This patch adds a missing check for the BakerTaylorEnabled system preference in staff interface search results. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the staff interface with separate system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307 Owen Leonard changed: What|Removed |Added Attachment #131784|0 |1 is obsolete|| Attachment #131785|0 |1 is obsolete|| Attachment #131786|0 |1 is obsolete|| --- Comment #18 from Owen Leonard --- Created attachment 133274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133274&action=edit Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC This patch updates the system preferences controlling Baker & Taylor content so that there are separate preferences for the OPAC and the staff interface. The patch also adds Baker & Taylor cover images to the staff client. To test, apply the patch and run the database update. - Go to Admnistration -> System preferences -> Enhanced content - You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled preference. The OPACBakerTaylorEnabled should have the same setting you previously had for BakerTaylorEnabled. The BakerTaylorEnabled preference should be turned off. - Note that the description of the preferences have been updated to include links to the Baker & Taylor username and password preferences. - Enable both and make sure you have a valid Baker & Taylor username and password entered. - Perform a search in both the OPAC and staff interface. A Baker & Taylor cover image should appear on the bibliographic detail page in the OPAC, and on the search results and bibliographic detail page in the staff interface. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30248] Multiple Select elements randomly have small width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30248 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Owen Leonard changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30525] Items batch modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525 --- Comment #2 from Owen Leonard --- Created attachment 133273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133273&action=edit Bug 30525: Items batch modification broken This patch modifies instances in the code which try to get cookies using: my %cookies = parse CGI::Cookie($cookie); In some cases the relevant lines can be removed because they are unused. In others it can be replaced with: my %cookies = CGI::Cookie->fetch(); To test, apply the patch and restart_all. Test the following pages to confirm they load without errors: - Circulation -> Offline circulation file upload - Circulation -> Offline circulation -> Add to queue - Tools -> Batch item modification - Tools -> Stage MARC for import - Tools -> Staged MARC management - Tools -> Batch patron modification - Tools -> Upload local cover image -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30525] Items batch modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30531] New: Search.t needs update for Recalls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30531 Bug ID: 30531 Summary: Search.t needs update for Recalls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The tests complain: The syspref UseRecalls was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 158. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass changed: What|Removed |Added Attachment #133237|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 133272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133272&action=edit Bug 30474: (follow-up) Tie editor initialization to tab activation The way Bootstrap tabs manipulate the DOM, CodeMirror has problems initializing correctly, I think because of redraws and CodeMirror's attemps to position things absolutely. The solution seems to be to wait until after a Bootstrap tab has activated before initializing the CodeMirror instance. This patch implements that, along with a check to prevent double-initializing the same textarea. I've also made a similar change to the way TinyMCE is initialized, which I hope will help with the issue of the editor not always loading correctly. To test, apply the patch and go to Tools -> HTML customizations. - Test creation and editing of HTML customization entries using both the default editor and the text editor (Edit -> Edit with text editor). - Verify that the editor (CodeMirror or TinyMCE) loads correctly and looks correct, both upon page load and upon switching tabs between "Default" and other language tabs - Verify that your edits are saved correctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass changed: What|Removed |Added Attachment #133236|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 133271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133271&action=edit Bug 30474: Convert tools pages tabs to Bootstrap (part 1) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> HTML customizations. - Click "New entry." - On the entry form you should see two tabs, "Default" and "English (en)" - The tabs should look correct and work correctly. Go to Tools -> Batch record deletion. - Test the three tabs: "Upload a file", "Select a list of records", and "Enter a list of record numbers." Go to Tools -> Batch record modification. - Test the same three tabs on this page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30530] The translation updates for 21.11.03 contains the updates made for bug 29525, which has not been backported to 21.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30530 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Andreas, we have fixed this on Pootle on bug 30307. It should be fixed for the latest release 21.11.04. *** This bug has been marked as a duplicate of bug 30307 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30307] 21.11 files contain strings from master (Recalls)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30307 Katrin Fischer changed: What|Removed |Added CC||andreas.jons...@kreablo.se --- Comment #3 from Katrin Fischer --- *** Bug 30530 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30530] New: The translation updates for 21.11.03 contains the updates made for bug 29525, which has not been backported to 21.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30530 Bug ID: 30530 Summary: The translation updates for 21.11.03 contains the updates made for bug 29525, which has not been backported to 21.11 Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jons...@kreablo.se QA Contact: testo...@bugs.koha-community.org The translation updates for 21.11.03 (commit 4cd5997464d8c39c4ca79d1b4437a4e4d260) contains the updates made for bug 29525 which cause some on the messages on the privacy page to remain untranslated. In particular, these messages are affected: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130256&action=diff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #8 from Nick Clemens --- Created attachment 133270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133270&action=edit Bug 17170: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #7 from Nick Clemens --- Created attachment 133269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133269&action=edit Bug 17170: Add admin page for filters and ability to edit/save existing filters This patchset adds a new ability to save searches on the staff client, and display them in the results page on staff or opac as a new filter. New filters can be added from the resuilts page after a search, and there is an admin page for updating deleting and renaming filters There is a new permission to control management of these filters New filters can be added that are not displayed along with facets, this allows for building custom links using these filters to keep URLs shorter Due to bug 30528 testing in ES is recommended To test: 1 - Apply patches and update database and restart all 2 - Enable new system preference 'SavedSearchFilters' 3 - As superlibrarian perform a search in staff client, something broad like 'a' 4 - Note new 'Save search as filter' link on results page 5 - Click it, save search as new filter, check 'Staff client' visibility 6 - Perform another search 7 - Note the filter now appears above facets 8 - Click to it filter results 9 - Note results are limited by the new filter, and it is checked in the facets 10 - Confirm click the [x] removes the filter 11 - Go to administration->search filters 12 - Confirm the filter appears 13 - Edit and mark as OPAC visible 14 - Test OPAC to ensure it shows and can be applied/removed 15 - Copy URL with filter applied 16 - In adminsitration mark filter as not visible on staff or opac 17 - Confirm link above still works 18 - Create a new staff with catalogue and search filters permission 19 - Ensure they can access/save filters 20 - Remove filter permission and ensure they cannot 21 - Disable system preference 22 - Confirm links to search filters page are removed from admin home and admin sidebar 23 - Confirm filters do not appear on results and cannot be created 24 - Enable pref 25 - Create a filter 26 - From search filters page, click 'Edit search' 27 - Confirm you are taken to advanced search page letting you know which filter you are editing 28 - Confirm you can change searhc options and save 29 - Confirm you can perform the search from this page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #6 from Nick Clemens --- Created attachment 133268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133268&action=edit Bug 17170: Handle search filters in query builders This patch updates the query building code to expand filters when searching and pass them back as part of the cgi and descriptive search strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #5 from Nick Clemens --- Created attachment 133267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133267&action=edit Bug 17170: Add search filters to staff and opac interfaces This patch displays the filters on the results pages with the facets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #4 from Nick Clemens --- Created attachment 133266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133266&action=edit Bug 17170: Add API route for SearchFilters This adds the API routes and tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #3 from Nick Clemens --- Created attachment 133265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133265&action=edit Bug 17170: Update schema for boolean -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #2 from Nick Clemens --- Created attachment 133264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133264&action=edit Bug 17170: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 --- Comment #1 from Nick Clemens --- Created attachment 133263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133263&action=edit Bug 17170: DB Updates This patch adds the new table, permission, and a syspref to enable the feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30526] The pagination in the REST API does not work if $c->objects->search is called multiple times.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Andreas Jonsson from comment #2) > Test plan: > > * Make sure you have at least 3 libraries that may be pickup locations. > * Activate the system preference AllowHoldPolicyOverride > * Change the system preference RESTdefaultPageSize to 1 > * Go to a record and make a place a hold. > * In the Holds view for the record, verify that all libraries appear in the > pickup library drop down menu on the hold. Hi, nice catch and really happy to see your patch. I suggest you take a look at this files: - t/Koha/REST/Plugin/Pagination.t - t/db_dependent/api/v1/pagination.t in those files, you should add regression tests at different levels. In case you need it, ping me on IRC (tcohen) or just drop an email to koha-devel. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24334] Barcode should be included in Marcitemfieldstoorder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24334 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30529 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30529] New: Allow all item fields to be set in MARCItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30529 Bug ID: 30529 Summary: Allow all item fields to be set in MARCItemFieldsToOrder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The MARCItemFieldsToOrder syspref allows values for a set list of item/order fields to be sent in MARC file used in acquisitions. We should broaden that out to include any item field to support a broader array of workflows. Bug 24334 already suggested adding barcode, but I see no reason not to take that idea further. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5274] CCL prefixes break search limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5274 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30528 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30528 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30528] Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17170, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=5274 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30528] New: Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528 Bug ID: 30528 Summary: Limits are not correctly parsed when query contains CCL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com This was made more apparent by bug 17170 - when a special limit that needs parsing is passed along witha query containing CCL indexes then the limits are not parsed (with exception of 'available' which is handled) This is due to a clause the prevents the normal parsing in C4::Search::buildQuery To test: 1 - Perform advanced search in staff client 2 - Select 'More options' 3 - In first box with keyword as index type 'ti:a' 4 - Enter a year into Limits 5 - Search 6 - You see only 'ti:a' in description, and search fails with bug 17170 1 - Save a search filter visible in staff client 2 - Perform a search like 'ti:a' 3 - Attempt to filter using custom filter 4 - In plack intranet error log: [2022/04/13 14:14:51] [WARN] WARNING: query problem with ti=a and search_filter=94 ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 352. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30527] New: Limits are not correctly parsed when query contains CCL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30527 Bug ID: 30527 Summary: Limits are not correctly parsed when query contains CCL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com This was made more apparent by bug 17170 - when a special limit that needs parsing is passed along witha query containing CCL indexes then the limits are not parsed (with exception of 'available' which is handled) This is due to a clause the prevents the normal parsing in C4::Search::buildQuery To test: 1 - Perform advanced search in staff client 2 - Select 'More options' 3 - In first box with keyword as index type 'ti:a' 4 - Enter a year into Limits 5 - Search 6 - You see only 'ti:a' in description, and search fails with bug 17170 1 - Save a search filter visible in staff client 2 - Perform a search like 'ti:a' 3 - Attempt to filter using custom filter 4 - In plack intranet error log: [2022/04/13 14:14:51] [WARN] WARNING: query problem with ti=a and search_filter=94 ZOOM error 10014 "CCL parsing error" (addinfo: "Unknown qualifier") from diag-set 'ZOOM' at /kohadevbox/koha/C4/Search.pm line 352. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should not limit to 100 records for ElasticSearch (causing incomplete authority merges)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30526] The pagination in the REST API does not work if $c->objects->search is called multiple times.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526 Andreas Jonsson changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Andreas Jonsson --- Test plan: * Make sure you have at least 3 libraries that may be pickup locations. * Activate the system preference AllowHoldPolicyOverride * Change the system preference RESTdefaultPageSize to 1 * Go to a record and make a place a hold. * In the Holds view for the record, verify that all libraries appear in the pickup library drop down menu on the hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should not limit to 100 records for ElasticSearch (causing incomplete authority merges)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522 Marcel de Rooy changed: What|Removed |Added Summary|SearchEngine::simple_search |SearchEngine::simple_search |_compat should not limit to |_compat should not limit to |100 records for |100 records for |ElasticSearch |ElasticSearch (causing ||incomplete authority ||merges) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should not limit to 100 records for ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522 Marcel de Rooy changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30522] SearchEngine::simple_search_compat should not limit to 100 records for ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30522
Marcel de Rooy changed:
What|Removed |Added
Severity|minor |normal
QA Contact|testo...@bugs.koha-communit |
|y.org |
CC||n...@bywatersolutions.com,
||tomasco...@gmail.com
Version|21.11 |master
Component|MARC Authority data support |Searching - Elasticsearch
Summary|Issue with |SearchEngine::simple_search
|merge_authorities script ? |_compat should not limit to
||100 records for
||ElasticSearch
--- Comment #5 from Marcel de Rooy ---
(In reply to Bernard from comment #4)
> It's version 21.11.01.000
>
> I've just run your little script:
>
> use Modern::Perl;
> use Data::Dumper qw/Dumper/;
> use Koha::Authorities;
> my @biblionumbers = Koha::Authorities->linked_biblionumbers({ authid => 7307
> });
> print Dumper( scalar @biblionumbers );
>
> >>>
>
> $ perl /home2/kfc/kohaclone/Koha/bertest.pl
> $VAR1 = 100;
>
> There are 104 bib records linked to this authority
Found it!
You are using ElasticSearch, I used Zebra.
The cause is in the Koha/SearchEngine/ElasticSearch/Search.pm module:
sub simple_search_compat {
my ($self, $query, $offset, $max_results) = @_;
return ('No query entered', undef, undef) unless $query;
my %options;
$offset = 0 if not defined $offset or $offset < 0;
$options{offset} = $offset;
$max_results //= 100;
=> This sub expects a max_results parameter for Elastic while the Zebra one
does not require it. No max_results means there all results.
So we need to adjust that one somehow. CCing Nick and Tomas.
Good catch !
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30526] The pagination in the REST API does not work if $c->objects->search is called multiple times.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526 --- Comment #1 from Andreas Jonsson --- Created attachment 133262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133262&action=edit Bug 30526: Copy parameters when building links in rest api. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30525] Items batch modification broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30525 --- Comment #1 from Fridolin Somers --- We see 2 ways : > git grep 'CGI::Cookie->fetch' admin/import_export_authtype.pl:my %cookies = CGI::Cookie->fetch(); admin/import_export_framework.pl:my %cookies = CGI::Cookie->fetch(); authorities/merge_ajax.pl:my %cookies = CGI::Cookie->fetch; cataloguing/merge_ajax.pl:my %cookies = CGI::Cookie->fetch; opac/opac-ratings-ajax.pl:my %cookies = CGI::Cookie->fetch; opac/opac-tags.pl:my %cookies = CGI::Cookie->fetch; tags/review.pl:my %cookies = CGI::Cookie->fetch; tools/background-job-progress.pl:my %cookies = CGI::Cookie->fetch; tools/upload-file.pl:my %cookies = CGI::Cookie->fetch; 16:05:46 ~/git/koha-master [ master | v21.11.00 p+1076 | u= ] > git grep 'parse CGI::Cookie' offline_circ/enqueue_koc.pl:my %cookies = parse CGI::Cookie($cookie); offline_circ/process_koc.pl:my %cookies = parse CGI::Cookie($cookie); tools/batchMod.pl:my %cookies = parse CGI::Cookie($cookie); tools/manage-marc-import.pl:my %cookies = parse CGI::Cookie($cookie); tools/modborrowers.pl:my %cookies = parse CGI::Cookie($cookie); tools/stage-marc-import.pl:my %cookies = parse CGI::Cookie($cookie); tools/upload-cover-image.pl:my %cookies = parse CGI::Cookie($cookie); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30526] New: The pagination in the REST API does not work if $c->objects->search is called multiple times.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526
Bug ID: 30526
Summary: The pagination in the REST API does not work if
$c->objects->search is called multiple times.
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: andreas.jons...@kreablo.se
CC: tomasco...@gmail.com
The REST-plugin Koha::REST::Plugin::Pagination defines two methods:
dbic_merge_pagination and add_pagination_headers. The method
add_pagination_headers use the helper subroutine _build_link. The last
call in add_pagination_headers looks like this:
push @links,
_build_link( $c,
{ page => $pages, per_page => $per_page, rel => 'last', params
=> $args->{params} } );
Here is _build_link:
sub _build_link {
my ( $c, $args ) = @_;
my $params = $args->{params};
$params->{_page} = $args->{page};
$params->{_per_page} = $args->{per_page};
Note that the original parameters _page and _per_page is overwritten
here. This means that _page will be $pages. Subsequent calls to
$c->objects->search will, thus, always return the last page.
At least REST::V1::Holds::pickup_locations is affected by this
(because a redundant call to $c->objects->search is made if
AllowHoldPolicyOverride is activated). This causes the dropdown menu with
pickup locations in the holds view to only contain the last page of libraries
if there are more than 20 pickup libraries and AllowHoldPolicyOverride is
activated.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30498] Enum search_field.type should contain year in kohastructure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30498] Enum search_field.type should contain year in kohastructure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30498 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30485] Searching all patrons from the header does not display the patron search view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30485] Searching all patrons from the header does not display the patron search view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30485 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30481] Drop unique constraint deleteditemsstocknumberidx for deleteditems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30481] Drop unique constraint deleteditemsstocknumberidx for deleteditems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30481 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30476] Remove NORMARC translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30476 --- Comment #3 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30476] Remove NORMARC translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30476 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30426] suggestion service missing Auth and Output imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30426 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 --- Comment #15 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30410] Add a way for plugins to register background tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30410 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30376] Unable to save item if field date acquired is set mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30376] Unable to save item if field date acquired is set mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30376 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not accept whitespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30142] ElasticSearch MARC mappings should not accept whitespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30142 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
