[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |oleon...@myacpl.org |com | Status|Passed QA |In Discussion --- Comment #42 from Jonathan Druart --- (In reply to Fridolin Somers from comment #40) > That code looks very strange to me. > Naming a TT filter 'Filter'. > > I would prefer to see syntax : [% var | $NoDoubleEncode %] > Like TT plugin Price. > > Class is using : > Base qw( Template::Plugin::Filter ) > But does not implement a 'filter' method. The idea was to have a module that would deal with other encode/decode, or replacements functions. I still think it is a good idea. I don't have more time to dedicate to this patch unfortunately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > Could you provide a test plan for this one? Go to /cgi-bin/koha/members/members-home.pl Click search without providing any terms Search "henry" in the global DT search and "h" in the "Name" column filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #120 from Martin Renvoize --- Awesome, thanks for the review Tomas. I'm happy to work on tests today, revisiting it yesterday my intention was to add some more tests as I also found them to be lacking. I got held up as it appears Circulation.t is failing already due to the constraint added here.. but I can't for the life of me work out why as the data does appear to be present and correct in k-t-d where I was testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28709] Fetching biblio objects for custom covers is inefficient
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28709 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- yes, *should* :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7709] Cover Images Template plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7709 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 --- Comment #3 from Jonathan Druart --- Created attachment 134203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134203&action=edit Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item Test plan: 1 - Enable HoldsAutoFill 2 - Place a title level hold 3 - Check in an item and confirm hold 4 - Switch to another branch 5 - Checkin the item Without this patch you got Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. at /kohadevbox/koha/C4/Reserves.pm line 1576 With this patch applied the operation succeeds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22490] Some strings in JavaScript files are untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Jérémy Breuillard changed: What|Removed |Added Attachment #134072|0 |1 is obsolete|| --- Comment #10 from Jérémy Breuillard --- Created attachment 134204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134204&action=edit Bug 22490: Some strings in JavaScript files are untranslatable This patch updates the translation functions of the strings in Javascript files Test Plan: 1) Find a string in a popup or from a Javascript file who is still not translated or 1) Home > Administration > Authority types 2) Make sure to have at least one Authority type saved 3) Click on Action > Import 4) Import button without adding any file to trigger the popup 5) The string inside the popup appears without translation 6) Apply patch and repeat from 3) to 5) : now the string is translated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 --- Comment #7 from Jonathan Druart --- (In reply to Martin Renvoize from comment #6) > Hmm, wasn't there actually a reason cataloguers needed to be able to change > library? I have a feeling this was a feature rather than a bug as I've > asked this question before.. ccing people to help dredge the hive mind. It's the purpose of bug 29887 if I understand correctly. This patch should provide a change at the controller level (and not only hide the link in the template). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30637] New: Add Koha::Checkout->renew method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637 Bug ID: 30637 Summary: Add Koha::Checkout->renew method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org We should introduce a `renew` method in the Koha::Checkout object and start to migrate calls from C4::Circulation to it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30637] Add Koha::Checkout->renew method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637 Martin Renvoize changed: What|Removed |Added Depends on||30275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 [Bug 30275] Checkout renewals should be stored in their own table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Blocks||30637 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30637 [Bug 30637] Add Koha::Checkout->renew method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 --- Comment #3 from Jonathan Druart --- Created attachment 134205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134205&action=edit Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_05_candidate, ||rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30620] Add a warning close to /*!VERSION lines in kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30620 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #6 from Jonathan Druart --- Not a good idea, kohastructure.sql will be regenerated at the next major release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #65 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #63) > And in line with the former comments, the following commit made lots of > useless changes in kohastructure: > Could you remove them, Jonathan ? As said on another bug report, this kohastructure.sql will be auto generated when 22.05.00 will be released. We should not add manual changes to it (apart from the usual changes). If you want to modify it you should adjust mysqldump's output (which was already not trivial if you read the previous comments). Or sed it and modify koha-dump. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 Marcel de Rooy changed: What|Removed |Added Summary|Dateaccessioned is set to |Missing dateaccessioned is |todays date if missing when |set to today when storing |storing an item.|an item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 --- Comment #2 from Marcel de Rooy --- Did you see: 29815 KohaSerials alexbuck...@catalyst.net.nz Push--- Pre-populate 'Date acquired' field when adding/editing items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 Marcel de Rooy changed: What|Removed |Added Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 --- Comment #3 from Katrin Fischer --- Hm, as Koha always forced dateaccessioned itself, I wonder if this is not actually a data problem :( The field cannot be null, unless you explicitly forced it to be. When migrating data using the import tools, the date is also set. The only way to end up with empty is by migrating with SQL, I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Attachment #134202|0 |1 is obsolete|| --- Comment #9 from Emmi Takkinen --- Created attachment 134206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134206&action=edit Bug 30328: Add ability to generate barcode with branch specific prefix We should add more flexibility to generating barcodes by letting libraries define branch specific prefix for their barcodes. This patch adds new option "premmincr" in systempreference "autoBarcode" and new systempreference "BarcodePrefix" to define branch specific prefix Test plan for adding item: 1. Apply patch and update database 2. Set syspref "autoBarcode" as 3. Add some values to syspref "Barcodeprefix" e.g.: Default: DEF CPL: CPL FFL: FFL 4. Now change your library to CPL (if needed) and add an item 5. Click barcode input field => barcode should be CPL1 6. Add another item and click barcode field => barcode should be CPL2 7. Change your library to FFL and add an item => barcode should now be FFL1 8. Change your library to e.g. FPL (or another as long as it doesn't have prefix value in "Barcodeprefix"), add an item and click barcode field => barcode should now be DEF1 9. Try to add multiple items => barcodes incremental value should increase in order (no skipping values, no errors) Test plan for adding multiple aqcuisitions: 1. Set syspref "AcqCreateItem" as "placing order". 2. Create an order and add multiple items to it. 3. Save the order. 4. Navigate to that biblios detail page to which you added items. => ordered items barcodes incremental value should increase in order (no skipping values, no errors) Also prove t/db_dependent/Barcodes_ValueBuilder.t and t/Barcodes_premmincr.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22490] Some strings in JavaScript files are untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Jérémy Breuillard changed: What|Removed |Added Attachment #134204|0 |1 is obsolete|| --- Comment #11 from Jérémy Breuillard --- Created attachment 134207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134207&action=edit Bug 22490: Some strings in JavaScript files are untranslatable This patch updates the translation functions of the strings in Javascript files Test Plan: 1) Find a string in a popup or from a Javascript file who is still not translated or 1) Home > Administration > Authority types 2) Make sure to have at least one Authority type saved 3) Click on Action > Import 4) Import button without adding any file to trigger the popup 5) The string inside the popup appears without translation 6) Apply patch and repeat from 3) to 5) : now the string is translated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 --- Comment #4 from Marcel de Rooy --- If we would remove the second $self->dateaccessioned($today) that is after the modify branch in store, we still have the effect that opening an item that has a NULL date in dateaccessioned will be populated with today due to 29815 (the value builder will put today in that field now). Does it make more sense to choose some arbitrary date for all unknown acquired dates and run a SQL update to replace the NULLs? And even the -00-00 values that I still discovered in my table too? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 --- Comment #5 from Andreas Jonsson --- Indeed, missing dateaccessioned fields stems from data migration. And sometimes there is not meaningful date in the source data, so it makes sense to allow it to be empty to indicate that the date is unknown. As it stands we have to use a garbage date such as 1901-01-01 to indicate that the date is unknown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Marcel de Rooy --- Current master as of today: Trying to save 24.99 does no longer work. Trying to save free text like 'test' does not work. An empty field results in date of today in record (no problem). But unfortunately I can still get -00-00 into my records by entering -00-00 into the date field. It is displayed by the date picker as 00-1-11-30 (meaning: November 30 of year -1 ??) but gets stored as -00-00. Also note: I can also save -01-01. Or 0001-01-01, 0002-02-01, etc. Years like 0001 are displayed in the date picker as 1901 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29815 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27768 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29915] Anonymous session generates 1 new session ID per hit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #129 from Jonathan Druart --- (In reply to Andrew Fuerste-Henry from comment #128) > I've been unable to get this to apply to 21.05. Please rebase for backport. > Thanks! Fortunately this bug has been caused by bug 29914 and is not affecting 21.05.x! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Bug 28786 depends on bug 29915, which changed state. Bug 29915 Summary: Anonymous session generates 1 new session ID per hit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29954] Fix C4::Context->unset_userenv and rename _new too
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29954 Bug 29954 depends on bug 29915, which changed state. Bug 29915 Summary: Anonymous session generates 1 new session ID per hit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 David Nind changed: What|Removed |Added Attachment #134203|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 134208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134208&action=edit Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item Test plan: 1 - Enable HoldsAutoFill 2 - Place a title level hold 3 - Check in an item and confirm hold 4 - Switch to another branch 5 - Checkin the item Without this patch you got Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. at /kohadevbox/koha/C4/Reserves.pm line 1576 With this patch applied the operation succeeds Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 --- Comment #6 from Marcel de Rooy --- Adding see also to bug 27768. Strange values like -00-00, 0001-01-01 etc. Date picker does not like them either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29915] Anonymous session generates 1 new session ID per hit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29915 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27768 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29958 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 Marcel de Rooy changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz ||, ||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today when storing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29815 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29958 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 Marcel de Rooy changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29815 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Marcel de Rooy changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27768 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Jonathan Druart changed: What|Removed |Added Attachment #128576|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 134209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134209&action=edit Bug 29623: Cache circulation rules Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > Could I get a test plan for this please? Confirm that the rule is taken into account where get_effective_rules is used (hardduedate for instance). And that a new value is used when modified in the circ matrix (ie. the cache is flushed when a rule is updated). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 --- Comment #3 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #2) > Current master as of today: > > Trying to save 24.99 does no longer work. > Trying to save free text like 'test' does not work. > > An empty field results in date of today in record (no problem). > > But unfortunately I can still get -00-00 into my records by entering > -00-00 into the date field. It is displayed by the date picker as > 00-1-11-30 (meaning: November 30 of year -1 ??) but gets stored as > -00-00. > > Also note: I can also save -01-01. Or 0001-01-01, 0002-02-01, etc. Years > like 0001 are displayed in the date picker as 1901 ? https://github.com/flatpickr/flatpickr/issues/1524 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Attachment #132925|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Jérémy Breuillard changed: What|Removed |Added Attachment #132926|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Jérémy Breuillard changed: What|Removed |Added Attachment #132927|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30638] New: Odd number of elements in anonymous hash at C4/Letters.pm line 827
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 Bug ID: 30638 Summary: Odd number of elements in anonymous hash at C4/Letters.pm line 827 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Originating from 20.11 warnings: Odd number of elements in anonymous hash at C4/Letters.pm line 878 output_pref({ dt => dt_from_string( $replacedby ), dateonly => $dateonly }); This is line 827 on current master. If dt_from_string returns undef in list context, we get the odd number warn. Also note the following lines: if ( $letter->{ $letter_field } ) { $letter->{ $letter_field } =~ s/\Q<<$table.$field$filter_string_used>>\E/$replacedby_date/g; $letter->{ $letter_field } =~ s/\Q<<$field$filter_string_used>>\E/$replacedby_date/g; If output_pref should correctly return undef on a NULL from dt_from_string, the undefined result triggers two warnings in the regexes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 --- Comment #1 from Marcel de Rooy --- Probably related to -00-00 in dateaccessioned. See 27768. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30623] Copy permissions from one user to another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 --- Comment #1 from Michal Denar --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 --- Comment #4 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #2) > But unfortunately I can still get -00-00 into my records by entering > -00-00 into the date field. It is displayed by the date picker as > 00-1-11-30 (meaning: November 30 of year -1 ??) but gets stored as > -00-00. I don't recreate that, I am getting a 500 with Invalid value passed, dateaccessioned=00-1-11-30 expected type is date at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #121 from Martin Renvoize --- Created attachment 134210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134210&action=edit Bug 30275: (follow-up) Drop renewer_id constraint This patch fixes some unit tests by ensureing we set a valid userid for mock userenv setting so that the foreign key constraint doesn't fail and it also removes the exception class and check for renewer_id from the store method as, for example with autorenewals, the renewal may not have been triggered by a actual user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 Nick Clemens changed: What|Removed |Added Attachment #134084|0 |1 is obsolete|| Attachment #134085|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 134211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134211&action=edit Bug 30576: Use DefaultPatronSearchFields in patron search This patch corrects the handling of the 'Standard' search field in patron searches such that it accurately reflects the contents of the DefaultPatronSearchFields system preference and falls back to a hard coded list instead of always using the hard coded list. To test: 1) Empty the contents of DefaultPatronSearchFields systempreference 2) Perform a patron search from the header search 3) Inspect the patrons API request and note that we search on the default fallback fields of firstname, surname, othernames, cardnumber and userid (and some extended attributes which are historically hard coded). 4) Navigate to the memebers-home by clicking the 'Patrons' button from the main page 5) Perform another search using the filters on the left with 'Standard' selected. 6) Note the same list of search fields used as above in the patrons API request. 7) Update the DefaultPatronSearchFields systempreference adding one or more borrower fields in a comma delimited list. 8) Repeat steps 2 -> 6 but this time upon inspecting the API request you should find that only the fields in your DefaultPatronSearchFields list are searched (along with the hard coded extended attributes list). 9) Signoff Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30576] DefaultPatronSearchFields no longer takes effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30576 --- Comment #16 from Nick Clemens --- Created attachment 134212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134212&action=edit Bug 30576: (follow-up) Corrections to behaviour to reflect unit tests The unit tests highlighted my original patch didn't cover the full preference description. We now replace the 'standard' option with the fields from the preference and we also add those fields as options to the field selection in advanced searches. This patch also adjusts the tests to test for that and reflects the expected changes to the number of options displayed in the select boxes. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27619] Remove fr-FR installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart changed: What|Removed |Added Attachment #121625|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 134213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134213&action=edit Bug 27619: Add custom for fr-FR -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 Nick Clemens changed: What|Removed |Added Attachment #134055|0 |1 is obsolete|| Attachment #134056|0 |1 is obsolete|| Attachment #134057|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 134214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134214&action=edit Bug 30626: DT REST API wrapper - Fix general search The general search query is not built correctly. Say you have a table with column filters, like the main patron search: General filter: henry Specific filter on the 'Name' column: h The generated query will be (= are actually LIKE): { Column1="henry" AND Column3="henry", ...} AND { Column2="h" } The first term does not contain the Column2 attribute. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 --- Comment #12 from Nick Clemens --- Created attachment 134215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134215&action=edit Bug 30626: Fix test Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 --- Comment #13 from Nick Clemens --- Created attachment 134216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134216&action=edit Bug 30626: (QA follow-up) Fix test plan Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27619] Remove fr-FR installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|ASSIGNED|Needs Signoff --- Comment #6 from Jonathan Druart --- Patches pushed to https://gitlab.com/joubu/Koha/-/commits/bug_27619 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Marcel de Rooy changed: What|Removed |Added Depends on||30638 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 Marcel de Rooy changed: What|Removed |Added Blocks||25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 Jonathan Druart changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 --- Comment #2 from Marcel de Rooy --- Created attachment 134217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134217&action=edit Bug 30638: Resolve odd number in hash warn in Letters Odd number of elements in anonymous hash at C4/Letters.pm line 827. Trivial fix. Adding undefined check on result to prevent warns on that one. No test plan. Read the patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30638] Odd number of elements in anonymous hash at C4/Letters.pm line 827
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30638 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- Trivial: self SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #64 from Martin Renvoize --- Note to self, must add 'Sponsored-by: Loughborough University' line back into patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #56 from Martin Renvoize --- Not to self, add in 'Sponsored-by: Cheshire Libraries' line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30630] Checking in a waiting hold at another branch when HoldsAutoFill is enabled causes errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Nick Clemens changed: What|Removed |Added Attachment #134208|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 134218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134218&action=edit Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item Test plan: 1 - Enable HoldsAutoFill 2 - Place a title level hold 3 - Check in an item and confirm hold 4 - Switch to another branch 5 - Checkin the item Without this patch you got Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. at /kohadevbox/koha/C4/Reserves.pm line 1576 With this patch applied the operation succeeds Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through stage MARC record import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through stage MARC record import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #84 from Nick Clemens --- Created attachment 134219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134219&action=edit Bug 22785: (follow-up) Update contentType in request -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30628] Batch borrower modifications only affect the current page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Nick Clemens changed: What|Removed |Added Attachment #134205|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 134220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134220&action=edit Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-all-pages-with-jquery-datatables Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30639] New: Patron search does not find patrons if passed first and last name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639 Bug ID: 30639 Summary: Patron search does not find patrons if passed first and last name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Search for: "edna acosta" OR "henry acevedo" OR you favorite default patron No results! The query is search for both terms in each field: i.e. firstname LIKE 'edna acosta' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30639] Patron search does not find patrons if passed first and last name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639 Nick Clemens changed: What|Removed |Added Depends on||30063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Nick Clemens changed: What|Removed |Added Blocks||30639 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30639 [Bug 30639] Patron search does not find patrons if passed first and last name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Nick Clemens changed: What|Removed |Added Attachment #134196|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 134221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134221&action=edit Bug 29755: Check each NoIssuesCharge separately This patch updates SIP patron code to use account methods to calculate balances over the patronflags returns. It also checks if patron should be blocked for each 'No Issues charge' preference Tests are added for NoIssuesChargeGuarantees To test: 1 - Set noissuescharge preference to 5 2 - Add a $10 charge to a patron 3 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 4 - Note the 64 message starts with Y's that mean patron is blocked 5 - Set noissuescharge to 11 6 - Repeat 3, patron is no longer blocked 7 - Set NoIssuesChargeGuarantees to 8 8 - Repeat 3, patron is blocked 9 - Pay $3 on patron so they owe 7 10 - Repeat 3, patron is not blocked 11 - Add a child account with patron as guarantor 12 - Repeat 3, patron is not blocked 13 - Add a $4 charge to child 14 - Repeat 3, patron is blocked 15 - Repeat 3, but with child barcode, child is not blocked 16 - Set NoIssuesChargeGuarantorsWithGuarantees to 10 17 - Repeat 3, patron is blocked 18 - Repeat 3 with child barcode, child is blocked Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 --- Comment #5 from Nick Clemens --- Created attachment 134222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134222&action=edit Bug 29755: (follow-up) Mock NoIssuesChargeGuarantorsWithGuarantees in test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Nick Clemens changed: What|Removed |Added Attachment #134010|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30626] DT REST API wrapper not building the filter query correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30626 --- Comment #14 from Katrin Fischer --- Now Nick beat me to it :) Nick++ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What|Removed |Added Attachment #130240|0 |1 is obsolete|| --- Comment #11 from Jérémy Breuillard --- Created attachment 134223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134223&action=edit Bug 29983: Display the pretend claim column in overdue.tt This patch displays the column "Return claims" from the page "moremember.pl" to the page "overdues.pl". Rebase on master. Test plan: 1) Use a patron with at least 1 item who should be checked out soon 2) Home > Patron > Patron details for [name] 3) Click on the 'Checkout' button down the page to show the full table and notice the "Return Claims" column 4) Now go to Home > Circulation > Overdues 5) Find the patron who has to check out and have a look at the table 6) Apply patch and repeat 4) and 5) -> the "Return Claim" column is now displayed on the table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27077] Searching for patrons with guarantor_id criteria results in 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27077 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |DUPLICATE CC||tomasco...@gmail.com Status|NEW |RESOLVED --- Comment #1 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 30534 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30534] borrowers.guarantorid not present on database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30534 Tomás Cohen Arazi changed: What|Removed |Added CC||arthur.suz...@biblibre.com --- Comment #7 from Tomás Cohen Arazi --- *** Bug 27077 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #11 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #10) > Looks like this was signed off so adjusting bug status. Thanks, Aleisha! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30640] New: Focus does not always move to correct search header form field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640 Bug ID: 30640 Summary: Focus does not always move to correct search header form field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 29155 The jQuery upgrade has introduced a bug with how the header search form is supposed to handle focus. This can be seen in any page where the "Check out" tab is present in the header search but not the pre-selected tab, e.g. the patron detail tab. On the patron details page the "Search patrons" tab is selected by default, and the cursor focus is automatically put on the form field. Switch to the "Check out" tab and you'll find that the focus doesn't move to the form field. The other tabs don't have this problem. I think this is the explanation: https://github.com/jquery/jquery/issues/4950 To fix we'll need to remove the "focus" class on form fields which might be hidden by default and update the tabs behavior to make sure the right field is focused on load. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 [Bug 29155] Upgrade jquery version to 3.6.0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29155] Upgrade jquery version to 3.6.0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Owen Leonard changed: What|Removed |Added Blocks||30640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640 [Bug 30640] Focus does not always move to correct search header form field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27768] Saving an item with an invalid dateaccessioned or replacementpricedate throws no helpful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27768 --- Comment #5 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #4) > I don't recreate that, I am getting a 500 with > > Invalid value passed, dateaccessioned=00-1-11-30 expected type is date at > /usr/share/perl5/Exception/Class/Base.pm line 88 Set sql mode to 0. Assuming that this still is the case for a regular install. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/