[Koha-bugs] [Bug 30760] "Next" button is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30760 Sena changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30760] "Next" button is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30760 Sena changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30760] New: "Next" button is not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30760 Bug ID: 30760 Summary: "Next" button is not working Change sponsored?: --- Product: Koha Version: master Hardware: PC URL: https://www.w3schools.com/html/default.asp OS: Windows Status: UNCONFIRMED Severity: normal Priority: P3 Component: Websites, Mailing Lists, etc Assignee: senaweera.c...@gmail.com Reporter: teharasewm...@gmail.com QA Contact: testo...@bugs.koha-community.org Deadline: 2022-06-01 Created attachment 135007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135007=edit "Next" button is not working Test cases: 1. Open any browser. 2. Go to https://www.w3schools.com/html/default.asp 3. Click "Next" button. 4. Go to the next page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #8 from David Nind --- I tested in koha-testing-docker: 1. Ran tests before applying patches and these passed: prove t/db_dependent/Koha_Authority.t 2. Ran tests using new name after applying patches, and these passed: prove t/db_dependent/Koha_MetadataRecord_Authority.t Hope that is sufficient. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind changed: What|Removed |Added Attachment #135000|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 135006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135006=edit Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind changed: What|Removed |Added Attachment #134999|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 135005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135005=edit Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind changed: What|Removed |Added Attachment #134998|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 135004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135004=edit Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30742] Confusion when placing hold on record with no items available because of not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742 David Nind changed: What|Removed |Added Attachment #134983|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 135003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135003=edit Bug 30742: Remove 'bad_bibs' and send a list of holdable bibs Currently place request gets a list of bad_bibs that is created via javascript on the template. It ignores this list Ths patch instead doesn't add info for bad bibs, and provides a list of the bibs that can be held To test: 1 - Attempt multi hold with some items that can be held, and one that cannot due to notforloan 2 - Fill in pickup locations and place hold 3 - Note hold is place on bib with no avilable items and hsows twice in results 4 - Apply patch 5 - repeat with another patron 6 - Note no aidditonal hold on record with notforloan items 7 - Note with with not for loan items appears only once in results Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30742] Confusion when placing hold on record with no items available because of not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742 David Nind changed: What|Removed |Added Attachment #134982|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 135002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135002=edit Bug 30742: Prevent placing holds on items/records where all items notforloan This patch does a few things: 1 - Adds itemtype not for loan status to display 2 - Adds a conditional to display notforlaon status as the reason a hold cannot be placed 3 - Seperates the lower 'Place hold(s)' buttons for single and multi holds into two template sections 4 - Handles the case where all bibs in a multi hold have no items available 5 - Disables the button for single hlds when all items are unavailable To test: 1 - Find or create a record with all items of itemtype marked 'notforloan' 2 - Attempt to place single hold on this record from staff client 3 - See one disab;ed button, one enabled 'Place holds' button 4 - Click 'Place holds' - hold placed 5 - Cancel hold 6 - Place multiple holds with some bibs that can be held, and this one that cannot 7 - Notice message that 'Cannot place hold on some items' 8 - Click 'Place holds' - hold is generated for the notforloan bib 9 - Apply patch 10 - Place single hold 11 - Note you now see not for loan status on items 12 - Note the red x also includes message abnout not for loan status 13 - Note the 'Place hold' button is disabled 14 - Attempt multi hold 15 - Message now includes "No items available: One or more records have no items that can be held" 16 - Click 'Place holds' 17 - Above still places the hold - this is for a followup patch Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30742] Confusion when placing hold on record with no items available because of not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26932] Importing staged bibliographic MARC records does not show a completed status if there are any item records to stage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26932 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Can confirm that this is still the case in master - a record with items hangs at 0%, the record is added, but no items are added. Note: I saw this bug, and thought bug 30520 might solve this - but it doesn't. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30629] in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 David Nind changed: What|Removed |Added Attachment #134990|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 135001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135001=edit Bug 30629: fix in title of some pages == Test plan == 1. Go to http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout 2. See that the page title in your browser window title is wrong because it contains 3. Go to http://localhost:8081/cgi-bin/koha/labels/label-manage.pl?label_element=batch 4. See that the page title in your browser window title is wrong because it contains 5. Go to http://localhost:8081/cgi-bin/koha/admin/aqbudgetperiods.pl 6. Administration => Budgets => Click on a budget => planning => plan by months 7. See that the page title in your browser window title is wrong because it contains 8. Refresh the pages and see that the titles are correct 9. Sign off :) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30629] in title of patron card creator template needs to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #21 from Victor Grousset/tuxayo --- (The final result is what I posted at the beginning of the comment "the number of the strings it would have lost") -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #152 from Katrin Fischer --- I indeed missed your comment Victor. When testing this I made sure that nothing would happen/be sent to Google, while the feature is not active. A note on the system preference including information about what is sent to Google would make sense. Even better if we could make it so the request is not from the browser, but handled server side. I've filed 2 bugs: * Bug 30758 - Handle Google Books API requests for OPACSuggestionAutoFill on server side * Bug 30759 - Add hint about the data that is sent via the Google Books API to OPACSuggestionAutoFill -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Blocks||30759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30759 [Bug 30759] Add hint about the data that is sent via the Google Books API to OPACSuggestionAutoFill -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30759] New: Add hint about the data that is sent via the Google Books API to OPACSuggestionAutoFill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30759 Bug ID: 30759 Summary: Add hint about the data that is sent via the Google Books API to OPACSuggestionAutoFill Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 14242 On bug 14242 Victor suggested to add a hint to the OPACSuggestionAutoFill system preference that explains about possible implications to data privacy and lists which data is sent via the Google Books API: (In reply to Victor Grousset/tuxayo from comment #118) > And meanwhile, should a small warning in the syspref description be added? > So the library can update their documents about their personal data > processing. > > Something like «Personal data processing: Google will receive the following > data: IP address, OS name, web browser version, preferred languages, and the > ISBNs of the books suggested.» Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Blocks||30758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30758 [Bug 30758] Handle Google Books API requests for OPACSuggestionAutoFill on server side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30758] New: Handle Google Books API requests for OPACSuggestionAutoFill on server side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30758 Bug ID: 30758 Summary: Handle Google Books API requests for OPACSuggestionAutoFill on server side Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 14242 Bug 14242 allows to use the Google Book API to pull in information about a book from the ISBN or similar. At the moment the request is done in the browser, but for privacy concerns it would be better if the request could be made from the Koha server instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 [Bug 14242] Use ISBN-field to fill out purchase suggestions using Google Books API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27175] Jenkins instance exposed to public
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27175 Furman Khan changed: What|Removed |Added Attachment #114267|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30757] The last two skips on Jenkins for Koha_ExternalContent_RecordedBooks.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30757 --- Comment #1 from Marcel de Rooy --- t_db_dependent_Koha_ExternalContent_RecordedBooks_t 39 ms 0 2 1 3 The only test we do on Jenkins, is the use_ok on the module Reference to debian package libwebservice-ils-perl_0.17-1_all.deb -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30757] New: The last two skips on Jenkins for Koha_ExternalContent_RecordedBooks.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30757 Bug ID: 30757 Summary: The last two skips on Jenkins for Koha_ExternalContent_RecordedBooks.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Marcel de Rooy changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #4 from Marcel de Rooy --- So we should no longer see these 3 on Jenkins: t_db_dependent_Koha_Authority_t 0.82 sec0 3 8 11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #3 from Marcel de Rooy --- Created attachment 135000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135000=edit Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #2 from Marcel de Rooy --- Created attachment 134999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134999=edit Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #1 from Marcel de Rooy --- Created attachment 134998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134998=edit Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30756] New: Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Bug ID: 30756 Summary: Get skip block out of Koha_Authority.t and add TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org This test contains 3 skips on Jenkins. It uses a MARC file. We could quite easily resolve this with TestBuilder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29897] Display author identifiers for researchers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Thibault Keromnès changed: What|Removed |Added CC||thibault.keromnes@univ-pari ||s8.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24638] UNIMARC Authorities update from IFLA for new Koha installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638 Thibault Keromnès changed: What|Removed |Added CC||thibault.keromnes@univ-pari ||s8.fr --- Comment #4 from Thibault Keromnès --- I just checked on master, the 3 fields mentioned are there and looking good. I'll check again after 22.05 is released, it may be impacted by https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] Date last seen should be set upon registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #17 from Martin Renvoize --- There's something really odd going on here.. I don't understand why current_timestamp is coming out wrong.. though I do have vague recollections of such an issue in the past. However.. I also query.. should the column be updated to 'NOT NULL' too if we're giving it a DEFAULT? Also.. sha1 issues trying to apply the follow-up.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- Good call on moving the fix Katrin :) All works as expected and Unit tests included. QA Script happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Martin Renvoize changed: What|Removed |Added Attachment #134663|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 134997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134997=edit Bug 29719: Do not clear onloan value when not passed in MARC We blank the field to prevent users from setting it during import, but this has the affect of blanking it in the DB. This patch replaces the onloan field when not passed in to 'ModItemFromMARC' to preserve the value To test: 1 - Check an item out to a paron 2 - Export the item using Tools->Export data 3 - Stage the record for import 4 - Match on 999c and replace items 5 - Import the batch 6 - View the record and note item is checked out and Available 7 - In the DB note the onloan value is now null 8 - Check in the item 9 - Apply patch 10 - Repeat 1-5 11 - View the record and note item is checked out 12 - In the DB note the onloan value matches the due date Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Martin Renvoize changed: What|Removed |Added Attachment #134662|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 134996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134996=edit Bug 29719: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30720] Batch delete links from result list missing permission checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30720 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Good catch Katrin, all works as expected and QA scripts are happy. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30720] Batch delete links from result list missing permission checks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30720 Martin Renvoize changed: What|Removed |Added Attachment #134970|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 134995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134995=edit Bug 30720: Batch action links in result list missing permission checks In the staff interface you can select records for merging, batch editing, and batch deleting from the result list. This fixes the code to check for the specific batch edit records and batch delete records permissions, so those actions are only shown if the user has the right permissions. As there is no merge record permission yet, it's assumed that edit_cataloge is needed as before (no change in behavior). To test: - Create a staff user with only catalogue and editcatalogue permissions. - Do a search in the catalog of the staff interface - Select a few records from result list to unlock the Edit button on top - Verify it shows all three options: edit, delete and merge - Apply patch - Verfiy now only merging is shown - Add the records_batchdel and records_batchmod permissions from the tools area one after another and verify the display changes accordingly. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- I would have loved to see some of this moved up into module code and unit tested.. but it does resolve the issue here and I feel asking for such a move at this time would be a bit above an beyond. So, working as expected, no regressions found and QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735
Martin Renvoize changed:
What|Removed |Added
Attachment #134971|0 |1
is obsolete||
--- Comment #4 from Martin Renvoize ---
Created attachment 134994
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134994=edit
Bug 30735: Fix filtering by patron attribute with AV in overdues report
In Circulation > Overdues, if there are seachable patron attributes
they can be used in left filters. Search does not work if this attribute
is linked to an authorized values category.
The problem is that AV code is compared to the AV desciption in :
if (grep { $attrval eq lc($_->[1]) } @{ $pattrs->{$code} }) {
Looking at a Data::Dumper of the var $pattrs you see for example :
$VAR1 = {
'ATT1' => [
[
'afr',
'Afrikaans'
]
]
};
First row is attribute code and second row is desciption.
It works for an attribute without AV because in this case
'avdescription' is undefined so code is stored as description :
push @{ $pattrs->{$row->{attrcode}} }, [
$row->{attrval},
defined $row->{avdescription} ? $row->{avdescription} :
$row->{attrval},
];
This patch fixes the code and removes commented line.
Also reviews the SQL query :
- avcategory is useless
- use alias attrcode for borrower_attributes.code to be more explicit
Test plan :
1) Create a patron A with overdues
2) Go to Circulation > Overdues
3) Check you see the patron A
4) Create a patron attribute, searchable, with an authorized value
category, ie LANG
5) Edit patron A to set a value in this attribute
6) Go to Circulation > Overdues
7) Select attribute value and apply filter
8) Check you see the patron A
9) Redo test plan with a patron attribute, searchable, without an
authorized value category
Signed-off-by: Owen Leonard
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Martin Renvoize changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #31 from Martin Renvoize --- All works as described and resolves the bug.. Unit tests passing and QA script happy. I would argue we don't really need the system preference for this.. in my opinion, it's fixing an inconsistency/bug and thus would be a welcome change and consistency improvement so doesn't really need the option to enable/disable.. But I'll leave the final decision to the RM on that one. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Martin Renvoize changed: What|Removed |Added Attachment #134839|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 134993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134993=edit Bug 28529: Make biblio-level hold itemtype count against max rules The current situation is that biblio-level holds can be assigned an item type, so they can only be fulfilled by items matching that specified item type (be it item-level itype or the fallback to biblio-level). But there's the situation in which max holds limits for a specific item type can be overridden by using biblio-level holds with item type selection (AllowHoldItemTypeSelection) enabled. To test: 1. Have a patron of category 'Staff' (S) 2. Have 3 records with items with the 'BK' item type, and maybe others 3. Enable AllowHoldItemTypeSelection 4. Set a limit of 2 max holds for that category+item type 5. In the OPAC. Place bibio-level holds, with item type contraint to 'BK' on those 3 records => FAIL: You can place the 3 holds 6. Cancel the holds 7. Apply this patch and restart all 8. Repeat 5 => SUCCESS: You can only place 2 holds 9. Run: $ kshell t/db_dependent/Reserves.t => SUCCESS: Tests pass! 10. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Martin Renvoize changed: What|Removed |Added Attachment #134838|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 134992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134992=edit Bug 28529: Unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds should honour max_holds as item-level do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529 Martin Renvoize changed: What|Removed |Added Attachment #134837|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 134991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134991=edit Bug 28529: Add BiblioHoldItemTypeUseForRules system preference Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 --- Comment #20 from Victor Grousset/tuxayo --- > My expectation would be, that most of those strings would not require any > changes for 22.05, so not appear as new/fuzzy right now. We shouldn't expect that for this patch. Because that would happen also if this patch would have been merged 1 month ago and it wouldn't have been a problem to add 300 new/fuzzy strings then. The expectation is that we should not loose too much work already done since the string freeze, otherwise that's a problem. If the patch was merged on 11th of May, here are the number of the strings it would have lost: 14 strings for German 1 strings for Armenian 17 strings for Spanish 9 strings for Turkish 11th of May is the last Pootle sync. That's where most work has been done anyway compared to the last two days so it's still representative. And the actual work we have to care about is in the last two days and for now it's even less than the low above numbers. That's fine if this patch is merged for 22.05.01 but the lost work will be higher than the current small one. That's still a good plan because that lost work will be the highest for the most active (yes, both criteria) languages in the next two weeks. And these very active languages will easily recover from that loss. Calculations: Using poedit here are some numbers of empty + fuzzy strings with the .po of master updated against master code. To simulate how it has been when 22.05 was created on the translation platform with the most complete languages: German: staff: 947 opac: 168 = 1115 total strings needing work Italian: staff: 2208 opac: 347 = 2555 (this is weird, Italian is at 100% for 21.11 but the unupdated .po in master aren't 100% complete before string update, as opposed other langs) Armenian: staff: 1116 opac: 168 = 1284 Spanish: staff: 1311 opac: 170 = 1481 Turkish: staff: 1315 opac: 237 = 1552 After applying this patch and updating the strings: German: staff: 1126 opac: 300 = 1426 Italian: staff: 2360 opac: 447 = 2807 Armenian: staff: 1295 opac: 300 = 1595 Spanish: staff: 1484 opac: 302 = 1786 Turkish: staff: 1488 opac: 365 = 1853 If the patch was merged 1 month ago, it would have added a net: 311 strings for German 252 strings for Italian (unreliable due to previous inconsistency) 311 strings for Armenian 305 strings for Spanish 301 strings for Turkish I downloaded the .po from the translation platform as of 11th of May then I put them in my local Koha to get the translation work of the week preceding the string freeze. And I updated the strings. Using poedit here are the numbers of empty + fuzzy strings: German: staff: 713 opac: 29 = 742 Italian: staff: 808 opac: 107 = 915 (the .po in Pootle is okay though. But I can't compare to master then. The recent activity in Pootle is lower than for German so there can't have been 1500 strings done to bridge the gap from the .po in master. So I have to drop Italian in this analysis) Armenian: staff: 839 opac: 115 = 954 Spanish: staff: 826 opac: 111 = 937 Turkish: staff: 998 opac: 116 = 1114 After applying this patch and updating the strings: German: staff: 899 opac: 168 = 1067 Italian: staff: 996 opac: 240 = 1236 Armenian: staff: 1019 opac: 247 = 1266 Spanish: staff: 1016 opac: 243 = 1259 Turkish: staff: 1176 opac: 248 = 1424 If the patch was merged on 11th of May it would have added 325 strings for German 321 strings for Italian 312 strings for Armenian 322 strings for Spanish 310 strings for Turkish The final result is the number of strings added in the 11th of May simulation minus those from the simulation from the creation of the 22.05 translation (with the .po from master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
