[Koha-bugs] [Bug 30803] output_error should not assume a 404 status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30803 Jonathan Druart changed: What|Removed |Added Depends on||23329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23329 [Bug 23329] tracklinks.pl accepts any url from a parameter for proxying if not tracking -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23329] tracklinks.pl accepts any url from a parameter for proxying if not tracking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23329 Jonathan Druart changed: What|Removed |Added Blocks||30803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30803 [Bug 30803] output_error should not assume a 404 status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What|Removed |Added Attachment #131054|0 |1 is obsolete|| --- Comment #14 from Kevin Carnes --- Created attachment 135194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135194&action=edit Bug 29012: Add default values for blank circulation rules that weren't saved to the database There are 5 fields that are not set if no value is provided when saving/editing a rule in Administration->Circulation and fines rules - issuelength - hardduedate - unseenrenewalsallowed - rentaldiscount - decreaseloanholds This is problematic because it gives the impression these rules are set as blank, but in reality they don't exist and the rule will fal back to the higher level To test: 1 - Set a rule for Patron category: Teacher Itemtype: All Hard due date: (Today) Lona period: 10 2 - Set a rule for Patron category: Teacher Itemtype: Books Hard due date: (leave blank) Loan period: 10 3 - Expected behaviour is Book item will checkout to teacher for 10 days, all other types will be due yesterday at 25:59:00 4 - Checkout an non-book item type to teacher 5 - Hard due date applies 6 - Checkout a 'book' item type to teacher 7 - Hard due date applies - FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30804] New: Optionally show information on existing items in order form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30804 Bug ID: 30804 Summary: Optionally show information on existing items in order form Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Some libraries would like to see information about existing items when creating an order line for an existing record. This would be especially helpful for multi-branch libraries that would like to coordinate their acquisitions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30805] New: Missing default value on import_records.marxml_old
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30805 Bug ID: 30805 Summary: Missing default value on import_records.marxml_old Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Depends on: 20144 We fixed a ton of missing default values on bug 20144, I believe this one might be another to fix: import DBD::mysql::st execute failed: Field 'marcxml_old' doesn't have a default value [for Statement "INSERT INTO import_records (import_batch_id, record_sequence, marc, marcxml, record_type, encoding, z3950random) We see this error in an older version after the latest Debian update with a new MariaDB version, but in master we still have: `marcxml` longtext COLLATE utf8mb4_unicode_ci NOT NULL, Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 [Bug 20144] Test suite is failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20144] Test suite is failing with new default SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 Katrin Fischer changed: What|Removed |Added Blocks||30805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30805 [Bug 30805] Missing default value on import_records.marxml_old -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Jérémy Breuillard changed: What|Removed |Added Attachment #135121|0 |1 is obsolete|| --- Comment #6 from Jérémy Breuillard --- Created attachment 135195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135195&action=edit Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Jérémy Breuillard changed: What|Removed |Added Attachment #135195|0 |1 is obsolete|| --- Comment #7 from Jérémy Breuillard --- Created attachment 135196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135196&action=edit Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 Jérémy Breuillard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30323] Wrong error messages on OPAC password recovery form when translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30323 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer --- After a lot of testing, this turned out to be a local issue. Thx again Owen for taking the time to test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29560] Add option to create MARC links when adding items to bundles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 Martin Renvoize changed: What|Removed |Added CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30799] Add REST API route to update biblio metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30799
Paul Derscheid changed:
What|Removed |Added
Attachment #135102|0 |1
is obsolete||
--- Comment #2 from Paul Derscheid ---
Created attachment 135197
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135197&action=edit
Bug 30799: Add REST API route to update biblio metadata
Example:
PUT /api/v1/biblios/{biblio_id}/metadata
...
Calling this endpoint will replace the current MARC record with the one
given in the request body, by calling C4::Biblio::ModBiblio
Test plan:
1. Try requesting this endpoint with your favorite API tool
2. Run `prove t/db_dependent/api/v1/biblios/metadata/put.t`
Signed-off-by: Paul Derscheid
--- Works as advertised. Passes provided test.
Current status: Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30799] Add REST API route to update biblio metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30799 Paul Derscheid changed: What|Removed |Added CC||paul.dersch...@lmscloud.de Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25126] MARC visibility settings not obeyed on cart normal and detailed views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25126 Aude Charillon changed: What|Removed |Added CC||aude.charillon@ptfs-europe. ||com --- Comment #3 from Aude Charillon --- We've found the exact same situation as Lye Jia Lun describes on a site recently upgraded to 21.11.05. The site was on version 20.11.03 before where those options worked fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 David Nind changed: What|Removed |Added Attachment #135196|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 135198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135198&action=edit Bug 30507: Value builder for field 183 This patch provides values builders for the subfields $a and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 183 : it contains subfields $a & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a and $2 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 --- Comment #194 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #193) > (In reply to Martin Renvoize from comment #192) > > Finally.. I couldn't replicate any unit test failures.. for me they all > > pass first time (after a reset) and subsequent runs also pass too :? > > Hum, confirmed. Cannot recreate today. Certainly something wrong with my DB > yesterday. Maybe worth adding a test for 2022-05-18? Kidding -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790
David Nind changed:
What|Removed |Added
Attachment #135089|0 |1
is obsolete||
--- Comment #7 from David Nind ---
Created attachment 135199
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135199&action=edit
Bug 30790: Add REST API route to list biblios
Examples:
GET /api/v1/biblios
GET /api/v1/biblios?q={"title": "foo"}
GET /api/v1/biblios?q={"isbn": "1-23-456789-0"}
GET /api/v1/biblios?_order_by=title
Test plan:
1. Try requesting this endpoint with your favorite API tool
2. Run `prove t/db_dependent/api/v1/biblios/list.t`
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29860] Useless warnings in regressions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #3 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #2) > Tomas: What about changing status here ? Oops -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30806] New: Use patron-title.inc in member-flags template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806 Bug ID: 30806 Summary: Use patron-title.inc in member-flags template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Blocks: 30617 We should use the patron-title include everwhere we display a patron title instead of templates mixing up formats. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 Martin Renvoize changed: What|Removed |Added Depends on||30806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806 [Bug 30806] Use patron-title.inc in member-flags template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30806] Use patron-title.inc in member-flags template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30806] Use patron-title.inc in member-flags template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30806] Use patron-title.inc in member-flags template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806 --- Comment #1 from Martin Renvoize --- Created attachment 135200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135200&action=edit Bug 30806: Migrate to patron-title in member-flags This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to edit their permissions 2) Note how the patron name displays in the title, breadcrump and headings 3) Apply the patch and reload the page 4) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30807] New: Use patron-title.inc in patron payments pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Bug ID: 30807 Summary: Use patron-title.inc in patron payments pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: oleon...@myacpl.org, testo...@bugs.koha-community.org Blocks: 30617 We should use the patron-title include everwhere we display a patron title instead of templates mixing up formats. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30617] [OMNIBUS] We should consistently use includes for patron name display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30617 Martin Renvoize changed: What|Removed |Added Depends on||30807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 [Bug 30807] Use patron-title.inc in patron payments pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30807] Use patron-title.inc in patron payments pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 --- Comment #1 from Martin Renvoize --- Created attachment 135201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135201&action=edit Bug 30807: Migrate to patron-title in pay and paycollect This patch updates the member-flags template to use the patron-title.inc include wherever patron names are referenced. Test plan 1) Navigate to a patron and click through to their accounts tab 2) Note how the patron name displays in the title, breadcrumb and headings 3) Click through to make a payment 4) Note how the patron name displays in the title, breadcrumb and headings 5) Apply the patch and reload the page 6) Confirm the patron name still appears in each location and is consistently formatted and linked as you would expect Note: This patch also removes a superflous hidden title form element that was simply passed to and from the controller but not actually used in any way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30807] Use patron-title.inc in patron payments pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30807] Use patron-title.inc in patron payments pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 --- Comment #2 from Caroline Cyr La Rose --- I tested in a sandbox in case it was my installation that was acting up, and the sandbox is limited to 14, completely ignoring the value in numReturnedItemsToShow (which was set to 20 by default). Even after I changed the pref to 50, the returns.pl page only shows 14. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] New: Release team 22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 Bug ID: 30808 Summary: Release team 22.11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: da...@davidnind.com, dc...@prosentient.com.au, fridolin.som...@biblibre.com, jonathan.druart+k...@gmail.com, katrin.fisc...@bsz-bw.de, k...@bywatersolutions.com, m.de.r...@rijksmuseum.nl, testo...@bugs.koha-community.org, vic...@tuxayo.net, wainuiwitikap...@catalyst.net.nz Depends on: 29300 Add the next release team :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 [Bug 29300] Release team 22.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29300] Release team 22.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 Martin Renvoize changed: What|Removed |Added Blocks||30808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 [Bug 30808] Release team 22.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 --- Comment #1 from Martin Renvoize --- Created attachment 135202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135202&action=edit Bug 30808: Add the 22.05 release team. Test plan 1/ Check against https://wiki.koha-community.org/wiki/Release_Teams -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 Martin Renvoize changed: What|Removed |Added Keywords||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 --- Comment #2 from Martin Renvoize --- This should be one of the last things pushed as you do go through the release process Fridolin :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30808] Release team 22.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30808 Martin Renvoize changed: What|Removed |Added CC|dc...@prosentient.com.au, | |k...@bywatersolutions.com, | |testo...@bugs.koha-communit | |y.org, | |wainuiwitikapark@catalyst.n | |et.nz | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Shi Yao Wang changed: What|Removed |Added Attachment #135175|0 |1 is obsolete|| --- Comment #6 from Shi Yao Wang --- Created attachment 135203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135203&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #7 from Shi Yao Wang --- (In reply to David Nind from comment #5) > I love consistency for terminology, so this is great! > > I have two suggestions to move the "Show/Don't show" options to the start of > the system preference text, rather than at the end, to be as consistent as > possible with how it is used elsewhere: > > - noItemTypeImages: > . Updated text: Show itemtype icons in the staff interface: Show/Don't show > . Change to: Show/Don't show itemtype icons in the staff interface. > > - OpacNoItemTypeImages: > . Updated text: Show itemtype icons in the OPAC: Show/Don't show > . Change to: Show/Don't show itemtype icons in the OPAC. > > I'll also add to the terminology list: > https://wiki.koha-community.org/wiki/Terminology Added the suggested changes in noItemTypeImages and OpacNoItemTypeImages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30809] New: Add method to delete analytic link from holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30809 Bug ID: 30809 Summary: Add method to delete analytic link from holdings table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When using analytic cataloging, the bib detail page for the child record shows an item from the host record and offers all of the usual edit/delete options. We should also offer an option to remove the analytic link right from the holdings table on the bib detail page. Currently, one needs to edit the child bib and remove the 773 to break the link. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30810] New: We should move sample_quotes out of en
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30810 Bug ID: 30810 Summary: We should move sample_quotes out of en Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The sample quotes are all quotes from American presidents.. not really things that everyone wants/needs to translate at translation time. We should move them out of /en/optional and into /localization/en-US. This would stop them from appearing in the translations and give other cultures the opportunity to add their own more relevant sample quotes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30810] We should move sample_quotes out of en
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30810 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30810] We should move sample_quotes out of en
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30810 --- Comment #1 from Martin Renvoize --- That, or reduce them to a very small list of samples that are very Koha specific and might be meaningful to a wider audience. Personal favourite, but inappropriate rangi: #thingsihavelearnt if there is a mad scheme a library somewhere will be doing it ... except madder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23659] Allow hold pickup location to default to item home branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23659] Allow hold pickup location to default to item home branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #135120|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 135204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135204&action=edit Bug 23659: Add DefaultHoldPickupLocation system preference On the staff side behaviour differs for default pickup location when placing a hold or placing an overridden hold. Additionally, the behaviour has changed betwee master and stables We should provide a consistent default, and allow the library to specify their choice Note this only affects staff client as there is only a single dropdown on OPAC and it is not tied to items To test: 1 - Apply patch 2 - Update database 3 - Find a record with items from various branches, and at least one with a different home/holding branch 4 - Ensure there is an item that requires override to hold, and AllowHoldPolicyOverride is enabled 4 - Attempt to place hold 5 - Confirm all dropdowns default to logged in library 6 - Set DefaultHoldPickupLocation to item's home branch 7 - Refresh and confirm all dropdowns match item home library except biblio level hold - still logged in library 8 - Set DefaultHoldPickupLocation to item's holding branch 9 - Refresh and confirm defaults 10 - Mark one of the items holding library as 'not a pickup location' in Admin->Libraries 11 - Refresh and confirm dropdown is now empty for that item Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30810] We should move sample_quotes out of en
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30810 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23659] Allow hold pickup location to default to item home branch for item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Allow hold pickup location |Allow hold pickup location |to default to item home |to default to item home |branch |branch for item-level holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30811] New: Allow hold pickup location to default to item home/holding branch for bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30811 Bug ID: 30811 Summary: Allow hold pickup location to default to item home/holding branch for bib-level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 23659 Bug 23659 adds the ability to make item-level holds default their pickup location to either the item homebranch or the item holdingbranch. It would be great to be able to do this for bib-level holds, too -- that would mean the hold does not truly have a pickup branch until an item is captured, at which point the pickup location gets set to wherever the captured item is. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 [Bug 23659] Allow hold pickup location to default to item home branch for item-level holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23659] Allow hold pickup location to default to item home branch for item-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||30811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30811 [Bug 30811] Allow hold pickup location to default to item home/holding branch for bib-level holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28950] serialsUpdate cron does not mark an issue late until the next issue is expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28950 --- Comment #1 from Nick Clemens --- Created attachment 135205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135205&action=edit Bug 28950: Mark serial late when past grace period This script had some oddities: - There was a LEFT JOIN to subscription, but no error printed if no subscription I changed this to a JOIN as there is a constraint, so this shoudl not happen - Publisheddate was checked after the SQL, moved into query - We checked for the next issue, and marked late only if that issue was already expected This overruled grace period, which should be the mnarker for a serial being late The grace period should be extended if you wish to wait for next issue - If no next published date, we reported an error on the planneddate - Script without confirm had no reporting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30812] New: subfield 9 deleted if no other data is available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30812 Bug ID: 30812 Summary: subfield 9 deleted if no other data is available Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: d...@plix.at QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl DNB exports the ISBN with dashes in 020$9, which we import via SRU while cataloguing. Therefore we added a subfield 9 to field 020. But when 020 contains no data except the dashed ISBN in $9, the value of $9 is deleted. I assume this is caused by some special cases needed to delete the koha_id of an authority (which is often stored in $9). To reproduce: * Go to a framwork, field 020, add a subfield 9, visible in tab 0, OPAC, Intranet and edito * Go to a book, edit it, enter something in 020$a and 020$9, save * The values are stored * Edit again, remove the value from 020$a, save * the value from 020$9 is gone, too I can maybe take a look tomorrow to try to figure out what's happening.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- Good spot finding 'SkipHoldTrapOnNotForLoanValue' David, to me that pref is slightly mid-described.. it feels like it should affect not just trapping at checking but also this HoldsQueue and pendingreserves too. For history, the notforloan handling was dropped from here by mistake originally in bug 3142 where it looks like we assumed the same logic was already taking place in the filter_by_for_hold. (Bad assumption.. we go from filtering on `!= 0` to filtering on `'<=' => 0` An initial 'fix' would be to restore the `!= 0` found in get_items_that_can_fill I believe.. though I'm not sure how the chaining would treat it.. I'm not entirely a fan of the current implementation in this patch.. your adding a query to fetch all items available for loans instead of just adding the 'notforloan' limit to the existing overall query. I'll have a read of the unit tests now to check they make sense, then I think we can golf this a little further. As for the 'SkipHoldTrapOnNotForLoanValue', that might be a nice thing to add support for whilst we're here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 --- Comment #13 from Lucas Gass --- Thank you Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 --- Comment #3 from Shi Yao Wang --- Created attachment 135206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135206&action=edit Bug 30802: Make numReturnedItemsToShow function properly Replaced the hardcoded 20 by the value of numReturnedItemsToShow to display the right number of items in check in. Test plan: 1- Make lots of checkouts, at least like 40 (I used the batchCheckouts feature) 2- Go to Circulation > Check in 3- Return 21 items The last 20 items returned will be displayed 4- Change numReturnedItemsToShow to 50 5- Return a couple more items Only the last 20 returned items are displayed 6- Change numReturnedItemsToShow to 10 7- Return a couple more items Only the last 10 returned items are displayed 8- Apply the patch 9- Change numReturnedItemsToShow back to 20 10- Do steps 1 to 7 again, but this time step 5 returns the right amount of items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Shi Yao Wang changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com ||, shi-yao.w...@inlibro.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 --- Comment #10 from Martin Renvoize --- Wow, the prefs do make this complicated! OK.. I spent some time working through this.. 'Trap' is very much about 'At Checkin' prompts.. in this case we're building lists of items to go and find.. so the preferences don't really come into play. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added Attachment #135081|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 135207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135207&action=edit Bug 30730: Holds to Pull should not list items with a notforloan status Remove items with a notforloan value other than 0 because items that are potentially holdable (with negative notforloan status) are not wanted in holds to pull. Test plan: 1- Have a bib with 2 items, both holdable. Give one of these items a notforloan status with a negative value (like Ordered in the testing docker data). 2- Place a title-level hold on your bib 3- Confirm your bib is showing on Holds to Pull as expected, prompting staff to pull the item that does not have a not for loan status (correct!) 4- Take the item that does not have a not for loan status and check it out to a different patron, make sure not to fill or cancel your hold 5- Reload Holds to Pull, see your title is still listed and now Koha is directing staff to the item with a notforloan status 6- Apply the patch 7- Reload Holds to Pull, see your title with a notforloan status is gone 8- Run `prove t/db_dependent/Koha/Holds.t` and all tests should pass Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added Attachment #135082|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 135208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135208&action=edit Bug 30730: Unit tests Added an entry in holds for an item with negative notforloan value to test if get_items_that_can_fill returns the right items. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 --- Comment #13 from Martin Renvoize --- Created attachment 135209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135209&action=edit Bug 30730: (follow-up) Simplify query This patch drops the 'fetch all non-loanable items' query used in the subsequent query as part of the 'not_in' and instead replaces it with a simple filter on 'notforloan => 0' Test plan Run the included unit tests before and apply applying the followup. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added Attachment #135207|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 135210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135210&action=edit Bug 30730: Holds to Pull should not list items with a notforloan status Remove items with a notforloan value other than 0 because items that are potentially holdable (with negative notforloan status) are not wanted in holds to pull. Test plan: 1- Have a bib with 2 items, both holdable. Give one of these items a notforloan status with a negative value (like Ordered in the testing docker data). 2- Place a title-level hold on your bib 3- Confirm your bib is showing on Holds to Pull as expected, prompting staff to pull the item that does not have a not for loan status (correct!) 4- Take the item that does not have a not for loan status and check it out to a different patron, make sure not to fill or cancel your hold 5- Reload Holds to Pull, see your title is still listed and now Koha is directing staff to the item with a notforloan status 6- Apply the patch 7- Reload Holds to Pull, see your title with a notforloan status is gone 8- Run `prove t/db_dependent/Koha/Holds.t` and all tests should pass Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added Attachment #135208|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 135211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135211&action=edit Bug 30730: Unit tests Added an entry in holds for an item with negative notforloan value to test if get_items_that_can_fill returns the right items. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added Attachment #135209|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 135212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135212&action=edit Bug 30730: (follow-up) Simplify query This patch drops the 'fetch all non-loanable items' query used in the subsequent query as part of the 'not_in' and instead replaces it with a simple filter on 'notforloan => 0' Test plan Run the included unit tests before and apply applying the followup. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize --- OK.. I'm happy this restores the previous functionality.. we have Unit tests and the code is simplified. QA scripts are happy Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added Keywords||regression, ||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30337] Holds to Pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30337 Martin Renvoize changed: What|Removed |Added Attachment #134972|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 135213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135213&action=edit Bug 30337: Holds to Pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended Holds to Pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended, and shows the wrong number of "patrons with holds" which presumably tells the librarian how many copies to pull from the shelves. Test Plan: 1) Create a record with one or more holdable items 2) Place two holds on the record 3) Note they show in the holds to pull report 4) Suspend the priority 2 hold 5) Note the report continues showing that 2 patrons have holds 6) Resume the priority 2 hold 7) Suspend the priority 1 hold 8) Note the hold disappears from the holds to pull report 9) Apply this patch 10) Restart all the things! 11) Reload the holds to pull report 12) The report should show one hold that needs an item pulled to fill it! Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30337] Holds to Pull ( pendingreserves.pl ) ignores holds if priority 1 hold is suspended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30337 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Works as expected and resolves a regression. QA script is happy. I'd love to have seen some work to move some of the queries here out of the controller and up into the Koha::Holds class (so we could also have unit tests added).. But as a fix, this does the job and is pragmatic so I can't really fail it ;P Passing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 --- Comment #13 from Elaine Bradtke --- (In reply to David Nind from comment #8) > Testing notes (koha-testing-docker): > > - When testing, I was getting some "flaky" behaviour with new news items not > displaying. > > - In the end, I emptied the additional_contents table (truncate > additional_contents;) and started again. > > - I think the issue was the difference between the date on my computer (we > are NZST - so date was 19 May 2022) compared with koha-testing-docker (UTC > time 18 May 2022): news wasn't displaying in the OPAC and staff interface as > the date of the news item was in the future (that is, the publication date > had not yet been reached). I have seen the same flaky behaviour. I'm eight hours behind the catalogue I maintain, so there are times when they're on a different date. Good to know this is a potential problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #3 from Nick Clemens ---
Right now, the error is not set in the issue object if not confirm:
$auto_renew->auto_renew_error($error)->store if $confirm;
I suspect we need:
$auto_renew->auto_renew_error($error)
$auto_renew->store if $confirm;
Additionally:
173 if ($confirm){
174 my $date_due = AddRenewal( $auto_renew->borrowernumber,
$auto_renew->itemnumber, $auto_renew->branchcode, undef, undef, undef, 0 );
175 $auto_renew->auto_renew_error(undef)->store;
176 }
Otherwise the messages I get don't have the correct info/status
There may be other instances like this to check as well
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- The digests will receive an issue marked as 'auto_too_soon' - there should not be a case of an issue marked for auto-renewal returning 'too_soon' without auto The default notice should be updated to handle these - if you are getting a digest I think you do want to see to: Book A renewed Book B not renewed (too soon) Otherwise we should nex ton those in the loop Beyond that - if all errors are too_soon we shouldn't trigger a notice, the updated flag should not be sent and the digest should be skipped. Can you confirm if you are seeing auto_too_soon on other notices, or notices with all auto_too_soon? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 --- Comment #18 from David Nind --- Thanks Martin, apologies for confusing things -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #8 from David Nind --- (In reply to Shi Yao Wang from comment #7) > (In reply to David Nind from comment #5) > > I love consistency for terminology, so this is great! > > > > I have two suggestions to move the "Show/Don't show" options to the start of > > the system preference text, rather than at the end, to be as consistent as > > possible with how it is used elsewhere: > > > > - noItemTypeImages: > > . Updated text: Show itemtype icons in the staff interface: Show/Don't > > show > > . Change to: Show/Don't show itemtype icons in the staff interface. > > > > - OpacNoItemTypeImages: > > . Updated text: Show itemtype icons in the OPAC: Show/Don't show > > . Change to: Show/Don't show itemtype icons in the OPAC. > > > > I'll also add to the terminology list: > > https://wiki.koha-community.org/wiki/Terminology > > Added the suggested changes in noItemTypeImages and OpacNoItemTypeImages. Hi Shi Yao. Thanks for updating. However, I think I may have confused things! I meant having the dropdown list with the choice at the front, rather than at the end of the sentence - eliminating the "double" show. For example: - For OpacNoItemTypeImages it should read as: [Show/Don't show] itemtype icons in the OPAC. - Rather than: Show/Don't show itemtype icons in the OPAC: [Show/Don't show] Hope that makes sense! David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28556] Make guarantor information available in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Shi Yao Wang changed: What|Removed |Added Attachment #130340|0 |1 is obsolete|| --- Comment #4 from Shi Yao Wang --- Created attachment 135214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135214&action=edit Bug 28556: Guarantor's information is available in notice This patch adds the guarantor's information when sending overdue notice. To test: 1. Make sure that there is an overdue letter. a) Go in Tools/Notices & Slips. b) Search for the code "ODUE" and note the "Name" of the letter. c) Click on "Edit". d) Click on "Email" and make sure that there is text inside the box. e) Add the following code in the textbox: C/O <> <> f) Click on "Save". 2. Set up the status trigger. a) Go in Tools/Overdue notice/status triggers. b) In "First" tab, put a number of days in the "Delay" column (ex: 1). c) In the column "Letter", put the "Name" of the letter of step 1a) . d) Check "Email". e) Click "Save". 3. Create a patron with a guarantor. a) Go in Administration/Patron categories. b) Create a child category AND a adult category. c) Create an adult patron. d) Create a child patron. e) Go in the child patron's page and click "Edit". f) In the "Patron guarantor" section, click add guarantor. g) Search for your adult patron and click "Select". h) Select a relationship for the guarantor (ex: Mother). i) Click on "Save". 4. Borrow an overdue item. a) Click on the arrow next to "Search button" (Top of the screen). b) Click on "Items search". c) Click on search. d) Copy a barcode in the list. e) Search for your child patron. f) Go in his page and click on "Checkout". g) Paste the barcode copied at step 4d) . h) Click on "Checkout settings". i) Put a date in the past greater than the number of days that you put on step 2b). j) Click on "Check out". k) Click on "Yes" Notice tht there is a message saying that Patron has ITEMS OVERDUE. 5. Test the patch. a) In the terminal, run ./misc/cronjobs/overdue_notices.pl b) Return in your child patron's page. c) Click on "Notice" and you should see a letter. d) Click on the letter to see the content. c) Notice that you can't see the guarantor's informations (Adult patron). d) Apply the patch. e) Repeat steps a) to d) f) Notice that you can see the guarantor's informations. This also works if you decide to add a non-patron guarantor instead of a patron guarantor at step 3. NOTE: If you want to delete the letters, go in your database and run: - delete from message_queue; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28556] Make guarantor information available in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||shi-yao.w...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Shi Yao Wang changed: What|Removed |Added Attachment #135203|0 |1 is obsolete|| --- Comment #9 from Shi Yao Wang --- Created attachment 135215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135215&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Nick Clemens changed: What|Removed |Added Attachment #135071|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 135216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135216&action=edit Bug 30789: Improve performance of AddBiblio AddBiblio calls TransformMarcRecordToKoha. We are only interested in getting biblio and biblioitems info, so we can pass 'no_items' to save some field lookups Benchmarking saw a ~75% increase in the performance of this call To test: 1 - Stage and import some records 2 - Confirm it works the same before and after patch 3 - Add a biblio via cataloguing, confirm it works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] New: Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Bug ID: 30813 Summary: Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org While testing bug 30789 it was found that passing the already retrieved marc subfield structure into TransformMarckToKohaOneField increased performance by ~20% This seemed odd as the routine is already retrieving from cache unsafe Rather than pass around this shared variable, it seems to make sense to allow TransformMarcToKoha to take a list of fields to process, rather than have a seperate routine that must be called -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Nick Clemens changed: What|Removed |Added Depends on||30789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 [Bug 30789] Improve performance of AddBiblio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Nick Clemens changed: What|Removed |Added Blocks||30813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 David Nind changed: What|Removed |Added Attachment #135215|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 135217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135217&action=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #11 from David Nind --- Thanks Shi Yao for updating! I've added my sign off as well, to show the QA I've checked the change0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 --- Comment #12 from Shi Yao Wang --- No problem David. Thanks for the sign offs! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29860] Useless warnings in regressions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29860] Useless warnings in regressions.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 David Nind changed: What|Removed |Added Attachment #129348|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 135218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135218&action=edit Bug 29860: Remove item type-related warnings To test: 1. Run: $ kshell k$ prove t/db_dependent/selenium/regressions.t => FAIL: You see several item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more item type warnings 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 David Nind changed: What|Removed |Added Attachment #135192|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 135219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135219&action=edit Bug 30781: Add unit test for substitute with undefined value Add unit test that generates warn. This may be usefull as no regression test. Run prove t/db_dependent/Letters.t You see warn : t/db_dependent/Letters.t .. 1/84 Use of uninitialized value $val in substitution iterator at /kohadevbox/koha/C4/Letters.pm line 607. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 David Nind changed: What|Removed |Added Attachment #135193|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 135220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135220&action=edit Bug 30781: Fix warning in GetPreparedLetter Test by running : prove t/db_dependent/Letters.t Check you dont see warning : Use of uninitialized value $val in substitution iterator Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Author (meeting/conference) when upgrading an authority through Z3950
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 Katrin Fischer changed: What|Removed |Added Summary|UNIMARC 210a is reported to |UNIMARC 210a is reported to |Autor (meeting/conference) |Author (meeting/conference) |when upgrading an authority |when upgrading an authority |through Z3950 |through Z3950 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #6 from David Cook --- (In reply to Nick Clemens from comment #5) > The digests will receive an issue marked as 'auto_too_soon' - there should > not be a case of an issue marked for auto-renewal returning 'too_soon' > without auto > > The default notice should be updated to handle these - if you are getting a > digest I think you do want to see to: > Book A renewed > Book B not renewed (too soon) > > > Otherwise we should nex ton those in the loop > > Beyond that - if all errors are too_soon we shouldn't trigger a notice, the > updated flag should not be sent and the digest should be skipped. Can you > confirm if you are seeing auto_too_soon on other notices, or notices with > all auto_too_soon? That's what I'm confused about. Doesn't the following mean that auto_too_soon errors aren't even being counted? https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29381&attachment=127947 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #4 from David Cook --- (In reply to Joonas Kylmälä from comment #2) > In koha-suomi fork we use start-stop-daemon to send the HUP signal, that's > probably the preferable way since koha-plack uses start-stop-daemon already > to send the process kill signal. I'm only seeing "start-stop-daemon" for koha-plack --stop for some reason... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21366] add plack reload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 --- Comment #5 from David Cook --- (In reply to Fridolin Somers from comment #1) > To trigger this reload, juste run : > > /bin/kill -HUP $MASTER_PID > > MASTER_PID beeing the pid of the starman master process, can be fetched in > pid file. > > Source : > https://metacpan.org/pod/distribution/Starman/script/starman#SIGNALS I'd forgotten about this comment, but I just used the following today in prod: kill -SIGHUP $(cat /var/run/koha//plack.pid) I wanted to enable plugins and then reload after installing the plugin, and it was so elegant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
