[Koha-bugs] [Bug 30730] Holds to Pull should not list items with a notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730 --- Comment #19 from Martin Renvoize --- Not at all David, your insight is always really helpful. It certainly got me digging into QA for this, really glad to have you on the team. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #133 from Owen Leonard --- This looks like it's working pretty well in the staff interface. Is there a plan to make the contents of bundles visible in the OPAC? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Shi Yao Wang changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Shi Yao Wang --- (In reply to Owen Leonard from comment #4) > With numReturnedItemsToShow set to 50 I seem to be limited to seeing 36 > checkins. I tested again and set numReturnedItemsToShow to 50 and checked in 51 items and it shows 50 checkins for me. Can someone else confirm the behaviour? Putting this back to Needs Signoff for others to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #13 from Owen Leonard ---
I don't understand what's going on here, which may just be me:
if ( !$patron->has_permission({ borrowers => 'edit_borrowers' }) ) {
print $input->redirect("/cgi-bin/koha/mainpage.pl");
}
But when I change a patron's password when logged in as a superlibrarian I'm
redirected to the main page rather than back to their account.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 David Nind changed: What|Removed |Added Attachment #135230|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 135252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135252=edit Bug 29333: Fix encoding of imported UNIMARC authorities MARC::Record and MARC::File::* modules sometimes use the position 09 of the leader to detect encoding. A blank character means 'MARC-8' while an 'a' means 'UTF-8'. In a UNIMARC authority this position is used to store the authority type (see https://www.transition-bibliographique.fr/wp-content/uploads/2021/02/AIntroLabel-2004.pdf [FR]). In this case, 'a' means 'Personal Name'. The result is that the import will succeed for a Personal Name authority, but it will fail for all other authority types. Steps to reproduce: 0. Be sure to have a Koha UNIMARC instance. 1. Download the MARCXML for "Honoré de Balzac" curl -o balzac.marcxml https://www.idref.fr/02670305X.xml 2. Verify that it's encoded in UTF-8 file balzac.marcxml (should output "balzac.marcxml: XML 1.0 document, UTF-8 Unicode text") 3. Go to Tools » Stage MARC for import and import balzac.marcxml with the following settings: Record type: Authority Character encoding: UTF-8 Format: MARCXML Do not touch the other settings 4. Once imported, go to the staged MARC management tool and find your batch. Click on the authority title "Balzac Honoré de 1799-1850" to show the MARC inside a modal window. There should be no encoding issue. 5. Write down the imported record id (the number in column '#') and go to the MARC authority editor. Replace all URL parameters by 'breedingid=THE_ID_YOU_WROTE_DOWN' The URL should look like this: /cgi-bin/koha/authorities/authorities.pl?breedingid=198 You should see no encoding issues. Do not save the record. 6. Import the batch into the catalog. Verify that the authority record has no encoding issue. 7. Now download the MARCXML for "Athènes (Grèce)" curl -o athènes.marcxml https://www.idref.fr/027290530.xml 8. Repeat steps 2 to 6 using athènes.marcxml file. At steps 4 and 5 you should see encoding issues and that the position 9 of the leader was rewritten from 'c' to 'a'. Strangely, importing this batch fix the encoding issue, but we still lose the information in position 09 of the leader This patch makes use of the MARCXML representation of the record instead of the ISO2709 representation, because, unlike MARC::Record::new_from_usmarc, MARC::Record::new_from_xml allows us to pass directly the encoding and the format, which prevents data to be double encoded when position 09 of the leader is different that 'a' Test plan: - Follow the "steps to reproduce" above and verify that you have no encoding issues. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #4) > I've not looked in depth yet.. but I'm wondering if we aught to start > adopting a pattern of generally accepting Object or Identifier for passed > params. If one already has the object it's a no brainer to pass it through > and save a lookup. In this case I could see the potential of having to fetch > a patron to pass in then not actually need to use it, depending on the > pref.. which is also wasteful? > > Thoughts? In this particular case, what bothered me was that every place the method was called, the object was already there and it got unblessed just because (it was obviously a transition step when moving GetMember and friends to Koha::Patrons to avoid friction). I'd say in this particular case either is fine. We always have the object in context anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #4 from Martin Renvoize --- I've not looked in depth yet.. but I'm wondering if we aught to start adopting a pattern of generally accepting Object or Identifier for passed params. If one already has the object it's a no brainer to pass it through and save a lookup. In this case I could see the potential of having to fetch a patron to pass in then not actually need to use it, depending on the pref.. which is also wasteful? Thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30827] New: Autobarcode discards leading zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30827 Bug ID: 30827 Summary: Autobarcode discards leading zero Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl If you set autobarcode to "generated in the form 1,2,3," Koha will find the largest numeric barcode in your system and add 1. However, if your largest numeric barcode has leading zeros, those will not be maintained in your new item. So if the current highest barcode is "09000," the next barcode generated will be "9001." Apparently we fixed this on bug 5681 way back in 2011, but it has since regressed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- With numReturnedItemsToShow set to 50 I seem to be limited to seeing 36 checkins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 --- Comment #4 from Martin Renvoize --- Created attachment 135251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135251=edit Bug 30822: Make BatchCommitRecords update the index in one request When committing staged marc imports to the catalogue we will often be importing a batch of records. We don't want to send one index request per biblio affected, we want to index them all after the records have been modified otherwise we will end up with multiple tasks per record (when items are also affected). Test plan: 1) Use the stage marc record tool to stage and commit a set of records and confirm the behaviour remains correct. 2) If using Elastic, check that only one indexing job is queued to take place resulting from the committed import. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 --- Comment #11 from Tomás Cohen Arazi --- Bug 30825 - Get rid of GetReservesControlBranch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Depends on||30825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 [Bug 30825] Get rid of GetReservesControlBranch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 135250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135250=edit Bug 30825: Remove GetReservesControlBranch in favour of Koha::Item->holds_control_library This patch removes the GetReservesControlBranch method, and replaces its uses with the newly introduced method. To test: 1. Apply this patch 2. Verify that placing holds from the OPAC works => SUCCESS: Things work as expected 3. Run: $ kshell k$ prove t/db_dependent/Reserves* \ t/db_dependent/Hold* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 135249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135249=edit Bug 30825: Add Koha::Item->holds_control_library This simple method takes care of calculating the control branch for an item and a patron, depending on a syspref. It targets replacing C4::Reserves::GetReservesControlBranch To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 135248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135248=edit Bug 30825: Add unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30826] New: Update ModBiblio to return biblio info
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30826 Bug ID: 30826 Summary: Update ModBiblio to return biblio info Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org ModBiblio updates the record, and fetches biblioitemnumber during its work In other routines we can save time if we have this biblioitemnumber, see bug 30824 We should consider updating the return values here to pass back data that can be reused -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 --- Comment #1 from Nick Clemens --- Created attachment 135247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135247=edit Bug 30824: Improve performance of BatchCommitItems This makes two simple changes: - Limit TransformMarcToKoha to the fields we need - Pass forward the biblioitemnumber when adding items to a new biblionumber Profiling with NYTProf I saved ~8-9 seconds importing around 400 bibs/1000 items Reducing calls in item store to use a passed biblionumber was the largest gain. To test: 1 - Import some records and items 2 - Verify values etc., revert 3 - Apply patch 4 - Import again 5 - Verify values etc. same as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Nick Clemens changed: What|Removed |Added Blocks||30824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 [Bug 30824] Improve performance of BatchCommitItems -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 Nick Clemens changed: What|Removed |Added Depends on||30813 Status|NEW |Needs Signoff Patch complexity|--- |Small patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30825] New: Get rid of GetReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Bug ID: 30825 Summary: Get rid of GetReservesControlBranch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The method currently requires unblessed objects only to access one attribute on them... and it can certainly be moved to Koha::* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] New: Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 Bug ID: 30824 Summary: Improve performance of BatchCommitItems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823 [Bug 30823] Recalls should use 'FILL' in action logs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_22_05_candidate Depends on||19532 --- Comment #1 from Tomás Cohen Arazi --- I think this should be fixed before the release, if agreed. This way we won't need to deal with an atomicupdate for action logs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30823] New: Recalls should use 'FILL' in action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823 Bug ID: 30823 Summary: Recalls should use 'FILL' in action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Recalls are too close to holds but the action_logs action for filling a 'recall' has been coded as FULFILL. The same thing is coded FILL for holds, they should be named the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 Martin Renvoize changed: What|Removed |Added Blocks||29440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 [Bug 29440] Refactor/clean up bulkmarcimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What|Removed |Added Depends on||30822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 [Bug 30822] BatchCommit does not deal with indexation correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 --- Comment #3 from Martin Renvoize --- What we really need is task dependencies... then the Authority linking can be a task that's dependent on the rebuild having been completed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 --- Comment #2 from Martin Renvoize --- (In reply to Katrin Fischer from comment #1) > Is there a reason indexing could not take place during the import and would > have to be pushed after the task is completed? Just wondering if this would > not slow down things for big imports like you would do with bulkmarcimport. See discussion on bug 30465 for background on this exact issue... As far as I can tell there's already a bug in the existing implementation here anyway.. as I just mentioned in bug 29440 if `BiblioAddsAuthorities` is enabled we're using the search indexes to find authority matches as part of the AddBiblio action.. if we're calling a whole bunch of AddBiblio's in a row in a loop then the index will likely be out of date for at least some of these searches and as such authority matches won't work as expected.. we have a race condition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 --- Comment #1 from Katrin Fischer --- Is there a reason indexing could not take place during the import and would have to be pushed after the task is completed? Just wondering if this would not slow down things for big imports like you would do with bulkmarcimport. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Katrin Fischer changed: What|Removed |Added Attachment #133477|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 135246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135246=edit Bug 24239: Let the ILL module set ad hoc hard due dates The Swedish Libris ILL backend lets librarians store a specific due date when an ILL loan is received. This patch set adds a new date_due column to the illrequets table that can be used by the different backends to store a due date. If an illrequest has the date due set, it will be used when the item is checked out instead of the calculation using the circulation conditions. To test: - Apply the patch and make sure the atomic database update is run - Use the FreeForm backend to add one ILL request. Take note of the illrequest_id of the request you created. We refer to this as "x" below. - Connect a biblio (with biblionumber y), that has an item with a barcode, to the ILL request directly in the database: UPDATE illrequests SET biblio_id = y WHERE illrequest_id = x; - Next we set the due date, this would normally be done by or from the backend. UPDATE illrequests SET date_due = "2023-01-01" WHERE illrequest_id = x; - Go to circulation and issue the barcode of the item to the patron associated with the FreeForm ILL request. Verify that the loan gets a due date of 2023-01-01. - Ideally: return the item and issue it again through SIP2 and SCO, and verify that the due date is still 2023-01-01. - Verify that there are no regressions, so that regular calculation of due dates still work. - prove t/db_dependent/Circulation.t (Patch description, test plan and partial code credits to Magnus Enger) Signed-off-by: Katrin Fischer (Patch description and test plan rewritten to reflect changes in development) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Katrin Fischer changed: What|Removed |Added Attachment #133476|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 135245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135245=edit Bug 24239: Unit tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Katrin Fischer changed: What|Removed |Added Attachment #133475|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 135244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135244=edit Bug 24239: Add column illrequests.date_due Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #38 from Martin Renvoize --- Looking good so far.. a couple of comments We have a fairly standard 'skip_index' name for the search engine index skip param.. we should stick to that here too (I bet your patch pre-dates that, but it shouldn't be too onerous to update for consistency) However, there's a more challenging thing to resolve. If 'BiblioAddsAuthorities' is enabled the index skip is going to cause issues as the linker relies of updated indexes to do it's job... we possibly need to move where the BiblioAddsAuthories code runs for such cases to run at the end after a first run of indexing has taken place and then run a second index run to catch the link changes it makes? Conundrum. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30822 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29440 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 Martin Renvoize changed: What|Removed |Added Depends on||30822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 [Bug 30822] BatchCommit does not deal with indexation correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Martin Renvoize changed: What|Removed |Added Blocks||30822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 [Bug 30822] BatchCommit does not deal with indexation correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30822] New: BatchCommit does not deal with indexation correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822 Bug ID: 30822 Summary: BatchCommit does not deal with indexation correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: dc...@prosentient.com.au, fridolin.som...@biblibre.com, jonathan.druart+k...@gmail.com, julian.maur...@biblibre.com, k...@bywatersolutions.com, martin.renvo...@ptfs-europe.com, tomasco...@gmail.com Depends on: 27344 Blocks: 27341 AddBiblio must implement skip_index and we should update the search engine's index after all the biblio records have been imported. This also applies for bulkmarcimport. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 [Bug 27341] Performance 21.05 - Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #10 from Nick Clemens --- Created attachment 135243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135243=edit Bug 30813: (follow-up) ImportBatch updates Missed these in the original commits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 --- Comment #21 from Katrin Fischer --- I believe the test plan requires updating! * As we now have a illrequests.date_due, we should probably update that in step 4. * There is no ILLUseExactDueDate system preference anymore. I am rewriting it accordingly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- This works great and serves as another nice cleanup. QA script is happy, all unit tests for biblios and items are passing great. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Martin Renvoize changed: What|Removed |Added Attachment #135235|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 135242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135242=edit Bug 30813: Remove Koha::MetadataRecord::getKohaField This was essentially a wrapper around TransformKohaToMarcOneField After changing and updating, it seems easier not to create the intermediary object and to just transform the data Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Martin Renvoize changed: What|Removed |Added Attachment #135234|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 135241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135241=edit Bug 30813: Remove TransformMarcToKohaOneField To test: 1 - prove -v t/db_dependent/Biblio/TransformMarcToKoha.t t/db_dependent/Breeding.t 2 - Test Z3950 search in advanced catalog editor Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Martin Renvoize changed: What|Removed |Added Attachment #135233|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 135240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135240=edit Bug 30813: Adjust TransformMarcToKoha to take kohafields parameter This adjusts the routine to accept an arrayref of koha fields to process To test: prove -v t/db_dependent/Biblio/TransformMarcToKoha.t t/Biblio.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Martin Renvoize changed: What|Removed |Added Attachment #135232|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 135239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135239=edit Bug 30813: Update TransformMarcToKoha to accept a hashref This patch updates all the calls to pass a hasref rather than an array It also removes the no longer used framework parameter To test: prove -v t/Biblio.t t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- Trivial and clear code improvement.. we don't handle item table rows as part of AddBiblio so there's really no reason to process them. Unit tests continue to all pass as expected, no regressions found and the QA script is happy. I can confirm the performance improvement too alongside the cleaner feeling code. Think I'm going to go straight to QA for this one. Passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30789] Improve performance of AddBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789 Martin Renvoize changed: What|Removed |Added Attachment #135216|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 135238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135238=edit Bug 30789: Improve performance of AddBiblio AddBiblio calls TransformMarcRecordToKoha. We are only interested in getting biblio and biblioitems info, so we can pass 'no_items' to save some field lookups Benchmarking saw a ~75% increase in the performance of this call To test: 1 - Stage and import some records 2 - Confirm it works the same before and after patch 3 - Add a biblio via cataloguing, confirm it works Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30818] REST API: Why does a wrong column name still cause a general 500 while validating exhaustively?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30818 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #0) > How is that possible? I stumble over all kinds of validation, extracting and > merging parameters etc. etc. As I mentioned on my earlier answer, we shouldn't validate any arbitrary query contains valid attributes. It is more sustainable to just catch the DBIx::Class exception and act better. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30818] REST API: Why does a wrong column name still cause a general 500 while validating exhaustively?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30818
--- Comment #3 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #2)
> The REST API is a great thing. But I must admit that going thru all these
> modules, plugins, etc. the exact meaning of a lot of subroutines is unclear
> and the comments are sparse. Hoping that not only Tomas has a global
> detailed view of what is going on here.. ;)
There are two main things that need to be considered when thinking about the
API tooling:
1. We need to map attributes from the API to the actual DB names. This happens
when creating/updating resources, as well as querying. The latter is the most
complex in the code (i.e. the recursive _parse_dbic_query)
2. When we are using q= in conjunction with x-koha-embed, we need to
prefetch/join the right tables. This is mainly handled by _parse_prefetch.
About (1). In the original implementations, the controllers had two methods:
to_model and to_api. So the mappings were entirely handled there. The problem
with that is the fact we wanted to do more complex things like embedding
related objects, so the API representation of an object needed to be handled on
the object itself. There's some redundancy, most probably in the
attributes_from_api and friends stuff on the Koha::Object(s) method. That could
be polished. But the main thing is it needs to be handled at that level and
reused as much as possible. There are not many more things to optimize there
IMHO.
About (2). This is the difficult part. Embeds can happen at an arbitrary depth.
Like in 'x-koha-embed: biblio.items.checkouts.patron'. As the 'how I should be
rendered on the API' question is answered at the Koha::Object level, we build a
data structure ('embed' param for to_api) that contains a (probably
enhanceable) data structure representing the 'rest of the tree' that each
object needs to embed. Along with this data structure, there's the need to
build the prefetches/joins so we optimize things. Embedding can happen on real
'relations' (thus actual prefetches take place) or just on 'methods output' in
which case no prefetch takes place. This is handled by _parse_prefetch, which
is also recursive.
Regarding to_api(), we are adding new parameters that are passed through to
related objects like 'public'. So each object, needs to know how it should
render on an unprivileged context.
So, TL;DR
Our helper methods take care of handling what the OpenAPI plugin generates out
of the requests, and convert it into:
- Queries, objects, etc with mapped attribute names
- Prefetches are appended to resultsets with embeds
- Generate data structure to be passed to to_api()
And most of the magic takes place in Koha::Object->to_api(). The most complex
bit is querying.
Regarding this bug, I believe the solution is to catch the
DBIx::Class::Exception in the objects.search helper, and return a 400 with a
meaningful message.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30821] New: unable to install plugin. throws error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30821 Bug ID: 30821 Summary: unable to install plugin. throws error 500 Change sponsored?: --- Product: Koha Version: 21.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: vnsaw...@drtc.isibang.ac.in QA Contact: testo...@bugs.koha-community.org Created attachment 135237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135237=edit plugin not working in koha 21.11 After upgrading to koha 21.11 from koha 17, the coverflow plugin is not getting installed and other plugins are getting installed but not able to configure. It throws error 500. All those plugins(coverflow, asklibrarian etc) were successfully running in koha 17. I have attached the screenshots of the same. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29668] Add API route to create a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29668 --- Comment #2 from Paul Derscheid --- This isn't compatible with the current master branch because of some changes in the api directory structure, but I think you already know. Some merge conflicts have to be resolved. There is the new route acquisitions/baskets/managers which probably wasn't there yet when this patch was written. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Nick Clemens changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #4 from Nick Clemens --- Created attachment 135235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135235=edit Bug 30813: Remove Koha::MetadataRecord::getKohaField This was essentially a wrapper around TransformKohaToMarcOneField After changing and updating, it seems easier not to create the intermediary object and to just transform the data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #3 from Nick Clemens --- Created attachment 135234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135234=edit Bug 30813: Remove TransformMarcToKohaOneField To test: 1 - prove -v t/db_dependent/Biblio/TransformMarcToKoha.t t/db_dependent/Breeding.t 2 - Test Z3950 search in advanced catalog editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #2 from Nick Clemens --- Created attachment 135233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135233=edit Bug 30813: Adjust TransformMarcToKoha to take kohafields parameter This adjusts the routine to accept an arrayref of koha fields to process To test: prove -v t/db_dependent/Biblio/TransformMarcToKoha.t t/Biblio.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #1 from Nick Clemens --- Created attachment 135232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135232=edit Bug 30813: Update TransformMarcToKoha to accept a hashref This patch updates all the calls to pass a hasref rather than an array It also removes the no longer used framework parameter To test: prove -v t/Biblio.t t/db_dependent/Biblio/TransformMarcToKoha.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #23 from Martin Renvoize --- (In reply to Jonathan Druart from comment #22) > The dependency is reversed IMO. I agree with the current way around... we already expose object methods to notices.. this patch doesn't change or expose anything worse so blocking this one with that one would be silly in my opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30818] REST API: Why does a wrong column name still cause a general 500 while validating exhaustively?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30818 --- Comment #2 from Marcel de Rooy --- Just for my reference. Going thru code $filtered_params = $result_set->attributes_from_api($filtered_params); NB my $columns_info = $self->_result->result_source->columns_info; $filtered_params = $c->build_query_params( $filtered_params, $reserved_params ); merge_q_params _parse_dbic_query Hmm Recursive _from_api_param The extracted_reserved_params seems a bit suboptimal. The attributes_from_api should be able to remove bad columns? The REST API is a great thing. But I must admit that going thru all these modules, plugins, etc. the exact meaning of a lot of subroutines is unclear and the comments are sparse. Hoping that not only Tomas has a global detailed view of what is going on here.. ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30817] Make build_authorities_query takes QueryAutoTruncate system preference into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30817 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30817] Make build_authorities_query takes QueryAutoTruncate system preference into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30817 --- Comment #1 from Alex Arnaud --- Created attachment 135231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135231=edit Bug 30817: make build_authorities_query takes QueryAutoTruncate system preference into account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30820] New: Standardize sample patron category for ILL libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30820 Bug ID: 30820 Summary: Standardize sample patron category for ILL libraries Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de At the moment, everytime you want to test ILL you have to either add a patron category ILLIBS or you have to update the koha-conf.xml to use the existing IL category type from the sample data. As we have CPL as a sample branch in the koha-conf.xml, I think it would make sense to also change the patron category to match our sample data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30819 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30819] Not able to adjust size of barcode numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10762 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #13 from Katrin Fischer ---
1) QA test tools:
FAIL installer/data/mysql/atomicupdate/update-BZ_10762.pl
FAIL file permissions
File must have the exec flag
2) See comment#11, it looks like the original value was 0.01:
+scale_height=> 0.02,
-my $barcode_y_scale_factor = 0.01 * $self->{'height'}; # this
scales the barcode height to 10% of the label height
3) Defaults
Just a question, maybe someone else can answer that one too:
The patch adds the 2 new database columns with defaults 0.02 and 0.8 in the
database and also sets the defaults in new.
Should we do both or would one option suffice?
4) Changes to kohastructure.sql are missing
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed Summary|Not able to adjust size of |Make it possible to adjust |barcode numbers |the barcode height and ||width on labels Severity|normal |enhancement --- Comment #12 from Katrin Fischer --- I believe this actually fixes something different than originally reported. This makes it possible to pick the size of the barcode, the original was a bug saying that the font size was not taken into account for the barcode number shown below the barcode. I've filed a new bug and reset this as enh, because it's a nice new feature now. Bug 30819 - Not able to adjust size of barcode numbers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30819] New: Not able to adjust size of barcode numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30819 Bug ID: 30819 Summary: Not able to adjust size of barcode numbers Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Moved from the original bug 10762: (In reply to Jesse Maseto from comment #0) > I created a new layout (section 2.5.3.1 in the manual) that just shows the > barcode, and I set the font size big. First I did 14, then 32 just to make > sure my eyes weren't deceiving me. The numbers below the barcode didn't > change size! > > It seems like the font settings only affect the bibliographic data. What I > want to change is the barcode number itself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 --- Comment #6 from Julian Maurice --- (In reply to Fridolin Somers from comment #4) > This should be only for authorities no ? > showmarc.pl is also used to display biblio records Fixed in the latest patch (In reply to David Nind from comment #3) > Hi Julian. > > Thanks for the great test plan! > > Just to check that this patch should fix both: > - the encoding issues during the staging and import stages, and > - the c being changed to an a on import. > > For me, after applying the patch and working through the test plan for > athènes.marcxml, the c in the leader is still changed to an a after import - > it remains as a c in steps 4 and 5. The encoding issues are fixed. (UNIMARC > instance, have cleared caches (Koha and browser), restarted, etc). This patch is only about fixing encoding issues. The 'c' being changed to an 'a' can be addressed in a followup bug I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #13 from David Nind --- Just retested - everything passes now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Julian Maurice changed: What|Removed |Added Attachment #126983|0 |1 is obsolete|| --- Comment #5 from Julian Maurice --- Created attachment 135230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135230=edit Bug 29333: Fix encoding of imported UNIMARC authorities MARC::Record and MARC::File::* modules sometimes use the position 09 of the leader to detect encoding. A blank character means 'MARC-8' while an 'a' means 'UTF-8'. In a UNIMARC authority this position is used to store the authority type (see https://www.transition-bibliographique.fr/wp-content/uploads/2021/02/AIntroLabel-2004.pdf [FR]). In this case, 'a' means 'Personal Name'. The result is that the import will succeed for a Personal Name authority, but it will fail for all other authority types. Steps to reproduce: 0. Be sure to have a Koha UNIMARC instance. 1. Download the MARCXML for "Honoré de Balzac" curl -o balzac.marcxml https://www.idref.fr/02670305X.xml 2. Verify that it's encoded in UTF-8 file balzac.marcxml (should output "balzac.marcxml: XML 1.0 document, UTF-8 Unicode text") 3. Go to Tools » Stage MARC for import and import balzac.marcxml with the following settings: Record type: Authority Character encoding: UTF-8 Format: MARCXML Do not touch the other settings 4. Once imported, go to the staged MARC management tool and find your batch. Click on the authority title "Balzac Honoré de 1799-1850" to show the MARC inside a modal window. There should be no encoding issue. 5. Write down the imported record id (the number in column '#') and go to the MARC authority editor. Replace all URL parameters by 'breedingid=THE_ID_YOU_WROTE_DOWN' The URL should look like this: /cgi-bin/koha/authorities/authorities.pl?breedingid=198 You should see no encoding issues. Do not save the record. 6. Import the batch into the catalog. Verify that the authority record has no encoding issue. 7. Now download the MARCXML for "Athènes (Grèce)" curl -o athènes.marcxml https://www.idref.fr/027290530.xml 8. Repeat steps 2 to 6 using athènes.marcxml file. At steps 4 and 5 you should see encoding issues and that the position 9 of the leader was rewritten from 'c' to 'a'. Strangely, importing this batch fix the encoding issue, but we still lose the information in position 09 of the leader This patch makes use of the MARCXML representation of the record instead of the ISO2709 representation, because, unlike MARC::Record::new_from_usmarc, MARC::Record::new_from_xml allows us to pass directly the encoding and the format, which prevents data to be double encoded when position 09 of the leader is different that 'a' Test plan: - Follow the "steps to reproduce" above and verify that you have no encoding issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30818] REST API: Why does a wrong column name still cause a general 500 while validating exhaustively?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30818 --- Comment #1 from Marcel de Rooy --- [2022/05/20 09:10:31] [ERROR] GET /api/v1/biblios: unhandled exception (DBIx::Class::Exception)<> Koha::REST::Plugin::Exceptions::__ANON__ /usr/share/koha/Koha/REST/Plugin/Exceptions.pm (73) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #12 from Katrin Fischer --- Hi David, thx for testing! I think we overlapped, could you have a go with the follow-up patch? It should fix exactly that problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- I believe the new is_notforloan is not complete as is: * You check for the notforloan status in the item * You check for the notforloan of the itemtype of the item But: I think you need to use effective_itemtype here to catch itemtype on record level as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29668] Add API route to create a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29668 Paul Derscheid changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||paul.dersch...@lmscloud.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30818] REST API: Why does a wrong column name still cause a general 500 while validating exhaustively?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30818 Marcel de Rooy changed: What|Removed |Added CC||julian.maur...@biblibre.com ||, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30818] New: REST API: Why does a wrong column name still cause a general 500 while validating exhaustively?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30818
Bug ID: 30818
Summary: REST API: Why does a wrong column name still cause a
general 500 while validating exhaustively?
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: m.de.r...@rijksmuseum.nl
CC: tomasco...@gmail.com
This might just be a dumb question:
While testing 30790 and tweaking the test a bit, I found this:
my $api_filter = encode_json({'isbn' => '123', 'xx1' => 'a2' });
$t->get_ok("//$userid:$password@/api/v1/biblios?q=$api_filter");
I am sending xx1 to Koha/REST/V1/Biblios, sub list.
To my surprise, this doesnt trigger an error that says xx1 is not a valid
biblio column. It appears that this query is just sent to DBIx. It crashes and
the Exceptions module returns 500 Something went wrong.
How is that possible? I stumble over all kinds of validation, extracting and
merging parameters etc. etc.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 --- Comment #5 from Katrin Fischer --- Looking here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30742] Confusion when placing hold on record with no items available because of not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #11 from Katrin Fischer --- Forgot to commit a last minute change - just the number of tests needed to be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 --- Comment #10 from Katrin Fischer --- Created attachment 135229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135229=edit Bug 30788: Fix number of tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #9 from David Nind --- For me, this test was failing: prove t/db_dependent/Circulation/CalcFine.t t/db_dependent/Circulation/CalcFine.t .. 1/5 # Looks like you planned 2 tests but ran 1. # Failed test 'Test with fine amount empty' # at t/db_dependent/Circulation/CalcFine.t line 142. t/db_dependent/Circulation/CalcFine.t .. 5/5 # Looks like you failed 1 test of 5. t/db_dependent/Circulation/CalcFine.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests Test Summary Report --- t/db_dependent/Circulation/CalcFine.t (Wstat: 256 Tests: 5 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=5, 4 wallclock secs ( 0.03 usr 0.01 sys + 2.78 cusr 0.26 csys = 3.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14587] Acq: Make it possible to edit asort1 and asort2 values on receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14587 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Works great and is a nice cleanup. Unit tests are present and passing and QA script is happy (now that I fixed the first commit author to match the second commit author) Going for a straight to QA on this. Passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 Martin Renvoize changed: What|Removed |Added Attachment #135226|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 135228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135228=edit Bug 30788: Unit test Run: prove t/db_dependent/Circulation/CalcFine.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30788] Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30788 Martin Renvoize changed: What|Removed |Added Attachment #135225|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 135227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135227=edit Bug 30788: Fix warning in Overdues.pm when fine is empty in circ rules Argument "" isn't numeric in multiplication (*) at /usr/share/koha/lib/C4/Overdues.pm To test: * Create a issuing rule where fine is empty, but a fine interval is set. Fine amount: empty To do this, remove the 0 displayed in the input field before saving. Fine charging interval: 5 or any other numeric value When to charge: Start of interval Fine grace period: 0 * Check out an item with the due date yester (use specify due date) * Run misc/cronjobs/fines.pl -v * You should see above warn in the output * Apply patch * Rerun fines.pl, there should be no warn. * Run: t/db_dependent/Circulation/CalcFine.t t/db_dependent/Fines.t t/db_dependent/Circulation.t t/db_dependent/Overdues.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #14) > (In reply to Marcel de Rooy from comment #13) > > Seeing this too: > > > > # Failed test 'No tests run for subtest "get() tests"' > > # at t/db_dependent/api/v1/biblios/list.t line 89. > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > > execute failed: Cannot delete or update a parent row: a foreign key > > constraint fails (`koha_myclone`.`issues`, CONSTRAINT `issues_ibfk_2` > > FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE > > CASCADE) at t/db_dependent/api/v1/biblios/list.t line 48 > > Yes, when you delete biblios there could still be issues ! You might better consider adding a few biblios without deleting them all btw. And adjusting your queries based on that situation? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30817] New: Make build_authorities_query takes QueryAutoTruncate system preference into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30817 Bug ID: 30817 Summary: Make build_authorities_query takes QueryAutoTruncate system preference into account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arn...@biblibre.com Currently authorities search (contains) queries are always truncated using SearchEngine::Elasticsearch::QueryBuilder::_truncate_terms. Truncating queries could have some negative effects on search results (i.e relevance). An interesting test plan could be: - Enable Elasticsearch search engine, - make sure you have some authorities with the following heading-main content: "jean-Charles", "Jean", "Charles", "Jean Foo", "Foo Jean", "Jean Charles" - launch the following search: Main heading contains "jean-Charles" sort by "none" - Authority with heading-main "jean-Charles" should have the highest relevance score. But this is not the case. The score seems to be altered by the wildcard. Patch is coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30790] Add REST API route to list biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30790 --- Comment #14 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #13) > Seeing this too: > > # Failed test 'No tests run for subtest "get() tests"' > # at t/db_dependent/api/v1/biblios/list.t line 89. > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > execute failed: Cannot delete or update a parent row: a foreign key > constraint fails (`koha_myclone`.`issues`, CONSTRAINT `issues_ibfk_2` > FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE > CASCADE) at t/db_dependent/api/v1/biblios/list.t line 48 Yes, when you delete biblios there could still be issues ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
