[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #14 from Martin Renvoize --- Nearly, I think the updated flag works as expected and thus reduces when the notice is sent.. the issue I had was the error count being out, not matching what our patrons actually consider an error. Putting it mathematically.. my notic filters put auto_too_soon (and splits errors and successes into two groups) So, before my notice change we have a jumbled mess of checkouts with success + errors = all checkouts that might autorenew. With my notice because I filter out the auto_too_soon items we have success (in a group) + actual errors (errors - auto_too_soon). The "errors" count doesn't match in this case. But yes... This all results in the same final conclusion.. we need a clear set of object methods instead... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #13 from Martin Renvoize --- Nearly, I think the updated flag works as expected and thus reduces when the notice is sent.. the issue I had was the error count being out, not matching what our patrons actually consider an error. Putting it mathematically.. my notic filters put auto_too_soon (and splits errors and successes into two groups) So, before my notice change we have a jumbled mess of checkouts with success + errors = all checkouts that might autorenew. With my notice because I filter out the auto_too_soon items we have success (in a group) + actual errors (errors - auto_too_soon). The "errors" count doesn't match in this case. But yes... This all results in the same final conclusion.. we need a clear set of object methods instead... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 David Cook changed: What|Removed |Added Severity|enhancement |normal --- Comment #12 from David Cook --- Changing this from enhancement to a bug, because I'd say it's definitely a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30755 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30755 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30222, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29381 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30278] Auto renewal should be moved to an object method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30278 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29381 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30278 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30755] too_soon should not be counted as an error in autorenewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30755 --- Comment #11 from David Cook --- (In reply to Martin Renvoize from comment #7) > Created attachment 135224 [details] [review] > Bug 30755: Remove auto_too_soon from error count > > This patch prevents auto_too_soon errors being counted towards auto > renew errors. Oh man... I understand now... Bug 29381 fixed this problem, but then Bug 30222 broke it again. So now here you are trying to re-fix it again... Yeah as you say I think that really brings us back to Bug 30278. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30278] Auto renewal should be moved to an object method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30278 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636
--- Comment #7 from David Cook ---
(In reply to Katrin Fischer from comment #6)
> I believe the new is_notforloan is not complete as is:
>
> * You check for the notforloan status in the item
> * You check for the notforloan of the itemtype of the item
>
> But: I think you need to use effective_itemtype here to catch itemtype on
> record level as well.
Nope. That's automagically handled by '$self->itemtype;'. See below:
=head3 itemtype
my $itemtype = $item->itemtype;
Returns Koha object for effective itemtype
=cut
sub itemtype {
my ( $self ) = @_;
return Koha::ItemTypes->find( $self->effective_itemtype );
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30636] ILS-DI shows incorrect availability when Notforloan by Itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30636 David Cook changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700
--- Comment #14 from David Cook ---
(In reply to Owen Leonard from comment #13)
> I don't understand what's going on here, which may just be me:
>
> if ( !$patron->has_permission({ borrowers => 'edit_borrowers' }) ) {
> print $input->redirect("/cgi-bin/koha/mainpage.pl");
> }
>
> But when I change a patron's password when logged in as a superlibrarian I'm
> redirected to the main page rather than back to their account.
Looks like Koha::Patron->has_permission uses C4::Auth::haspermission, which has
this line:
return $flags if $flags->{superlibrarian};
So if you're a superlibrarian then that should be returning true.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
